acts_as_featureable 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7fd7ae3319ca73121825929c08ffed994ed1da4d
-  data.tar.gz: 1b0d23f470a30c8f5a4b56f9e78064c9dec180c2
+  metadata.gz: da0913e97c15dd0b9f312c91c8b9ac0c7cbee9db
+  data.tar.gz: 61381268c7f755346dfbe4968ce6491d524a2aec
 SHA512:
-  metadata.gz: 6da70932bd2a8635194ddefa226dd36086f2a788d3c532bf94a02eabff9905b1093ec4d7216a39a6c73547babcbddbd739e5d03dd1edaee27dba2e90bd75b93c
-  data.tar.gz: 9ad74f02e91c5a73c5196e88f80b6be92250dd31b2b4981e1f2804eccebba15bd7a9fc3677b3a2f55c407130ba0b56fd6ebb8c52878cde9ffba92af51bf618ec
+  metadata.gz: 256f4f5a3b7664cea18e224e9fd75d0ef9570096c9ae9106e8e1252f0f9da1274cc4ba48a7612c977ca5b3df38a7f1ef095952c92d52b1eb42346b23d7dcda16
+  data.tar.gz: f189187baf2ae53bf9c670aedb24242690dcfa7049d26ebaf2b16c387334b1f63ecd9231bcde43e1eff16647950b707baffeb1feba9c16599e939e3239e8fa0f

data/.gitignore

@@ -14,5 +14,8 @@ rdoc
 spec/reports
 test/tmp
 test/version_tmp
+spec/dummy/log/*.log
 tmp
 .project
+spec/log/*.log
+/nbproject

data/CHANGELOG.md

@@ -1,6 +1,10 @@
+## v0.0.3
+
+* Bug fix. Always use respond_to_missing? when using method_missing?
+
 ## v0.0.2
 
-* enhancements
+* Enhancements
 	* Added categories
 	* Added validations
 	* Turned into Rails::Engine with controller (with CanCan support) and basic views
@@ -8,4 +12,4 @@
 
 ## v0.0.1
 
-* initial release
+* Initial release

data/Rakefile

@@ -1,8 +1,8 @@
 #!/usr/bin/env rake
 begin
-	require 'bundler/setup'
+  require 'bundler/setup'
 rescue LoadError
-	puts 'You must `gem install bundler` and `bundle install` to run rake tasks'
+  puts 'You must `gem install bundler` and `bundle install` to run rake tasks'
 end
 
 APP_RAKEFILE = File.expand_path("../spec/dummy/Rakefile", __FILE__)

data/acts_as_featureable.gemspec

@@ -4,26 +4,26 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'acts_as_featureable/version'
 
 Gem::Specification.new do |spec|
-	spec.name          = "acts_as_featureable"
-	spec.version       = ActsAsFeatureable::VERSION
-	spec.authors       = ["Kainage"]
-	spec.email         = ["kainage@gmail.com"]
-	spec.description   = %q{Add a feature resource to a rails app}
-	spec.summary       = %q{Creates a new polymorphic resrouce, Feature, for pulling content to a main/features page}
-	spec.homepage      = "https://github.com/kainage/acts_as_featureable"
-	spec.license       = "MIT"
+  spec.name          = "acts_as_featureable"
+  spec.version       = ActsAsFeatureable::VERSION
+  spec.authors       = ["Kainage"]
+  spec.email         = ["kainage@gmail.com"]
+  spec.description   = %q{Add a feature resource to a rails app}
+  spec.summary       = %q{Creates a new polymorphic resrouce, Feature, for pulling content to a main/features page}
+  spec.homepage      = "https://github.com/kainage/acts_as_featureable"
+  spec.license       = "MIT"
 
-	spec.files         = `git ls-files`.split($/)
-	spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-	spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-	spec.require_paths = ["lib"]
+  spec.files         = `git ls-files`.split($/)
+  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
+  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
+  spec.require_paths = ["lib"]
 
-	spec.add_dependency "rails", "~> 4.0.0.rc1"
+  spec.add_dependency "rails", "~> 4.0.0.rc1"
 
-	spec.add_development_dependency "bundler", "~> 1.3"
-	spec.add_development_dependency "rake"
-	spec.add_development_dependency "rspec"
-	spec.add_development_dependency "sqlite3"
-	spec.add_development_dependency "shoulda-matchers"
-	spec.add_development_dependency "rspec-rails"
+  spec.add_development_dependency "bundler", "~> 1.3"
+  spec.add_development_dependency "rake"
+  spec.add_development_dependency "rspec"
+  spec.add_development_dependency "sqlite3"
+  spec.add_development_dependency "shoulda-matchers"
+  spec.add_development_dependency "rspec-rails"
 end

data/app/controllers/features_controller.rb

@@ -1,90 +1,90 @@
 class FeaturesController < ApplicationController
-	authorize_resource if defined?(CanCan::Ability)
-	
-	before_filter :find_featureable
-	
-	def index
-		@features = Feature.all
-
-		respond_to do |format|
-			format.html 
-			format.json { render json: @features }
-		end
-	end
-
-	def show
-		@feature = Feature.find(params[:id])
-
-		respond_to do |format|
-			format.html 
-			format.json { render json: @feature }
-		end
-	end
-
-	def new
-		@feature = @featureable.features.build
-
-		respond_to do |format|
-			format.html
-			format.json { render json: @feature }
-		end
-	end
-
-	def edit
-		@feature = Feature.find(params[:id])
-		
-		respond_to do |format|
-			format.html
-			format.json { render json: @feature }
-		end
-	end
-
-	def create
-		@feature = @featureable.features.build(feature_params)
-		
-		respond_to do |format|
-			if @feature.save
-				format.html { redirect_to @featureable, notice: 'Feature was successfully created.' }
-				format.json { render json: @feature, status: :created, location: @feature }
-			else
-				format.html { redirect_to @featureable, alert: @feature.errors.full_messages.join(',') }
-				format.json { render json: @feature.errors, status: :unprocessable_entity }
-			end
-		end
-	end
-	
-	def update
-		@feature = Feature.find(params[:id])
-		
-		respond_to do |format|
-			if @feature.update(feature_params)
-				format.html { redirect_to @featureable, notice: 'Feature was successfully updated.' }
-				format.json { head :no_content }
-			else
-				format.html { redirect_to @featureable, alert: @feature.errors.full_messages.join(',') }
-				format.json { render json: @feature.errors, status: :unprocessable_entity }
-			end
-		end
-	end
-
-	def destroy
-		@feature = Feature.find(params[:id])
-		@feature.destroy
-
-		respond_to do |format|
-			format.html { redirect_to @featureable, notice: 'Feature was successfully removed.' }
-			format.json { head :no_content }
-		end
-	end
-
-	private
-	
-	def feature_params
-		params.require(:feature).permit(:position, :category)
-	end
-
-	def find_featureable
-		resource, id = request.path.split('/')[1, 2]
-		@featureable = resource.singularize.classify.constantize.find(id)
-	end
+  authorize_resource if defined?(CanCan::Ability)
+
+  before_filter :find_featureable
+
+  def index
+    @features = Feature.all
+
+    respond_to do |format|
+      format.html
+      format.json { render json: @features }
+    end
+  end
+
+  def show
+    @feature = Feature.find(params[:id])
+
+    respond_to do |format|
+      format.html
+      format.json { render json: @feature }
+    end
+  end
+
+  def new
+    @feature = @featureable.features.build
+
+    respond_to do |format|
+      format.html
+      format.json { render json: @feature }
+    end
+  end
+
+  def edit
+    @feature = Feature.find(params[:id])
+
+    respond_to do |format|
+      format.html
+      format.json { render json: @feature }
+    end
+  end
+
+  def create
+    @feature = @featureable.features.build(feature_params)
+
+    respond_to do |format|
+      if @feature.save
+        format.html { redirect_to @featureable, notice: 'Feature was successfully created.' }
+        format.json { render json: @feature, status: :created, location: @feature }
+      else
+        format.html { redirect_to @featureable, alert: @feature.errors.full_messages.join(',') }
+        format.json { render json: @feature.errors, status: :unprocessable_entity }
+      end
+    end
+  end
+
+  def update
+    @feature = Feature.find(params[:id])
+
+    respond_to do |format|
+      if @feature.update(feature_params)
+        format.html { redirect_to @featureable, notice: 'Feature was successfully updated.' }
+        format.json { head :no_content }
+      else
+        format.html { redirect_to @featureable, alert: @feature.errors.full_messages.join(',') }
+        format.json { render json: @feature.errors, status: :unprocessable_entity }
+      end
+    end
+  end
+
+  def destroy
+    @feature = Feature.find(params[:id])
+    @feature.destroy
+
+    respond_to do |format|
+      format.html { redirect_to @featureable, notice: 'Feature was successfully removed.' }
+      format.json { head :no_content }
+    end
+  end
+
+  private
+
+  def feature_params
+    params.require(:feature).permit(:position, :category)
+  end
+
+  def find_featureable
+    resource, id = request.path.split('/')[1, 2]
+    @featureable = resource.singularize.classify.constantize.find(id)
+  end
 end

data/app/helpers/features_helper.rb

@@ -1,9 +1,9 @@
 module FeaturesHelper
-	def feature_form_for(featureable)
-		render 'features/form', :featureable => featureable
-	end
-	
-	def features_for(featureable)
-		render 'features/features', :featureable => featureable
-	end
+  def feature_form_for(featureable)
+    render 'features/form', :featureable => featureable
+  end
+
+  def features_for(featureable)
+    render 'features/features', :featureable => featureable
+  end
 end

data/app/models/feature.rb

@@ -1,76 +1,3 @@
 class Feature < ActiveRecord::Base
-	include ActsAsFeatureable::Feature
-	
-	before_validation :assign_title, :assign_summary, :assign_position
-	
-	validate :feature_limit_not_reached, :ensure_categories
-	
-	validates_presence_of :featureable_id, :featureable_type
-	
-	validates_numericality_of :position
-		
-	private
-	
-	def ensure_categories
-		cats = ::ActsAsFeatureable::categories
-		# Allow all categories if set to false
-		if cats && self.category && !cats.include?(self.category.to_sym)
-			errors.add(:category, " is not in the list [#{cats.join(',')}]")
-		end
-	end
-	
-	def feature_limit_not_reached
-		limit = ActsAsFeatureable.feature_limit
-		errors.add(:base, 
-			"The feature limit of #{limit} has been reached. \
-			Please delete or change an existing feature."
-		) if ActsAsFeatureable.categories ? Feature.where(category: self.category).count >= limit : Feature.count >= limit
-	end
-	
-	def assign_title
-		# If there is no title given, check the model. 
-		# Will check for the attributes in ActsAsFeatureable.auto_title_assign_list.
-		
-		unless self.title
-			ActsAsFeatureable.auto_title_assign_list.each do |attr|
-				if featureable.respond_to?(attr)
-					self.title = featureable.send(attr)
-					break
-				end
-			end
-		end
-	end
-	
-	def assign_summary
-		# If there is no summary given, check the model. 
-		# Will check for the attributes in ActsAsFeatureable.auto_summary_assign_list.
-		
-		unless self.summary
-			ActsAsFeatureable.auto_summary_assign_list.each do |attr|
-				if featureable.respond_to?(attr)
-					self.summary = featureable.send(attr)
-					break
-				end
-			end
-		end
-	end
-	
-	def assign_position
-		# If there is no position given, or the position given is already taken,
-		# assign the lowest open position. Otherwise assign it.
-		all_positions = if ActsAsFeatureable.categories 
-			Feature.select('features.position, features.category').where(category: self.category).map(&:position).sort
-		else
-			Feature.select('features.position').map(&:position).sort
-		end
-		
-		if !self.position || (self.position && all_positions.include?(self.position))
-			# Find lowest, non-taken position
-			(1..ActsAsFeatureable.feature_limit).each do |n|
-				next if all_positions.include? n
-				self.position = n
-				break
-			end
-		end
-	end
+  include ActsAsFeatureable::FeatureAdditions
 end

data/app/views/features/_feature.html.erb

@@ -1,5 +1,5 @@
 <div class="feature">
-	<%= content_tag :span, feature.position, :class => 'position' %>
-	<%= content_tag :span, feature.category, :class => 'category' %>
-	<%= link_to 'Remove', [feature.featureable, feature], :method => :delete, :data => { :confirm => 'Are you sure?' } %>
+  <%= content_tag :span, feature.position, :class => 'position' %>
+  <%= content_tag :span, feature.category, :class => 'category' %>
+  <%= link_to 'Remove', [feature.featureable, feature], :method => :delete, :data => { :confirm => 'Are you sure?' } %>
 </div>

data/app/views/features/_features.html.erb

@@ -1,3 +1,3 @@
 <% featureable.features.each do |feature| %>
-	<%= render feature %>
+  <%= render feature %>
 <% end unless featureable.features.empty? %>

data/app/views/features/_form.html.erb

@@ -1,19 +1,19 @@
 <% cats = ActsAsFeatureable.categories %>
 
 <%= form_for [featureable, Feature.new] do |f| %>
-	<div class="field">
-		<%= f.label :position %>
-		<%= f.select :position, (1..ActsAsFeatureable.feature_limit) %>
-	</div>
-	
-	<div class="field">
-		<%= f.label :category%>
-		<% if cats %>
-			<%= f.select :category, cats %>
-		<% else %>
-			<%= f.text_field :category %>
-		<% end %>
-	</div>
-	
-	<%= f.submit %>
+  <div class="field">
+    <%= f.label :position %>
+    <%= f.select :position, (1..ActsAsFeatureable.feature_limit) %>
+  </div>
+
+  <div class="field">
+    <%= f.label :category%>
+    <% if cats %>
+    <%= f.select :category, cats %>
+    <% else %>
+    <%= f.text_field :category %>
+    <% end %>
+  </div>
+
+  <%= f.submit %>
 <% end %>

data/app/views/features/index.html.erb

@@ -1,3 +1,3 @@
 <% @features.each do |feature| %>
-	<%= render feature %>
+  <%= render feature %>
 <% end %>

data/lib/acts_as_featureable.rb

@@ -4,5 +4,5 @@ require 'active_support/core_ext/module/attribute_accessors'
 require 'acts_as_featureable/config'
 
 require 'acts_as_featureable/version'
-require 'acts_as_featureable/featureable_methods'
-require 'acts_as_featureable/feature_methods'
+require 'acts_as_featureable/featureable_additions'
+require 'acts_as_featureable/feature_additions'

data/lib/acts_as_featureable/config.rb

@@ -1,30 +1,30 @@
 module ActsAsFeatureable
-	# Set the maximum limit of features availible.
-	mattr_accessor :feature_limit
-	@@feature_limit = 10
-	
-	# Set the order of auto title assign
-	mattr_accessor :auto_title_assign_list
-	@@auto_title_assign_list = [:title, :name]
-	
-	# Set the order of auto summary assigning
-	mattr_accessor :auto_summary_assign_list
-	@@auto_summary_assign_list = [:summary, :caption, :tldr, :content, :text]
-	
-	# Limit the categories you wish to use.
-	# This should be an array of symbols
-	# [:main, :articles, :images]
-	#
-	# false allows unlimited categories.
-	#
-	# The benefit of using this is gaining the scopes for which categories you include.
-	#
-	# Feature.articles
-	# => [<# Feature > ,<# Feature>]
-	mattr_accessor :categories
-	@@categories = false
-	
-	def self.setup
-		yield self
-	end
+  # Set the maximum limit of features availible.
+  mattr_accessor :feature_limit
+  @@feature_limit = 10
+
+  # Set the order of auto title assign
+  mattr_accessor :auto_title_assign_list
+  @@auto_title_assign_list = [:title, :name]
+
+  # Set the order of auto summary assigning
+  mattr_accessor :auto_summary_assign_list
+  @@auto_summary_assign_list = [:summary, :caption, :tldr, :content, :text]
+
+  # Limit the categories you wish to use.
+  # This should be an array of symbols
+  # [:main, :articles, :images]
+  #
+  # false allows unlimited categories.
+  #
+  # The benefit of using this is gaining the scopes for which categories you include.
+  #
+  # Feature.articles
+  # => [<# Feature > ,<# Feature>]
+  mattr_accessor :categories
+  @@categories = false
+
+  def self.setup
+    yield self
+  end
 end