acts_as_favoritor 5.0.0 → 5.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3e0e21ccec6a8d67036d67b66db5851d554e046eb5a7d8ba592eba0a98b8ae48
-  data.tar.gz: 951039111774466e4bf8347d8e5de83af8960817b8bb934611a06b228b854198
+  metadata.gz: 2554cf505e5a47eb5f24bc1de95fb6287d397259cc70685f4905d99be6164e72
+  data.tar.gz: ac5749692ac44627c97dfb2797834671f7d3cc368d32e63aac5d2d9a94e4b6b6
 SHA512:
-  metadata.gz: 390486da05c0e6d4370b433cd6ae774371595726b376febff627dfa5c2bd1f0b154abd57ff4bf55808d4379f4bc8e20552c7d73ffdd19fe60c89e93651f050ed
-  data.tar.gz: a53d91399cb196ba971ab0170c49da2fa7b996cd65d3e1371f095049092e3f820f5740011ac90b97424b6571b64ddfccaa2e2d1bec3360f9aca3fc37aae2b940
+  metadata.gz: 544dda8f78ced970192a0d523f8c7b4804be135d33afe8635a15eaef3263d5413793d54ca5342fa12636d4a1c893b4d52bb1c160180bb72386c4a144a3280a6b
+  data.tar.gz: 28fd936df2e6dc96f6b5a2449fc654f40b4307a7d4bed58e5f648652e283af46d3547f1e3ac2245b928400d1391186fae291ff4fc1756438a14afb8c03858abe

data/README.md

@@ -4,40 +4,17 @@ acts_as_favoritor is a Rubygem to allow any ActiveRecord model to associate any
 
 You are able to differentiate followers, favorites, watchers, votes and whatever else you can imagine through a single relationship. This is accomplished by a double polymorphic relationship on the Favorite model. There is also built in support for blocking/un-blocking favorite records as well as caching.
 
----
-
-## Table of Contents
-
-- [acts_as_favoritor](#actsasfavoritor)
-  - [Table of Contents](#table-of-contents)
-  - [Installation](#installation)
-  - [Usage](#usage)
-    - [Setup](#setup)
-    - [`acts_as_favoritor` methods](#actsasfavoritor-methods)
-    - [`acts_as_favoritable` methods](#actsasfavoritable-methods)
-    - [`Favorite` model](#favorite-model)
-    - [Scopes](#scopes)
-    - [Caching](#caching)
-  - [Configuration](#configuration)
-  - [Testing](#testing)
-  - [Release](#release)
-  - [To do](#to-do)
-  - [Contributing](#contributing)
-    - [Semantic Versioning](#semantic-versioning)
-
----
-
 ## Installation
 
-acts_as_favoritor works with Rails 5.0 onwards. You can add it to your `Gemfile` with:
+You can add acts_as_favoritor to your `Gemfile` with:
 
 ```ruby
 gem 'acts_as_favoritor'
 ```
 
-And then execute:
+And then run:
 
-    $ bundle
+    $ bundle install
 
 Or install it yourself as:
 
@@ -245,8 +222,6 @@ book.favoritable_favorite_cache # => 1
 
 **Note:** These methods are available for every scope you are using.
 
----
-
 ## Configuration
 
 You can configure acts_as_favoritor by passing a block to `configure`. This can be done in `config/initializers/acts_as_favoritor.rb`:
@@ -261,51 +236,41 @@ end
 
 **`cache`** Whether `acts_as_favoritor` uses caching or not. Takes a boolean. Defaults to `false`. Learn more about caching [here](#caching).
 
----
-
-## Testing
-
-1. Fork this repository
-2. Clone your forked git locally
-3. Install dependencies
+## Development
 
-    `$ bundle install`
+To start development you first have to fork this repository and locally clone your fork.
 
-4. Run tests
+Install the projects dependencies by running:
 
-    `$ bundle exec rspec`
+    $ bundle install
 
-5. Run RuboCop
+### Testing
 
-    `$ bundle exec rubocop`
+Tests are written with RSpec and can be found in `/spec`.
 
----
+To run tests:
 
-## Release
+    $ bundle exec rspec
 
-1. Review breaking changes and deprecations in `CHANGELOG.md`
-2. Change the gem version in `lib/acts_as_favoritor/version.rb`
-3. Reset `CHANGELOG.md`
-4. Create a pull request to merge the changes into `master`
-5. After the pull request was merged, create a new release listing the breaking changes and commits on `master` since the last release.
-6. The release workflow will publish the gems to RubyGems and the GitHub Package Registry
+To run RuboCop:
 
----
+    $ bundle exec rubocop
 
-## To do
-
-We use [GitHub projects](https://github.com/jonhue/acts_as_favoritor/projects/1) to coordinate the work on this project.
-
-To propose your ideas, initiate the discussion by adding a [new issue](https://github.com/jonhue/acts_as_favoritor/issues/new).
+## Contributing
 
----
+We warmly welcome everyone who is intersted in contributing. Please reference our [contributing guidelines](CONTRIBUTING.md) and our [Code of Conduct](CODE_OF_CONDUCT.md).
 
-## Contributing
+## Releases
 
-We hope that you will consider contributing to acts_as_favoritor. Please read this short overview for some information about how to get started:
+[Here](https://github.com/jonhue/acts_as_favoritor/releases) you can find details on all past releases. Unreleased breaking changes that are on the current master can be found [here](CHANGELOG.md).
 
-[Learn more about contributing to this repository](CONTRIBUTING.md), [Code of Conduct](CODE_OF_CONDUCT.md)
+acts_as_favoritor follows Semantic Versioning 2.0 as defined at http://semver.org. Reference our [security policy](SECURITY.md).
 
-### Semantic Versioning
+### Publishing
 
-acts_as_favoritor follows Semantic Versioning 2.0 as defined at http://semver.org.
+1. Review breaking changes and deprecations in `CHANGELOG.md`.
+1. Change the gem version in `lib/acts_as_favoritor/version.rb`.
+1. Reset `CHANGELOG.md`.
+1. Create a pull request to merge the changes into `master`.
+1. After the pull request was merged, create a new release listing the breaking changes and commits on `master` since the last release.
+2. The release workflow will publish the gem to RubyGems.

data/lib/acts_as_favoritor/configuration.rb

@@ -14,8 +14,7 @@ module ActsAsFavoritor
     DEFAULT_SCOPE = :favorite
     DEFAULT_CACHE = false
 
-    attr_accessor :default_scope
-    attr_accessor :cache
+    attr_accessor :cache, :default_scope
 
     def initialize
       @default_scope = DEFAULT_SCOPE

data/lib/acts_as_favoritor/favoritable.rb

@@ -38,11 +38,13 @@ module ActsAsFavoritor
       end
       # rubocop:enable Metrics/AbcSize, Metrics/MethodLength
 
+      # rubocop:disable Style/OptionalBooleanParameter
       def respond_to_missing?(method, include_private = false)
         super || method.to_s[/(.+)_favoritors/] ||
           method.to_s[/favoritable_(.+)_score/] ||
           method.to_s[/favoritable_(.+)_total/]
       end
+      # rubocop:enable Style/OptionalBooleanParameter
 
       def favoritors(scope: ActsAsFavoritor.configuration.default_scope,
                      scopes: nil)

data/lib/acts_as_favoritor/favorite_scopes.rb

@@ -12,9 +12,11 @@ module ActsAsFavoritor
       end
     end
 
+    # rubocop:disable Style/OptionalBooleanParameter
     def respond_to_missing?(method, include_private = false)
       super || method.to_s[/(.+)_list/]
     end
+    # rubocop:enable Style/OptionalBooleanParameter
 
     def for_favoritor(favoritor)
       where(

data/lib/acts_as_favoritor/favoritor.rb

@@ -38,11 +38,13 @@ module ActsAsFavoritor
       end
       # rubocop:enable Metrics/AbcSize, Metrics/MethodLength
 
+      # rubocop:disable Style/OptionalBooleanParameter
       def respond_to_missing?(method, include_private = false)
         super || method.to_s[/favorited_(.+)/] ||
           method.to_s[/favoritor_(.+)_score/] ||
           method.to_s[/favoritor_(.+)_total/]
       end
+      # rubocop:enable Style/OptionalBooleanParameter
 
       def favorite(favoritable,
                    scope: ActsAsFavoritor.configuration.default_scope,
@@ -158,9 +160,7 @@ module ActsAsFavoritor
 
         favoritable.favoritable_score[scope] =
           (favoritable.favoritable_score[scope] || 0) - 1
-        unless favoritable.favoritable_score[scope].positive?
-          favoritable.favoritable_score.delete(scope)
-        end
+        favoritable.favoritable_score.delete(scope) unless favoritable.favoritable_score[scope].positive?
         favoritable.save!
       end
       # rubocop:enable Metrics/AbcSize

data/lib/acts_as_favoritor/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ActsAsFavoritor
-  VERSION = '5.0.0'
+  VERSION = '5.0.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: acts_as_favoritor
 version: !ruby/object:Gem::Version
-  version: 5.0.0
+  version: 5.0.1
 platform: ruby
 authors:
 - Jonas Hübotter
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-03-17 00:00:00.000000000 Z
+date: 2020-12-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -166,7 +166,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.4
 signing_key: 
 specification_version: 4
 summary: A Rubygem to add Favorite, Follow, Vote, etc. functionality to ActiveRecord