acts_as_favoritor 2.0.0 → 2.0.1

data/lib/acts_as_favoritor/railtie.rb

@@ -1,4 +1,4 @@
-require 'rails'
+require 'rails/railtie'
 
 module ActsAsFavoritor
     class Railtie < Rails::Railtie

data/lib/acts_as_favoritor/version.rb

@@ -1,5 +1,5 @@
 module ActsAsFavoritor
 
-    VERSION = '2.0.0'
+    VERSION = '2.0.1'
 
 end

data/lib/generators/templates/model.rb

@@ -3,12 +3,11 @@ class Favorite < ActiveRecord::Base
     extend ActsAsFavoritor::FavoritorLib
     extend ActsAsFavoritor::FavoriteScopes
 
-    # NOTE: Favorites belong to the 'favoritable' and 'favoritor' interface
     belongs_to :favoritable, polymorphic: true
     belongs_to :favoritor, polymorphic: true
 
     def block!
-        self.update_attribute :blocked, true
+        self.update_attributes blocked: true
     end
 
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: acts_as_favoritor
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.0.1
 platform: ruby
 authors:
 - Jonas Hübotter
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-21 00:00:00.000000000 Z
+date: 2018-01-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -119,21 +119,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".github/issue_template.md"
-- ".github/pull_request_template.md"
-- ".gitignore"
-- ".travis.yml"
 - CHANGELOG.md
-- CODE_OF_CONDUCT.md
-- CONTRIBUTING.md
-- DEPRECATIONS.md
-- Gemfile
-- INSTALL.md
 - LICENSE
 - README.md
-- Rakefile
-- acts_as_favoritor.gemspec
-- init.rb
 - lib/acts_as_favoritor.rb
 - lib/acts_as_favoritor/configuration.rb
 - lib/acts_as_favoritor/favoritable.rb
@@ -147,35 +135,6 @@ files:
 - lib/generators/templates/initializer.rb
 - lib/generators/templates/migration.rb.erb
 - lib/generators/templates/model.rb
-- test/acts_as_favoritable_test.rb
-- test/acts_as_favoritor_test.rb
-- test/dummy30/Gemfile
-- test/dummy30/Rakefile
-- test/dummy30/app/models/application_record.rb
-- test/dummy30/app/models/band.rb
-- test/dummy30/app/models/band/punk.rb
-- test/dummy30/app/models/band/punk/pop_punk.rb
-- test/dummy30/app/models/custom_record.rb
-- test/dummy30/app/models/some.rb
-- test/dummy30/app/models/user.rb
-- test/dummy30/config.ru
-- test/dummy30/config/application.rb
-- test/dummy30/config/boot.rb
-- test/dummy30/config/database.yml
-- test/dummy30/config/environment.rb
-- test/dummy30/config/environments/development.rb
-- test/dummy30/config/environments/test.rb
-- test/dummy30/config/initializers/acts_as_favoritor.rb
-- test/dummy30/config/initializers/secret_token.rb
-- test/dummy30/config/initializers/session_store.rb
-- test/dummy30/config/locales/en.yml
-- test/dummy30/config/routes.rb
-- test/factories/bands.rb
-- test/factories/somes.rb
-- test/factories/users.rb
-- test/favorite_test.rb
-- test/schema.rb
-- test/test_helper.rb
 homepage: https://github.com/jonhue/acts_as_favoritor
 licenses:
 - MIT
@@ -199,7 +158,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.3
+rubygems_version: 2.7.4
 signing_key: 
 specification_version: 4
 summary: A Rubygem to add Favorite, Follow, Vote, etc. functionality to ActiveRecord

data/.github/issue_template.md

@@ -1,14 +0,0 @@
-### Expected behavior
-Tell us what should happen
-
-### Actual behavior
-Tell us what happens instead
-
-### Steps to reproduce
-Show a way to reproduce
-
-### System configuration
-
-**Ruby version**:
-
-**Rails version**:

data/.github/pull_request_template.md

@@ -1,21 +0,0 @@
-### Summary
-
-Provide a general description of the code changes in your pull
-request... were there any bugs you had fixed? If so, mention them. If
-these bugs have open GitHub issues, be sure to tag them here as well,
-to keep the conversation linked together.
-
-### Other Information
-
-If there's anything else that's important and relevant to your pull
-request, mention that information here. This could include
-benchmarks, or other information.
-
-If you are updating any of the CHANGELOG files or are asked to update the
-CHANGELOG files by reviewers, please add the CHANGELOG entry at the top of the file.
-
-Finally, if your pull request affects documentation or any non-code
-changes, guidelines for those changes are [available
-here](https://github.com/jonhue/acts_as_favoritor/blob/master/CONTRIBUTING.md)
-
-Thanks for contributing to acts_as_favoritor!

data/.gitignore

@@ -1,8 +0,0 @@
-test/debug.log
-coverage
-rdoc
-memory
-*.gem
-.rvmrc
-Gemfile.lock
-log

data/.travis.yml

@@ -1,3 +0,0 @@
-language: ruby
-rvm:
-    - 2.3.3

data/CODE_OF_CONDUCT.md

@@ -1,46 +0,0 @@
-# Contributor Covenant Code of Conduct
-
-## Our Pledge
-
-In the interest of fostering an open and welcoming environment, we as contributors and maintainers pledge to making participation in our project and our community a harassment-free experience for everyone, regardless of age, body size, disability, ethnicity, gender identity and expression, level of experience, nationality, personal appearance, race, religion, or sexual identity and orientation.
-
-## Our Standards
-
-Examples of behavior that contributes to creating a positive environment include:
-
-* Using welcoming and inclusive language
-* Being respectful of differing viewpoints and experiences
-* Gracefully accepting constructive criticism
-* Focusing on what is best for the community
-* Showing empathy towards other community members
-
-Examples of unacceptable behavior by participants include:
-
-* The use of sexualized language or imagery and unwelcome sexual attention or advances
-* Trolling, insulting/derogatory comments, and personal or political attacks
-* Public or private harassment
-* Publishing others' private information, such as a physical or electronic address, without explicit permission
-* Other conduct which could reasonably be considered inappropriate in a professional setting
-
-## Our Responsibilities
-
-Project maintainers are responsible for clarifying the standards of acceptable behavior and are expected to take appropriate and fair corrective action in response to any instances of unacceptable behavior.
-
-Project maintainers have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct, or to ban temporarily or permanently any contributor for other behaviors that they deem inappropriate, threatening, offensive, or harmful.
-
-## Scope
-
-This Code of Conduct applies both within project spaces and in public spaces when an individual is representing the project or its community. Examples of representing a project or community include using an official project e-mail address, posting via an official social media account, or acting as an appointed representative at an online or offline event. Representation of a project may be further defined and clarified by project maintainers.
-
-## Enforcement
-
-Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by contacting the project team at help@slooob.com. The project team will review and investigate all complaints, and will respond in a way that it deems appropriate to the circumstances. The project team is obligated to maintain confidentiality with regard to the reporter of an incident. Further details of specific enforcement policies may be posted separately.
-
-Project maintainers who do not follow or enforce the Code of Conduct in good faith may face temporary or permanent repercussions as determined by other members of the project's leadership.
-
-## Attribution
-
-This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4, available at [http://contributor-covenant.org/version/1/4][version]
-
-[homepage]: http://contributor-covenant.org
-[version]: http://contributor-covenant.org/version/1/4/

data/CONTRIBUTING.md

@@ -1 +0,0 @@
-# Contributing

data/DEPRECATIONS.md

@@ -1,5 +0,0 @@
-# Deprecations
-
-### 2.0.0 - 2017-12-21
-
-* `config/acts_as_favoritor.yml` file replaced by initializer

data/Gemfile

@@ -1,9 +0,0 @@
-source 'http://rubygems.org'
-
-gemspec
-
-
-gem 'activesupport', ENV['RAILS_VERSION'] if ENV['RAILS_VERSION']
-
-# # Test Coverage
-# gem 'simplecov', require: false, group: :test

data/INSTALL.md

@@ -1,3 +0,0 @@
-**Thank you for installing acts_as_favoritor!**
-Get started by running `rails g acts_as_favoritor`.
-Learn more at https://github.com/jonhue/acts_as_favoritor.

data/Rakefile

@@ -1,16 +0,0 @@
-require 'bundler'
-Bundler::GemHelper.install_tasks
-
-require 'rake'
-require 'rake/testtask'
-require 'rdoc/task'
-
-desc 'Default: run unit tests.'
-task default: :test
-
-desc 'Test the acts_as_favoritor gem.'
-Rake::TestTask.new(:test) do |t|
-    t.libs << 'lib'
-    t.pattern = 'test/**/*_test.rb'
-    t.verbose = true
-end

data/acts_as_favoritor.gemspec

@@ -1,30 +0,0 @@
-# -*- encoding: utf-8 -*-
-require File.expand_path(File.join('..', 'lib', 'acts_as_favoritor', 'version'), __FILE__)
-
-Gem::Specification.new do |gem|
-    gem.name                  = 'acts_as_favoritor'
-    gem.version               = ActsAsFavoritor::VERSION
-    gem.platform              = Gem::Platform::RUBY
-    gem.summary               = 'A Rubygem to add Favorite, Follow, Vote, etc. functionality to ActiveRecord models'
-    gem.description           = 'acts_as_favoritor is a Rubygem to allow any ActiveRecord model to associate any other model including the option for multiple relationships per association with scopes. You are able to differentiate followers, favorites, watchers, votes and whatever else you can imagine through a single relationship. This is accomplished by a double polymorphic relationship on the Favorite model. There is also built in support for blocking/un-blocking favorite records as well as caching.'
-    gem.authors               = 'Jonas Hübotter'
-    gem.email                 = 'jonas.huebotter@gmail.com'
-    gem.homepage              = 'https://github.com/jonhue/acts_as_favoritor'
-    gem.license               = 'MIT'
-
-    gem.files                 = `git ls-files`.split("\n")
-    gem.require_paths         = ['lib']
-
-    gem.post_install_message  = IO.read('INSTALL.md')
-
-    gem.required_ruby_version = '>= 2.3'
-
-    gem.add_dependency 'activerecord', '>= 5.0'
-
-    gem.add_development_dependency 'sqlite3', '~> 1.3'
-    gem.add_development_dependency 'shoulda_create', '~> 0.0'
-    gem.add_development_dependency 'shoulda', '~> 3.5'
-    gem.add_development_dependency 'factory_girl', '~> 4.8'
-    gem.add_development_dependency 'rails', '>= 5.0'
-    gem.add_development_dependency 'tzinfo-data', '~> 1.2017'
-end

data/init.rb

@@ -1 +0,0 @@
-require 'acts_as_favoritor'

data/test/acts_as_favoritable_test.rb

@@ -1,283 +0,0 @@
-require File.dirname(__FILE__) + '/test_helper'
-
-class ActsAsFavoritableTest < ActiveSupport::TestCase
-
-    context 'instance methods' do
-        setup do
-            @sam = FactoryGirl.create :sam
-        end
-
-        should 'be defined' do
-            assert @sam.respond_to? :favoritors_count
-            assert @sam.respond_to? :favoritors
-            assert @sam.respond_to? :favorited_by?
-        end
-    end
-
-    context 'acts_as_favoritable' do
-        setup do
-            @sam = FactoryGirl.create :sam
-            @jon = FactoryGirl.create :jon
-            @oasis = FactoryGirl.create :oasis
-            @metallica = FactoryGirl.create :metallica
-            @green_day = FactoryGirl.create :green_day
-            @blink_182 = FactoryGirl.create :blink_182
-            @sam.favorite @jon
-        end
-
-        context 'favoritors_count' do
-            should 'return the number of favoritors' do
-                assert_equal 0, @sam.favoritors_count
-                assert_equal 1, @jon.favoritors_count
-            end
-
-            should 'return the proper number of multiple favoritors' do
-                @bob = FactoryGirl.create :bob
-                @sam.favorite @bob
-                assert_equal 0, @sam.favoritors_count
-                assert_equal 1, @jon.favoritors_count
-                assert_equal 1, @bob.favoritors_count
-            end
-        end
-
-        context 'favoritors' do
-            should 'return users' do
-                assert_equal [], @sam.favoritors
-                assert_equal [@sam], @jon.favoritors
-            end
-
-            should 'return users (multiple favoritors)' do
-                @bob = FactoryGirl.create :bob
-                @sam.favorite @bob
-                assert_equal [], @sam.favoritors
-                assert_equal [@sam], @jon.favoritors
-                assert_equal [@sam], @bob.favoritors
-            end
-
-            should 'return users (multiple favoritors, complex)' do
-                @bob = FactoryGirl.create :bob
-                @sam.favorite @bob
-                @jon.favorite @bob
-                assert_equal [], @sam.favoritors
-                assert_equal [@sam], @jon.favoritors
-                assert_equal [@sam, @jon], @bob.favoritors
-            end
-
-            should 'accept AR options' do
-                @bob = FactoryGirl.create :bob
-                @bob.favorite @jon
-                assert_equal 1, @jon.favoritors(limit: 1).count
-            end
-        end
-
-        context 'favorited_by' do
-            should 'return_favoritor_status' do
-                assert_equal true, @jon.favorited_by?(@sam)
-                assert_equal false, @sam.favorited_by?(@jon)
-            end
-        end
-
-        context 'destroying a favoritable' do
-            setup do
-                @jon.destroy
-            end
-
-            should_change('Favorite count', by: -1) { Favorite.count }
-            should_change('@sam.all_favorited.size', by: -1) { @sam.all_favorited.size }
-        end
-
-        context 'get favorite record' do
-            setup do
-                @bob = FactoryGirl.create :bob
-                @favorite = @bob.favorite @sam
-            end
-
-            should 'return favorite record' do
-                assert_equal @favorite, @sam.get_favorite_for(@bob)
-            end
-
-            should 'return nil' do
-                assert_nil @sam.get_favorite_for(@jon)
-            end
-        end
-
-        context 'blocks' do
-            setup do
-        @bob = FactoryGirl.create :bob
-        @jon.block @sam
-        @jon.block @bob
-        end
-
-        should 'accept AR options' do
-            assert_equal 1, @jon.blocks(limit: 1).count
-        end
-        end
-
-        context 'blocking a favoritor' do
-            context 'in my favorited list' do
-                setup do
-                    @jon.block @sam
-                end
-
-                should 'remove him from favoritors' do
-                    assert_equal 0, @jon.favoritors_count
-                end
-
-                should 'add him to the blocked favoritors' do
-                    assert_equal 1, @jon.blocked_favoritors_count
-                end
-
-                should 'not be able to favorite again' do
-                    @jon.favorite @sam
-                    assert_equal 0, @jon.favoritors_count
-                end
-
-                should 'not be present when listing favoritors' do
-                    assert_equal [], @jon.favoritors
-                end
-
-                should 'be in the list of blocks' do
-                    assert_equal [@sam], @jon.blocks
-                end
-            end
-
-            context 'not in my favorited list' do
-                setup do
-                    @sam.block @jon
-                end
-
-                should 'add him to the blocked favoritors' do
-                    assert_equal 1, @sam.blocked_favoritors_count
-                end
-
-                should 'not be able to favorite again' do
-                    @sam.favorite @jon
-                    assert_equal 0, @sam.favoritors_count
-                end
-
-                should 'not be present when listing favoritors' do
-                    assert_equal [], @sam.favoritors
-                end
-
-                should 'be in the list of blocks' do
-                    assert_equal [@jon], @sam.blocks
-                end
-            end
-        end
-
-        context 'unblocking a blocked favorite' do
-            setup do
-                @jon.block @sam
-                @jon.unblock @sam
-            end
-
-            should 'not include the unblocked user in the list of favoritors' do
-                assert_equal [], @jon.favoritors
-            end
-
-            should 'remove him from the blocked favoritors' do
-                assert_equal 0, @jon.blocked_favoritors_count
-                assert_equal [], @jon.blocks
-            end
-        end
-
-        context 'unblock a non-existent favorite' do
-            setup do
-                @sam.remove_favorite @jon
-                @jon.unblock @sam
-            end
-
-            should 'not be in the list of favoritors' do
-                assert_equal [], @jon.favoritors
-            end
-
-            should 'not be in the blocked favoritors count' do
-                assert_equal 0, @jon.blocked_favoritors_count
-            end
-
-            should 'not be in the blocks list' do
-                assert_equal [], @jon.blocks
-            end
-        end
-
-        context 'favoritors_by_type' do
-            setup do
-                @sam.favorite @oasis
-                @jon.favorite @oasis
-            end
-
-            should 'return the favoritors for given type' do
-                assert_equal [@sam], @jon.favoritors_by_type('User')
-                assert_equal [@sam, @jon], @oasis.favoritors_by_type('User')
-            end
-
-            should 'not return block favoritors in the favoritors for a given type' do
-                @oasis.block @jon
-                assert_equal [@sam], @oasis.favoritors_by_type('User')
-            end
-
-            should 'return the count for favoritors_by_type_count for a given type' do
-                assert_equal 1, @jon.favoritors_by_type_count('User')
-                assert_equal 2, @oasis.favoritors_by_type_count('User')
-            end
-
-            should 'not count blocked favorites in the count' do
-                @oasis.block @sam
-                assert_equal 1, @oasis.favoritors_by_type_count('User')
-            end
-        end
-
-        context 'favoritors_with_sti' do
-            setup do
-                @sam.favorite @green_day
-                @sam.favorite @blink_182
-            end
-
-            should 'return the favoritors for given type' do
-                assert_equal @sam.favorites_by_type('Band').first&.favoritable, @green_day.becomes(Band)
-                assert_equal @sam.favorites_by_type('Band').second&.favoritable, @blink_182.becomes(Band)
-                assert @green_day.favoritors_by_type('User').include?(@sam)
-                assert @blink_182.favoritors_by_type('User').include?(@sam)
-            end
-        end
-
-        context 'method_missing' do
-            setup do
-                @sam.favorite @oasis
-                @jon.favorite @oasis
-            end
-
-            should 'return the favoritors for given type' do
-                assert_equal [@sam], @jon.user_favoritors
-                assert_equal [@sam, @jon], @oasis.user_favoritors
-            end
-
-            should 'not return block favoritors in the favoritors for a given type' do
-                @oasis.block @jon
-                assert_equal [@sam], @oasis.user_favoritors
-            end
-
-            should 'return the count for favoritors_by_type_count for a given type' do
-                assert_equal 1, @jon.count_user_favoritors
-                assert_equal 2, @oasis.count_user_favoritors
-            end
-
-            should 'not count blocked favorites in the count' do
-                @oasis.block @sam
-                assert_equal 1, @oasis.count_user_favoritors
-            end
-        end
-
-        context 'respond_to?' do
-            should 'advertise that it responds to favorited methods' do
-                assert @oasis.respond_to?(:user_favoritors)
-                assert @oasis.respond_to?(:user_favoritors_count)
-            end
-
-            should 'return false when called with a nonexistent method' do
-                assert (not @oasis.respond_to?(:foobar))
-            end
-        end
-
-    end
-end