acts_as_favoritor 1.0.0 → 1.0.1

data/test/acts_as_favoritor_test.rb

@@ -0,0 +1,224 @@
+require File.dirname(__FILE__) + '/test_helper'
+
+class ActsAsFavoritorTest < ActiveSupport::TestCase
+
+    context 'instance methods' do
+        setup do
+            @sam = FactoryGirl.create :sam
+        end
+
+        should 'be defined' do
+            assert @sam.respond_to? :favorited?
+            assert @sam.respond_to? :favorite_count
+            assert @sam.respond_to? :favorite
+            assert @sam.respond_to? :remove_favorite
+            assert @sam.respond_to? :favorites_by_type
+            assert @sam.respond_to? :all_favorites
+        end
+    end
+
+    context 'acts_as_favoritor' do
+        setup do
+            @sam = FactoryGirl.create :sam
+            @jon = FactoryGirl.create :jon
+            @oasis = FactoryGirl.create :oasis
+            @sam.favorite @jon
+            @sam.favorite @oasis
+        end
+
+        context 'favorited' do
+            should 'return favorited_status' do
+                assert_equal true, @sam.favorited? @jon
+                assert_equal false, @jon.favorited? @sam
+            end
+
+            should 'return favorite_count' do
+                assert_equal 2, @sam.favorite_count
+                assert_equal 0, @jon.favorite_count
+            end
+        end
+
+        context 'favorite a friend' do
+            setup do
+                @jon.favorite @sam
+            end
+
+            should_change('Favorite count', by: 1) { Favorite.count }
+            should_change('@jon.favorite_count', by: 1) { @jon.favorite_count }
+
+            should "set the favoritor" do
+                assert_equal @jon, Favorite.last.favoritor
+            end
+
+            should "set the favoritable" do
+                assert_equal @sam, Favorite.last.favoritable
+            end
+        end
+
+        context "favorite yourself" do
+            setup do
+                @jon.favorite @jon
+            end
+
+            should_not_change('Favorite count') { Favorite.count }
+            should_not_change('@jon.favorite_count') { @jon.favorite_count }
+
+            should 'not set the favoritor' do
+                assert_not_equal @jon, Favorite.last.favoritor
+            end
+
+            should 'not set the favoritable' do
+                assert_not_equal @jon, Favorite.last.favoritable
+            end
+        end
+
+        context 'remove_favorite' do
+            setup do
+                @sam.remove_favorite @jon
+            end
+
+            should_change('Favorite count', by: -1) { Favorite.count }
+            should_change('@sam.favorite_count', by: -1) { @sam.favorite_count }
+        end
+
+        context 'favorites' do
+            setup do
+                @band_favorite = Favorite.where('favoritor_id = ? and favoritor_type = "User" and favoritable_id = ? and favoritable_type = "Band"', @sam.id, @oasis.id).first
+                @user_favorite = Favorite.where('favoritor_id = ? and favoritor_type = "User" and favoritable_id = ? and favoritable_type = "User"', @sam.id, @jon.id).first
+            end
+
+            context 'favorites_by_type' do
+                should 'only return requested favorites' do
+                    assert_equal [@band_favorite], @sam.favorites_by_type('Band')
+                    assert_equal [@user_favorite], @sam.favorites_by_type('User')
+                end
+
+                should 'accept AR options' do
+                    @metallica = FactoryGirl.create :metallica
+                    @sam.favorite @metallica
+                    assert_equal 1, @sam.favorites_by_type('Band', limit: 1).count
+                end
+            end
+
+            context 'favorited_by_type_count' do
+                should 'return the count of the requested type' do
+                    @metallica = FactoryGirl.create :metallica
+                    @sam.favorite @metallica
+                    assert_equal 2, @sam.favorited_by_type_count('Band')
+                    assert_equal 1, @sam.favorited_by_type_count('User')
+                    assert_equal 0, @jon.favorited_by_type_count('Band')
+                    @jon.block @sam
+                    assert_equal 0, @sam.favorited_by_type_count('User')
+                end
+            end
+
+            context 'all_favorites' do
+                should 'return all favorites' do
+                    assert_equal 2, @sam.all_favorites.size
+                    assert @sam.all_favorites.include?(@band_favorite)
+                    assert @sam.all_favorites.include?(@user_favorite)
+                    assert_equal [], @jon.all_favorites
+                end
+
+                should 'accept AR options' do
+                    assert_equal 1, @sam.all_favorites(limit: 1).count
+                end
+            end
+        end
+
+        context 'all_favorited' do
+            should 'return the actual favorite records' do
+                assert_equal 2, @sam.all_favorited.size
+                assert @sam.all_favorited.include?(@oasis)
+                assert @sam.all_favorited.include?(@jon)
+                assert_equal [], @jon.all_favorited
+            end
+
+            should 'accept AR limit option' do
+                assert_equal 1, @sam.all_favorited(limit: 1).count
+            end
+
+            should 'accept AR where option' do
+                assert_equal 1, @sam.all_favorited(where: { id: @oasis.id }).count
+            end
+        end
+
+        context 'favorited_by_type' do
+            should 'return only requested records' do
+                assert_equal [@oasis], @sam.favorited_by_type('Band')
+                assert_equal [@jon], @sam.favorited_by_type('User')
+            end
+
+            should 'accept AR options' do
+                @metallica = FactoryGirl.create :metallica
+                @sam.favorite @metallica
+                assert_equal 1, @sam.favorited_by_type('Band', limit: 1).to_a.size
+            end
+        end
+
+        context 'method_missing' do
+            should 'call favorited_by_type' do
+                assert_equal [@oasis], @sam.favorited_bands
+                assert_equal [@jon], @sam.favorited_users
+            end
+
+            should 'call favorited_by_type_count' do
+                @metallica = FactoryGirl.create :metallica
+                @sam.favorite @metallica
+                assert_equal 2, @sam.favorited_bands_count
+                assert_equal 1, @sam.favorited_users_count
+                assert_equal 0, @jon.favorited_bands_count
+                @jon.block @sam
+                assert_equal 0, @sam.favorited_users_count
+            end
+
+            should 'raise on no method' do
+                assert_raises (NoMethodError) { @sam.foobar }
+            end
+        end
+
+        context 'respond_to?' do
+            should 'advertise that it responds to favorited methods' do
+                assert @sam.respond_to?(:favorited_users)
+                assert @sam.respond_to?(:favorited_users_count)
+            end
+
+            should 'return false when called with a nonexistent method' do
+                assert (not @sam.respond_to?(:foobar))
+            end
+        end
+
+        context 'destroying favoritor' do
+            setup do
+                @jon.destroy
+            end
+
+            should_change('Favorite.count', by: -1) { Favorite.count }
+            should_change('@sam.favorite_count', by: -1) { @sam.favorite_count }
+        end
+
+        context "blocked by favoritable" do
+            setup do
+                @jon.block @sam
+            end
+
+            should 'return favorited_status' do
+                assert_equal false, @sam.favorited?(@jon)
+            end
+
+            should 'return favorite_count' do
+                assert_equal 1, @sam.favorite_count
+            end
+
+            should 'not return record of the blocked favorites' do
+                assert_equal 1, @sam.all_favorites.size
+                assert !@sam.all_favorites.include?(@user_favorite)
+                assert !@sam.all_favorited.include?(@jon)
+                assert_equal [], @sam.favorited_by_type('User')
+                assert_equal [], @sam.favorites_by_type('User')
+                assert_equal [], @sam.favorited_users
+            end
+        end
+    end
+
+end

data/test/dummy30/Rakefile

@@ -1,6 +1,3 @@
-# Add your own tasks in files placed in lib/tasks ending in .rake,
-# for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
-
 require File.expand_path '../config/application', __FILE__
 require 'rake'
 

data/test/dummy30/config.ru

@@ -1,4 +1,2 @@
-# This file is used by Rack-based servers to start the application.
-
 require ::File.expand_path '../config/environment', __FILE__
 run Dummy::Application

data/test/dummy30/config/application.rb

@@ -8,35 +8,7 @@ require 'acts_as_favoritor'
 
 module Dummy
     class Application < Rails::Application
-        # Settings in config/environments/* take precedence over those specified here.
-        # Application configuration should go into files in config/initializers
-        # -- all .rb files in that directory are automatically loaded.
-
-        # Custom directories with classes and modules you want to be autoloadable.
-        # config.autoload_paths += %W(#{config.root}/extras)
-
-        # Only load the plugins named here, in the order given (default is alphabetical).
-        # :all can be used as a placeholder for all plugins not explicitly named.
-        # config.plugins = [ :exception_notification, :ssl_requirement, :all ]
-
-        # Activate observers that should always be running.
-        # config.active_record.observers = :cacher, :garbage_collector, :forum_observer
-
-        # Set Time.zone default to the specified zone and make Active Record auto-convert to this zone.
-        # Run "rake -D time" for a list of tasks for finding time zone names. Default is UTC.
-        # config.time_zone = 'Central Time (US & Canada)'
-
-        # The default locale is :en and all translations from config/locales/*.rb,yml are auto loaded.
-        # config.i18n.load_path += Dir[Rails.root.join('my', 'locales', '*.{rb,yml}').to_s]
-        # config.i18n.default_locale = :de
-
-        # JavaScript files you want as :defaults (application.js is always included).
-        # config.action_view.javascript_expansions[:defaults] = %w(jquery rails)
-
-        # Configure the default encoding used in templates for Ruby 1.9.
         config.encoding = 'utf-8'
-
-        # Configure sensitive parameters which will be filtered from the log file.
         config.filter_parameters += [:password]
     end
 end

data/test/dummy30/config/environments/development.rb

@@ -1,18 +1,6 @@
 Dummy::Application.configure do
-    # Settings specified here will take precedence over those in config/application.rb
-
-    # In the development environment your application's code is reloaded on
-    # every request.  This slows down response time but is perfect for development
-    # since you don't have to restart the webserver when you make code changes.
     config.cache_classes = false
-
-    # Log error messages when you accidentally call methods on nil.
     config.whiny_nils = true
-
-    # Show full error reports and disable caching
     config.consider_all_requests_local = true
-
-    # Print deprecation notices to the Rails logger
     config.active_support.deprecation = :log
-
 end

data/test/dummy30/config/environments/test.rb

@@ -1,20 +1,5 @@
 Dummy::Application.configure do
-    # Settings specified here will take precedence over those in config/application.rb
-
-    # The test environment is used exclusively to run your application's
-    # test suite.  You never need to work with it otherwise.  Remember that
-    # your test database is "scratch space" for the test suite and is wiped
-    # and recreated between test runs.  Don't rely on the data there!
     config.cache_classes = true
-
-    # Show full error reports and disable caching
     config.consider_all_requests_local = true
-
-    # Use SQL instead of Active Record's schema dumper when creating the test database.
-    # This is necessary if your schema can't be completely dumped by the schema dumper,
-    # like if you have constraints or database-specific column types
-    # config.active_record.schema_format = :sql
-
-    # Print deprecation notices to the stderr
     config.active_support.deprecation = :stderr
 end

data/test/dummy30/config/initializers/secret_token.rb

@@ -1,7 +1 @@
-# Be sure to restart your server when you modify this file.
-
-# Your secret key for verifying the integrity of signed cookies.
-# If you change this key, all old signed cookies will become invalid!
-# Make sure the secret is at least 30 characters and all random,
-# no regular words or you'll be exposed to dictionary attacks.
 Dummy::Application.config.secret_token = '7b0ce915dc4c2ee60581c2769798abb5e4078292ad23670fc8d728953fc13aec19863558873234816b58a54f6a35be58b2b0a26749a7dfddcd2f02ee82d7e94f'

data/test/dummy30/config/initializers/session_store.rb

@@ -1,8 +1 @@
-# Be sure to restart your server when you modify this file.
-
 Dummy::Application.config.session_store :cookie_store, key: '_dummy_session'
-
-# Use the database for sessions instead of the cookie-based default,
-# which shouldn't be used to store highly confidential information
-# (create the session table with "rails generate session_migration")
-# Dummy::Application.config.session_store :active_record_store

data/test/dummy30/config/locales/en.yml

@@ -1,5 +1,2 @@
-# Sample localization file for English. Add more files in this directory for other locales.
-# See http://github.com/svenfuchs/rails-i18n/tree/master/rails%2Flocale for starting points.
-
 en:
   hello: 'Hello world'

data/test/favorite_test.rb

@@ -0,0 +1,28 @@
+require File.dirname(__FILE__) + '/test_helper'
+
+class FavoriteTest < ActiveSupport::TestCase
+
+    # Replace with real tests
+    def test_assert_true_should_be_true
+        assert true
+    end
+
+    context 'configuration with setters' do
+        should 'contain custom parents' do
+            ActsAsFavoritor.custom_parent_classes = [CustomRecord]
+
+            assert_equal [CustomRecord], ActsAsFavoritor.custom_parent_classes
+        end
+    end
+
+    context '#setup' do
+        should 'contain custom parents via setup' do
+            ActsAsFavoritor.setup do |c|
+                c.custom_parent_classes = [CustomRecord]
+            end
+
+            assert_equal [CustomRecord], ActsAsFavoritor.custom_parent_classes
+        end
+    end
+
+end

data/test/schema.rb

@@ -1,10 +1,11 @@
 ActiveRecord::Schema.define version: 0 do
 
-    create_table :follows, force: true do |t|
-        t.integer  'followable_id', null: false
-        t.string   'followable_type', null: false
-        t.integer  'follower_id', null: false
-        t.string   'follower_type', null: false
+    create_table :favorites, force: true do |t|
+        t.integer  'favoritable_id', null: false
+        t.string   'favoritable_type', null: false
+        t.integer  'favoritor_id', null: false
+        t.string   'favoritor_type', null: false
+        t.string   'lists', default: [:favorites].to_yaml, null: false
         t.boolean  'blocked', default: false, null: false
         t.datetime 'created_at'
         t.datetime 'updated_at'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: acts_as_favoritor
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Jonas Hübotter
@@ -30,56 +30,56 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1'
+        version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1'
+        version: '1.3'
 - !ruby/object:Gem::Dependency
   name: shoulda_create
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.0'
 - !ruby/object:Gem::Dependency
   name: shoulda
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3'
+        version: '3.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3'
+        version: '3.5'
 - !ruby/object:Gem::Dependency
   name: factory_girl
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4'
+        version: '4.8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4'
+        version: '4.8'
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
@@ -106,7 +106,9 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".travis.yml"
+- CHANGELOG.md
 - Gemfile
+- Gemfile.lock
 - LICENSE
 - README.md
 - Rakefile
@@ -120,12 +122,12 @@ files:
 - lib/acts_as_favoritor/railtie.rb
 - lib/acts_as_favoritor/version.rb
 - lib/generators/USAGE
-- lib/generators/acts_as_follower_generator.rb
+- lib/generators/acts_as_favoritor_generator.rb
 - lib/generators/templates/migration.rb.erb
 - lib/generators/templates/model.rb
 - test/README
-- test/acts_as_followable_test.rb
-- test/acts_as_follower_test.rb
+- test/acts_as_favoritable_test.rb
+- test/acts_as_favoritor_test.rb
 - test/dummy30/Gemfile
 - test/dummy30/Rakefile
 - test/dummy30/app/models/application_record.rb
@@ -142,8 +144,6 @@ files:
 - test/dummy30/config/environment.rb
 - test/dummy30/config/environments/development.rb
 - test/dummy30/config/environments/test.rb
-- test/dummy30/config/initializers/backtrace_silencers.rb
-- test/dummy30/config/initializers/inflections.rb
 - test/dummy30/config/initializers/secret_token.rb
 - test/dummy30/config/initializers/session_store.rb
 - test/dummy30/config/locales/en.yml
@@ -151,7 +151,7 @@ files:
 - test/factories/bands.rb
 - test/factories/somes.rb
 - test/factories/users.rb
-- test/follow_test.rb
+- test/favorite_test.rb
 - test/schema.rb
 - test/test_helper.rb
 homepage: https://github.com/slooob/acts_as_favoritor
@@ -166,14 +166,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: acts_as_follower
+rubyforge_project: 
 rubygems_version: 2.6.12
 signing_key: 
 specification_version: 4