acts_as_background_solr 0.5 → 0.5.1

data/README

@@ -27,6 +27,13 @@ Use this in place of acts_as_solr as in your models, e.g.
 
   acts_as_background_solr
 
+Example:
+
+  require 'acts_as_background_solr'
+  class User < ActiveRecord::Base
+    acts_as_background_solr
+  end
+
 The options :background, :if and :auto_commit will be automatically
 overridden.
 

data/history.txt

@@ -0,0 +1,4 @@
+0.5.1
+
+  * Fix bugs in argument parsing related to do_optimize and do_commit
+    in SolrBatch.process_all. Thanks to pablo@handwire.com.

data/lib/solr_batch.rb

@@ -11,7 +11,7 @@ class SolrBatch
       models.each do |model|
         klass = eval(model)
         first_klass = klass unless first_klass
-        SolrBatch.sync_pending_records(klass, { :do_commit => false, :do_optimize => true })
+        SolrBatch.sync_pending_records(klass, { :do_commit => false, :do_optimize => false })
       end
 
       ## Commit/optimize after ALL records have been processed
@@ -41,10 +41,11 @@ class SolrBatch
   # Ex: from within ActiveRecord Model, call:
   # SolrBatch.sync_pending_records(self, { :batch_size => 500 } );
   def SolrBatch.sync_pending_records(ar_model, opts = {}, iteration=1)
+    opts = { :batch_size => 500, :do_commit => true, :do_optimize => true }.merge(opts)
     batch_size = opts.delete(:batch_size)
-    batch_size = 500 if batch_size.nil? || batch_size < 1
-    do_commit   = opts.delete(:do_commit) || true
-    do_optimize = opts.delete(:do_optimize) || true
+    batch_size = 500 if batch_size < 1
+    do_commit   = opts.delete(:do_commit)
+    do_optimize = opts.delete(:do_optimize)
     raise "Invalid option keys: #{opts.keys}" unless opts.keys.size == 0
 
     RAILS_DEFAULT_LOGGER.debug("SolrBatch.sync_pending_records(#{ar_model})")

metadata

@@ -3,8 +3,8 @@ rubygems_version: 0.9.4
 specification_version: 1
 name: acts_as_background_solr
 version: !ruby/object:Gem::Version 
-  version: "0.5"
-date: 2007-09-09 00:00:00 -04:00
+  version: 0.5.1
+date: 2007-11-06 00:00:00 -05:00
 summary: Extends the functionality of the acts_as_solr plugin to provide for disconnected background job processing
 require_paths: 
 - lib
@@ -30,6 +30,7 @@ authors:
 - Michael Bryzek
 files: 
 - init.rb
+- history.txt
 - lib/acts_as_background_solr.rb
 - lib/class_methods.rb
 - lib/instance_methods.rb