acts_as_approvable 0.1.1 → 0.7.0

data/spec/acts_as_approvable/ownership/class_methods_spec.rb

@@ -0,0 +1,134 @@
+require 'spec_helper'
+
+describe ActsAsApprovable::Ownership::ClassMethods do
+  before(:all) do
+    ActsAsApprovable::Ownership.configure
+  end
+
+  before(:each) do
+    @user1 = User.create
+    @user2 = User.create
+  end
+
+  subject { Approval }
+
+  describe '.owner_class' do
+    it 'proxies to ActsAsApprovable' do
+      ActsAsApprovable.should_receive(:owner_class)
+      subject.owner_class
+    end
+  end
+
+  describe '.owner_source' do
+    it 'proxies to ActsAsApprovable' do
+      ActsAsApprovable.should_receive(:owner_source)
+      subject.owner_source
+    end
+  end
+
+  describe '.available_owners' do
+    it 'selects all records from #owner_class' do
+      subject.available_owners.should include(@user1)
+      subject.available_owners.should include(@user2)
+    end
+
+    context 'when an owner source is configured' do
+      before(:each) do
+        class FakeSource; end
+        ActsAsApprovable.owner_source = FakeSource
+      end
+
+      it 'proxies to the configured source' do
+        FakeSource.should_receive(:available_owners)
+        subject.available_owners
+      end
+    end
+  end
+
+  describe '.options_for_available_owners' do
+    it 'returns an array usable by #options_for_select' do
+      subject.options_for_available_owners.should be_an_options_array
+    end
+
+    it 'uses .available_owners as its source' do
+      subject.should_receive(:available_owners).and_return([])
+      subject.options_for_available_owners
+    end
+
+    it 'uses .options_for_owner to format each record' do
+      subject.should_receive(:option_for_owner).with(@user1).once
+      subject.should_receive(:option_for_owner).with(@user2).once
+      subject.options_for_available_owners
+    end
+
+    it 'includes a prompt if requested' do
+      subject.options_for_available_owners(true).should include(['(none)', nil])
+    end
+
+    it 'does not includes a prompt by default' do
+      subject.options_for_available_owners.should_not include(['(none)', nil])
+    end
+  end
+
+  context 'when an owner source is configured' do
+    before(:each) do
+      class FakeSource; end
+      ActsAsApprovable.owner_source = FakeSource
+    end
+
+    describe '.assigned_owners' do
+      it 'proxies to the configured source' do
+        FakeSource.should_receive(:assigned_owners)
+        subject.assigned_owners
+      end
+    end
+  end
+
+  context 'when no users are assigned' do
+    describe '.assigned_owners' do
+      it 'should be empty' do
+        subject.assigned_owners.should be_empty
+      end
+    end
+  end
+
+  context 'when some users are assigned' do
+    before(:each) do
+      CreatesApprovable.create.approval.update_attribute(:owner_id, @user1.id)
+    end
+
+    describe '.assigned_owners' do
+      it 'selects all owners with an assigned approval' do
+        subject.assigned_owners.should include(@user1)
+      end
+
+      it 'does not include owners without an assignment' do
+        subject.assigned_owners.should_not include(@user2)
+      end
+    end
+
+    describe '.options_for_assigned_owners' do
+      it 'returns an array usable by #options_for_select' do
+        subject.options_for_assigned_owners.should be_an_options_array
+      end
+
+      it 'uses .assigned_owners as its source' do
+        subject.should_receive(:assigned_owners).and_return([@user1])
+        subject.options_for_assigned_owners
+      end
+
+      it 'uses .options_for_owner to format each record' do
+        subject.should_receive(:option_for_owner).with(@user1)
+        subject.options_for_assigned_owners
+      end
+
+      it 'includes a prompt if requested' do
+        subject.options_for_assigned_owners(true).should include(['All Users', nil])
+      end
+
+      it 'does not includes a prompt by default' do
+        subject.options_for_assigned_owners.should_not include(['All Users', nil])
+      end
+    end
+  end
+end

data/spec/acts_as_approvable/ownership/instance_methods_spec.rb

@@ -0,0 +1,32 @@
+require 'spec_helper'
+
+describe ActsAsApprovable::Ownership::InstanceMethods do
+  before(:all) do
+    ActsAsApprovable::Ownership.configure
+  end
+
+  before(:each) do
+    @user1 = User.create
+    @user2 = User.new
+    subject.stub(:save => true)
+  end
+
+  subject { Approval.new }
+
+  describe '#assign' do
+    it 'sets the owner' do
+      expect { subject.assign(@user1) }.to change{subject.owner}.from(nil).to(@user1)
+    end
+
+    it 'raises an InvalidOwner error if the owner is not valid' do
+      expect { subject.assign(@user2) }.to raise_error(ActsAsApprovable::Error::InvalidOwner)
+    end
+  end
+
+  describe '#unassign' do
+    it 'removes the assigned owner' do
+      subject.owner = @user1
+      expect { subject.unassign }.to change{subject.owner}.from(@user1).to(nil)
+    end
+  end
+end

data/spec/acts_as_approvable/ownership_spec.rb

@@ -0,0 +1,52 @@
+require 'spec_helper'
+
+describe ActsAsApprovable::Ownership do
+  describe '.configure' do
+    it 'defaults to Approval as the approval model' do
+      Approval.should_receive(:include).with(ActsAsApprovable::Ownership)
+      subject.configure
+    end
+
+    it 'defaults to User as the owner model' do
+      ActsAsApprovable.should_receive(:owner_class=).with(User)
+      subject.configure
+    end
+
+    it 'adds a belongs_to(:owner) association' do
+      subject.configure
+      Approval.new.should belong_to(:owner)
+    end
+
+    it 'uses the given approval :model' do
+      class FakeApproval < ActiveRecord::Base; end
+      FakeApproval.should_receive(:include).with(ActsAsApprovable::Ownership)
+      subject.configure(:model => FakeApproval)
+    end
+
+    it 'uses the given :owner' do
+      class FakeUser; end
+      ActsAsApprovable.should_receive(:owner_class=).with(FakeUser)
+      subject.configure(:owner => FakeUser)
+    end
+
+    it 'uses the given :source' do
+      class FakeSource; end
+      ActsAsApprovable.should_receive(:owner_source=).with(FakeSource)
+      subject.configure(:source => FakeSource)
+    end
+  end
+
+  describe '.included' do
+    before(:all) do
+      class IncludedOwnership; include ActsAsApprovable::Ownership; end
+    end
+
+    it 'should extend ClassMethods' do
+      IncludedOwnership.should extend(ActsAsApprovable::Ownership::ClassMethods)
+    end
+
+    it 'should extend InstanceMethods' do
+      IncludedOwnership.should extend(ActsAsApprovable::Ownership::InstanceMethods)
+    end
+  end
+end

data/spec/acts_as_approvable_spec.rb

@@ -0,0 +1,31 @@
+require 'spec_helper'
+
+describe ActsAsApprovable do
+  it { should respond_to(:owner_class) }
+  it { should respond_to(:owner_class=) }
+  it { should respond_to(:view_language) }
+  it { should respond_to(:view_language=) }
+  it { should respond_to(:stale_check=) }
+  it { should respond_to(:stale_check?) }
+
+  describe '.enabled?' do
+    it 'returns true by default' do
+      subject.enabled?.should be_true
+    end
+  end
+
+  describe '.disable' do
+    it 'disables the approval queue' do
+      subject.disable
+      subject.enabled?.should be_false
+    end
+  end
+
+  describe '.enable' do
+    it 'enables the approval queue' do
+      subject.enable
+      subject.enabled?.should be_true
+    end
+  end
+
+end

data/spec/spec_helper.rb

@@ -0,0 +1,51 @@
+if RUBY_VERSION =~ /^1\.9/
+  begin
+    require 'simplecov'
+    SimpleCov.start do
+      add_filter '/spec/'
+    end if ENV['COVERAGE']
+  rescue LoadError
+  end
+end
+
+ENV['RAILS_ENV'] = 'test'
+ENV['RAILS_ROOT'] ||= File.expand_path(File.join(File.dirname(__FILE__), '..', '..', '..', '..'))
+
+require 'rspec'
+require 'shoulda'
+require 'timecop'
+require 'active_record'
+
+begin
+  require 'plymouth'
+rescue LoadError
+end if ENV['PRYABLE']
+
+require File.expand_path('../lib/acts_as_approvable', File.dirname(__FILE__))
+
+require File.expand_path('support/database', File.dirname(__FILE__))
+require File.expand_path('support/models', File.dirname(__FILE__))
+require File.expand_path('support/matchers', File.dirname(__FILE__))
+
+RSpec.configure do |config|
+  config.before(:suite) do
+    LOGGER = Support::Database.setup_log unless defined?(LOGGER)
+    Support::Database.load_schema
+  end
+
+  config.before(:each) do
+    Object.send(:remove_const, :CleanApprovable) if defined?(CleanApprovable)
+    class CleanApprovable < ActiveRecord::Base
+      def self.table_name; 'nots'; end
+      def self.primary_key; 'id'; end
+    end
+
+    freeze_at = Time.parse('2012-01-01')
+    Timecop.freeze(freeze_at)
+  end
+
+  config.after(:each) do
+    Timecop.return
+    Support::Database.truncate
+  end
+end

data/spec/support/database.rb

@@ -0,0 +1,49 @@
+module Support
+  module Database
+    def self.setup_log(logfile = nil)
+      logfile ||= File.expand_path('../../debug.log', File.dirname(__FILE__))
+      ActiveRecord::Base.logger = if defined?(ActiveSupport::BufferedLogger)
+                                    ActiveSupport::BufferedLogger.new(logfile)
+                                  else
+                                    Logger.new(logfile)
+                                  end
+    end
+
+    def self.load_schema
+      config = YAML::load(IO.read(File.expand_path('database.yml', File.dirname(__FILE__))))
+
+      unless db_adapter = ENV['DB']
+        %w(sqlite3 mysql2 sqlite).each do |gem|
+          begin
+            require gem
+            db_adapter = gem
+            break
+          rescue MissingSourceFile
+          end
+        end
+      end
+
+      if db_adapter.nil?
+        puts
+        puts
+        puts "You must run tests using one of the available appraisals. `bundle exec rake -T` to list, `bundle exec rake appraisal:rails31` to run against Rails 3.1 and SQLite."
+        exit
+      end
+
+      ActiveRecord::Base.establish_connection(config[db_adapter])
+      ActiveRecord::Migration.suppress_messages do
+        load(File.expand_path('schema.rb', File.dirname(__FILE__)))
+      end
+
+      [User, Approval, NotApprovable, DefaultApprovable, CreatesApprovable, CreatesWithStateApprovable, UpdatesApprovable, UpdatesIgnoreFieldsApprovable, UpdatesOnlyFieldsApprovable, DestroysApprovable].each do |klass|
+        klass.reset_column_information
+      end
+    end
+
+    def self.truncate
+      [User, Approval, NotApprovable, DefaultApprovable, CreatesApprovable, UpdatesApprovable, DestroysApprovable].each do |klass|
+        klass.delete_all
+      end
+    end
+  end
+end

data/spec/support/database.yml

@@ -0,0 +1,12 @@
+sqlite:
+  :adapter: sqlite
+  :database: spec/acts_as_approvable_plugin.sqlite.db
+
+sqlite3:
+  :adapter: sqlite3
+  :database: spec/acts_as_approvable_plugin.sqlite3.db
+
+mysql2:
+  :adapter: mysql2
+  :database: acts_as_approvable_test
+  :user: root

data/spec/support/matchers.rb

@@ -0,0 +1,87 @@
+require 'rspec/expectations'
+require 'shoulda/active_record/matchers'
+
+class Module
+  # Return any modules we +extend+
+  def extended_modules
+    (class << self; self end).included_modules
+  end
+end
+
+# Truthfully this checks both extend *and* include. :include is already used as a matcher for Arrays :-/
+RSpec::Matchers.define :extend do |expected|
+  match do |actual|
+    extended = (actual.extended_modules - Module.extended_modules) + actual.included_modules
+    extended.include?(expected)
+  end
+  description do
+    "extend #{expected}"
+  end
+  failure_message_for_should do |actual|
+    "expected #{actual} to extend #{expected}"
+  end
+  failure_message_for_should_not do |actual|
+    "expected #{actual} not to extend #{expected}"
+  end
+end
+
+RSpec::Matchers.define :be_an_options_array do
+  match do |actual|
+    actual.should be_an(Array)
+    actual.each do |option|
+      unless option.is_a?(String)
+        option.should be_an(Array)
+        option.length.should be(2)
+      end
+    end
+  end
+  description do
+    'returns an array usable by #options_for_select'
+  end
+  failure_message_for_should do |actual|
+    "expected #{actual} to map to a valid #options_for_select array"
+  end
+  failure_message_for_should_not do |actual|
+    "expected #{actual} not to map to a valid #options_for_select array"
+  end
+end
+
+module Shoulda
+  module ActiveRecord
+    module Matchers
+      def validate_inclusion_of(attr)
+        ValidatesInclusionOfMatcher.new(attr)
+      end
+
+      class ValidatesInclusionOfMatcher < ValidationMatcher
+        def in(values)
+          @values = values
+          self
+        end
+
+        def description
+          "require #{@attribute} to be one of #{@values.inspect}"
+        end
+
+        def matches?(subject)
+          super(subject)
+
+          allows_given_values && disallows_other_values
+        end
+
+        private
+        def allows_given_values
+          @values.each do |value|
+            allows_value_of(value, @message)
+          end unless @values.empty?
+        end
+
+        def disallows_other_values
+          @values.each do |value|
+            disallows_value_of("#{value}s", @message)
+          end unless @values.empty?
+        end
+      end
+    end
+  end
+end