acts_as_amazon_product 1.2 → 1.3

data/README

@@ -1,27 +1,29 @@
 = ActsAsAmazonProduct
 
-This "acts_as" module makes it extremely simple to add Amazon integration to an existing model.  
+This "acts_as" module makes it extremely simple to add Amazon integration to an 
+existing model.  
 
 == Setup
 
-This code does not require changing any current database tables.  It only requires adding one migration for a single new table used to cache responses from Amazon:
+This code does not require changing any current database tables.  It only requires 
+adding one migration for a single new table used to cache responses from Amazon.
+Run the following to create the migration:
 
-	ActiveRecord::Base.connection.create_table :amazon_products do |t|
-	  t.column :asin, :string
-	  t.column :xml, :text
-	  t.column :created_at, :datetime, :null => false
-	  t.column :amazonable_id, :integer, :default => 0, :null => false
-	  t.column :amazonable_type, :string, :limit => 15, :default => "", :null => false
-	end
+  script/generate acts_as_amazon_product_migration
 
 == Using acts_as_amazon_product
 
-Add the "acts_as" line to your model.  Only :access_key is required.  The :asin and :name assignments override what attributes in your class should be used for a direct lookup (item_looup) or general search (item_search).  If no value is assigned to :asin then a general search is made and the first item (sorted by salesrank) is assigned (this functionality will likely change).
+Add the "acts_as" line to your model.  Only :access_key is required.  The :asin and 
+:name assignments override what attributes in your class should be used for a direct 
+lookup (item_looup) or general search (item_search).  If no value is assigned to :asin 
+then a general search is made and the first item (sorted by salesrank) is assigned 
+(this functionality will likely change).
 
 	require 'acts_as_amazon_product'
 
 	class Book < ActiveRecord::Base
-	  acts_as_amazon_product :asin => 'isbn', :name => 'title', :access_key => '0123456', :associate_tag => 'assoc-20'
+	  acts_as_amazon_product :asin => 'isbn', :name => 'title', 
+				:access_key => '0123456', :associate_tag => 'assoc-20'
 	end
 
 You can now access the Amazon data in your views like so (see):
@@ -37,12 +39,14 @@ You can now access the Amazon data in your views like so (see):
 
 == Unit tests
 
-There are tests you can run in the [gem]/test directory.  Just create a test/config.yml from the example and run "Rake test" from the [gem] directory.
+There are tests you can run in the [gem]/test directory.  Just create a 
+test/config.yml from the example and run "Rake test" from the [gem] directory.
 
 = Credits
-acts_as_amazon_product was credited by Scott Nedderman and Chris Beck from netphase.com
+acts_as_amazon_product was created by Scott Nedderman and Chris Beck from netphase.com
 
-We'd love to here how you like it.  Also, if you'd like us to help out with your next project, let us know. 
+We'd love to here how you like it.  Also, if you'd like us to help out with your next 
+project, let us know. 
 
 http://netphase.com
 

data/lib/amazon_product.rb

@@ -1,54 +1,60 @@
 require 'hpricot'
 
 class AmazonProduct < ActiveRecord::Base
-#  belongs_to :amazonable, :polymorphic => true
 
-  def hdoc(key)
+  def get(key, separator = ', ')
     @doc ||= Hpricot.XML(xml)
-    @doc.at(key).inner_html
-  end
-
-  def get(key)
-    hdoc(key)
+    values = (@doc/key).collect {|e| e.inner_html }
+    values *= separator unless separator.nil?
+    values unless values.blank?
   end
 
   def isbn
-    hdoc("itemattributes/isbn")
+    get("itemattributes/isbn")
   end
 
   def title
-    hdoc("itemattributes/title")
+    get("itemattributes/title")
   end
 
   def author
-    hdoc("itemattributes/author")
+    get("itemattributes/author")
   end
 
   def binding
-    hdoc("itemattributes/binding")
+    get("itemattributes/binding")
   end
 
   def price
-    hdoc("itemattributes/listprice/amount")
+    get("itemattributes/listprice/amount")
   end
 
   def pages
-    hdoc("itemattributes/numberofpages")
+    get("itemattributes/numberofpages")
   end
 
   def small_image_url
-    hdoc("smallimage/url")
+    get("smallimage/url")
   end
 
   def medium_image_url
-    hdoc("mediumimage/url")
+    get("mediumimage/url")
   end
 
   def large_image_url
-    hdoc("largeimage/url")
+    get("largeimage/url")
   end
 
   def detail_url
-    hdoc("detailpageurl")
+    get("detailpageurl")
   end
+
+  def method_missing(symbol, *args)
+    begin
+      super(symbol, *args)
+    rescue NoMethodError
+      get(symbol, *args)
+    end
+  end
+
 end

data/test/acts_as_amazon_product_test.rb

@@ -15,6 +15,7 @@ ActiveRecord::Base.establish_connection(config["database"])
 ActiveRecord::Base.connection.drop_table :amazon_products rescue nil
 ActiveRecord::Base.connection.drop_table :books rescue nil
 ActiveRecord::Base.connection.drop_table :movies rescue nil
+ActiveRecord::Base.connection.drop_table :magazines rescue nil
 
 ActiveRecord::Base.connection.create_table :books do |t|
   t.column :title, :string
@@ -47,72 +48,96 @@ class Book < ActiveRecord::Base
 end
 
 class Movie < ActiveRecord::Base
-  acts_as_amazon_product
+  acts_as_amazon_product :access_key => @@access_key, :associate_tag => @@associate_tag
 end
 
 class Magazine < ActiveRecord::Base
-  acts_as_amazon_product :search_index => 'Magazines'
+  acts_as_amazon_product :search_index => 'Magazines', :access_key => @@access_key,
+    :associate_tag => @@associate_tag
 end
 
 AmazonProduct.delete_all
 
 class ActAsAmazonProductTest < Test::Unit::TestCase
     
-    def setup
-      Book.delete_all        
-      @book_gtd = Book.create(:title => 'Getting Things Done', :author => 'Dude', :isbn => '0142000280')
-      @book_ror = Book.create(:title => 'Rails Recipes')
-      @book_perl = Book.create(:title => 'Perl')
-      @movie_dh = Movie.create(:name=>'Live Free or Die Hard', :asin=>'B000VNMMRA')
-      Magazine.delete_all
-      @mag_lci = Magazine.create(:name => 'La Cucina Italiana')
-    end
-    
-    def test_isbn
-      assert_not_nil(@book_gtd.amazon)
-      assert_equal("0142000280", @book_gtd.amazon.isbn)
-    end
-    
-    def test_title
-      assert_not_nil(@book_gtd.amazon)
-      assert_equal("Getting Things Done: The Art of Stress-Free Productivity", @book_gtd.amazon.title)
-    end
-    
-    def test_magazine
-      assert_not_nil(@mag_lci.amazon)
-      assert_equal("B00009XFML", @mag_lci.amazon.asin)
-    end
-    
-    def test_small_image
-      assert_not_nil(@book_gtd.amazon)
-      assert_match(/4104N6ME70L\._SL75_\.jpg/, @book_gtd.amazon.small_image_url)
-    end
-
-    def test_author
-      assert_not_nil(@book_gtd.amazon)
-      assert_equal("David Allen", @book_gtd.amazon.author)
-    end
-    
-    def test_binding
-      assert_not_nil(@book_gtd.amazon)
-      assert_equal("Paperback", @book_gtd.amazon.binding)
-    end
-
-    def test_find_with_multiple
-      assert_equal("Rails Recipes (Pragmatic Programmers)", @book_ror.amazon.title)
-      assert_equal("Chad Fowler", @book_ror.amazon.author)
-    end
-    
-    def test_update
-      assert_not_nil(@book_perl.amazon)
-      isbn = @book_perl.amazon.isbn
-      @book_perl.title = "Websters"
-      @book_perl.save
-      assert_not_equal(isbn, @book_perl.amazon.isbn)
-    end
-
-    def test_product_with_all_defaults
-      assert_not_nil(@movie_dh.amazon)
-      assert_equal 'Bruce Willis', @movie_dh.amazon.get('itemattributes/actor')
-    end
+  def setup
+    Book.delete_all        
+    @book_gtd = Book.create(:title => 'Getting Things Done', :author => 'Dude', :isbn => '0142000280')
+    @book_ror = Book.create(:title => 'Rails Recipes')
+    @book_perl = Book.create(:title => 'Perl')
+    @movie_dh = Movie.create(:name=>'Live Free or Die Hard', :asin=>'B000VNMMRA')
+    Magazine.delete_all
+    @mag_lci = Magazine.create(:name => 'La Cucina Italiana')
+  end
+  
+  def test_isbn
+    assert_not_nil(@book_gtd.amazon)
+    assert_equal("0142000280", @book_gtd.amazon.isbn)
+  end
+  
+  def test_title
+    assert_not_nil(@book_gtd.amazon)
+    assert_equal("Getting Things Done: The Art of Stress-Free Productivity", @book_gtd.amazon.title)
+  end
+  
+  def test_magazine
+    assert_not_nil(@mag_lci.amazon)
+    assert_equal("B00009XFML", @mag_lci.amazon.asin)
+  end
+  
+  def test_small_image
+    assert_not_nil(@book_gtd.amazon)
+    assert_match(/4104N6ME70L\._SL75_\.jpg/, @book_gtd.amazon.small_image_url)
+  end
+  
+  def test_author
+    assert_not_nil(@book_gtd.amazon)
+    assert_equal("David Allen", @book_gtd.amazon.author)
+  end
+  
+  def test_binding
+    assert_not_nil(@book_gtd.amazon)
+    assert_equal("Paperback", @book_gtd.amazon.binding)
+  end
+  
+  def test_find_with_multiple
+    assert_equal("Advanced Rails Recipes: 84 New Ways to Build Stunning Rails Apps (Pragmatic Programmers)", @book_ror.amazon.title)
+    assert_equal("Mike Clark", @book_ror.amazon.author)
+  end
+  
+  def test_returns_nil_if_attribute_not_found
+    assert_equal(nil, @book_ror.amazon.get('contributor'))
+  end
+  
+  def test_update
+    assert_not_nil(@book_perl.amazon)
+    isbn = @book_perl.amazon.isbn
+    @book_perl.title = "Websters"
+    @book_perl.save
+    assert_not_equal(isbn, @book_perl.amazon.isbn)
+  end
+  
+  def test_product_with_all_defaults
+    assert_not_nil(@movie_dh.amazon)
+    assert_equal 'Bruce Willis, Timothy Olyphant, Justin Long, Maggie Q, Cliff Curtis',
+      @movie_dh.amazon.get('itemattributes/actor')
+  end
+  
+  def test_accepts_a_custom_separator
+    assert_equal 'Bruce Willis | Timothy Olyphant | Justin Long | Maggie Q | Cliff Curtis',
+      @movie_dh.amazon.get('itemattributes/actor', ' | ')      
+  end
+  
+  def test_returns_array_if_separator_is_nil
+    assert_equal ['Bruce Willis', 'Timothy Olyphant', 'Justin Long', 'Maggie Q', 'Cliff Curtis'],
+      @movie_dh.amazon.get('itemattributes/actor', nil)      
+  end
+
+  def test_method_missing
+    assert_equal 'Bruce Willis, Timothy Olyphant, Justin Long, Maggie Q, Cliff Curtis', @movie_dh.amazon.actor
+  end
+
+  def test_method_missing_with_separator
+    assert_equal 'Bruce Willis | Timothy Olyphant | Justin Long | Maggie Q | Cliff Curtis', @movie_dh.amazon.actor(' | ')
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: acts_as_amazon_product
 version: !ruby/object:Gem::Version 
-  version: "1.2"
+  version: "1.3"
 platform: ruby
 authors: 
 - Scott Nedderman
@@ -9,7 +9,7 @@ autorequire: acts_as_amazon_product
 bindir: bin
 cert_chain: []
 
-date: 2008-04-24 00:00:00 -04:00
+date: 2008-08-11 00:00:00 -04:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency