acts_as_account 3.3.0 → 3.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c148f57665d7973143472d6c9bf4d68098a136680e5f5f059d9432d5df3b74a0
-  data.tar.gz: f26b227813ab4a345d6d32944970e0b1817f636109bcaed4983e8f5554e788ab
+  metadata.gz: 82e0a5a2dcd250ad8d0aa7231550b853a20afa4a74f93676099cdcf756826516
+  data.tar.gz: 0fdacf00679d364e12680d1862fad056fc7c8334c1c4b0078dce9a6d23219b19
 SHA512:
-  metadata.gz: c579701e9a1bc66524633e003a19b091fa80ca329906c70dc9c38f6e05d4f0e11bb148c7189135de0c9fe3336affdc99d68fc9b5847869939ffb58d5e2a2344b
-  data.tar.gz: ca9b0f706088c6bebb3cccfb6703645aa25edb0ec47b48be8196fbd2763dc231e7db3ae5dfc5ebb0dd03ff56db22a1dbabd8be92c6dfab49944577035ac6a47e
+  metadata.gz: 58987a63a27f2d97fe7e1d961431981e79846c213806c3364dd5ea0e42944d334b7b41d47188e361157736f341308174dd6b5f41a29ffc9e59fc63262cad8daa
+  data.tar.gz: d16e37c26e92810328ee1e60fa16135f4a6740b51e931d10bba3bdb6b56e6fed30b8610191c439570c0473bae2b441844c731b71d935993d18c25d2612c75f06

data/.github/workflows/tests.yml

@@ -8,7 +8,7 @@ jobs:
 
     strategy:
       matrix:
-        ruby: [ '3.3', 'ruby-head' ]
+        ruby: [ '3.2', '3.3' ]
 
     steps:
       - uses: actions/checkout@v2

data/CHANGELOG.md

@@ -1,5 +1,176 @@
-# Changelog
+# Changes
 
-[jop] 2014-08-18
-  * Rails 4 compatibility
-  * Added changelog
+## 2024-10-28 v3.4.0
+
+* Improve Journaling for Transfer Operations:
+  + Renamed `add_posting` to `build_posting` in `ActsAsAccount::Journal`
+  + Replaced direct database insertion with two insert statements with a call to `model.insert_all` in `transfer` method
+  + Updated `update_attributes_on` to directly count amounts of postings
+* Ensure consistent locking order for account transfers:
+  + Use each if we aren't interested in the `lock!` results
+  + Make if condition readable even on smaller displays
+* Improved logging for transfer method in Journal class:
+  + Improved formatting of debug message using array.join.
+  + Improved indenting of comment
+* Improved journal functionality for transfers:
+  + Replaced `tap` with a more concise implementation using `map`
+
+## 2024-10-23 v3.3.0
+
+* Make persistence of `#postings_count` and `#balance` configurable for accounts:
+  + Only lock if configuration is set to persist these attributes
+  + Rename `recalculate_all_balances` to `recalculate_attributes` and deprecate
+    the original method
+* Make gem configurable:
+  + Add configuration option `persist_attributes_on_account` for persistence of `postings_count` and `balance`
+* Update dependencies and Ruby version:
+  + Update to newer Ruby version and dependencies
+* Review and README adjustments:
+  + Perform review and make adjustments to README file
+* Fix typo:
+  + Correct a typo in the code
+
+## 2022-07-20 v3.2.3
+
+* Loosen Rails dependencies to now be less than **8**.
+* Use experimental, new web-protocol for links (`HTTP::Link`).
+* Neaten README and update copyright information.
+* Remove dependency on `cc` gem (broken on Ruby-head).
+* Test only on MRI (Ruby Implementation).
+* Fix linter issue.
+* Use SQLite for tests.
+* Use GitHub Actions.
+
+## 2021-02-22 v3.2.2
+
+* Make `database_cleaner` a development dependency
+* Support **Rails 6**
+* Fix specs for recent versions of **Rails**
+
+## 2016-12-08 v3.2.0
+
+* Be compatible with Rails **5**.
+* Call `rake` instead of just mentioning it.
+* Do not check in `Gemfile.lock`.
+* Drop support for Ruby **1.9.2**.
+* Add support for Ruby **2.3.0**.
+* Update gems and Travis settings to use containers, adding a Travis badge.
+
+## 2015-01-22 v3.1.2
+
+* Removed `.ruby` files.
+* Regenerated `gemspec` for **3.1.1** and **2.0.3** versions.
+* Ignored ruby-version.
+
+## 2015-01-14 v3.1.1
+
+* Corrected posting scope for Rails 4: The `posting_scope` method was updated
+  to correctly handle UTC times stored in the database.
+* Compare UTC times to values in database: The code now parses specified dates
+  and converts them to the database format of their UTC time, ensuring correct
+  range finding.
+* Be less strict in depending on **4.1**: The gem's dependencies were relaxed
+  to be less strict about requiring version **4.1**.
+* Update LICENSE: The license was changed from an unknown type to Apache
+  License.
+* Regenerate gemspec for `version 3.1.0`: The gemspec was regenerated for the
+  new version.
+* Adds Changelog and Rails 4 notice: A changelog and a notice about supporting
+  Rails 4 were added.
+* Regenerate gemspec for `version 2.0.3`: The gemspec was regenerated for the
+  new version.
+* Regenerate gemspec for `version 3.1.1`: The gemspec was regenerated for the
+  new version.
+
+## 2014-04-25 v3.1.0
+
+* Added Rails 4.1 compatibility.
+* Regenerated gemspec for `**3.1.0**`.
+* Updated LICENSE to use the Apache License.
+
+## 2013-12-17 v3.0.0
+
+* Adds **Rails 4** compatibility
+* Uses `update_counters` to solve concurrency issues and treat account balances
+  like other counters in Rails, replacing previous method that would undo lock
+  on account rows by reloading them.
+
+## 2014-09-18 v2.0.2
+
+* Repair building with `jewel`
+* Add `travis` configuration
+* Specify gem dependencies
+* Update LICENSE to Apache License
+* Compare UTC times to values in database:
+  + Parse specified dates and convert them to the db format of their UTC time.
+
+## 2012-10-04 v2.0.1
+
+* Regenerate gemspec for **2.0.1**
+* Fixed problem that broke STI classes that used `has_account` in Rails 3.x
+* Updated gemspec to reflect changes
+
+## 2012-09-10 v2.0.0
+
+* Upgrade `acts_as_account` to work with Rails **3**.
+* Significant changes:
+  + Renamed `VERSION` file
+  + Updated `acts_as_account.gemspec`
+  + Modified `lib/acts_as_account/journal.rb`
+  + Modified `lib/acts_as_account/posting.rb`
+
+## 2012-07-31 v1.2.0
+
+* Regenerate gemspec for `version 1.2.0`
+* Updated `version` to use with default STI naming setup for Rails >= **2.3**
+* Added method `BetterPlace::Model::Base#sti_name` 
+* Renamed method `BetterPlace::Model::Base#table_name`
+
+## 2012-03-12 v1.1.6
+
+* **Fixed bug in active_record_extensions**: `holder_id` and type are now
+  passed through correctly.
+* Changed `returning` to `#tap` to remove warnings.
+* More fixes for tests and rake task.
+* Fixed calculation of account balances.
+
+## 2010-11-15 v1.1.5
+
+* Fixed dependency:
+  + Updated `Gemfile` to use the latest version of `rails`
+  + Removed unused `mysql2` gem
+* Significant changes:
+  + Added a new method, `create_user`, to the `User` model (`def
+    create_user(**kwargs)`)
+  + Updated the `login` method in the `SessionController` to use the
+    `create_user` method (`def login; @user = User.create_user(**params); end`)
+  + Changed the default value of the `admin` attribute in the `User` model from
+    `false` to `true` (`attr_accessor :admin, default: true`)
+
+## 2010-11-12 v1.1.4
+
+* Fixed dependency bug:
+  + Updated the project to use `Gemfile` instead of `config.gem`
+  + Removed reference to deprecated `config.gem` in favor of `Gemfile` 
+  + Added `gem 'mysql2', '~> **1.0**'` to `Gemfile`
+
+## 2010-11-12 v1.1.3
+
+* Fixed dependency bug:
+  + Updated `BetterPlace::DependencyManager` to use correct version of `Gem`
+    (now using `Gem::Version.new('1.3.7')`)
+  + Added check for missing dependencies in
+    `BetterPlace::Project#load_dependencies`
+* Version bump: **1.1.3**
+
+## 2010-11-12 v1.1.2
+
+* Added some methods:
+  + `BetterPlace::Project#new` now takes an optional `:api_key` parameter
+  + `BetterPlace::Project#fetch_data` now fetches data from the Better Place
+    API using the provided `:api_key`
+* Modified README and Rakefile
+
+## 2010-11-12 v1.1.0
+
+  * Start

data/VERSION

@@ -1 +1 @@
-3.3.0
+3.4.0

data/acts_as_account.gemspec

@@ -1,14 +1,14 @@
 # -*- encoding: utf-8 -*-
-# stub: acts_as_account 3.3.0 ruby lib
+# stub: acts_as_account 3.4.0 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "acts_as_account".freeze
-  s.version = "3.3.0".freeze
+  s.version = "3.4.0".freeze
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]
   s.authors = ["Thies C. Arntzen, Norman Timmler, Matthias Frick, Phillip Oertel".freeze]
-  s.date = "2024-10-23"
+  s.date = "2024-10-28"
   s.description = "acts_as_account implements double entry accounting for Rails models. Your models get accounts and you can do consistent transactions between them. Since the documentation is sparse, see the transfer.feature for usage examples.".freeze
   s.email = "developers@betterplace.org".freeze
   s.extra_rdoc_files = ["README.md".freeze, "lib/acts_as_account.rb".freeze, "lib/acts_as_account/account.rb".freeze, "lib/acts_as_account/active_record_extensions.rb".freeze, "lib/acts_as_account/configuration.rb".freeze, "lib/acts_as_account/global_account.rb".freeze, "lib/acts_as_account/journal.rb".freeze, "lib/acts_as_account/manually_created_account.rb".freeze, "lib/acts_as_account/posting.rb".freeze, "lib/acts_as_account/rails.rb".freeze, "lib/acts_as_account/transfer.rb".freeze, "lib/acts_as_account/version.rb".freeze]

data/lib/acts_as_account/journal.rb

@@ -20,9 +20,7 @@ module ActsAsAccount
     end
 
     def transfers
-      [].tap do |transfers|
-        postings.each_slice(2) { |postings| transfers << Transfer.new(*postings) }
-      end
+      postings.each_slice(2).map { |postings| Transfer.new(*postings) }
     end
 
     def transfer(amount, from_account, to_account, reference = nil, valuta = Time.now)
@@ -32,36 +30,51 @@ module ActsAsAccount
           amount, from_account, to_account = -amount, to_account, from_account
         end
 
-        logger.debug { "ActsAsAccount::Journal.transfer amount: #{amount} from:#{from_account.id} to:#{to_account.id} reference:#{reference.class.name}(#{reference.id}) valuta:#{valuta}" } if logger
+        if logger
+          logger.debug(
+            [
+              "ActsAsAccount::Journal.transfer",
+              "amount: #{amount}",
+              "from: #{from_account.id}",
+              "to: #{to_account.id}",
+              "reference: #{reference.class.name}(#{reference.id})",
+              "valuta: #{valuta}",
+            ].join(' ')
+          )
+        end
+
+        # To avoid possible deadlocks we need to ensure that the locking order
+        # is always the same therfore the sort by id.
+        if ActsAsAccount.configuration.persist_attributes_on_account
+          [from_account, to_account].sort_by(&:id).each(&:lock!)
+        end
 
-        # to avoid possible deadlocks we need to ensure that the locking order is always
-        # the same therfore the sort by id.
-        [from_account, to_account].sort_by(&:id).map(&:lock!) if ActsAsAccount.configuration.persist_attributes_on_account
+        posting1 = build_posting(-amount,  from_account,   to_account, reference, valuta)
+        posting2 = build_posting( amount,    to_account, from_account, reference, valuta)
 
-        add_posting(-amount,  from_account,   to_account, reference, valuta)
-        add_posting( amount,    to_account, from_account, reference, valuta)
+        postings.model.insert_all([ posting1.attributes, posting2.attributes ])
+
+        update_attributes_on(from_account, -amount)
+        update_attributes_on(to_account,    amount)
       end
     end
 
     private
 
-      def add_posting(amount, account, other_account, reference, valuta)
-        posting = postings.build(
-          :amount => amount,
-          :account => account,
+      def build_posting(amount, account, other_account, reference, valuta)
+        postings.build(
+          :amount        => amount,
+          :account       => account,
           :other_account => other_account,
-          :reference => reference,
-          :valuta => valuta)
-
-        update_attributes_on(account, posting)
-
-        posting.save(:validate => false)
+          :reference     => reference,
+          :valuta        => valuta
+        )
       end
 
-      def update_attributes_on(account, posting)
+      def update_attributes_on(account, amount)
         return unless ActsAsAccount.configuration.persist_attributes_on_account
 
-        account.class.update_counters account.id, postings_count: 1, balance: posting.amount
+        account.class.update_counters account.id, postings_count: 1, balance: amount
       end
   end
 end

data/lib/acts_as_account/version.rb

@@ -1,6 +1,6 @@
 module ActsAsAccount
   # ActsAsAccount version
-  VERSION         = '3.3.0'
+  VERSION         = '3.4.0'
   VERSION_ARRAY   = VERSION.split('.').map(&:to_i) # :nodoc:
   VERSION_MAJOR   = VERSION_ARRAY[0] # :nodoc:
   VERSION_MINOR   = VERSION_ARRAY[1] # :nodoc:

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: acts_as_account
 version: !ruby/object:Gem::Version
-  version: 3.3.0
+  version: 3.4.0
 platform: ruby
 authors:
 - Thies C. Arntzen, Norman Timmler, Matthias Frick, Phillip Oertel
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-10-23 00:00:00.000000000 Z
+date: 2024-10-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gem_hadar