acts_as_account 3.2.2 → 3.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: de4d90bc7ede8a221ad6b6c75a2e2f011b3e5d386928a691b474062e176d8e4d
-  data.tar.gz: a398469051b8d3f8999736de15df861c523960d00bf0173596d26660259d7cda
+  metadata.gz: c148f57665d7973143472d6c9bf4d68098a136680e5f5f059d9432d5df3b74a0
+  data.tar.gz: f26b227813ab4a345d6d32944970e0b1817f636109bcaed4983e8f5554e788ab
 SHA512:
-  metadata.gz: 15501c287164b0968fe841e9bb06c1534366a295287428c039ac9539d8e8a9b1a5a7321654d801a53f6b1d2420bf9a6d56d2dc559cebbcc64387fad6442a7183
-  data.tar.gz: 89c0ad8c2ba52c551fa6069bff11e2192e00f572a7d477f20b4b02028f4eb64146fc2dd08fc51e52150f6e6e305e2615446506ae0e9bd385e33d30a1d5ec6166
+  metadata.gz: c579701e9a1bc66524633e003a19b091fa80ca329906c70dc9c38f6e05d4f0e11bb148c7189135de0c9fe3336affdc99d68fc9b5847869939ffb58d5e2a2344b
+  data.tar.gz: ca9b0f706088c6bebb3cccfb6703645aa25edb0ec47b48be8196fbd2763dc231e7db3ae5dfc5ebb0dd03ff56db22a1dbabd8be92c6dfab49944577035ac6a47e

data/.github/workflows/lint.yml

@@ -0,0 +1,29 @@
+# based on https://github.com/rails/rails/blob/4a78dcb/.github/workflows/rubocop.yml
+
+name: rubocop linting
+
+on: [push, pull_request]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: 3.3
+    - name: Cache gems
+      uses: actions/cache@v1
+      with:
+        path: vendor/bundle
+        key: ${{ runner.os }}-rubocop-${{ hashFiles('**/Gemfile.lock') }}
+        restore-keys: |
+          ${{ runner.os }}-rubocop-
+    - name: Install gems
+      run: |
+        bundle config path vendor/bundle
+        bundle install --jobs 4 --retry 3
+    - name: Run rubocop
+      run: bundle exec rubocop --lint

data/.github/workflows/tests.yml

@@ -0,0 +1,22 @@
+name: tests
+
+on: [push, pull_request]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        ruby: [ '3.3', 'ruby-head' ]
+
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Ruby ${{ matrix.ruby }}
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+      - name: Install dependencies
+        run: bundle install --jobs 4
+      - name: Test with Rake
+        run: bundle exec rake

data/.rubocop.yml

@@ -0,0 +1,61 @@
+# usage: `rubocop --lint`
+
+AllCops:
+  NewCops: enable
+
+# disable some linters that are not so likely to indicate bugs
+
+Lint/AmbiguousAssignment:
+  Enabled: false
+Lint/AmbiguousBlockAssociation:
+  Enabled: false
+Lint/AmbiguousOperator:
+  Enabled: false
+Lint/AmbiguousRegexpLiteral:
+  Enabled: false
+Lint/AssignmentInCondition:
+  Enabled: false
+Lint/ConstantDefinitionInBlock:
+  Enabled: false
+Lint/ConstantResolution:
+  Enabled: false
+Lint/DuplicateBranch:
+  Enabled: false
+Lint/EmptyBlock:
+  Enabled: false
+Lint/EmptyClass:
+  Enabled: false
+Lint/EmptyConditionalBody:
+  Enabled: false
+Lint/EmptyExpression:
+  Enabled: false
+Lint/EmptyFile:
+  Enabled: false
+Lint/EmptyWhen:
+  Enabled: false
+Lint/EnsureReturn:
+  Enabled: false
+Lint/Loop:
+  Enabled: false
+Lint/MissingSuper:
+  Enabled: false
+Lint/MixedRegexpCaptureTypes:
+  Enabled: false
+Lint/NumberConversion:
+  Enabled: false
+Lint/ParenthesesAsGroupedExpression:
+  Enabled: false
+Lint/RedundantStringCoercion:
+  Enabled: false
+Lint/ShadowedArgument:
+  Enabled: false
+Lint/ShadowedException:
+  Enabled: false
+Lint/ShadowingOuterLocalVariable:
+  Enabled: false
+Lint/SuppressedException:
+  Enabled: false
+Lint/UnusedBlockArgument:
+  Enabled: false
+Lint/UnusedMethodArgument:
+  Enabled: false

data/README.md

@@ -0,0 +1,55 @@
+# acts_as_account
+
+[![Build Status](https://github.com/betterplace/acts_as_account/workflows/tests/badge.svg)](https://github.com/jaynetics/js_regex/actions)
+
+## Theory
+
+*ActsAsAccount* implements a "Double Entry Accounting" system for your
+Rails-models.
+
+It hooks into ActiveRecord and allows to add accounts to any model by
+simply means of adding `has_account` to your model. Because the accounts
+are connected via a `has_many` relation no migration to the account-holder
+tables is needed.
+
+We also hook into the ActionController request cycle to warn the developer
+if a request has left uncommitted changes in the system.
+
+## Configuration
+
+It is possible to configure if attributes (postings_count, balance, last_valuta) are persisted on the Account or if it is calculated on demand.
+```
+  ActsAsAccount.configure do |config|
+    # Default values:
+    # config.persist_attributes_on_account = true
+  end
+```
+Enabling persistence means that the sending and receiving account will aquire a lock when making a transfer to ensure correct data. This can be problematic in a high load scenario where many transfers to the same accounts are processed in parallel.
+
+
+## How to test
+
+Run the cucumber features from the acs_as_account gem, just execute
+* `rake features:create_database`
+* `cucumber`
+
+## How to release
+
+You need to update the data in `VERSION` and Rakefile and run `rake` (because it uses GemHadar).
+`rake gem:push` will push the version to rubygems.
+
+## Links
+
+* Double Entry Accounting in a Relational Database: [http://homepages.tcp.co.uk/~m-wigley/gc_wp_ded.html (archived)](https://web.archive.org/web/20080310200243/http://homepages.tcp.co.uk/~m-wigley/gc_wp_ded.html)
+
+## Compatibility
+
+Rails 4 is supported since version 3.1.0, Rails 7 since 3.2.2 .
+
+## Credits
+
+This gem was written for the payment backend of betterplace.org by [Thies C. Arntzen, "thieso2"](https://github.com/thieso2), [Norman Timmler, "unnu"](https://github.com/unnu) and others.
+
+## Copyright
+
+Copyright (c) 2010, 2022 [gut.org gAG](https://gut.org), released under the [Apache License v2.0](LICENSE).

data/Rakefile

@@ -6,43 +6,38 @@ GemHadar do
   name        'acts_as_account'
   author      [ "Thies C. Arntzen, Norman Timmler, Matthias Frick, Phillip Oertel" ]
   email       'developers@betterplace.org'
-  homepage    "http://github.com/betterplace/acts_as_account"
+  homepage    "https://github.com/betterplace/acts_as_account"
   summary     'acts_as_account implements double entry accounting for Rails models'
   description 'acts_as_account implements double entry accounting for Rails models. Your models get accounts and you can do consistent transactions between them. Since the documentation is sparse, see the transfer.feature for usage examples.'
   test_dir    'tests'
   ignore      '.*.sw[pon]', 'pkg', 'Gemfile.lock', 'coverage', '.rvmrc',
     '.AppleDouble', 'tags', '.byebug_history', '.DS_Store'
-  readme      'README.rdoc'
+  readme      'README.md'
   title       "#{name.camelize} -- More Math in Ruby"
   licenses << 'Apache-2.0'
 
-  dependency 'activerecord',         '>= 4.1', '<7'
-  dependency 'actionpack'  ,         '>= 4.1', '<7'
-  development_dependency 'cucumber', '~> 1.3'
-  development_dependency 'mysql2'
-  development_dependency 'rspec',    '~> 3.1'
+  dependency 'activerecord',         '>= 5.1', '<8'
+  dependency 'actionpack'  ,         '>= 4.1', '<8'
+  development_dependency 'cucumber'
+  development_dependency 'sqlite3'
+  development_dependency 'rspec'
   development_dependency 'simplecov'
-  development_dependency 'complex_config'
-  development_dependency 'database_cleaner',     '~> 1.3'
+  development_dependency 'database_cleaner'
+  development_dependency 'rubocop'
 end
 
 def connect_database
   require 'active_record'
-  require 'complex_config'
-  config = ComplexConfig::Provider.config 'features/db/database.yml'
-  connection_config = config.acts_as_account.to_h
-  connection_config.delete(:database)
-  ActiveRecord::Base.establish_connection(connection_config).connection
+  require 'yaml'
+  db_config = YAML.load_file('features/db/database.yml')
+  ActiveRecord::Base.establish_connection(db_config).lease_connection
 end
 
 namespace :features do
   desc "create test database out of db/schema.rb"
   task :create_database do
-    conn = connect_database
-    conn.execute('DROP DATABASE IF EXISTS acts_as_account')
-    conn.execute('CREATE DATABASE acts_as_account')
-    conn.execute('USE acts_as_account')
-    load(File.dirname(__FILE__) + '/features/db/schema.rb')
+    connect_database
+    load("#{__dir__}/features/db/schema.rb")
   end
 end
 

data/VERSION

@@ -1 +1 @@
-3.2.2
+3.3.0

data/acts_as_account.gemspec

@@ -1,47 +1,33 @@
 # -*- encoding: utf-8 -*-
-# stub: acts_as_account 3.2.2 ruby lib
+# stub: acts_as_account 3.3.0 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "acts_as_account".freeze
-  s.version = "3.2.2"
+  s.version = "3.3.0".freeze
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]
   s.authors = ["Thies C. Arntzen, Norman Timmler, Matthias Frick, Phillip Oertel".freeze]
-  s.date = "2021-02-22"
+  s.date = "2024-10-23"
   s.description = "acts_as_account implements double entry accounting for Rails models. Your models get accounts and you can do consistent transactions between them. Since the documentation is sparse, see the transfer.feature for usage examples.".freeze
   s.email = "developers@betterplace.org".freeze
-  s.extra_rdoc_files = ["README.rdoc".freeze, "lib/acts_as_account.rb".freeze, "lib/acts_as_account/account.rb".freeze, "lib/acts_as_account/active_record_extensions.rb".freeze, "lib/acts_as_account/global_account.rb".freeze, "lib/acts_as_account/journal.rb".freeze, "lib/acts_as_account/manually_created_account.rb".freeze, "lib/acts_as_account/posting.rb".freeze, "lib/acts_as_account/rails.rb".freeze, "lib/acts_as_account/transfer.rb".freeze, "lib/acts_as_account/version.rb".freeze]
-  s.files = [".gitignore".freeze, ".travis.yml".freeze, "CHANGELOG.md".freeze, "Gemfile".freeze, "LICENSE".freeze, "README.rdoc".freeze, "Rakefile".freeze, "VERSION".freeze, "acts_as_account.gemspec".freeze, "cucumber.yml".freeze, "features/account/account_creation.feature".freeze, "features/db/database.yml".freeze, "features/db/schema.rb".freeze, "features/step_definitions/account_steps.rb".freeze, "features/support/abstract_user.rb".freeze, "features/support/cheque.rb".freeze, "features/support/env.rb".freeze, "features/support/inheriting_user.rb".freeze, "features/support/user.rb".freeze, "features/transfer/journal_creation.feature".freeze, "features/transfer/transfer.feature".freeze, "init.rb".freeze, "lib/acts_as_account.rb".freeze, "lib/acts_as_account/account.rb".freeze, "lib/acts_as_account/active_record_extensions.rb".freeze, "lib/acts_as_account/global_account.rb".freeze, "lib/acts_as_account/journal.rb".freeze, "lib/acts_as_account/manually_created_account.rb".freeze, "lib/acts_as_account/posting.rb".freeze, "lib/acts_as_account/rails.rb".freeze, "lib/acts_as_account/transfer.rb".freeze, "lib/acts_as_account/version.rb".freeze]
-  s.homepage = "http://github.com/betterplace/acts_as_account".freeze
+  s.extra_rdoc_files = ["README.md".freeze, "lib/acts_as_account.rb".freeze, "lib/acts_as_account/account.rb".freeze, "lib/acts_as_account/active_record_extensions.rb".freeze, "lib/acts_as_account/configuration.rb".freeze, "lib/acts_as_account/global_account.rb".freeze, "lib/acts_as_account/journal.rb".freeze, "lib/acts_as_account/manually_created_account.rb".freeze, "lib/acts_as_account/posting.rb".freeze, "lib/acts_as_account/rails.rb".freeze, "lib/acts_as_account/transfer.rb".freeze, "lib/acts_as_account/version.rb".freeze]
+  s.files = [".github/workflows/lint.yml".freeze, ".github/workflows/tests.yml".freeze, ".gitignore".freeze, ".rubocop.yml".freeze, "CHANGELOG.md".freeze, "Gemfile".freeze, "LICENSE".freeze, "README.md".freeze, "Rakefile".freeze, "VERSION".freeze, "acts_as_account.gemspec".freeze, "acts_as_account.sqlite".freeze, "cucumber.yml".freeze, "features/account/account_creation.feature".freeze, "features/db/database.yml".freeze, "features/db/schema.rb".freeze, "features/step_definitions/account_steps.rb".freeze, "features/support/abstract_user.rb".freeze, "features/support/cheque.rb".freeze, "features/support/env.rb".freeze, "features/support/inheriting_user.rb".freeze, "features/support/user.rb".freeze, "features/transfer/journal_creation.feature".freeze, "features/transfer/transfer.feature".freeze, "init.rb".freeze, "lib/acts_as_account.rb".freeze, "lib/acts_as_account/account.rb".freeze, "lib/acts_as_account/active_record_extensions.rb".freeze, "lib/acts_as_account/configuration.rb".freeze, "lib/acts_as_account/global_account.rb".freeze, "lib/acts_as_account/journal.rb".freeze, "lib/acts_as_account/manually_created_account.rb".freeze, "lib/acts_as_account/posting.rb".freeze, "lib/acts_as_account/rails.rb".freeze, "lib/acts_as_account/transfer.rb".freeze, "lib/acts_as_account/version.rb".freeze]
+  s.homepage = "https://github.com/betterplace/acts_as_account".freeze
   s.licenses = ["Apache-2.0".freeze]
-  s.rdoc_options = ["--title".freeze, "ActsAsAccount -- More Math in Ruby".freeze, "--main".freeze, "README.rdoc".freeze]
-  s.rubygems_version = "3.2.8".freeze
+  s.rdoc_options = ["--title".freeze, "ActsAsAccount -- More Math in Ruby".freeze, "--main".freeze, "README.md".freeze]
+  s.rubygems_version = "3.5.18".freeze
   s.summary = "acts_as_account implements double entry accounting for Rails models".freeze
 
-  if s.respond_to? :specification_version then
-    s.specification_version = 4
-  end
+  s.specification_version = 4
 
-  if s.respond_to? :add_runtime_dependency then
-    s.add_development_dependency(%q<gem_hadar>.freeze, ["~> 1.11.0"])
-    s.add_development_dependency(%q<cucumber>.freeze, ["~> 1.3"])
-    s.add_development_dependency(%q<mysql2>.freeze, [">= 0"])
-    s.add_development_dependency(%q<rspec>.freeze, ["~> 3.1"])
-    s.add_development_dependency(%q<simplecov>.freeze, [">= 0"])
-    s.add_development_dependency(%q<complex_config>.freeze, [">= 0"])
-    s.add_development_dependency(%q<database_cleaner>.freeze, ["~> 1.3"])
-    s.add_runtime_dependency(%q<activerecord>.freeze, [">= 4.1", "< 7"])
-    s.add_runtime_dependency(%q<actionpack>.freeze, [">= 4.1", "< 7"])
-  else
-    s.add_dependency(%q<gem_hadar>.freeze, ["~> 1.11.0"])
-    s.add_dependency(%q<cucumber>.freeze, ["~> 1.3"])
-    s.add_dependency(%q<mysql2>.freeze, [">= 0"])
-    s.add_dependency(%q<rspec>.freeze, ["~> 3.1"])
-    s.add_dependency(%q<simplecov>.freeze, [">= 0"])
-    s.add_dependency(%q<complex_config>.freeze, [">= 0"])
-    s.add_dependency(%q<database_cleaner>.freeze, ["~> 1.3"])
-    s.add_dependency(%q<activerecord>.freeze, [">= 4.1", "< 7"])
-    s.add_dependency(%q<actionpack>.freeze, [">= 4.1", "< 7"])
-  end
+  s.add_development_dependency(%q<gem_hadar>.freeze, ["~> 1.19".freeze])
+  s.add_development_dependency(%q<cucumber>.freeze, [">= 0".freeze])
+  s.add_development_dependency(%q<sqlite3>.freeze, [">= 0".freeze])
+  s.add_development_dependency(%q<rspec>.freeze, [">= 0".freeze])
+  s.add_development_dependency(%q<simplecov>.freeze, [">= 0".freeze])
+  s.add_development_dependency(%q<database_cleaner>.freeze, [">= 0".freeze])
+  s.add_development_dependency(%q<rubocop>.freeze, [">= 0".freeze])
+  s.add_runtime_dependency(%q<activerecord>.freeze, [">= 5.1".freeze, "< 8".freeze])
+  s.add_runtime_dependency(%q<actionpack>.freeze, [">= 4.1".freeze, "< 8".freeze])
 end

data/features/db/database.yml

@@ -1,6 +1,5 @@
-acts_as_account:
-  adapter: mysql2
-  encoding: utf8
-  database: acts_as_account
-  username: root
-  host: localhost
+adapter: sqlite3
+encoding: utf8
+database: acts_as_account.sqlite
+username: root
+host: localhost

data/features/db/schema.rb

@@ -41,10 +41,6 @@ ActiveRecord::Schema.define(version: 1) do
   add_index "acts_as_account_postings", ["reference_type", "reference_id"], name: "reference"
   add_index "acts_as_account_postings", ["valuta", "id"], name: "sort_key"
 
-  execute "ALTER TABLE acts_as_account_postings ADD CONSTRAINT account_id FOREIGN KEY (account_id) REFERENCES acts_as_account_accounts (id)"
-  execute "ALTER TABLE acts_as_account_postings ADD CONSTRAINT other_account_id FOREIGN KEY (other_account_id) REFERENCES acts_as_account_accounts (id)"
-  execute "ALTER TABLE acts_as_account_postings ADD CONSTRAINT journal_id FOREIGN KEY (journal_id) REFERENCES acts_as_account_journals (id)"
-
   create_table "acts_as_account_global_accounts", force: true do |t|
     t.string   "name", null: false
   end

data/features/step_definitions/account_steps.rb

@@ -15,6 +15,10 @@ Given /^I create a user (\w+)$/ do |name|
   User.create!(:name => name)
 end
 
+Given /^I configure attribute persistence to be (\w+)$/ do |flag|
+  ActsAsAccount.configuration.persist_attributes_on_account = flag == 'true'
+end
+
 Given /^I have a user (\w+) that inherits from an abstract class$/ do |name|
   InheritingUser.create!(:name => name)
 end
@@ -67,9 +71,10 @@ Then /^the global (\w+) account balance is (-?\d+) €$/ do |name, balance|
 end
 
 When /^I transfer (-?\d+) € from (\w+)'s account to (\w+)'s account$/ do |amount, from, to|
-  from_account = User.find_by_name(from).account
-  to_account = User.find_by_name(to).account
-  Journal.current.transfer(amount.to_i, from_account, to_account, @reference, @valuta)
+  @from_account = User.find_by_name(from).account
+  @to_account = User.find_by_name(to).account
+  @previous_account_attributes = [@from_account.attributes, @to_account.attributes]
+  Journal.current.transfer(amount.to_i, @from_account, @to_account, @reference, @valuta)
 end
 
 When /^I transfer (\d+) € from global (\w+) account to global (\w+) account$/ do |amount, from, to|
@@ -94,7 +99,7 @@ When /^I create a Journal via (.+)$/ do |method|
     eval <<-EOT
     @journal = Journal.#{method}
     EOT
-  rescue Exception => @last_exception
+  rescue => @last_exception
   end
 end
 
@@ -152,7 +157,7 @@ end
 
 Then /^the order of the postings is correct$/ do
   # make sure we always book "Soll an Haben"
-  Posting.all.in_groups_of(2) do |from, to|
+  Posting.all.each_slice(2) do |from, to|
     from.amount.should be < 0
     to.amount.should be > 0
   end
@@ -172,3 +177,12 @@ end
 When /^I call 'account' on both it should be possible$/ do
   [@user1, @user2].each { |user| user.account }
 end
+
+Then('there are no changes to the accounts') do
+  @previous_account_attributes.should eq [@from_account.reload.attributes, @to_account.reload.attributes]
+end
+
+Then('the balance field changed on the accounts') do
+  @from_account.reload.read_attribute(:balance).should_not eq @previous_account_attributes.first['balance']
+  @to_account.reload.read_attribute(:balance).should_not eq @previous_account_attributes.last['balance']
+end

data/features/support/env.rb

@@ -6,21 +6,28 @@ if ENV['START_SIMPLECOV'].to_i == 1
 end
 
 require 'acts_as_account'
-require 'complex_config'
-config =ComplexConfig::Provider.config File.dirname(__FILE__) + '/../db/database.yml'
-ActiveRecord::Base.establish_connection(config.acts_as_account.to_h)
+require 'yaml'
+db_config = YAML.load_file(__dir__ + '/../db/database.yml')
+ActiveRecord::Base.establish_connection(db_config)
 
 require 'database_cleaner'
 require 'database_cleaner/cucumber'
 DatabaseCleaner.strategy = :transaction
 
-Dir[File.dirname(__FILE__) + '/../step_definitions/*.rb'].each { |file| require file }
+Dir["#{__dir__}/../step_definitions/*.rb"].sort.each { |file| require file }
 
-require File.dirname(__FILE__) + '/user'
-require File.dirname(__FILE__) + '/abstract_user'
-require File.dirname(__FILE__) + '/inheriting_user'
-require File.dirname(__FILE__) + '/cheque'
+require_relative 'user'
+require_relative 'abstract_user'
+require_relative 'inheriting_user'
+require_relative 'cheque'
 
 After do
   ActsAsAccount::Journal.clear_current
 end
+
+Before do
+  ActsAsAccount.configure do |config|
+    # Default values:
+    # config.persist_attributes_on_account = true
+  end
+end

data/features/transfer/transfer.feature

@@ -3,14 +3,26 @@ Feature: Transfer
   As a Bank
   I want not to loose money
 
-  Scenario: I transfer money between accounts having holders
+  Scenario: I transfer money between accounts having holders with attribute persistence set to true
     Given I create a user Thies
     Given I create a user Norman
+    Given I configure attribute persistence to be true
     When I transfer 30 € from Thies's account to Norman's account
     Then Thies's account balance is -30 €
     And Norman's account balance is 30 €
     And the order of the postings is correct
-    
+    And the balance field changed on the accounts
+
+  Scenario: I transfer money between accounts having holders with attribute persistence set to false
+    Given I create a user Thies
+    Given I create a user Norman
+    Given I configure attribute persistence to be false
+    When I transfer 30 € from Thies's account to Norman's account
+    Then Thies's account balance is -30 €
+    And Norman's account balance is 30 €
+    And the order of the postings is correct
+    And there are no changes to the accounts
+
   Scenario: I transfer a negative amount between accounts having holders
     Given I create a user Thies
     Given I create a user Norman
@@ -41,4 +53,4 @@ Feature: Transfer
     When I transfer 50 € from Thies's account to Norman's account and specify 22.05.1968 07:45 as the booking time
     Then Thies's account balance is -50 €
     And Norman's account balance is 50 €
-    And all postings have 22.05.1968 07:45 as the booking time
+    And all postings have 22.05.1968 07:45 as the booking time

data/lib/acts_as_account/account.rb

@@ -6,20 +6,16 @@ module ActsAsAccount
     has_many :postings, :class_name => 'ActsAsAccount::Posting'
     has_many :journals, :through => :postings
 
-    # TODO: discuss with norman:
-    # validates_presence_of will force an ActiveRecord::find on the object
-    # but we have to create accounts for deleted holder!
-    #
-    # validates_presence_of :holder
-
     class << self
       def recalculate_all_balances
+        warn "[DEPRECATION] `recalculate_all_balances` is deprecated and will be removed in a future version. Please use `recalculate_attributes` instead."
+
+        recalculate_attributes
+      end
+
+      def recalculate_attributes
         find_each do |account|
-          account.update_columns(
-            balance:        account.postings.sum(:amount),
-            postings_count: account.postings.count,
-            last_valuta:    account.postings.maximum(:valuta)
-          )
+          account.recalculate_attributes
         end
       end
 
@@ -53,7 +49,7 @@ module ActsAsAccount
         yield
 
       # Trying to create a duplicate key on a unique index raises StatementInvalid
-      rescue ActiveRecord::StatementInvalid => e
+      rescue ActiveRecord::StatementInvalid
         record = if attributes[:holder]
           attributes[:holder].account(attributes[:name])
         else
@@ -67,6 +63,40 @@ module ActsAsAccount
       end
     end
 
+    def balance
+      if ActsAsAccount.configuration.persist_attributes_on_account
+        super
+      else
+        postings.sum(:amount)
+      end
+    end
+
+    def postings_count
+      if ActsAsAccount.configuration.persist_attributes_on_account
+        super
+      else
+        postings.count
+      end
+    end
+
+    def last_valuta
+      if ActsAsAccount.configuration.persist_attributes_on_account
+        super
+      else
+        postings.maximum(:valuta)
+      end
+    end
+
+    def recalculate_attributes
+      return unless ActsAsAccount.configuration.persist_attributes_on_account
+
+      update_columns(
+        last_valuta:    postings.maximum(:valuta),
+        balance:        postings.sum(:amount),
+        postings_count: postings.count
+      )
+    end
+
     def deleteable?
       postings.empty? && journals.empty?
     end

data/lib/acts_as_account/active_record_extensions.rb

@@ -10,7 +10,6 @@ module ActsAsAccount
     end
 
     module ClassMethods
-
       def has_account(name = :default)
         has_one :"#{name}_account", -> { where name: name }, class_name: "ActsAsAccount::Account", as: :holder
 

data/lib/acts_as_account/configuration.rb

@@ -0,0 +1,10 @@
+module ActsAsAccount
+  class Configuration
+    attr_accessor :persist_attributes_on_account
+
+    def initialize
+      # default values
+      @persist_attributes_on_account = true
+    end
+  end
+end

data/lib/acts_as_account/global_account.rb

@@ -1,7 +1,12 @@
 module ActsAsAccount
+  # A named account that is "global" (not tied to any specific entity
+  # in your database otherwise).
+  #
+  # This is useful for accounts that you don't want to model anything
+  # for via an ActiveRecord model (like "Cash").
   class GlobalAccount < ActiveRecord::Base
     self.table_name = :acts_as_account_global_accounts
 
     has_account
   end
-end
+end

data/lib/acts_as_account/journal.rb

@@ -21,7 +21,7 @@ module ActsAsAccount
 
     def transfers
       [].tap do |transfers|
-        postings.in_groups_of(2) { |postings| transfers << Transfer.new(*postings) }
+        postings.each_slice(2) { |postings| transfers << Transfer.new(*postings) }
       end
     end
 
@@ -36,7 +36,7 @@ module ActsAsAccount
 
         # to avoid possible deadlocks we need to ensure that the locking order is always
         # the same therfore the sort by id.
-        [from_account, to_account].sort_by(&:id).map(&:lock!)
+        [from_account, to_account].sort_by(&:id).map(&:lock!) if ActsAsAccount.configuration.persist_attributes_on_account
 
         add_posting(-amount,  from_account,   to_account, reference, valuta)
         add_posting( amount,    to_account, from_account, reference, valuta)
@@ -53,10 +53,15 @@ module ActsAsAccount
           :reference => reference,
           :valuta => valuta)
 
-        account.class.update_counters account.id, :postings_count => 1, :balance => posting.amount
+        update_attributes_on(account, posting)
 
         posting.save(:validate => false)
-        account.save(:validate => false)
+      end
+
+      def update_attributes_on(account, posting)
+        return unless ActsAsAccount.configuration.persist_attributes_on_account
+
+        account.class.update_counters account.id, postings_count: 1, balance: posting.amount
       end
   end
 end

data/lib/acts_as_account/posting.rb

@@ -12,11 +12,11 @@ module ActsAsAccount
     scope :soll,       -> { where('amount >= 0') }
     scope :haben,      -> { where('amount < 0') }
     scope :start_date, -> date {
-      date = Time.parse(date.to_s).utc.to_s(:db)
+      date = Time.parse(date.to_s).utc.to_fs(:db)
       where(['valuta >= ?', date])
     }
     scope :end_date,   -> date {
-      date = Time.parse(date.to_s).utc.to_s(:db)
+      date = Time.parse(date.to_s).utc.to_fs(:db)
       where(['valuta <= ?', date])
     }
   end

data/lib/acts_as_account/version.rb

@@ -1,6 +1,6 @@
 module ActsAsAccount
   # ActsAsAccount version
-  VERSION         = '3.2.2'
+  VERSION         = '3.3.0'
   VERSION_ARRAY   = VERSION.split('.').map(&:to_i) # :nodoc:
   VERSION_MAJOR   = VERSION_ARRAY[0] # :nodoc:
   VERSION_MINOR   = VERSION_ARRAY[1] # :nodoc:

data/lib/acts_as_account.rb

@@ -1,7 +1,16 @@
 require 'active_record'
 require 'action_controller'
+require 'acts_as_account/configuration'
 
 module ActsAsAccount
+  class << self
+    attr_accessor :configuration
+  end
+
+  def self.configure
+    self.configuration ||= Configuration.new
+    yield(configuration)
+  end
 end
 
 require 'acts_as_account/version'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: acts_as_account
 version: !ruby/object:Gem::Version
-  version: 3.2.2
+  version: 3.3.0
 platform: ruby
 authors:
 - Thies C. Arntzen, Norman Timmler, Matthias Frick, Phillip Oertel
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-02-22 00:00:00.000000000 Z
+date: 2024-10-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gem_hadar
@@ -16,30 +16,30 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.11.0
+        version: '1.19'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.11.0
+        version: '1.19'
 - !ruby/object:Gem::Dependency
   name: cucumber
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: mysql2
+  name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -56,16 +56,16 @@ dependencies:
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -81,7 +81,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: complex_config
+  name: database_cleaner
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -95,39 +95,39 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: database_cleaner
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.1'
+        version: '5.1'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7'
+        version: '8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.1'
+        version: '5.1'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7'
+        version: '8'
 - !ruby/object:Gem::Dependency
   name: actionpack
   requirement: !ruby/object:Gem::Requirement
@@ -137,7 +137,7 @@ dependencies:
         version: '4.1'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7'
+        version: '8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -147,7 +147,7 @@ dependencies:
         version: '4.1'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7'
+        version: '8'
 description: acts_as_account implements double entry accounting for Rails models.
   Your models get accounts and you can do consistent transactions between them. Since
   the documentation is sparse, see the transfer.feature for usage examples.
@@ -155,10 +155,11 @@ email: developers@betterplace.org
 executables: []
 extensions: []
 extra_rdoc_files:
-- README.rdoc
+- README.md
 - lib/acts_as_account.rb
 - lib/acts_as_account/account.rb
 - lib/acts_as_account/active_record_extensions.rb
+- lib/acts_as_account/configuration.rb
 - lib/acts_as_account/global_account.rb
 - lib/acts_as_account/journal.rb
 - lib/acts_as_account/manually_created_account.rb
@@ -167,15 +168,18 @@ extra_rdoc_files:
 - lib/acts_as_account/transfer.rb
 - lib/acts_as_account/version.rb
 files:
+- ".github/workflows/lint.yml"
+- ".github/workflows/tests.yml"
 - ".gitignore"
-- ".travis.yml"
+- ".rubocop.yml"
 - CHANGELOG.md
 - Gemfile
 - LICENSE
-- README.rdoc
+- README.md
 - Rakefile
 - VERSION
 - acts_as_account.gemspec
+- acts_as_account.sqlite
 - cucumber.yml
 - features/account/account_creation.feature
 - features/db/database.yml
@@ -192,6 +196,7 @@ files:
 - lib/acts_as_account.rb
 - lib/acts_as_account/account.rb
 - lib/acts_as_account/active_record_extensions.rb
+- lib/acts_as_account/configuration.rb
 - lib/acts_as_account/global_account.rb
 - lib/acts_as_account/journal.rb
 - lib/acts_as_account/manually_created_account.rb
@@ -199,7 +204,7 @@ files:
 - lib/acts_as_account/rails.rb
 - lib/acts_as_account/transfer.rb
 - lib/acts_as_account/version.rb
-homepage: http://github.com/betterplace/acts_as_account
+homepage: https://github.com/betterplace/acts_as_account
 licenses:
 - Apache-2.0
 metadata: {}
@@ -208,7 +213,7 @@ rdoc_options:
 - "--title"
 - ActsAsAccount -- More Math in Ruby
 - "--main"
-- README.rdoc
+- README.md
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
@@ -222,7 +227,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.8
+rubygems_version: 3.5.18
 signing_key:
 specification_version: 4
 summary: acts_as_account implements double entry accounting for Rails models

data/.travis.yml

@@ -1,5 +0,0 @@
-rvm:
-  - 2.3.3
-  - 2.6.3
-sudo: false
-script: rake

data/README.rdoc

@@ -1,42 +0,0 @@
-= acts_as_account
-
-{<img src="https://travis-ci.org/betterplace/acts_as_account.svg?branch=master" alt="Build Status" />}[https://travis-ci.org/betterplace/acts_as_account]
-
-== Theory
-
-ActsAsAccount implements a "Double Entry Accounting" system for your
-Rails-models.
-
-It hooks into ActiveRecord and allows to add accounts to any model by
-simply means of adding "has_account" to your model. Because the accounts
-are connected via a has_many relation no migration to the account-holder
-tables is needed.
-
-We also hook into the ActionController request cycle to warn the developer
-if a request has left the uncommitted changes in the system.
-
-== Support
-
-Rails 4 is supported since version 3.1.0
-
-== How to test
-
-Run the cucumber features from the acs_as_account gem, just execute
-* rake features:create_database
-* cucumber
-
-== Links
-
-* Double Entry Accounting in a Relational Database: http://homepages.tcp.co.uk/~m-wigley/gc_wp_ded.html
-
-== Compatibility
-
-With the release of version 2.0.0 acts_as_account is supposed to work for Rails 3. If you still use Rails 2 please use version 1.2.0.
-
-== Credits
-
-This gem was written for the payment backend of betterplace.org by Thies C. Arntzen (http://github.com/thieso2) and Norman Timmler (github.com/unnu).
-
-== Copyright
-
-Copyright (c) 2010 gut.org gAG