acts_as_account 3.2.0 → 3.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: b705a667091596f33080e44a576596290391e8c6
-  data.tar.gz: b6d4dc031e53a8bc5b75051906aff81fb68081b6
+SHA256:
+  metadata.gz: 6c6d94c77b41055a293cb92db325121dd8e40a9de54004ba017fd20bc301b243
+  data.tar.gz: '0582774b247afe230b9036f47fcea99d346f56993174fa9d4eac36e4ec817893'
 SHA512:
-  metadata.gz: 9c1eeb4b0f460d5f53293e5a90bd0d06c088a8cddb9dbc2a077a470b70748bf9269ff7a76700e0b9ffa999c19ab119e823ec669f09046eb83226e6c36c058820
-  data.tar.gz: 2a029a58a6e83a79a2101eb17c845b7d1fd59b68cb7b1cdcacff279b3ebbfd97c2de75a5b864572cbf696fb87a6df6d6eb39d3840eca69907590c608f5486640
+  metadata.gz: a41ef812cff3dfeca6b723ae5367baa3af018687e3316b03b6a39ad76bcd1d1dbf3a92e0f9efdf863c4f41930c41e518dbf0c4909357b780829673da72c330d7
+  data.tar.gz: f9ad1dc779fa5fd623491d9267465a486ee6bc03ece7839f0dd9c6a88d5b05574249278a3e2fe8776c01180c441451194d7e3b6b33070d24473a6a10c077ca3d

data/.github/workflows/lint.yml

@@ -0,0 +1,29 @@
+# based on https://github.com/rails/rails/blob/4a78dcb/.github/workflows/rubocop.yml
+
+name: rubocop linting
+
+on: [push, pull_request]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: 2.7
+    - name: Cache gems
+      uses: actions/cache@v1
+      with:
+        path: vendor/bundle
+        key: ${{ runner.os }}-rubocop-${{ hashFiles('**/Gemfile.lock') }}
+        restore-keys: |
+          ${{ runner.os }}-rubocop-
+    - name: Install gems
+      run: |
+        bundle config path vendor/bundle
+        bundle install --jobs 4 --retry 3
+    - name: Run rubocop
+      run: bundle exec rubocop --lint

data/.github/workflows/tests.yml

@@ -0,0 +1,22 @@
+name: tests
+
+on: [push, pull_request]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        ruby: [ '2.7', 'ruby-head' ]
+
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Ruby ${{ matrix.ruby }}
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+      - name: Install dependencies
+        run: bundle install --jobs 4
+      - name: Test with Rake
+        run: bundle exec rake

data/.rubocop.yml

@@ -0,0 +1,61 @@
+# usage: `rubocop --lint`
+
+AllCops:
+  NewCops: enable
+
+# disable some linters that are not so likely to indicate bugs
+
+Lint/AmbiguousAssignment:
+  Enabled: false
+Lint/AmbiguousBlockAssociation:
+  Enabled: false
+Lint/AmbiguousOperator:
+  Enabled: false
+Lint/AmbiguousRegexpLiteral:
+  Enabled: false
+Lint/AssignmentInCondition:
+  Enabled: false
+Lint/ConstantDefinitionInBlock:
+  Enabled: false
+Lint/ConstantResolution:
+  Enabled: false
+Lint/DuplicateBranch:
+  Enabled: false
+Lint/EmptyBlock:
+  Enabled: false
+Lint/EmptyClass:
+  Enabled: false
+Lint/EmptyConditionalBody:
+  Enabled: false
+Lint/EmptyExpression:
+  Enabled: false
+Lint/EmptyFile:
+  Enabled: false
+Lint/EmptyWhen:
+  Enabled: false
+Lint/EnsureReturn:
+  Enabled: false
+Lint/Loop:
+  Enabled: false
+Lint/MissingSuper:
+  Enabled: false
+Lint/MixedRegexpCaptureTypes:
+  Enabled: false
+Lint/NumberConversion:
+  Enabled: false
+Lint/ParenthesesAsGroupedExpression:
+  Enabled: false
+Lint/RedundantStringCoercion:
+  Enabled: false
+Lint/ShadowedArgument:
+  Enabled: false
+Lint/ShadowedException:
+  Enabled: false
+Lint/ShadowingOuterLocalVariable:
+  Enabled: false
+Lint/SuppressedException:
+  Enabled: false
+Lint/UnusedBlockArgument:
+  Enabled: false
+Lint/UnusedMethodArgument:
+  Enabled: false

data/README.md

@@ -0,0 +1,43 @@
+# acts_as_account
+
+[![Build Status](https://github.com/betterplace/acts_as_account/workflows/tests/badge.svg)](https://github.com/jaynetics/js_regex/actions)
+
+## Theory
+
+*ActsAsAccount* implements a "Double Entry Accounting" system for your
+Rails-models.
+
+It hooks into ActiveRecord and allows to add accounts to any model by
+simply means of adding `has_account` to your model. Because the accounts
+are connected via a `has_many` relation no migration to the account-holder
+tables is needed.
+
+We also hook into the ActionController request cycle to warn the developer
+if a request has left uncommitted changes in the system.
+
+## How to test
+
+Run the cucumber features from the acs_as_account gem, just execute
+* `rake features:create_database`
+* `cucumber`
+
+## How to release
+
+You need to update the data in `VERSION` and Rakefile and run `rake` (because it uses Gemhadar).
+`rake gem:push` will push the version to rubygems.
+
+## Links
+
+* Double Entry Accounting in a Relational Database: [http://homepages.tcp.co.uk/~m-wigley/gc_wp_ded.html (archived)](https://web.archive.org/web/20080310200243/http://homepages.tcp.co.uk/~m-wigley/gc_wp_ded.html)
+
+## Compatibility
+
+Rails 4 is supported since version 3.1.0, Rails 7 since 3.2.2 .
+
+## Credits
+
+This gem was written for the payment backend of betterplace.org by [Thies C. Arntzen, "thieso2"](https://github.com/thieso2), [Norman Timmler, "unnu"](https://github.com/unnu) and others.
+
+## Copyright
+
+Copyright (c) 2010, 2022 [gut.org gAG](https://gut.org), released under the [Apache License v2.0](LICENSE).

data/Rakefile

@@ -6,43 +6,38 @@ GemHadar do
   name        'acts_as_account'
   author      [ "Thies C. Arntzen, Norman Timmler, Matthias Frick, Phillip Oertel" ]
   email       'developers@betterplace.org'
-  homepage    "http://github.com/betterplace/acts_as_account"
+  homepage    "https://github.com/betterplace/acts_as_account"
   summary     'acts_as_account implements double entry accounting for Rails models'
   description 'acts_as_account implements double entry accounting for Rails models. Your models get accounts and you can do consistent transactions between them. Since the documentation is sparse, see the transfer.feature for usage examples.'
   test_dir    'tests'
   ignore      '.*.sw[pon]', 'pkg', 'Gemfile.lock', 'coverage', '.rvmrc',
     '.AppleDouble', 'tags', '.byebug_history', '.DS_Store'
-  readme      'README.rdoc'
+  readme      'README.md'
   title       "#{name.camelize} -- More Math in Ruby"
   licenses << 'Apache-2.0'
 
-  dependency 'activerecord',         '>= 4.1', '<6'
-  dependency 'actionpack'  ,         '>= 4.1', '<6'
-  dependency 'database_cleaner',     '~> 1.3'
+  dependency 'activerecord',         '>= 5.1', '<8'
+  dependency 'actionpack'  ,         '>= 4.1', '<8'
   development_dependency 'cucumber', '~> 1.3'
-  development_dependency 'mysql2'
+  development_dependency 'sqlite3'
   development_dependency 'rspec',    '~> 3.1'
   development_dependency 'simplecov'
-  development_dependency 'complex_config'
+  development_dependency 'database_cleaner',     '~> 1.3'
+  development_dependency 'rubocop'
 end
 
 def connect_database
   require 'active_record'
-  require 'complex_config'
-  config = ComplexConfig::Provider.config 'features/db/database.yml'
-  connection_config = config.acts_as_account.to_h
-  connection_config.delete(:database)
-  ActiveRecord::Base.establish_connection(connection_config).connection
+  require 'yaml'
+  db_config = YAML.load_file('features/db/database.yml')
+  ActiveRecord::Base.establish_connection(db_config).connection
 end
 
 namespace :features do
   desc "create test database out of db/schema.rb"
   task :create_database do
-    conn = connect_database
-    conn.execute('DROP DATABASE IF EXISTS acts_as_account')
-    conn.execute('CREATE DATABASE acts_as_account')
-    conn.execute('USE acts_as_account')
-    load(File.dirname(__FILE__) + '/features/db/schema.rb')
+    connect_database
+    load("#{__dir__}/features/db/schema.rb")
   end
 end
 

data/VERSION

@@ -1 +1 @@
-3.2.0
+3.2.3

data/acts_as_account.gemspec

@@ -1,57 +1,47 @@
 # -*- encoding: utf-8 -*-
-# stub: acts_as_account 3.2.0 ruby lib
+# stub: acts_as_account 3.2.3 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "acts_as_account".freeze
-  s.version = "3.2.0"
+  s.version = "3.2.3"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]
   s.authors = ["Thies C. Arntzen, Norman Timmler, Matthias Frick, Phillip Oertel".freeze]
-  s.date = "2016-12-08"
+  s.date = "2022-07-20"
   s.description = "acts_as_account implements double entry accounting for Rails models. Your models get accounts and you can do consistent transactions between them. Since the documentation is sparse, see the transfer.feature for usage examples.".freeze
   s.email = "developers@betterplace.org".freeze
-  s.extra_rdoc_files = ["README.rdoc".freeze, "lib/acts_as_account.rb".freeze, "lib/acts_as_account/account.rb".freeze, "lib/acts_as_account/active_record_extensions.rb".freeze, "lib/acts_as_account/global_account.rb".freeze, "lib/acts_as_account/journal.rb".freeze, "lib/acts_as_account/manually_created_account.rb".freeze, "lib/acts_as_account/posting.rb".freeze, "lib/acts_as_account/rails.rb".freeze, "lib/acts_as_account/transfer.rb".freeze, "lib/acts_as_account/version.rb".freeze]
-  s.files = [".gitignore".freeze, ".travis.yml".freeze, "CHANGELOG.md".freeze, "Gemfile".freeze, "LICENSE".freeze, "README.rdoc".freeze, "Rakefile".freeze, "VERSION".freeze, "acts_as_account.gemspec".freeze, "cucumber.yml".freeze, "features/account/account_creation.feature".freeze, "features/db/database.yml".freeze, "features/db/schema.rb".freeze, "features/step_definitions/account_steps.rb".freeze, "features/support/abstract_user.rb".freeze, "features/support/cheque.rb".freeze, "features/support/env.rb".freeze, "features/support/inheriting_user.rb".freeze, "features/support/user.rb".freeze, "features/transfer/journal_creation.feature".freeze, "features/transfer/transfer.feature".freeze, "init.rb".freeze, "lib/acts_as_account.rb".freeze, "lib/acts_as_account/account.rb".freeze, "lib/acts_as_account/active_record_extensions.rb".freeze, "lib/acts_as_account/global_account.rb".freeze, "lib/acts_as_account/journal.rb".freeze, "lib/acts_as_account/manually_created_account.rb".freeze, "lib/acts_as_account/posting.rb".freeze, "lib/acts_as_account/rails.rb".freeze, "lib/acts_as_account/transfer.rb".freeze, "lib/acts_as_account/version.rb".freeze]
-  s.homepage = "http://github.com/betterplace/acts_as_account".freeze
+  s.extra_rdoc_files = ["README.md".freeze, "lib/acts_as_account.rb".freeze, "lib/acts_as_account/account.rb".freeze, "lib/acts_as_account/active_record_extensions.rb".freeze, "lib/acts_as_account/global_account.rb".freeze, "lib/acts_as_account/journal.rb".freeze, "lib/acts_as_account/manually_created_account.rb".freeze, "lib/acts_as_account/posting.rb".freeze, "lib/acts_as_account/rails.rb".freeze, "lib/acts_as_account/transfer.rb".freeze, "lib/acts_as_account/version.rb".freeze]
+  s.files = [".github/workflows/lint.yml".freeze, ".github/workflows/tests.yml".freeze, ".gitignore".freeze, ".rubocop.yml".freeze, "CHANGELOG.md".freeze, "Gemfile".freeze, "LICENSE".freeze, "README.md".freeze, "Rakefile".freeze, "VERSION".freeze, "acts_as_account.gemspec".freeze, "acts_as_account.sqlite".freeze, "cucumber.yml".freeze, "features/account/account_creation.feature".freeze, "features/db/database.yml".freeze, "features/db/schema.rb".freeze, "features/step_definitions/account_steps.rb".freeze, "features/support/abstract_user.rb".freeze, "features/support/cheque.rb".freeze, "features/support/env.rb".freeze, "features/support/inheriting_user.rb".freeze, "features/support/user.rb".freeze, "features/transfer/journal_creation.feature".freeze, "features/transfer/transfer.feature".freeze, "init.rb".freeze, "lib/acts_as_account.rb".freeze, "lib/acts_as_account/account.rb".freeze, "lib/acts_as_account/active_record_extensions.rb".freeze, "lib/acts_as_account/global_account.rb".freeze, "lib/acts_as_account/journal.rb".freeze, "lib/acts_as_account/manually_created_account.rb".freeze, "lib/acts_as_account/posting.rb".freeze, "lib/acts_as_account/rails.rb".freeze, "lib/acts_as_account/transfer.rb".freeze, "lib/acts_as_account/version.rb".freeze]
+  s.homepage = "https://github.com/betterplace/acts_as_account".freeze
   s.licenses = ["Apache-2.0".freeze]
-  s.rdoc_options = ["--title".freeze, "ActsAsAccount -- More Math in Ruby".freeze, "--main".freeze, "README.rdoc".freeze]
-  s.rubygems_version = "2.6.8".freeze
+  s.rdoc_options = ["--title".freeze, "ActsAsAccount -- More Math in Ruby".freeze, "--main".freeze, "README.md".freeze]
+  s.rubygems_version = "3.3.3".freeze
   s.summary = "acts_as_account implements double entry accounting for Rails models".freeze
 
   if s.respond_to? :specification_version then
     s.specification_version = 4
+  end
 
-    if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
-      s.add_development_dependency(%q<gem_hadar>.freeze, ["~> 1.9.1"])
-      s.add_development_dependency(%q<cucumber>.freeze, ["~> 1.3"])
-      s.add_development_dependency(%q<mysql2>.freeze, [">= 0"])
-      s.add_development_dependency(%q<rspec>.freeze, ["~> 3.1"])
-      s.add_development_dependency(%q<simplecov>.freeze, [">= 0"])
-      s.add_development_dependency(%q<complex_config>.freeze, [">= 0"])
-      s.add_runtime_dependency(%q<activerecord>.freeze, ["< 6", ">= 4.1"])
-      s.add_runtime_dependency(%q<actionpack>.freeze, ["< 6", ">= 4.1"])
-      s.add_runtime_dependency(%q<database_cleaner>.freeze, ["~> 1.3"])
-    else
-      s.add_dependency(%q<gem_hadar>.freeze, ["~> 1.9.1"])
-      s.add_dependency(%q<cucumber>.freeze, ["~> 1.3"])
-      s.add_dependency(%q<mysql2>.freeze, [">= 0"])
-      s.add_dependency(%q<rspec>.freeze, ["~> 3.1"])
-      s.add_dependency(%q<simplecov>.freeze, [">= 0"])
-      s.add_dependency(%q<complex_config>.freeze, [">= 0"])
-      s.add_dependency(%q<activerecord>.freeze, ["< 6", ">= 4.1"])
-      s.add_dependency(%q<actionpack>.freeze, ["< 6", ">= 4.1"])
-      s.add_dependency(%q<database_cleaner>.freeze, ["~> 1.3"])
-    end
+  if s.respond_to? :add_runtime_dependency then
+    s.add_development_dependency(%q<gem_hadar>.freeze, ["~> 1.11.0"])
+    s.add_development_dependency(%q<cucumber>.freeze, ["~> 1.3"])
+    s.add_development_dependency(%q<sqlite3>.freeze, [">= 0"])
+    s.add_development_dependency(%q<rspec>.freeze, ["~> 3.1"])
+    s.add_development_dependency(%q<simplecov>.freeze, [">= 0"])
+    s.add_development_dependency(%q<database_cleaner>.freeze, ["~> 1.3"])
+    s.add_development_dependency(%q<rubocop>.freeze, [">= 0"])
+    s.add_runtime_dependency(%q<activerecord>.freeze, [">= 5.1", "< 8"])
+    s.add_runtime_dependency(%q<actionpack>.freeze, [">= 4.1", "< 8"])
   else
-    s.add_dependency(%q<gem_hadar>.freeze, ["~> 1.9.1"])
+    s.add_dependency(%q<gem_hadar>.freeze, ["~> 1.11.0"])
     s.add_dependency(%q<cucumber>.freeze, ["~> 1.3"])
-    s.add_dependency(%q<mysql2>.freeze, [">= 0"])
+    s.add_dependency(%q<sqlite3>.freeze, [">= 0"])
     s.add_dependency(%q<rspec>.freeze, ["~> 3.1"])
     s.add_dependency(%q<simplecov>.freeze, [">= 0"])
-    s.add_dependency(%q<complex_config>.freeze, [">= 0"])
-    s.add_dependency(%q<activerecord>.freeze, ["< 6", ">= 4.1"])
-    s.add_dependency(%q<actionpack>.freeze, ["< 6", ">= 4.1"])
     s.add_dependency(%q<database_cleaner>.freeze, ["~> 1.3"])
+    s.add_dependency(%q<rubocop>.freeze, [">= 0"])
+    s.add_dependency(%q<activerecord>.freeze, [">= 5.1", "< 8"])
+    s.add_dependency(%q<actionpack>.freeze, [">= 4.1", "< 8"])
   end
 end

data/features/db/database.yml

@@ -1,6 +1,5 @@
-acts_as_account:
-  adapter: mysql2
-  encoding: utf8
-  database: acts_as_account
-  username: root
-  host: localhost
+adapter: sqlite3
+encoding: utf8
+database: acts_as_account.sqlite
+username: root
+host: localhost

data/features/db/schema.rb

@@ -1,69 +1,64 @@
-ActiveRecord::Schema.define(:version => 1) do
+ActiveRecord::Schema.define(version: 1) do
   if ENV['DROP_FK']
     execute "ALTER TABLE acts_as_account_postings DROP FOREIGN KEY account_id"
     execute "ALTER TABLE acts_as_account_postings DROP FOREIGN KEY other_account_id"
     execute "ALTER TABLE acts_as_account_postings DROP FOREIGN KEY journal_id"
   end
-  
-  create_table "acts_as_account_accounts", :force => true do |t|
-    t.integer  "holder_id", :null => false
-    t.string   "holder_type", :null => false
-    t.string   "name", :null => false
-    
-    t.integer  "balance", :default => 0
-    t.integer  "postings_count", :default => 0
-    t.datetime  "last_valuta"
-    
-    t.datetime "created_at"
-    t.datetime "updated_at"
+
+  create_table "acts_as_account_accounts", force: true do |t|
+    t.belongs_to  "holder", null: false
+    t.string      "holder_type", null: false
+    t.string      "name", null: false
+
+    t.integer     "balance", default: 0
+    t.integer     "postings_count", default: 0
+    t.datetime    "last_valuta"
+
+    t.datetime    "created_at"
+    t.datetime    "updated_at"
   end
-  add_index "acts_as_account_accounts", ["holder_id", "holder_type", "name"], :name => 'account_unique', :unique => true
+  add_index "acts_as_account_accounts", ["holder_id", "holder_type", "name"], name: 'account_unique', unique: true
 
-  create_table "acts_as_account_journals", :force => true do |t|
+  create_table "acts_as_account_journals", force: true do |t|
     t.datetime "created_at"
     t.datetime "updated_at"
   end
 
-  create_table "acts_as_account_postings", :force => true do |t|
-    t.integer "account_id", :null => false
-    t.integer "other_account_id", :null => false
-    t.integer "journal_id", :null => false
-    t.integer "amount", :null => false
-    
-    t.integer "reference_id"
-    t.string "reference_type"
+  create_table "acts_as_account_postings", force: true do |t|
+    t.belongs_to "account", null: false, index: true
+    t.belongs_to "other_account", null: false
+    t.belongs_to "journal", null: false, index: true
+    t.integer    "amount", null: false
 
-    t.datetime "valuta"
+    t.belongs_to "reference"
+    t.string     "reference_type"
 
-    t.datetime "created_at"
-    t.datetime "updated_at"
+    t.datetime   "valuta"
+
+    t.datetime   "created_at"
+    t.datetime   "updated_at"
   end
-  add_index "acts_as_account_postings", "account_id"
-  add_index "acts_as_account_postings", "journal_id"
-  add_index "acts_as_account_postings", ["reference_type", "reference_id"], :name => "reference"
-  add_index "acts_as_account_postings", ["valuta", "id"], :name => "sort_key"
-  
-  execute "ALTER TABLE acts_as_account_postings ADD CONSTRAINT account_id FOREIGN KEY (account_id) REFERENCES acts_as_account_accounts (id)"
-  execute "ALTER TABLE acts_as_account_postings ADD CONSTRAINT other_account_id FOREIGN KEY (other_account_id) REFERENCES acts_as_account_accounts (id)"
-  execute "ALTER TABLE acts_as_account_postings ADD CONSTRAINT journal_id FOREIGN KEY (journal_id) REFERENCES acts_as_account_journals (id)"
+  add_index "acts_as_account_postings", ["reference_type", "reference_id"], name: "reference"
+  add_index "acts_as_account_postings", ["valuta", "id"], name: "sort_key"
 
-  create_table "acts_as_account_global_accounts", :force => true do |t|
-    t.string   "name", :null => false
+  create_table "acts_as_account_global_accounts", force: true do |t|
+    t.string   "name", null: false
   end
 
-  create_table "users", :force => true do |t|
-    t.string   "name", :null => false
+  create_table "users", force: true do |t|
+    t.string   "name", null: false
     t.datetime "created_at"
     t.datetime "updated_at"
   end
 
-  create_table "abstract_users", :force => true do |t|
-    t.string   "name", :null => false
-    t.string   "type", :null => false
+  create_table "abstract_users", force: true do |t|
+    t.string   "name", null: false
+    t.string   "type", null: false
     t.datetime "created_at"
     t.datetime "updated_at"
   end
-  create_table "cheques", :force => true do |t|
+
+  create_table "cheques", force: true do |t|
     t.string "number"
     t.datetime "created_at"
     t.datetime "updated_at"

data/features/step_definitions/account_steps.rb

@@ -2,6 +2,11 @@
 
 include ActsAsAccount
 
+require 'rspec'
+RSpec.configure do |config|
+  config.expect_with(:rspec) { |c| c.syntax = :should }
+end
+
 def german_date_time_to_local(datestring, timestring)
   Time.local(*(datestring.split(".").reverse + timestring.split(":")).map(&:to_i))
 end
@@ -89,7 +94,7 @@ When /^I create a Journal via (.+)$/ do |method|
     eval <<-EOT
     @journal = Journal.#{method}
     EOT
-  rescue Exception => @last_exception
+  rescue => @last_exception
   end
 end
 
@@ -147,7 +152,7 @@ end
 
 Then /^the order of the postings is correct$/ do
   # make sure we always book "Soll an Haben"
-  Posting.all.in_groups_of(2) do |from, to|
+  Posting.all.each_slice(2) do |from, to|
     from.amount.should be < 0
     to.amount.should be > 0
   end

data/features/support/env.rb

@@ -6,20 +6,20 @@ if ENV['START_SIMPLECOV'].to_i == 1
 end
 
 require 'acts_as_account'
-require 'complex_config'
-config =ComplexConfig::Provider.config File.dirname(__FILE__) + '/../db/database.yml'
-ActiveRecord::Base.establish_connection(config.acts_as_account.to_h)
+require 'yaml'
+db_config = YAML.load_file(__dir__ + '/../db/database.yml')
+ActiveRecord::Base.establish_connection(db_config)
 
 require 'database_cleaner'
 require 'database_cleaner/cucumber'
 DatabaseCleaner.strategy = :transaction
 
-Dir[File.dirname(__FILE__) + '/../step_definitions/*.rb'].each { |file| require file }
+Dir["#{__dir__}/../step_definitions/*.rb"].sort.each { |file| require file }
 
-require File.dirname(__FILE__) + '/user'
-require File.dirname(__FILE__) + '/abstract_user'
-require File.dirname(__FILE__) + '/inheriting_user'
-require File.dirname(__FILE__) + '/cheque'
+require_relative 'user'
+require_relative 'abstract_user'
+require_relative 'inheriting_user'
+require_relative 'cheque'
 
 After do
   ActsAsAccount::Journal.clear_current

data/lib/acts_as_account/account.rb

@@ -53,7 +53,7 @@ module ActsAsAccount
         yield
 
       # Trying to create a duplicate key on a unique index raises StatementInvalid
-      rescue ActiveRecord::StatementInvalid => e
+      rescue ActiveRecord::StatementInvalid
         record = if attributes[:holder]
           attributes[:holder].account(attributes[:name])
         else

data/lib/acts_as_account/journal.rb

@@ -21,7 +21,7 @@ module ActsAsAccount
 
     def transfers
       [].tap do |transfers|
-        postings.in_groups_of(2) { |postings| transfers << Transfer.new(*postings) }
+        postings.each_slice(2) { |postings| transfers << Transfer.new(*postings) }
       end
     end
 

data/lib/acts_as_account/posting.rb

@@ -12,11 +12,11 @@ module ActsAsAccount
     scope :soll,       -> { where('amount >= 0') }
     scope :haben,      -> { where('amount < 0') }
     scope :start_date, -> date {
-      date = Time.parse(date.to_s).utc.to_s(:db)
+      date = Time.parse(date.to_s).utc.to_fs(:db)
       where(['valuta >= ?', date])
     }
     scope :end_date,   -> date {
-      date = Time.parse(date.to_s).utc.to_s(:db)
+      date = Time.parse(date.to_s).utc.to_fs(:db)
       where(['valuta <= ?', date])
     }
   end

data/lib/acts_as_account/version.rb

@@ -1,6 +1,6 @@
 module ActsAsAccount
   # ActsAsAccount version
-  VERSION         = '3.2.0'
+  VERSION         = '3.2.3'
   VERSION_ARRAY   = VERSION.split('.').map(&:to_i) # :nodoc:
   VERSION_MAJOR   = VERSION_ARRAY[0] # :nodoc:
   VERSION_MINOR   = VERSION_ARRAY[1] # :nodoc:

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: acts_as_account
 version: !ruby/object:Gem::Version
-  version: 3.2.0
+  version: 3.2.3
 platform: ruby
 authors:
 - Thies C. Arntzen, Norman Timmler, Matthias Frick, Phillip Oertel
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2016-12-08 00:00:00.000000000 Z
+date: 2022-07-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gem_hadar
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.9.1
+        version: 1.11.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.9.1
+        version: 1.11.0
 - !ruby/object:Gem::Dependency
   name: cucumber
   requirement: !ruby/object:Gem::Requirement
@@ -39,7 +39,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
-  name: mysql2
+  name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -81,7 +81,21 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: complex_config
+  name: database_cleaner
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.3'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.3'
+- !ruby/object:Gem::Dependency
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -100,20 +114,20 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.1'
+        version: '5.1'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '6'
+        version: '8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.1'
+        version: '5.1'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '6'
+        version: '8'
 - !ruby/object:Gem::Dependency
   name: actionpack
   requirement: !ruby/object:Gem::Requirement
@@ -123,7 +137,7 @@ dependencies:
         version: '4.1'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '6'
+        version: '8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -133,21 +147,7 @@ dependencies:
         version: '4.1'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '6'
-- !ruby/object:Gem::Dependency
-  name: database_cleaner
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.3'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '8'
 description: acts_as_account implements double entry accounting for Rails models.
   Your models get accounts and you can do consistent transactions between them. Since
   the documentation is sparse, see the transfer.feature for usage examples.
@@ -155,7 +155,7 @@ email: developers@betterplace.org
 executables: []
 extensions: []
 extra_rdoc_files:
-- README.rdoc
+- README.md
 - lib/acts_as_account.rb
 - lib/acts_as_account/account.rb
 - lib/acts_as_account/active_record_extensions.rb
@@ -167,15 +167,18 @@ extra_rdoc_files:
 - lib/acts_as_account/transfer.rb
 - lib/acts_as_account/version.rb
 files:
+- ".github/workflows/lint.yml"
+- ".github/workflows/tests.yml"
 - ".gitignore"
-- ".travis.yml"
+- ".rubocop.yml"
 - CHANGELOG.md
 - Gemfile
 - LICENSE
-- README.rdoc
+- README.md
 - Rakefile
 - VERSION
 - acts_as_account.gemspec
+- acts_as_account.sqlite
 - cucumber.yml
 - features/account/account_creation.feature
 - features/db/database.yml
@@ -199,16 +202,16 @@ files:
 - lib/acts_as_account/rails.rb
 - lib/acts_as_account/transfer.rb
 - lib/acts_as_account/version.rb
-homepage: http://github.com/betterplace/acts_as_account
+homepage: https://github.com/betterplace/acts_as_account
 licenses:
 - Apache-2.0
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options:
 - "--title"
 - ActsAsAccount -- More Math in Ruby
 - "--main"
-- README.rdoc
+- README.md
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
@@ -222,9 +225,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.8
-signing_key: 
+rubygems_version: 3.3.3
+signing_key:
 specification_version: 4
 summary: acts_as_account implements double entry accounting for Rails models
 test_files: []

data/.travis.yml

@@ -1,4 +0,0 @@
-rvm:
-  - 2.3.3
-sudo: false
-script: rake

data/README.rdoc

@@ -1,42 +0,0 @@
-= acts_as_account
-
-{<img src="https://travis-ci.org/betterplace/acts_as_account.svg?branch=master" alt="Build Status" />}[https://travis-ci.org/betterplace/acts_as_account]
-
-== Theory
-
-ActsAsAccount implements a "Double Entry Accounting" system for your
-Rails-models.
-
-It hooks into ActiveRecord and allows to add accounts to any model by
-simply means of adding "has_account" to your model. Because the accounts
-are connected via a has_many relation no migration to the account-holder
-tables is needed.
-
-We also hook into the ActionController request cycle to warn the developer
-if a request has left the uncommitted changes in the system.
-
-== Support
-
-Rails 4 is supported since version 3.1.0
-
-== How to test
-
-Run the cucumber features from the acs_as_account gem, just execute
-* rake features:create_database
-* cucumber
-
-== Links
-
-* Double Entry Accounting in a Relational Database: http://homepages.tcp.co.uk/~m-wigley/gc_wp_ded.html
-
-== Compatibility
-
-With the release of version 2.0.0 acts_as_account is supposed to work for Rails 3. If you still use Rails 2 please use version 1.2.0.
-
-== Credits
-
-This gem was written for the payment backend of betterplace.org by Thies C. Arntzen (http://github.com/thieso2) and Norman Timmler (github.com/unnu).
-
-== Copyright
-
-Copyright (c) 2010 gut.org gAG