acts_as 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 514a5965f8825f4c4bc1f2cb8155585c042f891c
-  data.tar.gz: 81513cdac4a29c051fd3be2240e0b9cc1a3f74b7
+  metadata.gz: f6e9ee1715570c9e8a97e3212b76ad5a66fb65bb
+  data.tar.gz: 38bc6aa48979d056cf86ec03903d741d1200eabe
 SHA512:
-  metadata.gz: fa3a00abcba6a4fe27727232a9a3b142d5934343106417147d703fe2707a973793c642ff861fb7f0bcb3de54cbb668946b03cfaaa14286e0251f7b88f0430ae0
-  data.tar.gz: 0608465f2b7ffa2f0027df6bed6113253da3acafdc3c37e2ea590d564af6c045702e2374d6cce49c75e700886e2ab512bf7a49356344002db34deeb12183edff
+  metadata.gz: 8ec4605e84506cf2765025d68812542c37ae548400f6176e78b3d313abe97acbe71eada88542baafdb4d6346c4d0156e4483c7d653b29b62a1060ebe0b4cfb23
+  data.tar.gz: 6c055ebd63e0abc5a1c00aa472333cfa88b8a3d924bcc574c9b9a08aef5353ef655d7a951188d1955644b4f099678dfc429181298cdc7a3c2113ee47e72b7134

data/README.md

@@ -82,16 +82,15 @@ Now a whole slew of methods related to ActiveRecord attributes are available for
     # Any method you want
     rebel.delegate_at_will #=> '10'
 
+## Automagical joins through .where Hash syntax
 
-## Roadmap / Ideas
+    Just get to what you want
 
-How does the active record join hash-parsing stuff work? EX-
-
-    Rebel.joins(:clan).where(clan: {cool: true)
-
-Can we make this work for ruby-sql autojoins? Is that even a good idea?
+```ruby
+    Rebel.where(strength: 10) #=> the same as Rebel.joins(:clan).where(clan: {strength: 10)
+```
 
-    Rebel.where(cool: true) #auto-joins :clan and queries clans table
+    One major caveat, it only works for first-level attributes at the moment. (see pending spec)
 
 ## Contributing
 

data/lib/acts_as/version.rb

@@ -1,3 +1,3 @@
 module ActsAs
-  VERSION = "0.3.0"
+  VERSION = "0.3.1"
 end

data/lib/acts_as.rb

@@ -56,9 +56,11 @@ module ActsAs
       relation = super
       #TODO support nested attribute joins like Guns.where(rebels: {strength: 10}))
       # for now, only first level joins will happen automagically
-      detected_associations = opts.keys.map {|attr| acts_as_fields_match(attr) }
-                                       .reject {|attr| attr.nil?}
-      return relation.joins(detected_associations) if detected_associations.any?
+      if opts.is_a? Hash
+        detected_associations = opts.keys.map {|attr| acts_as_fields_match(attr) }
+                                         .reject {|attr| attr.nil?}
+        return relation.joins(detected_associations) if detected_associations.any?
+      end
       relation
     end
 

data/spec/acts_as_spec.rb

@@ -104,9 +104,12 @@ describe ActsAs do
   end
 
   describe 'automagic .where hash syntax helpers' do
-    it 'should auto-expand acted attributes' do
+    it 'should auto-expand acted hash attributes' do
       Rebel.where(strength: rebel.strength).should include(rebel)
       Rebel.where(strength: rebel.strength, name: 'Jimbo').should_not include(rebel)
+      expect {
+        Rebel.where('strength = ?', 12).any?
+      }.to raise_error(ActiveRecord::StatementInvalid)
     end
 
     it 'should auto-expand acted attribuets that are nested as well' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: acts_as
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - winfred