acts-as-taggable-on 3.5.0 → 4.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 92222646174fc38e87d9972cea2022c78e9ba337
-  data.tar.gz: 62d819d54ea8d538ce67d1f30c4c640e63333328
+  metadata.gz: 8ab1dc9bc4d03cd7fb2396284190f76719bc4a40
+  data.tar.gz: 8bbb5a13b5a1cc54aea59cb1ab6e524c31ea530c
 SHA512:
-  metadata.gz: 6a17ce74f9d91e98037faa3348449813632f2f1ba2a4ca92a297beaafa8e544b650c2e12586c03a9aab8c2c6b0b5c1c1de21571d860be49aed971b0d20b8338e
-  data.tar.gz: d50ea8e8200c3eaef6f1d80b53412637604e74de62dd3a2e6385e22d1fbf579bbb372f2bbd9b6c026f3f062e4959a288a5a890360d5f98cde6df222ebc72947f
+  metadata.gz: 901d4fb2dd642138c9d8b918d49eee90a86a0ea78596c37753197583b8c4068c08068077e8917bacc0b43ff0272613002aab6670a437ef9ac98a90910f11e522
+  data.tar.gz: 6c0f2e8dc6157b6ea854f63456c4eaa9fc0c754d46dd419ad0a184dd76eb69c3f7486591dfe156d3a224918fcd8d81a13a90661503e216ff21730d98a5d59e52

data/.gitignore

@@ -9,3 +9,5 @@ tmp*.sw?
 tmp
 *.gem
 *.lock
+
+/.idea

data/.travis.yml

@@ -1,11 +1,11 @@
 language: ruby
+cache: bundler
 
 rvm:
+  - 2.3.1
+  - 2.2.5
   - 2.1
-  - 2.2
   - 2.0.0
-  - 1.9.3
-  - rbx-2
 
 env:
   - DB=sqlite3
@@ -13,28 +13,24 @@ env:
   - DB=postgresql
 
 gemfile:
-  - gemfiles/activerecord_3.2.gemfile
-  - gemfiles/activerecord_4.0.gemfile
+  - gemfiles/activerecord_5.0.gemfile
+  - gemfiles/activerecord_4.2.gemfile
   - gemfiles/activerecord_4.1.gemfile
+  - gemfiles/activerecord_4.0.gemfile
 
 sudo: false
 
 bundler_args: '--without local_development --jobs 3 --retry 3'
 
+before_install:
+   - gem install bundler
+
 script: bundle exec rake
 
 matrix:
-  fast_finish: true
-  allow_failures:
-      - gemfile: gemfiles/activerecord_edge.gemfile
-      - rvm: rbx-2
   exclude:
-      - rvm: 2.2
-        gemfile: gemfiles/activerecord_3.2.gemfile
-      - rvm: 1.9.3
-        gemfile: gemfiles/activerecord_4.0.gemfile
-      - rvm: 1.9.3
-        gemfile: gemfiles/activerecord_4.1.gemfile
-      - rvm: rbx-2
-        gemfile: gemfiles/activerecord_3.2.gemfile
-
+    - rvm: 2.0.0
+      gemfile: gemfiles/activerecord_5.0.gemfile
+    - rvm: 2.1
+      gemfile: gemfiles/activerecord_5.0.gemfile
+  fast_finish: true

data/Appraisals

@@ -1,16 +1,17 @@
-appraise "activerecord-3.2" do
-  gem "activerecord", github: "rails/rails" , branch: '3-2-stable'
+appraise 'activerecord-5.0' do
+  gem 'activerecord', "~> 5.0.0"
 end
 
-appraise "activerecord-4.0" do
-  gem "activerecord", github: "rails/rails" , branch: '4-0-stable'
+appraise "activerecord-4.2" do
+  gem "activerecord", "~> 4.2.0"
 end
 
 appraise "activerecord-4.1" do
-  gem "activerecord", github: "rails/rails" , branch: '4-1-stable'
+  gem "activerecord", "~> 4.1.0"
+  gem 'mysql2', '~> 0.3.21'
 end
 
-appraise "activerecord-4.2" do
-  gem "railties", github: "rails/rails" , branch: '4-2-stable'
-  gem "activerecord", github: "rails/rails"  , branch: '4-2-stable'
+appraise "activerecord-4.0" do
+  gem "activerecord", "~> 4.0.0"
+  gem 'mysql2', '~> 0.3.21'
 end

data/CHANGELOG.md

@@ -4,10 +4,12 @@ Each change should fall into categories that would affect whether the release is
 
 As such, a _Feature_ would map to either major or minor. A _bug fix_ to a patch.  And _misc_ is either minor or patch, the difference being kind of fuzzy for the purposes of history.  Adding tests would be patch level.
 
-### [3.5.0 / 2015-02-11](https://github.com/mbleigh/acts-as-taggable-on/compare/v3.4.4...v3.5.0)
+### [3.5.0 / 2015-03-03](https://github.com/mbleigh/acts-as-taggable-on/compare/v3.4.4...v3.5.0)
 
   * Fixes
    * [@rikettsie Fixed collation for MySql via rake rule or config parameter](https://github.com/mbleigh/acts-as-taggable-on/pull/634)
+  *Misc
+   * [@pcupueran Add rspec test for tagging_spec completeness]()
 
 ### [3.4.4 / 2015-02-11](https://github.com/mbleigh/acts-as-taggable-on/compare/v3.4.3...v3.4.4)
 

data/Gemfile

@@ -7,5 +7,5 @@ group :local_development do
   gem 'guard-rspec'
   gem 'appraisal'
   gem 'rake'
-  gem 'byebug' , platform: :mri_21
+  gem 'byebug' , platforms: [:mri_21, :mri_22, :mri_23]
 end

data/README.md

@@ -1,4 +1,6 @@
 # ActsAsTaggableOn
+
+[![Join the chat at https://gitter.im/mbleigh/acts-as-taggable-on](https://badges.gitter.im/mbleigh/acts-as-taggable-on.svg)](https://gitter.im/mbleigh/acts-as-taggable-on?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
 [![Gem Version](https://badge.fury.io/rb/acts-as-taggable-on.svg)](http://badge.fury.io/rb/acts-as-taggable-on)
 [![Build Status](https://secure.travis-ci.org/mbleigh/acts-as-taggable-on.png)](http://travis-ci.org/mbleigh/acts-as-taggable-on)
 [![Code Climate](https://codeclimate.com/github/mbleigh/acts-as-taggable-on.png)](https://codeclimate.com/github/mbleigh/acts-as-taggable-on)
@@ -17,22 +19,14 @@ Enter Acts as Taggable On. Rather than tying functionality to a specific keyword
 tag "contexts" that can be used locally or in combination in the same way steroids
 was used.
 
-## Compatibility
-
-Versions 2.x are compatible with Ruby 1.8.7+ and Rails 3.
-
-Versions 2.4.1 and up are compatible with Rails 4 too (thanks to arabonradar and cwoodcox).
 
-Versions >= 3.x are compatible with Ruby 1.9.3+ and Rails 3 and 4.
-
-For an up-to-date roadmap, see https://github.com/mbleigh/acts-as-taggable-on/milestones
 
 ## Installation
 
 To use it, add it to your Gemfile:
 
 ```ruby
-gem 'acts-as-taggable-on', '~> 3.4'
+gem 'acts-as-taggable-on', '~> 4.0'
 ```
 
 and bundle:
@@ -48,8 +42,6 @@ Install migrations
 ```shell
 # For the latest versions :
 rake acts_as_taggable_on_engine:install:migrations
-# For versions 2.4.1 and earlier :
-rails generate acts_as_taggable_on:migration
 ```
 
 Review the generated migrations then migrate :
@@ -73,9 +65,6 @@ rake acts_as_taggable_on_engine:tag_names:collate_bin
 See the Configuration section for more details, and a general note valid for older
 version of the gem.
 
-#### Upgrading
-
-see [UPGRADING](UPGRADING.md)
 
 ## Usage
 
@@ -89,7 +78,7 @@ end
 
 class UsersController < ApplicationController
   def user_params
-    params.require(:user).permit(:name, :tag_list => []) ## Rails 4 strong params usage
+    params.require(:user).permit(:name, :tag_list) ## Rails 4 strong params usage
   end
 end
 
@@ -273,7 +262,7 @@ User.tagged_with("same", :on => :customs) # => [@user]
 
 ### Tag Parsers
 
-If you want to change how tags are parsed, you can define a your own implementation:
+If you want to change how tags are parsed, you can define your own implementation:
 
 ```ruby
 class MyParser < ActsAsTaggableOn::GenericParser
@@ -302,7 +291,7 @@ Now you can use this parser, passing it as parameter:
 Or change it globally:
 
 ```ruby
-ActsAsTaggable.default_parser = MyParser
+ActsAsTaggableOn.default_parser = MyParser
 @user = User.new(:name => "Bobby")
 @user.tag_list = "east|south"
 @user.tag_list # => ["east", "south"]
@@ -331,6 +320,42 @@ Photo.tagged_with("paris", :on => :locations, :owned_by => @some_user)
 @some_user.tag(@some_photo, :with => "paris, normandy", :on => :locations, :skip_save => true) #won't save @some_photo object
 ```
 
+#### Working with Owned Tags
+Note that `tag_list` only returns tags whose taggings do not have an owner. Continuing from the above example:
+```ruby
+@some_photo.tag_list # => []
+```
+To retrieve all tags of an object (regardless of ownership) or if only one owner can tag the object, use `all_tags_list`.
+
+##### Adding owned tags
+Note that **owned tags** are added all at once, in the form of ***comma seperated tags*** in string.
+Also, when you try to add **owned tags** again, it simply overwrites the previous set of **owned tags**.
+So to append tags in previously existing **owned tags** list, go as follows:
+```ruby
+def add_owned_tag 
+    @some_item = Item.find(params[:id])
+    owned_tag_list = @some_item.all_tag_list - @some_item.tag_list
+    owned_tag_list += [(params[:tag])]
+    @tag_owner.tag(@some_item, :with => stringify(owned_tag_list), :on => :tags)
+    @some_item.save   
+end
+
+def stringify(tag_list)
+    tag_list.inject('') { |memo, tag| memo += (tag + ',') }[0..-1]
+end
+```
+##### Removing owned tags
+Similarly as above, removing will be as follows:
+```ruby
+def remove_owned_tag 
+    @some_item = Item.find(params[:id])
+    owned_tag_list = @some_item.all_tag_list - @some_item.tag_list
+    owned_tag_list -= [(params[:tag])]
+    @tag_owner.tag(@some_item, :with => stringify(owned_tag_list), :on => :tags)
+    @some_item.save   
+end
+```
+
 ### Dirty objects
 
 ```ruby
@@ -446,13 +471,25 @@ USE my_wonderful_app_db;
 ALTER TABLE tags MODIFY name VARCHAR(255) CHARACTER SET utf8 COLLATE utf8_bin;
 ```
 
+#### Upgrading
+
+see [UPGRADING](UPGRADING.md)
+
 ## Contributors
 
 We have a long list of valued contributors. [Check them all](https://github.com/mbleigh/acts-as-taggable-on/contributors)
 
-## Maintainer
+## Compatibility
+
+Versions 2.x are compatible with Ruby 1.8.7+ and Rails 3.
+
+Versions 2.4.1 and up are compatible with Rails 4 too (thanks to arabonradar and cwoodcox).
 
-* [Joost Baaij](https://github.com/tilsammans)
+Versions >= 3.x are compatible with Ruby 1.9.3+ and Rails 3 and 4.
+
+Versions >= 4.x are compatible with Ruby 2.0.0+ and Rails 4 and 5.
+
+For an up-to-date roadmap, see https://github.com/mbleigh/acts-as-taggable-on/milestones
 
 ## TODO
 

data/acts-as-taggable-on.gemspec

@@ -16,16 +16,16 @@ Gem::Specification.new do |gem|
   gem.files         = `git ls-files`.split($/)
   gem.test_files    = gem.files.grep(%r{^spec/})
   gem.require_paths = ['lib']
-  gem.required_ruby_version     = '>= 1.9.3'
+  gem.required_ruby_version     = '>= 2.0.0'
 
   if File.exist?('UPGRADING.md')
     gem.post_install_message = File.read('UPGRADING.md')
   end
 
-  gem.add_runtime_dependency 'activerecord',  ['>= 3.2', '< 5']
+  gem.add_runtime_dependency 'activerecord', ['>= 4.0']
 
   gem.add_development_dependency 'sqlite3'
-  gem.add_development_dependency 'mysql2', '~> 0.3.7'
+  gem.add_development_dependency 'mysql2', '~> 0.3'
   gem.add_development_dependency 'pg'
 
   gem.add_development_dependency 'rspec-rails'

data/db/migrate/2_add_missing_unique_indices.rb

@@ -2,7 +2,7 @@ class AddMissingUniqueIndices < ActiveRecord::Migration
   def self.up
     add_index :tags, :name, unique: true
 
-    remove_index :taggings, :tag_id
+    remove_index :taggings, :tag_id if index_exists?(:taggings, :tag_id)
     remove_index :taggings, [:taggable_id, :taggable_type, :context]
     add_index :taggings,
               [:tag_id, :taggable_id, :taggable_type, :context, :tagger_id, :tagger_type],
@@ -13,7 +13,8 @@ class AddMissingUniqueIndices < ActiveRecord::Migration
     remove_index :tags, :name
 
     remove_index :taggings, name: 'taggings_idx'
-    add_index :taggings, :tag_id
+
+    add_index :taggings, :tag_id unless index_exists?(:taggings, :tag_id)
     add_index :taggings, [:taggable_id, :taggable_type, :context]
   end
 end

data/db/migrate/6_add_missing_indexes.rb

@@ -0,0 +1,12 @@
+class AddMissingIndexes < ActiveRecord::Migration
+  def change
+    add_index :taggings, :tag_id
+    add_index :taggings, :taggable_id
+    add_index :taggings, :taggable_type
+    add_index :taggings, :tagger_id
+    add_index :taggings, :context
+
+    add_index :taggings, [:tagger_id, :tagger_type]
+    add_index :taggings, [:taggable_id, :taggable_type, :tagger_id, :context], name: 'taggings_idy'
+  end
+end

data/gemfiles/activerecord_4.0.gemfile

@@ -2,14 +2,15 @@
 
 source "https://rubygems.org"
 
-gem "activerecord", :github => "rails/rails", :branch => "4-0-stable"
+gem "activerecord", "~> 4.0.0"
+gem "mysql2", "~> 0.3.21"
 
 group :local_development do
   gem "guard"
   gem "guard-rspec"
   gem "appraisal"
   gem "rake"
-  gem "byebug", :platform => :mri_21
+  gem "byebug", :platforms => [:mri_21, :mri_22, :mri_23]
 end
 
 gemspec :path => "../"

data/gemfiles/activerecord_4.1.gemfile

@@ -2,14 +2,15 @@
 
 source "https://rubygems.org"
 
-gem "activerecord", :github => "rails/rails", :branch => "4-1-stable"
+gem "activerecord", "~> 4.1.0"
+gem "mysql2", "~> 0.3.21"
 
 group :local_development do
   gem "guard"
   gem "guard-rspec"
   gem "appraisal"
   gem "rake"
-  gem "byebug", :platform => :mri_21
+  gem "byebug", :platforms => [:mri_21, :mri_22, :mri_23]
 end
 
 gemspec :path => "../"

data/gemfiles/activerecord_4.2.gemfile

@@ -2,15 +2,14 @@
 
 source "https://rubygems.org"
 
-gem "railties", :github => "rails/rails", :branch => "4-2-stable"
-gem "activerecord", :github => "rails/rails", :branch => "4-2-stable"
+gem "activerecord", "~> 4.2.0"
 
 group :local_development do
   gem "guard"
   gem "guard-rspec"
   gem "appraisal"
   gem "rake"
-  gem "byebug", :platform => :mri_21
+  gem "byebug", :platforms => [:mri_21, :mri_22, :mri_23]
 end
 
 gemspec :path => "../"

data/gemfiles/{activerecord_3.2.gemfile → activerecord_5.0.gemfile}

@@ -2,14 +2,14 @@
 
 source "https://rubygems.org"
 
-gem "activerecord", :github => "rails/rails", :branch => "3-2-stable"
+gem "activerecord", "~> 5.0.0"
 
 group :local_development do
   gem "guard"
   gem "guard-rspec"
   gem "appraisal"
   gem "rake"
-  gem "byebug", :platform => :mri_21
+  gem "byebug", :platforms => [:mri_21, :mri_22, :mri_23]
 end
 
 gemspec :path => "../"

data/lib/acts-as-taggable-on.rb

@@ -2,7 +2,12 @@ require 'active_record'
 require 'active_record/version'
 require 'active_support/core_ext/module'
 
-require_relative 'acts_as_taggable_on/engine'  if defined?(Rails)
+begin
+  require 'rails/engine'
+  require 'acts_as_taggable_on/engine'
+  rescue LoadError
+
+end
 
 require 'digest/sha1'
 
@@ -13,7 +18,6 @@ module ActsAsTaggableOn
   autoload :TagList
   autoload :GenericParser
   autoload :DefaultParser
-  autoload :TagListParser
   autoload :Taggable
   autoload :Tagger
   autoload :Tagging
@@ -57,9 +61,10 @@ module ActsAsTaggableOn
   end
 
   class Configuration
-    attr_accessor :delimiter, :force_lowercase, :force_parameterize,
-                  :strict_case_match, :remove_unused_tags, :default_parser,
+    attr_accessor :force_lowercase, :force_parameterize,
+                  :remove_unused_tags, :default_parser,
                   :tags_counter
+    attr_reader :delimiter, :strict_case_match
 
     def initialize
       @delimiter = ','
@@ -73,9 +78,7 @@ module ActsAsTaggableOn
     end
 
     def strict_case_match=(force_cs)
-      if @force_binary_collation == false
-        @strict_case_match = force_cs
-      end
+      @strict_case_match = force_cs unless @force_binary_collation
     end
 
     def delimiter=(string)
@@ -89,7 +92,7 @@ WARNING
 
     def force_binary_collation=(force_bin)
       if Utils.using_mysql?
-        if force_bin == true
+        if force_bin
           Configuration.apply_binary_collation(true)
           @force_binary_collation = true
           @strict_case_match = true
@@ -103,10 +106,12 @@ WARNING
     def self.apply_binary_collation(bincoll)
       if Utils.using_mysql?
         coll = 'utf8_general_ci'
-        if bincoll == true
-          coll = 'utf8_bin'
+        coll = 'utf8_bin' if bincoll
+        begin
+          ActiveRecord::Migration.execute("ALTER TABLE #{Tag.table_name} MODIFY name varchar(255) CHARACTER SET utf8 COLLATE #{coll};")
+        rescue Exception => e
+          puts "Trapping #{e.class}: collation parameter ignored while migrating for the first time."
         end
-        ActiveRecord::Migration.execute("ALTER TABLE tags MODIFY name varchar(255) CHARACTER SET utf8 COLLATE #{coll};")
       end
     end
 
@@ -116,7 +121,6 @@ WARNING
 end
 
 ActiveSupport.on_load(:active_record) do
-  extend ActsAsTaggableOn::Compatibility
   extend ActsAsTaggableOn::Taggable
   include ActsAsTaggableOn::Tagger
 end

data/lib/acts_as_taggable_on/engine.rb

@@ -1,4 +1,3 @@
-require 'rails/engine'
 module ActsAsTaggableOn
   class Engine < Rails::Engine
   end

data/lib/acts_as_taggable_on/tag.rb

@@ -2,8 +2,6 @@
 module ActsAsTaggableOn
   class Tag < ::ActiveRecord::Base
 
-    attr_accessible :name if defined?(ActiveModel::MassAssignmentSecurity)
-
     ### ASSOCIATIONS:
 
     has_many :taggings, dependent: :destroy, class_name: '::ActsAsTaggableOn::Tagging'
@@ -50,6 +48,12 @@ module ActsAsTaggableOn
       where(clause)
     end
 
+    def self.for_context(context)
+      joins(:taggings).
+        where(["taggings.context = ?", context]).
+        select("DISTINCT tags.*")
+    end
+
     ### CLASS METHODS:
 
     def self.find_or_create_with_like_by_name(name)

data/lib/acts_as_taggable_on/tag_list.rb

@@ -84,7 +84,8 @@ module ActsAsTaggableOn
       map! { |tag| tag.mb_chars.downcase.to_s } if ActsAsTaggableOn.force_lowercase
       map!(&:parameterize) if ActsAsTaggableOn.force_parameterize
 
-      uniq!
+      ActsAsTaggableOn.strict_case_match ? uniq! : uniq!{ |tag| tag.downcase }
+      self
     end
 
 
@@ -99,18 +100,6 @@ module ActsAsTaggableOn
       args.flatten!
     end
 
-
-    ## DEPRECATED
-    def self.from(string)
-      ActiveRecord::Base.logger.warn <<WARNING
-ActsAsTaggableOn::TagList.from is deprecated \
-and will be removed from v4.0+, use  \
-ActsAsTaggableOn::DefaultParser.new instead
-WARNING
-      @parser.new(string).parse
-    end
-
-
   end
 end
 

data/lib/acts_as_taggable_on/taggable/cache.rb

@@ -73,7 +73,7 @@ module ActsAsTaggableOn::Taggable
         tag_types.map(&:to_s).each do |tag_type|
           if self.class.send("caching_#{tag_type.singularize}_list?")
             if tag_list_cache_set_on(tag_type)
-              list = tag_list_cache_on(tag_type).to_a.flatten.compact.join(', ')
+              list = tag_list_cache_on(tag_type).to_a.flatten.compact.join("#{ActsAsTaggableOn.delimiter} ")
               self["cached_#{tag_type.singularize}_list"] = list
             end
           end

data/lib/acts_as_taggable_on/taggable/collection.rb

@@ -138,7 +138,7 @@ module ActsAsTaggableOn::Taggable
           scoped_ids = pluck(table_name_pkey)
           tagging_scope = tagging_scope.where("#{ActsAsTaggableOn::Tagging.table_name}.taggable_id IN (?)", scoped_ids)
         else
-          tagging_scope = tagging_scope.where("#{ActsAsTaggableOn::Tagging.table_name}.taggable_id IN(#{safe_to_sql(select(table_name_pkey))})")
+          tagging_scope = tagging_scope.where("#{ActsAsTaggableOn::Tagging.table_name}.taggable_id IN(#{safe_to_sql(except(:select).select(table_name_pkey))})")
         end
 
         tagging_scope
@@ -169,9 +169,12 @@ module ActsAsTaggableOn::Taggable
     end
 
     module CalculationMethods
-      def count(column_name=:all, options = {})
+      # Rails 5 TODO: Remove options argument as soon we remove support to
+      # activerecord-deprecated_finders.
+      # See https://github.com/rails/rails/blob/master/activerecord/lib/active_record/relation/calculations.rb#L38
+      def count(column_name = :all, options = {})
         # https://github.com/rails/rails/commit/da9b5d4a8435b744fcf278fffd6d7f1e36d4a4f2
-        super
+        ActsAsTaggableOn::Utils.active_record5? ? super(column_name) : super(column_name, options)
       end
     end
   end

data/lib/acts_as_taggable_on/taggable/core.rb

@@ -23,18 +23,15 @@ module ActsAsTaggableOn::Taggable
           class_eval do
             # when preserving tag order, include order option so that for a 'tags' context
             # the associations tag_taggings & tags are always returned in created order
-            has_many_with_taggable_compatibility context_taggings, as: :taggable,
-                                                 dependent: :destroy,
-                                                 class_name: 'ActsAsTaggableOn::Tagging',
-                                                 order: taggings_order,
-                                                 conditions: {context: tags_type},
-                                                 include: :tag
-
-            has_many_with_taggable_compatibility context_tags, through: context_taggings,
-                                                 source: :tag,
-                                                 class_name: 'ActsAsTaggableOn::Tag',
-                                                 order: taggings_order
-
+            has_many context_taggings, -> { includes(:tag).order(taggings_order).where(context: tags_type) },
+                     as: :taggable,
+                     class_name: ActsAsTaggableOn::Tagging,
+                     dependent: :destroy
+
+            has_many context_tags, -> { order(taggings_order) },
+                     class_name: ActsAsTaggableOn::Tag,
+                     through: context_taggings,
+                     source: :tag
           end
 
           taggable_mixin.class_eval <<-RUBY, __FILE__, __LINE__ + 1
@@ -246,6 +243,14 @@ module ActsAsTaggableOn::Taggable
       def taggable_mixin
         @taggable_mixin ||= Module.new
       end
+
+      private
+
+      # Rails 5 has merged sanitize and quote_value
+      # See https://github.com/rails/rails/blob/master/activerecord/lib/active_record/sanitization.rb#L10
+      def quote_value(value, column = nil)
+        ActsAsTaggableOn::Utils.active_record5? ? super(value) : super(value, column)
+      end
     end
 
     # all column names are necessary for PostgreSQL group clause
@@ -254,7 +259,7 @@ module ActsAsTaggableOn::Taggable
     end
 
     def custom_contexts
-      @custom_contexts ||= []
+      @custom_contexts ||= taggings.map(&:context).uniq
     end
 
     def is_taggable?
@@ -333,7 +338,7 @@ module ActsAsTaggableOn::Taggable
     end
 
     def tagging_contexts
-      custom_contexts + self.class.tag_types.map(&:to_s)
+      self.class.tag_types.map(&:to_s) + custom_contexts
     end
 
     def process_dirty_object(context, new_list)
@@ -407,7 +412,7 @@ module ActsAsTaggableOn::Taggable
 
         # Destroy old taggings:
         if old_tags.present?
-          taggings.not_owned.by_context(context).destroy_all(tag_id: old_tags)
+          taggings.not_owned.by_context(context).where(tag_id: old_tags).destroy_all
         end
 
         # Create new taggings:
@@ -432,7 +437,7 @@ module ActsAsTaggableOn::Taggable
       tag_lists = tag_types.map {|tags_type| "#{tags_type.to_s.singularize}_list"}
       super.delete_if {|attr| tag_lists.include? attr }
     end
-    
+
     ##
     # Override this hook if you wish to subclass {ActsAsTaggableOn::Tag} --
     # context is provided so that you may conditionally use a Tag subclass

data/lib/acts_as_taggable_on/taggable/ownership.rb

@@ -108,9 +108,9 @@ module ActsAsTaggableOn::Taggable
 
           # Find all taggings that belong to the taggable (self), are owned by the owner,
           # have the correct context, and are removed from the list.
-          ActsAsTaggableOn::Tagging.destroy_all(taggable_id: id, taggable_type: self.class.base_class.to_s,
-                                                            tagger_type: owner.class.base_class.to_s, tagger_id: owner.id,
-                                                            tag_id: old_tags, context: context) if old_tags.present?
+          ActsAsTaggableOn::Tagging.where(taggable_id: id, taggable_type: self.class.base_class.to_s,
+                                          tagger_type: owner.class.base_class.to_s, tagger_id: owner.id,
+                                          tag_id: old_tags, context: context).destroy_all if old_tags.present?
 
           # Create new taggings:
           new_tags.each do |tag|