acts-as-taggable-on 3.4.3 → 3.4.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b39b0f1b57946931d609aa449f30102beb5a137a
-  data.tar.gz: 75404df8d0fc7bd5cda6f58cb72cebbda4d18b9c
+  metadata.gz: b3150df9e4bb27c039d1bf451b14848f05867cd1
+  data.tar.gz: 9451664d7c39a2bae61c254f8852b7c65101658c
 SHA512:
-  metadata.gz: 2379d076af6a782a0a6add5be79b8341991e607bcfbd96c45f5fe12bfc2fbf6cca5104d82494636b01ebb8776f3932a8231c199a7b1fc830b8e48bd7321af8aa
-  data.tar.gz: 82c387ff3f37edd3567e7c40f612251939c18702eabd606a711c3aad439d80e2ac4e42464317f5bd24e6bc05f53f3f414c9920064f3eb7982bece02cde56804d
+  metadata.gz: 33408ad30bec8845467d740606689fff474a35ff5440ed15a5320ff2b3a56f2076d557f111409c788c2431f6dfb732a2713b0847880895ed6d5abf7aa86d4bc9
+  data.tar.gz: 402c76125e5b27adbf531c9aeccf971af256b2b4545d92daa31b98a25beb3381820055075b6ae73e03efb7dd1c22495ae737655623b536c4703e7929002b624b

data/CHANGELOG.md

@@ -4,7 +4,7 @@ Each change should fall into categories that would affect whether the release is
 
 As such, a _Feature_ would map to either major or minor. A _bug fix_ to a patch.  And _misc_ is either minor or patch, the difference being kind of fuzzy for the purposes of history.  Adding tests would be patch level.
 
-### Master [changes](https://github.com/mbleigh/acts-as-taggable-on/compare/v3.4.3...master)
+### Master [changes](https://github.com/mbleigh/acts-as-taggable-on/compare/v3.4.4...master)
 
   * Breaking Changes
   * Features
@@ -12,6 +12,11 @@ As such, a _Feature_ would map to either major or minor. A _bug fix_ to a patch.
   * Performance
   * Misc
 
+### [3.4.4 / 2015-02-11](https://github.com/mbleigh/acts-as-taggable-on/compare/v3.4.3...v3.4.4)
+
+  * Fixes
+   * [@d4rky-pl Add context constraint to find_related_* methods](https://github.com/mbleigh/acts-as-taggable-on/pull/629)
+
 
 ### [3.4.3 / 2014-09-26](https://github.com/mbleigh/acts-as-taggable-on/compare/v3.4.2...v3.4.3)
 

data/README.md

@@ -73,7 +73,7 @@ end
 
 class UsersController < ApplicationController
   def user_params
-    params.require(:user).permit(:name, :tag_list) ## Rails 4 strong params usage
+    params.require(:user).permit(:name, :tag_list => []) ## Rails 4 strong params usage
   end
 end
 
@@ -262,7 +262,7 @@ If you want to change how tags are parsed, you can define a your own implementat
 ```ruby
 class MyParser < ActsAsTaggableOn::GenericParser
   def parse
-    TagList.new.tap do |tag_list|
+    ActsAsTaggableOn::TagList.new.tap do |tag_list|
       tag_list.add @tag_list.split('|')
     end
   end

data/lib/acts_as_taggable_on/taggable/related.rb

@@ -43,7 +43,7 @@ module ActsAsTaggableOn::Taggable
     def related_tags_for(context, klass, options = {})
       tags_to_ignore = Array.wrap(options[:ignore]).map(&:to_s) || []
       tags_to_find = tags_on(context).map { |t| t.name }.reject { |t| tags_to_ignore.include? t }
-      related_where(klass, ["#{exclude_self(klass, id)} #{klass.table_name}.#{klass.primary_key} = #{ActsAsTaggableOn::Tagging.table_name}.taggable_id AND #{ActsAsTaggableOn::Tagging.table_name}.taggable_type = '#{klass.base_class}' AND #{ActsAsTaggableOn::Tagging.table_name}.tag_id = #{ActsAsTaggableOn::Tag.table_name}.#{ActsAsTaggableOn::Tag.primary_key} AND #{ActsAsTaggableOn::Tag.table_name}.name IN (?)", tags_to_find])
+      related_where(klass, ["#{exclude_self(klass, id)} #{klass.table_name}.#{klass.primary_key} = #{ActsAsTaggableOn::Tagging.table_name}.taggable_id AND #{ActsAsTaggableOn::Tagging.table_name}.taggable_type = '#{klass.base_class}' AND #{ActsAsTaggableOn::Tagging.table_name}.tag_id = #{ActsAsTaggableOn::Tag.table_name}.#{ActsAsTaggableOn::Tag.primary_key} AND #{ActsAsTaggableOn::Tag.table_name}.name IN (?) AND #{ActsAsTaggableOn::Tagging.table_name}.context = ?", tags_to_find, context])
     end
 
     private

data/lib/acts_as_taggable_on/version.rb

@@ -1,4 +1,4 @@
 module ActsAsTaggableOn
-  VERSION = '3.4.3'
+  VERSION = '3.4.4'
 end
 

data/spec/acts_as_taggable_on/related_spec.rb

@@ -42,6 +42,15 @@ describe 'Acts As Taggable On' do
       expect(taggable1.find_related_tags_for(OtherTaggableModel)).to_not include(taggable2)
     end
 
+    it 'should find other related objects based on tags only from particular context' do
+      taggable1 = TaggableModel.create!(name: 'Taggable 1',tag_list: 'one, two')
+      taggable2 = TaggableModel.create!(name: 'Taggable 2',tag_list: 'three, four', skill_list: 'one, two')
+      taggable3 = TaggableModel.create!(name: 'Taggable 3',tag_list: 'one, four')
+
+      expect(taggable1.find_related_tags).to include(taggable3)
+      expect(taggable1.find_related_tags).to_not include(taggable2)
+    end
+
 
     shared_examples "a collection" do
       it do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: acts-as-taggable-on
 version: !ruby/object:Gem::Version
-  version: 3.4.3
+  version: 3.4.4
 platform: ruby
 authors:
 - Michael Bleigh
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-06 00:00:00.000000000 Z
+date: 2015-02-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -259,7 +259,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Advanced tagging for Rails.