acts-as-taggable-on 3.2.3 → 3.2.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 755e4d829ddc31ccd6ffb8385594ed8c5c64971f
-  data.tar.gz: 1ce12972b7d9d436484d619843a7bdf316a5c3b7
+  metadata.gz: a20675bbbf6a845a9af63de544fd91aa3d0456c4
+  data.tar.gz: 525532eb66d8245b5d5e5f5e0b0bcafbd71f0165
 SHA512:
-  metadata.gz: c8f129a07903598bcb765b260bd14db168b4a6fbf6989cef816157ae6350cadd733f75ca6cc0169e00fa8c19b59710198b868f52044f07efca451c44aa9a046c
-  data.tar.gz: 578b3d36b654b9343a36df3a7086b40b3ef32f6b43973d92c0f31251ea095405b692d2ef131ba74086366d117eef0fcd2334b51ce8f7ce3c0266481819a0a2a1
+  metadata.gz: da3437561dbcb861750489d2abcff557bd2aa488a483ea73d242a51d08fa6df6be4b8a64b1f7fbbed9e3dd44ea63e9b7b6101bd4d52d5a0ee05658272d16e5d8
+  data.tar.gz: 4f34e61243d64b0f77c842dc929c3dc6e1039b65a388d0da2e0b31484b7c63637acc76764dc18c5fde11198199dcf5756460b322e38abd5cbb9a65ed1a510c1d

data/.travis.yml

@@ -25,18 +25,19 @@ matrix:
   allow_failures:
       - gemfile: gemfiles/activerecord_edge.gemfile
       - rvm: rbx-2
+      - rvm: ruby-head
   exclude:
       - rvm: 1.9.3
-        gemfile: ci/Gemfile.activerecord-4.0.x
+        gemfile: gemfiles/activerecord_4.0.gemfile
       - rvm: 1.9.3
-        gemfile: ci/Gemfile.activerecord-4.1.x
+        gemfile: gemfiles/activerecord_4.1.gemfile
       - rvm: 1.9.3
-        gemfile: ci/Gemfile.activerecord-edge
+        gemfile: gemfiles/activerecord_edge.gemfile
       - rvm: rbx-2
-        gemfile: ci/Gemfile.activerecord-3.2.x
+        gemfile: gemfiles/activerecord_3.2.gemfile
       - rvm: ruby-head
-        gemfile: ci/Gemfile.activerecord-3.2.x
+        gemfile: gemfiles/activerecord_3.2.gemfile
       - rvm: ruby-head
-        gemfile: ci/Gemfile.activerecord-4.0.x
+        gemfile: gemfiles/activerecord_4.0.gemfile
       - rvm: ruby-head
-        gemfile: ci/Gemfile.activerecord-4.1.x
+        gemfile: gemfiles/activerecord_4.1.gemfile

data/Gemfile

@@ -7,5 +7,4 @@ group :local_development do
   gem 'guard-rspec'
   gem 'appraisal'
   gem 'rake'
-  gem 'byebug'
 end

data/acts-as-taggable-on.gemspec

@@ -26,13 +26,12 @@ Gem::Specification.new do |gem|
   gem.add_runtime_dependency 'actionpack',    ['>= 3', '< 5']
 
   gem.add_development_dependency 'sqlite3'
-  gem.add_development_dependency 'mysql2'
+  gem.add_development_dependency 'mysql2', '~> 0.3.7'
   gem.add_development_dependency 'pg'
 
-  gem.add_development_dependency 'rspec-rails'  , '~> 3.0.0.beta1'
-  gem.add_development_dependency 'rspec-its', '~> 1.0'
-  gem.add_development_dependency 'rspec', '3.0.0.beta2'
-  gem.add_development_dependency 'ammeter', '~> 1.0'
-  gem.add_development_dependency 'barrier', '~> 1.0'
-  gem.add_development_dependency 'database_cleaner', '~> 1.2'
+  gem.add_development_dependency 'rspec-rails'  , '~> 3.0.0.beta'
+  gem.add_development_dependency 'rspec-its'
+  gem.add_development_dependency 'rspec'
+  gem.add_development_dependency 'barrier'
+  gem.add_development_dependency 'database_cleaner'
 end

data/gemfiles/activerecord_3.2.gemfile

@@ -10,7 +10,6 @@ group :local_development do
   gem "guard-rspec"
   gem "appraisal"
   gem "rake"
-  gem "byebug"
 end
 
 gemspec :path => "../"

data/gemfiles/activerecord_4.0.gemfile

@@ -10,7 +10,6 @@ group :local_development do
   gem "guard-rspec"
   gem "appraisal"
   gem "rake"
-  gem "byebug"
 end
 
 gemspec :path => "../"

data/gemfiles/activerecord_4.1.gemfile

@@ -10,7 +10,6 @@ group :local_development do
   gem "guard-rspec"
   gem "appraisal"
   gem "rake"
-  gem "byebug"
 end
 
 gemspec :path => "../"

data/gemfiles/activerecord_edge.gemfile

@@ -11,7 +11,6 @@ group :local_development do
   gem "guard-rspec"
   gem "appraisal"
   gem "rake"
-  gem "byebug"
 end
 
 gemspec :path => "../"

data/lib/acts-as-taggable-on.rb

@@ -3,9 +3,35 @@ require 'active_record/version'
 require 'active_support/core_ext/module'
 require 'action_view'
 
+require_relative 'acts_as_taggable_on/engine'
+
 require 'digest/sha1'
 
 module ActsAsTaggableOn
+  extend ActiveSupport::Autoload
+
+  autoload :Tag
+  autoload :TagList
+  autoload :TagListParser
+  autoload :Taggable
+  autoload :Tagger
+  autoload :Tagging
+  autoload :TagsHelper
+  autoload :VERSION
+
+  autoload_under 'taggable' do
+    autoload :Cache
+    autoload :Collection
+    autoload :Core
+    autoload :Dirty
+    autoload :Ownership
+    autoload :Related
+  end
+
+  autoload :Utils
+  autoload :Compatibility
+
+
   class DuplicateTagError < StandardError
   end
 
@@ -16,7 +42,7 @@ module ActsAsTaggableOn
 
   def self.method_missing(method_name, *args, &block)
     @configuration.respond_to?(method_name) ?
-      @configuration.send(method_name, *args, &block) : super
+        @configuration.send(method_name, *args, &block) : super
   end
 
   def self.respond_to?(method_name, include_private=false)
@@ -31,7 +57,7 @@ module ActsAsTaggableOn
 
   class Configuration
     attr_accessor :delimiter, :force_lowercase, :force_parameterize,
-      :strict_case_match, :remove_unused_tags
+                  :strict_case_match, :remove_unused_tags
 
     def initialize
       @delimiter = ','
@@ -45,24 +71,6 @@ module ActsAsTaggableOn
   setup
 end
 
-require 'acts_as_taggable_on/utils'
-
-require 'acts_as_taggable_on/taggable'
-require 'acts_as_taggable_on/acts_as_taggable_on/compatibility'
-require 'acts_as_taggable_on/acts_as_taggable_on/core'
-require 'acts_as_taggable_on/acts_as_taggable_on/collection'
-require 'acts_as_taggable_on/acts_as_taggable_on/cache'
-require 'acts_as_taggable_on/acts_as_taggable_on/ownership'
-require 'acts_as_taggable_on/acts_as_taggable_on/related'
-require 'acts_as_taggable_on/acts_as_taggable_on/dirty'
-
-require 'acts_as_taggable_on/tagger'
-require 'acts_as_taggable_on/tag'
-require 'acts_as_taggable_on/tag_list'
-require 'acts_as_taggable_on/tags_helper'
-require 'acts_as_taggable_on/tagging'
-require 'acts_as_taggable_on/engine'
-
 ActiveSupport.on_load(:active_record) do
   extend ActsAsTaggableOn::Compatibility
   extend ActsAsTaggableOn::Taggable

data/lib/acts_as_taggable_on/tag_list.rb

@@ -1,3 +1,4 @@
+
 require 'active_support/core_ext/module/delegation'
 
 module ActsAsTaggableOn
@@ -8,82 +9,6 @@ module ActsAsTaggableOn
       add(*args)
     end
 
-    class << self
-      ##
-      # Returns a new TagList using the given tag string.
-      #
-      # Example:
-      #   tag_list = ActsAsTaggableOn::TagList.from("One , Two,  Three")
-      #   tag_list # ["One", "Two", "Three"]
-      def from(string)
-        string = string.join(ActsAsTaggableOn.glue) if string.respond_to?(:join)
-
-        new.tap do |tag_list|
-          string = string.to_s.dup
-
-
-          string.gsub!(double_quote_pattern) {
-            # Append the matched tag to the tag list
-            tag_list << Regexp.last_match[2]
-            # Return the matched delimiter ($3) to replace the matched items
-            ''
-          }
-
-          string.gsub!(single_quote_pattern) {
-            # Append the matched tag ($2) to the tag list
-            tag_list << Regexp.last_match[2]
-            # Return an empty string to replace the matched items
-            ''
-          }
-
-          # split the string by the delimiter
-          # and add to the tag_list
-          tag_list.add(string.split(Regexp.new delimiter))
-        end
-      end
-
-      def delimiter
-        # Parse the quoted tags
-        d = ActsAsTaggableOn.delimiter
-        # Separate multiple delimiters by bitwise operator
-        d = d.join('|') if d.kind_of?(Array)
-
-        d
-      end
-
-      def single_quote_pattern
-        %r{
-          (             # Tag start delimiter ($1)
-            \A       |  # Either string start or
-            #{delimiter}        # a delimiter
-          )
-          \s*'          # quote (') optionally preceded by whitespace
-          (.*?)         # Tag ($2)
-          '\s*          # quote (') optionally followed by whitespace
-          (?=           # Tag end delimiter (not consumed; is zero-length lookahead)
-            #{delimiter}\s*  |  # Either a delimiter optionally followed by whitespace or
-            \z          # string end
-          )
-      }x
-      end
-
-      def double_quote_pattern
-        %r{
-          (             # Tag start delimiter ($1)
-            \A       |  # Either string start or
-            #{delimiter}        # a delimiter
-          )
-          \s*"          # quote (") optionally preceded by whitespace
-          (.*?)         # Tag ($2)
-          "\s*          # quote (") optionally followed by whitespace
-          (?=           # Tag end delimiter (not consumed; is zero-length lookahead)
-            #{delimiter}\s*  |  # Either a delimiter optionally followed by whitespace or
-            \z          # string end
-          )
-      }x
-      end
-
-    end
     ##
     # Add tags to the tag_list. Duplicate or blank tags will be ignored.
     # Use the <tt>:parse</tt> option to add an unparsed tag string.
@@ -165,12 +90,23 @@ module ActsAsTaggableOn
       options = args.last.is_a?(Hash) ? args.pop : {}
       options.assert_valid_keys :parse
 
-      args.map! { |a| self.class.from(a) } if options[:parse]
+      args.map! { |a| TagListParser.parse(a) } if options[:parse]
 
       args.flatten!
     end
 
 
+    ## DEPRECATED
+    def self.from(string)
+      ActiveRecord::Base.logger.warn <<WARNING
+ActsAsTaggableOn::TagList.from is deprecated \
+and will be removed from v4.0+, use  \
+ActsAsTaggableOn::TagListParser.parse instead
+WARNING
+      TagListParser.parse(string)
+    end
+
+
   end
 end
 

data/lib/acts_as_taggable_on/tag_list_parser.rb

@@ -0,0 +1,78 @@
+module ActsAsTaggableOn
+  ##
+  # Returns a new TagList using the given tag string.
+  #
+  # Example:
+  #   tag_list = ActsAsTaggableOn::TagListParser.parse("One , Two,  Three")
+  #   tag_list # ["One", "Two", "Three"]
+  module TagListParser
+    class << self
+      def parse(string)
+        string = string.join(ActsAsTaggableOn.glue) if string.respond_to?(:join)
+        TagList.new.tap do |tag_list|
+          string = string.to_s.dup
+
+
+          string.gsub!(double_quote_pattern) {
+            # Append the matched tag to the tag list
+            tag_list << Regexp.last_match[2]
+            # Return the matched delimiter ($3) to replace the matched items
+            ''
+          }
+
+          string.gsub!(single_quote_pattern) {
+            # Append the matched tag ($2) to the tag list
+            tag_list << Regexp.last_match[2]
+            # Return an empty string to replace the matched items
+            ''
+          }
+
+          # split the string by the delimiter
+          # and add to the tag_list
+          tag_list.add(string.split(Regexp.new delimiter))
+        end
+      end
+
+
+      # private
+      def delimiter
+        # Parse the quoted tags
+        d = ActsAsTaggableOn.delimiter
+        # Separate multiple delimiters by bitwise operator
+        d = d.join('|') if d.kind_of?(Array)
+        d
+      end
+
+      # (             # Tag start delimiter ($1)
+      # \A       |  # Either string start or
+      # #{delimiter}        # a delimiter
+      # )
+      # \s*"          # quote (") optionally preceded by whitespace
+      # (.*?)         # Tag ($2)
+      # "\s*          # quote (") optionally followed by whitespace
+      # (?=           # Tag end delimiter (not consumed; is zero-length lookahead)
+      # #{delimiter}\s*  |  # Either a delimiter optionally followed by whitespace or
+      # \z          # string end
+      # )
+      def double_quote_pattern
+        /(\A|#{delimiter})\s*"(.*?)"\s*(?=#{delimiter}\s*|\z)/
+      end
+
+      # (             # Tag start delimiter ($1)
+      # \A       |  # Either string start or
+      # #{delimiter}        # a delimiter
+      # )
+      # \s*'          # quote (') optionally preceded by whitespace
+      # (.*?)         # Tag ($2)
+      # '\s*          # quote (') optionally followed by whitespace
+      # (?=           # Tag end delimiter (not consumed; is zero-length lookahead)
+      # #{delimiter}\s*  | d # Either a delimiter optionally followed by whitespace or
+      # \z          # string end
+      # )
+      def single_quote_pattern
+        /(\A|#{delimiter})\s*'(.*?)'\s*(?=#{delimiter}\s*|\z)/
+      end
+
+    end
+  end
+end

data/lib/acts_as_taggable_on/{acts_as_taggable_on → taggable}/core.rb

@@ -82,7 +82,7 @@ module ActsAsTaggableOn::Taggable
       #   User.tagged_with("awesome", "cool", :match_all => true) # Users that are tagged with just awesome and cool
       #   User.tagged_with("awesome", "cool", :owned_by => foo ) # Users that are tagged with just awesome and cool by 'foo'
       def tagged_with(tags, options = {})
-        tag_list = ActsAsTaggableOn::TagList.from(tags)
+        tag_list = ActsAsTaggableOn::TagListParser.parse(tags)
         options = options.dup
         empty_result = where('1 = 0')
 
@@ -116,7 +116,7 @@ module ActsAsTaggableOn::Taggable
                 " AND #{ActsAsTaggableOn::Tagging.table_name}.tagger_type = #{quote_value(owned_by.class.base_class.to_s, nil)}"
           end
 
-        elsif options.delete(:any)
+        elsif any = options.delete(:any)
           # get tags, drop out if nothing returned (we need at least one)
           tags = if options.delete(:wild)
                    ActsAsTaggableOn::Tag.named_like_any(tag_list)
@@ -141,7 +141,7 @@ module ActsAsTaggableOn::Taggable
 
           # don't need to sanitize sql, map all ids and join with OR logic
           conditions << tags.map { |t| "#{taggings_alias}.tag_id = #{quote_value(t.id, nil)}" }.join(' OR ')
-          select_clause = " #{table_name}.*" unless context and tag_types.one?
+          select_clause << " #{table_name}.*" unless context and tag_types.one?
 
           if owned_by
             tagging_join << ' AND ' +
@@ -153,7 +153,10 @@ module ActsAsTaggableOn::Taggable
           end
 
           joins << tagging_join
-          group = "#{table_name}.#{primary_key}"
+          unless any == 'distinct'    # Fix issue #544
+            group = "#{table_name}.#{primary_key}"
+            select_clause << group
+          end
         else
           tags = ActsAsTaggableOn::Tag.named_any(tag_list)
 
@@ -183,7 +186,7 @@ module ActsAsTaggableOn::Taggable
 
         group ||= [] # Rails interprets this as a no-op in the group() call below
         if options.delete(:order_by_matching_tag_count)
-          select_clause = "#{table_name}.*, COUNT(#{taggings_alias}.tag_id) AS #{taggings_alias}_count"
+          select_clause << "#{table_name}.*, COUNT(#{taggings_alias}.tag_id) AS #{taggings_alias}_count"
           group_columns = ActsAsTaggableOn::Utils.using_postgresql? ? grouped_column_names_for(self) : "#{table_name}.#{primary_key}"
           group = group_columns
           order_by << "#{taggings_alias}_count DESC"
@@ -203,8 +206,9 @@ module ActsAsTaggableOn::Taggable
 
         order_by << options[:order] if options[:order].present?
 
-        select(select_clause)
-        .joins(joins.join(' '))
+        query = self
+        query = self.select(select_clause.join(',')) unless select_clause.empty?
+        query.joins(joins.join(' '))
         .where(conditions.join(' AND '))
         .group(group)
         .having(having)
@@ -259,7 +263,7 @@ module ActsAsTaggableOn::Taggable
       if instance_variable_get(variable_name)
         instance_variable_get(variable_name)
       elsif cached_tag_list_on(context) && self.class.caching_tag_list_on?(context)
-        instance_variable_set(variable_name, ActsAsTaggableOn::TagList.from(cached_tag_list_on(context)))
+        instance_variable_set(variable_name, ActsAsTaggableOn::TagListParser.parse(cached_tag_list_on(context)))
       else
         instance_variable_set(variable_name, ActsAsTaggableOn::TagList.new(tags_on(context).map(&:name)))
       end
@@ -309,7 +313,7 @@ module ActsAsTaggableOn::Taggable
       variable_name = "@#{context.to_s.singularize}_list"
       process_dirty_object(context, new_list) unless custom_contexts.include?(context.to_s)
 
-      instance_variable_set(variable_name, ActsAsTaggableOn::TagList.from(new_list))
+      instance_variable_set(variable_name, ActsAsTaggableOn::TagListParser.parse(new_list))
     end
 
     def tagging_contexts
@@ -383,7 +387,7 @@ module ActsAsTaggableOn::Taggable
 
         # Destroy old taggings:
         if old_tags.present?
-          self.taggings.not_owned.by_context(context).destroy_all(tag_id: old_tags)
+          taggings.not_owned.by_context(context).destroy_all(tag_id: old_tags)
         end
 
         # Create new taggings:

data/lib/acts_as_taggable_on/{acts_as_taggable_on → taggable}/ownership.rb

@@ -63,7 +63,7 @@ module ActsAsTaggableOn::Taggable
 
       cache = cached_owned_tag_list_on(context)
 
-      cache[owner] = ActsAsTaggableOn::TagList.from(new_list)
+      cache[owner] = ActsAsTaggableOn::TagListParser.parse(new_list)
     end
 
     def reload(*args)

data/lib/acts_as_taggable_on/taggable.rb

@@ -1,5 +1,6 @@
 module ActsAsTaggableOn
   module Taggable
+
     def taggable?
       false
     end
@@ -90,12 +91,12 @@ module ActsAsTaggableOn
 
       # each of these add context-specific methods and must be
       # called on each call of taggable_on
-      include ActsAsTaggableOn::Taggable::Core
-      include ActsAsTaggableOn::Taggable::Collection
-      include ActsAsTaggableOn::Taggable::Cache
-      include ActsAsTaggableOn::Taggable::Ownership
-      include ActsAsTaggableOn::Taggable::Related
-      include ActsAsTaggableOn::Taggable::Dirty
+      include Core
+      include Collection
+      include Cache
+      include Ownership
+      include Related
+      include Dirty
     end
   end
 end

data/lib/acts_as_taggable_on/utils.rb

@@ -1,3 +1,5 @@
+# This module is deprecated and will be removed in the incoming versions
+
 module ActsAsTaggableOn
   module Utils
     class << self
@@ -10,33 +12,11 @@ module ActsAsTaggableOn
         connection && connection.adapter_name == 'PostgreSQL'
       end
 
-      def postgresql_version
-        if using_postgresql?
-          connection.execute('SHOW SERVER_VERSION').first['server_version'].to_f
-        end
-      end
-
-      def postgresql_support_json?
-        postgresql_version >= 9.2
-      end
-
-      def using_sqlite?
-        connection && connection.adapter_name == 'SQLite'
-      end
-
       def using_mysql?
         #We should probably use regex for mysql to support prehistoric adapters
         connection && connection.adapter_name == 'Mysql2'
       end
 
-      def using_case_insensitive_collation?
-        using_mysql? && connection.collation =~ /_ci\Z/
-      end
-
-      def supports_concurrency?
-        !using_sqlite?
-      end
-
       def sha_prefix(string)
         Digest::SHA1.hexdigest("#{string}#{rand}")[0..6]
       end
@@ -45,10 +25,6 @@ module ActsAsTaggableOn
         ::ActiveRecord::VERSION::MAJOR == 4
       end
 
-      def active_record42?
-        active_record4? && ::ActiveRecord::VERSION::MINOR >= 2
-      end
-
       def like_operator
         using_postgresql? ? 'ILIKE' : 'LIKE'
       end

data/lib/acts_as_taggable_on/version.rb

@@ -1,4 +1,4 @@
 module ActsAsTaggableOn
-  VERSION = '3.2.3'
+  VERSION = '3.2.5'
 end
 

data/spec/acts_as_taggable_on/acts_as_taggable_on_spec.rb

@@ -1,4 +1,4 @@
-# coding: utf-8
+# -*- encoding : utf-8 -*-
 require 'spec_helper'
 
 describe 'Acts As Taggable On' do

data/spec/acts_as_taggable_on/acts_as_tagger_spec.rb

@@ -1,3 +1,4 @@
+# -*- encoding : utf-8 -*-
 require 'spec_helper'
 
 describe 'acts_as_tagger' do

data/spec/acts_as_taggable_on/caching_spec.rb

@@ -1,3 +1,4 @@
+# -*- encoding : utf-8 -*-
 require 'spec_helper'
 
 describe 'Acts As Taggable On' do

data/spec/acts_as_taggable_on/related_spec.rb

@@ -1,3 +1,4 @@
+# -*- encoding : utf-8 -*-
 require 'spec_helper'
 
 describe 'Acts As Taggable On' do

data/spec/acts_as_taggable_on/single_table_inheritance_spec.rb

@@ -1,3 +1,4 @@
+# -*- encoding : utf-8 -*-
 require 'spec_helper'
 
 describe 'Single Table Inheritance' do

data/spec/acts_as_taggable_on/tag_list_parser_spec.rb

@@ -0,0 +1,46 @@
+# -*- encoding : utf-8 -*-
+require 'spec_helper'
+
+describe ActsAsTaggableOn::TagListParser do
+  it '#parse should return empty array if empty array is passed' do
+    expect(ActsAsTaggableOn::TagListParser.parse([])).to be_empty
+  end
+
+  describe 'Multiple Delimiter' do
+    before do
+      @old_delimiter = ActsAsTaggableOn.delimiter
+    end
+
+    after do
+      ActsAsTaggableOn.delimiter = @old_delimiter
+    end
+
+    it 'should separate tags by delimiters' do
+      ActsAsTaggableOn.delimiter = [',', ' ', '\|']
+      tag_list = ActsAsTaggableOn::TagListParser.parse('cool, data|I have')
+      expect(tag_list.to_s).to eq('cool, data, I, have')
+    end
+
+    it 'should escape quote' do
+      ActsAsTaggableOn.delimiter = [',', ' ', '\|']
+      tag_list = ActsAsTaggableOn::TagListParser.parse "'I have'|cool, data"
+      expect(tag_list.to_s).to eq('"I have", cool, data')
+
+      tag_list = ActsAsTaggableOn::TagListParser.parse '"I, have"|cool, data'
+      expect(tag_list.to_s).to eq('"I, have", cool, data')
+    end
+
+    it 'should work for utf8 delimiter and long delimiter' do
+      ActsAsTaggableOn.delimiter = ['，', '的', '可能是']
+      tag_list = ActsAsTaggableOn::TagListParser.parse('我的东西可能是不见了，还好有备份')
+      expect(tag_list.to_s).to eq('我， 东西， 不见了， 还好有备份')
+    end
+
+    it 'should work for multiple quoted tags' do
+      ActsAsTaggableOn.delimiter = [',']
+      tag_list = ActsAsTaggableOn::TagListParser.parse('"Ruby Monsters","eat Katzenzungen"')
+      expect(tag_list.to_s).to eq('Ruby Monsters, eat Katzenzungen')
+    end
+  end
+
+end