acts-as-taggable-on 2.4.1 → 3.0.0

data/spec/acts_as_taggable_on/caching_spec.rb

@@ -0,0 +1,77 @@
+require 'spec_helper'
+
+describe "Acts As Taggable On" do
+
+  before(:each) do
+    clean_database!
+  end
+
+  describe 'Caching' do
+    before(:each) do
+      @taggable = CachedModel.new(:name => "Bob Jones")
+      @another_taggable = OtherCachedModel.new(:name => "John Smith")
+    end
+
+    it "should add saving of tag lists and cached tag lists to the instance" do
+      @taggable.should respond_to(:save_cached_tag_list)
+      @another_taggable.should respond_to(:save_cached_tag_list)
+
+      @taggable.should respond_to(:save_tags)
+    end
+
+    it "should add cached tag lists to the instance if cached column is not present" do
+      TaggableModel.new(:name => "Art Kram").should_not respond_to(:save_cached_tag_list)
+    end
+
+    it "should generate a cached column checker for each tag type" do
+      CachedModel.should respond_to(:caching_tag_list?)
+      OtherCachedModel.should respond_to(:caching_language_list?)
+    end
+
+    it 'should not have cached tags' do
+      @taggable.cached_tag_list.should be_blank
+      @another_taggable.cached_language_list.should be_blank
+    end
+
+    it 'should cache tags' do
+      @taggable.update_attributes(:tag_list => 'awesome, epic')
+      @taggable.cached_tag_list.should == 'awesome, epic'
+
+      @another_taggable.update_attributes(:language_list => 'ruby, .net')
+      @another_taggable.cached_language_list.should == 'ruby, .net'
+    end
+
+    it 'should keep the cache' do
+      @taggable.update_attributes(:tag_list => 'awesome, epic')
+      @taggable = CachedModel.find(@taggable)
+      @taggable.save!
+      @taggable.cached_tag_list.should == 'awesome, epic'
+    end
+
+    it 'should update the cache' do
+      @taggable.update_attributes(:tag_list => 'awesome, epic')
+      @taggable.update_attributes(:tag_list => 'awesome')
+      @taggable.cached_tag_list.should == 'awesome'
+    end
+
+    it 'should remove the cache' do
+      @taggable.update_attributes(:tag_list => 'awesome, epic')
+      @taggable.update_attributes(:tag_list => '')
+      @taggable.cached_tag_list.should be_blank
+    end
+
+    it 'should have a tag list' do
+      @taggable.update_attributes(:tag_list => 'awesome, epic')
+      @taggable = CachedModel.find(@taggable.id)
+      @taggable.tag_list.sort.should == %w(awesome epic).sort
+    end
+
+    it 'should keep the tag list' do
+      @taggable.update_attributes(:tag_list => 'awesome, epic')
+      @taggable = CachedModel.find(@taggable.id)
+      @taggable.save!
+      @taggable.tag_list.sort.should == %w(awesome epic).sort
+    end
+  end
+
+end

data/spec/acts_as_taggable_on/tags_helper_spec.rb

@@ -3,40 +3,40 @@ require 'spec_helper'
 describe ActsAsTaggableOn::TagsHelper do
   before(:each) do
     clean_database!
-    
+
     @bob = TaggableModel.create(:name => "Bob Jones",  :language_list => "ruby, php")
     @tom = TaggableModel.create(:name => "Tom Marley", :language_list => "ruby, java")
     @eve = TaggableModel.create(:name => "Eve Nodd",   :language_list => "ruby, c++")
-    
+
     @helper = class Helper
       include ActsAsTaggableOn::TagsHelper
     end.new
   end
-  
-  it "should yield the proper css classes" do 
+
+  it "should yield the proper css classes" do
     tags = { }
-    
+
     @helper.tag_cloud(TaggableModel.tag_counts_on(:languages), ["sucky", "awesome"]) do |tag, css_class|
       tags[tag.name] = css_class
     end
-    
+
     tags["ruby"].should == "awesome"
     tags["java"].should == "sucky"
     tags["c++"].should == "sucky"
     tags["php"].should == "sucky"
   end
-  
+
   it "should handle tags with zero counts (build for empty)" do
     bob = ActsAsTaggableOn::Tag.create(:name => "php")
     tom = ActsAsTaggableOn::Tag.create(:name => "java")
     eve = ActsAsTaggableOn::Tag.create(:name => "c++")
-    
+
     tags = { }
-    
+
     @helper.tag_cloud(ActsAsTaggableOn::Tag.all, ["sucky", "awesome"]) do |tag, css_class|
       tags[tag.name] = css_class
     end
-    
+
     tags["java"].should == "sucky"
     tags["c++"].should == "sucky"
     tags["php"].should == "sucky"

data/spec/schema.rb

@@ -1,59 +1,63 @@
 ActiveRecord::Schema.define :version => 0 do
-  create_table "taggings", :force => true do |t|
-    t.integer  "tag_id",        :limit => 11
-    t.integer  "taggable_id",   :limit => 11
-    t.string   "taggable_type"
-    t.string   "context"
-    t.datetime "created_at"
-    t.integer  "tagger_id",     :limit => 11
-    t.string   "tagger_type"
+  create_table :tags, :force => true do |t|
+    t.string :name
   end
 
-  add_index "taggings", ["tag_id"], :name => "index_taggings_on_tag_id"
-  add_index "taggings", ["taggable_id", "taggable_type", "context"], :name => "index_taggings_on_taggable_id_and_taggable_type_and_context"
+  create_table :taggings, :force => true do |t|
+    t.references :tag
 
-  create_table "tags", :force => true do |t|
-    t.string "name"
+    # You should make sure that the column created is
+    # long enough to store the required class names.
+    t.references :taggable, :polymorphic => true
+    t.references :tagger, :polymorphic => true
+
+    # Limit is created to prevent MySQL error on index
+    # length for MyISAM table type: http://bit.ly/vgW2Ql
+    t.string :context, :limit => 128
+
+    t.datetime :created_at
   end
-  
+  # above copied from
+  # generators/acts_as_taggable_on/migration/migration_generator
+
   create_table :taggable_models, :force => true do |t|
     t.column :name, :string
     t.column :type, :string
   end
-  
+
   create_table :non_standard_id_taggable_models, :primary_key => "an_id", :force => true do |t|
     t.column :name, :string
     t.column :type, :string
   end
-  
+
   create_table :untaggable_models, :force => true do |t|
     t.column :taggable_model_id, :integer
     t.column :name, :string
   end
-  
+
   create_table :cached_models, :force => true do |t|
     t.column :name, :string
     t.column :type, :string
     t.column :cached_tag_list, :string
   end
-  
+
   create_table :other_cached_models, :force => true do |t|
     t.column :name, :string
     t.column :type, :string
-    t.column :cached_language_list, :string    
+    t.column :cached_language_list, :string
     t.column :cached_status_list, :string
     t.column :cached_glass_list, :string
   end
-  
+
   create_table :users, :force => true do |t|
     t.column :name, :string
   end
-  
+
   create_table :other_taggable_models, :force => true do |t|
     t.column :name, :string
     t.column :type, :string
   end
-  
+
   create_table :ordered_taggable_models, :force => true do |t|
     t.column :name, :string
     t.column :type, :string

data/spec/spec_helper.rb

@@ -1,23 +1,7 @@
 $LOAD_PATH << "." unless $LOAD_PATH.include?(".")
+$LOAD_PATH.unshift(File.expand_path('../../lib', __FILE__))
 require 'logger'
 
-begin
-  require "rubygems"
-  require "bundler"
-
-  if Gem::Version.new(Bundler::VERSION) <= Gem::Version.new("0.9.5")
-    raise RuntimeError, "Your bundler version is too old." +
-     "Run `gem install bundler` to upgrade."
-  end
-
-  # Set up load paths for all bundled gems
-  Bundler.setup
-rescue Bundler::GemNotFound
-  raise RuntimeError, "Bundler couldn't find some gems." +
-    "Did you run \`bundlee install\`?"
-end
-
-Bundler.require
 require File.expand_path('../../lib/acts-as-taggable-on', __FILE__)
 require 'ammeter/init'
 
@@ -38,39 +22,39 @@ database_yml = File.expand_path('../database.yml', __FILE__)
 
 if File.exists?(database_yml)
   active_record_configuration = YAML.load_file(database_yml)
-  
+
   ActiveRecord::Base.configurations = active_record_configuration
   config = ActiveRecord::Base.configurations[db_name]
-  
+
   begin
     ActiveRecord::Base.establish_connection(db_name)
     ActiveRecord::Base.connection
   rescue
     case db_name
-    when /mysql/      
+    when /mysql/
       ActiveRecord::Base.establish_connection(config.merge('database' => nil))
       ActiveRecord::Base.connection.create_database(config['database'],  {:charset => 'utf8', :collation => 'utf8_unicode_ci'})
     when 'postgresql'
       ActiveRecord::Base.establish_connection(config.merge('database' => 'postgres', 'schema_search_path' => 'public'))
       ActiveRecord::Base.connection.create_database(config['database'], config.merge('encoding' => 'utf8'))
     end
-    
+
     ActiveRecord::Base.establish_connection(config)
   end
-    
+
   logger = ActiveRecord::Base.logger = Logger.new(File.join(File.dirname(__FILE__), "debug.log"))
   ActiveRecord::Base.default_timezone = :utc
-  
+
   begin
     old_logger_level, logger.level = logger.level, ::Logger::ERROR
     ActiveRecord::Migration.verbose = false
-    
+
     load(File.dirname(__FILE__) + '/schema.rb')
     load(File.dirname(__FILE__) + '/models.rb')
   ensure
     logger.level = old_logger_level
   end
-  
+
 else
   raise "Please create #{database_yml} first to configure your database. Take a look at: #{database_yml}.sample"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: acts-as-taggable-on
 version: !ruby/object:Gem::Version
-  version: 2.4.1
+  version: 3.0.0
 platform: ruby
 authors:
 - Michael Bleigh
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-07 00:00:00.000000000 Z
+date: 2014-01-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -32,35 +32,35 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '5'
 - !ruby/object:Gem::Dependency
-  name: rspec-rails
+  name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - '>='
       - !ruby/object:Gem::Version
-        version: 2.13.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - '>='
       - !ruby/object:Gem::Version
-        version: 2.13.0
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: mysql2
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '2.6'
+        version: 0.3.7
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '2.6'
+        version: 0.3.7
 - !ruby/object:Gem::Dependency
-  name: ammeter
+  name: pg
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
@@ -74,63 +74,35 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: sqlite3
+  name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.13.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.13.0
 - !ruby/object:Gem::Dependency
-  name: mysql2
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 0.3.7
+        version: '2.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 0.3.7
-- !ruby/object:Gem::Dependency
-  name: pg
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: guard
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.6'
 - !ruby/object:Gem::Dependency
-  name: guard-rspec
+  name: ammeter
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
@@ -156,15 +128,21 @@ files:
 - .rspec
 - .travis.yml
 - Appraisals
+- CHANGELOG.md
 - Gemfile
 - Guardfile
 - LICENSE.md
 - README.md
 - Rakefile
+- UPGRADING
 - acts-as-taggable-on.gemspec
-- gemfiles/rails_3.gemfile
-- gemfiles/rails_4.gemfile
+- db/migrate/1_acts_as_taggable_on_migration.rb
+- db/migrate/2_add_missing_unique_indices.rb
+- gemfiles/rails_3.2.gemfile
+- gemfiles/rails_4.0.gemfile
+- gemfiles/rails_4.1.gemfile
 - lib/acts-as-taggable-on.rb
+- lib/acts_as_taggable_on.rb
 - lib/acts_as_taggable_on/acts_as_taggable_on/cache.rb
 - lib/acts_as_taggable_on/acts_as_taggable_on/collection.rb
 - lib/acts_as_taggable_on/acts_as_taggable_on/compatibility.rb
@@ -172,6 +150,7 @@ files:
 - lib/acts_as_taggable_on/acts_as_taggable_on/dirty.rb
 - lib/acts_as_taggable_on/acts_as_taggable_on/ownership.rb
 - lib/acts_as_taggable_on/acts_as_taggable_on/related.rb
+- lib/acts_as_taggable_on/engine.rb
 - lib/acts_as_taggable_on/tag.rb
 - lib/acts_as_taggable_on/tag_list.rb
 - lib/acts_as_taggable_on/taggable.rb
@@ -180,10 +159,9 @@ files:
 - lib/acts_as_taggable_on/tags_helper.rb
 - lib/acts_as_taggable_on/utils.rb
 - lib/acts_as_taggable_on/version.rb
-- lib/generators/acts_as_taggable_on/migration/migration_generator.rb
-- lib/generators/acts_as_taggable_on/migration/templates/active_record/migration.rb
 - spec/acts_as_taggable_on/acts_as_taggable_on_spec.rb
 - spec/acts_as_taggable_on/acts_as_tagger_spec.rb
+- spec/acts_as_taggable_on/caching_spec.rb
 - spec/acts_as_taggable_on/related_spec.rb
 - spec/acts_as_taggable_on/single_table_inheritance_spec.rb
 - spec/acts_as_taggable_on/tag_list_spec.rb
@@ -195,7 +173,6 @@ files:
 - spec/acts_as_taggable_on/utils_spec.rb
 - spec/bm.rb
 - spec/database.yml.sample
-- spec/generators/acts_as_taggable_on/migration/migration_generator_spec.rb
 - spec/models.rb
 - spec/schema.rb
 - spec/spec_helper.rb
@@ -203,7 +180,14 @@ homepage: https://github.com/mbleigh/acts-as-taggable-on
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message: |
+  When upgrading
+
+  Re-run the migrations generator
+
+      rake railties:install:migrations FROM=acts_as_taggable_on_engine db:migrate
+
+  It will create any new migrations and skip existing ones
 rdoc_options: []
 require_paths:
 - lib
@@ -219,13 +203,14 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.0
+rubygems_version: 2.1.11
 signing_key: 
 specification_version: 4
 summary: Advanced tagging for Rails.
 test_files:
 - spec/acts_as_taggable_on/acts_as_taggable_on_spec.rb
 - spec/acts_as_taggable_on/acts_as_tagger_spec.rb
+- spec/acts_as_taggable_on/caching_spec.rb
 - spec/acts_as_taggable_on/related_spec.rb
 - spec/acts_as_taggable_on/single_table_inheritance_spec.rb
 - spec/acts_as_taggable_on/tag_list_spec.rb
@@ -237,7 +222,6 @@ test_files:
 - spec/acts_as_taggable_on/utils_spec.rb
 - spec/bm.rb
 - spec/database.yml.sample
-- spec/generators/acts_as_taggable_on/migration/migration_generator_spec.rb
 - spec/models.rb
 - spec/schema.rb
 - spec/spec_helper.rb