acts-as-taggable-on 2.2.2 → 2.3.0

data/spec/acts_as_taggable_on/tag_spec.rb

@@ -1,3 +1,5 @@
+#encoding: utf-8
+
 require File.expand_path('../../spec_helper', __FILE__)
 
 describe ActsAsTaggableOn::Tag do
@@ -40,6 +42,23 @@ describe ActsAsTaggableOn::Tag do
     end
   end
 
+  unless ActsAsTaggableOn::Tag.using_sqlite?
+    describe "find or create by unicode name" do
+      before(:each) do
+        @tag.name = "привет"
+        @tag.save
+      end
+
+      it "should find by name" do
+        ActsAsTaggableOn::Tag.find_or_create_with_like_by_name("привет").should == @tag
+      end
+
+      it "should find by name case insensitive" do
+        ActsAsTaggableOn::Tag.find_or_create_with_like_by_name("ПРИВЕТ").should == @tag
+      end
+    end
+  end
+
   describe "find or create all by any name" do
     before(:each) do
       @tag.name = "awesome"
@@ -82,6 +101,16 @@ describe ActsAsTaggableOn::Tag do
     @tag.errors[:name].should == []
   end
 
+  it "should limit the name length to 255 or less characters" do
+    @tag.name = "fgkgnkkgjymkypbuozmwwghblmzpqfsgjasflblywhgkwndnkzeifalfcpeaeqychjuuowlacmuidnnrkprgpcpybarbkrmziqihcrxirlokhnzfvmtzixgvhlxzncyywficpraxfnjptxxhkqmvicbcdcynkjvziefqzyndxkjmsjlvyvbwraklbalykyxoliqdlreeykuphdtmzfdwpphmrqvwvqffojkqhlzvinqajsxbszyvrqqyzusxranr"
+    @tag.valid?
+    @tag.errors[:name].should == ["is too long (maximum is 255 characters)"]
+
+    @tag.name = "fgkgnkkgjymkypbuozmwwghblmzpqfsgjasflblywhgkwndnkzeifalfcpeaeqychjuuowlacmuidnnrkprgpcpybarbkrmziqihcrxirlokhnzfvmtzixgvhlxzncyywficpraxfnjptxxhkqmvicbcdcynkjvziefqzyndxkjmsjlvyvbwraklbalykyxoliqdlreeykuphdtmzfdwpphmrqvwvqffojkqhlzvinqajsxbszyvrqqyzusxran"
+    @tag.valid?
+    @tag.errors[:name].should == []
+  end
+
   it "should equal a tag with the same name" do
     @tag.name = "awesome"
     new_tag = ActsAsTaggableOn::Tag.new(:name => "awesome")
@@ -120,35 +149,5 @@ describe ActsAsTaggableOn::Tag do
     end
 
   end
-  
-  describe ".remove_unused" do
-    before do
-      @taggable = TaggableModel.create(:name => "Bob Jones")
-      @tag = ActsAsTaggableOn::Tag.create(:name => "awesome")
 
-      @tagging = ActsAsTaggableOn::Tagging.create(:taggable => @taggable, :tag => @tag, :context => 'tags')
-    end
-    
-    context "if set to true" do
-      before do
-        ActsAsTaggableOn::Tag.remove_unused = true                  
-      end
-      
-      it "should remove unused tags after removing taggings" do
-        @tagging.destroy
-        ActsAsTaggableOn::Tag.find_by_name("awesome").should be_nil
-      end
-    end
-    
-    context "if set to false" do
-      before do
-        ActsAsTaggableOn::Tag.remove_unused = false        
-      end
-      
-      it "should not remove unused tags after removing taggings" do
-        @tagging.destroy
-        ActsAsTaggableOn::Tag.find_by_name("awesome").should == @tag
-      end
-    end
-  end
 end

data/spec/acts_as_taggable_on/taggable_spec.rb

@@ -1,5 +1,114 @@
 require File.expand_path('../../spec_helper', __FILE__)
 
+describe "Taggable To Preserve Order" do
+  before(:each) do
+    clean_database!
+    @taggable = OrderedTaggableModel.new(:name => "Bob Jones")
+  end
+  
+  it "should have tag types" do
+    [:tags, :colours].each do |type|
+      OrderedTaggableModel.tag_types.should include type
+    end
+
+    @taggable.tag_types.should == OrderedTaggableModel.tag_types
+  end
+  
+  it "should have tag associations" do
+    [:tags, :colours].each do |type|
+      @taggable.respond_to?(type).should be_true
+      @taggable.respond_to?("#{type.to_s.singularize}_taggings").should be_true
+    end
+  end
+  
+  it "should have tag associations ordered by id" do
+    [:tags, :colours].each do |type|
+      OrderedTaggableModel.reflect_on_association(type).options[:order].should include('id')
+      OrderedTaggableModel.reflect_on_association("#{type.to_s.singularize}_taggings".to_sym).options[:order].should include('id')
+    end
+  end
+  
+  it "should have tag methods" do
+    [:tags, :colours].each do |type|
+      @taggable.respond_to?("#{type.to_s.singularize}_list").should be_true
+      @taggable.respond_to?("#{type.to_s.singularize}_list=").should be_true
+      @taggable.respond_to?("all_#{type.to_s}_list").should be_true
+    end
+  end
+
+  it "should return tag list in the order the tags were created" do
+    # create
+    @taggable.tag_list = "rails, ruby, css"
+    @taggable.instance_variable_get("@tag_list").instance_of?(ActsAsTaggableOn::TagList).should be_true
+    
+    lambda {
+      @taggable.save
+    }.should change(ActsAsTaggableOn::Tag, :count).by(3)
+    
+    @taggable.reload
+    @taggable.tag_list.should == %w(rails ruby css)
+    
+    # update
+    @taggable.tag_list = "pow, ruby, rails"
+    @taggable.save
+        
+    @taggable.reload
+    @taggable.tag_list.should == %w(pow ruby rails)
+    
+    # update with no change
+    @taggable.tag_list = "pow, ruby, rails"
+    @taggable.save
+        
+    @taggable.reload
+    @taggable.tag_list.should == %w(pow ruby rails)
+    
+    # update to clear tags
+    @taggable.tag_list = ""
+    @taggable.save
+        
+    @taggable.reload
+    @taggable.tag_list.should == []
+  end
+  
+  it "should return tag objects in the order the tags were created" do
+    # create
+    @taggable.tag_list = "pow, ruby, rails"
+    @taggable.instance_variable_get("@tag_list").instance_of?(ActsAsTaggableOn::TagList).should be_true
+    
+    lambda {
+      @taggable.save
+    }.should change(ActsAsTaggableOn::Tag, :count).by(3)
+    
+    @taggable.reload
+    @taggable.tags.map{|t| t.name}.should == %w(pow ruby rails)
+    
+    # update
+    @taggable.tag_list = "rails, ruby, css, pow"
+    @taggable.save
+    
+    @taggable.reload
+    @taggable.tags.map{|t| t.name}.should == %w(rails ruby css pow)
+  end
+  
+  it "should return tag objects in tagging id order" do
+    # create
+    @taggable.tag_list = "pow, ruby, rails"
+    @taggable.save
+    
+    @taggable.reload
+    ids = @taggable.tags.map{|t| t.taggings.first.id}
+    ids.should == ids.sort
+    
+    # update
+    @taggable.tag_list = "rails, ruby, css, pow"
+    @taggable.save
+    
+    @taggable.reload
+    ids = @taggable.tags.map{|t| t.taggings.first.id}
+    ids.should == ids.sort
+  end
+end
+
 describe "Taggable" do
   before(:each) do
     clean_database!
@@ -224,19 +333,19 @@ describe "Taggable" do
       frank = TaggableModel.create(:name => "Frank", :tag_list => "bobby, jim")
       steve = TaggableModel.create(:name => "Steve", :tag_list => "john, patricia")
       jim = TaggableModel.create(:name => "Jim", :tag_list => "jim, steve")
-      
-      
-      TaggableModel.tagged_with(["bob", "tricia"], :wild => true, :any => true).to_a.should == [bob, frank, steve]      
-      TaggableModel.tagged_with(["bob", "tricia"], :wild => true, :exclude => true).to_a.should == [jim]            
+
+
+      TaggableModel.tagged_with(["bob", "tricia"], :wild => true, :any => true).to_a.sort_by{|o| o.id}.should == [bob, frank, steve]
+      TaggableModel.tagged_with(["bob", "tricia"], :wild => true, :exclude => true).to_a.should == [jim]
     end
   end
-  
+
   it "should be able to find tagged on a custom tag context" do
     bob = TaggableModel.create(:name => "Bob")
     bob.set_tag_list_on(:rotors, "spinning, jumping")
     bob.tag_list_on(:rotors).should == ["spinning","jumping"]
     bob.save
-    
+
     TaggableModel.tagged_with("spinning", :on => :rotors).to_a.should == [bob]
   end
 
@@ -407,6 +516,28 @@ describe "Taggable" do
       @taggable.tag_list_on(:test).should == ["hello"]
     end
   end
+
+  describe "Dirty Objects" do
+    before(:each) do
+      @taggable = TaggableModel.create(:tag_list => "awesome, epic")
+    end
+
+    it 'should show changes of dirty object' do
+      @taggable.changes.should == {}
+      @taggable.tag_list = 'one'
+      @taggable.changes.should == {"tag_list"=>["awesome, epic", ["one"]]}
+
+      @taggable.tag_list_changed?.should be_true
+      @taggable.tag_list_was.should == "awesome, epic"
+      @taggable.tag_list_change.should == ["awesome, epic", ["one"]]
+    end
+
+    it 'should show no changes if the same tag_list' do
+      @taggable.tag_list = "awesome, epic"
+      @taggable.tag_list_changed?.should be_false
+      @taggable.changes.should == {}
+    end
+  end
 end
 
 

data/spec/acts_as_taggable_on/tagger_spec.rb

@@ -16,7 +16,7 @@ describe "Tagger" do
     @user.tag(@taggable, :with=>'ruby,scheme', :on=>:tags)
     @user.owned_tags.size == 2
   end
-  
+
   it "should scope objects returned by tagged_with by owners" do
     @taggable2 = TaggableModel.create(:name => "Jim Jones")
     @taggable3 = TaggableModel.create(:name => "Jane Doe")
@@ -30,7 +30,7 @@ describe "Tagger" do
     TaggableModel.tagged_with(%w(ruby scheme), :owned_by => @user2).count.should == 2
 
   end
-  
+
   it "should not overlap tags from different taggers" do
     @user2 = TaggableUser.new
     lambda{
@@ -42,35 +42,35 @@ describe "Tagger" do
 
     @user.owned_tags.map(&:name).sort.should == %w(ruby scheme).sort
     @user2.owned_tags.map(&:name).sort.should == %w(java python lisp ruby).sort
-    
+
     @taggable.tags_from(@user).sort.should == %w(ruby scheme).sort
     @taggable.tags_from(@user2).sort.should == %w(java lisp python ruby).sort
-    
+
     @taggable.all_tags_list.sort.should == %w(ruby scheme java python lisp).sort
     @taggable.all_tags_on(:tags).size.should == 5
   end
-  
+
   it "should not lose tags from different taggers" do
     @user2 = TaggableUser.create
     @user2.tag(@taggable, :with => 'java, python, lisp, ruby', :on => :tags)
-    @user.tag(@taggable, :with => 'ruby, scheme', :on => :tags)  
-    
+    @user.tag(@taggable, :with => 'ruby, scheme', :on => :tags)
+
     lambda {
       @user2.tag(@taggable, :with => 'java, python, lisp', :on => :tags)
     }.should change(ActsAsTaggableOn::Tagging, :count).by(-1)
 
     [@user, @user2, @taggable].each(&:reload)
-    
+
     @taggable.tags_from(@user).sort.should == %w(ruby scheme).sort
     @taggable.tags_from(@user2).sort.should == %w(java python lisp).sort
-    
+
     @taggable.all_tags_list.sort.should == %w(ruby scheme java python lisp).sort
     @taggable.all_tags_on(:tags).length.should == 5
   end
 
   it "should not lose tags" do
     @user2 = TaggableUser.create
-    
+
     @user.tag(@taggable, :with => 'awesome', :on => :tags)
     @user2.tag(@taggable, :with => 'awesome, epic', :on => :tags)
 
@@ -78,28 +78,35 @@ describe "Tagger" do
       @user2.tag(@taggable, :with => 'epic', :on => :tags)
     }.should change(ActsAsTaggableOn::Tagging, :count).by(-1)
 
-    @taggable.reload  
+    @taggable.reload
     @taggable.all_tags_list.should include('awesome')
     @taggable.all_tags_list.should include('epic')
   end
-  
+
   it "should not lose tags" do
     @taggable.update_attributes(:tag_list => 'ruby')
     @user.tag(@taggable, :with => 'ruby, scheme', :on => :tags)
-    
+
     [@taggable, @user].each(&:reload)
     @taggable.tag_list.should == %w(ruby)
     @taggable.all_tags_list.sort.should == %w(ruby scheme).sort
-    
+
     lambda {
       @taggable.update_attributes(:tag_list => "")
     }.should change(ActsAsTaggableOn::Tagging, :count).by(-1)
-    
+
     @taggable.tag_list.should == []
     @taggable.all_tags_list.sort.should == %w(ruby scheme).sort
   end
 
   it "is tagger" do
     @user.is_tagger?.should(be_true)
-  end  
+  end
+
+  it "should skip save if skip_save is passed as option" do
+    lambda {
+      @user.tag(@taggable, :with => 'epic', :on => :tags, :skip_save => true)
+    }.should_not change(ActsAsTaggableOn::Tagging, :count)
+
+  end
 end

data/spec/models.rb

@@ -42,3 +42,8 @@ class NonStandardIdTaggableModel < ActiveRecord::Base
   acts_as_taggable_on :needs, :offerings
   has_many :untaggable_models
 end
+
+class OrderedTaggableModel < ActiveRecord::Base
+  acts_as_ordered_taggable
+  acts_as_ordered_taggable_on :colours
+end

data/spec/schema.rb

@@ -53,4 +53,9 @@ ActiveRecord::Schema.define :version => 0 do
     t.column :name, :string
     t.column :type, :string
   end
+  
+  create_table :ordered_taggable_models, :force => true do |t|
+    t.column :name, :string
+    t.column :type, :string
+  end
 end

data/spec/spec_helper.rb

@@ -31,6 +31,8 @@ unless [].respond_to?(:freq)
   end
 end
 
+# set adapter to use, default is sqlite3
+# to use an alternative adapter run => rake spec DB='postgresql'
 db_name = ENV['DB'] || 'sqlite3'
 database_yml = File.expand_path('../database.yml', __FILE__)
 
@@ -72,7 +74,7 @@ end
 
 def clean_database!
   models = [ActsAsTaggableOn::Tag, ActsAsTaggableOn::Tagging, TaggableModel, OtherTaggableModel, InheritingTaggableModel,
-            AlteredInheritingTaggableModel, TaggableUser, UntaggableModel]
+            AlteredInheritingTaggableModel, TaggableUser, UntaggableModel, OrderedTaggableModel]
   models.each do |model|
     ActiveRecord::Base.connection.execute "DELETE FROM #{model.table_name}"
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: acts-as-taggable-on
 version: !ruby/object:Gem::Version
-  version: 2.2.2
+  version: 2.3.0
   prerelease: 
 platform: ruby
 authors:
@@ -13,7 +13,7 @@ date: 2012-01-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
-  requirement: &70356686875400 !ruby/object:Gem::Requirement
+  requirement: &70275758086480 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -21,21 +21,21 @@ dependencies:
         version: '3.0'
   type: :runtime
   prerelease: false
-  version_requirements: *70356686875400
+  version_requirements: *70275758086480
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70356686901300 !ruby/object:Gem::Requirement
+  requirement: &70275758085980 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '2.5'
+        version: '2.6'
   type: :development
   prerelease: false
-  version_requirements: *70356686901300
+  version_requirements: *70275758085980
 - !ruby/object:Gem::Dependency
   name: ammeter
-  requirement: &70356686900800 !ruby/object:Gem::Requirement
+  requirement: &70275758085520 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -43,10 +43,10 @@ dependencies:
         version: 0.1.3
   type: :development
   prerelease: false
-  version_requirements: *70356686900800
+  version_requirements: *70275758085520
 - !ruby/object:Gem::Dependency
   name: sqlite3
-  requirement: &70356686900420 !ruby/object:Gem::Requirement
+  requirement: &70275758103040 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70356686900420
+  version_requirements: *70275758103040
 - !ruby/object:Gem::Dependency
   name: mysql2
-  requirement: &70356686899780 !ruby/object:Gem::Requirement
+  requirement: &70275758102400 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -65,10 +65,10 @@ dependencies:
         version: 0.3.7
   type: :development
   prerelease: false
-  version_requirements: *70356686899780
+  version_requirements: *70275758102400
 - !ruby/object:Gem::Dependency
   name: pg
-  requirement: &70356686899280 !ruby/object:Gem::Requirement
+  requirement: &70275758101640 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,10 +76,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70356686899280
+  version_requirements: *70275758101640
 - !ruby/object:Gem::Dependency
   name: guard
-  requirement: &70356686898580 !ruby/object:Gem::Requirement
+  requirement: &70275758100980 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -87,10 +87,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70356686898580
+  version_requirements: *70275758100980
 - !ruby/object:Gem::Dependency
   name: guard-rspec
-  requirement: &70356686897920 !ruby/object:Gem::Requirement
+  requirement: &70275758100180 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -98,7 +98,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70356686897920
+  version_requirements: *70275758100180
 description: With ActsAsTaggableOn, you can tag a single model on several contexts,
   such as skills, interests, and awards. It also provides other advanced functionality.
 email: michael@intridea.com
@@ -121,6 +121,7 @@ files:
 - lib/acts_as_taggable_on/acts_as_taggable_on/cache.rb
 - lib/acts_as_taggable_on/acts_as_taggable_on/collection.rb
 - lib/acts_as_taggable_on/acts_as_taggable_on/core.rb
+- lib/acts_as_taggable_on/acts_as_taggable_on/dirty.rb
 - lib/acts_as_taggable_on/acts_as_taggable_on/ownership.rb
 - lib/acts_as_taggable_on/acts_as_taggable_on/related.rb
 - lib/acts_as_taggable_on/tag.rb
@@ -163,7 +164,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -1793358145648125
+      hash: 3587969812961176900
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -172,7 +173,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -1793358145648125
+      hash: 3587969812961176900
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.10