acts-as-taggable-on 2.1.1 → 2.2.0

data/spec/acts_as_taggable_on/tag_list_spec.rb

@@ -62,6 +62,10 @@ describe ActsAsTaggableOn::TagList do
     @tag_list.to_s.should == "awesome, radical, cool, \"rad,bodacious\""
   end
   
+  it "#from should return empty array if empty array is passed" do
+    ActsAsTaggableOn::TagList.from([]).should == []
+  end
+  
   it "should be able to call to_s on a frozen tag list" do
     @tag_list.freeze
     lambda { @tag_list.add("cool","rad,bodacious") }.should raise_error

data/spec/acts_as_taggable_on/tag_spec.rb

@@ -9,12 +9,13 @@ describe ActsAsTaggableOn::Tag do
 
   describe "named like any" do
     before(:each) do
+      ActsAsTaggableOn::Tag.create(:name => "Awesome")
       ActsAsTaggableOn::Tag.create(:name => "awesome")
       ActsAsTaggableOn::Tag.create(:name => "epic")
     end
 
     it "should find both tags" do
-      ActsAsTaggableOn::Tag.named_like_any(["awesome", "epic"]).should have(2).items
+      ActsAsTaggableOn::Tag.named_like_any(["awesome", "epic"]).should have(3).items
     end
   end
 
@@ -72,7 +73,7 @@ describe ActsAsTaggableOn::Tag do
 
   it "should require a name" do
     @tag.valid?
-    
+
     if ActiveRecord::VERSION::MAJOR >= 3
       @tag.errors[:name].should == ["can't be blank"]
     else
@@ -81,8 +82,8 @@ describe ActsAsTaggableOn::Tag do
 
     @tag.name = "something"
     @tag.valid?
-    
-    if ActiveRecord::VERSION::MAJOR >= 3      
+
+    if ActiveRecord::VERSION::MAJOR >= 3
       @tag.errors[:name].should == []
     else
       @tag.errors[:name].should be_nil
@@ -112,24 +113,19 @@ describe ActsAsTaggableOn::Tag do
     @another_tag = ActsAsTaggableOn::Tag.create!(:name => "coolip")
     ActsAsTaggableOn::Tag.named_like('cool').should include(@tag, @another_tag)
   end
-  
+
   describe "escape wildcard symbols in like requests" do
     before(:each) do
       @tag.name = "cool"
       @tag.save
-      @another_tag = ActsAsTaggableOn::Tag.create!(:name => "coo%") 
-      @another_tag2 = ActsAsTaggableOn::Tag.create!(:name => "coolish")           
+      @another_tag = ActsAsTaggableOn::Tag.create!(:name => "coo%")
+      @another_tag2 = ActsAsTaggableOn::Tag.create!(:name => "coolish")
     end
-    
+
     it "return escaped result when '%' char present in tag" do
-      if @tag.using_sqlite?
-        ActsAsTaggableOn::Tag.named_like('coo%').should include(@tag)     
-        ActsAsTaggableOn::Tag.named_like('coo%').should include(@another_tag)
-      else
-        ActsAsTaggableOn::Tag.named_like('coo%').should_not include(@tag)     
+        ActsAsTaggableOn::Tag.named_like('coo%').should_not include(@tag)
         ActsAsTaggableOn::Tag.named_like('coo%').should include(@another_tag)
-      end
     end
-    
+
   end
 end

data/spec/acts_as_taggable_on/taggable_spec.rb

@@ -25,14 +25,19 @@ describe "Taggable" do
     @taggable.tag_counts_on(:tags).length.should == 2
   end
 
+  it "should return [] right after create" do
+    blank_taggable = TaggableModel.new(:name => "Bob Jones")
+    blank_taggable.tag_list.should == []
+  end
+
   it "should be able to create tags" do
     @taggable.skill_list = "ruby, rails, css"
     @taggable.instance_variable_get("@skill_list").instance_of?(ActsAsTaggableOn::TagList).should be_true
-    
+
     lambda {
       @taggable.save
     }.should change(ActsAsTaggableOn::Tag, :count).by(3)
-    
+
     @taggable.reload
     @taggable.skill_list.sort.should == %w(ruby rails css).sort
   end
@@ -41,10 +46,10 @@ describe "Taggable" do
     @taggable.tag_list_on(:test).add("hello")
     @taggable.tag_list_cache_on(:test).should_not be_empty
     @taggable.tag_list_on(:test).should == ["hello"]
-    
+
     @taggable.save
     @taggable.save_tags
-    
+
     @taggable.reload
     @taggable.tag_list_on(:test).should == ["hello"]
   end
@@ -75,7 +80,7 @@ describe "Taggable" do
     @taggables[0].skill_list = "ruby"
     @taggables[1].skill_list = "css"
     @taggables.each{|taggable| taggable.save}
-    
+
     @found_taggables_by_tag = TaggableModel.joins(:tags).where(:tags => {:name => ["bob"]})
     @found_taggables_by_skill = TaggableModel.joins(:skills).where(:tags => {:name => ["ruby"]})
 
@@ -84,7 +89,7 @@ describe "Taggable" do
     @found_taggables_by_skill.should include @taggables[0]
     @found_taggables_by_skill.should_not include @taggables[1]
   end
-  
+
   it "should be able to find by tag" do
     @taggable.skill_list = "ruby, rails, css"
     @taggable.save
@@ -136,7 +141,7 @@ describe "Taggable" do
     # Let's only find those who need rails or css and are offering c++ or java
     TaggableModel.tagged_with(['rails, css'], :on => :needs, :any => true).tagged_with(['c++', 'java'], :on => :offerings, :any => true).to_a.should == [bob]
   end
-  
+
   if ActiveRecord::VERSION::MAJOR >= 3
     it "should not return read-only records" do
       TaggableModel.create(:name => "Bob", :tag_list => "ruby, rails, css")
@@ -146,10 +151,10 @@ describe "Taggable" do
     xit "should not return read-only records" do
       # apparantly, there is no way to set readonly to false in a scope if joins are made
     end
-    
+
     it "should be possible to return writable records" do
       TaggableModel.create(:name => "Bob", :tag_list => "ruby, rails, css")
-      TaggableModel.tagged_with("ruby").first(:readonly => false).should_not be_readonly      
+      TaggableModel.tagged_with("ruby").first(:readonly => false).should_not be_readonly
     end
   end
 
@@ -174,10 +179,10 @@ describe "Taggable" do
     bob = TaggableModel.create(:name => "Bob", :tag_list => "ruby, rails, css")
     frank = TaggableModel.create(:name => "Frank", :tag_list => "ruby, rails")
     charlie = TaggableModel.create(:name => "Charlie", :skill_list => "ruby, java")
- 
+
     TaggableModel.tagged_with('rails').all_tag_counts.should have(3).items
     TaggableModel.tagged_with('rails').all_tag_counts.any? { |tag| tag.name == 'java' }.should be_false
-    
+
     # Test specific join syntaxes:
     frank.untaggable_models.create!
     TaggableModel.tagged_with('rails').scoped(:joins => :untaggable_models).all_tag_counts.should have(2).items
@@ -203,15 +208,15 @@ describe "Taggable" do
     TaggableModel.tagged_with("ruby, rails", :order => 'taggable_models.name').to_a.should == [bob, frank]
     TaggableModel.tagged_with(["ruby", "rails"], :order => 'taggable_models.name').to_a.should == [bob, frank]
   end
-  
+
   it "should be able to find tagged with quotation marks" do
     bob = TaggableModel.create(:name => "Bob", :tag_list => "fitter, happier, more productive, 'I love the ,comma,'")
     TaggableModel.tagged_with("'I love the ,comma,'").should include(bob)
   end
-  
+
   it "should be able to find tagged with invalid tags" do
-    bob = TaggableModel.create(:name => "Bob", :tag_list => "fitter, happier, more productive")    
-    TaggableModel.tagged_with("sad, happier").should_not include(bob)    
+    bob = TaggableModel.create(:name => "Bob", :tag_list => "fitter, happier, more productive")
+    TaggableModel.tagged_with("sad, happier").should_not include(bob)
   end
 
   it "should be able to find tagged with any tag" do
@@ -260,11 +265,12 @@ describe "Taggable" do
 
     TaggableModel.tagged_with("lazy", :exclude => true).to_a.should == [frank, steve]
   end
-  
+
   it "should return an empty scope for empty tags" do
     TaggableModel.tagged_with('').should == []
     TaggableModel.tagged_with(' ').should == []
-    TaggableModel.tagged_with(nil).should == []    
+    TaggableModel.tagged_with(nil).should == []
+    TaggableModel.tagged_with([]).should == []
   end
 
   it "should not create duplicate taggings" do
@@ -275,12 +281,12 @@ describe "Taggable" do
       bob.save
     }.should change(ActsAsTaggableOn::Tagging, :count).by(1)
   end
- 
+
   describe "Associations" do
     before(:each) do
       @taggable = TaggableModel.create(:tag_list => "awesome, epic")
     end
-    
+
     it "should not remove tags when creating associated objects" do
       @taggable.untaggable_models.create!
       @taggable.reload
@@ -296,6 +302,10 @@ describe "Taggable" do
     it "should return all column names joined for TaggableModel GROUP clause" do
       @taggable.grouped_column_names_for(TaggableModel).should == "taggable_models.id, taggable_models.name, taggable_models.type"
     end
+
+    it "should return all column names joined for NonStandardIdTaggableModel GROUP clause" do
+      @taggable.grouped_column_names_for(TaggableModel).should == "taggable_models.#{TaggableModel.primary_key}, taggable_models.name, taggable_models.type"
+    end
   end
 
   describe "Single Table Inheritance" do
@@ -304,45 +314,97 @@ describe "Taggable" do
       @inherited_same = InheritingTaggableModel.new(:name => "inherited same")
       @inherited_different = AlteredInheritingTaggableModel.new(:name => "inherited different")
     end
-  
+
     it "should be able to save tags for inherited models" do
       @inherited_same.tag_list = "bob, kelso"
       @inherited_same.save
       InheritingTaggableModel.tagged_with("bob").first.should == @inherited_same
     end
-  
+
     it "should find STI tagged models on the superclass" do
       @inherited_same.tag_list = "bob, kelso"
       @inherited_same.save
       TaggableModel.tagged_with("bob").first.should == @inherited_same
     end
-  
+
     it "should be able to add on contexts only to some subclasses" do
       @inherited_different.part_list = "fork, spoon"
       @inherited_different.save
       InheritingTaggableModel.tagged_with("fork", :on => :parts).should be_empty
       AlteredInheritingTaggableModel.tagged_with("fork", :on => :parts).first.should == @inherited_different
     end
-  
+
     it "should have different tag_counts_on for inherited models" do
       @inherited_same.tag_list = "bob, kelso"
       @inherited_same.save!
       @inherited_different.tag_list = "fork, spoon"
       @inherited_different.save!
-  
+
       InheritingTaggableModel.tag_counts_on(:tags, :order => 'tags.id').map(&:name).should == %w(bob kelso)
       AlteredInheritingTaggableModel.tag_counts_on(:tags, :order => 'tags.id').map(&:name).should == %w(fork spoon)
       TaggableModel.tag_counts_on(:tags, :order => 'tags.id').map(&:name).should == %w(bob kelso fork spoon)
     end
-  
+
     it 'should store same tag without validation conflict' do
       @taggable.tag_list = 'one'
       @taggable.save!
-  
+
       @inherited_same.tag_list = 'one'
       @inherited_same.save!
-  
+
       @inherited_same.update_attributes! :name => 'foo'
     end
   end
+
+  describe "NonStandardIdTaggable" do
+    before(:each) do
+      clean_database!
+      @taggable = NonStandardIdTaggableModel.new(:name => "Bob Jones")
+      @taggables = [@taggable, NonStandardIdTaggableModel.new(:name => "John Doe")]
+    end
+
+    it "should have tag types" do
+      [:tags, :languages, :skills, :needs, :offerings].each do |type|
+        NonStandardIdTaggableModel.tag_types.should include type
+      end
+
+      @taggable.tag_types.should == NonStandardIdTaggableModel.tag_types
+    end
+
+    it "should have tag_counts_on" do
+      NonStandardIdTaggableModel.tag_counts_on(:tags).all.should be_empty
+
+      @taggable.tag_list = ["awesome", "epic"]
+      @taggable.save
+
+      NonStandardIdTaggableModel.tag_counts_on(:tags).length.should == 2
+      @taggable.tag_counts_on(:tags).length.should == 2
+    end
+
+    it "should be able to create tags" do
+      @taggable.skill_list = "ruby, rails, css"
+      @taggable.instance_variable_get("@skill_list").instance_of?(ActsAsTaggableOn::TagList).should be_true
+
+      lambda {
+        @taggable.save
+      }.should change(ActsAsTaggableOn::Tag, :count).by(3)
+
+      @taggable.reload
+      @taggable.skill_list.sort.should == %w(ruby rails css).sort
+    end
+
+    it "should be able to create tags through the tag list directly" do
+      @taggable.tag_list_on(:test).add("hello")
+      @taggable.tag_list_cache_on(:test).should_not be_empty
+      @taggable.tag_list_on(:test).should == ["hello"]
+
+      @taggable.save
+      @taggable.save_tags
+
+      @taggable.reload
+      @taggable.tag_list_on(:test).should == ["hello"]
+    end
+  end
 end
+
+

data/spec/acts_as_taggable_on/tagger_spec.rb

@@ -17,6 +17,20 @@ describe "Tagger" do
     @user.owned_tags.size == 2
   end
   
+  it "should scope objects returned by tagged_with by owners" do
+    @taggable2 = TaggableModel.create(:name => "Jim Jones")
+    @taggable3 = TaggableModel.create(:name => "Jane Doe")
+
+    @user2 = TaggableUser.new
+    @user.tag(@taggable, :with => 'ruby, scheme', :on => :tags)
+    @user2.tag(@taggable2, :with => 'ruby, scheme', :on => :tags)
+    @user2.tag(@taggable3, :with => 'ruby, scheme', :on => :tags)
+
+    TaggableModel.tagged_with(%w(ruby scheme), :owned_by => @user).count.should == 1
+    TaggableModel.tagged_with(%w(ruby scheme), :owned_by => @user2).count.should == 2
+
+  end
+  
   it "should not overlap tags from different taggers" do
     @user2 = TaggableUser.new
     lambda{

data/spec/acts_as_taggable_on/utils_spec.rb

@@ -4,16 +4,15 @@ describe ActsAsTaggableOn::Utils do
   describe "like_operator" do
     before(:each) do
       clean_database!
-      TaggableModel.write_inheritable_attribute(:tag_types, [])
       TaggableModel.acts_as_taggable_on(:tags, :languages, :skills, :needs, :offerings)
       @taggable = TaggableModel.new(:name => "Bob Jones")
     end
-  
+
     it "should return 'ILIKE' when the adapter is PostgreSQL" do
       TaggableModel.connection.stub(:adapter_name).and_return("PostgreSQL")
       TaggableModel.send(:like_operator).should == "ILIKE"
     end
-  
+
     it "should return 'LIKE' when the adapter is not PostgreSQL" do
       TaggableModel.connection.stub(:adapter_name).and_return("MySQL")
       TaggableModel.send(:like_operator).should == "LIKE"

data/spec/database.yml.sample

@@ -16,4 +16,4 @@ postgresql:
   username: postgres
   password:
   database: acts_as_taggable_on
-  encoding: utf8
+  encoding: utf8

data/spec/generators/acts_as_taggable_on/migration/migration_generator_spec.rb

@@ -0,0 +1,22 @@
+require 'spec_helper'
+
+# Generators are not automatically loaded by Rails
+require 'generators/acts_as_taggable_on/migration/migration_generator'
+
+describe ActsAsTaggableOn::MigrationGenerator do
+  # Tell the generator where to put its output (what it thinks of as Rails.root)
+  destination File.expand_path("../../../../../tmp", __FILE__)
+
+  before do
+    prepare_destination
+    Rails::Generators.options[:rails][:orm] = :active_record
+  end
+  describe 'no arguments' do
+    before { run_generator  }
+
+    describe 'db/migrate/acts_as_taggable_on_migration.rb' do
+      subject { file('db/migrate/acts_as_taggable_on_migration.rb') }
+      it { should be_a_migration }
+    end
+  end
+end

data/spec/models.rb

@@ -11,7 +11,7 @@ class CachedModel < ActiveRecord::Base
 end
 
 class OtherCachedModel < ActiveRecord::Base
-  acts_as_taggable_on :languages
+  acts_as_taggable_on :languages, :statuses, :glasses
 end
 
 class OtherTaggableModel < ActiveRecord::Base
@@ -32,4 +32,13 @@ end
 
 class UntaggableModel < ActiveRecord::Base
   belongs_to :taggable_model
-end
+end
+
+class NonStandardIdTaggableModel < ActiveRecord::Base
+  set_primary_key "an_id"
+  acts_as_taggable
+  acts_as_taggable_on :languages
+  acts_as_taggable_on :skills
+  acts_as_taggable_on :needs, :offerings
+  has_many :untaggable_models
+end

data/spec/schema.rb

@@ -21,6 +21,11 @@ ActiveRecord::Schema.define :version => 0 do
     t.column :type, :string
   end
   
+  create_table :non_standard_id_taggable_models, :primary_key => "an_id", :force => true do |t|
+    t.column :name, :string
+    t.column :type, :string
+  end
+  
   create_table :untaggable_models, :force => true do |t|
     t.column :taggable_model_id, :integer
     t.column :name, :string
@@ -36,6 +41,8 @@ ActiveRecord::Schema.define :version => 0 do
     t.column :name, :string
     t.column :type, :string
     t.column :cached_language_list, :string    
+    t.column :cached_status_list, :string
+    t.column :cached_glass_list, :string
   end
   
   create_table :taggable_users, :force => true do |t|

data/spec/spec_helper.rb

@@ -19,6 +19,7 @@ end
 
 Bundler.require
 require File.expand_path('../../lib/acts-as-taggable-on', __FILE__)
+require 'ammeter/init'
 
 unless [].respond_to?(:freq)
   class Array