acts-as-taggable-on 2.0.6 → 2.4.0

data/spec/acts_as_taggable_on/tag_list_spec.rb

@@ -1,70 +1,126 @@
+# -*- coding: utf-8 -*-
 require File.expand_path('../../spec_helper', __FILE__)
 
 describe ActsAsTaggableOn::TagList do
-  before(:each) do
-    @tag_list = ActsAsTaggableOn::TagList.new("awesome","radical")
-  end
-  
-  it "should be an array" do
-    @tag_list.is_a?(Array).should be_true
-  end
-  
-  it "should be able to be add a new tag word" do
-    @tag_list.add("cool")
-    @tag_list.include?("cool").should be_true
-  end
-  
-  it "should be able to add delimited lists of words" do
-    @tag_list.add("cool, wicked", :parse => true)
-    @tag_list.include?("cool").should be_true
-    @tag_list.include?("wicked").should be_true
-  end
-  
-  it "should be able to add delimited list of words with quoted delimiters" do
-    @tag_list.add("'cool, wicked', \"really cool, really wicked\"", :parse => true)
-    @tag_list.include?("cool, wicked").should be_true
-    @tag_list.include?("really cool, really wicked").should be_true
-  end
-  
-  it "should be able to handle other uses of quotation marks correctly" do
-    @tag_list.add("john's cool car, mary's wicked toy", :parse => true)
-    @tag_list.include?("john's cool car").should be_true
-    @tag_list.include?("mary's wicked toy").should be_true
-  end
-  
-  it "should be able to add an array of words" do
-    @tag_list.add(["cool", "wicked"], :parse => true)
-    @tag_list.include?("cool").should be_true
-    @tag_list.include?("wicked").should be_true
-  end
-  
-  it "should be able to remove words" do
-    @tag_list.remove("awesome")
-    @tag_list.include?("awesome").should be_false
+  let(:tag_list) { ActsAsTaggableOn::TagList.new("awesome","radical") }
+
+  it { should be_kind_of Array }
+
+  it "#from should return empty array if empty array is passed" do
+    ActsAsTaggableOn::TagList.from([]).should be_empty
   end
-  
-  it "should be able to remove delimited lists of words" do
-    @tag_list.remove("awesome, radical", :parse => true)
-    @tag_list.should be_empty
+
+  describe "#add" do
+    it "should be able to be add a new tag word" do
+      tag_list.add("cool")
+      tag_list.include?("cool").should be_true
+    end
+
+    it "should be able to add delimited lists of words" do
+      tag_list.add("cool, wicked", :parse => true)
+      tag_list.should include("cool", "wicked")
+    end
+
+    it "should be able to add delimited list of words with quoted delimiters" do
+      tag_list.add("'cool, wicked', \"really cool, really wicked\"", :parse => true)
+      tag_list.should include("cool, wicked", "really cool, really wicked")
+    end
+
+    it "should be able to handle other uses of quotation marks correctly" do
+      tag_list.add("john's cool car, mary's wicked toy", :parse => true)
+      tag_list.should include("john's cool car", "mary's wicked toy")
+    end
+
+    it "should be able to add an array of words" do
+      tag_list.add(["cool", "wicked"], :parse => true)
+      tag_list.should include("cool", "wicked")
+    end
+
+    it "should quote escape tags with commas in them" do
+      tag_list.add("cool","rad,bodacious")
+      tag_list.to_s.should == "awesome, radical, cool, \"rad,bodacious\""
+    end
+
   end
-  
-  it "should be able to remove an array of words" do
-    @tag_list.remove(["awesome", "radical"], :parse => true)
-    @tag_list.should be_empty
+
+  describe "#remove" do
+    it "should be able to remove words" do
+      tag_list.remove("awesome")
+      tag_list.should_not include("awesome")
+    end
+
+    it "should be able to remove delimited lists of words" do
+      tag_list.remove("awesome, radical", :parse => true)
+      tag_list.should be_empty
+    end
+
+    it "should be able to remove an array of words" do
+      tag_list.remove(["awesome", "radical"], :parse => true)
+      tag_list.should be_empty
+    end
   end
-  
-  it "should give a delimited list of words when converted to string" do
-    @tag_list.to_s.should == "awesome, radical"
+
+  describe "#to_s" do
+    it "should give a delimited list of words when converted to string" do
+      tag_list.to_s.should == "awesome, radical"
+    end
+
+    it "should be able to call to_s on a frozen tag list" do
+      tag_list.freeze
+      lambda { tag_list.add("cool","rad,bodacious") }.should raise_error
+      lambda { tag_list.to_s }.should_not raise_error
+    end
   end
-  
-  it "should quote escape tags with commas in them" do
-    @tag_list.add("cool","rad,bodacious")
-    @tag_list.to_s.should == "awesome, radical, cool, \"rad,bodacious\""
+
+  describe "cleaning" do
+    it "should parameterize if force_parameterize is set to true" do
+      ActsAsTaggableOn.force_parameterize = true
+      tag_list = ActsAsTaggableOn::TagList.new("awesome()","radical)(cc")
+
+      tag_list.to_s.should == "awesome, radical-cc"
+      ActsAsTaggableOn.force_parameterize = false
+    end
+
+    it "should lowercase if force_lowercase is set to true" do
+      ActsAsTaggableOn.force_lowercase = true
+
+      tag_list = ActsAsTaggableOn::TagList.new("aweSomE","RaDicaL","Entrée")
+      tag_list.to_s.should == "awesome, radical, entrée"
+
+      ActsAsTaggableOn.force_lowercase = false
+    end
+
   end
-  
-  it "should be able to call to_s on a frozen tag list" do
-    @tag_list.freeze
-    lambda { @tag_list.add("cool","rad,bodacious") }.should raise_error
-    lambda { @tag_list.to_s }.should_not raise_error
+
+  describe "Multiple Delimiter" do
+    before do 
+      @old_delimiter = ActsAsTaggableOn.delimiter
+    end
+
+    after do 
+      ActsAsTaggableOn.delimiter = @old_delimiter
+    end
+
+    it "should separate tags by delimiters" do
+      ActsAsTaggableOn.delimiter = [',', ' ', '\|']
+      tag_list = ActsAsTaggableOn::TagList.from "cool, data|I have"
+      tag_list.to_s.should == 'cool, data, I, have'
+    end
+
+    it "should escape quote" do 
+      ActsAsTaggableOn.delimiter = [',', ' ', '\|']
+      tag_list = ActsAsTaggableOn::TagList.from "'I have'|cool, data"
+      tag_list.to_s.should == '"I have", cool, data'
+
+      tag_list = ActsAsTaggableOn::TagList.from '"I, have"|cool, data'
+      tag_list.to_s.should == '"I, have", cool, data'
+    end
+
+    it "should work for utf8 delimiter and long delimiter" do 
+      ActsAsTaggableOn.delimiter = ['，', '的', '可能是']
+      tag_list = ActsAsTaggableOn::TagList.from "我的东西可能是不见了，还好有备份"
+      tag_list.to_s.should == "我， 东西， 不见了， 还好有备份"
+    end
   end
-end
+
+end

data/spec/acts_as_taggable_on/tag_spec.rb

@@ -1,3 +1,5 @@
+#encoding: utf-8
+
 require File.expand_path('../../spec_helper', __FILE__)
 
 describe ActsAsTaggableOn::Tag do
@@ -9,12 +11,13 @@ describe ActsAsTaggableOn::Tag do
 
   describe "named like any" do
     before(:each) do
+      ActsAsTaggableOn::Tag.create(:name => "Awesome")
       ActsAsTaggableOn::Tag.create(:name => "awesome")
       ActsAsTaggableOn::Tag.create(:name => "epic")
     end
 
     it "should find both tags" do
-      ActsAsTaggableOn::Tag.named_like_any(["awesome", "epic"]).should have(2).items
+      ActsAsTaggableOn::Tag.named_like_any(["awesome", "epic"]).should have(3).items
     end
   end
 
@@ -39,6 +42,23 @@ describe ActsAsTaggableOn::Tag do
     end
   end
 
+  unless ActsAsTaggableOn::Tag.using_sqlite?
+    describe "find or create by unicode name" do
+      before(:each) do
+        @tag.name = "привет"
+        @tag.save
+      end
+
+      it "should find by name" do
+        ActsAsTaggableOn::Tag.find_or_create_with_like_by_name("привет").should == @tag
+      end
+
+      it "should find by name case insensitive" do
+        ActsAsTaggableOn::Tag.find_or_create_with_like_by_name("ПРИВЕТ").should == @tag
+      end
+    end
+  end
+
   describe "find or create all by any name" do
     before(:each) do
       @tag.name = "awesome"
@@ -72,21 +92,23 @@ describe ActsAsTaggableOn::Tag do
 
   it "should require a name" do
     @tag.valid?
-    
-    if ActiveRecord::VERSION::MAJOR >= 3
-      @tag.errors[:name].should == ["can't be blank"]
-    else
-      @tag.errors[:name].should == "can't be blank"
-    end
+
+    @tag.errors[:name].should == ["can't be blank"]
 
     @tag.name = "something"
     @tag.valid?
-    
-    if ActiveRecord::VERSION::MAJOR >= 3      
-      @tag.errors[:name].should == []
-    else
-      @tag.errors[:name].should be_nil
-    end
+
+    @tag.errors[:name].should == []
+  end
+
+  it "should limit the name length to 255 or less characters" do
+    @tag.name = "fgkgnkkgjymkypbuozmwwghblmzpqfsgjasflblywhgkwndnkzeifalfcpeaeqychjuuowlacmuidnnrkprgpcpybarbkrmziqihcrxirlokhnzfvmtzixgvhlxzncyywficpraxfnjptxxhkqmvicbcdcynkjvziefqzyndxkjmsjlvyvbwraklbalykyxoliqdlreeykuphdtmzfdwpphmrqvwvqffojkqhlzvinqajsxbszyvrqqyzusxranr"
+    @tag.valid?
+    @tag.errors[:name].should == ["is too long (maximum is 255 characters)"]
+
+    @tag.name = "fgkgnkkgjymkypbuozmwwghblmzpqfsgjasflblywhgkwndnkzeifalfcpeaeqychjuuowlacmuidnnrkprgpcpybarbkrmziqihcrxirlokhnzfvmtzixgvhlxzncyywficpraxfnjptxxhkqmvicbcdcynkjvziefqzyndxkjmsjlvyvbwraklbalykyxoliqdlreeykuphdtmzfdwpphmrqvwvqffojkqhlzvinqajsxbszyvrqqyzusxran"
+    @tag.valid?
+    @tag.errors[:name].should == []
   end
 
   it "should equal a tag with the same name" do
@@ -112,4 +134,79 @@ describe ActsAsTaggableOn::Tag do
     @another_tag = ActsAsTaggableOn::Tag.create!(:name => "coolip")
     ActsAsTaggableOn::Tag.named_like('cool').should include(@tag, @another_tag)
   end
-end
+
+  describe "escape wildcard symbols in like requests" do
+    before(:each) do
+      @tag.name = "cool"
+      @tag.save
+      @another_tag = ActsAsTaggableOn::Tag.create!(:name => "coo%")
+      @another_tag2 = ActsAsTaggableOn::Tag.create!(:name => "coolish")
+    end
+
+    it "return escaped result when '%' char present in tag" do
+        ActsAsTaggableOn::Tag.named_like('coo%').should_not include(@tag)
+        ActsAsTaggableOn::Tag.named_like('coo%').should include(@another_tag)
+    end
+
+  end
+
+  describe "when using strict_case_match" do
+    before do
+      ActsAsTaggableOn.strict_case_match = true
+      @tag.name = "awesome"
+      @tag.save!
+    end
+
+    after do
+      ActsAsTaggableOn.strict_case_match = false
+    end
+
+    it "should find by name" do
+      ActsAsTaggableOn::Tag.find_or_create_with_like_by_name("awesome").should == @tag
+    end
+
+    it "should find by name case sensitively" do
+      expect {
+        ActsAsTaggableOn::Tag.find_or_create_with_like_by_name("AWESOME")
+      }.to change(ActsAsTaggableOn::Tag, :count)
+
+      ActsAsTaggableOn::Tag.last.name.should == "AWESOME"
+    end
+
+    it "should have a named_scope named(something) that matches exactly" do
+      uppercase_tag = ActsAsTaggableOn::Tag.create(:name => "Cool")
+      @tag.name     = "cool"
+      @tag.save!
+
+      ActsAsTaggableOn::Tag.named('cool').should include(@tag)
+      ActsAsTaggableOn::Tag.named('cool').should_not include(uppercase_tag)
+    end
+  end
+
+  describe "name uniqeness validation" do
+    let(:duplicate_tag) { ActsAsTaggableOn::Tag.new(:name => 'ror') }
+
+    before { ActsAsTaggableOn::Tag.create(:name => 'ror') }
+
+    context "when don't need unique names" do
+      it "should not run uniqueness validation" do
+        duplicate_tag.stub(:validates_name_uniqueness?).and_return(false)
+        duplicate_tag.save
+        duplicate_tag.should be_persisted
+      end  
+    end
+
+    context "when do need unique names" do
+      it "should run uniqueness validation" do
+        duplicate_tag.should_not be_valid        
+      end
+
+      it "add error to name" do
+        duplicate_tag.save
+
+        duplicate_tag.should have(1).errors
+        duplicate_tag.errors.messages[:name].should include('has already been taken')
+      end
+    end
+  end
+end