acts-as-taggable-on 2.0.6 → 2.3.0

data/spec/acts_as_taggable_on/tag_spec.rb

@@ -1,3 +1,5 @@
+#encoding: utf-8
+
 require File.expand_path('../../spec_helper', __FILE__)
 
 describe ActsAsTaggableOn::Tag do
@@ -9,12 +11,13 @@ describe ActsAsTaggableOn::Tag do
 
   describe "named like any" do
     before(:each) do
+      ActsAsTaggableOn::Tag.create(:name => "Awesome")
       ActsAsTaggableOn::Tag.create(:name => "awesome")
       ActsAsTaggableOn::Tag.create(:name => "epic")
     end
 
     it "should find both tags" do
-      ActsAsTaggableOn::Tag.named_like_any(["awesome", "epic"]).should have(2).items
+      ActsAsTaggableOn::Tag.named_like_any(["awesome", "epic"]).should have(3).items
     end
   end
 
@@ -39,6 +42,23 @@ describe ActsAsTaggableOn::Tag do
     end
   end
 
+  unless ActsAsTaggableOn::Tag.using_sqlite?
+    describe "find or create by unicode name" do
+      before(:each) do
+        @tag.name = "привет"
+        @tag.save
+      end
+
+      it "should find by name" do
+        ActsAsTaggableOn::Tag.find_or_create_with_like_by_name("привет").should == @tag
+      end
+
+      it "should find by name case insensitive" do
+        ActsAsTaggableOn::Tag.find_or_create_with_like_by_name("ПРИВЕТ").should == @tag
+      end
+    end
+  end
+
   describe "find or create all by any name" do
     before(:each) do
       @tag.name = "awesome"
@@ -72,21 +92,23 @@ describe ActsAsTaggableOn::Tag do
 
   it "should require a name" do
     @tag.valid?
-    
-    if ActiveRecord::VERSION::MAJOR >= 3
-      @tag.errors[:name].should == ["can't be blank"]
-    else
-      @tag.errors[:name].should == "can't be blank"
-    end
+
+    @tag.errors[:name].should == ["can't be blank"]
 
     @tag.name = "something"
     @tag.valid?
-    
-    if ActiveRecord::VERSION::MAJOR >= 3      
-      @tag.errors[:name].should == []
-    else
-      @tag.errors[:name].should be_nil
-    end
+
+    @tag.errors[:name].should == []
+  end
+
+  it "should limit the name length to 255 or less characters" do
+    @tag.name = "fgkgnkkgjymkypbuozmwwghblmzpqfsgjasflblywhgkwndnkzeifalfcpeaeqychjuuowlacmuidnnrkprgpcpybarbkrmziqihcrxirlokhnzfvmtzixgvhlxzncyywficpraxfnjptxxhkqmvicbcdcynkjvziefqzyndxkjmsjlvyvbwraklbalykyxoliqdlreeykuphdtmzfdwpphmrqvwvqffojkqhlzvinqajsxbszyvrqqyzusxranr"
+    @tag.valid?
+    @tag.errors[:name].should == ["is too long (maximum is 255 characters)"]
+
+    @tag.name = "fgkgnkkgjymkypbuozmwwghblmzpqfsgjasflblywhgkwndnkzeifalfcpeaeqychjuuowlacmuidnnrkprgpcpybarbkrmziqihcrxirlokhnzfvmtzixgvhlxzncyywficpraxfnjptxxhkqmvicbcdcynkjvziefqzyndxkjmsjlvyvbwraklbalykyxoliqdlreeykuphdtmzfdwpphmrqvwvqffojkqhlzvinqajsxbszyvrqqyzusxran"
+    @tag.valid?
+    @tag.errors[:name].should == []
   end
 
   it "should equal a tag with the same name" do
@@ -112,4 +134,20 @@ describe ActsAsTaggableOn::Tag do
     @another_tag = ActsAsTaggableOn::Tag.create!(:name => "coolip")
     ActsAsTaggableOn::Tag.named_like('cool').should include(@tag, @another_tag)
   end
+
+  describe "escape wildcard symbols in like requests" do
+    before(:each) do
+      @tag.name = "cool"
+      @tag.save
+      @another_tag = ActsAsTaggableOn::Tag.create!(:name => "coo%")
+      @another_tag2 = ActsAsTaggableOn::Tag.create!(:name => "coolish")
+    end
+
+    it "return escaped result when '%' char present in tag" do
+        ActsAsTaggableOn::Tag.named_like('coo%').should_not include(@tag)
+        ActsAsTaggableOn::Tag.named_like('coo%').should include(@another_tag)
+    end
+
+  end
+
 end

data/spec/acts_as_taggable_on/taggable_spec.rb

@@ -1,9 +1,119 @@
 require File.expand_path('../../spec_helper', __FILE__)
 
+describe "Taggable To Preserve Order" do
+  before(:each) do
+    clean_database!
+    @taggable = OrderedTaggableModel.new(:name => "Bob Jones")
+  end
+  
+  it "should have tag types" do
+    [:tags, :colours].each do |type|
+      OrderedTaggableModel.tag_types.should include type
+    end
+
+    @taggable.tag_types.should == OrderedTaggableModel.tag_types
+  end
+  
+  it "should have tag associations" do
+    [:tags, :colours].each do |type|
+      @taggable.respond_to?(type).should be_true
+      @taggable.respond_to?("#{type.to_s.singularize}_taggings").should be_true
+    end
+  end
+  
+  it "should have tag associations ordered by id" do
+    [:tags, :colours].each do |type|
+      OrderedTaggableModel.reflect_on_association(type).options[:order].should include('id')
+      OrderedTaggableModel.reflect_on_association("#{type.to_s.singularize}_taggings".to_sym).options[:order].should include('id')
+    end
+  end
+  
+  it "should have tag methods" do
+    [:tags, :colours].each do |type|
+      @taggable.respond_to?("#{type.to_s.singularize}_list").should be_true
+      @taggable.respond_to?("#{type.to_s.singularize}_list=").should be_true
+      @taggable.respond_to?("all_#{type.to_s}_list").should be_true
+    end
+  end
+
+  it "should return tag list in the order the tags were created" do
+    # create
+    @taggable.tag_list = "rails, ruby, css"
+    @taggable.instance_variable_get("@tag_list").instance_of?(ActsAsTaggableOn::TagList).should be_true
+    
+    lambda {
+      @taggable.save
+    }.should change(ActsAsTaggableOn::Tag, :count).by(3)
+    
+    @taggable.reload
+    @taggable.tag_list.should == %w(rails ruby css)
+    
+    # update
+    @taggable.tag_list = "pow, ruby, rails"
+    @taggable.save
+        
+    @taggable.reload
+    @taggable.tag_list.should == %w(pow ruby rails)
+    
+    # update with no change
+    @taggable.tag_list = "pow, ruby, rails"
+    @taggable.save
+        
+    @taggable.reload
+    @taggable.tag_list.should == %w(pow ruby rails)
+    
+    # update to clear tags
+    @taggable.tag_list = ""
+    @taggable.save
+        
+    @taggable.reload
+    @taggable.tag_list.should == []
+  end
+  
+  it "should return tag objects in the order the tags were created" do
+    # create
+    @taggable.tag_list = "pow, ruby, rails"
+    @taggable.instance_variable_get("@tag_list").instance_of?(ActsAsTaggableOn::TagList).should be_true
+    
+    lambda {
+      @taggable.save
+    }.should change(ActsAsTaggableOn::Tag, :count).by(3)
+    
+    @taggable.reload
+    @taggable.tags.map{|t| t.name}.should == %w(pow ruby rails)
+    
+    # update
+    @taggable.tag_list = "rails, ruby, css, pow"
+    @taggable.save
+    
+    @taggable.reload
+    @taggable.tags.map{|t| t.name}.should == %w(rails ruby css pow)
+  end
+  
+  it "should return tag objects in tagging id order" do
+    # create
+    @taggable.tag_list = "pow, ruby, rails"
+    @taggable.save
+    
+    @taggable.reload
+    ids = @taggable.tags.map{|t| t.taggings.first.id}
+    ids.should == ids.sort
+    
+    # update
+    @taggable.tag_list = "rails, ruby, css, pow"
+    @taggable.save
+    
+    @taggable.reload
+    ids = @taggable.tags.map{|t| t.taggings.first.id}
+    ids.should == ids.sort
+  end
+end
+
 describe "Taggable" do
   before(:each) do
     clean_database!
     @taggable = TaggableModel.new(:name => "Bob Jones")
+    @taggables = [@taggable, TaggableModel.new(:name => "John Doe")]
   end
 
   it "should have tag types" do
@@ -24,14 +134,19 @@ describe "Taggable" do
     @taggable.tag_counts_on(:tags).length.should == 2
   end
 
+  it "should return [] right after create" do
+    blank_taggable = TaggableModel.new(:name => "Bob Jones")
+    blank_taggable.tag_list.should == []
+  end
+
   it "should be able to create tags" do
     @taggable.skill_list = "ruby, rails, css"
     @taggable.instance_variable_get("@skill_list").instance_of?(ActsAsTaggableOn::TagList).should be_true
-    
+
     lambda {
       @taggable.save
     }.should change(ActsAsTaggableOn::Tag, :count).by(3)
-    
+
     @taggable.reload
     @taggable.skill_list.sort.should == %w(ruby rails css).sort
   end
@@ -40,10 +155,10 @@ describe "Taggable" do
     @taggable.tag_list_on(:test).add("hello")
     @taggable.tag_list_cache_on(:test).should_not be_empty
     @taggable.tag_list_on(:test).should == ["hello"]
-    
+
     @taggable.save
     @taggable.save_tags
-    
+
     @taggable.reload
     @taggable.tag_list_on(:test).should == ["hello"]
   end
@@ -68,6 +183,22 @@ describe "Taggable" do
     @taggable.should have(2).skills
   end
 
+  it "should be able to select taggables by subset of tags using ActiveRelation methods" do
+    @taggables[0].tag_list = "bob"
+    @taggables[1].tag_list = "charlie"
+    @taggables[0].skill_list = "ruby"
+    @taggables[1].skill_list = "css"
+    @taggables.each{|taggable| taggable.save}
+
+    @found_taggables_by_tag = TaggableModel.joins(:tags).where(:tags => {:name => ["bob"]})
+    @found_taggables_by_skill = TaggableModel.joins(:skills).where(:tags => {:name => ["ruby"]})
+
+    @found_taggables_by_tag.should include @taggables[0]
+    @found_taggables_by_tag.should_not include @taggables[1]
+    @found_taggables_by_skill.should include @taggables[0]
+    @found_taggables_by_skill.should_not include @taggables[1]
+  end
+
   it "should be able to find by tag" do
     @taggable.skill_list = "ruby, rails, css"
     @taggable.save
@@ -111,20 +242,18 @@ describe "Taggable" do
     TaggableModel.all_tag_counts(:order => 'tags.id').first.count.should == 3 # ruby
   end
 
-  if ActiveRecord::VERSION::MAJOR >= 3
-    it "should not return read-only records" do
-      TaggableModel.create(:name => "Bob", :tag_list => "ruby, rails, css")
-      TaggableModel.tagged_with("ruby").first.should_not be_readonly
-    end
-  else
-    xit "should not return read-only records" do
-      # apparantly, there is no way to set readonly to false in a scope if joins are made
-    end
-    
-    it "should be possible to return writable records" do
-      TaggableModel.create(:name => "Bob", :tag_list => "ruby, rails, css")
-      TaggableModel.tagged_with("ruby").first(:readonly => false).should_not be_readonly      
-    end
+  it "should be able to use named scopes to chain tag finds by any tags by context" do
+    bob   = TaggableModel.create(:name => "Bob",   :need_list => "rails", :offering_list => "c++")
+    frank = TaggableModel.create(:name => "Frank", :need_list => "css",   :offering_list => "css")
+    steve = TaggableModel.create(:name => 'Steve', :need_list => "c++",   :offering_list => "java")
+
+    # Let's only find those who need rails or css and are offering c++ or java
+    TaggableModel.tagged_with(['rails, css'], :on => :needs, :any => true).tagged_with(['c++', 'java'], :on => :offerings, :any => true).to_a.should == [bob]
+  end
+
+  it "should not return read-only records" do
+    TaggableModel.create(:name => "Bob", :tag_list => "ruby, rails, css")
+    TaggableModel.tagged_with("ruby").first.should_not be_readonly
   end
 
   it "should be able to get scoped tag counts" do
@@ -148,10 +277,10 @@ describe "Taggable" do
     bob = TaggableModel.create(:name => "Bob", :tag_list => "ruby, rails, css")
     frank = TaggableModel.create(:name => "Frank", :tag_list => "ruby, rails")
     charlie = TaggableModel.create(:name => "Charlie", :skill_list => "ruby, java")
- 
+
     TaggableModel.tagged_with('rails').all_tag_counts.should have(3).items
     TaggableModel.tagged_with('rails').all_tag_counts.any? { |tag| tag.name == 'java' }.should be_false
-    
+
     # Test specific join syntaxes:
     frank.untaggable_models.create!
     TaggableModel.tagged_with('rails').scoped(:joins => :untaggable_models).all_tag_counts.should have(2).items
@@ -177,15 +306,15 @@ describe "Taggable" do
     TaggableModel.tagged_with("ruby, rails", :order => 'taggable_models.name').to_a.should == [bob, frank]
     TaggableModel.tagged_with(["ruby", "rails"], :order => 'taggable_models.name').to_a.should == [bob, frank]
   end
-  
+
   it "should be able to find tagged with quotation marks" do
     bob = TaggableModel.create(:name => "Bob", :tag_list => "fitter, happier, more productive, 'I love the ,comma,'")
     TaggableModel.tagged_with("'I love the ,comma,'").should include(bob)
   end
-  
+
   it "should be able to find tagged with invalid tags" do
-    bob = TaggableModel.create(:name => "Bob", :tag_list => "fitter, happier, more productive")    
-    TaggableModel.tagged_with("sad, happier").should_not include(bob)    
+    bob = TaggableModel.create(:name => "Bob", :tag_list => "fitter, happier, more productive")
+    TaggableModel.tagged_with("sad, happier").should_not include(bob)
   end
 
   it "should be able to find tagged with any tag" do
@@ -198,6 +327,19 @@ describe "Taggable" do
     TaggableModel.tagged_with(["depressed", "css"], :order => 'taggable_models.name', :any => true).to_a.should == [bob, frank]
   end
 
+  context "wild: true" do
+    it "should use params as wildcards" do
+      bob = TaggableModel.create(:name => "Bob", :tag_list => "bob, tricia")
+      frank = TaggableModel.create(:name => "Frank", :tag_list => "bobby, jim")
+      steve = TaggableModel.create(:name => "Steve", :tag_list => "john, patricia")
+      jim = TaggableModel.create(:name => "Jim", :tag_list => "jim, steve")
+
+
+      TaggableModel.tagged_with(["bob", "tricia"], :wild => true, :any => true).to_a.sort_by{|o| o.id}.should == [bob, frank, steve]
+      TaggableModel.tagged_with(["bob", "tricia"], :wild => true, :exclude => true).to_a.should == [jim]
+    end
+  end
+
   it "should be able to find tagged on a custom tag context" do
     bob = TaggableModel.create(:name => "Bob")
     bob.set_tag_list_on(:rotors, "spinning, jumping")
@@ -235,6 +377,13 @@ describe "Taggable" do
     TaggableModel.tagged_with("lazy", :exclude => true).to_a.should == [frank, steve]
   end
 
+  it "should return an empty scope for empty tags" do
+    TaggableModel.tagged_with('').should == []
+    TaggableModel.tagged_with(' ').should == []
+    TaggableModel.tagged_with(nil).should == []
+    TaggableModel.tagged_with([]).should == []
+  end
+
   it "should not create duplicate taggings" do
     bob = TaggableModel.create(:name => "Bob")
     lambda {
@@ -243,12 +392,12 @@ describe "Taggable" do
       bob.save
     }.should change(ActsAsTaggableOn::Tagging, :count).by(1)
   end
- 
+
   describe "Associations" do
     before(:each) do
       @taggable = TaggableModel.create(:tag_list => "awesome, epic")
     end
-    
+
     it "should not remove tags when creating associated objects" do
       @taggable.untaggable_models.create!
       @taggable.reload
@@ -264,6 +413,10 @@ describe "Taggable" do
     it "should return all column names joined for TaggableModel GROUP clause" do
       @taggable.grouped_column_names_for(TaggableModel).should == "taggable_models.id, taggable_models.name, taggable_models.type"
     end
+
+    it "should return all column names joined for NonStandardIdTaggableModel GROUP clause" do
+      @taggable.grouped_column_names_for(TaggableModel).should == "taggable_models.#{TaggableModel.primary_key}, taggable_models.name, taggable_models.type"
+    end
   end
 
   describe "Single Table Inheritance" do
@@ -272,45 +425,119 @@ describe "Taggable" do
       @inherited_same = InheritingTaggableModel.new(:name => "inherited same")
       @inherited_different = AlteredInheritingTaggableModel.new(:name => "inherited different")
     end
-  
+
     it "should be able to save tags for inherited models" do
       @inherited_same.tag_list = "bob, kelso"
       @inherited_same.save
       InheritingTaggableModel.tagged_with("bob").first.should == @inherited_same
     end
-  
+
     it "should find STI tagged models on the superclass" do
       @inherited_same.tag_list = "bob, kelso"
       @inherited_same.save
       TaggableModel.tagged_with("bob").first.should == @inherited_same
     end
-  
+
     it "should be able to add on contexts only to some subclasses" do
       @inherited_different.part_list = "fork, spoon"
       @inherited_different.save
       InheritingTaggableModel.tagged_with("fork", :on => :parts).should be_empty
       AlteredInheritingTaggableModel.tagged_with("fork", :on => :parts).first.should == @inherited_different
     end
-  
+
     it "should have different tag_counts_on for inherited models" do
       @inherited_same.tag_list = "bob, kelso"
       @inherited_same.save!
       @inherited_different.tag_list = "fork, spoon"
       @inherited_different.save!
-  
+
       InheritingTaggableModel.tag_counts_on(:tags, :order => 'tags.id').map(&:name).should == %w(bob kelso)
       AlteredInheritingTaggableModel.tag_counts_on(:tags, :order => 'tags.id').map(&:name).should == %w(fork spoon)
       TaggableModel.tag_counts_on(:tags, :order => 'tags.id').map(&:name).should == %w(bob kelso fork spoon)
     end
-  
+
     it 'should store same tag without validation conflict' do
       @taggable.tag_list = 'one'
       @taggable.save!
-  
+
       @inherited_same.tag_list = 'one'
       @inherited_same.save!
-  
+
       @inherited_same.update_attributes! :name => 'foo'
     end
   end
+
+  describe "NonStandardIdTaggable" do
+    before(:each) do
+      clean_database!
+      @taggable = NonStandardIdTaggableModel.new(:name => "Bob Jones")
+      @taggables = [@taggable, NonStandardIdTaggableModel.new(:name => "John Doe")]
+    end
+
+    it "should have tag types" do
+      [:tags, :languages, :skills, :needs, :offerings].each do |type|
+        NonStandardIdTaggableModel.tag_types.should include type
+      end
+
+      @taggable.tag_types.should == NonStandardIdTaggableModel.tag_types
+    end
+
+    it "should have tag_counts_on" do
+      NonStandardIdTaggableModel.tag_counts_on(:tags).all.should be_empty
+
+      @taggable.tag_list = ["awesome", "epic"]
+      @taggable.save
+
+      NonStandardIdTaggableModel.tag_counts_on(:tags).length.should == 2
+      @taggable.tag_counts_on(:tags).length.should == 2
+    end
+
+    it "should be able to create tags" do
+      @taggable.skill_list = "ruby, rails, css"
+      @taggable.instance_variable_get("@skill_list").instance_of?(ActsAsTaggableOn::TagList).should be_true
+
+      lambda {
+        @taggable.save
+      }.should change(ActsAsTaggableOn::Tag, :count).by(3)
+
+      @taggable.reload
+      @taggable.skill_list.sort.should == %w(ruby rails css).sort
+    end
+
+    it "should be able to create tags through the tag list directly" do
+      @taggable.tag_list_on(:test).add("hello")
+      @taggable.tag_list_cache_on(:test).should_not be_empty
+      @taggable.tag_list_on(:test).should == ["hello"]
+
+      @taggable.save
+      @taggable.save_tags
+
+      @taggable.reload
+      @taggable.tag_list_on(:test).should == ["hello"]
+    end
+  end
+
+  describe "Dirty Objects" do
+    before(:each) do
+      @taggable = TaggableModel.create(:tag_list => "awesome, epic")
+    end
+
+    it 'should show changes of dirty object' do
+      @taggable.changes.should == {}
+      @taggable.tag_list = 'one'
+      @taggable.changes.should == {"tag_list"=>["awesome, epic", ["one"]]}
+
+      @taggable.tag_list_changed?.should be_true
+      @taggable.tag_list_was.should == "awesome, epic"
+      @taggable.tag_list_change.should == ["awesome, epic", ["one"]]
+    end
+
+    it 'should show no changes if the same tag_list' do
+      @taggable.tag_list = "awesome, epic"
+      @taggable.tag_list_changed?.should be_false
+      @taggable.changes.should == {}
+    end
+  end
 end
+
+

data/spec/acts_as_taggable_on/tagger_spec.rb

@@ -16,7 +16,21 @@ describe "Tagger" do
     @user.tag(@taggable, :with=>'ruby,scheme', :on=>:tags)
     @user.owned_tags.size == 2
   end
-  
+
+  it "should scope objects returned by tagged_with by owners" do
+    @taggable2 = TaggableModel.create(:name => "Jim Jones")
+    @taggable3 = TaggableModel.create(:name => "Jane Doe")
+
+    @user2 = TaggableUser.new
+    @user.tag(@taggable, :with => 'ruby, scheme', :on => :tags)
+    @user2.tag(@taggable2, :with => 'ruby, scheme', :on => :tags)
+    @user2.tag(@taggable3, :with => 'ruby, scheme', :on => :tags)
+
+    TaggableModel.tagged_with(%w(ruby scheme), :owned_by => @user).count.should == 1
+    TaggableModel.tagged_with(%w(ruby scheme), :owned_by => @user2).count.should == 2
+
+  end
+
   it "should not overlap tags from different taggers" do
     @user2 = TaggableUser.new
     lambda{
@@ -28,35 +42,35 @@ describe "Tagger" do
 
     @user.owned_tags.map(&:name).sort.should == %w(ruby scheme).sort
     @user2.owned_tags.map(&:name).sort.should == %w(java python lisp ruby).sort
-    
+
     @taggable.tags_from(@user).sort.should == %w(ruby scheme).sort
     @taggable.tags_from(@user2).sort.should == %w(java lisp python ruby).sort
-    
+
     @taggable.all_tags_list.sort.should == %w(ruby scheme java python lisp).sort
     @taggable.all_tags_on(:tags).size.should == 5
   end
-  
+
   it "should not lose tags from different taggers" do
     @user2 = TaggableUser.create
     @user2.tag(@taggable, :with => 'java, python, lisp, ruby', :on => :tags)
-    @user.tag(@taggable, :with => 'ruby, scheme', :on => :tags)  
-    
+    @user.tag(@taggable, :with => 'ruby, scheme', :on => :tags)
+
     lambda {
       @user2.tag(@taggable, :with => 'java, python, lisp', :on => :tags)
     }.should change(ActsAsTaggableOn::Tagging, :count).by(-1)
 
     [@user, @user2, @taggable].each(&:reload)
-    
+
     @taggable.tags_from(@user).sort.should == %w(ruby scheme).sort
     @taggable.tags_from(@user2).sort.should == %w(java python lisp).sort
-    
+
     @taggable.all_tags_list.sort.should == %w(ruby scheme java python lisp).sort
     @taggable.all_tags_on(:tags).length.should == 5
   end
 
   it "should not lose tags" do
     @user2 = TaggableUser.create
-    
+
     @user.tag(@taggable, :with => 'awesome', :on => :tags)
     @user2.tag(@taggable, :with => 'awesome, epic', :on => :tags)
 
@@ -64,28 +78,35 @@ describe "Tagger" do
       @user2.tag(@taggable, :with => 'epic', :on => :tags)
     }.should change(ActsAsTaggableOn::Tagging, :count).by(-1)
 
-    @taggable.reload  
+    @taggable.reload
     @taggable.all_tags_list.should include('awesome')
     @taggable.all_tags_list.should include('epic')
   end
-  
+
   it "should not lose tags" do
     @taggable.update_attributes(:tag_list => 'ruby')
     @user.tag(@taggable, :with => 'ruby, scheme', :on => :tags)
-    
+
     [@taggable, @user].each(&:reload)
     @taggable.tag_list.should == %w(ruby)
     @taggable.all_tags_list.sort.should == %w(ruby scheme).sort
-    
+
     lambda {
       @taggable.update_attributes(:tag_list => "")
     }.should change(ActsAsTaggableOn::Tagging, :count).by(-1)
-    
+
     @taggable.tag_list.should == []
     @taggable.all_tags_list.sort.should == %w(ruby scheme).sort
   end
 
   it "is tagger" do
     @user.is_tagger?.should(be_true)
-  end  
+  end
+
+  it "should skip save if skip_save is passed as option" do
+    lambda {
+      @user.tag(@taggable, :with => 'epic', :on => :tags, :skip_save => true)
+    }.should_not change(ActsAsTaggableOn::Tagging, :count)
+
+  end
 end

data/spec/acts_as_taggable_on/tagging_spec.rb

@@ -13,11 +13,7 @@ describe ActsAsTaggableOn::Tagging do
 
     @tagging.should_not be_valid
     
-    if ActiveRecord::VERSION::MAJOR >= 3
-      @tagging.errors[:tag_id].should == ["can't be blank"]
-    else
-      @tagging.errors[:tag_id].should == "can't be blank"
-    end
+    @tagging.errors[:tag_id].should == ["can't be blank"]
   end
 
   it "should not create duplicate taggings" do
@@ -28,4 +24,5 @@ describe ActsAsTaggableOn::Tagging do
       2.times { ActsAsTaggableOn::Tagging.create(:taggable => @taggable, :tag => @tag, :context => 'tags') }
     }.should change(ActsAsTaggableOn::Tagging, :count).by(1)
   end
+  
 end

data/spec/acts_as_taggable_on/tags_helper_spec.rb

@@ -25,4 +25,20 @@ describe ActsAsTaggableOn::TagsHelper do
     tags["c++"].should == "sucky"
     tags["php"].should == "sucky"
   end
+  
+  it "should handle tags with zero counts (build for empty)" do
+    bob = ActsAsTaggableOn::Tag.create(:name => "php")
+    tom = ActsAsTaggableOn::Tag.create(:name => "java")
+    eve = ActsAsTaggableOn::Tag.create(:name => "c++")
+    
+    tags = { }
+    
+    @helper.tag_cloud(ActsAsTaggableOn::Tag.all, ["sucky", "awesome"]) do |tag, css_class|
+      tags[tag.name] = css_class
+    end
+    
+    tags["java"].should == "sucky"
+    tags["c++"].should == "sucky"
+    tags["php"].should == "sucky"
+  end
 end