acts-as-taggable-on 2.0.0.pre5 → 3.5.0

data/spec/acts_as_taggable_on/acts_as_tagger_spec.rb

@@ -1,114 +1,112 @@
-require File.dirname(__FILE__) + '/../spec_helper'
+# -*- encoding : utf-8 -*-
+require 'spec_helper'
 
-describe "acts_as_tagger" do
-  before(:each) do
-    clean_database!
-  end
-  
-  context "Tagger Method Generation" do
+describe 'acts_as_tagger' do
+
+  describe 'Tagger Method Generation' do
     before(:each) do
-      @tagger = TaggableUser.new()
+      @tagger = User.new
     end
 
-    it "should add #is_tagger? query method to the class-side" do
-      TaggableUser.should respond_to(:is_tagger?)
+    it 'should add #is_tagger? query method to the class-side' do
+      expect(User).to respond_to(:is_tagger?)
     end
-    
-    it "should return true from the class-side #is_tagger?" do
-      TaggableUser.is_tagger?.should be_true
+
+    it 'should return true from the class-side #is_tagger?' do
+      expect(User.is_tagger?).to be_truthy
     end
-    
-    it "should return false from the base #is_tagger?" do
-      ActiveRecord::Base.is_tagger?.should be_false
+
+    it 'should return false from the base #is_tagger?' do
+      expect(ActiveRecord::Base.is_tagger?).to be_falsy
     end
-    
-    it "should add #is_tagger? query method to the singleton" do
-      @tagger.should respond_to(:is_tagger?)
+
+    it 'should add #is_tagger? query method to the singleton' do
+      expect(@tagger).to respond_to(:is_tagger?)
     end
-    
-    it "should add #tag method on the instance-side" do
-      @tagger.should respond_to(:tag)
+
+    it 'should add #tag method on the instance-side' do
+      expect(@tagger).to respond_to(:tag)
     end
-    
-    it "should generate an association for #owned_taggings and #owned_tags" do
-      @tagger.should respond_to(:owned_taggings, :owned_tags)
+
+    it 'should generate an association for #owned_taggings and #owned_tags' do
+      expect(@tagger).to respond_to(:owned_taggings, :owned_tags)
     end
   end
-  
-  describe "#tag" do
+
+  describe '#tag' do
     context 'when called with a non-existent tag context' do
       before(:each) do
-        @tagger = TaggableUser.new()
-        @taggable = TaggableModel.new(:name=>"Richard Prior")
+        @tagger = User.new
+        @taggable = TaggableModel.new(name: 'Richard Prior')
       end
-      
-      it "should by default not throw an exception " do
-        @taggable.tag_list_on(:foo).should be_empty
-        lambda {
-          @tagger.tag(@taggable, :with=>'this, and, that', :on=>:foo)
-        }.should_not raise_error
+
+      it 'should by default not throw an exception ' do
+        expect(@taggable.tag_list_on(:foo)).to be_empty
+        expect(-> {
+          @tagger.tag(@taggable, with: 'this, and, that', on: :foo)
+        }).to_not raise_error
       end
-      
+
       it 'should by default create the tag context on-the-fly' do
-        @taggable.tag_list_on(:here_ond_now).should be_empty
-        @tagger.tag(@taggable, :with=>'that', :on => :here_ond_now)
-        @taggable.tag_list_on(:here_ond_now).should_not include('that')
-        @taggable.all_tags_list_on(:here_ond_now).should include('that')
+        expect(@taggable.tag_list_on(:here_ond_now)).to be_empty
+        @tagger.tag(@taggable, with: 'that', on: :here_ond_now)
+        expect(@taggable.tag_list_on(:here_ond_now)).to_not include('that')
+        expect(@taggable.all_tags_list_on(:here_ond_now)).to include('that')
       end
-      
-      it "should show all the tag list when both public and owned tags exist" do
+
+      it 'should show all the tag list when both public and owned tags exist' do
         @taggable.tag_list = 'ruby, python'
-        @tagger.tag(@taggable, :with => 'java, lisp', :on => :tags)
-        @taggable.all_tags_on(:tags).map(&:name).sort.should == %w(ruby python java lisp).sort
+        @tagger.tag(@taggable, with: 'java, lisp', on: :tags)
+        expect(@taggable.all_tags_on(:tags).map(&:name).sort).to eq(%w(ruby python java lisp).sort)
       end
-      
-      it "should not add owned tags to the common list" do
+
+      it 'should not add owned tags to the common list' do
         @taggable.tag_list = 'ruby, python'
-        @tagger.tag(@taggable, :with => 'java, lisp', :on => :tags)
-        @taggable.tag_list.should == %w(ruby python)
-        @tagger.tag(@taggable, :with => '', :on => :tags)
-        @taggable.tag_list.should == %w(ruby python)
+        @tagger.tag(@taggable, with: 'java, lisp', on: :tags)
+        expect(@taggable.tag_list).to eq(%w(ruby python))
+        @tagger.tag(@taggable, with: '', on: :tags)
+        expect(@taggable.tag_list).to eq(%w(ruby python))
       end
-      
-      it "should throw an exception when the default is over-ridden" do
-        @taggable.tag_list_on(:foo_boo).should be_empty
-        lambda {
-          @tagger.tag(@taggable, :with=>'this, and, that', :on=>:foo_boo, :force=>false)
-        }.should raise_error        
+
+      it 'should throw an exception when the default is over-ridden' do
+        expect(@taggable.tag_list_on(:foo_boo)).to be_empty
+        expect(-> {
+          @tagger.tag(@taggable, with: 'this, and, that', on: :foo_boo, force: false)
+        }).to raise_error
       end
 
-      it "should not create the tag context on-the-fly when the default is over-ridden" do
-        @taggable.tag_list_on(:foo_boo).should be_empty
-        @tagger.tag(@taggable, :with=>'this, and, that', :on=>:foo_boo, :force=>false) rescue
-        @taggable.tag_list_on(:foo_boo).should be_empty
+      it 'should not create the tag context on-the-fly when the default is over-ridden' do
+        expect(@taggable.tag_list_on(:foo_boo)).to be_empty
+        @tagger.tag(@taggable, with: 'this, and, that', on: :foo_boo, force: false) rescue
+            expect(@taggable.tag_list_on(:foo_boo)).to be_empty
       end
     end
-    
-    context "when called by multiple tagger's" do
+
+    describe "when called by multiple tagger's" do
       before(:each) do
-        @user_x = TaggableUser.create(:name => "User X")
-        @user_y = TaggableUser.create(:name => "User Y")
-        @taggable = TaggableModel.create(:name => 'acts_as_taggable_on', :tag_list => 'plugin')
-        
-        @user_x.tag(@taggable, :with => 'ruby, rails',  :on => :tags)
-        @user_y.tag(@taggable, :with => 'ruby, plugin', :on => :tags)
-
-        @user_y.tag(@taggable, :with => '', :on => :tags)
-        @user_y.tag(@taggable, :with => '', :on => :tags)
+        @user_x = User.create(name: 'User X')
+        @user_y = User.create(name: 'User Y')
+        @taggable = TaggableModel.create(name: 'acts_as_taggable_on', tag_list: 'plugin')
+
+        @user_x.tag(@taggable, with: 'ruby, rails', on: :tags)
+        @user_y.tag(@taggable, with: 'ruby, plugin', on: :tags)
+
+        @user_y.tag(@taggable, with: '', on: :tags)
+        @user_y.tag(@taggable, with: '', on: :tags)
       end
-      
-      it "should delete owned tags" do        
-        @user_y.owned_tags.should == []
+
+      it 'should delete owned tags' do
+        expect(@user_y.owned_tags).to be_empty
       end
-      
-      it "should not delete other taggers tags" do
-        @user_x.owned_tags.should have(2).items
+
+      it 'should not delete other taggers tags' do
+        expect(@user_x.owned_tags.count).to eq(2)
       end
-      
-      it "should not delete original tags" do
-        @taggable.all_tags_list_on(:tags).should include('plugin')
+
+      it 'should not delete original tags' do
+        expect(@taggable.all_tags_list_on(:tags)).to include('plugin')
       end
     end
   end
 
-end
+end

data/spec/acts_as_taggable_on/caching_spec.rb

@@ -0,0 +1,83 @@
+# -*- encoding : utf-8 -*-
+require 'spec_helper'
+
+describe 'Acts As Taggable On' do
+
+  describe 'Caching' do
+    before(:each) do
+      @taggable = CachedModel.new(name: 'Bob Jones')
+      @another_taggable = OtherCachedModel.new(name: 'John Smith')
+    end
+
+    it 'should add saving of tag lists and cached tag lists to the instance' do
+      expect(@taggable).to respond_to(:save_cached_tag_list)
+      expect(@another_taggable).to respond_to(:save_cached_tag_list)
+
+      expect(@taggable).to respond_to(:save_tags)
+    end
+
+    it 'should add cached tag lists to the instance if cached column is not present' do
+      expect(TaggableModel.new(name: 'Art Kram')).to_not respond_to(:save_cached_tag_list)
+    end
+
+    it 'should generate a cached column checker for each tag type' do
+      expect(CachedModel).to respond_to(:caching_tag_list?)
+      expect(OtherCachedModel).to respond_to(:caching_language_list?)
+    end
+
+    it 'should not have cached tags' do
+      expect(@taggable.cached_tag_list).to be_blank
+      expect(@another_taggable.cached_language_list).to be_blank
+    end
+
+    it 'should cache tags' do
+      @taggable.update_attributes(tag_list: 'awesome, epic')
+      expect(@taggable.cached_tag_list).to eq('awesome, epic')
+
+      @another_taggable.update_attributes(language_list: 'ruby, .net')
+      expect(@another_taggable.cached_language_list).to eq('ruby, .net')
+    end
+
+    it 'should keep the cache' do
+      @taggable.update_attributes(tag_list: 'awesome, epic')
+      @taggable = CachedModel.find(@taggable.id)
+      @taggable.save!
+      expect(@taggable.cached_tag_list).to eq('awesome, epic')
+    end
+
+    it 'should update the cache' do
+      @taggable.update_attributes(tag_list: 'awesome, epic')
+      @taggable.update_attributes(tag_list: 'awesome')
+      expect(@taggable.cached_tag_list).to eq('awesome')
+    end
+
+    it 'should remove the cache' do
+      @taggable.update_attributes(tag_list: 'awesome, epic')
+      @taggable.update_attributes(tag_list: '')
+      expect(@taggable.cached_tag_list).to be_blank
+    end
+
+    it 'should have a tag list' do
+      @taggable.update_attributes(tag_list: 'awesome, epic')
+      @taggable = CachedModel.find(@taggable.id)
+      expect(@taggable.tag_list.sort).to eq(%w(awesome epic).sort)
+    end
+
+    it 'should keep the tag list' do
+      @taggable.update_attributes(tag_list: 'awesome, epic')
+      @taggable = CachedModel.find(@taggable.id)
+      @taggable.save!
+      expect(@taggable.tag_list.sort).to eq(%w(awesome epic).sort)
+    end
+
+    it 'should clear the cache on reset_column_information' do
+      CachedModel.column_names
+      CachedModel.reset_column_information
+      expect(CachedModel.instance_variable_get(:@acts_as_taggable_on_cache_columns)).to eql(nil)
+    end
+  end
+
+  describe 'CachingWithArray' do
+    pending '#TODO'
+  end
+end

data/spec/acts_as_taggable_on/default_parser_spec.rb

@@ -0,0 +1,47 @@
+# -*- encoding : utf-8 -*-
+require 'spec_helper'
+
+describe ActsAsTaggableOn::DefaultParser do
+  it '#parse should return empty array if empty array is passed' do
+    parser = ActsAsTaggableOn::DefaultParser.new([])
+    expect(parser.parse).to be_empty
+  end
+
+  describe 'Multiple Delimiter' do
+    before do
+      @old_delimiter = ActsAsTaggableOn.delimiter
+    end
+
+    after do
+      ActsAsTaggableOn.delimiter = @old_delimiter
+    end
+
+    it 'should separate tags by delimiters' do
+      ActsAsTaggableOn.delimiter = [',', ' ', '\|']
+      parser = ActsAsTaggableOn::DefaultParser.new('cool, data|I have')
+      expect(parser.parse.to_s).to eq('cool, data, I, have')
+    end
+
+    it 'should escape quote' do
+      ActsAsTaggableOn.delimiter = [',', ' ', '\|']
+      parser = ActsAsTaggableOn::DefaultParser.new("'I have'|cool, data")
+      expect(parser.parse.to_s).to eq('"I have", cool, data')
+
+      parser = ActsAsTaggableOn::DefaultParser.new('"I, have"|cool, data')
+      expect(parser.parse.to_s).to eq('"I, have", cool, data')
+    end
+
+    it 'should work for utf8 delimiter and long delimiter' do
+      ActsAsTaggableOn.delimiter = ['，', '的', '可能是']
+      parser = ActsAsTaggableOn::DefaultParser.new('我的东西可能是不见了，还好有备份')
+      expect(parser.parse.to_s).to eq('我， 东西， 不见了， 还好有备份')
+    end
+
+    it 'should work for multiple quoted tags' do
+      ActsAsTaggableOn.delimiter = [',']
+      parser = ActsAsTaggableOn::DefaultParser.new('"Ruby Monsters","eat Katzenzungen"')
+      expect(parser.parse.to_s).to eq('Ruby Monsters, eat Katzenzungen')
+    end
+  end
+
+end

data/spec/acts_as_taggable_on/generic_parser_spec.rb

@@ -0,0 +1,14 @@
+# -*- encoding : utf-8 -*-
+require 'spec_helper'
+
+describe ActsAsTaggableOn::GenericParser do
+  it '#parse should return empty array if empty tag string is passed' do
+    tag_list = ActsAsTaggableOn::GenericParser.new('')
+    expect(tag_list.parse).to be_empty
+  end
+
+  it '#parse should separate tags by comma' do
+    tag_list = ActsAsTaggableOn::GenericParser.new('cool,data,,I,have')
+    expect(tag_list.parse).to eq(%w(cool data I have))
+  end
+end

data/spec/acts_as_taggable_on/related_spec.rb

@@ -0,0 +1,99 @@
+# -*- encoding : utf-8 -*-
+require 'spec_helper'
+
+describe 'Acts As Taggable On' do
+
+  describe 'Related Objects' do
+
+    #TODO, shared example
+    it 'should find related objects based on tag names on context' do
+      taggable1 = TaggableModel.create!(name: 'Taggable 1',tag_list: 'one, two')
+      taggable2 = TaggableModel.create!(name: 'Taggable 2',tag_list: 'three, four')
+      taggable3 = TaggableModel.create!(name: 'Taggable 3',tag_list: 'one, four')
+
+      expect(taggable1.find_related_tags).to include(taggable3)
+      expect(taggable1.find_related_tags).to_not include(taggable2)
+    end
+
+    it 'finds related tags for ordered taggable on' do
+      taggable1 = OrderedTaggableModel.create!(name: 'Taggable 1',colour_list: 'one, two')
+      taggable2 = OrderedTaggableModel.create!(name: 'Taggable 2',colour_list: 'three, four')
+      taggable3 = OrderedTaggableModel.create!(name: 'Taggable 3',colour_list: 'one, four')
+
+      expect(taggable1.find_related_colours).to include(taggable3)
+      expect(taggable1.find_related_colours).to_not include(taggable2)
+    end
+
+    it 'should find related objects based on tag names on context - non standard id' do
+      taggable1 = NonStandardIdTaggableModel.create!(name: 'Taggable 1',tag_list: 'one, two')
+      taggable2 = NonStandardIdTaggableModel.create!(name: 'Taggable 2',tag_list: 'three, four')
+      taggable3 = NonStandardIdTaggableModel.create!(name: 'Taggable 3',tag_list: 'one, four')
+
+      expect(taggable1.find_related_tags).to include(taggable3)
+      expect(taggable1.find_related_tags).to_not include(taggable2)
+    end
+
+    it 'should find other related objects based on tag names on context' do
+      taggable1 = TaggableModel.create!(name: 'Taggable 1',tag_list: 'one, two')
+      taggable2 = OtherTaggableModel.create!(name: 'Taggable 2',tag_list: 'three, four')
+      taggable3 = OtherTaggableModel.create!(name: 'Taggable 3',tag_list: 'one, four')
+
+      expect(taggable1.find_related_tags_for(OtherTaggableModel)).to include(taggable3)
+      expect(taggable1.find_related_tags_for(OtherTaggableModel)).to_not include(taggable2)
+    end
+
+    it 'should find other related objects based on tags only from particular context' do
+      taggable1 = TaggableModel.create!(name: 'Taggable 1',tag_list: 'one, two')
+      taggable2 = TaggableModel.create!(name: 'Taggable 2',tag_list: 'three, four', skill_list: 'one, two')
+      taggable3 = TaggableModel.create!(name: 'Taggable 3',tag_list: 'one, four')
+
+      expect(taggable1.find_related_tags).to include(taggable3)
+      expect(taggable1.find_related_tags).to_not include(taggable2)
+    end
+
+
+    shared_examples "a collection" do
+      it do
+        taggable1 = described_class.create!(name: 'Taggable 1', tag_list: 'one')
+        taggable2 = described_class.create!(name: 'Taggable 2', tag_list: 'one, two')
+
+        expect(taggable1.find_related_tags).to include(taggable2)
+        expect(taggable1.find_related_tags).to_not include(taggable1)
+      end
+    end
+
+    # it 'should not include the object itself in the list of related objects' do
+    describe TaggableModel do
+      it_behaves_like "a collection"
+    end
+
+    # it 'should not include the object itself in the list of related objects - non standard id' do
+    describe NonStandardIdTaggableModel do
+      it_behaves_like "a collection"
+    end
+
+    context 'Ignored Tags' do
+      let(:taggable1) { TaggableModel.create!(name: 'Taggable 1', tag_list: 'one, two, four') }
+      let(:taggable2) { TaggableModel.create!(name: 'Taggable 2', tag_list: 'two, three') }
+      let(:taggable3) { TaggableModel.create!(name: 'Taggable 3', tag_list: 'one, three') }
+
+      it 'should not include ignored tags in related search' do
+        expect(taggable1.find_related_tags(ignore: 'two')).to_not include(taggable2)
+        expect(taggable1.find_related_tags(ignore: 'two')).to include(taggable3)
+      end
+
+      it 'should accept array of ignored tags' do
+        taggable4 = TaggableModel.create!(name: 'Taggable 4', tag_list: 'four')
+
+
+        expect(taggable1.find_related_tags(ignore: ['two', 'four'])).to_not include(taggable2)
+        expect(taggable1.find_related_tags(ignore: ['two', 'four'])).to_not include(taggable4)
+      end
+
+      it 'should accept symbols as ignored tags' do
+        expect(taggable1.find_related_tags(ignore: :two)).to_not include(taggable2)
+      end
+    end
+
+  end
+end

data/spec/acts_as_taggable_on/single_table_inheritance_spec.rb

@@ -0,0 +1,211 @@
+# -*- encoding : utf-8 -*-
+require 'spec_helper'
+
+describe 'Single Table Inheritance' do
+  let(:taggable) { TaggableModel.new(name: 'taggable model') }
+
+  let(:inheriting_model) { InheritingTaggableModel.new(name: 'Inheriting Taggable Model') }
+  let(:altered_inheriting) { AlteredInheritingTaggableModel.new(name: 'Altered Inheriting Model') }
+
+  1.upto(4) do |n|
+    let(:"inheriting_#{n}") { InheritingTaggableModel.new(name: "Inheriting Model #{n}") }
+  end
+
+  let(:student) { Student.create! }
+
+  describe 'tag contexts' do
+    it 'should pass on to STI-inherited models' do
+      expect(inheriting_model).to respond_to(:tag_list, :skill_list, :language_list)
+      expect(altered_inheriting).to respond_to(:tag_list, :skill_list, :language_list)
+    end
+
+    it 'should pass on to altered STI models' do
+      expect(altered_inheriting).to respond_to(:part_list)
+    end
+  end
+
+  context 'matching contexts' do
+
+    before do
+      inheriting_1.offering_list = 'one, two'
+      inheriting_1.need_list = 'one, two'
+      inheriting_1.save!
+
+      inheriting_2.need_list = 'one, two'
+      inheriting_2.save!
+
+      inheriting_3.offering_list = 'one, two'
+      inheriting_3.save!
+
+      inheriting_4.tag_list = 'one, two, three, four'
+      inheriting_4.save!
+
+      taggable.need_list = 'one, two'
+      taggable.save!
+    end
+
+    it 'should find objects with tags of matching contexts' do
+      expect(inheriting_1.find_matching_contexts(:offerings, :needs)).to include(inheriting_2)
+      expect(inheriting_1.find_matching_contexts(:offerings, :needs)).to_not include(inheriting_3)
+      expect(inheriting_1.find_matching_contexts(:offerings, :needs)).to_not include(inheriting_4)
+      expect(inheriting_1.find_matching_contexts(:offerings, :needs)).to_not include(taggable)
+
+      expect(inheriting_1.find_matching_contexts_for(TaggableModel, :offerings, :needs)).to include(inheriting_2)
+      expect(inheriting_1.find_matching_contexts_for(TaggableModel, :offerings, :needs)).to_not include(inheriting_3)
+      expect(inheriting_1.find_matching_contexts_for(TaggableModel, :offerings, :needs)).to_not include(inheriting_4)
+      expect(inheriting_1.find_matching_contexts_for(TaggableModel, :offerings, :needs)).to include(taggable)
+    end
+
+    it 'should not include the object itself in the list of related objects with tags of matching contexts' do
+      expect(inheriting_1.find_matching_contexts(:offerings, :needs)).to_not include(inheriting_1)
+      expect(inheriting_1.find_matching_contexts_for(InheritingTaggableModel, :offerings, :needs)).to_not include(inheriting_1)
+      expect(inheriting_1.find_matching_contexts_for(TaggableModel, :offerings, :needs)).to_not include(inheriting_1)
+    end
+  end
+
+  context 'find related tags' do
+    before do
+      inheriting_1.tag_list = 'one, two'
+      inheriting_1.save
+
+      inheriting_2.tag_list = 'three, four'
+      inheriting_2.save
+
+      inheriting_3.tag_list = 'one, four'
+      inheriting_3.save
+
+      taggable.tag_list = 'one, two, three, four'
+      taggable.save
+    end
+
+    it 'should find related objects based on tag names on context' do
+      expect(inheriting_1.find_related_tags).to include(inheriting_3)
+      expect(inheriting_1.find_related_tags).to_not include(inheriting_2)
+      expect(inheriting_1.find_related_tags).to_not include(taggable)
+
+      expect(inheriting_1.find_related_tags_for(TaggableModel)).to include(inheriting_3)
+      expect(inheriting_1.find_related_tags_for(TaggableModel)).to_not include(inheriting_2)
+      expect(inheriting_1.find_related_tags_for(TaggableModel)).to include(taggable)
+    end
+
+    it 'should not include the object itself in the list of related objects' do
+      expect(inheriting_1.find_related_tags).to_not include(inheriting_1)
+      expect(inheriting_1.find_related_tags_for(InheritingTaggableModel)).to_not include(inheriting_1)
+      expect(inheriting_1.find_related_tags_for(TaggableModel)).to_not include(inheriting_1)
+    end
+  end
+
+  describe 'tag list' do
+    before do
+      @inherited_same = InheritingTaggableModel.new(name: 'inherited same')
+      @inherited_different = AlteredInheritingTaggableModel.new(name: 'inherited different')
+    end
+
+    #TODO, shared example
+    it 'should be able to save tags for inherited models' do
+      inheriting_model.tag_list = 'bob, kelso'
+      inheriting_model.save
+      expect(InheritingTaggableModel.tagged_with('bob').first).to eq(inheriting_model)
+    end
+
+    it 'should find STI tagged models on the superclass' do
+      inheriting_model.tag_list = 'bob, kelso'
+      inheriting_model.save
+      expect(TaggableModel.tagged_with('bob').first).to eq(inheriting_model)
+    end
+
+    it 'should be able to add on contexts only to some subclasses' do
+      altered_inheriting.part_list = 'fork, spoon'
+      altered_inheriting.save
+      expect(InheritingTaggableModel.tagged_with('fork', on: :parts)).to be_empty
+      expect(AlteredInheritingTaggableModel.tagged_with('fork', on: :parts).first).to eq(altered_inheriting)
+    end
+
+    it 'should have different tag_counts_on for inherited models' do
+      inheriting_model.tag_list = 'bob, kelso'
+      inheriting_model.save!
+      altered_inheriting.tag_list = 'fork, spoon'
+      altered_inheriting.save!
+
+      expect(InheritingTaggableModel.tag_counts_on(:tags, order: 'tags.id').map(&:name)).to eq(%w(bob kelso))
+      expect(AlteredInheritingTaggableModel.tag_counts_on(:tags, order: 'tags.id').map(&:name)).to eq(%w(fork spoon))
+      expect(TaggableModel.tag_counts_on(:tags, order: 'tags.id').map(&:name)).to eq(%w(bob kelso fork spoon))
+    end
+
+    it 'should have different tags_on for inherited models' do
+      inheriting_model.tag_list = 'bob, kelso'
+      inheriting_model.save!
+      altered_inheriting.tag_list = 'fork, spoon'
+      altered_inheriting.save!
+
+      expect(InheritingTaggableModel.tags_on(:tags, order: 'tags.id').map(&:name)).to eq(%w(bob kelso))
+      expect(AlteredInheritingTaggableModel.tags_on(:tags, order: 'tags.id').map(&:name)).to eq(%w(fork spoon))
+      expect(TaggableModel.tags_on(:tags, order: 'tags.id').map(&:name)).to eq(%w(bob kelso fork spoon))
+    end
+
+    it 'should store same tag without validation conflict' do
+      taggable.tag_list = 'one'
+      taggable.save!
+
+      inheriting_model.tag_list = 'one'
+      inheriting_model.save!
+
+      inheriting_model.update_attributes! name: 'foo'
+    end
+  end
+
+  describe 'ownership' do
+    it 'should have taggings' do
+      student.tag(taggable, with: 'ruby,scheme', on: :tags)
+      expect(student.owned_taggings.count).to eq(2)
+    end
+
+    it 'should have tags' do
+      student.tag(taggable, with: 'ruby,scheme', on: :tags)
+      expect(student.owned_tags.count).to eq(2)
+    end
+
+    it 'should return tags for the inheriting tagger' do
+      student.tag(taggable, with: 'ruby, scheme', on: :tags)
+      expect(taggable.tags_from(student)).to eq(%w(ruby scheme))
+    end
+
+    it 'returns owner tags on the tagger' do
+      student.tag(taggable, with: 'ruby, scheme', on: :tags)
+      expect(taggable.owner_tags_on(student, :tags).count).to eq(2)
+    end
+
+    it 'should scope objects returned by tagged_with by owners' do
+      student.tag(taggable, with: 'ruby, scheme', on: :tags)
+      expect(TaggableModel.tagged_with(%w(ruby scheme), owned_by: student).count).to eq(1)
+    end
+  end
+
+  describe 'a subclass of Tag' do
+    let(:company) { Company.new(:name => 'Dewey, Cheatham & Howe') }
+    let(:user) { User.create! }
+
+    subject { Market.create! :name => 'finance' }
+
+    its(:type) { should eql 'Market' }
+
+    it 'sets STI type through string list' do
+      company.market_list = 'law, accounting'
+      company.save!
+      expect(Market.count).to eq(2)
+    end
+
+    it 'does not interfere with a normal Tag context on the same model' do
+      company.location_list = 'cambridge'
+      company.save!
+      expect(ActsAsTaggableOn::Tag.where(name: 'cambridge', type: nil)).to_not be_empty
+    end
+
+    it 'is returned with proper type through ownership' do
+      user.tag(company, :with => 'ripoffs, rackets', :on => :markets)
+      tags = company.owner_tags_on(user, :markets)
+      expect(tags.all? { |tag| tag.is_a? Market }).to be_truthy
+    end
+  end
+end
+