acts-as-taggable-on 12.0.0 → 13.0.0

data/gemfiles/activerecord_8.0.gemfile

@@ -1,19 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "activerecord", "~> 8.0.0.beta1"
-gem "railties", "~> 8.0.0.beta1"
-gem "pg"
-gem "sqlite3", "~> 2.1"
-gem "mysql2", "~> 0.5"
-
-group :local_development do
-  gem "guard"
-  gem "guard-rspec"
-  gem "appraisal"
-  gem "rake"
-  gem "byebug", platforms: [:mri]
-end
-
-gemspec path: "../"

data/spec/acts_as_taggable_on/acts_as_taggable_on_spec.rb

@@ -1,272 +0,0 @@
-# -*- encoding : utf-8 -*-
-require 'spec_helper'
-
-describe 'Acts As Taggable On' do
-
-  it "should provide a class method 'taggable?' that is false for untaggable models" do
-    expect(UntaggableModel).to_not be_taggable
-  end
-
-  describe 'Taggable Method Generation To Preserve Order' do
-    before(:each) do
-      TaggableModel.tag_types = []
-      TaggableModel.preserve_tag_order = false
-      TaggableModel.acts_as_ordered_taggable_on(:ordered_tags)
-      @taggable = TaggableModel.new(name: 'Bob Jones')
-    end
-
-    it "should respond 'true' to preserve_tag_order?" do
-      expect(@taggable.class.preserve_tag_order?).to be_truthy
-    end
-  end
-
-  describe 'Taggable Method Generation' do
-    before(:each) do
-      TaggableModel.tag_types = []
-      TaggableModel.acts_as_taggable_on(:tags, :languages, :skills, :needs, :offerings)
-      @taggable = TaggableModel.new(name: 'Bob Jones')
-    end
-
-    it "should respond 'true' to taggable?" do
-      expect(@taggable.class).to be_taggable
-    end
-
-    it 'should create a class attribute for tag types' do
-      expect(@taggable.class).to respond_to(:tag_types)
-    end
-
-    it 'should create an instance attribute for tag types' do
-      expect(@taggable).to respond_to(:tag_types)
-    end
-
-    it 'should have all tag types' do
-      expect(@taggable.tag_types).to eq([:tags, :languages, :skills, :needs, :offerings])
-    end
-
-    it 'should create a class attribute for preserve tag order' do
-      expect(@taggable.class).to respond_to(:preserve_tag_order?)
-    end
-
-    it 'should create an instance attribute for preserve tag order' do
-      expect(@taggable).to respond_to(:preserve_tag_order?)
-    end
-
-    it "should respond 'false' to preserve_tag_order?" do
-      expect(@taggable.class.preserve_tag_order?).to be_falsy
-    end
-
-    it 'should generate an association for each tag type' do
-      expect(@taggable).to respond_to(:tags, :skills, :languages)
-    end
-
-    it 'should add tagged_with and tag_counts to singleton' do
-      expect(TaggableModel).to respond_to(:tagged_with, :tag_counts)
-    end
-
-    it 'should generate a tag_list accessor/setter for each tag type' do
-      expect(@taggable).to respond_to(:tag_list, :skill_list, :language_list)
-      expect(@taggable).to respond_to(:tag_list=, :skill_list=, :language_list=)
-    end
-
-    it 'should generate a tag_list accessor, that includes owned tags, for each tag type' do
-      expect(@taggable).to respond_to(:all_tags_list, :all_skills_list, :all_languages_list)
-    end
-  end
-
-  describe 'Matching Contexts' do
-    it 'should find objects with tags of matching contexts' do
-      taggable1 = TaggableModel.create!(name: 'Taggable 1')
-      taggable2 = TaggableModel.create!(name: 'Taggable 2')
-      taggable3 = TaggableModel.create!(name: 'Taggable 3')
-
-      taggable1.offering_list = 'one, two'
-      taggable1.save!
-
-      taggable2.need_list = 'one, two'
-      taggable2.save!
-
-      taggable3.offering_list = 'one, two'
-      taggable3.save!
-
-      expect(taggable1.find_matching_contexts(:offerings, :needs)).to include(taggable2)
-      expect(taggable1.find_matching_contexts(:offerings, :needs)).to_not include(taggable3)
-    end
-
-    it 'should find other related objects with tags of matching contexts' do
-      taggable1 = TaggableModel.create!(name: 'Taggable 1')
-      taggable2 = OtherTaggableModel.create!(name: 'Taggable 2')
-      taggable3 = OtherTaggableModel.create!(name: 'Taggable 3')
-
-      taggable1.offering_list = 'one, two'
-      taggable1.save
-
-      taggable2.need_list = 'one, two'
-      taggable2.save
-
-      taggable3.offering_list = 'one, two'
-      taggable3.save
-
-      expect(taggable1.find_matching_contexts_for(OtherTaggableModel, :offerings, :needs)).to include(taggable2)
-      expect(taggable1.find_matching_contexts_for(OtherTaggableModel, :offerings, :needs)).to_not include(taggable3)
-    end
-
-    it 'should not include the object itself in the list of related objects with tags of matching contexts' do
-      taggable1 = TaggableModel.create!(name: 'Taggable 1')
-      taggable2 = TaggableModel.create!(name: 'Taggable 2')
-
-      taggable1.offering_list = 'one, two'
-      taggable1.need_list = 'one, two'
-      taggable1.save
-
-      taggable2.need_list = 'one, two'
-      taggable2.save
-
-      expect(taggable1.find_matching_contexts_for(TaggableModel, :offerings, :needs)).to include(taggable2)
-      expect(taggable1.find_matching_contexts_for(TaggableModel, :offerings, :needs)).to_not include(taggable1)
-    end
-
-    it 'should ensure joins to multiple taggings maintain their contexts when aliasing' do
-      taggable1 = TaggableModel.create!(name: 'Taggable 1')
-
-      taggable1.offering_list = 'one'
-      taggable1.need_list = 'two'
-
-      taggable1.save
-
-      column = TaggableModel.connection.quote_column_name("context")
-      offer_alias = TaggableModel.connection.quote_table_name(ActsAsTaggableOn.taggings_table)
-      need_alias = TaggableModel.connection.quote_table_name("need_taggings_taggable_models_join")
-
-      expect(TaggableModel.joins(:offerings, :needs).to_sql).to include "#{offer_alias}.#{column}"
-      expect(TaggableModel.joins(:offerings, :needs).to_sql).to include "#{need_alias}.#{column}"
-    end
-
-  end
-
-  describe 'Tagging Contexts' do
-    it 'should eliminate duplicate tagging contexts ' do
-      TaggableModel.acts_as_taggable_on(:skills, :skills)
-      expect(TaggableModel.tag_types.freq[:skills]).to eq(1)
-    end
-
-    it 'should not contain embedded/nested arrays' do
-      TaggableModel.acts_as_taggable_on([:array], [:array])
-      expect(TaggableModel.tag_types.freq[[:array]]).to eq(0)
-    end
-
-    it 'should _flatten_ the content of arrays' do
-      TaggableModel.acts_as_taggable_on([:array], [:array])
-      expect(TaggableModel.tag_types.freq[:array]).to eq(1)
-    end
-
-    it 'should not raise an error when passed nil' do
-      expect(-> {
-        TaggableModel.acts_as_taggable_on
-      }).to_not raise_error
-    end
-
-    it 'should not raise an error when passed [nil]' do
-      expect(-> {
-        TaggableModel.acts_as_taggable_on([nil])
-      }).to_not raise_error
-    end
-
-    it 'should include dynamic contexts in tagging_contexts' do
-      taggable = TaggableModel.create!(name: 'Dynamic Taggable')
-      taggable.set_tag_list_on :colors, 'tag1, tag2, tag3'
-      expect(taggable.tagging_contexts).to eq(%w(tags languages skills needs offerings array colors))
-      taggable.save
-      taggable = TaggableModel.where(name: 'Dynamic Taggable').first
-      expect(taggable.tagging_contexts).to eq(%w(tags languages skills needs offerings array colors))
-    end
-  end
-
-  context 'when tagging context ends in an "s" when singular (ex. "status", "glass", etc.)' do
-    describe 'caching' do
-      before  { @taggable = OtherCachedModel.new(name: 'John Smith') }
-      subject { @taggable }
-
-      it { should respond_to(:save_cached_tag_list) }
-      its(:cached_language_list) { should be_blank }
-      its(:cached_status_list)   { should be_blank }
-      its(:cached_glass_list)    { should be_blank }
-
-      context 'language taggings cache after update' do
-        before  { @taggable.update(language_list: 'ruby, .net') }
-        subject { @taggable }
-
-        its(:language_list)        { should == ['ruby', '.net']}
-        its(:cached_language_list) { should == 'ruby, .net' }           # passes
-        its(:instance_variables)   { should     include(:@language_list) }
-      end
-
-      context 'status taggings cache after update' do
-        before  { @taggable.update(status_list: 'happy, married') }
-        subject { @taggable }
-
-        its(:status_list)        { should     == ['happy', 'married'] }
-        its(:cached_status_list) { should     == 'happy, married'     } # fails
-        its(:cached_status_list) { should_not == ''                   } # fails, is blank
-        its(:instance_variables) { should     include(:@status_list) }
-        its(:instance_variables) { should_not include(:@statu_list)  } # fails, note: one "s"
-
-      end
-
-      context 'glass taggings cache after update' do
-        before do
-          @taggable.update(glass_list: 'rectangle, aviator')
-        end
-
-        subject { @taggable }
-        its(:glass_list)         { should     == ['rectangle', 'aviator'] }
-        its(:cached_glass_list)  { should     == 'rectangle, aviator'     } # fails
-        its(:cached_glass_list)  { should_not == ''                       } # fails, is blank
-        its(:instance_variables) { should     include(:@glass_list)      }
-        its(:instance_variables) { should_not include(:@glas_list)       } # fails, note: one "s"
-
-      end
-    end
-  end
-
-  describe 'taggings' do
-    before(:each) do
-      @taggable = TaggableModel.new(name: 'Art Kram')
-    end
-
-    it 'should return no taggings' do
-      expect(@taggable.taggings).to be_empty
-    end
-  end
-
-  describe '@@remove_unused_tags' do
-    before do
-      @taggable = TaggableModel.create(name: 'Bob Jones')
-      @tag = ActsAsTaggableOn::Tag.create(name: 'awesome')
-
-      @tagging = ActsAsTaggableOn::Tagging.create(taggable: @taggable, tag: @tag, context: 'tags')
-    end
-
-    context 'if set to true' do
-      before do
-        ActsAsTaggableOn.remove_unused_tags = true
-      end
-
-      it 'should remove unused tags after removing taggings' do
-        @tagging.destroy
-        expect(ActsAsTaggableOn::Tag.find_by_name('awesome')).to be_nil
-      end
-    end
-
-    context 'if set to false' do
-      before do
-        ActsAsTaggableOn.remove_unused_tags = false
-      end
-
-      it 'should not remove unused tags after removing taggings' do
-        @tagging.destroy
-        expect(ActsAsTaggableOn::Tag.find_by_name('awesome')).to eq(@tag)
-      end
-    end
-  end
-
-end

data/spec/acts_as_taggable_on/acts_as_tagger_spec.rb

@@ -1,112 +0,0 @@
-# -*- encoding : utf-8 -*-
-require 'spec_helper'
-
-describe 'acts_as_tagger' do
-
-  describe 'Tagger Method Generation' do
-    before(:each) do
-      @tagger = User.new
-    end
-
-    it 'should add #is_tagger? query method to the class-side' do
-      expect(User).to respond_to(:is_tagger?)
-    end
-
-    it 'should return true from the class-side #is_tagger?' do
-      expect(User.is_tagger?).to be_truthy
-    end
-
-    it 'should return false from the base #is_tagger?' do
-      expect(ActiveRecord::Base.is_tagger?).to be_falsy
-    end
-
-    it 'should add #is_tagger? query method to the singleton' do
-      expect(@tagger).to respond_to(:is_tagger?)
-    end
-
-    it 'should add #tag method on the instance-side' do
-      expect(@tagger).to respond_to(:tag)
-    end
-
-    it 'should generate an association for #owned_taggings and #owned_tags' do
-      expect(@tagger).to respond_to(:owned_taggings, :owned_tags)
-    end
-  end
-
-  describe '#tag' do
-    context 'when called with a non-existent tag context' do
-      before(:each) do
-        @tagger = User.new
-        @taggable = TaggableModel.new(name: 'Richard Prior')
-      end
-
-      it 'should by default not throw an exception ' do
-        expect(@taggable.tag_list_on(:foo)).to be_empty
-        expect(-> {
-          @tagger.tag(@taggable, with: 'this, and, that', on: :foo)
-        }).to_not raise_error
-      end
-
-      it 'should by default create the tag context on-the-fly' do
-        expect(@taggable.tag_list_on(:here_ond_now)).to be_empty
-        @tagger.tag(@taggable, with: 'that', on: :here_ond_now)
-        expect(@taggable.tag_list_on(:here_ond_now)).to_not include('that')
-        expect(@taggable.all_tags_list_on(:here_ond_now)).to include('that')
-      end
-
-      it 'should show all the tag list when both public and owned tags exist' do
-        @taggable.tag_list = 'ruby, python'
-        @tagger.tag(@taggable, with: 'java, lisp', on: :tags)
-        expect(@taggable.all_tags_on(:tags).map(&:name).sort).to eq(%w(ruby python java lisp).sort)
-      end
-
-      it 'should not add owned tags to the common list' do
-        @taggable.tag_list = 'ruby, python'
-        @tagger.tag(@taggable, with: 'java, lisp', on: :tags)
-        expect(@taggable.tag_list).to eq(%w(ruby python))
-        @tagger.tag(@taggable, with: '', on: :tags)
-        expect(@taggable.tag_list).to eq(%w(ruby python))
-      end
-
-      it 'should throw an exception when the default is over-ridden' do
-        expect(@taggable.tag_list_on(:foo_boo)).to be_empty
-        expect {
-          @tagger.tag(@taggable, with: 'this, and, that', on: :foo_boo, force: false)
-        }.to raise_error(RuntimeError)
-      end
-
-      it 'should not create the tag context on-the-fly when the default is over-ridden' do
-        expect(@taggable.tag_list_on(:foo_boo)).to be_empty
-        @tagger.tag(@taggable, with: 'this, and, that', on: :foo_boo, force: false) rescue
-            expect(@taggable.tag_list_on(:foo_boo)).to be_empty
-      end
-    end
-
-    describe "when called by multiple tagger's" do
-      before(:each) do
-        @user_x = User.create(name: 'User X')
-        @user_y = User.create(name: 'User Y')
-        @taggable = TaggableModel.create(name: 'acts_as_taggable_on', tag_list: 'plugin')
-
-        @user_x.tag(@taggable, with: 'ruby, rails', on: :tags)
-        @user_y.tag(@taggable, with: 'ruby, plugin', on: :tags)
-
-        @user_y.tag(@taggable, with: '', on: :tags)
-        @user_y.tag(@taggable, with: '', on: :tags)
-      end
-
-      it 'should delete owned tags' do
-        expect(@user_y.owned_tags).to be_empty
-      end
-
-      it 'should not delete other taggers tags' do
-        expect(@user_x.owned_tags.count).to eq(2)
-      end
-
-      it 'should not delete original tags' do
-        expect(@taggable.all_tags_list_on(:tags)).to include('plugin')
-      end
-    end
-  end
-
-end

data/spec/acts_as_taggable_on/caching_spec.rb

@@ -1,125 +0,0 @@
-# -*- encoding : utf-8 -*-
-require 'spec_helper'
-
-describe 'Acts As Taggable On' do
-
-  describe 'Caching' do
-    before(:each) do
-      @taggable = CachedModel.new(name: 'Bob Jones')
-      @another_taggable = OtherCachedModel.new(name: 'John Smith')
-    end
-
-    it 'should add saving of tag lists and cached tag lists to the instance' do
-      expect(@taggable).to respond_to(:save_cached_tag_list)
-      expect(@another_taggable).to respond_to(:save_cached_tag_list)
-
-      expect(@taggable).to respond_to(:save_tags)
-    end
-
-    it 'should generate a cached column checker for each tag type' do
-      expect(CachedModel).to respond_to(:caching_tag_list?)
-      expect(OtherCachedModel).to respond_to(:caching_language_list?)
-    end
-
-    it 'should not have cached tags' do
-      expect(@taggable.cached_tag_list).to be_blank
-      expect(@another_taggable.cached_language_list).to be_blank
-    end
-
-    it 'should cache tags' do
-      @taggable.update(tag_list: 'awesome, epic')
-      expect(@taggable.cached_tag_list).to eq('awesome, epic')
-
-      @another_taggable.update(language_list: 'ruby, .net')
-      expect(@another_taggable.cached_language_list).to eq('ruby, .net')
-    end
-
-    it 'should keep the cache' do
-      @taggable.update(tag_list: 'awesome, epic')
-      @taggable = CachedModel.find(@taggable.id)
-      @taggable.save!
-      expect(@taggable.cached_tag_list).to eq('awesome, epic')
-    end
-
-    it 'should update the cache' do
-      @taggable.update(tag_list: 'awesome, epic')
-      @taggable.update(tag_list: 'awesome')
-      expect(@taggable.cached_tag_list).to eq('awesome')
-    end
-
-    it 'should remove the cache' do
-      @taggable.update(tag_list: 'awesome, epic')
-      @taggable.update(tag_list: '')
-      expect(@taggable.cached_tag_list).to be_blank
-    end
-
-    it 'should have a tag list' do
-      @taggable.update(tag_list: 'awesome, epic')
-      @taggable = CachedModel.find(@taggable.id)
-      expect(@taggable.tag_list.sort).to eq(%w(awesome epic).sort)
-    end
-
-    it 'should keep the tag list' do
-      @taggable.update(tag_list: 'awesome, epic')
-      @taggable = CachedModel.find(@taggable.id)
-      @taggable.save!
-      expect(@taggable.tag_list.sort).to eq(%w(awesome epic).sort)
-    end
-
-    it 'should clear the cache on reset_column_information' do
-      CachedModel.column_names
-      CachedModel.reset_column_information
-      expect(CachedModel.instance_variable_get(:@acts_as_taggable_on_cache_columns)).to eql(nil)
-    end
-
-    it 'should not override a user-defined columns method' do
-      expect(ColumnsOverrideModel.columns.map(&:name)).not_to include('ignored_column')
-      ColumnsOverrideModel.acts_as_taggable
-      expect(ColumnsOverrideModel.columns.map(&:name)).not_to include('ignored_column')
-    end
-  end
-
-  describe 'with a custom delimiter' do
-    before(:each) do
-      @taggable = CachedModel.new(name: 'Bob Jones')
-      @another_taggable = OtherCachedModel.new(name: 'John Smith')
-      ActsAsTaggableOn.delimiter = ';'
-    end
-
-    after(:all) do
-      ActsAsTaggableOn.delimiter = ','
-    end
-
-    it 'should cache tags with custom delimiter' do
-      @taggable.update(tag_list: 'awesome; epic')
-      expect(@taggable.tag_list).to eq(['awesome', 'epic'])
-      expect(@taggable.cached_tag_list).to eq('awesome; epic')
-
-      @taggable = CachedModel.find_by_name('Bob Jones')
-      expect(@taggable.tag_list).to eq(['awesome', 'epic'])
-      expect(@taggable.cached_tag_list).to eq('awesome; epic')
-    end
-  end
-
-  describe 'Cache methods initialization on new models' do
-    before(:all) do
-      ActiveRecord::Base.connection.execute(
-        'INSERT INTO cache_methods_injected_models (cached_tag_list) VALUES (\'ciao\')'
-      )
-      class CacheMethodsInjectedModel < ActiveRecord::Base
-        acts_as_taggable
-      end
-    end
-    after(:all) { Object.send(:remove_const, :CacheMethodsInjectedModel) }
-
-    it 'cached_tag_list_on? get injected correctly' do
-      expect do
-        CacheMethodsInjectedModel.first.tag_list
-      end.not_to raise_error
-    end
-  end
-
-  describe 'CachingWithArray' do
-    pending '#TODO'
-  end
-end

data/spec/acts_as_taggable_on/default_parser_spec.rb

@@ -1,47 +0,0 @@
-# -*- encoding : utf-8 -*-
-require 'spec_helper'
-
-describe ActsAsTaggableOn::DefaultParser do
-  it '#parse should return empty array if empty array is passed' do
-    parser = ActsAsTaggableOn::DefaultParser.new([])
-    expect(parser.parse).to be_empty
-  end
-
-  describe 'Multiple Delimiter' do
-    before do
-      @old_delimiter = ActsAsTaggableOn.delimiter
-    end
-
-    after do
-      ActsAsTaggableOn.delimiter = @old_delimiter
-    end
-
-    it 'should separate tags by delimiters' do
-      ActsAsTaggableOn.delimiter = [',', ' ', '\|']
-      parser = ActsAsTaggableOn::DefaultParser.new('cool, data|I have')
-      expect(parser.parse.to_s).to eq('cool, data, I, have')
-    end
-
-    it 'should escape quote' do
-      ActsAsTaggableOn.delimiter = [',', ' ', '\|']
-      parser = ActsAsTaggableOn::DefaultParser.new("'I have'|cool, data")
-      expect(parser.parse.to_s).to eq('"I have", cool, data')
-
-      parser = ActsAsTaggableOn::DefaultParser.new('"I, have"|cool, data')
-      expect(parser.parse.to_s).to eq('"I, have", cool, data')
-    end
-
-    it 'should work for utf8 delimiter and long delimiter' do
-      ActsAsTaggableOn.delimiter = ['，', '的', '可能是']
-      parser = ActsAsTaggableOn::DefaultParser.new('我的东西可能是不见了，还好有备份')
-      expect(parser.parse.to_s).to eq('我， 东西， 不见了， 还好有备份')
-    end
-
-    it 'should work for multiple quoted tags' do
-      ActsAsTaggableOn.delimiter = [',']
-      parser = ActsAsTaggableOn::DefaultParser.new('"Ruby Monsters","eat Katzenzungen"')
-      expect(parser.parse.to_s).to eq('Ruby Monsters, eat Katzenzungen')
-    end
-  end
-
-end