acts-as-taggable-on 1.0.13 → 2.0.6

data/spec/acts_as_taggable_on/acts_as_taggable_on_spec.rb

@@ -1,13 +1,19 @@
-require File.dirname(__FILE__) + '/../spec_helper'
+require File.expand_path('../../spec_helper', __FILE__)
 
 describe "Acts As Taggable On" do
+  before(:each) do
+    clean_database!
+  end
+
   it "should provide a class method 'taggable?' that is false for untaggable models" do
     UntaggableModel.should_not be_taggable
   end
 
   describe "Taggable Method Generation" do
     before(:each) do
-      [TaggableModel, Tag, Tagging, TaggableUser].each(&:delete_all)
+      clean_database!
+      TaggableModel.write_inheritable_attribute(:tag_types, [])
+      TaggableModel.acts_as_taggable_on(:tags, :languages, :skills, :needs, :offerings)
       @taggable = TaggableModel.new(:name => "Bob Jones")
     end
 
@@ -18,32 +24,31 @@ describe "Acts As Taggable On" do
     it "should create a class attribute for tag types" do
       @taggable.class.should respond_to(:tag_types)
     end
-    
+
     it "should create an instance attribute for tag types" do
       @taggable.should respond_to(:tag_types)
     end
+    
+    it "should have all tag types" do
+      @taggable.tag_types.should == [:tags, :languages, :skills, :needs, :offerings]
+    end
 
     it "should generate an association for each tag type" do
       @taggable.should respond_to(:tags, :skills, :languages)
     end
 
-    it "should generate a cached column checker for each tag type" do
-     TaggableModel.should respond_to(:caching_tag_list?, :caching_skill_list?, :caching_language_list?)
-    end
-
     it "should add tagged_with and tag_counts to singleton" do
-      TaggableModel.should respond_to(:find_tagged_with, :tag_counts)
-    end
-
-    it "should add saving of tag lists and cached tag lists to the instance" do
-      @taggable.should respond_to(:save_cached_tag_list)
-      @taggable.should respond_to(:save_tags)
+      TaggableModel.should respond_to(:tagged_with, :tag_counts)
     end
 
     it "should generate a tag_list accessor/setter for each tag type" do
       @taggable.should respond_to(:tag_list, :skill_list, :language_list)
       @taggable.should respond_to(:tag_list=, :skill_list=, :language_list=)
     end
+    
+    it "should generate a tag_list accessor, that includes owned tags, for each tag type" do
+      @taggable.should respond_to(:all_tags_list, :all_skills_list, :all_languages_list)
+    end
   end
 
   describe "Single Table Inheritance" do
@@ -52,17 +57,17 @@ describe "Acts As Taggable On" do
       @inherited_same = InheritingTaggableModel.new(:name => "inherited same")
       @inherited_different = AlteredInheritingTaggableModel.new(:name => "inherited different")
     end
-
+  
     it "should pass on tag contexts to STI-inherited models" do
       @inherited_same.should respond_to(:tag_list, :skill_list, :language_list)
       @inherited_different.should respond_to(:tag_list, :skill_list, :language_list)
     end
-
+  
     it "should have tag contexts added in altered STI models" do
       @inherited_different.should respond_to(:part_list)
     end
   end
-
+  
   describe "Reloading" do
     it "should save a model instantiated by Model.find" do
       taggable = TaggableModel.create!(:name => "Taggable")
@@ -76,48 +81,48 @@ describe "Acts As Taggable On" do
       taggable1 = TaggableModel.create!(:name => "Taggable 1")
       taggable2 = TaggableModel.create!(:name => "Taggable 2")
       taggable3 = TaggableModel.create!(:name => "Taggable 3")
-
+  
       taggable1.tag_list = "one, two"
       taggable1.save
-
+  
       taggable2.tag_list = "three, four"
       taggable2.save
-
+  
       taggable3.tag_list = "one, four"
       taggable3.save
-
+  
       taggable1.find_related_tags.should include(taggable3)
       taggable1.find_related_tags.should_not include(taggable2)
     end
-
+  
     it "should find other related objects based on tag names on context" do
       taggable1 = TaggableModel.create!(:name => "Taggable 1")
       taggable2 = OtherTaggableModel.create!(:name => "Taggable 2")
       taggable3 = OtherTaggableModel.create!(:name => "Taggable 3")
-
+  
       taggable1.tag_list = "one, two"
       taggable1.save
-
+  
       taggable2.tag_list = "three, four"
       taggable2.save
-
+  
       taggable3.tag_list = "one, four"
       taggable3.save
-
+  
       taggable1.find_related_tags_for(OtherTaggableModel).should include(taggable3)
       taggable1.find_related_tags_for(OtherTaggableModel).should_not include(taggable2)
     end
-
+  
     it "should not include the object itself in the list of related objects" do
       taggable1 = TaggableModel.create!(:name => "Taggable 1")
       taggable2 = TaggableModel.create!(:name => "Taggable 2")
-
+  
       taggable1.tag_list = "one"
       taggable1.save
-
+  
       taggable2.tag_list = "one, two"
       taggable2.save
-
+  
       taggable1.find_related_tags.should include(taggable2)
       taggable1.find_related_tags.should_not include(taggable1)
     end
@@ -128,64 +133,54 @@ describe "Acts As Taggable On" do
       taggable1 = TaggableModel.create!(:name => "Taggable 1")
       taggable2 = TaggableModel.create!(:name => "Taggable 2")
       taggable3 = TaggableModel.create!(:name => "Taggable 3")
-
+  
       taggable1.offering_list = "one, two"
       taggable1.save!
-
+  
       taggable2.need_list = "one, two"
       taggable2.save!
-
+  
       taggable3.offering_list = "one, two"
       taggable3.save!
-
+  
       taggable1.find_matching_contexts(:offerings, :needs).should include(taggable2)
       taggable1.find_matching_contexts(:offerings, :needs).should_not include(taggable3)
     end
-
+  
     it "should find other related objects with tags of matching contexts" do
       taggable1 = TaggableModel.create!(:name => "Taggable 1")
       taggable2 = OtherTaggableModel.create!(:name => "Taggable 2")
       taggable3 = OtherTaggableModel.create!(:name => "Taggable 3")
-
+  
       taggable1.offering_list = "one, two"
       taggable1.save
-
+  
       taggable2.need_list = "one, two"
       taggable2.save
-
+  
       taggable3.offering_list = "one, two"
       taggable3.save
-
+  
       taggable1.find_matching_contexts_for(OtherTaggableModel, :offerings, :needs).should include(taggable2)
       taggable1.find_matching_contexts_for(OtherTaggableModel, :offerings, :needs).should_not include(taggable3)
     end
-
+  
     it "should not include the object itself in the list of related objects" do
       taggable1 = TaggableModel.create!(:name => "Taggable 1")
       taggable2 = TaggableModel.create!(:name => "Taggable 2")
-
+  
       taggable1.tag_list = "one"
       taggable1.save
-
+  
       taggable2.tag_list = "one, two"
       taggable2.save
-
+  
       taggable1.find_related_tags.should include(taggable2)
       taggable1.find_related_tags.should_not include(taggable1)
     end
   end
 
   describe 'Tagging Contexts' do
-    before(:all) do
-      class Array
-        def freq
-          k=Hash.new(0)
-          self.each {|e| k[e]+=1}
-          k
-        end
-      end
-    end
-
     it 'should eliminate duplicate tagging contexts ' do
       TaggableModel.acts_as_taggable_on(:skills, :skills)
       TaggableModel.tag_types.freq[:skills].should_not == 3
@@ -212,10 +207,62 @@ describe "Acts As Taggable On" do
         TaggableModel.acts_as_taggable_on([nil])
       }.should_not raise_error
     end
+  end
+  
+  describe 'Caching' do
+    before(:each) do
+      @taggable = CachedModel.new(:name => "Bob Jones")  
+    end
+    
+    it "should add saving of tag lists and cached tag lists to the instance" do
+      @taggable.should respond_to(:save_cached_tag_list)
+      @taggable.should respond_to(:save_tags)
+    end  
 
-    after(:all) do
-      class Array; remove_method :freq; end
+    it "should generate a cached column checker for each tag type" do
+      CachedModel.should respond_to(:caching_tag_list?)
+    end  
+    
+    it 'should not have cached tags' do
+      @taggable.cached_tag_list.should be_blank  
+    end
+    
+    it 'should cache tags' do
+      @taggable.update_attributes(:tag_list => 'awesome, epic')
+      @taggable.cached_tag_list.should == 'awesome, epic'
+    end
+    
+    it 'should keep the cache' do
+      @taggable.update_attributes(:tag_list => 'awesome, epic')
+      @taggable = CachedModel.find(@taggable)  
+      @taggable.save!
+      @taggable.cached_tag_list.should == 'awesome, epic'   
+    end
+    
+    it 'should update the cache' do
+      @taggable.update_attributes(:tag_list => 'awesome, epic')
+      @taggable.update_attributes(:tag_list => 'awesome')
+      @taggable.cached_tag_list.should == 'awesome'      
+    end
+    
+    it 'should remove the cache' do
+      @taggable.update_attributes(:tag_list => 'awesome, epic')
+      @taggable.update_attributes(:tag_list => '')
+      @taggable.cached_tag_list.should be_blank  
+    end
+    
+    it 'should have a tag list' do
+      @taggable.update_attributes(:tag_list => 'awesome, epic')
+      @taggable = CachedModel.find(@taggable.id)
+      @taggable.tag_list.sort.should == %w(awesome epic).sort
+    end
+    
+    it 'should keep the tag list' do
+      @taggable.update_attributes(:tag_list => 'awesome, epic')
+      @taggable = CachedModel.find(@taggable.id)
+      @taggable.save!
+      @taggable.tag_list.sort.should == %w(awesome epic).sort
     end
   end
 
-end
+end

data/spec/acts_as_taggable_on/acts_as_tagger_spec.rb

@@ -1,8 +1,11 @@
-require File.dirname(__FILE__) + '/../spec_helper'
+require File.expand_path('../../spec_helper', __FILE__)
 
 describe "acts_as_tagger" do
-  context "Tagger Method Generation" do
-
+  before(:each) do
+    clean_database!
+  end
+  
+  describe "Tagger Method Generation" do
     before(:each) do
       @tagger = TaggableUser.new()
     end
@@ -48,8 +51,23 @@ describe "acts_as_tagger" do
       
       it 'should by default create the tag context on-the-fly' do
         @taggable.tag_list_on(:here_ond_now).should be_empty
-        @tagger.tag(@taggable, :with=>'that', :on=>:here_ond_now)
-        @taggable.tag_list_on(:here_ond_now).should include('that')
+        @tagger.tag(@taggable, :with=>'that', :on => :here_ond_now)
+        @taggable.tag_list_on(:here_ond_now).should_not include('that')
+        @taggable.all_tags_list_on(:here_ond_now).should include('that')
+      end
+      
+      it "should show all the tag list when both public and owned tags exist" do
+        @taggable.tag_list = 'ruby, python'
+        @tagger.tag(@taggable, :with => 'java, lisp', :on => :tags)
+        @taggable.all_tags_on(:tags).map(&:name).sort.should == %w(ruby python java lisp).sort
+      end
+      
+      it "should not add owned tags to the common list" do
+        @taggable.tag_list = 'ruby, python'
+        @tagger.tag(@taggable, :with => 'java, lisp', :on => :tags)
+        @taggable.tag_list.should == %w(ruby python)
+        @tagger.tag(@taggable, :with => '', :on => :tags)
+        @taggable.tag_list.should == %w(ruby python)
       end
       
       it "should throw an exception when the default is over-ridden" do
@@ -64,9 +82,33 @@ describe "acts_as_tagger" do
         @tagger.tag(@taggable, :with=>'this, and, that', :on=>:foo_boo, :force=>false) rescue
         @taggable.tag_list_on(:foo_boo).should be_empty
       end
+    end
+    
+    describe "when called by multiple tagger's" do
+      before(:each) do
+        @user_x = TaggableUser.create(:name => "User X")
+        @user_y = TaggableUser.create(:name => "User Y")
+        @taggable = TaggableModel.create(:name => 'acts_as_taggable_on', :tag_list => 'plugin')
+        
+        @user_x.tag(@taggable, :with => 'ruby, rails',  :on => :tags)
+        @user_y.tag(@taggable, :with => 'ruby, plugin', :on => :tags)
 
+        @user_y.tag(@taggable, :with => '', :on => :tags)
+        @user_y.tag(@taggable, :with => '', :on => :tags)
+      end
+      
+      it "should delete owned tags" do        
+        @user_y.owned_tags.should == []
+      end
+      
+      it "should not delete other taggers tags" do
+        @user_x.owned_tags.should have(2).items
+      end
+      
+      it "should not delete original tags" do
+        @taggable.all_tags_list_on(:tags).should include('plugin')
+      end
     end
-  
   end
 
 end

data/spec/acts_as_taggable_on/tag_list_spec.rb

@@ -1,8 +1,8 @@
-require File.dirname(__FILE__) + '/../spec_helper'
+require File.expand_path('../../spec_helper', __FILE__)
 
-describe TagList do
+describe ActsAsTaggableOn::TagList do
   before(:each) do
-    @tag_list = TagList.new("awesome","radical")
+    @tag_list = ActsAsTaggableOn::TagList.new("awesome","radical")
   end
   
   it "should be an array" do
@@ -20,6 +20,18 @@ describe TagList do
     @tag_list.include?("wicked").should be_true
   end
   
+  it "should be able to add delimited list of words with quoted delimiters" do
+    @tag_list.add("'cool, wicked', \"really cool, really wicked\"", :parse => true)
+    @tag_list.include?("cool, wicked").should be_true
+    @tag_list.include?("really cool, really wicked").should be_true
+  end
+  
+  it "should be able to handle other uses of quotation marks correctly" do
+    @tag_list.add("john's cool car, mary's wicked toy", :parse => true)
+    @tag_list.include?("john's cool car").should be_true
+    @tag_list.include?("mary's wicked toy").should be_true
+  end
+  
   it "should be able to add an array of words" do
     @tag_list.add(["cool", "wicked"], :parse => true)
     @tag_list.include?("cool").should be_true
@@ -49,4 +61,10 @@ describe TagList do
     @tag_list.add("cool","rad,bodacious")
     @tag_list.to_s.should == "awesome, radical, cool, \"rad,bodacious\""
   end
+  
+  it "should be able to call to_s on a frozen tag list" do
+    @tag_list.freeze
+    lambda { @tag_list.add("cool","rad,bodacious") }.should raise_error
+    lambda { @tag_list.to_s }.should_not raise_error
+  end
 end

data/spec/acts_as_taggable_on/tag_spec.rb

@@ -1,62 +1,115 @@
-require File.dirname(__FILE__) + '/../spec_helper'
+require File.expand_path('../../spec_helper', __FILE__)
 
-describe Tag do
+describe ActsAsTaggableOn::Tag do
   before(:each) do
-    @tag = Tag.new
-    @user = TaggableModel.create(:name => "Pablo")  
-    Tag.delete_all
+    clean_database!
+    @tag = ActsAsTaggableOn::Tag.new
+    @user = TaggableModel.create(:name => "Pablo")
   end
-  
+
+  describe "named like any" do
+    before(:each) do
+      ActsAsTaggableOn::Tag.create(:name => "awesome")
+      ActsAsTaggableOn::Tag.create(:name => "epic")
+    end
+
+    it "should find both tags" do
+      ActsAsTaggableOn::Tag.named_like_any(["awesome", "epic"]).should have(2).items
+    end
+  end
+
   describe "find or create by name" do
     before(:each) do
       @tag.name = "awesome"
       @tag.save
     end
-    
+
     it "should find by name" do
-      Tag.find_or_create_with_like_by_name("awesome").should == @tag
+      ActsAsTaggableOn::Tag.find_or_create_with_like_by_name("awesome").should == @tag
     end
-    
+
     it "should find by name case insensitive" do
-      Tag.find_or_create_with_like_by_name("AWESOME").should == @tag
+      ActsAsTaggableOn::Tag.find_or_create_with_like_by_name("AWESOME").should == @tag
     end
-    
+
     it "should create by name" do
       lambda {
-        Tag.find_or_create_with_like_by_name("epic")
-      }.should change(Tag, :count).by(1)
+        ActsAsTaggableOn::Tag.find_or_create_with_like_by_name("epic")
+      }.should change(ActsAsTaggableOn::Tag, :count).by(1)
+    end
+  end
+
+  describe "find or create all by any name" do
+    before(:each) do
+      @tag.name = "awesome"
+      @tag.save
+    end
+
+    it "should find by name" do
+      ActsAsTaggableOn::Tag.find_or_create_all_with_like_by_name("awesome").should == [@tag]
+    end
+
+    it "should find by name case insensitive" do
+      ActsAsTaggableOn::Tag.find_or_create_all_with_like_by_name("AWESOME").should == [@tag]
+    end
+
+    it "should create by name" do
+      lambda {
+        ActsAsTaggableOn::Tag.find_or_create_all_with_like_by_name("epic")
+      }.should change(ActsAsTaggableOn::Tag, :count).by(1)
+    end
+
+    it "should find or create by name" do
+      lambda {
+        ActsAsTaggableOn::Tag.find_or_create_all_with_like_by_name("awesome", "epic").map(&:name).should == ["awesome", "epic"]
+      }.should change(ActsAsTaggableOn::Tag, :count).by(1)
+    end
+
+    it "should return an empty array if no tags are specified" do
+      ActsAsTaggableOn::Tag.find_or_create_all_with_like_by_name([]).should == []
     end
   end
 
   it "should require a name" do
     @tag.valid?
-    @tag.errors.on(:name).should == "can't be blank"
+    
+    if ActiveRecord::VERSION::MAJOR >= 3
+      @tag.errors[:name].should == ["can't be blank"]
+    else
+      @tag.errors[:name].should == "can't be blank"
+    end
+
     @tag.name = "something"
     @tag.valid?
-    @tag.errors.on(:name).should be_nil
+    
+    if ActiveRecord::VERSION::MAJOR >= 3      
+      @tag.errors[:name].should == []
+    else
+      @tag.errors[:name].should be_nil
+    end
   end
-  
+
   it "should equal a tag with the same name" do
     @tag.name = "awesome"
-    new_tag = Tag.new(:name => "awesome")
+    new_tag = ActsAsTaggableOn::Tag.new(:name => "awesome")
     new_tag.should == @tag
   end
-  
+
   it "should return its name when to_s is called" do
     @tag.name = "cool"
     @tag.to_s.should == "cool"
   end
-  
+
   it "have named_scope named(something)" do
     @tag.name = "cool"
     @tag.save!
-    Tag.named('cool').should include(@tag)
+    ActsAsTaggableOn::Tag.named('cool').should include(@tag)
   end
-  
+
   it "have named_scope named_like(something)" do
     @tag.name = "cool"
     @tag.save!
-    @another_tag = Tag.create!(:name => "coolip")
-    Tag.named_like('cool').should include(@tag, @another_tag)
+    @another_tag = ActsAsTaggableOn::Tag.create!(:name => "coolip")
+    ActsAsTaggableOn::Tag.named_like('cool').should include(@tag, @another_tag)
   end
-end
+end