acts-as-taggable-array-on 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d7015d2509416188e45cc5c3cf1504167a311a96
-  data.tar.gz: 96d19346e51a44233258a2b150a9b3eeb80c6633
+  metadata.gz: 571322f949adda3190c96102b3f5c5884aab591a
+  data.tar.gz: 35675504cfeb7e6bba4bb2616da65403abe91904
 SHA512:
-  metadata.gz: c81cef96b1bb5a2c418760dcafd67f68161708cd73bfebdcc89eebdb512bc162e6500c56298e7c5f671d8cf2f2b8d696cfefe9263c7776271dcfcac49ff4fec8
-  data.tar.gz: 269914c72de99a97d53ec456b1071e8d43ebeb031c608b102919d77e33dd06757d6ffadee571949672dd700719a94ecb8e9898a434fcc8c5998fbcad24edd6d1
+  metadata.gz: cdf1581fb54a72305b93c52c09ce192bef5bb7b88dd6647a5e2be90e32a6c094a643c4475a5de44224c94ef894314f47bf25f34e35c8096f99d178fb1a811681
+  data.tar.gz: 1ad9dbef4a56e0aca0de2e39c9af3bd6b263fe9a079893dc700fba14c11fa247492f4b83d08e25f69d09d3e083c5dd16870d467e62077dc24d7d6335e0cf14fe

data/.gitignore

@@ -4,6 +4,7 @@
 .config
 .yardoc
 Gemfile.lock
+gemfiles/*.lock
 InstalledFiles
 _yardoc
 coverage

data/.travis.yml

@@ -2,15 +2,24 @@ language: ruby
 rvm:
   - 2.0.0
   - 2.1.1
-  - 2.1.2
+  - 2.2.2
+  - 2.3.0
 addons:
   postgresql: 9.3
 gemfile:
-  - gemfiles/rails_4.0.gemfile
-  - gemfiles/rails_4.1.gemfile
+  - gemfiles/rails_4.gemfile
+  - gemfiles/rails_5.gemfile
 before_script:
   - createuser -d acts-as-taggable-array-on -U postgres
   - createdb --username=acts-as-taggable-array-on acts-as-taggable-array-on_test
 script:
   - bundle
   - bundle exec rspec
+matrix:
+  exclude:
+    - rvm: 2.0.0
+      gemfile: gemfiles/rails_5.gemfile
+    - rvm: 2.1.1
+      gemfile: gemfiles/rails_5.gemfile
+    - rvm: 2.1.2
+      gemfile: gemfiles/rails_5.gemfile

data/README.md

@@ -155,6 +155,60 @@ To handle the result tags named 'tag', prepend scopes.
 User.where('tag like ?', 'aws%').all_tags { where name: ['ken', 'tom'] }
 ```
 
+## Benchmark
+Based on the [article](https://adamnengland.wordpress.com/2014/02/19/benchmarks-acts-as-taggable-on-vs-postgresql-arrays/), I built [simple benchmark app](https://github.com/tmiyamon/acts-as-taggable-benchmark/) to compare only the main features acts-as-taggable-array-on has.
+
+This result does NOT insist acts-as-taggable-array-on is better than acts-as-taggable-on since it provides much more features than this gem.
+In the case you need simple tag functionality, acts-as-taggable-array-on may be helpful to improve its performance.
+
+```bash
+% rake bench:write bench:find_by_id bench:find_by_tag
+Deleted all ActsAsTaggableOn::Tag
+Deleted all ActsAsTaggableOn::Tagging
+Deleted all TaggableUser
+Deleted all TaggableArrayUser
+Finsihed to clean
+
+
+###################################################################
+
+bench:write
+Rehearsal ---------------------------------------------------------
+Using Taggable          6.950000   0.420000   7.370000 (  9.223704)
+Using Postgres Arrays   0.710000   0.090000   0.800000 (  1.184734)
+------------------------------------------------ total: 8.170000sec
+
+                            user     system      total        real
+Using Taggable          5.800000   0.340000   6.140000 (  7.842051)
+Using Postgres Arrays   0.680000   0.090000   0.770000 (  1.117812)
+
+###################################################################
+
+bench:find_by_id
+Rehearsal ---------------------------------------------------------
+Using Taggable          1.490000   0.110000   1.600000 (  2.079776)
+Using Postgres Arrays   0.240000   0.030000   0.270000 (  0.419430)
+------------------------------------------------ total: 1.870000sec
+
+                            user     system      total        real
+Using Taggable          1.440000   0.100000   1.540000 (  2.023188)
+Using Postgres Arrays   0.250000   0.040000   0.290000 (  0.434233)
+
+###################################################################
+
+bench:find_by_tag
+Rehearsal ---------------------------------------------------------
+Using Taggable          0.600000   0.040000   0.640000 (  1.107227)
+Using Postgres Arrays   0.060000   0.000000   0.060000 (  0.060019)
+------------------------------------------------ total: 0.700000sec
+
+                            user     system      total        real
+Using Taggable          0.600000   0.040000   0.640000 (  1.100302)
+Using Postgres Arrays   0.030000   0.000000   0.030000 (  0.033001)
+rake bench:write bench:find_by_id bench:find_by_tag  20.29s user 1.52s system 77% cpu 28.322 total
+```
+
+
 ## Contributing
 
 1. Fork it ( http://github.com/tmiyamon/acts-as-taggable-array-on/fork )

data/acts-as-taggable-array-on.gemspec

@@ -18,8 +18,8 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_runtime_dependency 'activerecord',  ['>= 4', '< 5']
-  spec.add_runtime_dependency 'activesupport', ['>= 4', '< 5']
+  spec.add_runtime_dependency 'activerecord',  ['>= 4']
+  spec.add_runtime_dependency 'activesupport', ['>= 4']
 
   spec.add_development_dependency 'pg'
 
@@ -27,4 +27,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec-rails"
   spec.add_development_dependency "guard-rspec"
+  spec.add_development_dependency "listen",  "~> 3.0.0"
 end

data/gemfiles/rails_4.gemfile

@@ -0,0 +1,7 @@
+source 'https://rubygems.org'
+
+# Specify your gem's dependencies in acts-as-pgarray-taggable-on.gemspec
+gemspec path: '../'
+
+gem 'activerecord',  '>= 4', '< 5'
+gem 'activesupport', '>= 4', '< 5'

data/gemfiles/rails_5.gemfile

@@ -0,0 +1,7 @@
+source 'https://rubygems.org'
+
+# Specify your gem's dependencies in acts-as-pgarray-taggable-on.gemspec
+gemspec path: '../'
+
+gem 'activerecord',  '~> 5.0.0'
+gem 'activesupport', '~> 5.0.0'

data/lib/acts-as-taggable-array-on/taggable.rb

@@ -16,7 +16,7 @@ module ActsAsTaggableArrayOn
 
         self.class.class_eval do
           define_method :"all_#{tag_name}" do |options = {}, &block|
-            subquery_scope = unscoped.select("unnest(#{table_name}.#{tag_name}) as tag").uniq
+            subquery_scope = unscoped.select("unnest(#{table_name}.#{tag_name}) as tag").distinct
             subquery_scope = subquery_scope.instance_eval(&block) if block
 
             from(subquery_scope).pluck('tag')

data/lib/acts-as-taggable-array-on/version.rb

@@ -1,3 +1,3 @@
 module ActsAsTagPgarray
-  VERSION = "0.3.0"
+  VERSION = "0.4.0"
 end

data/spec/spec_helper.rb

@@ -16,7 +16,7 @@ class User < ActiveRecord::Base; end
 RSpec.configure do |config|
   config.before(:all) do
     ActiveRecord::Base.establish_connection(
-      adapter: "postgresql", 
+      adapter: "postgresql",
       encoding: 'unicode',
       database: "acts-as-taggable-array-on_test",
       username: "acts-as-taggable-array-on"
@@ -37,8 +37,8 @@ def create_database
   ActiveRecord::Schema.define(:version => 1) do
     create_table :users do |t|
       t.string :name
-      t.string :colors, array: true, defualt: '{}'
-      t.timestamps
+      t.string :colors, array: true, default: []
+      t.timestamps null: true
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: acts-as-taggable-array-on
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Takuya Miyamoto
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-27 00:00:00.000000000 Z
+date: 2017-05-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -17,9 +17,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '4'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -27,9 +24,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '4'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '5'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
@@ -37,9 +31,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '4'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -47,9 +38,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '4'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '5'
 - !ruby/object:Gem::Dependency
   name: pg
   requirement: !ruby/object:Gem::Requirement
@@ -120,6 +108,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: listen
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 3.0.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 3.0.0
 description: Simple tagging gem for Rails using postgres array.
 email:
 - miyamototakuya@gmail.com
@@ -135,6 +137,8 @@ files:
 - README.md
 - Rakefile
 - acts-as-taggable-array-on.gemspec
+- gemfiles/rails_4.gemfile
+- gemfiles/rails_5.gemfile
 - lib/acts-as-taggable-array-on.rb
 - lib/acts-as-taggable-array-on/parser.rb
 - lib/acts-as-taggable-array-on/taggable.rb
@@ -163,7 +167,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Simple tagging gem for Rails using postgres array.