acts-as-approvable 0.6.7 → 0.6.8.1

data/spec/acts_as_approvable/model/update_instance_methods_spec.rb

@@ -0,0 +1,111 @@
+require 'spec_helper'
+
+describe ActsAsApprovable::Model::UpdateInstanceMethods do
+  subject { UpdatesApprovable.create }
+
+  describe '#update_approvals' do
+    before(:each) do
+      subject.update_attributes(:title => 'review')
+      @approval1 = subject.approvals.last
+      @approval1.approve!
+
+      subject.update_attributes(:title => 'review2')
+      @approval2 = subject.approvals.last
+    end
+
+    it 'retreives all :update approvals' do
+      subject.update_approvals.should == [@approval1, @approval2]
+    end
+
+    context 'when requesting only pending records' do
+      it 'retreives pending :update approvals' do
+        subject.update_approvals(false).should == [@approval2]
+      end
+    end
+  end
+
+  describe '#pending_changes?' do
+    it 'returns false with no pending approvals' do
+      subject.should_not be_pending_changes
+    end
+
+    context 'with pending approvals' do
+      before(:each) do
+        subject.update_attributes(:title => 'review')
+      end
+
+      it 'returns true' do
+        subject.should be_pending_changes
+      end
+    end
+
+    context 'with approved and rejected approvals' do
+      before(:each) do
+        subject.update_attributes(:title => 'review')
+        subject.approvals.last.approve!
+
+        subject.update_attributes(:title => 'review')
+        subject.approvals.last.reject!
+      end
+
+      it 'returns false' do
+        subject.should_not be_pending_changes
+      end
+    end
+  end
+
+  describe '#changed_notably?' do
+    it 'returns true if #notably_changed returns values' do
+      subject.stub(:notably_changed => [1])
+      subject.should be_changed_notably
+    end
+
+    it 'returns false if #notably_changed does not return values' do
+      subject.stub(:notably_changed => [])
+      subject.should_not be_changed_notably
+    end
+  end
+
+  describe '#notably_changed' do
+    before(:each) do
+      subject.title = 'review'
+      subject.updated_at += 60
+    end
+
+    it 'includes fields that should be approved' do
+      subject.changed.should include('title')
+      subject.notably_changed.should include('title')
+    end
+
+    it 'does not include fields that should be ignored' do
+      subject.changed.should include('updated_at')
+      subject.notably_changed.should_not include('updated_at')
+    end
+
+    it 'gets a list of approvable fields from #approvable_fields' do
+      subject.should_receive(:approvable_fields).and_return([])
+      subject.notably_changed
+    end
+  end
+
+  describe '#approvable_fields' do
+    it 'proxies to the class level' do
+      subject.class.should_receive(:approvable_fields)
+      subject.approvable_fields
+    end
+  end
+
+  context 'when a record is updated' do
+    before(:each) do
+      subject.update_attribute(:body, 'updated')
+    end
+
+    it 'saves the updated values to the approval record' do
+      subject.update_approvals.last.object.should == {'body' => 'updated'}
+    end
+
+    it 'saves the original values to the approval record' do
+      subject.update_approvals.last.original.should == {'body' => nil}
+    end
+  end
+end

data/spec/acts_as_approvable/model_spec.rb

@@ -0,0 +1,90 @@
+require 'spec_helper'
+
+describe ActsAsApprovable::Model do
+  context 'when acts_as_approvable is not configured' do
+    subject { NotApprovable }
+
+    it { subject.new.should_not have_many(:approvals) }
+
+    it { should_not extend(ActsAsApprovable::Model::ClassMethods) }
+    it { should_not extend(ActsAsApprovable::Model::InstanceMethods) }
+    it { should_not extend(ActsAsApprovable::Model::CreateInstanceMethods) }
+    it { should_not extend(ActsAsApprovable::Model::UpdateInstanceMethods) }
+  end
+
+  context 'with default configuration options' do
+    subject { DefaultApprovable }
+
+    it { should be_approvable_on(:create) }
+    it { should be_approvable_on(:update) }
+    it { should be_approvals_enabled }
+    it { subject.new.should have_many(:approvals) }
+
+    it { should extend(ActsAsApprovable::Model::ClassMethods) }
+    it { should extend(ActsAsApprovable::Model::InstanceMethods) }
+    it { should extend(ActsAsApprovable::Model::CreateInstanceMethods) }
+    it { should extend(ActsAsApprovable::Model::UpdateInstanceMethods) }
+
+    it 'has no approvable_field' do
+      subject.approvable_field.should_not be
+    end
+
+    it 'ignores timestamps' do
+      subject.approvable_ignore.should include('created_at')
+      subject.approvable_ignore.should include('updated_at')
+    end
+
+    it 'ignores the primary key' do
+      subject.approvable_ignore.should include(subject.primary_key)
+    end
+  end
+
+  context 'with :create as the only event' do
+    context 'and no other options' do
+      subject { CreatesApprovable }
+
+      it { should be_approvable_on(:create) }
+      it { should_not be_approvable_on(:update) }
+
+      it { should extend(ActsAsApprovable::Model::ClassMethods) }
+      it { should extend(ActsAsApprovable::Model::InstanceMethods) }
+      it { should extend(ActsAsApprovable::Model::CreateInstanceMethods) }
+      it { should_not extend(ActsAsApprovable::Model::UpdateInstanceMethods) }
+    end
+
+    context 'and a :state_field' do
+      subject { CreatesWithStateApprovable }
+
+      it 'has an approvable_field' do
+        subject.approvable_field.should be
+      end
+
+      it 'ignores the approvable_field' do
+        subject.approvable_ignore.should include(subject.approvable_field.to_s)
+      end
+
+      it 'ignores timestamps' do
+        subject.approvable_ignore.should include('created_at')
+        subject.approvable_ignore.should include('updated_at')
+      end
+
+      it 'ignores the primary key' do
+        subject.approvable_ignore.should include(subject.primary_key)
+      end
+    end
+  end
+
+  context 'with :update as the only event' do
+    context 'and no other options' do
+      subject { UpdatesApprovable }
+
+      it { should be_approvable_on(:update) }
+      it { should_not be_approvable_on(:create) }
+
+      it { should extend(ActsAsApprovable::Model::ClassMethods) }
+      it { should extend(ActsAsApprovable::Model::InstanceMethods) }
+      it { should extend(ActsAsApprovable::Model::UpdateInstanceMethods) }
+      it { should_not extend(ActsAsApprovable::Model::CreateInstanceMethods) }
+    end
+  end
+end

data/spec/acts_as_approvable/ownership/class_methods_spec.rb

@@ -0,0 +1,101 @@
+require 'spec_helper'
+
+describe ActsAsApprovable::Ownership::ClassMethods do
+  before(:all) do
+    ActsAsApprovable::Ownership.configure
+  end
+
+  before(:each) do
+    @user1 = User.create
+    @user2 = User.create
+  end
+
+  subject { Approval }
+
+  describe '.owner_class' do
+    it 'proxies to ActsAsApprovable' do
+      ActsAsApprovable.should_receive(:owner_class)
+      subject.owner_class
+    end
+  end
+
+  describe '.available_owners' do
+    it 'selects all records from #owner_class' do
+      subject.available_owners.should include(@user1)
+      subject.available_owners.should include(@user2)
+    end
+  end
+
+  describe '.options_for_available_owners' do
+    it 'returns an array usable by #options_for_select' do
+      subject.options_for_available_owners.should be_an_options_array
+    end
+
+    it 'uses .available_owners as its source' do
+      subject.should_receive(:available_owners).and_return([])
+      subject.options_for_available_owners
+    end
+
+    it 'uses .options_for_owner to format each record' do
+      subject.should_receive(:option_for_owner).with(@user1).once
+      subject.should_receive(:option_for_owner).with(@user2).once
+      subject.options_for_available_owners
+    end
+
+    it 'includes a prompt if requested' do
+      subject.options_for_available_owners(true).should include(['(none)', nil])
+    end
+
+    it 'does not includes a prompt by default' do
+      subject.options_for_available_owners.should_not include(['(none)', nil])
+    end
+  end
+
+  context 'when no users are assigned' do
+    describe '.assigned_owners' do
+      it 'should be empty' do
+        subject.assigned_owners.should be_empty
+      end
+    end
+  end
+
+  context 'when some users are assigned' do
+    before(:each) do
+      CreatesApprovable.create.approval.update_attribute(:owner_id, @user1.id)
+    end
+
+    describe '.assigned_owners' do
+      it 'selects all owners with an assigned approval' do
+        subject.assigned_owners.should include(@user1)
+      end
+
+      it 'does not include owners without an assignment' do
+        subject.assigned_owners.should_not include(@user2)
+      end
+    end
+
+    describe '.options_for_assigned_owners' do
+      it 'returns an array usable by #options_for_select' do
+        subject.options_for_assigned_owners.should be_an_options_array
+      end
+
+      it 'uses .assigned_owners as its source' do
+        subject.should_receive(:assigned_owners).and_return([@user1])
+        subject.options_for_assigned_owners
+      end
+
+      it 'uses .options_for_owner to format each record' do
+        subject.should_receive(:option_for_owner).with(@user1)
+        subject.options_for_assigned_owners
+      end
+
+      it 'includes a prompt if requested' do
+        subject.options_for_assigned_owners(true).should include(['All Users', nil])
+      end
+
+      it 'does not includes a prompt by default' do
+        subject.options_for_assigned_owners.should_not include(['All Users', nil])
+      end
+    end
+  end
+end

data/spec/acts_as_approvable/ownership/instance_methods_spec.rb

@@ -0,0 +1,32 @@
+require 'spec_helper'
+
+describe ActsAsApprovable::Ownership::InstanceMethods do
+  before(:all) do
+    ActsAsApprovable::Ownership.configure
+  end
+
+  before(:each) do
+    @user1 = User.create
+    @user2 = User.new
+    subject.stub(:save => true)
+  end
+
+  subject { Approval.new }
+
+  describe '#assign' do
+    it 'sets the owner' do
+      expect { subject.assign(@user1) }.to change{subject.owner}.from(nil).to(@user1)
+    end
+
+    it 'raises an InvalidOwner error if the owner is not valid' do
+      expect { subject.assign(@user2) }.to raise_error(ActsAsApprovable::Error::InvalidOwner)
+    end
+  end
+
+  describe '#unassign' do
+    it 'removes the assigned owner' do
+      subject.owner = @user1
+      expect { subject.unassign }.to change{subject.owner}.from(@user1).to(nil)
+    end
+  end
+end

data/spec/acts_as_approvable/ownership_spec.rb

@@ -0,0 +1,51 @@
+require 'spec_helper'
+
+describe ActsAsApprovable::Ownership do
+  describe '.configure' do
+    it 'defaults to Approval as the approval model' do
+      Approval.should_receive(:include).with(ActsAsApprovable::Ownership)
+      subject.configure
+    end
+
+    it 'defaults to User as the owner model' do
+      ActsAsApprovable.should_receive(:owner_class=).with(User)
+      subject.configure
+    end
+
+    it 'adds a belongs_to(:owner) association' do
+      subject.configure
+      Approval.new.should belong_to(:owner)
+    end
+
+    it 'uses the given approval :model' do
+      class FakeApproval < ActiveRecord::Base; end
+      FakeApproval.should_receive(:include).with(ActsAsApprovable::Ownership)
+      subject.configure(:model => FakeApproval)
+    end
+
+    it 'uses the given :owner' do
+      class FakeUser; end
+      ActsAsApprovable.should_receive(:owner_class=).with(FakeUser)
+      subject.configure(:owner => FakeUser)
+    end
+
+    it 'applies the provided block' do
+      Approval.should_receive(:class_exec)
+      subject.configure {}
+    end
+  end
+
+  describe '.included' do
+    before(:all) do
+      class IncludedOwnership; include ActsAsApprovable::Ownership; end
+    end
+
+    it 'should extend ClassMethods' do
+      IncludedOwnership.should extend(ActsAsApprovable::Ownership::ClassMethods)
+    end
+
+    it 'should extend InstanceMethods' do
+      IncludedOwnership.should extend(ActsAsApprovable::Ownership::InstanceMethods)
+    end
+  end
+end

data/spec/acts_as_approvable_spec.rb

@@ -0,0 +1,29 @@
+require 'spec_helper'
+
+describe ActsAsApprovable do
+  it { should respond_to(:owner_class) }
+  it { should respond_to(:owner_class=) }
+  it { should respond_to(:view_language) }
+  it { should respond_to(:view_language=) }
+
+  describe '.enabled?' do
+    it 'returns true by default' do
+      subject.enabled?.should be_true
+    end
+  end
+
+  describe '.disable' do
+    it 'disables the approval queue' do
+      subject.disable
+      subject.enabled?.should be_false
+    end
+  end
+
+  describe '.enable' do
+    it 'enables the approval queue' do
+      subject.enable
+      subject.enabled?.should be_true
+    end
+  end
+
+end

data/spec/spec_helper.rb

@@ -0,0 +1,51 @@
+if RUBY_VERSION =~ /^1\.9/
+  begin
+    require 'simplecov'
+    SimpleCov.start do
+      add_filter '/spec/'
+    end if ENV['COVERAGE']
+  rescue LoadError
+  end
+end
+
+ENV['RAILS_ENV'] = 'test'
+ENV['RAILS_ROOT'] ||= File.expand_path(File.join(File.dirname(__FILE__), '..', '..', '..', '..'))
+
+require 'rspec'
+require 'shoulda'
+require 'timecop'
+require 'active_record'
+
+begin
+  require 'plymouth'
+rescue LoadError
+end
+
+require File.expand_path('../lib/acts-as-approvable', File.dirname(__FILE__))
+
+require File.expand_path('support/database', File.dirname(__FILE__))
+require File.expand_path('support/models', File.dirname(__FILE__))
+require File.expand_path('support/matchers', File.dirname(__FILE__))
+
+RSpec.configure do |config|
+  config.before(:suite) do
+    LOGGER = Support::Database.setup_log unless defined?(LOGGER)
+    Support::Database.load_schema
+  end
+
+  config.before(:each) do
+    Object.send(:remove_const, :CleanApprovable) if defined?(CleanApprovable)
+    class CleanApprovable < ActiveRecord::Base
+      def self.table_name; 'nots'; end
+      def self.primary_key; 'id'; end
+    end
+
+    freeze_at = Time.parse('2012-01-01')
+    Timecop.freeze(freeze_at)
+  end
+
+  config.after(:each) do
+    Timecop.return
+    Support::Database.truncate
+  end
+end