activity_notification 1.4.4 → 2.2.4

data/spec/controllers/subscriptions_api_controller_spec.rb

@@ -0,0 +1,19 @@
+require 'controllers/subscriptions_api_controller_shared_examples'
+
+describe ActivityNotification::SubscriptionsApiController, type: :controller do
+  let(:test_target)        { create(:user) }
+  let(:target_type)        { :users }
+  let(:typed_target_param) { :user_id }
+  let(:extra_params)       { {} }
+  let(:valid_session)      {}
+
+  it_behaves_like :subscriptions_api_controller
+
+  describe "/api/v#{ActivityNotification::GEM_VERSION::MAJOR}", type: :request do
+    let(:root_path)          { "/api/v#{ActivityNotification::GEM_VERSION::MAJOR}" }
+    let(:test_target)        { create(:user) }
+    let(:target_type)        { :users }
+
+    it_behaves_like :subscriptions_api_request
+  end
+end

data/spec/controllers/subscriptions_api_with_devise_controller_spec.rb

@@ -0,0 +1,60 @@
+require 'controllers/subscriptions_api_controller_shared_examples'
+
+context "ActivityNotification::NotificationsApiWithDeviseController" do
+  context "test admins API with associated users authentication" do
+
+    describe "/api/v#{ActivityNotification::GEM_VERSION::MAJOR}", type: :request do
+      include ActivityNotification::ControllerSpec::CommitteeUtility
+
+      let(:root_path)            { "/api/v#{ActivityNotification::GEM_VERSION::MAJOR}" }
+      let(:test_user)            { create(:confirmed_user) }
+      let(:unauthenticated_user) { create(:confirmed_user) }
+      let(:test_target)          { create(:admin, user: test_user) }
+      let(:target_type)          { :admins }
+
+      def sign_in_with_devise_token_auth(auth_user, status)
+        post_with_compatibility "#{root_path}/auth/sign_in", params: { email: auth_user.email, password: "password" }
+        expect(response).to have_http_status(status)
+        @headers = response.header.slice("access-token", "client", "uid")
+      end
+
+      context "signed in with devise as authenticated user" do
+        before do
+          sign_in_with_devise_token_auth(test_user, 200)
+        end
+      
+        it_behaves_like :subscriptions_api_request
+      end
+
+      context "signed in with devise as unauthenticated user" do
+        let(:target_params) { { target_type: target_type, devise_type: :users } }
+
+        describe "GET #index" do
+          before do
+            sign_in_with_devise_token_auth(unauthenticated_user, 200)
+            get_with_compatibility "#{api_path}/subscriptions", headers: @headers
+          end
+      
+          it "returns 403 as http status code" do
+            expect(response.status).to eq(403)
+          end
+        end
+      end
+
+      context "unsigned in with devise" do
+        let(:target_params) { { target_type: target_type, devise_type: :users } }
+
+        describe "GET #index" do
+          before do
+            get_with_compatibility "#{api_path}/subscriptions", headers: @headers
+          end
+      
+          it "returns 401 as http status code" do
+            expect(response.status).to eq(401)
+          end
+        end
+      end
+    end
+
+  end
+end

data/spec/controllers/subscriptions_controller_shared_examples.rb

@@ -1,4 +1,8 @@
-shared_examples_for :subscription_controller do
+require_relative 'controller_spec_utility'
+
+shared_examples_for :subscriptions_controller do
+  include ActivityNotification::ControllerSpec::RequestUtility
+
   let(:target_params) { { target_type: target_type }.merge(extra_params || {}) }
 
   describe "GET #index" do
@@ -81,30 +85,6 @@ shared_examples_for :subscription_controller do
       end
     end
 
-    context "with json as format parameter" do
-      before do
-        @subscription = create(:subscription, target: test_target, key: 'test_subscription_key')
-        @notification = create(:notification, target: test_target, key: 'test_notification_key')
-        get_with_compatibility :index, target_params.merge({ typed_target_param => test_target, format: :json }), valid_session
-      end
-
-      it "returns 200 as http status code" do
-        expect(response.status).to eq(200)
-      end
-
-      it "returns json format" do
-        if ActivityNotification.config.orm == :active_record
-          expect(JSON.parse(response.body)["subscriptions"].first)
-          .to include("target_id" => test_target.id, "target_type" => test_target.to_class_name)
-        else
-          expect(JSON.parse(response.body)["subscriptions"].first)
-          .to include("target_id" => test_target.id.to_s, "target_type" => test_target.to_class_name)
-        end
-        expect(JSON.parse(response.body)["unconfigured_notification_keys"].first)
-        .to eq('test_notification_key')
-      end
-    end
-
     context "with filter parameter" do
       context "with configured as filter" do
         before do
@@ -225,14 +205,14 @@ shared_examples_for :subscription_controller do
     end
   end
 
-  describe "POST #create" do
+  describe "PUT #create" do
     before do
-      expect(test_target.subscriptions.size).to      eq(0)
+      expect(test_target.subscriptions.size).to       eq(0)
     end
 
-    context "http direct POST request without optional targets" do
+    context "http direct PUT request without optional targets" do
       before do
-        post_with_compatibility :create, target_params.merge({
+        put_with_compatibility :create, target_params.merge({
             typed_target_param => test_target,
             "subscription"     => { "key"        => "new_subscription_key",
                                     "subscribing"=> "true",
@@ -255,9 +235,9 @@ shared_examples_for :subscription_controller do
       end
     end
 
-    context "http direct POST request with optional targets" do
+    context "http direct PUT request with optional targets" do
       before do
-        post_with_compatibility :create, target_params.merge({
+        put_with_compatibility :create, target_params.merge({
             typed_target_param => test_target,
             "subscription"     => { "key"        => "new_subscription_key",
                                     "subscribing"=> "true",
@@ -273,9 +253,10 @@ shared_examples_for :subscription_controller do
 
       it "creates new subscription of the target" do
         expect(test_target.subscriptions.reload.size).to      eq(1)
-        expect(test_target.subscriptions.reload.first.key).to eq("new_subscription_key")
-        expect(test_target.subscriptions.reload.first.subscribing_to_optional_target?("base1")).to be_truthy
-        expect(test_target.subscriptions.reload.first.subscribing_to_optional_target?("base2")).to be_falsey
+        created_subscription = test_target.subscriptions.reload.first
+        expect(created_subscription.key).to eq("new_subscription_key")
+        expect(created_subscription.subscribing_to_optional_target?("base1")).to be_truthy
+        expect(created_subscription.subscribing_to_optional_target?("base2")).to be_falsey
       end
 
       it "redirects to :index" do
@@ -283,10 +264,10 @@ shared_examples_for :subscription_controller do
       end
     end
 
-    context "http POST request from root_path" do
+    context "http PUT request from root_path" do
       before do
         request.env["HTTP_REFERER"] = root_path
-        post_with_compatibility :create, target_params.merge({
+        put_with_compatibility :create, target_params.merge({
             typed_target_param => test_target,
             "subscription"     => { "key"        => "new_subscription_key",
                                     "subscribing"=> "true",
@@ -309,10 +290,10 @@ shared_examples_for :subscription_controller do
       end
     end
 
-    context "Ajax POST request" do
+    context "Ajax PUT request" do
       before do
         request.env["HTTP_REFERER"] = root_path
-        xhr_with_compatibility :post, :create, target_params.merge({
+        xhr_with_compatibility :put, :create, target_params.merge({
             typed_target_param => test_target,
             "subscription"     => { "key"        => "new_subscription_key",
                                     "subscribing"=> "true",
@@ -340,6 +321,38 @@ shared_examples_for :subscription_controller do
     end
   end
 
+  describe "GET #find" do
+    context "with key, target_type and (typed_target)_id parameters" do
+      before do
+        @subscription = create(:subscription, target: test_target, key: 'test_subscription_key')
+        get_with_compatibility :find, target_params.merge({ key: 'test_subscription_key', typed_target_param => test_target }), valid_session
+      end
+
+      it "returns 302 as http status code" do
+        expect(response.status).to eq(302)
+      end
+
+      it "assigns the requested subscription as @subscription" do
+        expect(assigns(:subscription)).to eq(@subscription)
+      end
+
+      it "redirects to :show" do
+        expect(response).to redirect_to action: :show, id: @subscription
+      end
+    end
+
+    context "with wrong id and (typed_target)_id parameters" do
+      before do
+        @subscription = create(:subscription, target: create(:user))
+        get_with_compatibility :find, target_params.merge({ key: 'test_subscription_key', typed_target_param => test_target }), valid_session
+      end
+
+      it "returns 404 as http status code" do
+        expect(response.status).to eq(404)
+      end
+    end
+  end
+
   describe "GET #show" do
     context "with id, target_type and (typed_target)_id parameters" do
       before do
@@ -355,7 +368,7 @@ shared_examples_for :subscription_controller do
         expect(assigns(:subscription)).to eq(@subscription)
       end
 
-      it "renders the :index template" do
+      it "renders the :show template" do
         expect(response).to render_template :show
       end
     end
@@ -384,7 +397,7 @@ shared_examples_for :subscription_controller do
       end
 
       it "deletes the subscription" do
-        expect(assigns(test_target.subscriptions.where(id: @subscription.id).exists?)).to be_falsey
+        expect(test_target.subscriptions.where(id: @subscription.id).exists?).to be_falsey
       end
 
       it "redirects to :index" do
@@ -436,13 +449,13 @@ shared_examples_for :subscription_controller do
     end
   end
 
-  describe "POST #subscribe" do
-    context "http direct POST request" do
+  describe "PUT #subscribe" do
+    context "http direct PUT request" do
       before do
         @subscription = create(:subscription, target: test_target, key: 'test_subscription_key')
         @subscription.unsubscribe
         expect(@subscription.subscribing?).to be_falsey
-        post_with_compatibility :subscribe, target_params.merge({ id: @subscription, typed_target_param => test_target }), valid_session
+        put_with_compatibility :subscribe, target_params.merge({ id: @subscription, typed_target_param => test_target }), valid_session
       end
 
       it "returns 302 as http status code" do
@@ -458,13 +471,13 @@ shared_examples_for :subscription_controller do
       end
     end
 
-    context "http POST request from root_path" do
+    context "http PUT request from root_path" do
       before do
         @subscription = create(:subscription, target: test_target, key: 'test_subscription_key')
         @subscription.unsubscribe
         expect(@subscription.subscribing?).to be_falsey
         request.env["HTTP_REFERER"] = root_path
-        post_with_compatibility :subscribe, target_params.merge({ id: @subscription, typed_target_param => test_target }), valid_session
+        put_with_compatibility :subscribe, target_params.merge({ id: @subscription, typed_target_param => test_target }), valid_session
       end
 
       it "returns 302 as http status code" do
@@ -480,13 +493,13 @@ shared_examples_for :subscription_controller do
       end
     end
 
-    context "Ajax POST request" do
+    context "Ajax PUT request" do
       before do
         @subscription = create(:subscription, target: test_target, key: 'test_subscription_key')
         @subscription.unsubscribe
         expect(@subscription.subscribing?).to be_falsey
         request.env["HTTP_REFERER"] = root_path
-        xhr_with_compatibility :post, :subscribe, target_params.merge({ id: @subscription, typed_target_param => test_target }), valid_session
+        xhr_with_compatibility :put, :subscribe, target_params.merge({ id: @subscription, typed_target_param => test_target }), valid_session
       end
   
       it "returns 200 as http status code" do
@@ -507,12 +520,12 @@ shared_examples_for :subscription_controller do
     end
   end
 
-  describe "POST #unsubscribe" do
-    context "http direct POST request" do
+  describe "PUT #unsubscribe" do
+    context "http direct PUT request" do
       before do
         @subscription = create(:subscription, target: test_target, key: 'test_subscription_key')
         expect(@subscription.subscribing?).to be_truthy
-        post_with_compatibility :unsubscribe, target_params.merge({ id: @subscription, typed_target_param => test_target }), valid_session
+        put_with_compatibility :unsubscribe, target_params.merge({ id: @subscription, typed_target_param => test_target }), valid_session
       end
 
       it "returns 302 as http status code" do
@@ -528,12 +541,12 @@ shared_examples_for :subscription_controller do
       end
     end
 
-    context "http POST request from root_path" do
+    context "http PUT request from root_path" do
       before do
         @subscription = create(:subscription, target: test_target, key: 'test_subscription_key')
         expect(@subscription.subscribing?).to be_truthy
         request.env["HTTP_REFERER"] = root_path
-        post_with_compatibility :unsubscribe, target_params.merge({ id: @subscription, typed_target_param => test_target }), valid_session
+        put_with_compatibility :unsubscribe, target_params.merge({ id: @subscription, typed_target_param => test_target }), valid_session
       end
 
       it "returns 302 as http status code" do
@@ -549,12 +562,12 @@ shared_examples_for :subscription_controller do
       end
     end
 
-    context "Ajax POST request" do
+    context "Ajax PUT request" do
       before do
         @subscription = create(:subscription, target: test_target, key: 'test_subscription_key')
         expect(@subscription.subscribing?).to be_truthy
         request.env["HTTP_REFERER"] = root_path
-        xhr_with_compatibility :post, :unsubscribe, target_params.merge({ id: @subscription, typed_target_param => test_target }), valid_session
+        xhr_with_compatibility :put, :unsubscribe, target_params.merge({ id: @subscription, typed_target_param => test_target }), valid_session
       end
   
       it "returns 200 as http status code" do
@@ -575,13 +588,13 @@ shared_examples_for :subscription_controller do
     end
   end
 
-  describe "POST #subscribe_to_email" do
-    context "http direct POST request" do
+  describe "PUT #subscribe_to_email" do
+    context "http direct PUT request" do
       before do
         @subscription = create(:subscription, target: test_target, key: 'test_subscription_key')
         @subscription.unsubscribe_to_email
         expect(@subscription.subscribing_to_email?).to be_falsey
-        post_with_compatibility :subscribe_to_email, target_params.merge({ id: @subscription, typed_target_param => test_target }), valid_session
+        put_with_compatibility :subscribe_to_email, target_params.merge({ id: @subscription, typed_target_param => test_target }), valid_session
       end
 
       it "returns 302 as http status code" do
@@ -597,13 +610,13 @@ shared_examples_for :subscription_controller do
       end
     end
 
-    context "http POST request from root_path" do
+    context "http PUT request from root_path" do
       before do
         @subscription = create(:subscription, target: test_target, key: 'test_subscription_key')
         @subscription.unsubscribe_to_email
         expect(@subscription.subscribing_to_email?).to be_falsey
         request.env["HTTP_REFERER"] = root_path
-        post_with_compatibility :subscribe_to_email, target_params.merge({ id: @subscription, typed_target_param => test_target }), valid_session
+        put_with_compatibility :subscribe_to_email, target_params.merge({ id: @subscription, typed_target_param => test_target }), valid_session
       end
 
       it "returns 302 as http status code" do
@@ -619,13 +632,13 @@ shared_examples_for :subscription_controller do
       end
     end
 
-    context "Ajax POST request" do
+    context "Ajax PUT request" do
       before do
         @subscription = create(:subscription, target: test_target, key: 'test_subscription_key')
         @subscription.unsubscribe_to_email
         expect(@subscription.subscribing_to_email?).to be_falsey
         request.env["HTTP_REFERER"] = root_path
-        xhr_with_compatibility :post, :subscribe_to_email, target_params.merge({ id: @subscription, typed_target_param => test_target }), valid_session
+        xhr_with_compatibility :put, :subscribe_to_email, target_params.merge({ id: @subscription, typed_target_param => test_target }), valid_session
       end
   
       it "returns 200 as http status code" do
@@ -651,7 +664,7 @@ shared_examples_for :subscription_controller do
         @subscription.unsubscribe
         expect(@subscription.subscribing?).to be_falsey
         expect(@subscription.subscribing_to_email?).to be_falsey
-        post_with_compatibility :subscribe_to_email, target_params.merge({ id: @subscription, typed_target_param => test_target }), valid_session
+        put_with_compatibility :subscribe_to_email, target_params.merge({ id: @subscription, typed_target_param => test_target }), valid_session
       end
 
       it "returns 302 as http status code" do
@@ -668,12 +681,12 @@ shared_examples_for :subscription_controller do
     end
   end
 
-  describe "POST #unsubscribe_to_email" do
-    context "http direct POST request" do
+  describe "PUT #unsubscribe_to_email" do
+    context "http direct PUT request" do
       before do
         @subscription = create(:subscription, target: test_target, key: 'test_subscription_key')
         expect(@subscription.subscribing_to_email?).to be_truthy
-        post_with_compatibility :unsubscribe_to_email, target_params.merge({ id: @subscription, typed_target_param => test_target }), valid_session
+        put_with_compatibility :unsubscribe_to_email, target_params.merge({ id: @subscription, typed_target_param => test_target }), valid_session
       end
 
       it "returns 302 as http status code" do
@@ -689,12 +702,12 @@ shared_examples_for :subscription_controller do
       end
     end
 
-    context "http POST request from root_path" do
+    context "http PUT request from root_path" do
       before do
         @subscription = create(:subscription, target: test_target, key: 'test_subscription_key')
         expect(@subscription.subscribing_to_email?).to be_truthy
         request.env["HTTP_REFERER"] = root_path
-        post_with_compatibility :unsubscribe_to_email, target_params.merge({ id: @subscription, typed_target_param => test_target }), valid_session
+        put_with_compatibility :unsubscribe_to_email, target_params.merge({ id: @subscription, typed_target_param => test_target }), valid_session
       end
 
       it "returns 302 as http status code" do
@@ -710,12 +723,12 @@ shared_examples_for :subscription_controller do
       end
     end
 
-    context "Ajax POST request" do
+    context "Ajax PUT request" do
       before do
         @subscription = create(:subscription, target: test_target, key: 'test_subscription_key')
         expect(@subscription.subscribing_to_email?).to be_truthy
         request.env["HTTP_REFERER"] = root_path
-        xhr_with_compatibility :post, :unsubscribe_to_email, target_params.merge({ id: @subscription, typed_target_param => test_target }), valid_session
+        xhr_with_compatibility :put, :unsubscribe_to_email, target_params.merge({ id: @subscription, typed_target_param => test_target }), valid_session
       end
   
       it "returns 200 as http status code" do
@@ -736,13 +749,13 @@ shared_examples_for :subscription_controller do
     end
   end
 
-  describe "POST #subscribe_to_optional_target" do
+  describe "PUT #subscribe_to_optional_target" do
     context "without optional_target_name param" do
       before do
         @subscription = create(:subscription, target: test_target, key: 'test_subscription_key')
         @subscription.unsubscribe_to_optional_target(:base)
         expect(@subscription.subscribing_to_optional_target?(:base)).to be_falsey
-        post_with_compatibility :subscribe_to_optional_target, target_params.merge({ id: @subscription, typed_target_param => test_target }), valid_session
+        put_with_compatibility :subscribe_to_optional_target, target_params.merge({ id: @subscription, typed_target_param => test_target }), valid_session
       end
 
       it "returns 400 as http status code" do
@@ -754,12 +767,12 @@ shared_examples_for :subscription_controller do
       end
     end
 
-    context "http direct POST request" do
+    context "http direct PUT request" do
       before do
         @subscription = create(:subscription, target: test_target, key: 'test_subscription_key')
         @subscription.unsubscribe_to_optional_target(:base)
         expect(@subscription.subscribing_to_optional_target?(:base)).to be_falsey
-        post_with_compatibility :subscribe_to_optional_target, target_params.merge({ id: @subscription, optional_target_name: 'base', typed_target_param => test_target }), valid_session
+        put_with_compatibility :subscribe_to_optional_target, target_params.merge({ id: @subscription, optional_target_name: 'base', typed_target_param => test_target }), valid_session
       end
 
       it "returns 302 as http status code" do
@@ -775,13 +788,13 @@ shared_examples_for :subscription_controller do
       end
     end
 
-    context "http POST request from root_path" do
+    context "http PUT request from root_path" do
       before do
         @subscription = create(:subscription, target: test_target, key: 'test_subscription_key')
         @subscription.unsubscribe_to_optional_target(:base)
         expect(@subscription.subscribing_to_optional_target?(:base)).to be_falsey
         request.env["HTTP_REFERER"] = root_path
-        post_with_compatibility :subscribe_to_optional_target, target_params.merge({ id: @subscription, optional_target_name: 'base', typed_target_param => test_target }), valid_session
+        put_with_compatibility :subscribe_to_optional_target, target_params.merge({ id: @subscription, optional_target_name: 'base', typed_target_param => test_target }), valid_session
       end
 
       it "returns 302 as http status code" do
@@ -797,13 +810,13 @@ shared_examples_for :subscription_controller do
       end
     end
 
-    context "Ajax POST request" do
+    context "Ajax PUT request" do
       before do
         @subscription = create(:subscription, target: test_target, key: 'test_subscription_key')
         @subscription.unsubscribe_to_optional_target(:base)
         expect(@subscription.subscribing_to_optional_target?(:base)).to be_falsey
         request.env["HTTP_REFERER"] = root_path
-        xhr_with_compatibility :post, :subscribe_to_optional_target, target_params.merge({ id: @subscription, optional_target_name: 'base', typed_target_param => test_target }), valid_session
+        xhr_with_compatibility :put, :subscribe_to_optional_target, target_params.merge({ id: @subscription, optional_target_name: 'base', typed_target_param => test_target }), valid_session
       end
   
       it "returns 200 as http status code" do
@@ -830,7 +843,7 @@ shared_examples_for :subscription_controller do
         @subscription.unsubscribe
         expect(@subscription.subscribing?).to be_falsey
         expect(@subscription.subscribing_to_optional_target?(:base)).to be_falsey
-        post_with_compatibility :subscribe_to_optional_target, target_params.merge({ id: @subscription, optional_target_name: 'base', typed_target_param => test_target }), valid_session
+        put_with_compatibility :subscribe_to_optional_target, target_params.merge({ id: @subscription, optional_target_name: 'base', typed_target_param => test_target }), valid_session
       end
 
       it "returns 302 as http status code" do
@@ -847,12 +860,12 @@ shared_examples_for :subscription_controller do
     end
   end
 
-  describe "POST #unsubscribe_to_email" do
+  describe "PUT #unsubscribe_to_email" do
     context "without optional_target_name param" do
       before do
         @subscription = create(:subscription, target: test_target, key: 'test_subscription_key')
         expect(@subscription.subscribing_to_optional_target?(:base)).to be_truthy
-        post_with_compatibility :unsubscribe_to_optional_target, target_params.merge({ id: @subscription, typed_target_param => test_target }), valid_session
+        put_with_compatibility :unsubscribe_to_optional_target, target_params.merge({ id: @subscription, typed_target_param => test_target }), valid_session
       end
 
       it "returns 400 as http status code" do
@@ -864,11 +877,11 @@ shared_examples_for :subscription_controller do
       end
     end
 
-    context "http direct POST request" do
+    context "http direct PUT request" do
       before do
         @subscription = create(:subscription, target: test_target, key: 'test_subscription_key')
         expect(@subscription.subscribing_to_optional_target?(:base)).to be_truthy
-        post_with_compatibility :unsubscribe_to_optional_target, target_params.merge({ id: @subscription, optional_target_name: 'base', typed_target_param => test_target }), valid_session
+        put_with_compatibility :unsubscribe_to_optional_target, target_params.merge({ id: @subscription, optional_target_name: 'base', typed_target_param => test_target }), valid_session
       end
 
       it "returns 302 as http status code" do
@@ -884,12 +897,12 @@ shared_examples_for :subscription_controller do
       end
     end
 
-    context "http POST request from root_path" do
+    context "http PUT request from root_path" do
       before do
         @subscription = create(:subscription, target: test_target, key: 'test_subscription_key')
         expect(@subscription.subscribing_to_optional_target?(:base)).to be_truthy
         request.env["HTTP_REFERER"] = root_path
-        post_with_compatibility :unsubscribe_to_optional_target, target_params.merge({ id: @subscription, optional_target_name: 'base', typed_target_param => test_target }), valid_session
+        put_with_compatibility :unsubscribe_to_optional_target, target_params.merge({ id: @subscription, optional_target_name: 'base', typed_target_param => test_target }), valid_session
       end
 
       it "returns 302 as http status code" do
@@ -905,12 +918,12 @@ shared_examples_for :subscription_controller do
       end
     end
 
-    context "Ajax POST request" do
+    context "Ajax PUT request" do
       before do
         @subscription = create(:subscription, target: test_target, key: 'test_subscription_key')
         expect(@subscription.subscribing_to_optional_target?(:base)).to be_truthy
         request.env["HTTP_REFERER"] = root_path
-        xhr_with_compatibility :post, :unsubscribe_to_optional_target, target_params.merge({ id: @subscription, optional_target_name: 'base', typed_target_param => test_target }), valid_session
+        xhr_with_compatibility :put, :unsubscribe_to_optional_target, target_params.merge({ id: @subscription, optional_target_name: 'base', typed_target_param => test_target }), valid_session
       end
   
       it "returns 200 as http status code" do
@@ -930,39 +943,4 @@ shared_examples_for :subscription_controller do
       end
     end
   end
-
-
-  private
-
-    def get_with_compatibility action, params, session
-      if Rails::VERSION::MAJOR <= 4
-        get action, params, session
-      else
-        get action, params: params, session: session
-      end
-    end
-
-    def post_with_compatibility action, params, session
-      if Rails::VERSION::MAJOR <= 4
-        post action, params, session
-      else
-        post action, params: params, session: session
-      end
-    end
-
-    def delete_with_compatibility action, params, session
-      if Rails::VERSION::MAJOR <= 4
-        delete action, params, session
-      else
-        delete action, params: params, session: session
-      end
-    end
-
-    def xhr_with_compatibility method, action, params, session
-      if Rails::VERSION::MAJOR <= 4
-        xhr method, action, params, session
-      else
-        send method.to_s, action, xhr: true, params: params, session: session
-      end
-    end
 end

data/spec/controllers/subscriptions_controller_spec.rb

@@ -7,6 +7,5 @@ describe ActivityNotification::SubscriptionsController, type: :controller do
   let(:extra_params)       { {} }
   let(:valid_session)      {}
 
-  it_behaves_like :subscription_controller
-
+  it_behaves_like :subscriptions_controller
 end

data/spec/controllers/subscriptions_with_devise_controller_spec.rb

@@ -1,6 +1,8 @@
 require 'controllers/subscriptions_controller_shared_examples'
 
 describe ActivityNotification::SubscriptionsWithDeviseController, type: :controller do
+  include ActivityNotification::ControllerSpec::RequestUtility
+
   let(:test_user)            { create(:confirmed_user) }
   let(:unauthenticated_user) { create(:confirmed_user) }
   let(:test_target)          { create(:admin, user: test_user) }
@@ -14,7 +16,7 @@ describe ActivityNotification::SubscriptionsWithDeviseController, type: :control
       sign_in test_user
     end
   
-    it_behaves_like :subscription_controller
+    it_behaves_like :subscriptions_controller
   end
 
   context "signed in with devise as unauthenticated user" do
@@ -78,14 +80,18 @@ describe ActivityNotification::SubscriptionsWithDeviseController, type: :control
     end
   end
 
-  private
+  context "without target_id and (typed_target)_id parameters for devise integrated controller with devise_type option" do
+    let(:target_params) { { target_type: target_type, devise_type: :users } }
+
+    describe "GET #index" do
+      before do
+        sign_in test_target.user
+        get_with_compatibility :index, target_params, valid_session
+      end
 
-    def get_with_compatibility action, params, session
-      if Rails::VERSION::MAJOR <= 4
-        get action, params, session
-      else
-        get action, params: params, session: session
+      it "returns 200 as http status code" do
+        expect(response.status).to eq(200)
       end
     end
-
+  end
 end

data/spec/factories/notifications.rb

@@ -2,6 +2,6 @@ FactoryBot.define do
   factory :notification, class: ActivityNotification::Notification do
     association :target, factory: :confirmed_user
     association :notifiable, factory: :article
-    key "default.default"
+    key { "default.default" }
   end
 end