activity_notification 1.4.4 → 1.5.0

data/lib/activity_notification/renderable.rb

@@ -8,7 +8,7 @@ module ActivityNotification
     #
     # @param [Hash] params Parameters for rendering notification text
     # @option params [String] :target Target type name to use as i18n text key
-    # @option params [Hash] others Parameters to be reffered in i18n text
+    # @option params [Hash] others Parameters to be referred in i18n text
     # @return [String] Rendered text
     def text(params = {})
       k = key.split('.')
@@ -21,12 +21,16 @@ module ActivityNotification
       k.push('text')
       k = k.join('.')
 
-      I18n.t(k, (parameters.merge(params) || {}).merge(
+      attrs = (parameters.symbolize_keys.merge(params) || {}).merge(
         group_member_count:          group_member_count,
         group_notification_count:    group_notification_count,
         group_member_notifier_count: group_member_notifier_count,
         group_notifier_count:        group_notifier_count
-      ))
+      )
+
+      # Generate the :default fallback key without using pluralization key :count
+      default = I18n.t(k, attrs)
+      I18n.t(k, attrs.merge(count: group_notification_count, default: default))
     end
 
     # Renders notification from views.
@@ -88,7 +92,7 @@ module ActivityNotification
     #   <%= yield %>
     #
     # == Custom Layout Location
-    # 
+    #
     # You can customize the layout directory by supplying :layout_root
     # or by using an absolute path.
     #
@@ -142,7 +146,7 @@ module ActivityNotification
     # @option params [Hash]           others                                  Parameters to be set as locals
     # @return [String] Rendered view or text as string
     def render(context, params = {})
-      params[:i18n] and return context.render text: self.text(params)
+      params[:i18n] and return context.render plain: self.text(params)
 
       partial = partial_path(*params.values_at(:partial, :partial_root, :target))
       layout  = layout_path(*params.values_at(:layout, :layout_root))

data/lib/activity_notification/version.rb

@@ -1,3 +1,3 @@
 module ActivityNotification
-  VERSION = "1.4.4"
+  VERSION = "1.5.0"
 end

data/lib/generators/templates/controllers/README

@@ -6,8 +6,8 @@ Some setup you must do manually if you haven't yet:
   For example:
 
     Rails.application.routes.draw do
-      notify_to :users,                       controllers: 'users/notifications'
-      notify_to :admins, with_devise: :users, controllers: 'admins/notifications_with_devise'
+      notify_to :users,                       controller: 'users/notifications'
+      notify_to :admins, with_devise: :users, controller: 'admins/notifications_with_devise'
     end
 
 ===============================================================================

data/scripts/bundle_update.sh

@@ -0,0 +1,7 @@
+#!/bin/bash
+
+bundle update
+BUNDLE_GEMFILE=gemfiles/Gemfile.rails-4.2 bundle update
+BUNDLE_GEMFILE=gemfiles/Gemfile.rails-5.0 bundle update
+BUNDLE_GEMFILE=gemfiles/Gemfile.rails-5.1 bundle update
+BUNDLE_GEMFILE=gemfiles/Gemfile.rails-5.2 bundle update

data/spec/concerns/models/target_spec.rb

@@ -924,18 +924,8 @@ shared_examples_for :target do
           end
 
           if ActivityNotification.config.orm == :active_record
-            it "calls with_target, with_notifiable and with_notifier" do
-              expect(ActiveRecord::Base).to receive(:includes).with(:target)
-              expect(ActiveRecord::Base).to receive(:includes).with(:notifiable)
-              expect(ActiveRecord::Base).to receive(:includes).with(:notifier)
-              test_instance.unopened_notification_index_with_attributes
-            end
-
-            it "does not call with_group" do
-              expect(ActiveRecord::Base).to receive(:includes).with(:target)
-              expect(ActiveRecord::Base).to receive(:includes).with(:notifiable)
-              expect(ActiveRecord::Base).not_to receive(:includes).with(:group)
-              expect(ActiveRecord::Base).to receive(:includes).with(:notifier)
+            it "calls with_target, with_notifiable, with_notifier and does not call with_group" do
+              expect(ActivityNotification::Notification).to receive_message_chain(:with_target, :with_notifiable, :with_notifier)
               test_instance.unopened_notification_index_with_attributes
             end
           end
@@ -950,10 +940,7 @@ shared_examples_for :target do
 
           if ActivityNotification.config.orm == :active_record
             it "calls with_group" do
-              expect(ActiveRecord::Base).to receive(:includes).with(:target)
-              expect(ActiveRecord::Base).to receive(:includes).with(:notifiable)
-              expect(ActiveRecord::Base).to receive(:includes).with(:group)
-              expect(ActiveRecord::Base).to receive(:includes).with(:notifier)
+              expect(ActivityNotification::Notification).to receive_message_chain(:with_target, :with_notifiable, :with_group, :with_notifier)
               test_instance.unopened_notification_index_with_attributes
             end
           end
@@ -986,18 +973,8 @@ shared_examples_for :target do
           end
 
           if ActivityNotification.config.orm == :active_record
-            it "calls with_target, with_notifiable and with_notifier" do
-              expect(ActiveRecord::Base).to receive(:includes).with(:target)
-              expect(ActiveRecord::Base).to receive(:includes).with(:notifiable)
-              expect(ActiveRecord::Base).to receive(:includes).with(:notifier)
-              test_instance.opened_notification_index_with_attributes
-            end
-
-            it "does not call with_group" do
-              expect(ActiveRecord::Base).to receive(:includes).with(:target)
-              expect(ActiveRecord::Base).to receive(:includes).with(:notifiable)
-              expect(ActiveRecord::Base).not_to receive(:includes).with(:group)
-              expect(ActiveRecord::Base).to receive(:includes).with(:notifier)
+            it "calls with_target, with_notifiable, with_notifier and does not call with_group" do
+              expect(ActivityNotification::Notification).to receive_message_chain(:with_target, :with_notifiable, :with_notifier)
               test_instance.opened_notification_index_with_attributes
             end
           end
@@ -1012,10 +989,7 @@ shared_examples_for :target do
 
           if ActivityNotification.config.orm == :active_record
             it "calls with_group" do
-              expect(ActiveRecord::Base).to receive(:includes).with(:target)
-              expect(ActiveRecord::Base).to receive(:includes).with(:notifiable)
-              expect(ActiveRecord::Base).to receive(:includes).with(:group)
-              expect(ActiveRecord::Base).to receive(:includes).with(:notifier)
+              expect(ActivityNotification::Notification).to receive_message_chain(:with_target, :with_notifiable, :with_group, :with_notifier)
               test_instance.opened_notification_index_with_attributes
             end
           end

data/spec/concerns/renderable_spec.rb

@@ -4,17 +4,23 @@ shared_examples_for :renderable do
   let(:test_instance) { create(test_class_name, target: test_target) }
   let(:target_type_key) { 'user' }
 
-  let(:notifier_name)        { 'foo' }
-  let(:article_title)        { 'bar' }
-  let(:group_member_count)   { 3 }
-  let(:simple_text_key)      { 'article.create' }
-  let(:params_text_key)      { 'comment.post' }
-  let(:group_text_key)       { 'comment.reply' }
-  let(:simple_text_original) { 'Article has been created' }
-  let(:params_text_original) { "<p>%{notifier_name} posted comments to your article %{article_title}</p>" }
-  let(:group_text_original)  { "<p>%{notifier_name} and %{group_member_count} people replied for your comments</p>" }
-  let(:params_text_embedded) { "<p>foo posted comments to your article bar</p>" }
-  let(:group_text_embedded)  { "<p>foo and 3 people replied for your comments</p>" }
+  let(:notifier_name)              { 'foo' }
+  let(:article_title)              { 'bar' }
+  let(:group_notification_count)   { 4 }
+  let(:group_member_count)         { 3 }
+  let(:simple_text_key)            { 'article.create' }
+  let(:params_text_key)            { 'article.update' }
+  let(:group_text_key)             { 'comment.reply' }
+  let(:plural_text_key)            { 'comment.post' }
+  let(:simple_text_original)       { 'Article has been created' }
+  let(:params_text_original)       { "Article %{article_title} has been updated" }
+  let(:plural_text_original_one)   { "<p>%{notifier_name} posted a comment on your article %{article_title}</p>" }
+  let(:plural_text_original_other) { "<p>%{notifier_name} posted %{count} comments on your article %{article_title}</p>" }
+  let(:group_text_original)        { "<p>%{notifier_name} and %{group_member_count} other people replied %{group_notification_count} times to your comment</p>" }
+  let(:params_text_embedded)       { "Article bar has been updated" }
+  let(:group_text_embedded)        { "<p>foo and 3 other people replied 4 times to your comment</p>" }
+  let(:plural_text_embedded_one)   { "<p>foo posted a comment on your article bar</p>" }
+  let(:plural_text_embedded_other) { "<p>foo posted 4 comments on your article bar</p>" }
 
   describe "i18n configuration" do
     it "has key configured for simple text" do
@@ -26,17 +32,30 @@ shared_examples_for :renderable do
       expect(I18n.t("notification.#{target_type_key}.#{params_text_key}.text"))
         .to eq(params_text_original)
       expect(I18n.t("notification.#{target_type_key}.#{params_text_key}.text",
-        {notifier_name: notifier_name, article_title: article_title}))
+        {article_title: article_title}))
         .to eq(params_text_embedded)
     end
 
-    it "has key configured with embedded params including group_member_count" do
+    it "has key configured with embedded params including group_member_count and group_notification_count" do
       expect(I18n.t("notification.#{target_type_key}.#{group_text_key}.text"))
         .to eq(group_text_original)
       expect(I18n.t("notification.#{target_type_key}.#{group_text_key}.text",
-        {notifier_name: notifier_name, group_member_count: group_member_count}))
+        {notifier_name: notifier_name, group_member_count: group_member_count, group_notification_count: group_notification_count}))
         .to eq(group_text_embedded)
     end
+
+    it "has key configured with plurals" do
+      expect(I18n.t("notification.#{target_type_key}.#{plural_text_key}.text")[:one])
+        .to eq(plural_text_original_one)
+      expect(I18n.t("notification.#{target_type_key}.#{plural_text_key}.text")[:other])
+        .to eq(plural_text_original_other)
+      expect(I18n.t("notification.#{target_type_key}.#{plural_text_key}.text",
+        {article_title: article_title, notifier_name: notifier_name, count: 1}))
+        .to eq(plural_text_embedded_one)
+      expect(I18n.t("notification.#{target_type_key}.#{plural_text_key}.text",
+        {article_title: article_title, notifier_name: notifier_name, count: group_notification_count}))
+        .to eq(plural_text_embedded_other)
+    end
   end
 
   describe "as public instance methods" do
@@ -83,7 +102,7 @@ shared_examples_for :renderable do
           context "when the text has embedded parameters" do
             it "uses text with embedded parameters" do
               test_instance.key = params_text_key
-              expect(test_instance.text({notifier_name: notifier_name, article_title: article_title}))
+              expect(test_instance.text({article_title: article_title}))
                 .to eq(params_text_embedded)
             end
 

data/spec/helpers/view_helpers_spec.rb

@@ -67,6 +67,21 @@ describe ActivityNotification::ViewHelpers, type: :helper do
         expect(render_notification notification, fallback: :text)
           .to eq(simple_text_original)
       end
+
+      it "interpolates from parameters" do
+        notification.parameters = { "article_title" => "custom title" }
+        notification.key = 'article.update'
+        expect(render_notification notification, fallback: :text)
+          .to eq("Article custom title has been updated")
+      end
+    end
+
+    context "with i18n param set" do
+      it "uses i18n text from key" do
+        notification.key = simple_text_key
+        expect(render_notification notification, i18n: true)
+          .to eq(simple_text_original)
+      end
     end
 
     context "with custom view" do

data/spec/mailers/mailer_spec.rb

@@ -84,7 +84,7 @@ describe ActivityNotification::Mailer do
           notification.notifiable.extend(AdditionalMethods)
           ActivityNotification::Mailer.send_notification_email(notification).deliver_now
           expect(ActivityNotification::Mailer.deliveries.last.subject)
-            .to eq("New comment to your article")
+            .to eq("New comment on your article")
         end
       end
 

data/spec/rails_app/config/application.rb

@@ -28,6 +28,9 @@ module Dummy
     if Rails::VERSION::MAJOR == 4 && Rails::VERSION::MINOR >= 2 && ENV['AN_TEST_DB'] != 'mongodb'
       config.active_record.raise_in_transactional_callbacks = true
     end
+    if Rails::VERSION::MAJOR >= 5 && Rails::VERSION::MINOR >= 2 && ENV['AN_TEST_DB'] != 'mongodb'
+      config.active_record.sqlite3.represent_boolean_as_integer = true
+    end
   end
 end
 

data/spec/rails_app/config/locales/activity_notification.en.yml

@@ -6,14 +6,18 @@ en:
       article:
         create:
           text: 'Article has been created'
+        update:
+          text: 'Article %{article_title} has been updated'
         destroy:
           text: 'Some user removed an article!'
       comment:
         post:
-          text: "<p>%{notifier_name} posted comments to your article %{article_title}</p>"
+          text:
+            one: "<p>%{notifier_name} posted a comment on your article %{article_title}</p>"
+            other: "<p>%{notifier_name} posted %{count} comments on your article %{article_title}</p>"
         reply:
-          text: "<p>%{notifier_name} and %{group_member_count} people replied for your comments</p>"
-          mail_subject: 'New comment to your article'
+          text: "<p>%{notifier_name} and %{group_member_count} other people replied %{group_notification_count} times to your comment</p>"
+          mail_subject: 'New comment on your article'
     admin:
       article:
         post:

data/spec/rails_app/lib/mailer_previews/mailer_preview.rb

@@ -13,7 +13,7 @@ class ActivityNotification::MailerPreview < ActionMailer::Preview
   def send_batch_notification_email
     target = User.find_by_name('Ichiro')
     target_notifications = target.notification_index_with_attributes(filtered_by_key: 'comment.default')
-    ActivityNotification::Mailer.send_batch_notification_email(target, target_notifications)
+    ActivityNotification::Mailer.send_batch_notification_email(target, target_notifications, 'batch.comment.default')
   end
 
 end

data/spec/roles/acts_as_notifiable_spec.rb

@@ -183,6 +183,7 @@ describe ActivityNotification::ActsAsNotifiable do
 
       context "with :dependent_notifications option" do
         before do
+          dummy_notifiable_class.delete_all
           @notifiable_1, @notifiable_2, @notifiable_3 = dummy_notifiable_class.create, dummy_notifiable_class.create, dummy_notifiable_class.create
           @group_owner  = create(:notification, target: user_target, notifiable: @notifiable_1, group: @notifiable_1)
           @group_member = create(:notification, target: user_target, notifiable: @notifiable_2, group: @notifiable_1, group_owner: @group_owner)
@@ -205,7 +206,7 @@ describe ActivityNotification::ActsAsNotifiable do
           it "does not deletes any notifications when notifiable is deleted" do
             dummy_notifiable_class.acts_as_notifiable :users
             expect(user_target.notifications.reload.size).to eq(3)
-            expect { @notifiable_1.destroy }.to change(dummy_notifiable_class, :count).by(-1)
+            expect { @notifiable_1.destroy }.to change(@notifiable_1, :destroyed?).from(false).to(true)
             expect(user_target.notifications.reload.size).to eq(3)
           end
         end
@@ -214,14 +215,14 @@ describe ActivityNotification::ActsAsNotifiable do
           it "deletes all notifications when notifiable is deleted" do
             dummy_notifiable_class.acts_as_notifiable :users, dependent_notifications: :delete_all
             expect(user_target.notifications.reload.size).to eq(3)
-            expect { @notifiable_1.destroy }.to change(dummy_notifiable_class, :count).by(-1)
+            expect { @notifiable_1.destroy }.to change(@notifiable_1, :destroyed?).from(false).to(true)
             expect(user_target.notifications.reload.size).to eq(2)
             expect(@group_member.reload.group_owner?).to be_falsey
           end
 
           it "does not delete notifications of other targets when notifiable is deleted" do
             dummy_notifiable_class.acts_as_notifiable :users, dependent_notifications: :delete_all
-            expect { @notifiable_1.destroy }.to change(dummy_notifiable_class, :count).by(-1)
+            expect { @notifiable_1.destroy }.to change(@notifiable_1, :destroyed?).from(false).to(true)
             expect(user_target.notifications.filtered_by_instance(@notifiable_1).count).to eq(0)
             expect(dummy_target.notifications.filtered_by_instance(@notifiable_1).count).to eq(1)
           end
@@ -231,14 +232,14 @@ describe ActivityNotification::ActsAsNotifiable do
           it "destroies all notifications when notifiable is deleted" do
             dummy_notifiable_class.acts_as_notifiable :users, dependent_notifications: :destroy
             expect(user_target.notifications.reload.size).to eq(3)
-            expect { @notifiable_1.destroy }.to change(dummy_notifiable_class, :count).by(-1)
+            expect { @notifiable_1.destroy }.to change(@notifiable_1, :destroyed?).from(false).to(true)
             expect(user_target.notifications.reload.size).to eq(2)
             expect(@group_member.reload.group_owner?).to be_falsey
           end
 
           it "does not destroy notifications of other targets when notifiable is deleted" do
             dummy_notifiable_class.acts_as_notifiable :users, dependent_notifications: :destroy
-            expect { @notifiable_1.destroy }.to change(dummy_notifiable_class, :count).by(-1)
+            expect { @notifiable_1.destroy }.to change(@notifiable_1, :destroyed?).from(false).to(true)
             expect(user_target.notifications.filtered_by_instance(@notifiable_1).count).to eq(0)
             expect(dummy_target.notifications.filtered_by_instance(@notifiable_1).count).to eq(1)
           end
@@ -260,7 +261,8 @@ describe ActivityNotification::ActsAsNotifiable do
           it "can not be deleted when it has generated notifications" do
             dummy_notifiable_class.acts_as_notifiable :users, dependent_notifications: :restrict_with_error
             expect(user_target.notifications.reload.size).to eq(3)
-            expect { @notifiable_1.destroy }.to change(dummy_notifiable_class, :count).by(0)
+            @notifiable_1.destroy
+            expect(@notifiable_1.destroyed?).to be_falsey
           end
         end
 
@@ -268,21 +270,21 @@ describe ActivityNotification::ActsAsNotifiable do
           it "deletes all notifications and update notification group when notifiable is deleted" do
             dummy_notifiable_class.acts_as_notifiable :users, dependent_notifications: :update_group_and_delete_all
             expect(user_target.notifications.reload.size).to eq(3)
-            expect { @notifiable_1.destroy }.to change(dummy_notifiable_class, :count).by(-1)
+            expect { @notifiable_1.destroy }.to change(@notifiable_1, :destroyed?).from(false).to(true)
             expect(user_target.notifications.reload.size).to eq(2)
             expect(@group_member.reload.group_owner?).to be_truthy
           end
 
           it "does not delete notifications of other targets when notifiable is deleted" do
             dummy_notifiable_class.acts_as_notifiable :users, dependent_notifications: :update_group_and_delete_all
-            expect { @notifiable_1.destroy }.to change(dummy_notifiable_class, :count).by(-1)
+            expect { @notifiable_1.destroy }.to change(@notifiable_1, :destroyed?).from(false).to(true)
             expect(user_target.notifications.filtered_by_instance(@notifiable_1).count).to eq(0)
             expect(dummy_target.notifications.filtered_by_instance(@notifiable_1).count).to eq(1)
           end
 
           it "does not update notification group when notifiable is deleted" do
             dummy_notifiable_class.acts_as_notifiable :users, dependent_notifications: :update_group_and_delete_all
-            expect { @notifiable_1.destroy }.to change(dummy_notifiable_class, :count).by(-1)
+            expect { @notifiable_1.destroy }.to change(@notifiable_1, :destroyed?).from(false).to(true)
             expect(@group_member.reload.group_owner?).to be_truthy
             expect(@other_target_group_member.reload.group_owner?).to be_falsey
           end
@@ -292,21 +294,21 @@ describe ActivityNotification::ActsAsNotifiable do
           it "destroies all notifications and update notification group when notifiable is deleted" do
             dummy_notifiable_class.acts_as_notifiable :users, dependent_notifications: :update_group_and_destroy
             expect(user_target.notifications.reload.size).to eq(3)
-            expect { @notifiable_1.destroy }.to change(dummy_notifiable_class, :count).by(-1)
+            expect { @notifiable_1.destroy }.to change(@notifiable_1, :destroyed?).from(false).to(true)
             expect(user_target.notifications.reload.size).to eq(2)
             expect(@group_member.reload.group_owner?).to be_truthy
           end
 
           it "does not destroy notifications of other targets when notifiable is deleted" do
             dummy_notifiable_class.acts_as_notifiable :users, dependent_notifications: :update_group_and_destroy
-            expect { @notifiable_1.destroy }.to change(dummy_notifiable_class, :count).by(-1)
+            expect { @notifiable_1.destroy }.to change(@notifiable_1, :destroyed?).from(false).to(true)
             expect(user_target.notifications.filtered_by_instance(@notifiable_1).count).to eq(0)
             expect(dummy_target.notifications.filtered_by_instance(@notifiable_1).count).to eq(1)
           end
 
           it "does not update notification group when notifiable is deleted" do
             dummy_notifiable_class.acts_as_notifiable :users, dependent_notifications: :update_group_and_destroy
-            expect { @notifiable_1.destroy }.to change(dummy_notifiable_class, :count).by(-1)
+            expect { @notifiable_1.destroy }.to change(@notifiable_1, :destroyed?).from(false).to(true)
             expect(@group_member.reload.group_owner?).to be_truthy
             expect(@other_target_group_member.reload.group_owner?).to be_falsey
           end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activity_notification
 version: !ruby/object:Gem::Version
-  version: 1.4.4
+  version: 1.5.0
 platform: ruby
 authors:
 - Shota Yamazaki
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-11-18 00:00:00.000000000 Z
+date: 2018-05-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties
@@ -19,7 +19,7 @@ dependencies:
         version: 4.2.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: '5.2'
+        version: '5.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -29,7 +29,7 @@ dependencies:
         version: 4.2.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: '5.2'
+        version: '5.3'
 - !ruby/object:Gem::Dependency
   name: i18n
   requirement: !ruby/object:Gem::Requirement
@@ -78,28 +78,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.4.10
+        version: 0.5.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.4.10
+        version: 0.5.1
 - !ruby/object:Gem::Dependency
   name: pg
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.21.0
+        version: 1.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.21.0
+        version: 1.0.0
 - !ruby/object:Gem::Dependency
   name: mongoid
   requirement: !ruby/object:Gem::Requirement
@@ -120,14 +120,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.7.1
+        version: 3.7.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.7.1
+        version: 3.7.2
 - !ruby/object:Gem::Dependency
   name: factory_bot_rails
   requirement: !ruby/object:Gem::Requirement
@@ -162,14 +162,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.9
+        version: 0.9.12
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.9
+        version: 0.9.12
 - !ruby/object:Gem::Dependency
   name: yard-activesupport-concern
   requirement: !ruby/object:Gem::Requirement
@@ -190,14 +190,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.3.0
+        version: 4.4.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.3.0
+        version: 4.4.3
 - !ruby/object:Gem::Dependency
   name: aws-sdk-sns
   requirement: !ruby/object:Gem::Requirement
@@ -288,6 +288,8 @@ files:
 - gemfiles/Gemfile.rails-5.0.lock
 - gemfiles/Gemfile.rails-5.1
 - gemfiles/Gemfile.rails-5.1.lock
+- gemfiles/Gemfile.rails-5.2
+- gemfiles/Gemfile.rails-5.2.lock
 - lib/activity_notification.rb
 - lib/activity_notification/apis/notification_api.rb
 - lib/activity_notification/apis/subscription_api.rb
@@ -343,6 +345,7 @@ files:
 - lib/generators/templates/models/notification.rb
 - lib/generators/templates/models/subscription.rb
 - lib/tasks/activity_notification_tasks.rake
+- scripts/bundle_update.sh
 - spec/concerns/apis/notification_api_spec.rb
 - spec/concerns/apis/subscription_api_spec.rb
 - spec/concerns/common_spec.rb