activity_notification 1.2.1 → 1.3.0

data/lib/activity_notification/orm/mongoid/subscription.rb

@@ -0,0 +1,73 @@
+require 'mongoid'
+require 'activity_notification/apis/subscription_api'
+
+module ActivityNotification
+  module ORM
+    module Mongoid
+      # Subscription model implementation generated by ActivityNotification.
+      class Subscription
+        include ::Mongoid::Document
+        include ::Mongoid::Timestamps
+        include ::Mongoid::Attributes::Dynamic
+        include Association
+        include SubscriptionApi
+        store_in collection: ActivityNotification.config.subscription_table_name
+
+        # Belongs to target instance of this subscription as polymorphic association.
+        # @scope instance
+        # @return [Object] Target instance of this subscription
+        belongs_to_polymorphic_xdb_record :target
+
+        field :key,                       type: String
+        field :subscribing,               type: Boolean, default: ActivityNotification.config.subscribe_as_default
+        field :subscribing_to_email,      type: Boolean, default: ActivityNotification.config.subscribe_as_default
+        field :subscribed_at,             type: DateTime
+        field :unsubscribed_at,           type: DateTime
+        field :subscribed_to_email_at,    type: DateTime
+        field :unsubscribed_to_email_at,  type: DateTime
+        field :optional_targets,          type: Hash,    default: {}
+    
+        validates  :target,               presence: true
+        validates  :key,                  presence: true
+        validates_inclusion_of :subscribing,          in: [true, false]
+        validates_inclusion_of :subscribing_to_email, in: [true, false]
+        validate   :subscribing_to_email_cannot_be_true_when_subscribing_is_false
+        validates  :subscribed_at,            presence: true, if:     :subscribing
+        validates  :unsubscribed_at,          presence: true, unless: :subscribing
+        validates  :subscribed_to_email_at,   presence: true, if:     :subscribing_to_email
+        validates  :unsubscribed_to_email_at, presence: true, unless: :subscribing_to_email
+        validate   :subscribing_to_optional_target_cannot_be_true_when_subscribing_is_false
+
+        # Selects filtered subscriptions by type of the object.
+        # Filtering with ActivityNotification::Subscription is defined as default scope.
+        # @return [Mongoid::Criteria<Subscription>] Database query of filtered subscriptions
+        default_scope -> { where(_type: "ActivityNotification::Subscription") }
+
+        # Selects filtered subscriptions by target instance.
+        #   ActivityNotification::Subscription.filtered_by_target(@user)
+        # is the same as
+        #   @user.subscriptions
+        # @scope class
+        # @param [Object] target Target instance for filter
+        # @return [Mongoid::Criteria<Subscription>] Database query of filtered subscriptions
+        scope :filtered_by_target,  ->(target) { target.present? ? where(target_id: target.id, target_type: target.class.name) : none }
+
+        # Includes target instance with query for subscriptions.
+        # @return [Mongoid::Criteria<Subscription>] Database query of subscriptions with target
+        scope :with_target,               -> { }
+
+        # Dummy reload method for test of subscriptions.
+        scope :reload,                    -> { }
+
+        # Selects unique keys from query for subscriptions.
+        # @return [Array<String>] Array of subscription unique keys
+        def self.uniq_keys
+          # distinct method cannot keep original sort
+          # distinct(:key)
+          pluck(:key).uniq
+        end
+
+      end
+    end
+  end
+end

data/lib/activity_notification/rails/routes.rb

@@ -204,16 +204,20 @@ module ActionDispatch::Routing
 
       # Create options fo routing
       # @api private
+      # @todo Check resources if it includes target module
+      # @todo Check devise configuration in model
+      # @todo Support other options like :as, :path_prefix, :path_names ...
+      #
       # @param [Symbol] resource Name of the resource model
       # @return [Boolean] Whether action path is ignored
       def create_options(resource, options = {}, except_actions = [])
-        #TODO check resources if it includes target module
+        # Check resources if it includes target module
         resources_name = resource.to_s.pluralize.underscore
         options[:model] ||= resources_name.to_sym
         if options[:with_devise].present?
           options[:controller] ||= "activity_notification/#{resources_name}_with_devise"
           options[:as]         ||= resources_name
-          #TODO check devise configuration in model
+          # Check devise configuration in model
           options[:devise_defaults] = { devise_type: options[:with_devise].to_s }
         else
           options[:controller] ||= "activity_notification/#{resources_name}"
@@ -224,7 +228,7 @@ module ActionDispatch::Routing
           options[:subscription_option] = (options[:with_subscription].is_a?(Hash) ? options[:with_subscription] : {})
                                             .merge(with_devise: options[:with_devise])
         end
-        #TODO other options like :as, :path_prefix, :path_names ...
+        # Support other options like :as, :path_prefix, :path_names ...
         options
       end
 

data/lib/activity_notification/renderable.rb

@@ -173,7 +173,11 @@ module ActivityNotification
       root ||= "activity_notification/notifications/#{target}" if target.present?
       root ||= controller.target_view_path                     if controller.present? && controller.respond_to?(:target_view_path)
       root ||= 'activity_notification/notifications/default'
-      path ||= self.key.tr('.', '/')
+      template_key = notifiable.respond_to?(:overriding_notification_template_key) &&
+                     notifiable.overriding_notification_template_key(@target, key).present? ?
+                       notifiable.overriding_notification_template_key(@target, key) :
+                       key
+      path ||= template_key.tr('.', '/')
       select_path(path, root)
     end
 

data/lib/activity_notification/roles/acts_as_notifiable.rb

@@ -171,24 +171,21 @@ module ActivityNotification
         if [:delete_all, :destroy, :restrict_with_error, :restrict_with_exception, :update_group_and_delete_all, :update_group_and_destroy].include? options[:dependent_notifications]
           case options[:dependent_notifications]
           when :delete_all, :destroy, :restrict_with_error, :restrict_with_exception
-            has_many_generated_notifications options[:dependent_notifications]
+            before_destroy -> { destroy_generated_notifications_with_dependency(options[:dependent_notifications], target_type) }
           when :update_group_and_delete_all
-            before_destroy :remove_generated_notifications_from_group
-            has_many_generated_notifications :delete_all
+            before_destroy -> { destroy_generated_notifications_with_dependency(:delete_all, target_type, true) }
           when :update_group_and_destroy
-            before_destroy :remove_generated_notifications_from_group
-            has_many_generated_notifications :destroy
+            before_destroy -> { destroy_generated_notifications_with_dependency(:destroy, target_type, true) }
           end
           configured_params = { dependent_notifications: options[:dependent_notifications] }
         end
 
         if options[:optional_targets].is_a?(Hash)
           options[:optional_targets] = options[:optional_targets].map { |target_class, target_options|
-            optional_target = target_class.new
+            optional_target = target_class.new(target_options)
             unless optional_target.kind_of?(ActivityNotification::OptionalTarget::Base)
               raise TypeError, "#{optional_target.class.name} for an optional target is not a kind of ActivityNotification::OptionalTarget::Base"
             end
-            optional_target.initialize_target(target_options)
             optional_target
           }
         end
@@ -215,17 +212,6 @@ module ActivityNotification
         ].freeze
       end
 
-      private
-
-        # Define to have many notification instances for this notifiable with dependent option.
-        # @api private
-        def has_many_generated_notifications(dependent_option)
-          has_many :generated_notifications_as_notifiable,
-            class_name: "::ActivityNotification::Notification",
-            as: :notifiable,
-            dependent: dependent_option
-        end
-
     end
   end
 end

data/lib/activity_notification/version.rb

@@ -1,3 +1,3 @@
 module ActivityNotification
-  VERSION = "1.2.1"
+  VERSION = "1.3.0"
 end

data/lib/generators/activity_notification/install_generator.rb

@@ -13,13 +13,11 @@ module ActivityNotification
 
       # Copies initializer file in application directory
       def copy_initializer
-        #TODO suport other orm e.g. mongoid
-        unless options[:orm] == :active_record
+        unless [:active_record, :mongoid].include?(options[:orm])
           raise TypeError, <<-ERROR.strip_heredoc
-          Currently ActivityNotification is only supported with Active Record ORM.
+          Currently ActivityNotification is only supported with ActiveRecord or Mongoid ORM.
 
-          Be sure to have an Active Record ORM loaded in your
-          app or configure your own at `config/application.rb`.
+          Be sure to have an ActiveRecord or MongoidORM loaded in your app or configure your own at `config/application.rb`.
 
             config.generators do |g|
               g.orm :active_record

data/lib/generators/templates/activity_notification.rb

@@ -1,13 +1,18 @@
 ActivityNotification.configure do |config|
 
-  # Configure if all activity notifications are enabled
-  # Set false when you want to turn off activity notifications
+  # Configure ORM name for ActivityNotification.
+  # Set :active_record or :mongoid.
+  ENV['AN_ORM'] = 'active_record' if ENV['AN_ORM'] != 'mongoid'
+  config.orm = ENV['AN_ORM']
+
+  # Configure if all activity notifications are enabled.
+  # Set false when you want to turn off activity notifications.
   config.enabled = true
 
-  # Configure table name to store notification data
+  # Configure table name to store notification data.
   config.notification_table_name = "notifications"
 
-  # Configure table name to store subscription data
+  # Configure table name to store subscription data.
   config.subscription_table_name = "subscriptions"
 
   # Configure if email notification is enabled as default.

data/spec/concerns/apis/notification_api_spec.rb

@@ -11,7 +11,6 @@ shared_examples_for :notification_api do
 
   describe "as public class methods" do
     before do
-      described_class.delete_all
       @author_user = create(:confirmed_user)
       @user_1      = create(:confirmed_user)
       @user_2      = create(:confirmed_user)
@@ -217,7 +216,7 @@ shared_examples_for :notification_api do
           end
 
           it "has parameters of parameters in acts_as_notifiable" do
-            expect(created_notification.parameters).to eq({test_default_param: '1'})
+            expect(created_notification.parameters).to eq({'test_default_param' => '1'})
           end
         end
 
@@ -517,7 +516,7 @@ shared_examples_for :notification_api do
     describe "#publish_to_optional_targets" do
       before do
         require 'custom_optional_targets/console_output'
-        @optional_target = CustomOptionalTarget::ConsoleOutput.new
+        @optional_target = CustomOptionalTarget::ConsoleOutput.new(console_out: false)
         notifiable_class.acts_as_notifiable test_instance.target.to_resources_name.to_sym, optional_targets: ->{ [@optional_target] }
         expect(test_instance.notifiable.optional_targets(test_instance.target.to_resources_name, test_instance.key)).to eq([@optional_target])
       end
@@ -556,16 +555,13 @@ shared_examples_for :notification_api do
     end
 
     describe "#open!" do
-      before do
-        described_class.delete_all
-      end
-
       it "returns the number of opened notification records" do
         expect(test_instance.open!).to eq(1)
       end
 
       it "returns the number of opened notification records including group members" do
-        create(test_class_name, group_owner: test_instance, opened_at: nil)
+        group_member = create(test_class_name, group_owner: test_instance)
+        expect(group_member.opened_at.blank?).to be_truthy
         expect(test_instance.open!).to eq(2)
       end
 
@@ -856,23 +852,39 @@ shared_examples_for :notification_api do
 
         context "with limit" do
           context "when the notification is group owner and has group members" do
-            it "returns member count by limit" do
+            it "returns member count by limit 0" do
               create(test_class_name, target: test_instance.target, group_owner: test_instance)
               create(test_class_name, target: test_instance.target, group_owner: test_instance)
               test_instance.open!
               expect(test_instance.group_member_count(0)).to eq(0)
               expect(test_instance.group_notification_count(0)).to eq(1)
             end
+
+            it "returns member count by limit 1" do
+              create(test_class_name, target: test_instance.target, group_owner: test_instance)
+              create(test_class_name, target: test_instance.target, group_owner: test_instance)
+              test_instance.open!
+              expect(test_instance.group_member_count(1)).to eq(1)
+              expect(test_instance.group_notification_count(1)).to eq(2)
+            end
           end
 
           context "when the notification belongs to group" do
-            it "returns member count by limit" do
+            it "returns member count by limit 0" do
               group_member = create(test_class_name, target: test_instance.target, group_owner: test_instance)
                              create(test_class_name, target: test_instance.target, group_owner: test_instance)
               test_instance.open!
               expect(group_member.group_member_count(0)).to eq(0)
               expect(group_member.group_notification_count(0)).to eq(1)
             end
+
+            it "returns member count by limit 1" do
+              group_member = create(test_class_name, target: test_instance.target, group_owner: test_instance)
+                             create(test_class_name, target: test_instance.target, group_owner: test_instance)
+              test_instance.open!
+              expect(group_member.group_member_count(1)).to eq(1)
+              expect(group_member.group_notification_count(1)).to eq(2)
+            end
           end
         end
       end
@@ -1135,7 +1147,7 @@ shared_examples_for :notification_api do
         it "returns latest group member" do
           member1 = create(test_class_name, target: test_instance.target, group_owner: test_instance)
           member2 = create(test_class_name, target: test_instance.target, group_owner: test_instance)
-          expect(test_instance.latest_group_member).to eq(member2)
+          expect(test_instance.latest_group_member.becomes(ActivityNotification::Notification)).to eq(member2)
         end
       end
 
@@ -1161,12 +1173,13 @@ shared_examples_for :notification_api do
 
       it "makes a new group owner" do
         test_instance.remove_from_group
-        expect(@member1.reload.group_owner?).to     be_truthy
-        expect(@member1.group_members).to           eq([@member2])
+        expect(@member1.reload.group_owner?).to                                             be_truthy
+        expect(@member1.group_members.size).to                                              eq(1)
+        expect(@member1.group_members.first.becomes(ActivityNotification::Notification)).to eq(@member2)
       end
 
       it "returns new group owner instance" do
-        expect(test_instance.remove_from_group).to eq(@member1)
+        expect(test_instance.remove_from_group.becomes(ActivityNotification::Notification)).to eq(@member1)
       end
     end
 

data/spec/concerns/models/notifiable_spec.rb

@@ -521,25 +521,26 @@ shared_examples_for :notifiable do
 
         it "returns specified symbol of method" do
           module AdditionalMethods
+            require 'custom_optional_targets/console_output'
             def custom_optional_targets
-              [ActivityNotification::OptionalTarget::Base.new]
+              [CustomOptionalTarget::ConsoleOutput.new]
             end
           end
           test_instance.extend(AdditionalMethods)
           described_class._optional_targets[:users] = :custom_optional_targets
           expect(test_instance.optional_targets(User, 'dummy_key').size).to  eq(1)
-          expect(test_instance.optional_targets(User, 'dummy_key').first).to be_a(ActivityNotification::OptionalTarget::Base)
+          expect(test_instance.optional_targets(User, 'dummy_key').first).to be_a(CustomOptionalTarget::ConsoleOutput)
         end
 
         it "returns specified lambda with no arguments" do
-          described_class._optional_targets[:users] = ->{ [ActivityNotification::OptionalTarget::Base.new] }
-          expect(test_instance.optional_targets(User, 'dummy_key').first).to be_a(ActivityNotification::OptionalTarget::Base)
+          described_class._optional_targets[:users] = ->{ [CustomOptionalTarget::ConsoleOutput.new] }
+          expect(test_instance.optional_targets(User, 'dummy_key').first).to be_a(CustomOptionalTarget::ConsoleOutput)
         end
 
         it "returns specified lambda with notifiable and key argument" do
-          described_class._optional_targets[:users] = ->(notifiable, key){ key == 'dummy_key' ? [ActivityNotification::OptionalTarget::Base.new] : [] }
+          described_class._optional_targets[:users] = ->(notifiable, key){ key == 'dummy_key' ? [CustomOptionalTarget::ConsoleOutput.new] : [] }
           expect(test_instance.optional_targets(User)).to eq([])
-          expect(test_instance.optional_targets(User, 'dummy_key').first).to be_a(ActivityNotification::OptionalTarget::Base)
+          expect(test_instance.optional_targets(User, 'dummy_key').first).to be_a(CustomOptionalTarget::ConsoleOutput)
         end
       end
     end
@@ -565,13 +566,14 @@ shared_examples_for :notifiable do
 
         it "returns specified symbol of method" do
           module AdditionalMethods
+            require 'custom_optional_targets/console_output'
             def custom_optional_targets
-              [ActivityNotification::OptionalTarget::Base.new]
+              [CustomOptionalTarget::ConsoleOutput.new]
             end
           end
           test_instance.extend(AdditionalMethods)
           described_class._optional_targets[:users] = :custom_optional_targets
-          expect(test_instance.optional_target_names(User, 'dummy_key')).to eq([:base])
+          expect(test_instance.optional_target_names(User, 'dummy_key')).to eq([:console_output])
         end
 
         it "returns specified lambda with no arguments" do

data/spec/concerns/models/subscriber_spec.rb

@@ -12,10 +12,10 @@ shared_examples_for :subscriber do
     it "has many subscriptions" do
       subscription_1 = create(:subscription, target: test_instance, key: 'subscription_key_1')
       subscription_2 = create(:subscription, target: test_instance, key: 'subscription_key_2')
-      expect(test_instance.subscriptions.count).to    eq(2)
+      expect(test_instance.subscriptions.count).to                eq(2)
       expect(test_instance.subscriptions.earliest_order.first).to eq(subscription_1)
       expect(test_instance.subscriptions.latest_order.first).to   eq(subscription_2)
-      expect(test_instance.subscriptions).to eq(ActivityNotification::Subscription.filtered_by_target(test_instance))
+      expect(test_instance.subscriptions).to                      eq(ActivityNotification::Subscription.filtered_by_target(test_instance))
     end
   end    
 
@@ -28,10 +28,6 @@ shared_examples_for :subscriber do
   end
 
   describe "as public instance methods" do
-    before do
-      ActivityNotification::Subscription.delete_all
-    end
-
     describe "#find_subscription" do
       before do
         expect(test_instance.subscriptions).to be_empty
@@ -224,9 +220,11 @@ shared_examples_for :subscriber do
 
         context 'with custom_filter options' do
           it "returns filtered notifications only" do
-            options = { custom_filter: ["key = ?", 'subscription_key_2'] }
-            expect(test_instance.subscription_index(options)[0]).to eq(@subscription2)
-            expect(test_instance.subscription_index(options).size).to eq(1)
+            if ActivityNotification.config.orm == :active_record
+              options = { custom_filter: ["key = ?", 'subscription_key_2'] }
+              expect(test_instance.subscription_index(options)[0]).to eq(@subscription2)
+              expect(test_instance.subscription_index(options).size).to eq(1)
+            end
 
             options = { custom_filter: { key: 'subscription_key_1' } }
             expect(test_instance.subscription_index(options)[0]).to eq(@subscription1)
@@ -324,9 +322,11 @@ shared_examples_for :subscriber do
 
         context 'with custom_filter options' do
           it "returns filtered notifications only" do
-            options = { custom_filter: ["key = ?", 'notification_key_2'] }
-            expect(test_instance.notification_keys(options)[0]).to eq('notification_key_2')
-            expect(test_instance.notification_keys(options).size).to eq(1)
+            if ActivityNotification.config.orm == :active_record
+              options = { custom_filter: ["key = ?", 'notification_key_2'] }
+              expect(test_instance.notification_keys(options)[0]).to eq('notification_key_2')
+              expect(test_instance.notification_keys(options).size).to eq(1)
+            end
 
             options = { custom_filter: { key: 'notification_key_1' } }
             expect(test_instance.notification_keys(options)[0]).to eq('notification_key_1')

data/spec/concerns/models/target_spec.rb

@@ -393,10 +393,10 @@ shared_examples_for :target do
 
     describe "#authenticated_with_devise?" do
       context "without any configuration" do
-        context "when the current devise resource and called target are defferent class instance" do
+        context "when the current devise resource and called target are different class instance" do
           it "raises TypeError" do
             expect { test_instance.authenticated_with_devise?(test_notifiable) }
-              .to raise_error(TypeError, /Defferent type of .+ has been passed to .+ You have to override .+ /)
+              .to raise_error(TypeError, /Different type of .+ has been passed to .+ You have to override .+ /)
           end
         end
   
@@ -414,11 +414,11 @@ shared_examples_for :target do
       end
 
       context "configured with a field" do
-        context "when the current devise resource and called target are defferent class instance" do
+        context "when the current devise resource and called target are different class instance" do
           it "raises TypeError" do
             described_class._notification_devise_resource = test_notifiable
             expect { test_instance.authenticated_with_devise?(test_instance) }
-              .to raise_error(TypeError, /Defferent type of .+ has been passed to .+ You have to override .+ /)
+              .to raise_error(TypeError, /Different type of .+ has been passed to .+ You have to override .+ /)
           end
         end
   
@@ -614,9 +614,11 @@ shared_examples_for :target do
 
         context 'with custom_filter options' do
           it "returns filtered notifications only" do
-            options = { custom_filter: ["key = ?", @key] }
-            expect(test_instance.notification_index(options)[0]).to eq(@notification3)
-            expect(test_instance.notification_index(options).size).to eq(1)
+            if ActivityNotification.config.orm == :active_record
+              options = { custom_filter: ["key = ?", @key] }
+              expect(test_instance.notification_index(options)[0]).to eq(@notification3)
+              expect(test_instance.notification_index(options).size).to eq(1)
+            end
 
             options = { custom_filter: { key: @key } }
             expect(test_instance.notification_index(options)[0]).to eq(@notification3)
@@ -920,36 +922,40 @@ shared_examples_for :target do
             create(:notification, target: test_instance)
             create(:notification, target: test_instance)
           end
-  
-          it "calls with_target, with_notifiable and with_notifier" do
-            expect(ActiveRecord::Base).to receive(:includes).with(:target)
-            expect(ActiveRecord::Base).to receive(:includes).with(:notifiable)
-            expect(ActiveRecord::Base).to receive(:includes).with(:notifier)
-            test_instance.unopened_notification_index_with_attributes
-          end
-  
-          it "does not call with_group" do
-            expect(ActiveRecord::Base).to receive(:includes).with(:target)
-            expect(ActiveRecord::Base).to receive(:includes).with(:notifiable)
-            expect(ActiveRecord::Base).not_to receive(:includes).with(:group)
-            expect(ActiveRecord::Base).to receive(:includes).with(:notifier)
-            test_instance.unopened_notification_index_with_attributes
+
+          if ActivityNotification.config.orm == :active_record
+            it "calls with_target, with_notifiable and with_notifier" do
+              expect(ActiveRecord::Base).to receive(:includes).with(:target)
+              expect(ActiveRecord::Base).to receive(:includes).with(:notifiable)
+              expect(ActiveRecord::Base).to receive(:includes).with(:notifier)
+              test_instance.unopened_notification_index_with_attributes
+            end
+
+            it "does not call with_group" do
+              expect(ActiveRecord::Base).to receive(:includes).with(:target)
+              expect(ActiveRecord::Base).to receive(:includes).with(:notifiable)
+              expect(ActiveRecord::Base).not_to receive(:includes).with(:group)
+              expect(ActiveRecord::Base).to receive(:includes).with(:notifier)
+              test_instance.unopened_notification_index_with_attributes
+            end
           end
         end
-  
+
         context "with group members" do
           before do
             group_owner  = create(:notification, target: test_instance, group_owner: nil)
                            create(:notification, target: test_instance, group_owner: nil)
             group_member = create(:notification, target: test_instance, group_owner: group_owner)
           end
-  
-          it "calls with_group" do
-            expect(ActiveRecord::Base).to receive(:includes).with(:target)
-            expect(ActiveRecord::Base).to receive(:includes).with(:notifiable)
-            expect(ActiveRecord::Base).to receive(:includes).with(:group)
-            expect(ActiveRecord::Base).to receive(:includes).with(:notifier)
-            test_instance.unopened_notification_index_with_attributes
+
+          if ActivityNotification.config.orm == :active_record
+            it "calls with_group" do
+              expect(ActiveRecord::Base).to receive(:includes).with(:target)
+              expect(ActiveRecord::Base).to receive(:includes).with(:notifiable)
+              expect(ActiveRecord::Base).to receive(:includes).with(:group)
+              expect(ActiveRecord::Base).to receive(:includes).with(:notifier)
+              test_instance.unopened_notification_index_with_attributes
+            end
           end
         end
       end
@@ -978,36 +984,40 @@ shared_examples_for :target do
             create(:notification, target: test_instance, opened_at: Time.current)
             create(:notification, target: test_instance, opened_at: Time.current)
           end
-  
-          it "calls with_target, with_notifiable and with_notifier" do
-            expect(ActiveRecord::Base).to receive(:includes).with(:target)
-            expect(ActiveRecord::Base).to receive(:includes).with(:notifiable)
-            expect(ActiveRecord::Base).to receive(:includes).with(:notifier)
-            test_instance.opened_notification_index_with_attributes
-          end
-  
-          it "does not call with_group" do
-            expect(ActiveRecord::Base).to receive(:includes).with(:target)
-            expect(ActiveRecord::Base).to receive(:includes).with(:notifiable)
-            expect(ActiveRecord::Base).not_to receive(:includes).with(:group)
-            expect(ActiveRecord::Base).to receive(:includes).with(:notifier)
-            test_instance.opened_notification_index_with_attributes
+
+          if ActivityNotification.config.orm == :active_record
+            it "calls with_target, with_notifiable and with_notifier" do
+              expect(ActiveRecord::Base).to receive(:includes).with(:target)
+              expect(ActiveRecord::Base).to receive(:includes).with(:notifiable)
+              expect(ActiveRecord::Base).to receive(:includes).with(:notifier)
+              test_instance.opened_notification_index_with_attributes
+            end
+
+            it "does not call with_group" do
+              expect(ActiveRecord::Base).to receive(:includes).with(:target)
+              expect(ActiveRecord::Base).to receive(:includes).with(:notifiable)
+              expect(ActiveRecord::Base).not_to receive(:includes).with(:group)
+              expect(ActiveRecord::Base).to receive(:includes).with(:notifier)
+              test_instance.opened_notification_index_with_attributes
+            end
           end
         end
-  
+
         context "with group members" do
           before do
             group_owner  = create(:notification, target: test_instance, group_owner: nil, opened_at: Time.current)
                            create(:notification, target: test_instance, group_owner: nil, opened_at: Time.current)
             group_member = create(:notification, target: test_instance, group_owner: group_owner, opened_at: Time.current)
           end
-  
-          it "calls with_group" do
-            expect(ActiveRecord::Base).to receive(:includes).with(:target)
-            expect(ActiveRecord::Base).to receive(:includes).with(:notifiable)
-            expect(ActiveRecord::Base).to receive(:includes).with(:group)
-            expect(ActiveRecord::Base).to receive(:includes).with(:notifier)
-            test_instance.opened_notification_index_with_attributes
+
+          if ActivityNotification.config.orm == :active_record
+            it "calls with_group" do
+              expect(ActiveRecord::Base).to receive(:includes).with(:target)
+              expect(ActiveRecord::Base).to receive(:includes).with(:notifiable)
+              expect(ActiveRecord::Base).to receive(:includes).with(:group)
+              expect(ActiveRecord::Base).to receive(:includes).with(:notifier)
+              test_instance.opened_notification_index_with_attributes
+            end
           end
         end
       end