activity_notification 1.0.2 → 1.1.0

data/spec/controllers/subscriptions_controller_spec.rb

@@ -0,0 +1,12 @@
+require 'controllers/subscriptions_controller_shared_examples'
+
+describe ActivityNotification::SubscriptionsController, type: :controller do
+  let(:test_target)        { create(:user) }
+  let(:target_type)        { :users }
+  let(:typed_target_param) { :user_id }
+  let(:extra_params)       { {} }
+  let(:valid_session)      {}
+
+  it_behaves_like :subscription_controller
+
+end

data/spec/controllers/subscriptions_with_devise_controller_spec.rb

@@ -0,0 +1,91 @@
+require 'controllers/subscriptions_controller_shared_examples'
+
+describe ActivityNotification::SubscriptionsWithDeviseController, type: :controller do
+  let(:test_user)            { create(:confirmed_user) }
+  let(:unauthenticated_user) { create(:confirmed_user) }
+  let(:test_target)          { create(:admin, user: test_user) }
+  let(:target_type)          { :admins }
+  let(:typed_target_param)   { :admin_id }
+  let(:extra_params)         { { devise_type: :users } }
+  let(:valid_session)        {}
+
+  context "signed in with devise as authenticated user" do
+    before do
+      sign_in test_user
+    end
+  
+    it_behaves_like :subscription_controller
+  end
+
+  context "signed in with devise as unauthenticated user" do
+    let(:target_params) { { target_type: target_type, devise_type: :users } }
+
+    describe "GET #index" do
+      before do
+        sign_in unauthenticated_user
+        get_with_compatibility :index, target_params.merge({ typed_target_param => test_target }), valid_session
+      end
+  
+      it "returns 403 as http status code" do
+        expect(response.status).to eq(403)
+      end
+    end
+  end
+
+  context "unsigned in with devise" do
+    let(:target_params) { { target_type: target_type, devise_type: :users } }
+
+    describe "GET #index" do
+      before do
+        get_with_compatibility :index, target_params.merge({ typed_target_param => test_target }), valid_session
+      end
+  
+      it "returns 302 as http status code" do
+        expect(response.status).to eq(302)
+      end
+
+      it "redirects to sign_in path" do
+        expect(response).to redirect_to new_user_session_path
+      end
+    end
+  end
+
+  context "without devise_type parameter" do
+    let(:target_params) { { target_type: target_type } }
+
+    describe "GET #index" do
+      before do
+        get_with_compatibility :index, target_params.merge({ typed_target_param => test_target }), valid_session
+      end
+  
+      it "returns 400 as http status code" do
+        expect(response.status).to eq(400)
+      end
+    end
+  end
+
+  context "with wrong devise_type parameter" do
+    let(:target_params) { { target_type: target_type, devise_type: :dummy_targets } }
+
+    describe "GET #index" do
+      before do
+        get_with_compatibility :index, target_params.merge({ typed_target_param => test_target }), valid_session
+      end
+  
+      it "returns 403 as http status code" do
+        expect(response.status).to eq(403)
+      end
+    end
+  end
+
+  private
+
+    def get_with_compatibility action, params, session
+      if Rails::VERSION::MAJOR <= 4
+        get action, params, session
+      else
+        get action, params: params, session: session
+      end
+    end
+
+end

data/spec/factories/dummy/dummy_subscriber.rb

@@ -0,0 +1,4 @@
+FactoryGirl.define do
+  factory :dummy_subscriber, class: Dummy::DummySubscriber do
+  end
+end

data/spec/factories/subscriptions.rb

@@ -0,0 +1,8 @@
+FactoryGirl.define do
+  factory :subscription, class: ActivityNotification::Subscription do
+    association :target, factory: :confirmed_user
+    key "default.default"
+    subscribed_at Time.current
+    subscribed_to_email_at Time.current
+  end
+end

data/spec/generators/controllers_generator_spec.rb

@@ -38,11 +38,23 @@ describe ActivityNotification::Generators::ControllersGenerator, type: :generato
           it { is_expected.to exist }
           it { is_expected.to contain(/class Users::NotificationsWithDeviseController < ActivityNotification::NotificationsWithDeviseController/) }
         end
+
+        describe 'the subscriptions_controller' do
+          subject { file('app/controllers/users/subscriptions_controller.rb') }
+          it { is_expected.to exist }
+          it { is_expected.to contain(/class Users::SubscriptionsController < ActivityNotification::SubscriptionsController/) }
+        end
+
+        describe 'the subscriptions_with_devise_controller' do
+          subject { file('app/controllers/users/subscriptions_with_devise_controller.rb') }
+          it { is_expected.to exist }
+          it { is_expected.to contain(/class Users::SubscriptionsWithDeviseController < ActivityNotification::SubscriptionsWithDeviseController/) }
+        end
       end
 
-      context 'with a controllers option as notifications' do
+      context 'with a controllers option as notifications and subscriptions' do
         before do
-          run_generator %w(users --controllers notifications)
+          run_generator %w(users --controllers notifications subscriptions)
         end
 
         describe 'the notifications_controller' do
@@ -55,6 +67,17 @@ describe ActivityNotification::Generators::ControllersGenerator, type: :generato
           subject { file('app/controllers/users/notifications_with_devise_controller.rb') }
           it { is_expected.not_to exist }
         end
+
+        describe 'the subscriptions_controller' do
+          subject { file('app/controllers/users/subscriptions_controller.rb') }
+          it { is_expected.to exist }
+          it { is_expected.to contain(/class Users::SubscriptionsController < ActivityNotification::SubscriptionsController/) }
+        end
+
+        describe 'the subscriptions_with_devise_controller' do
+          subject { file('app/controllers/users/subscriptions_with_devise_controller.rb') }
+          it { is_expected.not_to exist }
+        end
       end
     end
 

data/spec/generators/migration/migration_generator_spec.rb

@@ -19,15 +19,15 @@ describe ActivityNotification::Generators::MigrationGenerator, type: :generator
       end
 
       describe 'CreateNotifications migration file' do
-        subject { file(Dir["tmp/db/migrate/*_create_notifications.rb"].first.gsub!('tmp/', '')) }
+        subject { file(Dir["tmp/db/migrate/*_create_activity_notification_tables.rb"].first.gsub!('tmp/', '')) }
         it { is_expected.to exist }
-        it { is_expected.to contain(/class CreateNotifications < ActiveRecord::Migration/) }
+        it { is_expected.to contain(/class CreateActivityNotificationTables < ActiveRecord::Migration/) }
       end
     end
 
     context 'with CreateCustomNotifications as name argument' do
       before do
-        run_generator %w(CreateCustomNotifications)
+        run_generator %w(CreateCustomNotifications --tables notifications)
       end
 
       describe 'CreateCustomNotifications migration file' do

data/spec/generators/models_generator_spec.rb

@@ -0,0 +1,96 @@
+require 'generators/activity_notification/models_generator'
+
+describe ActivityNotification::Generators::ModelsGenerator, type: :generator do
+
+  # setup_default_destination
+  destination File.expand_path("../../../tmp", __FILE__)
+  before { prepare_destination }
+
+  it 'runs generating model tasks' do
+    gen = generator %w(users)
+    expect(gen).to receive :create_models
+    expect(gen).to receive(:readme).and_return(true)
+    gen.invoke_all
+  end
+
+  describe 'the generated files' do
+    context 'without target argument' do
+      it 'raises Thor::RequiredArgumentMissingError' do
+        expect { run_generator }
+        .to raise_error(Thor::RequiredArgumentMissingError)
+      end
+    end
+
+    context 'with users as target' do
+      context 'with target models as default' do
+        before do
+          run_generator %w(users)
+        end
+
+        describe 'the notification' do
+          subject { file('app/models/users/notification.rb') }
+          it { is_expected.to exist }
+          it { is_expected.to contain(/class Users::Notification < ActivityNotification::Notification/) }
+        end
+
+        describe 'the subscription' do
+          subject { file('app/models/users/subscription.rb') }
+          it { is_expected.to exist }
+          it { is_expected.to contain(/class Users::Subscription < ActivityNotification::Subscription/) }
+        end
+      end
+
+      context 'with a models option as notification' do
+        before do
+          run_generator %w(users --models notification)
+        end
+
+        describe 'the notification' do
+          subject { file('app/models/users/notification.rb') }
+          it { is_expected.to exist }
+          it { is_expected.to contain(/class Users::Notification < ActivityNotification::Notification/) }
+        end
+
+        describe 'the subscription' do
+          subject { file('app/models/users/subscription.rb') }
+          it { is_expected.not_to exist }
+        end
+      end
+
+      context 'with a names option as custom_notification and custom_subscription' do
+        before do
+          run_generator %w(users --names custom_notification custom_subscription)
+        end
+
+        describe 'the notification' do
+          subject { file('app/models/users/custom_notification.rb') }
+          it { is_expected.to exist }
+          it { is_expected.to contain(/class Users::CustomNotification < ActivityNotification::Notification/) }
+        end
+
+        describe 'the subscription' do
+          subject { file('app/models/users/custom_subscription.rb') }
+          it { is_expected.to exist }
+          it { is_expected.to contain(/class Users::CustomSubscription < ActivityNotification::Subscription/) }
+        end
+      end
+
+      context 'with a models option as notification and a names option as custom_notification' do
+        before do
+          run_generator %w(users --models notification --names custom_notification)
+        end
+
+        describe 'the notification' do
+          subject { file('app/models/users/custom_notification.rb') }
+          it { is_expected.to exist }
+          it { is_expected.to contain(/class Users::CustomNotification < ActivityNotification::Notification/) }
+        end
+
+        describe 'the subscription' do
+          subject { file('app/models/users/subscription.rb') }
+          it { is_expected.not_to exist }
+        end
+      end
+    end
+  end
+end

data/spec/generators/views_generator_spec.rb

@@ -57,10 +57,87 @@ describe ActivityNotification::Generators::ViewsGenerator, type: :generator do
         end
 
         describe 'the mailer views' do
+          describe 'default/batch_default.html.erb' do
+            subject { file('app/views/activity_notification/mailer/default/batch_default.html.erb') }
+            it { is_expected.to exist }
+          end
+
+          describe 'default/batch_default.text.erb' do
+            subject { file('app/views/activity_notification/mailer/default/batch_default.text.erb') }
+            it { is_expected.to exist }
+          end
+
           describe 'default/default.html.erb' do
             subject { file('app/views/activity_notification/mailer/default/default.html.erb') }
             it { is_expected.to exist }
           end
+
+          describe 'default/default.text.erb' do
+            subject { file('app/views/activity_notification/mailer/default/default.text.erb') }
+            it { is_expected.to exist }
+          end
+        end
+
+        describe 'the subscription views' do
+          describe 'default/_form.html.erb' do
+            subject { file('app/views/activity_notification/subscriptions/default/_form.html.erb') }
+            it { is_expected.to exist }
+          end
+
+          describe 'default/_notification_keys.html.erb' do
+            subject { file('app/views/activity_notification/subscriptions/default/_notification_keys.html.erb') }
+            it { is_expected.to exist }
+          end
+
+          describe 'default/_subscription.html.erb' do
+            subject { file('app/views/activity_notification/subscriptions/default/_subscription.html.erb') }
+            it { is_expected.to exist }
+          end
+
+          describe 'default/_subscriptions.html.erb' do
+            subject { file('app/views/activity_notification/subscriptions/default/_subscriptions.html.erb') }
+            it { is_expected.to exist }
+          end
+
+          describe 'default/create.js.erb' do
+            subject { file('app/views/activity_notification/subscriptions/default/create.js.erb') }
+            it { is_expected.to exist }
+          end
+
+          describe 'default/destroy.js.erb' do
+            subject { file('app/views/activity_notification/subscriptions/default/destroy.js.erb') }
+            it { is_expected.to exist }
+          end
+
+          describe 'default/index.html.erb' do
+            subject { file('app/views/activity_notification/subscriptions/default/index.html.erb') }
+            it { is_expected.to exist }
+          end
+
+          describe 'default/show.html.erb' do
+            subject { file('app/views/activity_notification/subscriptions/default/show.html.erb') }
+            it { is_expected.to exist }
+          end
+
+          describe 'default/subscribe_to_email.js.erb' do
+            subject { file('app/views/activity_notification/subscriptions/default/subscribe_to_email.js.erb') }
+            it { is_expected.to exist }
+          end
+
+          describe 'default/subscribe.js.erb' do
+            subject { file('app/views/activity_notification/subscriptions/default/subscribe.js.erb') }
+            it { is_expected.to exist }
+          end
+
+          describe 'default/unsubscribe_to_email.js.erb' do
+            subject { file('app/views/activity_notification/subscriptions/default/unsubscribe_to_email.js.erb') }
+            it { is_expected.to exist }
+          end
+
+          describe 'default/unsubscribe.js.erb' do
+            subject { file('app/views/activity_notification/subscriptions/default/unsubscribe.js.erb') }
+            it { is_expected.to exist }
+          end
         end
       end
 
@@ -104,6 +181,13 @@ describe ActivityNotification::Generators::ViewsGenerator, type: :generator do
             it { is_expected.to exist }
           end
         end
+
+        describe 'the subscription views' do
+          describe 'users/index.html.erb' do
+            subject { file('app/views/activity_notification/subscriptions/users/index.html.erb') }
+            it { is_expected.to exist }
+          end
+        end
       end
     end
 

data/spec/helpers/view_helpers_spec.rb

@@ -4,6 +4,9 @@ describe ActivityNotification::ViewHelpers, type: :helper do
     create(:notification, target: create(:confirmed_user))
   }
   let(:target_user)          { notification.target }
+  let(:subscription)         {
+    create(:subscription, target: target_user, key: notification.key)
+  }
   let(:notification_2)       {
     create(:notification, target: create(:confirmed_user))
   }
@@ -304,4 +307,144 @@ describe ActivityNotification::ViewHelpers, type: :helper do
     end
   end
 
+  describe '#subscriptions_path_for' do
+    it "returns path for the subscription target" do
+      expect(subscriptions_path_for(target_user))
+        .to eq(user_subscriptions_path(target_user))
+    end
+  end
+
+  describe '#subscription_path_for' do
+    it "returns path for the subscription target" do
+      expect(subscription_path_for(subscription))
+        .to eq(user_subscription_path(target_user, subscription))
+    end
+  end
+
+  describe '#subscribe_subscription_path_for' do
+    it "returns path for the subscription target" do
+      expect(subscribe_subscription_path_for(subscription))
+        .to eq(subscribe_user_subscription_path(target_user, subscription))
+    end
+  end
+
+  describe '#subscribe_path_for' do
+    it "returns path for the subscription target" do
+      expect(subscribe_path_for(subscription))
+        .to eq(subscribe_user_subscription_path(target_user, subscription))
+    end
+  end
+
+  describe '#unsubscribe_subscription_path_for' do
+    it "returns path for the subscription target" do
+      expect(unsubscribe_subscription_path_for(subscription))
+        .to eq(unsubscribe_user_subscription_path(target_user, subscription))
+    end
+  end
+
+  describe '#unsubscribe_path_for' do
+    it "returns path for the subscription target" do
+      expect(unsubscribe_path_for(subscription))
+        .to eq(unsubscribe_user_subscription_path(target_user, subscription))
+    end
+  end
+
+  describe '#subscribe_to_email_subscription_path_for' do
+    it "returns path for the subscription target" do
+      expect(subscribe_to_email_subscription_path_for(subscription))
+        .to eq(subscribe_to_email_user_subscription_path(target_user, subscription))
+    end
+  end
+
+  describe '#subscribe_to_email_path_for' do
+    it "returns path for the subscription target" do
+      expect(subscribe_to_email_path_for(subscription))
+        .to eq(subscribe_to_email_user_subscription_path(target_user, subscription))
+    end
+  end
+
+  describe '#unsubscribe_to_email_subscription_path_for' do
+    it "returns path for the subscription target" do
+      expect(unsubscribe_to_email_subscription_path_for(subscription))
+        .to eq(unsubscribe_to_email_user_subscription_path(target_user, subscription))
+    end
+  end
+
+  describe '#unsubscribe_to_email_path_for' do
+    it "returns path for the subscription target" do
+      expect(unsubscribe_to_email_path_for(subscription))
+        .to eq(unsubscribe_to_email_user_subscription_path(target_user, subscription))
+    end
+  end
+
+  describe '#subscriptions_url_for' do
+    it "returns url for the subscription target" do
+      expect(subscriptions_url_for(target_user))
+        .to eq(user_subscriptions_url(target_user))
+    end
+  end
+
+  describe '#subscription_url_for' do
+    it "returns url for the subscription target" do
+      expect(subscription_url_for(subscription))
+        .to eq(user_subscription_url(target_user, subscription))
+    end
+  end
+
+  describe '#subscribe_subscription_url_for' do
+    it "returns url for the subscription target" do
+      expect(subscribe_subscription_url_for(subscription))
+        .to eq(subscribe_user_subscription_url(target_user, subscription))
+    end
+  end
+
+  describe '#subscribe_url_for' do
+    it "returns url for the subscription target" do
+      expect(subscribe_url_for(subscription))
+        .to eq(subscribe_user_subscription_url(target_user, subscription))
+    end
+  end
+
+  describe '#unsubscribe_subscription_url_for' do
+    it "returns url for the subscription target" do
+      expect(unsubscribe_subscription_url_for(subscription))
+        .to eq(unsubscribe_user_subscription_url(target_user, subscription))
+    end
+  end
+
+  describe '#unsubscribe_url_for' do
+    it "returns url for the subscription target" do
+      expect(unsubscribe_url_for(subscription))
+        .to eq(unsubscribe_user_subscription_url(target_user, subscription))
+    end
+  end
+
+  describe '#subscribe_to_email_subscription_url_for' do
+    it "returns url for the subscription target" do
+      expect(subscribe_to_email_subscription_url_for(subscription))
+        .to eq(subscribe_to_email_user_subscription_url(target_user, subscription))
+    end
+  end
+
+  describe '#subscribe_to_email_url_for' do
+    it "returns url for the subscription target" do
+      expect(subscribe_to_email_url_for(subscription))
+        .to eq(subscribe_to_email_user_subscription_url(target_user, subscription))
+    end
+  end
+
+  describe '#unsubscribe_to_email_subscription_url_for' do
+    it "returns url for the subscription target" do
+      expect(unsubscribe_to_email_subscription_url_for(subscription))
+        .to eq(unsubscribe_to_email_user_subscription_url(target_user, subscription))
+    end
+  end
+
+  describe '#unsubscribe_to_email_url_for' do
+    it "returns url for the subscription target" do
+      expect(unsubscribe_to_email_url_for(subscription))
+        .to eq(unsubscribe_to_email_user_subscription_url(target_user, subscription))
+    end
+  end
+
 end