activity_notification 0.0.8 → 0.0.9

data/spec/controllers/notifications_controller_spec.rb

@@ -0,0 +1,12 @@
+require 'controllers/notifications_controller_shared_examples'
+
+describe ActivityNotification::NotificationsController, type: :controller do
+  let(:test_target)        { create(:user) }
+  let(:target_type)        { :users }
+  let(:typed_target_param) { :user_id }
+  let(:extra_params)       { {} }
+  let(:valid_session)      {}
+
+  it_behaves_like :notification_controller
+
+end

data/spec/controllers/notifications_with_devise_controller_spec.rb

@@ -0,0 +1,81 @@
+require 'controllers/notifications_controller_shared_examples'
+
+describe ActivityNotification::NotificationsWithDeviseController, type: :controller do
+  let(:test_user)            { create(:confirmed_user) }
+  let(:unauthenticated_user) { create(:confirmed_user) }
+  let(:test_target)          { create(:admin, user: test_user) }
+  let(:target_type)          { :admins }
+  let(:typed_target_param)   { :admin_id }
+  let(:extra_params)         { { devise_type: :users } }
+  let(:valid_session)        {}
+
+  context "signed in with devise as authenticated user" do
+    before do
+      sign_in test_user
+    end
+  
+    it_behaves_like :notification_controller
+  end
+
+  context "signed in with devise as unauthenticated user" do
+    let(:target_params) { { target_type: target_type, devise_type: :users } }
+
+    describe "GET #index" do
+      before do
+        sign_in unauthenticated_user
+        get :index, target_params.merge({ typed_target_param => test_target }), valid_session
+      end
+  
+      it "returns 403 as http status code" do
+        expect(response.status).to eq(403)
+      end
+    end
+  end
+
+  context "unsigned in with devise" do
+    let(:target_params) { { target_type: target_type, devise_type: :users } }
+
+    describe "GET #index" do
+      before do
+        get :index, target_params.merge({ typed_target_param => test_target }), valid_session
+      end
+  
+      it "returns 302 as http status code" do
+        expect(response.status).to eq(302)
+      end
+
+      it "redirects to sign_in path" do
+        expect(response).to redirect_to new_user_session_path
+      end
+    end
+  end
+
+  context "without devise_type parameter" do
+    let(:target_params) { { target_type: target_type } }
+
+    describe "GET #index" do
+      before do
+        get :index, target_params.merge({ typed_target_param => test_target }), valid_session
+      end
+  
+      it "returns 400 as http status code" do
+        expect(response.status).to eq(400)
+      end
+    end
+  end
+
+  context "with wrong devise_type parameter" do
+    let(:target_params) { { target_type: target_type, devise_type: :dummy_targets } }
+
+    describe "GET #index" do
+      before do
+        get :index, target_params.merge({ typed_target_param => test_target }), valid_session
+      end
+  
+      it "returns 403 as http status code" do
+        expect(response.status).to eq(403)
+      end
+    end
+  end
+
+end

data/spec/factories/admins.rb

@@ -0,0 +1,5 @@
+FactoryGirl.define do
+  factory :admin do
+    user
+  end
+end

data/spec/factories/articles.rb

@@ -1,5 +1,5 @@
 FactoryGirl.define do
   factory :article do
-    user
+    association :user, factory: :confirmed_user
   end
 end

data/spec/factories/comments.rb

@@ -1,6 +1,6 @@
 FactoryGirl.define do
   factory :comment do
     article
-    user
+    association :user, factory: :confirmed_user
   end
 end

data/spec/factories/dummy/dummy_notifiable.rb

@@ -0,0 +1,4 @@
+FactoryGirl.define do
+  factory :dummy_notifiable, class: Dummy::DummyNotifiable do
+  end
+end

data/spec/factories/dummy/dummy_notifier.rb

@@ -0,0 +1,4 @@
+FactoryGirl.define do
+  factory :dummy_notifier, class: Dummy::DummyNotifier do
+  end
+end

data/spec/factories/dummy/dummy_target.rb

@@ -0,0 +1,4 @@
+FactoryGirl.define do
+  factory :dummy_target, class: Dummy::DummyTarget do
+  end
+end

data/spec/factories/notifications.rb

@@ -1,6 +1,6 @@
 FactoryGirl.define do
   factory :notification, class: ActivityNotification::Notification do
-    association :target, factory: :user
+    association :target, factory: :confirmed_user
     association :notifiable, factory: :article
     key "default.default"
   end

data/spec/factories/users.rb

@@ -1,5 +1,11 @@
 FactoryGirl.define do
   factory :user do
-    email ['a'..'z'].shuffle.join + '@example.com'
+    email Array.new(10){[*"A".."Z", *"0".."9"].sample}.join + '@example.com'
+    password "password"
+    password_confirmation "password"
+  end
+
+  factory :confirmed_user, parent: :user do
+    after(:build) { |user| user.skip_confirmation! }
   end
 end

data/spec/generators/active_record/migration_generator_spec.rb

@@ -0,0 +1,41 @@
+require 'generators/activity_notification/active_record/migration_generator'
+
+describe ActivityNotification::Generators::MigrationGenerator, type: :generator do
+
+  # setup_default_destination
+  destination File.expand_path("../../../../tmp", __FILE__)
+  before { prepare_destination }
+
+  it 'runs generating migration tasks' do
+    gen = generator
+    expect(gen).to receive :create_migrations
+    gen.invoke_all
+  end
+
+  describe 'the generated files' do
+    context 'without name argument' do
+      before do
+        run_generator
+      end
+
+      describe 'CreateNotifications migration file' do
+        subject { file(Dir["tmp/db/migrate/*_create_notifications.rb"].first.gsub!('tmp/', '')) }
+        it { is_expected.to exist }
+        it { is_expected.to contain(/class CreateNotifications < ActiveRecord::Migration/) }
+      end
+    end
+
+    context 'with CreateCustomNotifications as name argument' do
+      before do
+        run_generator %w(CreateCustomNotifications)
+      end
+
+      describe 'CreateCustomNotifications migration file' do
+        subject { file(Dir["tmp/db/migrate/*_create_custom_notifications.rb"].first.gsub!('tmp/', '')) }
+        it { is_expected.to exist }
+        it { is_expected.to contain(/class CreateCustomNotifications < ActiveRecord::Migration/) }
+      end
+    end
+
+  end
+end

data/spec/generators/controllers_generator_spec.rb

@@ -0,0 +1,62 @@
+require 'generators/activity_notification/controllers_generator'
+
+describe ActivityNotification::Generators::ControllersGenerator, type: :generator do
+
+  # setup_default_destination
+  destination File.expand_path("../../../tmp", __FILE__)
+  before { prepare_destination }
+
+  it 'runs generating controllers tasks' do
+    gen = generator %w(users)
+    expect(gen).to receive :create_controllers
+    expect(gen).to receive(:readme).and_return(true)
+    gen.invoke_all
+  end
+
+  describe 'the generated files' do
+    context 'without target argument' do
+      it 'raises Thor::RequiredArgumentMissingError' do
+        expect { run_generator }
+        .to raise_error(Thor::RequiredArgumentMissingError)
+      end
+    end
+
+    context 'with users as target' do
+      context 'with target controllers as default' do
+        before do
+          run_generator %w(users)
+        end
+
+        describe 'the notifications_controller' do
+          subject { file('app/controllers/users/notifications_controller.rb') }
+          it { is_expected.to exist }
+          it { is_expected.to contain(/class Users::NotificationsController < ActivityNotification::NotificationsController/) }
+        end
+
+        describe 'the notifications_with_devise_controller' do
+          subject { file('app/controllers/users/notifications_with_devise_controller.rb') }
+          it { is_expected.to exist }
+          it { is_expected.to contain(/class Users::NotificationsWithDeviseController < ActivityNotification::NotificationsWithDeviseController/) }
+        end
+      end
+
+      context 'with a controllers option as notifications' do
+        before do
+          run_generator %w(users --controllers notifications)
+        end
+
+        describe 'the notifications_controller' do
+          subject { file('app/controllers/users/notifications_controller.rb') }
+          it { is_expected.to exist }
+          it { is_expected.to contain(/class Users::NotificationsController < ActivityNotification::NotificationsController/) }
+        end
+
+        describe 'the notifications_with_devise_controller' do
+          subject { file('app/controllers/users/notifications_with_devise_controller.rb') }
+          it { is_expected.not_to exist }
+        end
+      end
+    end
+
+  end
+end

data/spec/generators/install_generator_spec.rb

@@ -0,0 +1,43 @@
+require 'generators/activity_notification/install_generator'
+
+describe ActivityNotification::Generators::InstallGenerator, type: :generator do
+
+  # setup_default_destination
+  destination File.expand_path("../../../tmp", __FILE__)
+  before { prepare_destination }
+
+  it 'runs both the initializer and locale tasks' do
+    gen = generator
+    expect(gen).to receive :copy_initializer
+    expect(gen).to receive :copy_locale
+    expect(gen).to receive(:readme).and_return(true)
+    gen.invoke_all
+  end
+
+  describe 'the generated files' do
+    context 'with active_record orm as default' do
+      before do
+        run_generator
+      end
+
+      describe 'the initializer' do
+        subject { file('config/initializers/activity_notification.rb') }
+        it { is_expected.to exist }
+        it { is_expected.to contain(/ActivityNotification.configure do |config|/) }
+      end
+
+      describe 'the locale file' do
+        subject { file('config/locales/activity_notification.en.yml') }
+        it { is_expected.to exist }
+        it { is_expected.to contain(/en:\n.+notification:\n.+default:/) }
+      end
+    end
+
+    context 'with orm option as not :active_record' do
+      it 'raises MissingORMError' do
+        expect { run_generator %w(--orm dummy) }
+        .to raise_error(TypeError)
+      end
+    end
+  end
+end

data/spec/generators/models/notification_generator_spec.rb

@@ -0,0 +1,41 @@
+require 'generators/activity_notification/models/notification_generator'
+
+describe ActivityNotification::Generators::NotificationGenerator, type: :generator do
+
+  # setup_default_destination
+  destination File.expand_path("../../../../tmp", __FILE__)
+  before { prepare_destination }
+
+  it 'runs generating model tasks' do
+    gen = generator
+    expect(gen).to receive :create_models
+    gen.invoke_all
+  end
+
+  describe 'the generated files' do
+    context 'without name argument' do
+      before do
+        run_generator
+      end
+
+      describe 'app/models/notification.rb' do
+        subject { file('app/models/notification.rb') }
+        it { is_expected.to exist }
+        it { is_expected.to contain(/class Notification < ActivityNotification::Notification/) }
+      end
+    end
+
+    context 'with CustomNotification as name argument' do
+      before do
+        run_generator %w(CustomNotification)
+      end
+
+      describe 'app/models/notification.rb' do
+        subject { file('app/models/custom_notification.rb') }
+        it { is_expected.to exist }
+        it { is_expected.to contain(/class CustomNotification < ActivityNotification::Notification/) }
+      end
+    end
+
+  end
+end

data/spec/generators/views_generator_spec.rb

@@ -0,0 +1,111 @@
+require 'generators/activity_notification/views_generator'
+
+describe ActivityNotification::Generators::ViewsGenerator, type: :generator do
+
+  # setup_default_destination
+  destination File.expand_path("../../../tmp", __FILE__)
+  before { prepare_destination }
+
+  it 'runs generating views tasks' do
+    gen = generator
+    expect(gen).to receive :copy_views
+    gen.invoke_all
+  end
+
+  describe 'the generated files' do
+    context 'without target argument' do
+      context 'with target views as default' do
+        before do
+          run_generator
+        end
+
+        describe 'the notification views' do
+          describe 'default/_default.html.erb' do
+            subject { file('app/views/activity_notification/notifications/default/_default.html.erb') }
+            it { is_expected.to exist }
+          end
+
+          describe 'default/_index.html.erb' do
+            subject { file('app/views/activity_notification/notifications/default/_index.html.erb') }
+            it { is_expected.to exist }
+          end
+
+          describe 'default/destroy.js.erb' do
+            subject { file('app/views/activity_notification/notifications/default/destroy.js.erb') }
+            it { is_expected.to exist }
+          end
+
+          describe 'default/index.html.erb' do
+            subject { file('app/views/activity_notification/notifications/default/index.html.erb') }
+            it { is_expected.to exist }
+          end
+
+          describe 'default/open_all.js.erb' do
+            subject { file('app/views/activity_notification/notifications/default/open_all.js.erb') }
+            it { is_expected.to exist }
+          end
+
+          describe 'default/open.js.erb' do
+            subject { file('app/views/activity_notification/notifications/default/open.js.erb') }
+            it { is_expected.to exist }
+          end
+
+          describe 'default/show.html.erb' do
+            subject { file('app/views/activity_notification/notifications/default/show.html.erb') }
+            it { is_expected.to exist }
+          end
+        end
+
+        describe 'the mailer views' do
+          describe 'default/default.html.erb' do
+            subject { file('app/views/activity_notification/mailer/default/default.html.erb') }
+            it { is_expected.to exist }
+          end
+        end
+      end
+
+      context 'with a views option as notifications' do
+        before do
+          run_generator %w(--views notifications)
+        end
+
+        describe 'the notification views' do
+          describe 'default/index.html.erb' do
+            subject { file('app/views/activity_notification/notifications/default/index.html.erb') }
+            it { is_expected.to exist }
+          end
+        end
+
+        describe 'the mailer views' do
+          describe 'default/default.html.erb' do
+            subject { file('app/views/activity_notification/mailer/default/default.html.erb') }
+            it { is_expected.not_to exist }
+          end
+        end
+      end
+    end
+
+    context 'with users as target' do
+      context 'with target views as default' do
+        before do
+          run_generator %w(users)
+        end
+
+        describe 'the notification views' do
+          describe 'users/index.html.erb' do
+            subject { file('app/views/activity_notification/notifications/users/index.html.erb') }
+            it { is_expected.to exist }
+          end
+        end
+
+        describe 'the mailer views' do
+          describe 'users/default.html.erb' do
+            subject { file('app/views/activity_notification/mailer/users/default.html.erb') }
+            it { is_expected.to exist }
+          end
+        end
+      end
+    end
+
+  end
+end