activesupport 7.1.0 → 7.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 82365193f8aa8e04a486a7ed6f82adeb64093abd70569d67c7756b065f754b82
-  data.tar.gz: ececf5de5e7b69fe11b7edc1007e7b850c2463005ffba7f2763b85636e192d98
+  metadata.gz: 6db71966858e675d32617069b0df8dc17b1c5dfe8123c87ae96a28fdb6e2f5e6
+  data.tar.gz: 81ffe410567130147cd0c6f74943d40404a4031b2cf30f12bfaa2ee698cd5a57
 SHA512:
-  metadata.gz: e6daffabed388ec6412bff231a3d2478f430625d266078fe186c92594353b87026dc22a492e689ea7a716a570eb75a9eb53582a45b33627a06444be1b560da7e
-  data.tar.gz: 33dc1b13f205838ad773fc7c4bfda5bb6bec704cbdb7ffdaedfe938a91088c2dd98d1ade38514689dbb66d2f5f45e3871973b8981c21cd6deabec0cff41349da
+  metadata.gz: 99a9131ff9f97e739719621df9ba0a33d3b2fad9b1315397382235f29d33ee130f701d0c0ed767eacf01ccb31607eb26d7f5bb95f37ad86ac57f18817cd9b253
+  data.tar.gz: ffa6a0ffe90b88c87f65d85ddb32390d20f8c34ab2517f797c34d325839cbf434a0202650cdd54f118bee9a299cf478f83af4222c313f2746e267bbd19003914

data/CHANGELOG.md

@@ -1,3 +1,91 @@
+## Rails 7.1.2 (November 10, 2023) ##
+
+*   Fix `:expires_in` option for `RedisCacheStore#write_multi`.
+
+    *fatkodima*
+
+*   Fix deserialization of non-string "purpose" field in Message serializer
+
+    *Jacopo Beschi*
+
+*   Prevent global cache options being overwritten when setting dynamic options
+    inside a `ActiveSupport::Cache::Store#fetch` block.
+
+    *Yasha Krasnou*
+
+*   Fix missing `require` resulting in `NoMethodError` when running
+    `bin/rails secrets:show` or `bin/rails secrets:edit`.
+
+    *Stephen Ierodiaconou*
+
+*   Ensure `{down,up}case_first` returns non-frozen string.
+
+    *Jonathan Hefner*
+
+*   Fix `#to_fs(:human_size)` to correctly work with negative numbers.
+
+    *Earlopain*
+
+*   Fix `BroadcastLogger#dup` so that it duplicates the logger's `broadcasts`.
+
+    *Andrew Novoselac*
+
+*   Fix issue where `bootstrap.rb` overwrites the `level` of a `BroadcastLogger`'s `broadcasts`.
+
+    *Andrew Novoselac*
+
+*   Fix `ActiveSupport::Cache` to handle outdated Marshal payload from Rails 6.1 format.
+
+    Active Support's Cache is supposed to treat a Marshal payload that can no longer be
+    deserialized as a cache miss. It fail to do so for compressed payload in the Rails 6.1
+    legacy format.
+
+    *Jean Boussier*
+
+*   Fix `OrderedOptions#dig` for array indexes.
+
+    *fatkodima*
+
+*   Fix time travel helpers to work when nested using with separate classes.
+
+    *fatkodima*
+
+*   Fix `delete_matched` for file cache store to work with keys longer than the
+    max filename size.
+
+    *fatkodima* and *Jonathan Hefner*
+
+*   Fix compatibility with the `semantic_logger` gem.
+
+    The `semantic_logger` gem doesn't behave exactly like stdlib logger in that
+    `SemanticLogger#level` returns a Symbol while stdlib `Logger#level` returns an Integer.
+
+    This caused the various `LogSubscriber` classes in Rails to break when assigned a
+    `SemanticLogger` instance.
+
+    *Jean Boussier*, *ojab*
+
+## Rails 7.1.1 (October 11, 2023) ##
+
+*   Add support for keyword arguments when delegating calls to custom loggers from `ActiveSupport::BroadcastLogger`.
+
+    *Edouard Chin*
+
+*   `NumberHelper`: handle objects responding `to_d`.
+
+    *fatkodima*
+
+*   Fix RedisCacheStore to properly set the TTL when incrementing or decrementing.
+
+    This bug was only impacting Redis server older than 7.0.
+
+    *Thomas Countz*
+
+*   Fix MemoryStore to prevent race conditions when incrementing or decrementing.
+
+    *Pierre Jambet*
+
+
 ## Rails 7.1.0 (October 05, 2023) ##
 
 *   No changes.
@@ -868,7 +956,7 @@
 
      *Trevor Turk*
 
-*   `ActiveSupport::Cache:Store#fetch` now passes an options accessor to the block.
+*   `ActiveSupport::Cache::Store#fetch` now passes an options accessor to the block.
 
     It makes possible to override cache options:
 

data/lib/active_support/broadcast_logger.rb

@@ -51,6 +51,26 @@ module ActiveSupport
   #
   #   broadcast = BroadcastLogger.new
   #   broadcast.info("Hello world") # The log message will appear nowhere.
+  #
+  # If you are adding a custom logger with custom methods to the broadcast,
+  # the `BroadcastLogger` will proxy them and return the raw value, or an array
+  # of raw values, depending on how many loggers in the broadcasts responded to
+  # the method:
+  #
+  #   class MyLogger < ::Logger
+  #     def loggable?
+  #       true
+  #     end
+  #   end
+  #
+  #   logger = BroadcastLogger.new
+  #   logger.loggable? # => A NoMethodError exception is raised because no loggers in the broadcasts could respond.
+  #
+  #   logger.broadcast_to(MyLogger.new(STDOUT))
+  #   logger.loggable? # => true
+  #   logger.broadcast_to(MyLogger.new(STDOUT))
+  #   puts logger.broadcasts # => [MyLogger, MyLogger]
+  #   logger.loggable? # [true, true]
   class BroadcastLogger
     include ActiveSupport::LoggerSilence
 
@@ -198,20 +218,28 @@ module ActiveSupport
       dispatch { |logger| logger.fatal! }
     end
 
+    def initialize_copy(other)
+      @broadcasts = []
+      @progname = other.progname.dup
+      @formatter = other.formatter.dup
+
+      broadcast_to(*other.broadcasts.map(&:dup))
+    end
+
     private
       def dispatch(&block)
         @broadcasts.each { |logger| block.call(logger) }
       end
 
-      def method_missing(name, *args, &block)
+      def method_missing(name, *args, **kwargs, &block)
         loggers = @broadcasts.select { |logger| logger.respond_to?(name) }
 
         if loggers.none?
-          super(name, *args, &block)
+          super(name, *args, **kwargs, &block)
         elsif loggers.one?
-          loggers.first.send(name, *args, &block)
+          loggers.first.send(name, *args, **kwargs, &block)
         else
-          loggers.map { |logger| logger.send(name, *args, &block) }
+          loggers.map { |logger| logger.send(name, *args, **kwargs, &block) }
         end
       end
 

data/lib/active_support/cache/entry.rb

@@ -121,7 +121,13 @@ module ActiveSupport
 
       private
         def uncompress(value)
-          Marshal.load(Zlib::Inflate.inflate(value))
+          marshal_load(Zlib::Inflate.inflate(value))
+        end
+
+        def marshal_load(payload)
+          Marshal.load(payload)
+        rescue ArgumentError => error
+          raise Cache::DeserializationError, error.message
         end
     end
   end

data/lib/active_support/cache/file_store.rb

@@ -176,7 +176,7 @@ module ActiveSupport
 
         # Translate a file path into a key.
         def file_path_key(path)
-          fname = path[cache_path.to_s.size..-1].split(File::SEPARATOR, 4).last
+          fname = path[cache_path.to_s.size..-1].split(File::SEPARATOR, 4).last.delete(File::SEPARATOR)
           URI.decode_www_form_component(fname, Encoding::UTF_8)
         end
 

data/lib/active_support/cache/mem_cache_store.rb

@@ -270,14 +270,22 @@ module ActiveSupport
         def read_multi_entries(names, **options)
           keys_to_names = names.index_by { |name| normalize_key(name, options) }
 
-          raw_values = @data.with { |c| c.get_multi(keys_to_names.keys) }
+          raw_values = begin
+            @data.with { |c| c.get_multi(keys_to_names.keys) }
+          rescue Dalli::UnmarshalError
+            {}
+          end
+
           values = {}
 
           raw_values.each do |key, value|
             entry = deserialize_entry(value, raw: options[:raw])
 
             unless entry.nil? || entry.expired? || entry.mismatched?(normalize_version(keys_to_names[key], options))
-              values[keys_to_names[key]] = entry.value
+              begin
+                values[keys_to_names[key]] = entry.value
+              rescue DeserializationError
+              end
             end
           end
 

data/lib/active_support/cache/memory_store.rb

@@ -238,16 +238,18 @@ module ActiveSupport
           key     = normalize_key(name, options)
           version = normalize_version(name, options)
 
-          entry = read_entry(key, **options)
+          synchronize do
+            entry = read_entry(key, **options)
 
-          if !entry || entry.expired? || entry.mismatched?(version)
-            write(name, Integer(amount), options)
-            amount
-          else
-            num = entry.value.to_i + amount
-            entry = Entry.new(num, expires_at: entry.expires_at, version: entry.version)
-            write_entry(key, entry)
-            num
+            if !entry || entry.expired? || entry.mismatched?(version)
+              write(name, Integer(amount), options)
+              amount
+            else
+              num = entry.value.to_i + amount
+              entry = Entry.new(num, expires_at: entry.expires_at, version: entry.version)
+              write_entry(key, entry)
+              num
+            end
           end
         end
     end

data/lib/active_support/cache/redis_cache_store.rb

@@ -332,7 +332,10 @@ module ActiveSupport
             if value
               entry = deserialize_entry(value, raw: raw)
               unless entry.nil? || entry.expired? || entry.mismatched?(normalize_version(name, options))
-                results[name] = entry.value
+                begin
+                  results[name] = entry.value
+                rescue DeserializationError
+                end
               end
             end
           end
@@ -383,7 +386,7 @@ module ActiveSupport
         end
 
         # Nonstandard store provider API to write multiple values at once.
-        def write_multi_entries(entries, expires_in: nil, race_condition_ttl: nil, **options)
+        def write_multi_entries(entries, **options)
           return if entries.empty?
 
           failsafe :write_multi_entries do
@@ -438,18 +441,26 @@ module ActiveSupport
           redis.then do |c|
             c = c.node_for(key) if c.is_a?(Redis::Distributed)
 
-            if options[:expires_in] && supports_expire_nx?
-              c.pipelined do |pipeline|
-                pipeline.incrby(key, amount)
-                pipeline.call(:expire, key, options[:expires_in].to_i, "NX")
-              end.first
+            expires_in = options[:expires_in]
+
+            if expires_in
+              if supports_expire_nx?
+                count, _ = c.pipelined do |pipeline|
+                  pipeline.incrby(key, amount)
+                  pipeline.call(:expire, key, expires_in.to_i, "NX")
+                end
+              else
+                count, ttl = c.pipelined do |pipeline|
+                  pipeline.incrby(key, amount)
+                  pipeline.ttl(key)
+                end
+                c.expire(key, expires_in.to_i) if ttl < 0
+              end
             else
               count = c.incrby(key, amount)
-              if count != amount && options[:expires_in] && c.ttl(key) < 0
-                c.expire(key, options[:expires_in].to_i)
-              end
-              count
             end
+
+            count
           end
         end
 

data/lib/active_support/cache.rb

@@ -439,9 +439,9 @@ module ActiveSupport
       #
       # ==== Dynamic Options
       #
-      # In some cases it may be necessary to to dynamically compute options based
-      # on the cached value. For this purpose, a ActiveSupport::Cache::WriteOptions
-      # instance is passed as a second argument to the block
+      # In some cases it may be necessary to dynamically compute options based
+      # on the cached value. To support this, an ActiveSupport::Cache::WriteOptions
+      # instance is passed as the second argument to the block. For example:
       #
       #     cache.fetch("authentication-token:#{user.id}") do |key, options|
       #       token = authenticate_to_service
@@ -449,12 +449,6 @@ module ActiveSupport
       #       token
       #     end
       #
-      # Only some options can be set dynamically:
-      #
-      #   - +:expires_in+
-      #   - +:expires_at+
-      #   - +:version+
-      #
       def fetch(name, options = nil, &block)
         if block_given?
           options = merged_options(options)
@@ -465,7 +459,17 @@ module ActiveSupport
             instrument(:read, name, options) do |payload|
               cached_entry = read_entry(key, **options, event: payload)
               entry = handle_expired_entry(cached_entry, key, options)
-              entry = nil if entry && entry.mismatched?(normalize_version(name, options))
+              if entry
+                if entry.mismatched?(normalize_version(name, options))
+                  entry = nil
+                else
+                  begin
+                    entry.value
+                  rescue DeserializationError
+                    entry = nil
+                  end
+                end
+              end
               payload[:super_operation] = :fetch if payload
               payload[:hit] = !!entry if payload
             end
@@ -517,7 +521,12 @@ module ActiveSupport
               nil
             else
               payload[:hit] = true if payload
-              entry.value
+              begin
+                entry.value
+              rescue DeserializationError
+                payload[:hit] = false
+                nil
+              end
             end
           else
             payload[:hit] = false if payload
@@ -1044,6 +1053,8 @@ module ActiveSupport
         end
 
         def save_block_result_to_cache(name, options)
+          options = options.dup
+
           result = instrument(:generate, name, options) do
             yield(name, WriteOptions.new(options))
           end

data/lib/active_support/core_ext/date/conversions.rb

@@ -52,7 +52,7 @@ class Date
         strftime(formatter)
       end
     else
-      to_default_s
+      to_s
     end
   end
   alias_method :to_formatted_s, :to_fs

data/lib/active_support/core_ext/module/concerning.rb

@@ -3,7 +3,7 @@
 require "active_support/concern"
 
 class Module
-  # = Bite-sized separation of concerns
+  # == Bite-sized separation of concerns
   #
   # We often find ourselves with a medium-sized chunk of behavior that we'd
   # like to extract, but only mix in to a single class.
@@ -18,9 +18,9 @@ class Module
   # with a comment, as a least-bad alternative. Using modules in separate files
   # means tedious sifting to get a big-picture view.
   #
-  # = Dissatisfying ways to separate small concerns
+  # == Dissatisfying ways to separate small concerns
   #
-  # == Using comments:
+  # === Using comments:
   #
   #   class Todo < ApplicationRecord
   #     # Other todo implementation
@@ -37,7 +37,7 @@ class Module
   #       end
   #   end
   #
-  # == With an inline module:
+  # === With an inline module:
   #
   # Noisy syntax.
   #
@@ -61,7 +61,7 @@ class Module
   #     include EventTracking
   #   end
   #
-  # == Mix-in noise exiled to its own file:
+  # === Mix-in noise exiled to its own file:
   #
   # Once our chunk of behavior starts pushing the scroll-to-understand-it
   # boundary, we give in and move it to a separate file. At this size, the
@@ -75,7 +75,7 @@ class Module
   #     include TodoEventTracking
   #   end
   #
-  # = Introducing Module#concerning
+  # == Introducing Module#concerning
   #
   # By quieting the mix-in noise, we arrive at a natural, low-ceremony way to
   # separate bite-sized concerns.

data/lib/active_support/core_ext/object/json.rb

@@ -29,7 +29,7 @@ require "active_support/core_ext/date/conversions"
 # It should be noted that when using ::JSON.{generate,dump} directly, ActiveSupport's encoder is
 # bypassed completely. This means that as_json won't be invoked and the JSON gem will simply
 # ignore any options it does not natively understand. This also means that ::JSON.{generate,dump}
-# should give exactly the same results with or without active support.
+# should give exactly the same results with or without Active Support.
 
 module ActiveSupport
   module ToJsonWithActiveSupportEncoder # :nodoc:

data/lib/active_support/deprecation/behaviors.rb

@@ -60,8 +60,8 @@ module ActiveSupport
     # [+raise+]   Raise ActiveSupport::DeprecationException.
     # [+stderr+]  Log all deprecation warnings to <tt>$stderr</tt>.
     # [+log+]     Log all deprecation warnings to +Rails.logger+.
-    # [+notify+]  Use +ActiveSupport::Notifications+ to notify +deprecation.rails+.
-    # [+report+]  Use +ActiveSupport::ErrorReporter+ to report deprecations.
+    # [+notify+]  Use ActiveSupport::Notifications to notify +deprecation.rails+.
+    # [+report+]  Use ActiveSupport::ErrorReporter to report deprecations.
     # [+silence+] Do nothing. On \Rails, set <tt>config.active_support.report_deprecations = false</tt> to disable all behaviors.
     #
     # Setting behaviors only affects deprecations that happen after boot time.
@@ -88,8 +88,8 @@ module ActiveSupport
       # [+raise+]   Raise ActiveSupport::DeprecationException.
       # [+stderr+]  Log all deprecation warnings to <tt>$stderr</tt>.
       # [+log+]     Log all deprecation warnings to +Rails.logger+.
-      # [+notify+]  Use +ActiveSupport::Notifications+ to notify +deprecation.rails+.
-      # [+report+]  Use +ActiveSupport::ErrorReporter+ to report deprecations.
+      # [+notify+]  Use ActiveSupport::Notifications to notify +deprecation.rails+.
+      # [+report+]  Use ActiveSupport::ErrorReporter to report deprecations.
       # [+silence+] Do nothing.
       #
       # Setting behaviors only affects deprecations that happen after boot time.

data/lib/active_support/gem_version.rb

@@ -9,7 +9,7 @@ module ActiveSupport
   module VERSION
     MAJOR = 7
     MINOR = 1
-    TINY  = 0
+    TINY  = 2
     PRE   = nil
 
     STRING = [MAJOR, MINOR, TINY, PRE].compact.join(".")

data/lib/active_support/inflector/methods.rb

@@ -164,7 +164,7 @@ module ActiveSupport
     #   upcase_first('w')                 # => "W"
     #   upcase_first('')                  # => ""
     def upcase_first(string)
-      string.length > 0 ? string[0].upcase.concat(string[1..-1]) : ""
+      string.length > 0 ? string[0].upcase.concat(string[1..-1]) : +""
     end
 
     # Converts the first character in the string to lowercase.
@@ -173,7 +173,7 @@ module ActiveSupport
     #   downcase_first('I')                          # => "i"
     #   downcase_first('')                           # => ""
     def downcase_first(string)
-      string.length > 0 ? string[0].downcase.concat(string[1..-1]) : ""
+      string.length > 0 ? string[0].downcase.concat(string[1..-1]) : +""
     end
 
     # Capitalizes all the words and replaces some characters in the string to

data/lib/active_support/log_subscriber.rb

@@ -86,6 +86,12 @@ module ActiveSupport
     mattr_accessor :colorize_logging, default: true
     class_attribute :log_levels, instance_accessor: false, default: {} # :nodoc:
 
+    LEVEL_CHECKS = {
+      debug: -> (logger) { !logger.debug? },
+      info: -> (logger) { !logger.info? },
+      error: -> (logger) { !logger.error? },
+    }
+
     class << self
       def logger
         @logger ||= if defined?(Rails) && Rails.respond_to?(:logger)
@@ -122,7 +128,7 @@ module ActiveSupport
         end
 
         def subscribe_log_level(method, level)
-          self.log_levels = log_levels.merge(method => ::Logger.const_get(level.upcase))
+          self.log_levels = log_levels.merge(method => LEVEL_CHECKS.fetch(level))
           set_event_levels
         end
     end
@@ -137,7 +143,7 @@ module ActiveSupport
     end
 
     def silenced?(event)
-      logger.nil? || logger.level > @event_levels.fetch(event, Float::INFINITY)
+      logger.nil? || @event_levels[event]&.call(logger)
     end
 
     def call(event)

data/lib/active_support/message_encryptors.rb

@@ -130,6 +130,7 @@ module ActiveSupport
     # indicate whether old option sets are still in use or can be removed from
     # rotation.
 
+    ##
     private
       def build(salt, secret_generator:, secret_generator_options:, **options)
         secret_length = MessageEncryptor.key_len(*options[:cipher])

data/lib/active_support/message_verifiers.rb

@@ -126,6 +126,7 @@ module ActiveSupport
     # indicate whether old option sets are still in use or can be removed from
     # rotation.
 
+    ##
     private
       def build(salt, secret_generator:, secret_generator_options:, **options)
         MessageVerifier.new(secret_generator.call(salt, **secret_generator_options), **options)

data/lib/active_support/messages/metadata.rb

@@ -82,7 +82,7 @@ module ActiveSupport
             throw :invalid_message_content, "expired"
           end
 
-          if hash["pur"] != purpose&.to_s
+          if hash["pur"].to_s != purpose.to_s
             throw :invalid_message_content, "mismatched purpose"
           end
 

data/lib/active_support/notifications/fanout.rb

@@ -18,26 +18,30 @@ module ActiveSupport
     end
 
     module FanoutIteration # :nodoc:
-      def iterate_guarding_exceptions(listeners)
-        exceptions = nil
-
-        listeners.each do |s|
-          yield s
-        rescue Exception => e
-          exceptions ||= []
-          exceptions << e
-        end
+      private
+        def iterate_guarding_exceptions(collection)
+          exceptions = nil
 
-        if exceptions
-          if exceptions.size == 1
-            raise exceptions.first
-          else
-            raise InstrumentationSubscriberError.new(exceptions), cause: exceptions.first
+          collection.each do |s|
+            yield s
+          rescue Exception => e
+            exceptions ||= []
+            exceptions << e
           end
-        end
 
-        listeners
-      end
+          if exceptions
+            exceptions = exceptions.flat_map do |exception|
+              exception.is_a?(InstrumentationSubscriberError) ? exception.exceptions : [exception]
+            end
+            if exceptions.size == 1
+              raise exceptions.first
+            else
+              raise InstrumentationSubscriberError.new(exceptions), cause: exceptions.first
+            end
+          end
+
+          collection
+        end
     end
 
     # This is a default queue implementation that ships with Notifications.
@@ -225,6 +229,8 @@ module ActiveSupport
       #     handle.finish
       #   end
       class Handle
+        include FanoutIteration
+
         def initialize(notifier, name, id, payload) # :nodoc:
           @name = name
           @id = id
@@ -239,7 +245,7 @@ module ActiveSupport
           ensure_state! :initialized
           @state = :started
 
-          @groups.each do |group|
+          iterate_guarding_exceptions(@groups) do |group|
             group.start(@name, @id, @payload)
           end
         end
@@ -252,7 +258,7 @@ module ActiveSupport
           ensure_state! :started
           @state = :finished
 
-          @groups.each do |group|
+          iterate_guarding_exceptions(@groups) do |group|
             group.finish(name, id, payload)
           end
         end

data/lib/active_support/notifications/instrumenter.rb

@@ -65,16 +65,16 @@ module ActiveSupport
         end
       end
 
-      # Returns a "handle" for an event with the given +name+ and +payload+
+      # Returns a "handle" for an event with the given +name+ and +payload+.
       #
-      # +#start+ and +#finish+ must each be called exactly once on the returned object.
+      # #start and #finish must each be called exactly once on the returned object.
       #
-      # Where possible, it's best to use +#instrument+, which will record the
+      # Where possible, it's best to use #instrument, which will record the
       # start and finish of the event and correctly handle any exceptions.
       # +build_handle+ is a low-level API intended for cases where using
-      # +#instrument+ isn't possible.
+      # +instrument+ isn't possible.
       #
-      # See ActiveSupport::Notifications::Fanout::Handle
+      # See ActiveSupport::Notifications::Fanout::Handle.
       def build_handle(name, payload)
         @notifier.build_handle(name, @id, payload)
       end
@@ -146,21 +146,21 @@ module ActiveSupport
         @allocation_count_finish = now_allocations
       end
 
-      # Returns the CPU time (in milliseconds) passed since the call to
-      # +start!+ and the call to +finish!+
+      # Returns the CPU time (in milliseconds) passed between the call to
+      # #start! and the call to #finish!.
       def cpu_time
         @cpu_time_finish - @cpu_time_start
       end
 
-      # Returns the idle time time (in milliseconds) passed since the call to
-      # +start!+ and the call to +finish!+
+      # Returns the idle time time (in milliseconds) passed between the call to
+      # #start! and the call to #finish!.
       def idle_time
         diff = duration - cpu_time
         diff > 0.0 ? diff : 0.0
       end
 
-      # Returns the number of allocations made since the call to +start!+ and
-      # the call to +finish!+
+      # Returns the number of allocations made between the call to #start! and
+      # the call to #finish!.
       def allocations
         @allocation_count_finish - @allocation_count_start
       end

data/lib/active_support/number_helper/number_converter.rb

@@ -179,8 +179,10 @@ module ActiveSupport
           case number
           when Float, Rational
             number.to_d(0)
-          else
+          when String
             BigDecimal(number, exception: false)
+          else
+            number.to_d rescue nil
           end
         end
     end

data/lib/active_support/number_helper/number_to_human_size_converter.rb

@@ -43,13 +43,13 @@ module ActiveSupport
 
         def exponent
           max = STORAGE_UNITS.size - 1
-          exp = (Math.log(number) / Math.log(base)).to_i
+          exp = (Math.log(number.abs) / Math.log(base)).to_i
           exp = max if exp > max # avoid overflow for the highest unit
           exp
         end
 
         def smaller_than_base?
-          number.to_i < base
+          number.to_i.abs < base
         end
 
         def base

data/lib/active_support/ordered_options.rb

@@ -42,8 +42,8 @@ module ActiveSupport
       super(key.to_sym)
     end
 
-    def dig(*keys)
-      super(*keys.flatten.map(&:to_sym))
+    def dig(key, *identifiers)
+      super(key.to_sym, *identifiers)
     end
 
     def method_missing(name, *args)

data/lib/active_support/testing/strict_warnings.rb

@@ -17,6 +17,7 @@ module ActiveSupport
     SUPPRESSED_WARNINGS = Regexp.union(
       # TODO: remove if https://github.com/mikel/mail/pull/1557 or similar fix
       %r{/lib/mail/parsers/.*statement not reached},
+      %r{/lib/mail/parsers/.*assigned but unused variable - disp_type_s},
       %r{/lib/mail/parsers/.*assigned but unused variable - testEof}
     )
 

data/lib/active_support/testing/time_helpers.rb

@@ -25,7 +25,7 @@ module ActiveSupport
           unstub_object(stub)
         end
 
-        new_name = "__simple_stub__#{method_name}"
+        new_name = "__simple_stub__#{method_name}__#{object_id}"
 
         @stubs[object.object_id][method_name] = Stub.new(object, method_name, new_name)
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activesupport
 version: !ruby/object:Gem::Version
-  version: 7.1.0
+  version: 7.1.2
 platform: ruby
 authors:
 - David Heinemeier Hansson
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-10-05 00:00:00.000000000 Z
+date: 2023-11-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n
@@ -446,10 +446,10 @@ licenses:
 - MIT
 metadata:
   bug_tracker_uri: https://github.com/rails/rails/issues
-  changelog_uri: https://github.com/rails/rails/blob/v7.1.0/activesupport/CHANGELOG.md
-  documentation_uri: https://api.rubyonrails.org/v7.1.0/
+  changelog_uri: https://github.com/rails/rails/blob/v7.1.2/activesupport/CHANGELOG.md
+  documentation_uri: https://api.rubyonrails.org/v7.1.2/
   mailing_list_uri: https://discuss.rubyonrails.org/c/rubyonrails-talk
-  source_code_uri: https://github.com/rails/rails/tree/v7.1.0/activesupport
+  source_code_uri: https://github.com/rails/rails/tree/v7.1.2/activesupport
   rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options: