activesupport 7.1.0.rc2 → 7.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5e7c1720f83cebc94a181cd94c65ea558ed9e10a4635545893dd5e1bf054f27a
-  data.tar.gz: f61b99bf85b449f9b5262fd32388bf378e5ecd949e9f35da00569025d9c4edda
+  metadata.gz: ecb3bcd9549f6429e9a7b2e3e54bd529a71608135834c95ecad50ed60dd8935a
+  data.tar.gz: 23c6ef54d1fbef9a19494322bae6ed4f4719d1a9f0b60e3f507dc1ccd4cf9adf
 SHA512:
-  metadata.gz: a363047116d2e984f879cbc39b674faa1deac4791ee325eb616aeb0b482c8c06ab134cabff46ddd6449fb768ff4ca2b06d5f7bf722eb7cb210d6f7c364d94980
-  data.tar.gz: 47ca432654c35b2d8359c42d76e9dc517b8b797a5eac8efb74f5ae59fbcbbedef636a1c3df3891667bd2aefe0db7dd09ef1d1eab855438cef9c03d309f8f97e5
+  metadata.gz: abdba26b48e19b8f107f9110e2934f315f8f4fcf87340309f4786faf0998903a21e791d362e106550439088016039c692e00c90b380b5b7602b497244ea30419
+  data.tar.gz: 8f256ca213eea9aed13061094dca338c5886ba2bd3454036cd39649938399cc41ec74ff09ec28beabc21b9a57713c98e60125b13306e63a56aa908ad269b2316

data/CHANGELOG.md

@@ -1,3 +1,29 @@
+## Rails 7.1.1 (October 11, 2023) ##
+
+*   Add support for keyword arguments when delegating calls to custom loggers from `ActiveSupport::BroadcastLogger`.
+
+    *Edouard Chin*
+
+*   `NumberHelper`: handle objects responding `to_d`.
+
+    *fatkodima*
+
+*   Fix RedisCacheStore to properly set the TTL when incrementing or decrementing.
+
+    This bug was only impacting Redis server older than 7.0.
+
+    *Thomas Countz*
+
+*   Fix MemoryStore to prevent race conditions when incrementing or decrementing.
+
+    *Pierre Jambet*
+
+
+## Rails 7.1.0 (October 05, 2023) ##
+
+*   No changes.
+
+
 ## Rails 7.1.0.rc2 (October 01, 2023) ##
 
 *   Fix `AS::MessagePack` with `ENV["RAILS_MAX_THREADS"]`.
@@ -863,7 +889,7 @@
 
      *Trevor Turk*
 
-*   `ActiveSupport::Cache:Store#fetch` now passes an options accessor to the block.
+*   `ActiveSupport::Cache::Store#fetch` now passes an options accessor to the block.
 
     It makes possible to override cache options:
 

data/lib/active_support/broadcast_logger.rb

@@ -51,6 +51,26 @@ module ActiveSupport
   #
   #   broadcast = BroadcastLogger.new
   #   broadcast.info("Hello world") # The log message will appear nowhere.
+  #
+  # If you are adding a custom logger with custom methods to the broadcast,
+  # the `BroadcastLogger` will proxy them and return the raw value, or an array
+  # of raw values, depending on how many loggers in the broadcasts responded to
+  # the method:
+  #
+  #   class MyLogger < ::Logger
+  #     def loggable?
+  #       true
+  #     end
+  #   end
+  #
+  #   logger = BroadcastLogger.new
+  #   logger.loggable? # => A NoMethodError exception is raised because no loggers in the broadcasts could respond.
+  #
+  #   logger.broadcast_to(MyLogger.new(STDOUT))
+  #   logger.loggable? # => true
+  #   logger.broadcast_to(MyLogger.new(STDOUT))
+  #   puts logger.broadcasts # => [MyLogger, MyLogger]
+  #   logger.loggable? # [true, true]
   class BroadcastLogger
     include ActiveSupport::LoggerSilence
 
@@ -203,16 +223,20 @@ module ActiveSupport
         @broadcasts.each { |logger| block.call(logger) }
       end
 
-      def method_missing(name, *args)
+      def method_missing(name, *args, **kwargs, &block)
         loggers = @broadcasts.select { |logger| logger.respond_to?(name) }
 
         if loggers.none?
-          super(name, *args)
+          super(name, *args, **kwargs, &block)
         elsif loggers.one?
-          loggers.first.send(name, *args)
+          loggers.first.send(name, *args, **kwargs, &block)
         else
-          loggers.map { |logger| logger.send(name, *args) }
+          loggers.map { |logger| logger.send(name, *args, **kwargs, &block) }
         end
       end
+
+      def respond_to_missing?(method, include_all)
+        @broadcasts.any? { |logger| logger.respond_to?(method, include_all) }
+      end
   end
 end

data/lib/active_support/cache/memory_store.rb

@@ -238,16 +238,18 @@ module ActiveSupport
           key     = normalize_key(name, options)
           version = normalize_version(name, options)
 
-          entry = read_entry(key, **options)
+          synchronize do
+            entry = read_entry(key, **options)
 
-          if !entry || entry.expired? || entry.mismatched?(version)
-            write(name, Integer(amount), options)
-            amount
-          else
-            num = entry.value.to_i + amount
-            entry = Entry.new(num, expires_at: entry.expires_at, version: entry.version)
-            write_entry(key, entry)
-            num
+            if !entry || entry.expired? || entry.mismatched?(version)
+              write(name, Integer(amount), options)
+              amount
+            else
+              num = entry.value.to_i + amount
+              entry = Entry.new(num, expires_at: entry.expires_at, version: entry.version)
+              write_entry(key, entry)
+              num
+            end
           end
         end
     end

data/lib/active_support/cache/redis_cache_store.rb

@@ -438,18 +438,26 @@ module ActiveSupport
           redis.then do |c|
             c = c.node_for(key) if c.is_a?(Redis::Distributed)
 
-            if options[:expires_in] && supports_expire_nx?
-              c.pipelined do |pipeline|
-                pipeline.incrby(key, amount)
-                pipeline.call(:expire, key, options[:expires_in].to_i, "NX")
-              end.first
+            expires_in = options[:expires_in]
+
+            if expires_in
+              if supports_expire_nx?
+                count, _ = c.pipelined do |pipeline|
+                  pipeline.incrby(key, amount)
+                  pipeline.call(:expire, key, expires_in.to_i, "NX")
+                end
+              else
+                count, ttl = c.pipelined do |pipeline|
+                  pipeline.incrby(key, amount)
+                  pipeline.ttl(key)
+                end
+                c.expire(key, expires_in.to_i) if ttl < 0
+              end
             else
               count = c.incrby(key, amount)
-              if count != amount && options[:expires_in] && c.ttl(key) < 0
-                c.expire(key, options[:expires_in].to_i)
-              end
-              count
             end
+
+            count
           end
         end
 

data/lib/active_support/cache.rb

@@ -439,9 +439,9 @@ module ActiveSupport
       #
       # ==== Dynamic Options
       #
-      # In some cases it may be necessary to to dynamically compute options based
-      # on the cached value. For this purpose, a ActiveSupport::Cache::WriteOptions
-      # instance is passed as a second argument to the block
+      # In some cases it may be necessary to dynamically compute options based
+      # on the cached value. To support this, an ActiveSupport::Cache::WriteOptions
+      # instance is passed as the second argument to the block. For example:
       #
       #     cache.fetch("authentication-token:#{user.id}") do |key, options|
       #       token = authenticate_to_service
@@ -449,12 +449,6 @@ module ActiveSupport
       #       token
       #     end
       #
-      # Only some options can be set dynamically:
-      #
-      #   - +:expires_in+
-      #   - +:expires_at+
-      #   - +:version+
-      #
       def fetch(name, options = nil, &block)
         if block_given?
           options = merged_options(options)

data/lib/active_support/core_ext/object/json.rb

@@ -29,7 +29,7 @@ require "active_support/core_ext/date/conversions"
 # It should be noted that when using ::JSON.{generate,dump} directly, ActiveSupport's encoder is
 # bypassed completely. This means that as_json won't be invoked and the JSON gem will simply
 # ignore any options it does not natively understand. This also means that ::JSON.{generate,dump}
-# should give exactly the same results with or without active support.
+# should give exactly the same results with or without Active Support.
 
 module ActiveSupport
   module ToJsonWithActiveSupportEncoder # :nodoc:

data/lib/active_support/deprecation/behaviors.rb

@@ -60,8 +60,8 @@ module ActiveSupport
     # [+raise+]   Raise ActiveSupport::DeprecationException.
     # [+stderr+]  Log all deprecation warnings to <tt>$stderr</tt>.
     # [+log+]     Log all deprecation warnings to +Rails.logger+.
-    # [+notify+]  Use +ActiveSupport::Notifications+ to notify +deprecation.rails+.
-    # [+report+]  Use +ActiveSupport::ErrorReporter+ to report deprecations.
+    # [+notify+]  Use ActiveSupport::Notifications to notify +deprecation.rails+.
+    # [+report+]  Use ActiveSupport::ErrorReporter to report deprecations.
     # [+silence+] Do nothing. On \Rails, set <tt>config.active_support.report_deprecations = false</tt> to disable all behaviors.
     #
     # Setting behaviors only affects deprecations that happen after boot time.
@@ -88,8 +88,8 @@ module ActiveSupport
       # [+raise+]   Raise ActiveSupport::DeprecationException.
       # [+stderr+]  Log all deprecation warnings to <tt>$stderr</tt>.
       # [+log+]     Log all deprecation warnings to +Rails.logger+.
-      # [+notify+]  Use +ActiveSupport::Notifications+ to notify +deprecation.rails+.
-      # [+report+]  Use +ActiveSupport::ErrorReporter+ to report deprecations.
+      # [+notify+]  Use ActiveSupport::Notifications to notify +deprecation.rails+.
+      # [+report+]  Use ActiveSupport::ErrorReporter to report deprecations.
       # [+silence+] Do nothing.
       #
       # Setting behaviors only affects deprecations that happen after boot time.

data/lib/active_support/gem_version.rb

@@ -9,8 +9,8 @@ module ActiveSupport
   module VERSION
     MAJOR = 7
     MINOR = 1
-    TINY  = 0
-    PRE   = "rc2"
+    TINY  = 1
+    PRE   = nil
 
     STRING = [MAJOR, MINOR, TINY, PRE].compact.join(".")
   end

data/lib/active_support/message_encryptors.rb

@@ -130,6 +130,7 @@ module ActiveSupport
     # indicate whether old option sets are still in use or can be removed from
     # rotation.
 
+    ##
     private
       def build(salt, secret_generator:, secret_generator_options:, **options)
         secret_length = MessageEncryptor.key_len(*options[:cipher])

data/lib/active_support/message_verifiers.rb

@@ -126,6 +126,7 @@ module ActiveSupport
     # indicate whether old option sets are still in use or can be removed from
     # rotation.
 
+    ##
     private
       def build(salt, secret_generator:, secret_generator_options:, **options)
         MessageVerifier.new(secret_generator.call(salt, **secret_generator_options), **options)

data/lib/active_support/notifications/instrumenter.rb

@@ -65,16 +65,16 @@ module ActiveSupport
         end
       end
 
-      # Returns a "handle" for an event with the given +name+ and +payload+
+      # Returns a "handle" for an event with the given +name+ and +payload+.
       #
-      # +#start+ and +#finish+ must each be called exactly once on the returned object.
+      # #start and #finish must each be called exactly once on the returned object.
       #
-      # Where possible, it's best to use +#instrument+, which will record the
+      # Where possible, it's best to use #instrument, which will record the
       # start and finish of the event and correctly handle any exceptions.
       # +build_handle+ is a low-level API intended for cases where using
-      # +#instrument+ isn't possible.
+      # +instrument+ isn't possible.
       #
-      # See ActiveSupport::Notifications::Fanout::Handle
+      # See ActiveSupport::Notifications::Fanout::Handle.
       def build_handle(name, payload)
         @notifier.build_handle(name, @id, payload)
       end
@@ -146,21 +146,21 @@ module ActiveSupport
         @allocation_count_finish = now_allocations
       end
 
-      # Returns the CPU time (in milliseconds) passed since the call to
-      # +start!+ and the call to +finish!+
+      # Returns the CPU time (in milliseconds) passed between the call to
+      # #start! and the call to #finish!.
       def cpu_time
         @cpu_time_finish - @cpu_time_start
       end
 
-      # Returns the idle time time (in milliseconds) passed since the call to
-      # +start!+ and the call to +finish!+
+      # Returns the idle time time (in milliseconds) passed between the call to
+      # #start! and the call to #finish!.
       def idle_time
         diff = duration - cpu_time
         diff > 0.0 ? diff : 0.0
       end
 
-      # Returns the number of allocations made since the call to +start!+ and
-      # the call to +finish!+
+      # Returns the number of allocations made between the call to #start! and
+      # the call to #finish!.
       def allocations
         @allocation_count_finish - @allocation_count_start
       end

data/lib/active_support/number_helper/number_converter.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require "bigdecimal"
+require "bigdecimal/util"
 require "active_support/core_ext/big_decimal/conversions"
 require "active_support/core_ext/hash/keys"
 require "active_support/i18n"
@@ -128,7 +130,7 @@ module ActiveSupport
       def execute
         if !number
           nil
-        elsif validate_float? && !valid_float?
+        elsif validate_float? && !valid_bigdecimal
           number
         else
           convert
@@ -173,8 +175,15 @@ module ActiveSupport
           key.split(".").reduce(DEFAULTS) { |defaults, k| defaults[k.to_sym] }
         end
 
-        def valid_float?
-          Float(number, exception: false)
+        def valid_bigdecimal
+          case number
+          when Float, Rational
+            number.to_d(0)
+          when String
+            BigDecimal(number, exception: false)
+          else
+            number.to_d rescue nil
+          end
         end
     end
   end

data/lib/active_support/number_helper/number_to_currency_converter.rb

@@ -10,13 +10,13 @@ module ActiveSupport
       def convert
         format = options[:format]
 
-        number_f = valid_float?
-        if number_f
-          if number_f.negative?
-            number_f = number_f.abs
-            format = options[:negative_format] if (number_f * 10**options[:precision]) >= 0.5
+        number_d = valid_bigdecimal
+        if number_d
+          if number_d.negative?
+            number_d = number_d.abs
+            format = options[:negative_format] if (number_d * 10**options[:precision]) >= 0.5
           end
-          number_s = NumberToRoundedConverter.convert(number_f, options)
+          number_s = NumberToRoundedConverter.convert(number_d, options)
         else
           number_s = number.to_s.strip
           format = options[:negative_format] if number_s.sub!(/^-/, "")

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activesupport
 version: !ruby/object:Gem::Version
-  version: 7.1.0.rc2
+  version: 7.1.1
 platform: ruby
 authors:
 - David Heinemeier Hansson
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-10-01 00:00:00.000000000 Z
+date: 2023-10-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n
@@ -446,10 +446,10 @@ licenses:
 - MIT
 metadata:
   bug_tracker_uri: https://github.com/rails/rails/issues
-  changelog_uri: https://github.com/rails/rails/blob/v7.1.0.rc2/activesupport/CHANGELOG.md
-  documentation_uri: https://api.rubyonrails.org/v7.1.0.rc2/
+  changelog_uri: https://github.com/rails/rails/blob/v7.1.1/activesupport/CHANGELOG.md
+  documentation_uri: https://api.rubyonrails.org/v7.1.1/
   mailing_list_uri: https://discuss.rubyonrails.org/c/rubyonrails-talk
-  source_code_uri: https://github.com/rails/rails/tree/v7.1.0.rc2/activesupport
+  source_code_uri: https://github.com/rails/rails/tree/v7.1.1/activesupport
   rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options:
@@ -464,9 +464,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 2.7.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubygems_version: 3.4.18
 signing_key: