activestorage_legacy 0.1

data/test/models/blob_test.rb

@@ -0,0 +1,47 @@
+require "test_helper"
+require "database/setup"
+
+class ActiveStorage::BlobTest < ActiveSupport::TestCase
+  test "create after upload sets byte size and checksum" do
+    data = "Hello world!"
+    blob = create_blob data: data
+
+    assert_equal data, blob.download
+    assert_equal data.length, blob.byte_size
+    assert_equal Digest::MD5.base64digest(data), blob.checksum
+  end
+
+  test "text?" do
+    blob = create_blob data: "Hello world!"
+    assert blob.text?
+    assert_not blob.audio?
+  end
+
+  test "download yields chunks" do
+    blob   = create_blob data: "a" * 75.kilobytes
+    chunks = []
+
+    blob.download do |chunk|
+      chunks << chunk
+    end
+
+    assert_equal 2, chunks.size
+    assert_equal "a" * 64.kilobytes, chunks.first
+    assert_equal "a" * 11.kilobytes, chunks.second
+  end
+
+  test "urls expiring in 5 minutes" do
+    blob = create_blob
+
+    freeze_time do
+      assert_equal expected_url_for(blob), blob.service_url
+      assert_equal expected_url_for(blob, disposition: :attachment), blob.service_url(disposition: :attachment)
+    end
+  end
+
+  private
+    def expected_url_for(blob, disposition: :inline)
+      query_string = { content_type: blob.content_type, disposition: disposition }.to_param
+      "/rails/active_storage/disk/#{ActiveStorage.verifier.generate(blob.key, expires_in: 5.minutes, purpose: :blob_key)}/#{blob.filename}?#{query_string}"
+    end
+end

data/test/models/variant_test.rb

@@ -0,0 +1,27 @@
+require "test_helper"
+require "database/setup"
+
+class ActiveStorage::VariantTest < ActiveSupport::TestCase
+  setup do
+    @blob = create_image_blob filename: "racecar.jpg"
+  end
+
+  test "resized variation" do
+    variant = @blob.variant(resize: "100x100").processed
+    assert_match /racecar.jpg/, variant.service_url
+
+    image = read_image_variant(variant)
+    assert_equal 100, image.width
+    assert_equal 67, image.height
+  end
+
+  test "resized and monochrome variation" do
+    variant = @blob.variant(resize: "100x100", monochrome: true).processed
+    assert_match /racecar.jpg/, variant.service_url
+
+    image = read_image_variant(variant)
+    assert_equal 100, image.width
+    assert_equal 67, image.height
+    assert_match /Gray/, image.colorspace
+  end
+end

data/test/service/.gitignore

@@ -0,0 +1 @@
+configurations.yml

data/test/service/azure_service_test.rb

@@ -0,0 +1,14 @@
+require "service/shared_service_tests"
+require "httparty"
+require "uri"
+
+if SERVICE_CONFIGURATIONS[:azure]
+  class ActiveStorage::Service::AzureServiceTest < ActiveSupport::TestCase
+    SERVICE = ActiveStorage::Service.configure(:azure, SERVICE_CONFIGURATIONS)
+
+    include ActiveStorage::Service::SharedServiceTests
+  end
+
+else
+  puts "Skipping Azure Storage Service tests because no Azure configuration was supplied"
+end

data/test/service/configurations-example.yml

@@ -0,0 +1,31 @@
+# Copy this file to configurations.yml and edit the credentials to match your IAM test account and bucket
+s3:
+  service: S3
+  access_key_id:
+  secret_access_key:
+  region:
+  bucket:
+
+gcs:
+  service: GCS
+  keyfile: {
+    type: "service_account",
+    project_id: "",
+    private_key_id: "",
+    private_key: "",
+    client_email: "",
+    client_id: "",
+    auth_uri: "https://accounts.google.com/o/oauth2/auth",
+    token_uri: "https://accounts.google.com/o/oauth2/token",
+    auth_provider_x509_cert_url: "https://www.googleapis.com/oauth2/v1/certs",
+    client_x509_cert_url: ""
+  }
+  project:
+  bucket:
+
+azure:
+  service: Azure
+  path: ""
+  storage_account_name: ""
+  storage_access_key: ""
+  container: ""

data/test/service/configurator_test.rb

@@ -0,0 +1,14 @@
+require "service/shared_service_tests"
+
+class ActiveStorage::Service::ConfiguratorTest < ActiveSupport::TestCase
+  test "builds correct service instance based on service name" do
+    service = ActiveStorage::Service::Configurator.build(:foo, foo: { service: "Disk", root: "path" })
+    assert_instance_of ActiveStorage::Service::DiskService, service
+  end
+
+  test "raises error when passing non-existent service name" do
+    assert_raise RuntimeError do
+      ActiveStorage::Service::Configurator.build(:bigfoot, {})
+    end
+  end
+end

data/test/service/disk_service_test.rb

@@ -0,0 +1,12 @@
+require "service/shared_service_tests"
+
+class ActiveStorage::Service::DiskServiceTest < ActiveSupport::TestCase
+  SERVICE = ActiveStorage::Service::DiskService.new(root: File.join(Dir.tmpdir, "active_storage"))
+
+  include ActiveStorage::Service::SharedServiceTests
+
+  test "url generation" do
+    assert_match /rails\/active_storage\/disk\/.*\/avatar\.png\?.+disposition=inline/,
+      @service.url(FIXTURE_KEY, expires_in: 5.minutes, disposition: :inline, filename: "avatar.png", content_type: "image/png")
+  end
+end

data/test/service/gcs_service_test.rb

@@ -0,0 +1,42 @@
+require "service/shared_service_tests"
+require "httparty"
+
+if SERVICE_CONFIGURATIONS[:gcs]
+  class ActiveStorage::Service::GCSServiceTest < ActiveSupport::TestCase
+    SERVICE = ActiveStorage::Service.configure(:gcs, SERVICE_CONFIGURATIONS)
+
+    include ActiveStorage::Service::SharedServiceTests
+
+    test "direct upload" do
+      begin
+        key      = SecureRandom.base58(24)
+        data     = "Something else entirely!"
+        checksum = Digest::MD5.base64digest(data)
+        url      = @service.url_for_direct_upload(key, expires_in: 5.minutes, content_type: "text/plain", content_length: data.size, checksum: checksum)
+
+        HTTParty.put(
+          url,
+          body: data,
+          headers: { "Content-Type" => "text/plain", "Content-MD5" => checksum },
+          debug_output: STDOUT
+        )
+
+        assert_equal data, @service.download(key)
+      ensure
+        @service.delete key
+      end
+    end
+
+    test "signed URL generation" do
+      freeze_time do
+        url = SERVICE.bucket.signed_url(FIXTURE_KEY, expires: 120) +
+          "&response-content-disposition=inline%3B+filename%3D%22test.txt%22" +
+          "&response-content-type=text%2Fplain"
+
+        assert_equal url, @service.url(FIXTURE_KEY, expires_in: 2.minutes, disposition: :inline, filename: "test.txt", content_type: "text/plain")
+      end
+    end
+  end
+else
+  puts "Skipping GCS Service tests because no GCS configuration was supplied"
+end

data/test/service/mirror_service_test.rb

@@ -0,0 +1,62 @@
+require "service/shared_service_tests"
+
+class ActiveStorage::Service::MirrorServiceTest < ActiveSupport::TestCase
+  mirror_config = (1..3).map do |i|
+    [ "mirror_#{i}",
+      service: "Disk",
+      root: Dir.mktmpdir("active_storage_tests_mirror_#{i}") ]
+  end.to_h
+
+  config = mirror_config.merge \
+    mirror:   { service: "Mirror", primary: "primary", mirrors: mirror_config.keys },
+    primary:  { service: "Disk", root: Dir.mktmpdir("active_storage_tests_primary") }
+
+  SERVICE = ActiveStorage::Service.configure :mirror, config
+
+  include ActiveStorage::Service::SharedServiceTests
+
+  test "uploading to all services" do
+    begin
+      data = "Something else entirely!"
+      key  = upload(data, to: @service)
+
+      assert_equal data, SERVICE.primary.download(key)
+      SERVICE.mirrors.each do |mirror|
+        assert_equal data, mirror.download(key)
+      end
+    ensure
+      @service.delete key
+    end
+  end
+
+  test "downloading from primary service" do
+    data = "Something else entirely!"
+    key  = upload(data, to: SERVICE.primary)
+
+    assert_equal data, @service.download(key)
+  end
+
+  test "deleting from all services" do
+    @service.delete FIXTURE_KEY
+    assert_not SERVICE.primary.exist?(FIXTURE_KEY)
+    SERVICE.mirrors.each do |mirror|
+      assert_not mirror.exist?(FIXTURE_KEY)
+    end
+  end
+
+  test "URL generation in primary service" do
+    freeze_time do
+      assert_equal SERVICE.primary.url(FIXTURE_KEY, expires_in: 2.minutes, disposition: :inline, filename: "test.txt", content_type: "text/plain"),
+        @service.url(FIXTURE_KEY, expires_in: 2.minutes, disposition: :inline, filename: "test.txt", content_type: "text/plain")
+    end
+  end
+
+  private
+    def upload(data, to:)
+      SecureRandom.base58(24).tap do |key|
+        io = StringIO.new(data).tap(&:read)
+        @service.upload key, io, checksum: Digest::MD5.base64digest(data)
+        assert io.eof?
+      end
+    end
+end

data/test/service/s3_service_test.rb

@@ -0,0 +1,52 @@
+require "service/shared_service_tests"
+require "httparty"
+
+if SERVICE_CONFIGURATIONS[:s3]
+  class ActiveStorage::Service::S3ServiceTest < ActiveSupport::TestCase
+    SERVICE = ActiveStorage::Service.configure(:s3, SERVICE_CONFIGURATIONS)
+
+    include ActiveStorage::Service::SharedServiceTests
+
+    test "direct upload" do
+      begin
+        key      = SecureRandom.base58(24)
+        data     = "Something else entirely!"
+        checksum = Digest::MD5.base64digest(data)
+        url      = @service.url_for_direct_upload(key, expires_in: 5.minutes, content_type: "text/plain", content_length: data.size, checksum: checksum)
+
+        HTTParty.put(
+          url,
+          body: data,
+          headers: { "Content-Type" => "text/plain", "Content-MD5" => checksum },
+          debug_output: STDOUT
+        )
+
+        assert_equal data, @service.download(key)
+      ensure
+        @service.delete key
+      end
+    end
+
+    test "signed URL generation" do
+      assert_match /#{SERVICE_CONFIGURATIONS[:s3][:bucket]}\.s3.(\S+)?amazonaws.com.*response-content-disposition=inline.*avatar\.png.*response-content-type=image%2Fpng/,
+        @service.url(FIXTURE_KEY, expires_in: 5.minutes, disposition: :inline, filename: "avatar.png", content_type: "image/png")
+    end
+
+    test "uploading with server-side encryption" do
+      config  = SERVICE_CONFIGURATIONS.deep_merge(s3: { upload: { server_side_encryption: "AES256" }})
+      service = ActiveStorage::Service.configure(:s3, config)
+
+      begin
+        key  = SecureRandom.base58(24)
+        data = "Something else entirely!"
+        service.upload key, StringIO.new(data), checksum: Digest::MD5.base64digest(data)
+
+        assert_equal "AES256", service.bucket.object(key).server_side_encryption
+      ensure
+        service.delete key
+      end
+    end
+  end
+else
+  puts "Skipping S3 Service tests because no S3 configuration was supplied"
+end

data/test/service/shared_service_tests.rb

@@ -0,0 +1,66 @@
+require "test_helper"
+
+module ActiveStorage::Service::SharedServiceTests
+  extend ActiveSupport::Concern
+
+  FIXTURE_KEY  = SecureRandom.base58(24)
+  FIXTURE_DATA = "\211PNG\r\n\032\n\000\000\000\rIHDR\000\000\000\020\000\000\000\020\001\003\000\000\000%=m\"\000\000\000\006PLTE\000\000\000\377\377\377\245\331\237\335\000\000\0003IDATx\234c\370\377\237\341\377_\206\377\237\031\016\2603\334?\314p\1772\303\315\315\f7\215\031\356\024\203\320\275\317\f\367\201R\314\f\017\300\350\377\177\000Q\206\027(\316]\233P\000\000\000\000IEND\256B`\202".force_encoding(Encoding::BINARY)
+
+  included do
+    setup do
+      @service = self.class.const_get(:SERVICE)
+      @service.upload FIXTURE_KEY, StringIO.new(FIXTURE_DATA)
+    end
+
+    teardown do
+      @service.delete FIXTURE_KEY
+    end
+
+    test "uploading with integrity" do
+      begin
+        key  = SecureRandom.base58(24)
+        data = "Something else entirely!"
+        @service.upload(key, StringIO.new(data), checksum: Digest::MD5.base64digest(data))
+
+        assert_equal data, @service.download(key)
+      ensure
+        @service.delete key
+      end
+    end
+
+    test "uploading without integrity" do
+      begin
+        key  = SecureRandom.base58(24)
+        data = "Something else entirely!"
+
+        assert_raises(ActiveStorage::IntegrityError) do
+          @service.upload(key, StringIO.new(data), checksum: Digest::MD5.base64digest("bad data"))
+        end
+
+        assert_not @service.exist?(key)
+      ensure
+        @service.delete key
+      end
+    end
+
+    test "downloading" do
+      assert_equal FIXTURE_DATA, @service.download(FIXTURE_KEY)
+    end
+
+    test "existing" do
+      assert @service.exist?(FIXTURE_KEY)
+      assert_not @service.exist?(FIXTURE_KEY + "nonsense")
+    end
+
+    test "deleting" do
+      @service.delete FIXTURE_KEY
+      assert_not @service.exist?(FIXTURE_KEY)
+    end
+
+    test "deleting nonexistent key" do
+      assert_nothing_raised do
+        @service.delete SecureRandom.base58(24)
+      end
+    end
+  end
+end

data/test/sidekiq/minitest_support.rb

@@ -0,0 +1,6 @@
+module SidekiqMinitestSupport
+  def after_teardown
+    Sidekiq::Worker.clear_all
+    super
+  end
+end

data/test/support/assertions.rb

@@ -0,0 +1,20 @@
+require 'minitest/mock'
+
+module Assertions
+  def assert_not(object, message = nil)
+    message ||= "Expected #{object} to be nil or false"
+    assert !object, message
+  end
+
+  def freeze_time(&block)
+    if block
+      reference_date = Time.now
+
+      Time.stub :now, reference_date do
+        block.call
+      end
+    else
+      block.call
+    end
+  end
+end

data/test/test_helper.rb

@@ -0,0 +1,69 @@
+require 'simplecov'
+SimpleCov.start do
+  add_filter %r{^/test/}
+end
+
+require File.expand_path("../../test/dummy/config/environment.rb", __FILE__)
+
+require "bundler/setup"
+
+require "test/unit/active_support"
+
+require "active_support"
+require "active_support/test_case"
+
+require "byebug"
+require "sidekiq"
+require 'sidekiq/testing'
+require "sidekiq/minitest_support"
+
+require "active_storage"
+
+require "yaml"
+SERVICE_CONFIGURATIONS = begin
+  YAML.load_file(File.expand_path("../service/configurations.yml", __FILE__)).deep_symbolize_keys
+rescue Errno::ENOENT
+  puts "Missing service configuration file in test/service/configurations.yml"
+  {}
+end
+
+require "tmpdir"
+require 'active_storage/service/disk_service'
+require 'support/assertions'
+
+ActiveStorage::Blob.service = ActiveStorage::Service::DiskService.new(root: Dir.mktmpdir("active_storage_tests"))
+ActiveStorage::Service.logger = ::Logger.new(STDOUT)
+
+ActiveStorage.verifier = ActiveStorage::Verifier.new('Testing')
+
+class ActiveSupport::TestCase
+  include Assertions
+  include SidekiqMinitestSupport
+
+  private
+    def create_blob(data: "Hello world!", filename: "hello.txt", content_type: "text/plain")
+      ActiveStorage::Blob.create_after_upload! io: StringIO.new(data), filename: filename, content_type: content_type
+    end
+
+    def create_image_blob(filename: "racecar.jpg", content_type: "image/jpeg")
+      ActiveStorage::Blob.create_after_upload! \
+        io: file_fixture(filename).open,
+        filename: filename, content_type: content_type
+    end
+
+    def create_blob_before_direct_upload(filename: "hello.txt", byte_size:, checksum:, content_type: "text/plain")
+      ActiveStorage::Blob.create_before_direct_upload! filename: filename, byte_size: byte_size, checksum: checksum, content_type: content_type
+    end
+
+    def read_image_variant(variant)
+      MiniMagick::Image.open variant.service.send(:path_for, variant.key)
+    end
+
+    def file_fixture(filename)
+      Pathname(File.join(file_fixture_path, filename))
+    end
+
+    def file_fixture_path
+      File.expand_path("../fixtures/files", __FILE__)
+    end
+end

data/webpack.config.js

@@ -0,0 +1,27 @@
+const webpack = require("webpack")
+const path = require("path")
+
+module.exports = {
+  entry: {
+    "activestorage": path.resolve(__dirname, "app/javascript/activestorage/index.js"),
+  },
+
+  output: {
+    filename: "[name].js",
+    path: path.resolve(__dirname, "app/assets/javascripts"),
+    library: "ActiveStorage",
+    libraryTarget: "umd"
+  },
+
+  module: {
+    rules: [
+      {
+        test: /\.js$/,
+        exclude: /node_modules/,
+        use: {
+          loader: "babel-loader"
+        }
+      }
+    ]
+  }
+}