activestorage 7.0.8.4 → 7.1.0.beta1

Sign up to get free protection for your applications and to get access to all the features.
Files changed (52) hide show
  1. checksums.yaml +4 -4
  2. data/CHANGELOG.md +135 -343
  3. data/MIT-LICENSE +1 -1
  4. data/README.md +4 -4
  5. data/app/assets/javascripts/activestorage.esm.js +8 -4
  6. data/app/assets/javascripts/activestorage.js +9 -3
  7. data/app/controllers/active_storage/disk_controller.rb +4 -2
  8. data/app/controllers/concerns/active_storage/file_server.rb +4 -1
  9. data/app/javascript/activestorage/blob_record.js +4 -1
  10. data/app/javascript/activestorage/direct_upload.js +3 -2
  11. data/app/javascript/activestorage/index.js +3 -1
  12. data/app/jobs/active_storage/transform_job.rb +12 -0
  13. data/app/models/active_storage/attachment.rb +87 -13
  14. data/app/models/active_storage/blob/analyzable.rb +4 -3
  15. data/app/models/active_storage/blob/identifiable.rb +1 -0
  16. data/app/models/active_storage/blob/representable.rb +7 -3
  17. data/app/models/active_storage/blob.rb +25 -45
  18. data/app/models/active_storage/current.rb +0 -10
  19. data/app/models/active_storage/filename.rb +2 -0
  20. data/app/models/active_storage/named_variant.rb +21 -0
  21. data/app/models/active_storage/preview.rb +5 -3
  22. data/app/models/active_storage/variant.rb +8 -7
  23. data/app/models/active_storage/variant_with_record.rb +19 -7
  24. data/app/models/active_storage/variation.rb +5 -3
  25. data/db/migrate/20170806125915_create_active_storage_tables.rb +1 -1
  26. data/lib/active_storage/analyzer/audio_analyzer.rb +16 -4
  27. data/lib/active_storage/analyzer/image_analyzer.rb +2 -0
  28. data/lib/active_storage/analyzer/video_analyzer.rb +3 -1
  29. data/lib/active_storage/analyzer.rb +2 -0
  30. data/lib/active_storage/attached/changes/create_many.rb +8 -3
  31. data/lib/active_storage/attached/changes/create_one.rb +14 -2
  32. data/lib/active_storage/attached/many.rb +5 -4
  33. data/lib/active_storage/attached/model.rb +66 -43
  34. data/lib/active_storage/attached/one.rb +5 -4
  35. data/lib/active_storage/attached.rb +2 -0
  36. data/lib/active_storage/deprecator.rb +7 -0
  37. data/lib/active_storage/engine.rb +11 -7
  38. data/lib/active_storage/fixture_set.rb +2 -0
  39. data/lib/active_storage/gem_version.rb +4 -4
  40. data/lib/active_storage/log_subscriber.rb +12 -0
  41. data/lib/active_storage/previewer.rb +8 -1
  42. data/lib/active_storage/reflection.rb +3 -3
  43. data/lib/active_storage/service/azure_storage_service.rb +2 -0
  44. data/lib/active_storage/service/disk_service.rb +2 -0
  45. data/lib/active_storage/service/gcs_service.rb +11 -20
  46. data/lib/active_storage/service/mirror_service.rb +10 -5
  47. data/lib/active_storage/service/s3_service.rb +2 -0
  48. data/lib/active_storage/service.rb +4 -2
  49. data/lib/active_storage/transformers/transformer.rb +2 -0
  50. data/lib/active_storage/version.rb +1 -1
  51. data/lib/active_storage.rb +19 -3
  52. metadata +19 -30
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: f6b85af188d7d97bd6eca314f880feae2eaa5a601ab9d56913aa682cee59c745
4
- data.tar.gz: fff5aacc0c2ca287ba04a0ac21ac58e497a90fd1a760734decf62de3014ebdb3
3
+ metadata.gz: 5dfb6f1b9694161b8a664871f19104256c481525dbcd52a738137c2fdb0e7c55
4
+ data.tar.gz: f72483c9153ef5bae19222f6ccb659d7d6ee0444d8785a00f9fa54c12f0a861b
5
5
  SHA512:
6
- metadata.gz: dd7ac065a1308592dc65d95ad46ebfe98bd7b1b661ba676906e1290858a7473ea18a971e9250912af59f54a839f5e2728a285b5f83cd87f35df6a8c05a68b659
7
- data.tar.gz: 696e64f857204b0d9010966999335d34062d78f843a6420233f55abb374a4f5517e1184b833d02f0e9738b036d1f67f641f0ab0a31882e362264d0e104d9b647
6
+ metadata.gz: c7fb7bd0ff896ca2f063a71cbc2187659b14b819d6899c23c48ad43ce54f4a48a4039c027e7802a551986b9f0cbde296e4acf9f633aacaf886a3608a3902a07d
7
+ data.tar.gz: 438c8ad07e00b2bdcee84b781bf764fb4c209999e3ccb757b41c5c7c4b9d32f26ea5c36b8f820bd7f1c3b1901ae088448e92b09ff340528636eef841a62df7f4
data/CHANGELOG.md CHANGED
@@ -1,19 +1,4 @@
1
- ## Rails 7.0.8.4 (June 04, 2024) ##
2
-
3
- * No changes.
4
-
5
-
6
- ## Rails 7.0.8.3 (May 17, 2024) ##
7
-
8
- * No changes.
9
-
10
-
11
- ## Rails 7.0.8.2 (May 16, 2024) ##
12
-
13
- * No changes.
14
-
15
-
16
- ## Rails 7.0.8.1 (February 21, 2024) ##
1
+ ## Rails 7.1.0.beta1 (September 13, 2023) ##
17
2
 
18
3
  * Disables the session in `ActiveStorage::Blobs::ProxyController`
19
4
  and `ActiveStorage::Representations::ProxyController`
@@ -23,407 +8,214 @@
23
8
 
24
9
  *Bruno Prieto*
25
10
 
26
- ## Rails 7.0.8 (September 09, 2023) ##
27
-
28
- * No changes.
29
-
30
-
31
- ## Rails 7.0.7.2 (August 22, 2023) ##
32
-
33
- * No changes.
34
-
35
-
36
- ## Rails 7.0.7.1 (August 22, 2023) ##
37
-
38
- * No changes.
39
-
40
-
41
- ## Rails 7.0.7 (August 09, 2023) ##
42
-
43
- * No changes.
44
-
45
-
46
- ## Rails 7.0.6 (June 29, 2023) ##
47
-
48
- * Fix retrieving rotation value from FFmpeg on version 5.0+.
49
-
50
- In FFmpeg version 5.0+ the rotation value has been removed from tags.
51
- Instead the value can be found in side_data_list. Along with
52
- this update it's possible to have values of -90, -270 to denote the video
53
- has been rotated.
54
-
55
- *Haroon Ahmed*
56
-
57
-
58
- ## Rails 7.0.5.1 (June 26, 2023) ##
59
-
60
- * No changes.
61
-
62
-
63
- ## Rails 7.0.5 (May 24, 2023) ##
64
-
65
- * No changes.
66
-
67
-
68
- ## Rails 7.0.4.3 (March 13, 2023) ##
69
-
70
- * No changes.
71
-
72
-
73
- ## Rails 7.0.4.2 (January 24, 2023) ##
74
-
75
- * No changes.
76
-
77
-
78
- ## Rails 7.0.4.1 (January 17, 2023) ##
79
-
80
- * No changes.
81
-
82
-
83
- ## Rails 7.0.4 (September 09, 2022) ##
11
+ * Add `tags` to `ActiveStorage::Analyzer::AudioAnalyzer` output
84
12
 
85
- * Fixes proxy downloads of files over 5MiB
13
+ *Keaton Roux*
86
14
 
87
- Previously, trying to view and/or download files larger than 5mb stored in
88
- services like S3 via proxy mode could return corrupted files at around
89
- 5.2mb or cause random halts in the download. Now,
90
- `ActiveStorage::Blobs::ProxyController` correctly handles streaming these
91
- larger files from the service to the client without any issues.
92
-
93
- Fixes #44679
94
-
95
- *Felipe Raul*
96
-
97
- ## Rails 7.0.3.1 (July 12, 2022) ##
98
-
99
- * No changes.
100
-
101
-
102
- ## Rails 7.0.3 (May 09, 2022) ##
103
-
104
- * Don't stream responses in redirect mode
105
-
106
- Previously, both redirect mode and proxy mode streamed their
107
- responses which caused a new thread to be created, and could end
108
- up leaking connections in the connection pool. But since redirect
109
- mode doesn't actually send any data, it doesn't need to be
110
- streamed.
111
-
112
- *Luke Lau*
113
-
114
- ## Rails 7.0.2.4 (April 26, 2022) ##
15
+ * Add an option to preprocess variants
115
16
 
116
- * No changes.
17
+ ActiveStorage variants are processed on the fly when they are needed but
18
+ sometimes we're sure that they are accessed and want to processed them
19
+ upfront.
117
20
 
21
+ `preprocessed` option is added when declaring variants.
118
22
 
119
- ## Rails 7.0.2.3 (March 08, 2022) ##
120
-
121
- * Added image transformation validation via configurable allow-list.
122
-
123
- Variant now offers a configurable allow-list for
124
- transformation methods in addition to a configurable deny-list for arguments.
125
-
126
- [CVE-2022-21831]
127
-
128
-
129
- ## Rails 7.0.2.2 (February 11, 2022) ##
130
-
131
- * No changes.
132
-
133
- ## Rails 7.0.2.1 (February 11, 2022) ##
134
-
135
- * No changes.
136
-
137
-
138
- ## Rails 7.0.2 (February 08, 2022) ##
139
-
140
- * Revert the ability to pass `service_name` param to `DirectUploadsController` which was introduced
141
- in 7.0.0.
142
-
143
- That change caused a lot of problems to upgrade Rails applications so we decided to remove it
144
- while in work in a more backwards compatible implementation.
145
-
146
- *Gannon McGibbon*
147
-
148
- * Allow applications to opt out of precompiling Active Storage JavaScript assets.
149
-
150
- *jlestavel*
151
-
23
+ ```
24
+ class User < ApplicationRecord
25
+ has_one_attached :avatar do |attachable|
26
+ attachable.variant :thumb, resize_to_limit: [100, 100], preprocessed: true
27
+ end
28
+ end
29
+ ```
152
30
 
153
- ## Rails 7.0.1 (January 06, 2022) ##
31
+ *Shouichi Kamiya*
154
32
 
155
- * No changes.
33
+ * Fix variants not included when eager loading multiple records containing a single attachment
156
34
 
35
+ When using the `with_attached_#{name}` scope for a `has_one_attached` relation,
36
+ attachment variants were not eagerly loaded.
157
37
 
158
- ## Rails 7.0.0 (December 15, 2021) ##
38
+ *Russell Porter*
159
39
 
160
- * Support transforming empty-ish `has_many_attached` value into `[]` (e.g. `[""]`).
40
+ * Allow an ActiveStorage attachment to be removed via a form post
161
41
 
42
+ Attachments can already be removed by updating the attachment to be nil such as:
162
43
  ```ruby
163
- @user.highlights = [""]
164
- @user.highlights # => []
44
+ User.find(params[:id]).update!(avatar: nil)
165
45
  ```
166
46
 
167
- *Sean Doyle*
168
-
47
+ However, a form cannot post a nil param, it can only post an empty string. But, posting an
48
+ empty string would result in an `ActiveSupport::MessageVerifier::InvalidSignature: mismatched digest`
49
+ error being raised, because it's being treated as a signed blob id.
169
50
 
170
- ## Rails 7.0.0.rc3 (December 14, 2021) ##
171
-
172
- * No changes.
173
-
174
-
175
- ## Rails 7.0.0.rc2 (December 14, 2021) ##
176
-
177
- * No changes.
178
-
179
- ## Rails 7.0.0.rc1 (December 06, 2021) ##
180
-
181
- * `Add ActiveStorage::Blob.compose` to concatenate multiple blobs.
182
-
183
- *Gannon McGibbon*
184
-
185
- * Setting custom metadata on blobs are now persisted to remote storage.
186
-
187
- *joshuamsager*
188
-
189
- * Support direct uploads to multiple services.
190
-
191
- *Dmitry Tsepelev*
192
-
193
- * Invalid default content types are deprecated
194
-
195
- Blobs created with content_type `image/jpg`, `image/pjpeg`, `image/bmp`, `text/javascript` will now produce
196
- a deprecation warning, since these are not valid content types.
197
-
198
- These content types will be removed from the defaults in Rails 7.1.
199
-
200
- You can set `config.active_storage.silence_invalid_content_types_warning = true` to dismiss the warning.
201
-
202
- *Alex Ghiculescu*
203
-
204
- ## Rails 7.0.0.alpha2 (September 15, 2021) ##
205
-
206
- * No changes.
207
-
208
-
209
- ## Rails 7.0.0.alpha1 (September 15, 2021) ##
210
-
211
- * Emit Active Support instrumentation events from Active Storage analyzers.
212
-
213
- Fixes #42930
214
-
215
- *Shouichi Kamiya*
216
-
217
- * Add support for byte range requests
218
-
219
- *Tom Prats*
220
-
221
- * Attachments can be deleted after their association is no longer defined.
222
-
223
- Fixes #42514
224
-
225
- *Don Sisco*
51
+ Now, nil and an empty string are treated as a delete, which allows attachments to be removed via:
52
+ ```ruby
53
+ User.find(params[:id]).update!(params.require(:user).permit(:avatar))
226
54
 
227
- * Make `vips` the default variant processor for new apps.
55
+ ```
228
56
 
229
- See the upgrade guide for instructions on converting from `mini_magick` to `vips`. `mini_magick` is
230
- not deprecated, existing apps can keep using it.
57
+ *Nate Matykiewicz*
231
58
 
232
- *Breno Gazzola*
59
+ * Remove mini_mime usage in favour of marcel.
233
60
 
234
- * Deprecate `ActiveStorage::Current.host` in favor of `ActiveStorage::Current.url_options` which accepts
235
- a host, protocol and port.
61
+ We have two libraries that are have similar usage. This change removes
62
+ dependency on mini_mime and makes use of similar methods from marcel.
236
63
 
237
- *Santiago Bartesaghi*
64
+ *Vipul A M*
238
65
 
239
- * Allow using [IAM](https://cloud.google.com/storage/docs/access-control/signed-urls) when signing URLs with GCS.
66
+ * Allow destroying active storage variants
240
67
 
241
- ```yaml
242
- gcs:
243
- service: GCS
244
- ...
245
- iam: true
68
+ ```ruby
69
+ User.first.avatar.variant(resize_to_limit: [100, 100]).destroy
246
70
  ```
247
71
 
248
- *RRethy*
72
+ *Shouichi Kamiya*, *Yuichiro NAKAGAWA*, *Ryohei UEDA*
249
73
 
250
- * OpenSSL constants are now used for Digest computations.
74
+ * Add `sample_rate` to `ActiveStorage::Analyzer::AudioAnalyzer` output
251
75
 
252
- *Dirkjan Bussink*
76
+ *Matija Čupić*
253
77
 
254
- * Deprecate `config.active_storage.replace_on_assign_to_many`. Future versions of Rails
255
- will behave the same way as when the config is set to `true`.
78
+ * Remove deprecated `purge` and `purge_later` methods from the attachments association.
256
79
 
257
- *Santiago Bartesaghi*
80
+ *Rafael Mendonça França*
258
81
 
259
- * Remove deprecated methods: `build_after_upload`, `create_after_upload!` in favor of `create_and_upload!`,
260
- and `service_url` in favor of `url`.
82
+ * Remove deprecated behavior when assigning to a collection of attachments.
261
83
 
262
- *Santiago Bartesaghi*
84
+ Instead of appending to the collection, the collection is now replaced.
263
85
 
264
- * Add support of `strict_loading_by_default` to `ActiveStorage::Representations` controllers.
86
+ *Rafael Mendonça França*
265
87
 
266
- *Anton Topchii*, *Andrew White*
88
+ * Remove deprecated `ActiveStorage::Current#host` and `ActiveStorage::Current#host=` methods.
267
89
 
268
- * Allow to detach an attachment when record is not persisted.
90
+ *Rafael Mendonça França*
269
91
 
270
- *Jacopo Beschi*
92
+ * Remove deprecated invalid default content types in Active Storage configurations.
271
93
 
272
- * Use libvips instead of ImageMagick to analyze images when `active_storage.variant_processor = vips`.
94
+ *Rafael Mendonça França*
273
95
 
274
- *Breno Gazzola*
96
+ * Add missing preview event to `ActiveStorage::LogSubscriber`
275
97
 
276
- * Add metadata value for presence of video channel in video blobs.
98
+ A `preview` event is being instrumented in `ActiveStorage::Previewer`.
99
+ However it was not added inside ActiveStorage's LogSubscriber class.
277
100
 
278
- The `metadata` attribute of video blobs has a new boolean key named `video` that is set to
279
- `true` if the file has an video channel and `false` if it doesn't.
101
+ This will allow to have logs for when a preview happens
102
+ in the same fashion as all other ActiveStorage events such as
103
+ `upload` and `download` inside `Rails.logger`.
280
104
 
281
- *Breno Gazzola*
105
+ *Chedli Bourguiba*
282
106
 
283
- * Deprecate usage of `purge` and `purge_later` from the association extension.
107
+ * Fix retrieving rotation value from FFmpeg on version 5.0+.
284
108
 
285
- *Jacopo Beschi*
109
+ In FFmpeg version 5.0+ the rotation value has been removed from tags.
110
+ Instead the value can be found in side_data_list. Along with
111
+ this update it's possible to have values of -90, -270 to denote the video
112
+ has been rotated.
286
113
 
287
- * Passing extra parameters in `ActiveStorage::Blob#url` to S3 Client.
114
+ *Haroon Ahmed*
288
115
 
289
- This allows calls of `ActiveStorage::Blob#url` to have more interaction with
290
- the S3 Presigner, enabling, amongst other options, custom S3 domain URL
291
- Generation.
116
+ * Touch all corresponding model records after ActiveStorage::Blob is analyzed
292
117
 
293
- ```ruby
294
- blob = ActiveStorage::Blob.last
118
+ This fixes a race condition where a record can be requested and have a cache entry built, before
119
+ the initial `analyze_later` completes, which will not be invalidated until something else
120
+ updates the record. This also invalidates cache entries when a blob is re-analyzed, which
121
+ is helpful if a bug is fixed in an analyzer or a new analyzer is added.
295
122
 
296
- blob.url # => https://<bucket-name>.s3.<region>.amazonaws.com/<key>
297
- blob.url(virtual_host: true) # => # => https://<bucket-name>/<key>
298
- ```
123
+ *Nate Matykiewicz*
299
124
 
300
- *josegomezr*
125
+ * Add ability to use pre-defined variants when calling `preview` or
126
+ `representation` on an attachment.
301
127
 
302
- * Allow setting a `Cache-Control` on files uploaded to GCS.
128
+ ```ruby
129
+ class User < ActiveRecord::Base
130
+ has_one_attached :file do |attachable|
131
+ attachable.variant :thumb, resize_to_limit: [100, 100]
132
+ end
133
+ end
303
134
 
304
- ```yaml
305
- gcs:
306
- service: GCS
307
- ...
308
- cache_control: "public, max-age=3600"
135
+ <%= image_tag user.file.representation(:thumb) %>
309
136
  ```
310
137
 
311
- *maleblond*
138
+ *Richard Böhme*
312
139
 
313
- * The parameters sent to `ffmpeg` for generating a video preview image are now
314
- configurable under `config.active_storage.video_preview_arguments`.
140
+ * Method `attach` always returns the attachments except when the record
141
+ is persisted, unchanged, and saving it fails, in which case it returns `nil`.
315
142
 
316
- *Brendon Muir*
317
-
318
- * The ActiveStorage video previewer will now use scene change detection to generate
319
- better preview images (rather than the previous default of using the first frame
320
- of the video). This change requires FFmpeg v3.4+.
321
-
322
- *Jonathan Hefner*
143
+ *Santiago Bartesaghi*
323
144
 
324
- * Add support for ActiveStorage expiring URLs.
145
+ * Fixes multiple `attach` calls within transaction not uploading files correctly.
325
146
 
147
+ In the following example, the code failed to upload all but the last file to the configured service.
326
148
  ```ruby
327
- rails_blob_path(user.avatar, disposition: "attachment", expires_in: 30.minutes)
149
+ ActiveRecord::Base.transaction do
150
+ user.attachments.attach({
151
+ content_type: "text/plain",
152
+ filename: "dummy.txt",
153
+ io: ::StringIO.new("dummy"),
154
+ })
155
+ user.attachments.attach({
156
+ content_type: "text/plain",
157
+ filename: "dummy2.txt",
158
+ io: ::StringIO.new("dummy2"),
159
+ })
160
+ end
328
161
 
329
- <%= image_tag rails_blob_path(user.avatar.variant(resize: "100x100"), expires_in: 30.minutes) %>
162
+ assert_equal 2, user.attachments.count
163
+ assert user.attachments.first.service.exist?(user.attachments.first.key) # Fails
330
164
  ```
331
165
 
332
- If you want to set default expiration time for ActiveStorage URLs throughout your application, set `config.active_storage.urls_expire_in`.
333
-
334
- *aki77*
335
-
336
- * Allow to purge an attachment when record is not persisted for `has_many_attached`.
337
-
338
- *Jacopo Beschi*
339
-
340
- * Add `with_all_variant_records` method to eager load all variant records on an attachment at once.
341
- `with_attached_image` scope now eager loads variant records if using variant tracking.
342
-
343
- *Alex Ghiculescu*
344
-
345
- * Add metadata value for presence of audio channel in video blobs.
346
-
347
- The `metadata` attribute of video blobs has a new boolean key named `audio` that is set to
348
- `true` if the file has an audio channel and `false` if it doesn't.
349
-
350
- *Breno Gazzola*
166
+ This was addressed by keeping track of the subchanges pending upload, and uploading them
167
+ once the transaction is committed.
351
168
 
352
- * Adds analyzer for audio files.
169
+ Fixes #41661
353
170
 
354
- *Breno Gazzola*
171
+ *Santiago Bartesaghi*, *Bruno Vezoli*, *Juan Roig*, *Abhay Nikam*
355
172
 
356
- * Respect Active Record's primary_key_type in Active Storage migrations.
173
+ * Raise an exception if `config.active_storage.service` is not set.
357
174
 
358
- *fatkodima*
175
+ If Active Storage is configured and `config.active_storage.service` is not
176
+ set in the respective environment's configuration file, then an exception
177
+ is raised with a meaningful message when attempting to use Active Storage.
359
178
 
360
- * Allow `expires_in` for ActiveStorage signed ids.
179
+ *Ghouse Mohamed*
361
180
 
362
- *aki77*
181
+ * Fixes proxy downloads of files over 5mb
363
182
 
364
- * Allow to purge an attachment when record is not persisted for `has_one_attached`.
365
-
366
- *Jacopo Beschi*
367
-
368
- * Add a load hook called `active_storage_variant_record` (providing `ActiveStorage::VariantRecord`)
369
- to allow for overriding aspects of the `ActiveStorage::VariantRecord` class. This makes
370
- `ActiveStorage::VariantRecord` consistent with `ActiveStorage::Blob` and `ActiveStorage::Attachment`
371
- that already have load hooks.
372
-
373
- *Brendon Muir*
374
-
375
- * `ActiveStorage::PreviewError` is raised when a previewer is unable to generate a preview image.
376
-
377
- *Alex Robbin*
378
-
379
- * Add `ActiveStorage::Streaming` module that can be included in a controller to get access to `#send_blob_stream`,
380
- which wraps the new `ActionController::Base#send_stream` method to stream a blob from cloud storage:
381
-
382
- ```ruby
383
- class MyPublicBlobsController < ApplicationController
384
- include ActiveStorage::SetBlob, ActiveStorage::Streaming
385
-
386
- def show
387
- http_cache_forever(public: true) do
388
- send_blob_stream @blob, disposition: params[:disposition]
389
- end
390
- end
391
- end
392
- ```
183
+ Previously, trying to view and/or download files larger than 5mb stored in
184
+ services like S3 via proxy mode could return corrupted files at around
185
+ 5.2mb or cause random halts in the download. Now,
186
+ `ActiveStorage::Blobs::ProxyController` correctly handles streaming these
187
+ larger files from the service to the client without any issues.
393
188
 
394
- *DHH*
189
+ Fixes #44679
395
190
 
396
- * Add ability to use pre-defined variants.
191
+ *Felipe Raul*
397
192
 
398
- ```ruby
399
- class User < ActiveRecord::Base
400
- has_one_attached :avatar do |attachable|
401
- attachable.variant :thumb, resize: "100x100"
402
- attachable.variant :medium, resize: "300x300", monochrome: true
403
- end
404
- end
193
+ * Saving attachment(s) to a record returns the blob/blobs object
405
194
 
406
- class Gallery < ActiveRecord::Base
407
- has_many_attached :photos do |attachable|
408
- attachable.variant :thumb, resize: "100x100"
409
- attachable.variant :medium, resize: "300x300", monochrome: true
410
- end
411
- end
195
+ Previously, saving attachments did not return the blob/blobs that
196
+ were attached. Now, saving attachments to a record with `#attach`
197
+ method returns the blob or array of blobs that were attached to
198
+ the record. If it fails to save the attachment(s), then it returns
199
+ `false`.
412
200
 
413
- <%= image_tag user.avatar.variant(:thumb) %>
414
- ```
201
+ *Ghouse Mohamed*
415
202
 
416
- *fatkodima*
203
+ * Don't stream responses in redirect mode
417
204
 
418
- * After setting `config.active_storage.resolve_model_to_route = :rails_storage_proxy`
419
- `rails_blob_path` and `rails_representation_path` will generate proxy URLs by default.
205
+ Previously, both redirect mode and proxy mode streamed their
206
+ responses which caused a new thread to be created, and could end
207
+ up leaking connections in the connection pool. But since redirect
208
+ mode doesn't actually send any data, it doesn't need to be
209
+ streamed.
420
210
 
421
- *Ali Ismayilov*
211
+ *Luke Lau*
422
212
 
423
- * Declare `ActiveStorage::FixtureSet` and `ActiveStorage::FixtureSet.blob` to
424
- improve fixture integration.
213
+ * Safe for direct upload on Libraries or Frameworks
425
214
 
426
- *Sean Doyle*
215
+ Enable the use of custom headers during direct uploads, which allows for
216
+ the inclusion of Authorization bearer tokens or other forms of authorization
217
+ tokens through headers.
427
218
 
219
+ *Radamés Roriz*
428
220
 
429
- Please check [6-1-stable](https://github.com/rails/rails/blob/6-1-stable/activestorage/CHANGELOG.md) for previous changes.
221
+ Please check [7-0-stable](https://github.com/rails/rails/blob/7-0-stable/activestorage/CHANGELOG.md) for previous changes.
data/MIT-LICENSE CHANGED
@@ -1,4 +1,4 @@
1
- Copyright (c) 2017-2022 David Heinemeier Hansson, Basecamp
1
+ Copyright (c) David Heinemeier Hansson, 37signals LLC
2
2
 
3
3
  Permission is hereby granted, free of charge, to any person obtaining
4
4
  a copy of this software and associated documentation files (the
data/README.md CHANGED
@@ -6,11 +6,11 @@ Files can be uploaded from the server to the cloud or directly from the client t
6
6
 
7
7
  Image files can furthermore be transformed using on-demand variants for quality, aspect ratio, size, or any other [MiniMagick](https://github.com/minimagick/minimagick) or [Vips](https://www.rubydoc.info/gems/ruby-vips/Vips/Image) supported transformation.
8
8
 
9
- You can read more about Active Storage in the [Active Storage Overview](https://edgeguides.rubyonrails.org/active_storage_overview.html) guide.
9
+ You can read more about Active Storage in the [Active Storage Overview](https://guides.rubyonrails.org/active_storage_overview.html) guide.
10
10
 
11
11
  ## Compared to other storage solutions
12
12
 
13
- A key difference to how Active Storage works compared to other attachment solutions in Rails is through the use of built-in [Blob](https://github.com/rails/rails/blob/main/activestorage/app/models/active_storage/blob.rb) and [Attachment](https://github.com/rails/rails/blob/main/activestorage/app/models/active_storage/attachment.rb) models (backed by Active Record). This means existing application models do not need to be modified with additional columns to associate with files. Active Storage uses polymorphic associations via the `Attachment` join model, which then connects to the actual `Blob`.
13
+ A key difference to how Active Storage works compared to other attachment solutions in \Rails is through the use of built-in [Blob](https://github.com/rails/rails/blob/main/activestorage/app/models/active_storage/blob.rb) and [Attachment](https://github.com/rails/rails/blob/main/activestorage/app/models/active_storage/attachment.rb) models (backed by Active Record). This means existing application models do not need to be modified with additional columns to associate with files. Active Storage uses polymorphic associations via the `Attachment` join model, which then connects to the actual `Blob`.
14
14
 
15
15
  `Blob` models store attachment metadata (filename, content-type, etc.), and their identifier key in the storage service. Blob models do not store the actual binary data. They are intended to be immutable in spirit. One file, one blob. You can associate the same blob with multiple application models as well. And if you want to do transformations of a given `Blob`, the idea is that you'll simply create a new one, rather than attempt to mutate the existing one (though of course you can delete the previous version later if you don't need it).
16
16
 
@@ -144,11 +144,11 @@ Active Storage, with its included JavaScript library, supports uploading directl
144
144
 
145
145
  1. Include the Active Storage JavaScript in your application's JavaScript bundle or reference it directly.
146
146
 
147
- Requiring directly without bundling through the asset pipeline in the application html with autostart:
147
+ Requiring directly without bundling through the asset pipeline in the application HTML with autostart:
148
148
  ```html
149
149
  <%= javascript_include_tag "activestorage" %>
150
150
  ```
151
- Requiring via importmap-rails without bundling through the asset pipeline in the application html without autostart as ESM:
151
+ Requiring via importmap-rails without bundling through the asset pipeline in the application HTML without autostart as ESM:
152
152
  ```ruby
153
153
  # config/importmap.rb
154
154
  pin "@rails/activestorage", to: "activestorage.esm.js"
@@ -508,7 +508,7 @@ function toArray(value) {
508
508
  }
509
509
 
510
510
  class BlobRecord {
511
- constructor(file, checksum, url) {
511
+ constructor(file, checksum, url, customHeaders = {}) {
512
512
  this.file = file;
513
513
  this.attributes = {
514
514
  filename: file.name,
@@ -522,6 +522,9 @@ class BlobRecord {
522
522
  this.xhr.setRequestHeader("Content-Type", "application/json");
523
523
  this.xhr.setRequestHeader("Accept", "application/json");
524
524
  this.xhr.setRequestHeader("X-Requested-With", "XMLHttpRequest");
525
+ Object.keys(customHeaders).forEach((headerKey => {
526
+ this.xhr.setRequestHeader(headerKey, customHeaders[headerKey]);
527
+ }));
525
528
  const csrfToken = getMetaValue("csrf-token");
526
529
  if (csrfToken != undefined) {
527
530
  this.xhr.setRequestHeader("X-CSRF-Token", csrfToken);
@@ -604,11 +607,12 @@ class BlobUpload {
604
607
  let id = 0;
605
608
 
606
609
  class DirectUpload {
607
- constructor(file, url, delegate) {
610
+ constructor(file, url, delegate, customHeaders = {}) {
608
611
  this.id = ++id;
609
612
  this.file = file;
610
613
  this.url = url;
611
614
  this.delegate = delegate;
615
+ this.customHeaders = customHeaders;
612
616
  }
613
617
  create(callback) {
614
618
  FileChecksum.create(this.file, ((error, checksum) => {
@@ -616,7 +620,7 @@ class DirectUpload {
616
620
  callback(error);
617
621
  return;
618
622
  }
619
- const blob = new BlobRecord(this.file, checksum, this.url);
623
+ const blob = new BlobRecord(this.file, checksum, this.url, this.customHeaders);
620
624
  notify(this.delegate, "directUploadWillCreateBlobWithXHR", blob.xhr);
621
625
  blob.create((error => {
622
626
  if (error) {
@@ -841,4 +845,4 @@ function autostart() {
841
845
 
842
846
  setTimeout(autostart, 1);
843
847
 
844
- export { DirectUpload, start };
848
+ export { DirectUpload, DirectUploadController, DirectUploadsController, start };