activestorage 0.1

data/test/filename_test.rb

@@ -0,0 +1,36 @@
+require "test_helper"
+
+class ActiveStorage::FilenameTest < ActiveSupport::TestCase
+  test "sanitize" do
+    "%$|:;/\t\r\n\\".each_char do |character|
+      filename = ActiveStorage::Filename.new("foo#{character}bar.pdf")
+      assert_equal 'foo-bar.pdf', filename.sanitized
+      assert_equal 'foo-bar.pdf', filename.to_s
+    end
+  end
+
+  test "sanitize transcodes to valid UTF-8" do
+    { "\xF6".force_encoding(Encoding::ISO8859_1) => "ö",
+      "\xC3".force_encoding(Encoding::ISO8859_1) => "Ã",
+      "\xAD" => "�",
+      "\xCF" => "�",
+      "\x00" => "",
+    }.each do |actual, expected|
+      assert_equal expected, ActiveStorage::Filename.new(actual).sanitized
+    end
+  end
+
+  test "strips RTL override chars used to spoof unsafe executables as docs" do
+    # Would be displayed in Windows as "evilexe.pdf" due to the right-to-left
+    # (RTL) override char!
+    assert_equal 'evil-fdp.exe', ActiveStorage::Filename.new("evil\u{202E}fdp.exe").sanitized
+  end
+
+  test "compare case-insensitively" do
+    assert_operator ActiveStorage::Filename.new('foobar.pdf'), :==, ActiveStorage::Filename.new('FooBar.PDF')
+  end
+
+  test "compare sanitized" do
+    assert_operator ActiveStorage::Filename.new('foo-bar.pdf'), :==, ActiveStorage::Filename.new("foo\tbar.pdf")
+  end
+end

data/test/service/.gitignore

@@ -0,0 +1 @@
+configurations.yml

data/test/service/configurations-example.yml

@@ -0,0 +1,11 @@
+# Copy this file to configurations.yml and edit the credentials to match your IAM test account and bucket
+s3:
+  access_key_id:
+  secret_access_key:
+  region:
+  bucket:
+
+gcs:
+  project:
+  keyfile:
+  bucket:

data/test/service/disk_service_test.rb

@@ -0,0 +1,8 @@
+require "tmpdir"
+require "service/shared_service_tests"
+
+class ActiveStorage::Service::DiskServiceTest < ActiveSupport::TestCase
+  SERVICE = ActiveStorage::Service.configure(:Disk, root: File.join(Dir.tmpdir, "active_storage"))
+
+  include ActiveStorage::Service::SharedServiceTests
+end

data/test/service/gcs_service_test.rb

@@ -0,0 +1,20 @@
+require "service/shared_service_tests"
+
+if SERVICE_CONFIGURATIONS[:gcs]
+  class ActiveStorage::Service::GCSServiceTest < ActiveSupport::TestCase
+    SERVICE = ActiveStorage::Service.configure(:GCS, SERVICE_CONFIGURATIONS[:gcs])
+
+    include ActiveStorage::Service::SharedServiceTests
+
+    test "signed URL generation" do
+      travel_to Time.now do
+        url = SERVICE.bucket.signed_url(FIXTURE_KEY, expires: 120) +
+          "&response-content-disposition=inline%3B+filename%3D%22test.txt%22"
+
+        assert_equal url, @service.url(FIXTURE_KEY, expires_in: 2.minutes, disposition: :inline, filename: "test.txt")
+      end
+    end
+  end
+else
+  puts "Skipping GCS Service tests because no GCS configuration was supplied"
+end

data/test/service/mirror_service_test.rb

@@ -0,0 +1,50 @@
+require "tmpdir"
+require "service/shared_service_tests"
+
+class ActiveStorage::Service::MirrorServiceTest < ActiveSupport::TestCase
+  PRIMARY_DISK_SERVICE   = ActiveStorage::Service.configure(:Disk, root: File.join(Dir.tmpdir, "active_storage"))
+  SECONDARY_DISK_SERVICE = ActiveStorage::Service.configure(:Disk, root: File.join(Dir.tmpdir, "active_storage_mirror"))
+
+  SERVICE = ActiveStorage::Service.configure :Mirror, services: [ PRIMARY_DISK_SERVICE, SECONDARY_DISK_SERVICE ]
+
+  include ActiveStorage::Service::SharedServiceTests
+
+  test "uploading to all services" do
+    begin
+      data = "Something else entirely!"
+      key  = upload(data, to: @service)
+
+      assert_equal data, PRIMARY_DISK_SERVICE.download(key)
+      assert_equal data, SECONDARY_DISK_SERVICE.download(key)
+    ensure
+      @service.delete key
+    end
+  end
+
+  test "downloading from primary service" do
+    data = "Something else entirely!"
+    key  = upload(data, to: PRIMARY_DISK_SERVICE)
+
+    assert_equal data, @service.download(key)
+  end
+
+  test "deleting from all services" do
+    @service.delete FIXTURE_KEY
+    assert_not PRIMARY_DISK_SERVICE.exist?(FIXTURE_KEY)
+    assert_not SECONDARY_DISK_SERVICE.exist?(FIXTURE_KEY)
+  end
+
+  test "URL generation in primary service" do
+    travel_to Time.now do
+      assert_equal PRIMARY_DISK_SERVICE.url(FIXTURE_KEY, expires_in: 2.minutes, disposition: :inline, filename: "test.txt"),
+        @service.url(FIXTURE_KEY, expires_in: 2.minutes, disposition: :inline, filename: "test.txt")
+    end
+  end
+
+  private
+    def upload(data, to:)
+      SecureRandom.base58(24).tap do |key|
+        @service.upload key, StringIO.new(data), checksum: Digest::MD5.base64digest(data)
+      end
+    end
+end

data/test/service/s3_service_test.rb

@@ -0,0 +1,11 @@
+require "service/shared_service_tests"
+
+if SERVICE_CONFIGURATIONS[:s3]
+  class ActiveStorage::Service::S3ServiceTest < ActiveSupport::TestCase
+    SERVICE = ActiveStorage::Service.configure(:S3, SERVICE_CONFIGURATIONS[:s3])
+
+    include ActiveStorage::Service::SharedServiceTests
+  end
+else
+  puts "Skipping S3 Service tests because no S3 configuration was supplied"
+end

data/test/service/shared_service_tests.rb

@@ -0,0 +1,68 @@
+require "test_helper"
+require "active_support/core_ext/securerandom"
+require "yaml"
+
+SERVICE_CONFIGURATIONS = begin
+  YAML.load_file(File.expand_path("../configurations.yml", __FILE__)).deep_symbolize_keys 
+rescue Errno::ENOENT
+  puts "Missing service configuration file in test/services/configurations.yml"
+end
+
+module ActiveStorage::Service::SharedServiceTests
+  extend ActiveSupport::Concern
+
+  FIXTURE_KEY  = SecureRandom.base58(24)
+  FIXTURE_FILE = StringIO.new("Hello world!")
+
+  included do
+    setup do
+      @service = self.class.const_get(:SERVICE)
+      @service.upload FIXTURE_KEY, FIXTURE_FILE
+      FIXTURE_FILE.rewind
+    end
+
+    teardown do
+      @service.delete FIXTURE_KEY
+      FIXTURE_FILE.rewind
+    end
+
+    test "uploading with integrity" do
+      begin
+        key  = SecureRandom.base58(24)
+        data = "Something else entirely!"
+        @service.upload(key, StringIO.new(data), checksum: Digest::MD5.base64digest(data))
+
+        assert_equal data, @service.download(key)
+      ensure
+        @service.delete key
+      end
+    end
+
+    test "upload without integrity" do
+      begin
+        key  = SecureRandom.base58(24)
+        data = "Something else entirely!"
+
+        assert_raises(ActiveStorage::IntegrityError) do
+          @service.upload(key, StringIO.new(data), checksum: "BAD_CHECKSUM")
+        end
+      ensure
+        @service.delete key
+      end
+    end
+
+    test "downloading" do
+      assert_equal FIXTURE_FILE.read, @service.download(FIXTURE_KEY)
+    end
+
+    test "existing" do
+      assert @service.exist?(FIXTURE_KEY)
+      assert_not @service.exist?(FIXTURE_KEY + "nonsense")
+    end
+
+    test "deleting" do
+      @service.delete FIXTURE_KEY
+      assert_not @service.exist?(FIXTURE_KEY)
+    end
+  end
+end

data/test/test_helper.rb

@@ -0,0 +1,28 @@
+require "bundler/setup"
+require "active_support"
+require "active_support/test_case"
+require "active_support/testing/autorun"
+require "byebug"
+
+require "active_storage"
+
+require "active_storage/service"
+ActiveStorage::Blob.service = ActiveStorage::Service.configure(:Disk, root: File.join(Dir.tmpdir, "active_storage"))
+
+require "active_storage/verified_key_with_expiration"
+ActiveStorage::VerifiedKeyWithExpiration.verifier = ActiveSupport::MessageVerifier.new("Testing")
+
+class ActiveSupport::TestCase
+  private
+    def create_blob(data: "Hello world!", filename: "hello.txt", content_type: "text/plain")
+      ActiveStorage::Blob.create_after_upload! io: StringIO.new(data), filename: filename, content_type: content_type
+    end
+end
+
+
+require "active_storage/attached"
+ActiveRecord::Base.send :extend, ActiveStorage::Attached::Macros
+
+require "global_id"
+GlobalID.app = "ActiveStorageExampleApp"
+ActiveRecord::Base.send :include, GlobalID::Identification

data/test/verified_key_with_expiration_test.rb

@@ -0,0 +1,19 @@
+require "test_helper"
+require "active_support/core_ext/securerandom"
+
+class ActiveStorage::VerifiedKeyWithExpirationTest < ActiveSupport::TestCase
+  FIXTURE_KEY = SecureRandom.base58(24)
+
+  test "without expiration" do
+    encoded_key = ActiveStorage::VerifiedKeyWithExpiration.encode(FIXTURE_KEY)
+    assert_equal FIXTURE_KEY, ActiveStorage::VerifiedKeyWithExpiration.decode(encoded_key)
+  end
+
+  test "with expiration" do
+    encoded_key = ActiveStorage::VerifiedKeyWithExpiration.encode(FIXTURE_KEY, expires_in: 1.minute)
+    assert_equal FIXTURE_KEY, ActiveStorage::VerifiedKeyWithExpiration.decode(encoded_key)
+
+    travel 2.minutes
+    assert_nil ActiveStorage::VerifiedKeyWithExpiration.decode(encoded_key)
+  end
+end

metadata

@@ -0,0 +1,171 @@
+--- !ruby/object:Gem::Specification
+name: activestorage
+version: !ruby/object:Gem::Version
+  version: '0.1'
+platform: ruby
+authors:
+- David Heinemeier Hansson
+autorequire: 
+bindir: bin
+cert_chain: []
+date: 2017-07-06 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '5.1'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '5.1'
+- !ruby/object:Gem::Dependency
+  name: activerecord
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '5.1'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '5.1'
+- !ruby/object:Gem::Dependency
+  name: actionpack
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '5.1'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '5.1'
+- !ruby/object:Gem::Dependency
+  name: activejob
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '5.1'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '5.1'
+- !ruby/object:Gem::Dependency
+  name: bundler
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.15'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.15'
+description: 
+email: david@basecamp.com
+executables: []
+extensions: []
+extra_rdoc_files: []
+files:
+- ".gitignore"
+- Gemfile
+- Gemfile.lock
+- MIT-LICENSE
+- README.md
+- Rakefile
+- activestorage.gemspec
+- lib/active_storage.rb
+- lib/active_storage/attached.rb
+- lib/active_storage/attached/macros.rb
+- lib/active_storage/attached/many.rb
+- lib/active_storage/attached/one.rb
+- lib/active_storage/attachment.rb
+- lib/active_storage/blob.rb
+- lib/active_storage/disk_controller.rb
+- lib/active_storage/download.rb
+- lib/active_storage/filename.rb
+- lib/active_storage/migration.rb
+- lib/active_storage/purge_job.rb
+- lib/active_storage/railtie.rb
+- lib/active_storage/service.rb
+- lib/active_storage/service/disk_service.rb
+- lib/active_storage/service/gcs_service.rb
+- lib/active_storage/service/mirror_service.rb
+- lib/active_storage/service/s3_service.rb
+- lib/active_storage/storage_services.yml
+- lib/active_storage/verified_key_with_expiration.rb
+- lib/tasks/activestorage.rake
+- test/attachments_test.rb
+- test/blob_test.rb
+- test/database/create_users_migration.rb
+- test/database/setup.rb
+- test/disk_controller_test.rb
+- test/filename_test.rb
+- test/service/.gitignore
+- test/service/configurations-example.yml
+- test/service/disk_service_test.rb
+- test/service/gcs_service_test.rb
+- test/service/mirror_service_test.rb
+- test/service/s3_service_test.rb
+- test/service/shared_service_tests.rb
+- test/test_helper.rb
+- test/verified_key_with_expiration_test.rb
+homepage: https://github.com/rails/activestorage
+licenses:
+- MIT
+metadata: {}
+post_install_message: 
+rdoc_options: []
+require_paths:
+- lib
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: 2.3.0
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: '0'
+requirements: []
+rubyforge_project: 
+rubygems_version: 2.6.11
+signing_key: 
+specification_version: 4
+summary: Attach cloud and local files in Rails applications
+test_files:
+- test/attachments_test.rb
+- test/blob_test.rb
+- test/database/create_users_migration.rb
+- test/database/setup.rb
+- test/disk_controller_test.rb
+- test/filename_test.rb
+- test/service/.gitignore
+- test/service/configurations-example.yml
+- test/service/disk_service_test.rb
+- test/service/gcs_service_test.rb
+- test/service/mirror_service_test.rb
+- test/service/s3_service_test.rb
+- test/service/shared_service_tests.rb
+- test/test_helper.rb
+- test/verified_key_with_expiration_test.rb