activestorage 0.1 → 5.2.0.beta1

data/test/attachments_test.rb

@@ -1,95 +0,0 @@
-require "test_helper"
-require "database/setup"
-require "active_storage/blob"
-
-require "active_job"
-ActiveJob::Base.queue_adapter = :test
-ActiveJob::Base.logger = nil
-
-# ActiveRecord::Base.logger = Logger.new(STDOUT)
-
-class User < ActiveRecord::Base
-  has_one_attached  :avatar
-  has_many_attached :highlights
-end
-
-class ActiveStorage::AttachmentsTest < ActiveSupport::TestCase
-  include ActiveJob::TestHelper
-
-  setup { @user = User.create!(name: "DHH") }
-
-  teardown { ActiveStorage::Blob.all.each(&:purge) }
-
-  test "attach existing blob" do
-    @user.avatar.attach create_blob(filename: "funky.jpg")
-    assert_equal "funky.jpg", @user.avatar.filename.to_s
-  end
-
-  test "attach new blob" do
-    @user.avatar.attach io: StringIO.new("STUFF"), filename: "town.jpg", content_type: "image/jpg"
-    assert_equal "town.jpg", @user.avatar.filename.to_s
-  end
-
-  test "purge attached blob" do
-    @user.avatar.attach create_blob(filename: "funky.jpg")
-    avatar_key = @user.avatar.key
-
-    @user.avatar.purge
-    assert_not @user.avatar.attached?
-    assert_not ActiveStorage::Blob.service.exist?(avatar_key)
-  end
-
-  test "purge attached blob later when the record is destroyed" do
-    @user.avatar.attach create_blob(filename: "funky.jpg")
-    avatar_key = @user.avatar.key
-
-    perform_enqueued_jobs do
-      @user.destroy
-
-      assert_nil ActiveStorage::Blob.find_by(key: avatar_key)
-      assert_not ActiveStorage::Blob.service.exist?(avatar_key)
-    end
-  end
-
-
-  test "attach existing blobs" do
-    @user.highlights.attach create_blob(filename: "funky.jpg"), create_blob(filename: "wonky.jpg")
-
-    assert_equal "funky.jpg", @user.highlights.first.filename.to_s
-    assert_equal "wonky.jpg", @user.highlights.second.filename.to_s
-  end
-
-  test "attach new blobs" do
-    @user.highlights.attach(
-      { io: StringIO.new("STUFF"), filename: "town.jpg", content_type: "image/jpg" }, 
-      { io: StringIO.new("IT"), filename: "country.jpg", content_type: "image/jpg" })
-
-    assert_equal "town.jpg", @user.highlights.first.filename.to_s
-    assert_equal "country.jpg", @user.highlights.second.filename.to_s
-  end
-
-  test "purge attached blobs" do
-    @user.highlights.attach create_blob(filename: "funky.jpg"), create_blob(filename: "wonky.jpg")
-    highlight_keys = @user.highlights.collect(&:key)
-    
-    @user.highlights.purge
-    assert_not @user.highlights.attached?
-    assert_not ActiveStorage::Blob.service.exist?(highlight_keys.first)
-    assert_not ActiveStorage::Blob.service.exist?(highlight_keys.second)
-  end
-
-  test "purge attached blobs later when the record is destroyed" do
-    @user.highlights.attach create_blob(filename: "funky.jpg"), create_blob(filename: "wonky.jpg")
-    highlight_keys = @user.highlights.collect(&:key)
-
-    perform_enqueued_jobs do
-      @user.destroy
-
-      assert_nil ActiveStorage::Blob.find_by(key: highlight_keys.first)
-      assert_not ActiveStorage::Blob.service.exist?(highlight_keys.first)
-
-      assert_nil ActiveStorage::Blob.find_by(key: highlight_keys.second)
-      assert_not ActiveStorage::Blob.service.exist?(highlight_keys.second)
-    end
-  end
-end

data/test/blob_test.rb

@@ -1,28 +0,0 @@
-require "test_helper"
-require "database/setup"
-require "active_storage/blob"
-
-class ActiveStorage::BlobTest < ActiveSupport::TestCase
-  test "create after upload sets byte size and checksum" do
-    data = "Hello world!"
-    blob = create_blob data: data
-
-    assert_equal data, blob.download
-    assert_equal data.length, blob.byte_size
-    assert_equal Digest::MD5.base64digest(data), blob.checksum
-  end
-
-  test "urls expiring in 5 minutes" do
-    blob = create_blob
-
-    travel_to Time.now do
-      assert_equal expected_url_for(blob), blob.url
-      assert_equal expected_url_for(blob, disposition: :attachment), blob.url(disposition: :attachment)
-    end
-  end
-
-  private
-    def expected_url_for(blob, disposition: :inline)
-      "/rails/blobs/#{ActiveStorage::VerifiedKeyWithExpiration.encode(blob.key, expires_in: 5.minutes)}?disposition=#{disposition}"
-    end
-end

data/test/database/create_users_migration.rb

@@ -1,7 +0,0 @@
-class ActiveStorage::CreateUsers < ActiveRecord::Migration[5.1]
-  def change
-    create_table :users do |t|
-      t.string :name
-    end
-  end
-end

data/test/database/setup.rb

@@ -1,6 +0,0 @@
-require "active_storage/migration"
-require_relative "create_users_migration"
-
-ActiveRecord::Base.establish_connection(adapter: 'sqlite3', database: ':memory:')
-ActiveStorage::CreateTables.migrate(:up)
-ActiveStorage::CreateUsers.migrate(:up)

data/test/disk_controller_test.rb

@@ -1,34 +0,0 @@
-require "test_helper"
-require "database/setup"
-
-require "action_controller"
-require "action_controller/test_case"
-
-require "active_storage/disk_controller"
-require "active_storage/verified_key_with_expiration"
-
-class ActiveStorage::DiskControllerTest < ActionController::TestCase
-  Routes = ActionDispatch::Routing::RouteSet.new.tap do |routes|
-    routes.draw do
-      get "/rails/blobs/:encoded_key" => "active_storage/disk#show", as: :rails_disk_blob
-    end
-  end
-
-  setup do
-    @blob = create_blob
-    @routes = Routes
-    @controller = ActiveStorage::DiskController.new
-  end
-
-  test "showing blob inline" do
-    get :show, params: { encoded_key: ActiveStorage::VerifiedKeyWithExpiration.encode(@blob.key, expires_in: 5.minutes) }
-    assert_equal "inline; filename=\"#{@blob.filename}\"", @response.headers["Content-Disposition"]
-    assert_equal "text/plain", @response.headers["Content-Type"]
-  end
-
-  test "sending blob as attachment" do
-    get :show, params: { encoded_key: ActiveStorage::VerifiedKeyWithExpiration.encode(@blob.key, expires_in: 5.minutes), disposition: :attachment }
-    assert_equal "attachment; filename=\"#{@blob.filename}\"", @response.headers["Content-Disposition"]
-    assert_equal "text/plain", @response.headers["Content-Type"]
-  end
-end

data/test/filename_test.rb

@@ -1,36 +0,0 @@
-require "test_helper"
-
-class ActiveStorage::FilenameTest < ActiveSupport::TestCase
-  test "sanitize" do
-    "%$|:;/\t\r\n\\".each_char do |character|
-      filename = ActiveStorage::Filename.new("foo#{character}bar.pdf")
-      assert_equal 'foo-bar.pdf', filename.sanitized
-      assert_equal 'foo-bar.pdf', filename.to_s
-    end
-  end
-
-  test "sanitize transcodes to valid UTF-8" do
-    { "\xF6".force_encoding(Encoding::ISO8859_1) => "ö",
-      "\xC3".force_encoding(Encoding::ISO8859_1) => "Ã",
-      "\xAD" => "�",
-      "\xCF" => "�",
-      "\x00" => "",
-    }.each do |actual, expected|
-      assert_equal expected, ActiveStorage::Filename.new(actual).sanitized
-    end
-  end
-
-  test "strips RTL override chars used to spoof unsafe executables as docs" do
-    # Would be displayed in Windows as "evilexe.pdf" due to the right-to-left
-    # (RTL) override char!
-    assert_equal 'evil-fdp.exe', ActiveStorage::Filename.new("evil\u{202E}fdp.exe").sanitized
-  end
-
-  test "compare case-insensitively" do
-    assert_operator ActiveStorage::Filename.new('foobar.pdf'), :==, ActiveStorage::Filename.new('FooBar.PDF')
-  end
-
-  test "compare sanitized" do
-    assert_operator ActiveStorage::Filename.new('foo-bar.pdf'), :==, ActiveStorage::Filename.new("foo\tbar.pdf")
-  end
-end

data/test/service/.gitignore

@@ -1 +0,0 @@
-configurations.yml

data/test/service/configurations-example.yml

@@ -1,11 +0,0 @@
-# Copy this file to configurations.yml and edit the credentials to match your IAM test account and bucket
-s3:
-  access_key_id:
-  secret_access_key:
-  region:
-  bucket:
-
-gcs:
-  project:
-  keyfile:
-  bucket:

data/test/service/disk_service_test.rb

@@ -1,8 +0,0 @@
-require "tmpdir"
-require "service/shared_service_tests"
-
-class ActiveStorage::Service::DiskServiceTest < ActiveSupport::TestCase
-  SERVICE = ActiveStorage::Service.configure(:Disk, root: File.join(Dir.tmpdir, "active_storage"))
-
-  include ActiveStorage::Service::SharedServiceTests
-end

data/test/service/gcs_service_test.rb

@@ -1,20 +0,0 @@
-require "service/shared_service_tests"
-
-if SERVICE_CONFIGURATIONS[:gcs]
-  class ActiveStorage::Service::GCSServiceTest < ActiveSupport::TestCase
-    SERVICE = ActiveStorage::Service.configure(:GCS, SERVICE_CONFIGURATIONS[:gcs])
-
-    include ActiveStorage::Service::SharedServiceTests
-
-    test "signed URL generation" do
-      travel_to Time.now do
-        url = SERVICE.bucket.signed_url(FIXTURE_KEY, expires: 120) +
-          "&response-content-disposition=inline%3B+filename%3D%22test.txt%22"
-
-        assert_equal url, @service.url(FIXTURE_KEY, expires_in: 2.minutes, disposition: :inline, filename: "test.txt")
-      end
-    end
-  end
-else
-  puts "Skipping GCS Service tests because no GCS configuration was supplied"
-end

data/test/service/mirror_service_test.rb

@@ -1,50 +0,0 @@
-require "tmpdir"
-require "service/shared_service_tests"
-
-class ActiveStorage::Service::MirrorServiceTest < ActiveSupport::TestCase
-  PRIMARY_DISK_SERVICE   = ActiveStorage::Service.configure(:Disk, root: File.join(Dir.tmpdir, "active_storage"))
-  SECONDARY_DISK_SERVICE = ActiveStorage::Service.configure(:Disk, root: File.join(Dir.tmpdir, "active_storage_mirror"))
-
-  SERVICE = ActiveStorage::Service.configure :Mirror, services: [ PRIMARY_DISK_SERVICE, SECONDARY_DISK_SERVICE ]
-
-  include ActiveStorage::Service::SharedServiceTests
-
-  test "uploading to all services" do
-    begin
-      data = "Something else entirely!"
-      key  = upload(data, to: @service)
-
-      assert_equal data, PRIMARY_DISK_SERVICE.download(key)
-      assert_equal data, SECONDARY_DISK_SERVICE.download(key)
-    ensure
-      @service.delete key
-    end
-  end
-
-  test "downloading from primary service" do
-    data = "Something else entirely!"
-    key  = upload(data, to: PRIMARY_DISK_SERVICE)
-
-    assert_equal data, @service.download(key)
-  end
-
-  test "deleting from all services" do
-    @service.delete FIXTURE_KEY
-    assert_not PRIMARY_DISK_SERVICE.exist?(FIXTURE_KEY)
-    assert_not SECONDARY_DISK_SERVICE.exist?(FIXTURE_KEY)
-  end
-
-  test "URL generation in primary service" do
-    travel_to Time.now do
-      assert_equal PRIMARY_DISK_SERVICE.url(FIXTURE_KEY, expires_in: 2.minutes, disposition: :inline, filename: "test.txt"),
-        @service.url(FIXTURE_KEY, expires_in: 2.minutes, disposition: :inline, filename: "test.txt")
-    end
-  end
-
-  private
-    def upload(data, to:)
-      SecureRandom.base58(24).tap do |key|
-        @service.upload key, StringIO.new(data), checksum: Digest::MD5.base64digest(data)
-      end
-    end
-end

data/test/service/s3_service_test.rb

@@ -1,11 +0,0 @@
-require "service/shared_service_tests"
-
-if SERVICE_CONFIGURATIONS[:s3]
-  class ActiveStorage::Service::S3ServiceTest < ActiveSupport::TestCase
-    SERVICE = ActiveStorage::Service.configure(:S3, SERVICE_CONFIGURATIONS[:s3])
-
-    include ActiveStorage::Service::SharedServiceTests
-  end
-else
-  puts "Skipping S3 Service tests because no S3 configuration was supplied"
-end

data/test/service/shared_service_tests.rb

@@ -1,68 +0,0 @@
-require "test_helper"
-require "active_support/core_ext/securerandom"
-require "yaml"
-
-SERVICE_CONFIGURATIONS = begin
-  YAML.load_file(File.expand_path("../configurations.yml", __FILE__)).deep_symbolize_keys 
-rescue Errno::ENOENT
-  puts "Missing service configuration file in test/services/configurations.yml"
-end
-
-module ActiveStorage::Service::SharedServiceTests
-  extend ActiveSupport::Concern
-
-  FIXTURE_KEY  = SecureRandom.base58(24)
-  FIXTURE_FILE = StringIO.new("Hello world!")
-
-  included do
-    setup do
-      @service = self.class.const_get(:SERVICE)
-      @service.upload FIXTURE_KEY, FIXTURE_FILE
-      FIXTURE_FILE.rewind
-    end
-
-    teardown do
-      @service.delete FIXTURE_KEY
-      FIXTURE_FILE.rewind
-    end
-
-    test "uploading with integrity" do
-      begin
-        key  = SecureRandom.base58(24)
-        data = "Something else entirely!"
-        @service.upload(key, StringIO.new(data), checksum: Digest::MD5.base64digest(data))
-
-        assert_equal data, @service.download(key)
-      ensure
-        @service.delete key
-      end
-    end
-
-    test "upload without integrity" do
-      begin
-        key  = SecureRandom.base58(24)
-        data = "Something else entirely!"
-
-        assert_raises(ActiveStorage::IntegrityError) do
-          @service.upload(key, StringIO.new(data), checksum: "BAD_CHECKSUM")
-        end
-      ensure
-        @service.delete key
-      end
-    end
-
-    test "downloading" do
-      assert_equal FIXTURE_FILE.read, @service.download(FIXTURE_KEY)
-    end
-
-    test "existing" do
-      assert @service.exist?(FIXTURE_KEY)
-      assert_not @service.exist?(FIXTURE_KEY + "nonsense")
-    end
-
-    test "deleting" do
-      @service.delete FIXTURE_KEY
-      assert_not @service.exist?(FIXTURE_KEY)
-    end
-  end
-end

data/test/test_helper.rb

@@ -1,28 +0,0 @@
-require "bundler/setup"
-require "active_support"
-require "active_support/test_case"
-require "active_support/testing/autorun"
-require "byebug"
-
-require "active_storage"
-
-require "active_storage/service"
-ActiveStorage::Blob.service = ActiveStorage::Service.configure(:Disk, root: File.join(Dir.tmpdir, "active_storage"))
-
-require "active_storage/verified_key_with_expiration"
-ActiveStorage::VerifiedKeyWithExpiration.verifier = ActiveSupport::MessageVerifier.new("Testing")
-
-class ActiveSupport::TestCase
-  private
-    def create_blob(data: "Hello world!", filename: "hello.txt", content_type: "text/plain")
-      ActiveStorage::Blob.create_after_upload! io: StringIO.new(data), filename: filename, content_type: content_type
-    end
-end
-
-
-require "active_storage/attached"
-ActiveRecord::Base.send :extend, ActiveStorage::Attached::Macros
-
-require "global_id"
-GlobalID.app = "ActiveStorageExampleApp"
-ActiveRecord::Base.send :include, GlobalID::Identification

data/test/verified_key_with_expiration_test.rb

@@ -1,19 +0,0 @@
-require "test_helper"
-require "active_support/core_ext/securerandom"
-
-class ActiveStorage::VerifiedKeyWithExpirationTest < ActiveSupport::TestCase
-  FIXTURE_KEY = SecureRandom.base58(24)
-
-  test "without expiration" do
-    encoded_key = ActiveStorage::VerifiedKeyWithExpiration.encode(FIXTURE_KEY)
-    assert_equal FIXTURE_KEY, ActiveStorage::VerifiedKeyWithExpiration.decode(encoded_key)
-  end
-
-  test "with expiration" do
-    encoded_key = ActiveStorage::VerifiedKeyWithExpiration.encode(FIXTURE_KEY, expires_in: 1.minute)
-    assert_equal FIXTURE_KEY, ActiveStorage::VerifiedKeyWithExpiration.decode(encoded_key)
-
-    travel 2.minutes
-    assert_nil ActiveStorage::VerifiedKeyWithExpiration.decode(encoded_key)
-  end
-end