activestorage-hotcell-server 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: db442348d3994653c203d9d5ab83373d73c36fedc8bd6e22e9ac038f88bb3f66
-  data.tar.gz: 654f3937bb892200fb4fb4edbddf06ebc80c2e896ffb4d484549538c519c26de
+  metadata.gz: 89dcb6743b4bb87dacc1351b9dec256ef7dd1c887caf13c9242c4c4abc05c1de
+  data.tar.gz: 93b579fc94d6670fd6008b58e98c10fba06d50c3b63b8bf691ea6f35ae1526bf
 SHA512:
-  metadata.gz: 93e1b31a60d950149622c0d18f068b70253ac6b4a4e303837ff078d0dcbd2e912600da942efa33c9b7956a640dd36921dbc510b6d8649e54d73b14be63955944
-  data.tar.gz: f531653511415fe1394b1148f2b989c42e05125c86f0f058a5e24937f0426080049a2ace8400d90112d0e8d7415cb3f4ea9db2f7a0136d923d7c5efdb43b4109
+  metadata.gz: 999c462832530390ac5cc300a69b2673246e1a99759bdb9a92625af721523ec72ab16988107a1b4049e4a8e41cdb8f7d6612a87b7e33d647e5947a98325d2b78
+  data.tar.gz: c076edca15955f2cd668a43ac54a3c23011f6f8ca935ab4d08a7db7a1623fc2b1d2906d719070a4a09f4ea99a9d75c2356abac236bdc5cb4df746eec1d438b06

data/lib/active_storage/hot_cell/server/magick_operation.rb

@@ -50,9 +50,12 @@ module ActiveStorage
         abstract_operation
 
         # MiniMagick::Error is how mini_magick reports a `magick` that exited non-zero — the common shape of an
-        # input it cannot decode. MiniMagick::Invalid is an input `identify` rejects outright. Both are the
-        # input's fault rather than the operation's.
-        unreadable MiniMagick::Error, MiniMagick::Invalid
+        # input it cannot decode. MiniMagick::Invalid is an input `identify` rejects outright.
+        # ImageProcessing::Error is the pipeline's own verdict on the input against the requested
+        # transform — a multi-layer source into a single-layer destination, for example. All three are
+        # the input's fault rather than the operation's; unclassified, each was a transient `failed`
+        # that never marked the blob, so the same file spent a full conversion on every request.
+        unreadable MiniMagick::Error, MiniMagick::Invalid, ImageProcessing::Error
 
         # **Accepted risk.** A tool's output is not bounded on this path. `Operation#run_tool` caps what it
         # reads at 64KB and drops the rest as it arrives, because an input that makes a tool print gigabytes

data/lib/active_storage/hot_cell/server/version.rb

@@ -3,7 +3,7 @@
 module ActiveStorage
   module HotCell
     module Server
-      VERSION = "0.3.0"
+      VERSION = "0.3.1"
     end
   end
 end

data/lib/active_storage/hot_cell/server/vips_operation.rb

@@ -22,8 +22,10 @@ module ActiveStorage
 
         # Vips::Error is how libvips reports a file it cannot decode, which is common rather than exceptional: it
         # covers truncated uploads, formats this build was not compiled with, and formats deliberately refused by
-        # block_untrusted. All of those are the input's fault and none is the operation's.
-        unreadable Vips::Error
+        # block_untrusted. ImageProcessing::Error is the pipeline's own verdict on the input against the
+        # requested transform, classified the same way. All of those are the input's fault and none is
+        # the operation's.
+        unreadable Vips::Error, ImageProcessing::Error
 
         # Requires and configures. It must never evaluate an image, and the reason is mechanical: libvips starts
         # its thread pool on the first evaluation, that pool does not survive fork, and the child then waits on a

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activestorage-hotcell-server
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Mike Dalessio
@@ -15,14 +15,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.3.0
+        version: 0.3.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.3.0
+        version: 0.3.1
 - !ruby/object:Gem::Dependency
   name: image_processing
   requirement: !ruby/object:Gem::Requirement
@@ -99,8 +99,8 @@ licenses:
 - MIT
 metadata:
   homepage_uri: https://github.com/basecamp/hotcell
-  source_code_uri: https://github.com/basecamp/hotcell/tree/v0.3.0/activestorage-hotcell-server
-  changelog_uri: https://github.com/basecamp/hotcell/blob/v0.3.0/CHANGELOG.md
+  source_code_uri: https://github.com/basecamp/hotcell/tree/v0.3.1/activestorage-hotcell-server
+  changelog_uri: https://github.com/basecamp/hotcell/blob/v0.3.1/CHANGELOG.md
   bug_tracker_uri: https://github.com/basecamp/hotcell/issues
   rubygems_mfa_required: 'true'
 rdoc_options: []