activestorage-aliyun 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 796ec942f06897cf76873d1b6dadeb23a565345f
-  data.tar.gz: fd06616edba762ac6ccf4e352cbec7a17fc220dd
+SHA256:
+  metadata.gz: 7a6e97cb757b635493a02597209f20c7b73283f6922b604fac48836cb86c323f
+  data.tar.gz: c3472d980a98774ce2e4592c68cef5fd36b88423243fc1c9a5fa0b76f39518e4
 SHA512:
-  metadata.gz: 91698652328b356a3df0c7fbd1fa45a4f5e7185df39d097d19402fdf77e3eaad9190af997c4b21ed89dac385e87c9cebf27ef6303ca222a912291c8feec77f1b
-  data.tar.gz: d935a34961783cd60f41055480557a14017a01b3db3b60194c39a2801f8907c38ed403cb578b6244803070e30f1c037cbbc85d8330421ea61bff2e40049aff69
+  metadata.gz: 6f1c434607f6db1ae7383143b9ac4d8673b8b39af86c1ae130c9617bb1d23fc81ca9cb458d25b7b432f5199ee4856a9741ae84f229d7669ef4408c32218ff0b3
+  data.tar.gz: 2a748673e30e2d73cc4b335c017265592ccfca051f3bf4ae775a72731549dfc376aeaca94dd35866cf15bc58d48d994fa54782ead184dcfe19760cff28be91a8

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+## 0.4.0
+
+- Support present `params` to `service_url` to oss image url.
+
+for example:
+
+```rb
+@photo.image.service_url(params: { 'x-oss-process' => "image/resize,h_100,w_100" })
+```
+
 ## 0.3.0
 
 - Add `mode` config for setup OSS ACL, `mode: "private"` will always output URL that have signature info.

data/README.md

@@ -43,10 +43,22 @@ production:
 Orignial File URL:
 
 <%= image_tag @photo.image.service_url %>
+```
 
 Thumb with OSS image service:
 
-<%= image_tag @photo.image.service_url(filename: 'x-oss-process=image/resize,h_100,w_100') %>
+```rb
+class Photo < ApplicationRecord
+  def image_thumb_url(process)
+    self.image.service_url(params: { "x-oss-process" => process })
+  end
+end
+```
+
+And then:
+
+```erb
+<%= image_tag @photo.image.image_thumb_url("image/resize,h_100,w_100") %>
 ```
 
 ### Use for file download

data/lib/active_storage/service/aliyun_service.rb

@@ -52,19 +52,18 @@ module ActiveStorage
       end
     end
 
-    def url(key, expires_in:, filename:, content_type:, disposition:)
+    def url(key, expires_in:, filename: nil, content_type:, disposition:, params: {})
       instrument :url, key: key do |payload|
         sign    = private_mode? || disposition == :attachment
         filekey = path_for(key)
-        params  = {}
 
         if disposition == :attachment
           params["response-content-type"] = content_type if content_type
-          params["response-content-disposition"] = "attachment;filename*=UTF-8''#{CGI.escape(filename.to_s)}"
-        else
-          if filename.to_s.include?("x-oss-process")
-            params["x-oss-process"] = filename.to_s.split("=").last
+          unless filename.is_a?(ActiveStorage::Filename)
+            filename = ActiveStorage::Filename.new(filename)
           end
+
+          params["response-content-disposition"] = content_disposition_with(type: disposition, filename: filename)
         end
 
         generated_url = object_url(filekey, sign: sign, expires_in: expires_in, params: params)

data/lib/active_storage_aliyun/version.rb

@@ -1,3 +1,3 @@
 module ActiveStorageAliyun
-  VERSION = '0.3.0'
+  VERSION = '0.4.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activestorage-aliyun
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Jason Lee
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 5.2.0.rc
+        version: 5.2.0.rc2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 5.2.0.rc
+        version: 5.2.0.rc2
 - !ruby/object:Gem::Dependency
   name: aliyun-sdk
   requirement: !ruby/object:Gem::Requirement
@@ -71,7 +71,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Wraps the Aliyun OSS as an Active Storage service