activerpc 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e424564ef40dfcc5c6a1e802a8e7767a7111f5de76ebd52b7f91581f61bae195
-  data.tar.gz: 2d27258a00946665bd4795f124c3eb63f6ce59ed5056d3b0396c422d611c22e8
+  metadata.gz: '08b7d8b162f3cba366564c7571b55a1c1f3b772a6f989edf8e70974b49e2b97f'
+  data.tar.gz: 37c2e93c5fdfd169625ed06d53fc027dda638e39c30f5b37dec452607dc27e4d
 SHA512:
-  metadata.gz: 1f62f60e31e8ae1e26922693d3666f4f48ebac57f1eaf4a02dc96b9254f8636ae926addf08edef1ee67759c4344510e64d23b3454ac4fdf1a64be1886537898a
-  data.tar.gz: '040801f682a44861de03fbaa779f5d223c21de825e0581a328d114b22f651c14d92fe523c995a8966a085d2b4402e9e198b08ebfb4469cbcb0cc17a14a9d43bd'
+  metadata.gz: '0910eb2988cdff04085a38a805a45587a4fc0e24002d703fdde3a101e41cf16ece5a6149f2bca0f2a96144269d4fa9a2f5b13d78c7a56cd5c509d466556e1eff'
+  data.tar.gz: e9cf2a2059e0888a121d9c18007e933905d531be57e47a876a9c69c1fa087cd2cdef14339aa804adfc2da1f729a54688b9ad06c7fdea3a3ce0941815d5192187

data/README.md

@@ -25,12 +25,13 @@ Or install it yourself as:
 $ gem install activerpc
 ```
 
-Once you've installed the gem, you can add an initializer to configure things
-such as controller lifecycle actions.
+The final step is to add a `mount` directive to your
+routes file, like so:
 
 ```ruby
-ActiveRpc.configure do |config|
-  config.before_action = MyBeforeAction # something that responds to `.before`
+Rails.application.routes.draw do
+  # other routes...
+  mount ActiveRpc::Engine => "/rpc"
 end
 ```
 
@@ -94,6 +95,23 @@ ActiveRpc.configure do |config|
 end
 ```
 
+Alternatively, you can use mixins to extend the functionality to get more
+control.
+
+```ruby
+ActiveRpc::RpcController.send(:include, Module.new do
+  extend ActiveSupport::Concern
+
+  included do
+    around_action do
+      start = Time.now
+      yield
+      puts "took #{Time.now - start}"
+    end
+  end
+end)
+```
+
 #### Development Mode
 Please note, in development mode you might have issues with the operation classes
 being autoloaded. The new bootloader in Rails 6 will solve this, but until then you

data/lib/active_rpc/operation.rb

@@ -1,3 +1,7 @@
+require 'active_model/model'
+require 'active_model/validations'
+require 'active_model/validations/callbacks'
+
 module ActiveRpc
   class Operation
     include ActiveModel::Model

data/lib/active_rpc/rack_server.rb

@@ -0,0 +1,69 @@
+module ActiveRpc
+  class RackServer
+    def self.call(env)
+      new(Rack::Request.new(env)).call
+    end
+
+    attr_reader :request
+
+    def initialize(request)
+      @request = request
+    end
+
+    def call
+      res = nil
+      begin
+        res = case body
+              when Array then body.map(&method(:process_item)).map(&:to_hash)
+              when Hash then process_item(body).to_hash
+              end
+      rescue JSON::ParserError => ex
+        res = ActiveRpc::Response.new do |r|
+          r.error = Errors::ParseError.new(message: ex.to_s)
+        end.to_hash
+      end
+
+      [
+        200,
+        {'Content-Type' => 'application/json'},
+        [JSON.generate(res)]
+      ]
+    end
+
+    private def process_item(item)
+      req = ActiveRpc::Request.new(item.slice('id', 'method', 'params'))
+      res = ActiveRpc::Response.from_request(req)
+      ex = nil
+
+      begin
+        raise TypeError, 'invalid JSON-RPC request' unless req.valid?
+
+        executor = ActiveRpc.get_executor(req.method)
+        raise NoMethodError, "undefined operation `#{req.method}'" unless executor
+
+        ex = executor.new(req.params)
+        raise ArgumentError, 'invalid payload' unless ex.valid?
+        res.result = ex.call
+      rescue TypeError => e
+        res.error = Errors::ClientError.new(message: e.to_s)
+        res.error.data = req.errors
+      rescue NoMethodError => e
+        res.error = Errors::NoMethodError.new(message: e.to_s)
+      rescue ArgumentError => e
+        res.error = Errors::ArgumentError.new(message: e.to_s)
+        res.error.data = ex.errors
+      rescue OperationFailure => e
+        res.error = e.rpc_error
+      # todo: handle rpc-level errors
+      rescue => e
+        res.error = Errors::InternalError.new(message: e.to_s)
+      end
+
+      res
+    end
+
+    private def body
+      @body ||= JSON.load(request.body.read)
+    end
+  end
+end

data/lib/active_rpc/request.rb

@@ -1,3 +1,6 @@
+require 'active_model/model'
+require 'active_model/validations'
+
 module ActiveRpc
   class Request
     include ActiveModel::Model

data/lib/active_rpc/version.rb

@@ -1,3 +1,3 @@
 module ActiveRpc
-  VERSION = '0.2.0'
+  VERSION = '0.3.0'
 end

data/lib/active_rpc.rb

@@ -1,4 +1,4 @@
-require 'active_rpc/engine'
+require 'active_rpc/engine' if defined?(Rails)
 require 'active_rpc/errors'
 require 'active_rpc/configuration'
 require 'active_rpc/operation'

data/lib/activerpc.rb

@@ -1 +1 @@
-require "active_rpc"
+require 'active_rpc'

metadata

@@ -1,15 +1,35 @@
 --- !ruby/object:Gem::Specification
 name: activerpc
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - John Maxwell
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-03-10 00:00:00.000000000 Z
+date: 2019-03-14 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: activemodel
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '4.2'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '7.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '4.2'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '7.0'
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
@@ -20,7 +40,7 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: '7.0'
-  type: :runtime
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
@@ -67,6 +87,7 @@ files:
 - lib/active_rpc/engine.rb
 - lib/active_rpc/errors.rb
 - lib/active_rpc/operation.rb
+- lib/active_rpc/rack_server.rb
 - lib/active_rpc/request.rb
 - lib/active_rpc/response.rb
 - lib/active_rpc/version.rb
@@ -90,8 +111,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.1
 signing_key: 
 specification_version: 4
 summary: JSONRpc 2.0 Server library for Rails