activerecord_views 0.0.19 → 0.0.20

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 4abfbb8e0d3997f414810c95fec10c72d205b496
-  data.tar.gz: 0a441b8cbf5102e31a6dcabe631aca2ba0573448
+SHA256:
+  metadata.gz: b7bd9cd5324106a6834c7121d6dc674bb622a61866edcecd968a0ed87b2000c2
+  data.tar.gz: 850fcbff468562ace2ae45a4cf8a9f255ef0e9dcc26be6efba8191247731b4b3
 SHA512:
-  metadata.gz: 32ea38c39c48f983b5bf77343b70e2744ec15352dfabd157dbc944299a41eda074863430fb73af3840e63ea22f0c08b2b16b0ad1ca5c67a20bb675c016d6ce1a
-  data.tar.gz: 99df12b314ab50305db7e276ac18421c82fc01a548ccc266f71e53d3ad4c13d37e60f21d2399068691fe9be88384b19ba7fd177a97fe054102d95298d616584b
+  metadata.gz: a87e872a8469f95873acf78c06ab136156514c70d0fecf63da7f0a6038ebd39cd75e0a79b52786abcff8f5b23fc443dd8393d0a6f96d57d23864c846fce1df28
+  data.tar.gz: 6bf70cae5bffa0791d9d5ad82ea931cb06b02e893d19fd801c33b5401f841e2b5cb01ed88574762a6448f2ec3e0d9e0e0310139ec25a1105b7cb6858b7cb2eeb

data/lib/active_record_views.rb

@@ -152,19 +152,21 @@ module ActiveRecordViews
     end
   end
 
-  def self.drop_all_views(connection)
-    names = Set.new connection.select_values('SELECT name FROM active_record_views;')
+  def self.drop_all_views(base_connection)
+    without_transaction base_connection do |connection|
+      names = Set.new connection.select_values('SELECT name FROM active_record_views;')
 
-    func = lambda do |name|
-      if view_exists?(connection, name)
-        get_view_dependants(connection, name).each do |dependant_name, _, _, _|
-          func.call(dependant_name)
+      func = lambda do |name|
+        if view_exists?(connection, name)
+          get_view_dependants(connection, name).each do |dependant_name, _, _, _|
+            func.call(dependant_name)
+          end
+          drop_view connection, name
         end
-        drop_view connection, name
       end
-    end
 
-    names.each { |name| func.call(name) }
+      names.each { |name| func.call(name) }
+    end
   end
 
   def self.execute_create_view(connection, name, sql, options)

data/lib/active_record_views/version.rb

@@ -1,3 +1,3 @@
 module ActiveRecordViews
-  VERSION = '0.0.19'
+  VERSION = '0.0.20'
 end

data/spec/active_record_views_spec.rb

@@ -120,6 +120,21 @@ describe ActiveRecordViews do
             expect(view_names).to match_array %w[unmanaged]
           end
 
+          it 'support being ran inside a transaction' do
+            expect(ActiveRecordViews).to receive(:without_transaction).at_least(:once).and_wrap_original do |original, *args, &block|
+              original.call(*args) do |new_connection|
+                new_connection.execute 'SET statement_timeout = 1000'
+                block.call(new_connection)
+              end
+            end
+
+            connection.transaction requires_new: true do
+              expect {
+                ActiveRecordViews.drop_all_views connection
+              }.to change { view_names }
+            end
+          end
+
           it 'errors if an unmanaged view depends on a managed view' do
             connection.execute 'CREATE VIEW unmanaged AS SELECT * from dependant2a'
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord_views
 version: !ruby/object:Gem::Version
-  version: 0.0.19
+  version: 0.0.20
 platform: ruby
 authors:
 - Jason Weathered
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-11-13 00:00:00.000000000 Z
+date: 2019-02-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -154,7 +154,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.14.3
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Automatic database view creation for ActiveRecord