activerecord_views 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: be3aa1741d6dced3c4afcf32a941d3821ec0eafc
-  data.tar.gz: f29929115236d12395bad521420b03a4f799f382
+  metadata.gz: b51b3b3424c22f7b7eba5af6e221abdea9adcb77
+  data.tar.gz: 9847c0226785c69c854488bb8a0dd607ef5c8b70
 SHA512:
-  metadata.gz: 6c623e3dec891c353d1bb3d2b4a6466a2ea4ea520d5c4082007a3303c358982b6e832d251e9127b37ce0ba1b366cb866547eaa0ae57173fb868d0c4683582e4f
-  data.tar.gz: 7cde80415bc90e545f7cdcc6f987525c7c53050e59a2e26b8a83838f40c0f9e9cbbeae29ad15568e4a4e886a028b3bfce359167453d56f7af0d80a89111e3d3d
+  metadata.gz: 5f1e2b8e83b4bb47686d9dcecfb82dae020f21a6993dbf75c71d20022c8b90c37295000044d2bebc509c0c8078a3d5c40d763ddb2ee70e15099bf2c9fb764a42
+  data.tar.gz: 9407222259bcf7c5f2e2ee375de1a859a39f072cde39df1ffaa3b66fc56df003d9414adb3886117ebb04d62f0084c6829b6a1e257d4711f07e02973e98f300a2

data/lib/active_record_views/checksum_cache.rb

@@ -9,7 +9,12 @@ module ActiveRecordViews
       table_exists = @connection.table_exists?('active_record_views')
 
       if table_exists && !@connection.column_exists?('active_record_views', 'class_name')
-        @connection.execute 'DROP TABLE active_record_views;'
+        @connection.transaction :requires_new => true do
+          @connection.select_values('SELECT name FROM active_record_views;').each do |view_name|
+            @connection.execute "DROP VIEW IF EXISTS #{view_name} CASCADE;"
+          end
+          @connection.execute 'DROP TABLE active_record_views;'
+        end
         table_exists = false
       end
 

data/lib/active_record_views/version.rb

@@ -1,3 +1,3 @@
 module ActiveRecordViews
-  VERSION = '0.0.4'
+  VERSION = '0.0.5'
 end

data/spec/active_record_views_checksum_cache_spec.rb

@@ -30,15 +30,29 @@ describe ActiveRecordViews::ChecksumCache do
     context 'with old table' do
       before do
         connection.execute 'CREATE TABLE active_record_views(name text PRIMARY KEY, checksum text NOT NULL);'
+
+        connection.execute 'CREATE VIEW test_view AS SELECT 42 AS id;'
+        connection.execute "INSERT INTO active_record_views VALUES ('test_view', 'dummy');"
+
+        connection.execute 'CREATE VIEW other_view AS SELECT 123 AS id;'
       end
 
-      it 'recreates the table' do
-        expect(ActiveRecord::Base.connection).to receive(:execute).with(/\ADROP TABLE active_record_views/).once.and_call_original
+      it 'drops existing managed views recreates the table' do
+        expect(ActiveRecord::Base.connection).to receive(:execute).with(/\ABEGIN\z/).once.and_call_original
+        expect(ActiveRecord::Base.connection).to receive(:execute).with(/\ADROP VIEW IF EXISTS test_view CASCADE;\z/).once.and_call_original
+        expect(ActiveRecord::Base.connection).to receive(:execute).with(/\ADROP TABLE active_record_views;\z/).once.and_call_original
         expect(ActiveRecord::Base.connection).to receive(:execute).with(/\ACREATE TABLE active_record_views/).once.and_call_original
+        expect(ActiveRecord::Base.connection).to receive(:execute).with(/\ACOMMIT\z/).once.and_call_original
 
         expect(connection.column_exists?('active_record_views', 'class_name')).to eq false
+        expect(ActiveRecordViews.view_exists?(connection, 'test_view')).to eq true
+        expect(ActiveRecordViews.view_exists?(connection, 'other_view')).to eq true
+
         ActiveRecordViews::ChecksumCache.new(connection)
+
         expect(connection.column_exists?('active_record_views', 'class_name')).to eq true
+        expect(ActiveRecordViews.view_exists?(connection, 'test_view')).to eq false
+        expect(ActiveRecordViews.view_exists?(connection, 'other_view')).to eq true
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activerecord_views
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Jason Weathered