activerecord_enum 0.0.1 → 0.0.2

data/.gitignore

@@ -2,3 +2,4 @@
 .bundle
 Gemfile.lock
 pkg/*
+spec/database.yml

data/.travis.yml

@@ -0,0 +1,5 @@
+before_script:
+  - "mysql -e 'create database activerecord_enum_test;' >/dev/null"
+  - "cp spec/{.travis.,}database.yml"
+env:
+  - DB=mysql

data/README.markdown

@@ -2,6 +2,8 @@
 
 Provides ActiveRecord support for the nonstandard `ENUM` and `SET` data types.
 
+[![Build Status](http://travis-ci.org/iangreenleaf/activerecord_enum.png)](http://travis-ci.org/iangreenleaf/activerecord_enum)
+
 ## Hypothetically asked questions
 
 ### Y U NO WORK?!
@@ -11,6 +13,6 @@ Sorry, it currently only works with Rails 3.0.x and the mysql2 adapter. I plan t
 Right now it really only supports schema operations - attribute access is left untouched. I'll be working on that too at some point.
 
 ### Nonstandard SQL?! What's your problem, jerkweed?
-This isn't a plugin everyone should use. There are a number of plugins to simulate enum behavior backed by standard datatypes. Personally, I like [https://github.com/nofxx/symbolize].
+This isn't a plugin everyone should use. There are a number of plugins to simulate enum behavior backed by standard data types. Personally, I like [nofxx/symbolize](https://github.com/nofxx/symbolize).
 
 However, sometimes we can't or won't avoid working with these data types. When that happens, I got you covered.

data/Rakefile

@@ -1,10 +1,33 @@
 require 'bundler'
 Bundler::GemHelper.install_tasks
 
+DB_CONFIG = "spec/database.yml"
+
 require 'rake'
-desc 'Default: run unit tests.'
-task :default => :spec
+desc 'Default: run all unit tests.'
+task :default => :"spec:all"
+
+namespace :db do
+  desc 'Prepare the databases.'
+  task :prepare do
+    unless File.exist? DB_CONFIG
+      cp "#{config_file}.tmpl", DB_CONFIG
+    end
+    #TODO would be nice to create the DBs here
+  end
+end
 
 require "rspec/core/rake_task"
 desc 'Run the test suite.'
 RSpec::Core::RakeTask.new(:spec)
+
+desc 'Run the test suite for all DBs.'
+namespace :spec do
+  task :all do
+    db_config = YAML::load(IO.read(DB_CONFIG))
+    db_config.each do |db,config|
+      ENV["DB"] = db
+      Rake::Task["spec"].invoke
+    end
+  end
+end

data/lib/activerecord_enum/version.rb

@@ -1,3 +1,3 @@
 module ActiverecordEnum
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/lib/activerecord_enum.rb

@@ -1,8 +1,22 @@
 require 'active_record'
+require 'active_record/base'
 require 'active_record/connection_adapters/mysql2_adapter'
 require 'active_record/connection_adapters/abstract/schema_definitions.rb'
+require 'active_record/attribute_methods/write'
 
-module ActiverecordEnum
+module ActiveRecord
+  module AttributeMethods
+    module Write
+      def write_attribute_with_enum(attr_name, value)
+        if (column = column_for_attribute(attr_name)) && column.set? && value.respond_to?(:join)
+          value = value.join ","
+        end
+        write_attribute_without_enum attr_name, value
+      end
+      alias_method :write_attribute_without_enum, :write_attribute
+      alias_method :write_attribute, :write_attribute_with_enum
+    end
+  end
 end
 
 module ActiveRecord
@@ -67,6 +81,14 @@ module ActiveRecord
           extract_default default
         end
       end
+
+      def set?
+        type == :set
+      end
+
+      def enum?
+        type == :enum
+      end
     end
   end
 end

data/spec/.travis.database.yml

@@ -0,0 +1,4 @@
+mysql:
+  adapter: mysql2
+  database: activerecord_enum_test
+  username:

data/spec/database.yml.tmpl

@@ -0,0 +1,6 @@
+mysql:
+  adapter: mysql2
+  host: localhost
+  database: enum_test
+  username: enum_test
+  password: enum_test

data/spec/enum_spec.rb

@@ -40,9 +40,4 @@ describe "ENUM datatype" do
       subject[ "Type" ].should == "enum('small','medium','large')"
     end
   end
-
-  describe "validation" do
-    it "validates assigned value is member of the list"
-    it "allows nil when null enabled"
-  end
 end

data/spec/set_spec.rb

@@ -42,14 +42,40 @@ describe "SET datatype" do
   end
 
   describe "assignment" do
-    it "accepts single value"
-    it "accepts array of values"
-    it "accepts comma-separated values"
+    before { load_schema "set_new" }
+    it "accepts single value" do
+      b = Balloon.create :gasses => "helium"
+      b.should be_valid
+      b.reload.gasses.should == "helium"
+    end
+    it "accepts array of values" do
+      b = Balloon.create :gasses => [ "helium", "hydrogen" ]
+      b.should be_valid
+      b.reload.gasses.should == "helium,hydrogen"
+    end
+    it "accepts comma-separated values" do
+      b = Balloon.create :gasses => "helium,hydrogen"
+      b.should be_valid
+      b.reload.gasses.should == "helium,hydrogen"
+    end
+    it "accepts empty list" do
+      b = Balloon.create :gasses => [ ]
+      b.should be_valid
+      b.reload.gasses.should == ""
+    end
   end
 
-  describe "validation" do
-    it "validates assigned values are members of the list"
-    it "allows nil when null enabled"
-    it "allows empty list"
+  describe "getter" do
+    before do
+      load_schema "set_new"
+      ActiveRecord::Base.connection.execute "INSERT INTO balloons (gasses) VALUES ('helium,hydrogen')"
+      @b = Balloon.first
+    end
+    it "returns comma-separated values by default" do
+      @b.gasses.should == "helium,hydrogen"
+    end
+    it "returns array of values when config option is set"
   end
 end
+
+class Balloon < ActiveRecord::Base; end

data/spec/spec_helper.rb

@@ -20,14 +20,6 @@ def dumped_schema
   stream.string.lines.select {|l| /^\s*#/.match(l).nil? }.join
 end
 
-ActiveRecord::Base.configurations = {
-  "enum_test" => {
-    :adapter => "mysql2",
-    :host => "localhost",
-    :username => "enum_test",
-    :password => "enum_test",
-    :database => "enum_test",
-    :socket => "/tmp/mysql.sock"
-  },
-}
-ActiveRecord::Base.establish_connection "enum_test"
+ActiveRecord::Base.configurations = YAML::load(IO.read("spec/database.yml"))
+db = ENV["DB"] || "mysql"
+ActiveRecord::Base.establish_connection db

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: activerecord_enum
 version: !ruby/object:Gem::Version 
-  hash: 29
+  hash: 27
   prerelease: 
   segments: 
   - 0
   - 0
-  - 1
-  version: 0.0.1
+  - 2
+  version: 0.0.2
 platform: ruby
 authors: 
 - Ian Young
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-08-19 00:00:00 -07:00
+date: 2011-09-02 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -105,12 +105,15 @@ extra_rdoc_files: []
 
 files: 
 - .gitignore
+- .travis.yml
 - Gemfile
 - README.markdown
 - Rakefile
 - activerecord_enum.gemspec
 - lib/activerecord_enum.rb
 - lib/activerecord_enum/version.rb
+- spec/.travis.database.yml
+- spec/database.yml.tmpl
 - spec/enum_spec.rb
 - spec/schema/enum_new.rb
 - spec/schema/enum_old.rb
@@ -153,6 +156,7 @@ signing_key:
 specification_version: 3
 summary: Enum data types for ActiveRecord
 test_files: 
+- spec/database.yml.tmpl
 - spec/enum_spec.rb
 - spec/schema/enum_new.rb
 - spec/schema/enum_old.rb