activerecord_archive 1.0.2 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f053c38eeeae82a50f8d165bf5674f9ecb9b4f91e4dac9783b9819dc5a4dffd4
-  data.tar.gz: d6b2051f4d9953e2c2c9cc5582a3d3191f4e3aeb60f641b2ab865b4f51e3d4a4
+  metadata.gz: ec6caa129b25d19c6f0f399c91509018130b38f4bbed884de7efebf7df1d5137
+  data.tar.gz: f02746ec310b8ad11af8a08e2c04a4b5ee023b442e194c7d236be8ae4134bec4
 SHA512:
-  metadata.gz: 19bd05bc6cea7616a99ae742ed670d9b7511352be015642f83003bb70426c3f80ea5a56ef6f3a2bbd88df7e6e66963c6f5fcae6e182d191bbb32c96d0c324a43
-  data.tar.gz: ed1c62bd3905ae5731f6e24ec968af6fa3e260256e43a356553d78844714857452b9a9816d306d8412fa9db4524aa579be322a90ac9b664a639e06308eba3814
+  metadata.gz: dcb76d080936e53506cadf4e2d2353d10072ab8472c6d2b8d861fc5829e1a690a1e3e2fdee0b0d67c34cdd9eeab8c01d7ef87b03f98033fdcf7054ba52301a87
+  data.tar.gz: 914075c3c87ae28ede48f1500b226cf7d213a355fd836c59a0c9e6962fe50b6ff46d123daa1b4e2934157f27a536012a0939d5deef5507fa0e1243acbf1350d1

data/lib/activerecord_archive.rb

@@ -10,6 +10,7 @@ module ArchiveMethods # :nodoc:
     end
 
     raise 'PrefixAndTableNameTooLong - maximum is 64 characters' if "#{options[:prefix]}#{tabname}".size > 64
+    raise 'PrimaryKey id expected but not found' unless self.primary_key == 'id'
 
     # do a simple query first in case to cause an exception if there is an error in conditions
     ActiveRecord::Base.connection.execute("
@@ -23,11 +24,13 @@ module ArchiveMethods # :nodoc:
         LIKE #{tabname}
     ")
 
+    # use replace into in case of duplicate inserts
     ActiveRecord::Base.connection.execute("
-      INSERT INTO #{options[:prefix]}#{tabname}
+      REPLACE INTO #{options[:prefix]}#{tabname}
         SELECT * FROM #{tabname} WHERE #{conditions}
     ")
 
+    # delete only records in parent table where ids match those in archive table
     ActiveRecord::Base.connection.execute("
       DELETE FROM #{tabname}
       WHERE EXISTS(
@@ -48,6 +51,7 @@ module ArchiveMethods # :nodoc:
     end
 
     raise 'PrefixAndTableNameTooLong - maximum is 64 characters' if "#{options[:prefix]}#{tabname}".size > 64
+    raise 'PrimaryKey id expected but not found' unless self.primary_key == 'id'
 
     # do a simple query first in case to cause an exception if there is an error in conditions
     ActiveRecord::Base.connection.execute("
@@ -56,11 +60,13 @@ module ArchiveMethods # :nodoc:
       WHERE #{conditions}
     ")
 
+    # use replace into in case of duplicate inserts
     ActiveRecord::Base.connection.execute("
-      INSERT INTO #{tabname}
+      REPLACE INTO #{tabname}
         SELECT * FROM #{options[:prefix]}#{tabname} WHERE #{conditions}
     ")
 
+    # delete only records in archive table where ids match those in parent table
     ActiveRecord::Base.connection.execute("
       DELETE FROM #{options[:prefix]}#{tabname}
       WHERE EXISTS(

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord_archive
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors:
 - Vic Spanner
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-07-15 00:00:00.000000000 Z
+date: 2022-02-24 00:00:00.000000000 Z
 dependencies: []
 description: A simple archiving extension for ActiveRecord. Archive old records to
   improve database performance. Restore old records from archive tables.
@@ -37,7 +37,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.0.6
 signing_key: 
 specification_version: 4
 summary: ActiveRecord Archiving