activerecord_archive 1.0.1 → 1.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ac9d3219f20ca205595ab51f2d8e8828529353e18c26771689a2a5e28ca63406
-  data.tar.gz: 50dd7d5cd6b7bdf09e92464eff4595164d82471a046051d97dee739f46b90bd7
+  metadata.gz: 2d3c010163dccd7143c45dbaf0680598ea4cc5dc688c389bd174d75ebaa9ae36
+  data.tar.gz: 2a495578d9ec68a760283ee2f40660037b433d112024818c5e6dc03292a961af
 SHA512:
-  metadata.gz: 54e184d8cda7b6557ec32a16ab0fadc09cc39b2b3e3c0ab51e41dd6cb4b31af68c5f7c0a2ebda88d473af8291e92cb2ae1c8d9d4399ea6473bd4176c346f66fa
-  data.tar.gz: 5a06805897fe374fdb27dfb165a7e96a2993f63f3e5619a2a0243dce6dfe8f60e18aa05ffbf1c7a1f0fa2217932e56f3e1ff1e17ad74ef2120d4bb3c81a8e758
+  metadata.gz: fb595069da61e90ff49e74a29cfa3d04eb18460d7be9d1826253e4c1cfef29120c942dd28e6a02a9212e6f6f110fef985fab7ec5a3bff30d0d1a5412582a3e12
+  data.tar.gz: 77f0556795226e4204c40e844a1d788962d4f02468e07627bc0d85c118e984808ec121492309eaf03c538ac802dd96ddeee869b0e7c14ecb82826fd3270918e4

data/lib/activerecord_archive.rb

@@ -10,6 +10,7 @@ module ArchiveMethods # :nodoc:
     end
 
     raise 'PrefixAndTableNameTooLong - maximum is 64 characters' if "#{options[:prefix]}#{tabname}".size > 64
+    raise 'PrimaryKey id expected but not found' unless self.primary_key == 'id'
 
     # do a simple query first in case to cause an exception if there is an error in conditions
     ActiveRecord::Base.connection.execute("
@@ -23,11 +24,25 @@ module ArchiveMethods # :nodoc:
         LIKE #{tabname}
     ")
 
+    # use replace into in case of duplicate inserts
     ActiveRecord::Base.connection.execute("
-      INSERT INTO #{options[:prefix]}#{tabname}
+      REPLACE INTO #{options[:prefix]}#{tabname}
         SELECT * FROM #{tabname} WHERE #{conditions}
     ")
 
+    if options[:recursive_foreign_key] && !options[:recursive_foreign_key].blank?
+      # for self-referencing foreign keys, delete child records first
+      # delete only records in parent table where ids match those in archive table
+      ActiveRecord::Base.connection.execute("
+        DELETE FROM #{tabname}
+        WHERE #{tabname}.#{options[:recursive_foreign_key]} IS NOT NULL AND EXISTS(
+          SELECT #{options[:prefix]}#{tabname}.id
+          FROM #{options[:prefix]}#{tabname}
+          WHERE #{options[:prefix]}#{tabname}.id = #{tabname}.id)
+      ")
+    end
+
+    # delete only records in parent table where ids match those in archive table
     ActiveRecord::Base.connection.execute("
       DELETE FROM #{tabname}
       WHERE EXISTS(
@@ -48,6 +63,7 @@ module ArchiveMethods # :nodoc:
     end
 
     raise 'PrefixAndTableNameTooLong - maximum is 64 characters' if "#{options[:prefix]}#{tabname}".size > 64
+    raise 'PrimaryKey id expected but not found' unless self.primary_key == 'id'
 
     # do a simple query first in case to cause an exception if there is an error in conditions
     ActiveRecord::Base.connection.execute("
@@ -56,11 +72,27 @@ module ArchiveMethods # :nodoc:
       WHERE #{conditions}
     ")
 
-    ActiveRecord::Base.connection.execute("
-      INSERT INTO #{tabname}
+    if options[:recursive_foreign_key] && !options[:recursive_foreign_key].blank?
+      # use replace into in case of duplicate inserts
+      # for self-referencing foreign keys, insert parent records first
+      ActiveRecord::Base.connection.execute("
+      REPLACE INTO #{tabname}
+        SELECT * FROM #{options[:prefix]}#{tabname} WHERE (#{conditions}) AND #{options[:prefix]}#{tabname}.#{options[:recursive_foreign_key]} IS NULL
+      ")
+      # now insert child records
+      ActiveRecord::Base.connection.execute("
+      REPLACE INTO #{tabname}
+        SELECT * FROM #{options[:prefix]}#{tabname} WHERE (#{conditions}) AND #{options[:prefix]}#{tabname}.#{options[:recursive_foreign_key]} IS NOT NULL
+      ")
+    else
+      # use replace into in case of duplicate inserts
+      ActiveRecord::Base.connection.execute("
+      REPLACE INTO #{tabname}
         SELECT * FROM #{options[:prefix]}#{tabname} WHERE #{conditions}
-    ")
+      ")
+    end
 
+    # delete only records in archive table where ids match those in parent table
     ActiveRecord::Base.connection.execute("
       DELETE FROM #{options[:prefix]}#{tabname}
       WHERE EXISTS(

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord_archive
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.4
 platform: ruby
 authors:
 - Vic Spanner
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-07-15 00:00:00.000000000 Z
+date: 2022-02-24 00:00:00.000000000 Z
 dependencies: []
 description: A simple archiving extension for ActiveRecord. Archive old records to
   improve database performance. Restore old records from archive tables.
@@ -30,14 +30,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.0.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.0.6
 signing_key: 
 specification_version: 4
 summary: ActiveRecord Archiving