activerecord 8.1.0.rc1 → 8.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0f6a8286538d4ed09b1508bed7ded4b5b40629d71cbee9467c8926968413da05
-  data.tar.gz: ef5f9492d1efa2285bb03fdfe9d808e86ffadc768f0265257aba7d93bd5c32ad
+  metadata.gz: a92548efaf2245d66ddb7383470faf4182ac1d28a65f71824ba6a83c69b753fd
+  data.tar.gz: e019fc7a41a862fa0f0393ee6d8dd46589af1dd04ee0c9f1ddfde6716401c011
 SHA512:
-  metadata.gz: cad145e87e54f6bfd6cc35294e4aa25471f705e08eae4497a10c75af5ff204b8205728bf41e0ff43d1a2713c712d53b56ba35fbdfdb2df8a3204edc8c9c46eef
-  data.tar.gz: a8792d05c5c847e1c22daff04e84a662afd6847f07368fea7be61876c434f6e233f1d295c296f0c40adaa24896def1f985edc241c589489e4153554a4b15d5c7
+  metadata.gz: db83ab09afcb9232bc722208fd8add11064cefc613667592711d7ec21347e0933eddec2a9cdf1f4eb7f07a973a11d54a821b776da0861e320cfece6684e47a3c
+  data.tar.gz: 4e47cbdb388a3f4e00b55f775bf2d9397b80e1f27478e8ce00b4cb783d3ee8de72088c5303697d1080c2f5f58d6c81c053c980c984f2755d6d8224453fa684f2

data/CHANGELOG.md

@@ -1,4 +1,26 @@
-## Rails 8.1.0.rc1 (October 15, 2025) ##
+## Rails 8.1.0 (October 22, 2025) ##
+
+*   Fix SQLite3 data loss during table alterations with CASCADE foreign keys.
+
+    When altering a table in SQLite3 that is referenced by child tables with
+    `ON DELETE CASCADE` foreign keys, ActiveRecord would silently delete all
+    data from the child tables. This occurred because SQLite requires table
+    recreation for schema changes, and during this process the original table
+    is temporarily dropped, triggering CASCADE deletes on child tables.
+
+    The root cause was incorrect ordering of operations. The original code
+    wrapped `disable_referential_integrity` inside a transaction, but
+    `PRAGMA foreign_keys` cannot be modified inside a transaction in SQLite -
+    attempting to do so simply has no effect. This meant foreign keys remained
+    enabled during table recreation, causing CASCADE deletes to fire.
+
+    The fix reverses the order to follow the official SQLite 12-step ALTER TABLE
+    procedure: `disable_referential_integrity` now wraps the transaction instead
+    of being wrapped by it. This ensures foreign keys are properly disabled
+    before the transaction starts and re-enabled after it commits, preventing
+    CASCADE deletes while maintaining data integrity through atomic transactions.
+
+    *Ruy Rocha*
 
 *   Add replicas to test database parallelization setup.
 
@@ -103,8 +125,6 @@
 
     *Rob Lewis*
 
-## Rails 8.1.0.beta1 (September 04, 2025) ##
-
 *   Remove deprecated `:unsigned_float` and `:unsigned_decimal` column methods for MySQL.
 
     *Rafael Mendonça França*

data/lib/active_record/connection_adapters/postgresql/schema_dumper.rb

@@ -42,6 +42,7 @@ module ActiveRecord
                 types.sort.each do |name, values|
                   stream.puts "  create_enum #{relation_name(name).inspect}, #{values.inspect}"
                 end
+                stream.puts
               end
             end
           end

data/lib/active_record/connection_adapters/sqlite3_adapter.rb

@@ -613,8 +613,8 @@ module ActiveRecord
             yield definition if block_given?
           end
 
-          transaction do
-            disable_referential_integrity do
+          disable_referential_integrity do
+            transaction do
               move_table(table_name, altered_table_name, options.merge(temporary: true))
               move_table(altered_table_name, table_name, &caller)
             end

data/lib/active_record/connection_handling.rb

@@ -173,9 +173,11 @@ module ActiveRecord
       prevent_writes = true if role == ActiveRecord.reading_role
 
       append_to_connected_to_stack(role: role, shard: shard, prevent_writes: prevent_writes, klasses: classes)
-      yield
-    ensure
-      connected_to_stack.pop
+      begin
+        yield
+      ensure
+        connected_to_stack.pop
+      end
     end
 
     # Passes the block to +connected_to+ for every +shard+ the
@@ -396,11 +398,13 @@ module ActiveRecord
         prevent_writes = true if role == ActiveRecord.reading_role
 
         append_to_connected_to_stack(role: role, shard: shard, prevent_writes: prevent_writes, klasses: [self])
-        return_value = yield
-        return_value.load if return_value.is_a? ActiveRecord::Relation
-        return_value
-      ensure
-        self.connected_to_stack.pop
+        begin
+          return_value = yield
+          return_value.load if return_value.is_a? ActiveRecord::Relation
+          return_value
+        ensure
+          self.connected_to_stack.pop
+        end
       end
 
       def append_to_connected_to_stack(entry)

data/lib/active_record/gem_version.rb

@@ -10,7 +10,7 @@ module ActiveRecord
     MAJOR = 8
     MINOR = 1
     TINY  = 0
-    PRE   = "rc1"
+    PRE   = nil
 
     STRING = [MAJOR, MINOR, TINY, PRE].compact.join(".")
   end

data/lib/active_record/reflection.rb

@@ -425,14 +425,10 @@ module ActiveRecord
 
       def _klass(class_name) # :nodoc:
         if active_record.name.demodulize == class_name
-          begin
-            compute_class("::#{class_name}")
-          rescue NameError
-            compute_class(class_name)
-          end
-        else
-          compute_class(class_name)
+          return compute_class("::#{class_name}") rescue NameError
         end
+
+        compute_class(class_name)
       end
 
       def compute_class(name)

data/lib/active_record/relation/query_methods.rb

@@ -1923,7 +1923,8 @@ module ActiveRecord
 
       def build_with_expression_from_value(value, nested = false)
         case value
-        when Arel::Nodes::SqlLiteral then Arel::Nodes::Grouping.new(value)
+        when Arel::Nodes::SqlLiteral, Arel::Nodes::BoundSqlLiteral
+          Arel::Nodes::Grouping.new(value)
         when ActiveRecord::Relation
           if nested
             value.arel.ast

data/lib/active_record/structured_event_subscriber.rb

@@ -12,7 +12,7 @@ module ActiveRecord
 
       emit_debug_event("active_record.strict_loading_violation",
         owner: owner.name,
-        class: reflection.klass.name,
+        class: reflection.polymorphic? ? nil : reflection.klass.name,
         name: reflection.name,
       )
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activerecord
 version: !ruby/object:Gem::Version
-  version: 8.1.0.rc1
+  version: 8.1.0
 platform: ruby
 authors:
 - David Heinemeier Hansson
@@ -15,28 +15,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 8.1.0.rc1
+        version: 8.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 8.1.0.rc1
+        version: 8.1.0
 - !ruby/object:Gem::Dependency
   name: activemodel
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 8.1.0.rc1
+        version: 8.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 8.1.0.rc1
+        version: 8.1.0
 - !ruby/object:Gem::Dependency
   name: timeout
   requirement: !ruby/object:Gem::Requirement
@@ -478,10 +478,10 @@ licenses:
 - MIT
 metadata:
   bug_tracker_uri: https://github.com/rails/rails/issues
-  changelog_uri: https://github.com/rails/rails/blob/v8.1.0.rc1/activerecord/CHANGELOG.md
-  documentation_uri: https://api.rubyonrails.org/v8.1.0.rc1/
+  changelog_uri: https://github.com/rails/rails/blob/v8.1.0/activerecord/CHANGELOG.md
+  documentation_uri: https://api.rubyonrails.org/v8.1.0/
   mailing_list_uri: https://discuss.rubyonrails.org/c/rubyonrails-talk
-  source_code_uri: https://github.com/rails/rails/tree/v8.1.0.rc1/activerecord
+  source_code_uri: https://github.com/rails/rails/tree/v8.1.0/activerecord
   rubygems_mfa_required: 'true'
 rdoc_options:
 - "--main"