activerecord 5.2.8 → 6.0.0.beta1

data/CHANGELOG.md

@@ -1,143 +1,80 @@
-## Rails 5.2.8 (May 09, 2022) ##
+## Rails 6.0.0.beta1 (January 18, 2019) ##
 
-*   No changes.
+*   Remove deprecated `#set_state` from the transaction object.
 
+    *Rafael Mendonça França*
 
-## Rails 5.2.7.1 (April 26, 2022) ##
-
-*   No changes.
-
-
-## Rails 5.2.7 (March 10, 2022) ##
-
-*   No changes.
-
-
-## Rails 5.2.6.3 (March 08, 2022) ##
-
-*   No changes.
-
-
-## Rails 5.2.6.2 (February 11, 2022) ##
-
-*   No changes.
-
-
-## Rails 5.2.6.1 (February 11, 2022) ##
-
-*   No changes.
-
-
-## Rails 5.2.6 (May 05, 2021) ##
-
-*   No changes.
-
-
-## Rails 5.2.5 (March 26, 2021) ##
-
-*   No changes.
-
-
-## Rails 5.2.4.6 (May 05, 2021) ##
-
-*   No changes.
-
-
-## Rails 5.2.4.5 (February 10, 2021) ##
-
-*   Fix possible DoS vector in PostgreSQL money type
-
-    Carefully crafted input can cause a DoS via the regular expressions used
-    for validating the money format in the PostgreSQL adapter.  This patch
-    fixes the regexp.
-
-    Thanks to @dee-see from Hackerone for this patch!
-
-    [CVE-2021-22880]
-
-    *Aaron Patterson*
-
-
-## Rails 5.2.4.4 (September 09, 2020) ##
-
-*   No changes.
-
-
-## Rails 5.2.4.3 (May 18, 2020) ##
-
-*   No changes.
+*   Remove deprecated `#supports_statement_cache?` from the database adapters.
 
-## Rails 5.2.4.2 (March 19, 2020) ##
+    *Rafael Mendonça França*
 
-*   No changes.
+*   Remove deprecated `#insert_fixtures` from the database adapters.
 
+    *Rafael Mendonça França*
 
-## Rails 5.2.4.1 (December 18, 2019) ##
+*   Remove deprecated `ActiveRecord::ConnectionAdapters::SQLite3Adapter#valid_alter_table_type?`.
 
-*   No changes.
+    *Rafael Mendonça França*
 
+*   Do not allow passing the column name to `sum` when a block is passed.
 
-## Rails 5.2.4 (November 27, 2019) ##
+    *Rafael Mendonça França*
 
-*   Fix circular `autosave: true` causes invalid records to be saved.
+*   Do not allow passing the column name to `count` when a block is passed.
 
-    Prior to the fix, when there was a circular series of `autosave: true`
-    associations, the callback for a `has_many` association was run while
-    another instance of the same callback on the same association hadn't
-    finished running. When control returned to the first instance of the
-    callback, the instance variable had changed, and subsequent associated
-    records weren't saved correctly. Specifically, the ID field for the
-    `belongs_to` corresponding to the `has_many` was `nil`.
+    *Rafael Mendonça França*
 
-    Fixes #28080.
+*   Remove delegation of missing methods in a relation to arel.
 
-    *Larry Reid*
+    *Rafael Mendonça França*
 
-*   PostgreSQL: Fix GROUP BY with ORDER BY virtual count attribute.
+*   Remove delegation of missing methods in a relation to private methods of the class.
 
-    Fixes #36022.
+    *Rafael Mendonça França*
 
-    *Ryuta Kamizono*
+*   Deprecate `config.activerecord.sqlite3.represent_boolean_as_integer`.
 
-*   Fix sqlite3 collation parsing when using decimal columns.
+    *Rafael Mendonça França*
 
-    *Martin R. Schuster*
+*   Change `SQLite3Adapter` to always represent boolean values as integers.
 
-*   Make ActiveRecord `ConnectionPool.connections` method thread-safe.
+    *Rafael Mendonça França*
 
-    Fixes #36465.
+*   Remove ability to specify a timestamp name for `#cache_key`.
 
-    *Jeff Doering*
+    *Rafael Mendonça França*
 
-*   Assign all attributes before calling `build` to ensure the child record is visible in
-    `before_add` and `after_add` callbacks for `has_many :through` associations.
+*   Remove deprecated `ActiveRecord::Migrator.migrations_path=`.
 
-    Fixes #33249.
+    *Rafael Mendonça França*
 
-    *Ryan H. Kerr*
+*   Remove deprecated `expand_hash_conditions_for_aggregates`.
 
+    *Rafael Mendonça França*
 
-## Rails 5.2.3 (March 27, 2019) ##
+*   Set polymorphic type column to NULL on `dependent: :nullify` strategy.
 
-*   Fix different `count` calculation when using `size` with manual `select` with DISTINCT.
+    On polymorphic associations both the foreign key and the foreign type columns will be set to NULL.
 
-    Fixes #35214.
+    *Laerti Papa*
 
-    *Juani Villarejo*
+*   Allow permitted instance of `ActionController::Parameters` as argument of `ActiveRecord::Relation#exists?`.
 
-*   Fix prepared statements caching to be enabled even when query caching is enabled.
+    *Gannon McGibbon*
 
-    *Ryuta Kamizono*
+*   Add support for endless ranges introduces in Ruby 2.6.
 
-*   Don't allow `where` with invalid value matches to nil values.
+    *Greg Navis*
 
-    Fixes #33624.
+*   Deprecate passing `migrations_paths` to `connection.assume_migrated_upto_version`.
 
     *Ryuta Kamizono*
 
-*   Restore an ability that class level `update` without giving ids.
+*   MySQL: `ROW_FORMAT=DYNAMIC` create table option by default.
 
-    Fixes #34743.
+    Since MySQL 5.7.9, the `innodb_default_row_format` option defines the default row
+    format for InnoDB tables. The default setting is `DYNAMIC`.
+    The row format is required for indexing on `varchar(255)` with `utf8mb4` columns.
 
     *Ryuta Kamizono*
 
@@ -145,6 +82,10 @@
 
     *Gannon McGibbon*
 
+*   Allow disabling scopes generated by `ActiveRecord.enum`.
+
+    *Alfred Dominic*
+
 *   Ensure that `delete_all` on collection proxy returns affected count.
 
     *Ryuta Kamizono*
@@ -153,17 +94,21 @@
 
     *Gannon McGibbon*
 
+*   Add the ability to prevent writes to a database for the duration of a block.
 
-## Rails 5.2.2.1 (March 11, 2019) ##
-
-*   No changes.
+    Allows the application to prevent writes to a database. This can be useful when
+    you're building out multiple databases and want to make sure you're not sending
+    writes when you want a read.
 
+    If `while_preventing_writes` is called and the query is considered a write
+    query the database will raise an exception regardless of whether the database
+    user is able to write.
 
-## Rails 5.2.2 (December 04, 2018) ##
+    This is not meant to be a catch-all for write queries but rather a way to enforce
+    read-only queries without opening a second connection. One purpose of this is to
+    catch accidental writes, not all writes.
 
-*   Do not ignore the scoping with query methods in the scope block.
-
-    *Ryuta Kamizono*
+    *Eileen M. Uchitelle*
 
 *   Allow aliased attributes to be used in `#update_columns` and `#update`.
 
@@ -171,8 +116,7 @@
 
 *   Allow spaces in postgres table names.
 
-    Fixes issue where "user post" is misinterpreted as "\"user\".\"post\"" when quoting table names with the postgres
-    adapter.
+    Fixes issue where "user post" is misinterpreted as "\"user\".\"post\"" when quoting table names with the postgres adapter.
 
     *Gannon McGibbon*
 
@@ -205,852 +149,419 @@
 
     *Dmitry Tsepelev*
 
-*   Values of enum are frozen, raising an error when attempting to modify them.
-
-    *Emmanuel Byrd*
-
-*   `update_columns` now correctly raises `ActiveModel::MissingAttributeError`
-    if the attribute does not exist.
-
-    *Sean Griffin*
-
-*   Do not use prepared statement in queries that have a large number of binds.
-
-    *Ryuta Kamizono*
-
-*   Fix query cache to load before first request.
-
-    *Eileen M. Uchitelle*
-
-*   Fix collection cache key with limit and custom select to avoid ambiguous timestamp column error.
-
-    Fixes #33056.
-
-    *Federico Martinez*
-
-*   Fix duplicated record creation when using nested attributes with `create_with`.
-
-    *Darwin Wu*
-
-*   Fix regression setting children record in parent `before_save` callback.
-
-    *Guo Xiang Tan*
-
-*   Prevent leaking of user's DB credentials on `rails db:create` failure.
-
-    *bogdanvlviv*
-
-*   Clear mutation tracker before continuing the around callbacks.
-
-    *Yuya Tanaka*
-
-*   Prevent deadlocks when waiting for connection from pool.
-
-    *Brent Wheeldon*
-
-*   Avoid extra scoping when using `Relation#update` that was causing this method to change the current scope.
-
-    *Ryuta Kamizono*
-
-*   Fix numericality validator not to be affected by custom getter.
-
-    *Ryuta Kamizono*
-
-*   Fix bulk change table ignores comment option on PostgreSQL.
-
-    *Yoshiyuki Kinjo*
-
-
-## Rails 5.2.1.1 (November 27, 2018) ##
-
-*   No changes.
-
-
-## Rails 5.2.1 (August 07, 2018) ##
-
-*   PostgreSQL: Support new relkind for partitioned tables.
-
-    Fixes #33008.
-
-    *Yannick Schutz*
-
-*   Rollback parent transaction when children fails to update.
-
-    *Guillaume Malette*
-
-*   Fix default value for MySQL time types with specified precision.
-
-    *Nikolay Kondratyev*
-
-*   Fix `touch` option to behave consistently with `Persistence#touch` method.
-
-    *Ryuta Kamizono*
-
-*   Fix `save` in `after_create_commit` won't invoke extra `after_create_commit`.
-
-    Fixes #32831.
-
-    *Ryuta Kamizono*
-
-*   Fix logic on disabling commit callbacks so they are not called unexpectedly when errors occur.
-
-    *Brian Durand*
-
-*   Fix parent record should not get saved with duplicate children records.
-
-    Fixes #32940.
-
-    *Santosh Wadghule*
-
-*   Fix that association's after_touch is not called with counter cache.
-
-    Fixes #31559.
-
-    *Ryuta Kamizono*
-
-*   `becomes` should clear the mutation tracker which is created in `after_initialize`.
-
-    Fixes #32867.
-
-    *Ryuta Kamizono*
-
-*   Allow a belonging to parent object to be created from a new record.
+*   Make the implicit order column configurable.
 
-    *Jolyon Pawlyn*
+    When calling ordered finder methods such as +first+ or +last+ without an
+    explicit order clause, ActiveRecord sorts records by primary key. This can
+    result in unpredictable and surprising behaviour when the primary key is
+    not an auto-incrementing integer, for example when it's a UUID. This change
+    makes it possible to override the column used for implicit ordering such
+    that +first+ and +last+ will return more predictable results.
 
-*   Fix that building record with assigning multiple has_one associations
-    wrongly persists through record.
-
-    Fixes #32511.
-
-    *Sam DeCesare*
-
-*   Fix relation merging when one of the relations is going to skip the
-    query cache.
-
-    *James Williams*
-
-
-## Rails 5.2.0 (April 09, 2018) ##
-
-*   MySQL: Support mysql2 0.5.x.
-
-    *Aaron Stone*
-
-*   Apply time column precision on assignment.
-
-    PR #20317 changed the behavior of datetime columns so that when they
-    have a specified precision then on assignment the value is rounded to
-    that precision. This behavior is now applied to time columns as well.
-
-    Fixes #30301.
-
-    *Andrew White*
-
-*   Normalize time column values for SQLite database.
-
-    For legacy reasons, time columns in SQLite are stored as full datetimes
-    because until #24542 the quoting for time columns didn't remove the date
-    component. To ensure that values are consistent we now normalize the
-    date component to 2001-01-01 on reading and writing.
-
-    *Andrew White*
-
-*   Ensure that the date component is removed when quoting times.
-
-    PR #24542 altered the quoting for time columns so that the date component
-    was removed however it only removed it when it was 2001-01-01. Now the
-    date component is removed irrespective of what the date is.
-
-    *Andrew White*
-
-*   Fix `dependent: :destroy` issue for has_one/belongs_to relationship where
-    the parent class was getting deleted when the child was not.
-
-    Fixes #32022.
-
-    *Fernando Gorodscy*
-
-*   Whitelist `NULLS FIRST` and `NULLS LAST` in order clauses too.
-
-    *Xavier Noria*
-
-*   Fix that after commit callbacks on update does not triggered when optimistic locking is enabled.
-
-    *Ryuta Kamizono*
+    Example:
 
-*   Fix `#columns_for_distinct` of MySQL and PostgreSQL to make
-    `ActiveRecord::FinderMethods#limited_ids_for` use correct primary key values
-    even if `ORDER BY` columns include other table's primary key.
+        class Project < ActiveRecord::Base
+          self.implicit_order_column = "created_at"
+        end
 
-    Fixes #28364.
+    *Tekin Suleyman*
 
-    *Takumi Kagiyama*
+*   Bump minimum PostgreSQL version to 9.3.
 
-*   Make `reflection.klass` raise if `polymorphic?` not to be misused.
+    *Yasuo Honda*
 
-    Fixes #31876.
+*   Values of enum are frozen, raising an error when attempting to modify them.
 
-    *Ryuta Kamizono*
+    *Emmanuel Byrd*
 
-*   PostgreSQL: Allow pg-1.0 gem to be used with Active Record.
+*   Move `ActiveRecord::StatementInvalid` SQL to error property and include binds as separate error property.
 
-    *Lars Kanis*
+    `ActiveRecord::ConnectionAdapters::AbstractAdapter#translate_exception_class` now requires `binds` to be passed as the last argument.
 
-*   Deprecate `expand_hash_conditions_for_aggregates` without replacement.
-    Using a `Relation` for performing queries is the prefered API.
+    `ActiveRecord::ConnectionAdapters::AbstractAdapter#translate_exception` now requires `message`, `sql`, and `binds` to be passed as keyword arguments.
 
-    *Ryuta Kamizono*
+    Subclasses of `ActiveRecord::StatementInvalid` must now provide `sql:` and `binds:` arguments to `super`.
 
-*   Fix not expanded problem when passing an Array object as argument to the where method using `composed_of` column.
+    Example:
 
     ```
-    david_balance = customers(:david).balance
-    Customer.where(balance: [david_balance]).to_sql
-
-    # Before: WHERE `customers`.`balance` = NULL
-    # After : WHERE `customers`.`balance` = 50
+    class MySubclassedError < ActiveRecord::StatementInvalid
+      def initialize(message, sql:, binds:)
+        super(message, sql: sql, binds: binds)
+      end
+    end
     ```
 
-    Fixes #31723.
-
-    *Yutaro Kanagawa*
-
-*   Fix `count(:all)` with eager loading and having an order other than the driving table.
-
-    Fixes #31783.
-
-    *Ryuta Kamizono*
-
-*   Clear the transaction state when an Active Record object is duped.
-
-    Fixes #31670.
-
-    *Yuriy Ustushenko*
-
-*   Support for PostgreSQL foreign tables.
-
-    *fatkodima*
-
-*   Fix relation merger issue with `left_outer_joins`.
-
-    *Mehmet Emin İNAÇ*
-
-*   Don't allow destroyed object mutation after `save` or `save!` is called.
-
-    *Ryuta Kamizono*
-
-*   Take into account association conditions when deleting through records.
-
-    Fixes #18424.
-
-    *Piotr Jakubowski*
+    *Gannon McGibbon*
 
-*   Fix nested `has_many :through` associations on unpersisted parent instances.
+*   Add an `:if_not_exists` option to `create_table`.
 
-    For example, if you have
+    Example:
 
-        class Post < ActiveRecord::Base
-          belongs_to :author
-          has_many :books, through: :author
-          has_many :subscriptions, through: :books
+        create_table :posts, if_not_exists: true do |t|
+          t.string :title
         end
 
-        class Author < ActiveRecord::Base
-          has_one :post
-          has_many :books
-          has_many :subscriptions, through: :books
-        end
+    That would execute:
 
-        class Book < ActiveRecord::Base
-          belongs_to :author
-          has_many :subscriptions
-        end
+        CREATE TABLE IF NOT EXISTS posts (
+          ...
+        )
 
-        class Subscription < ActiveRecord::Base
-          belongs_to :book
-        end
+    If the table already exists, `if_not_exists: false` (the default) raises an
+    exception whereas `if_not_exists: true` does nothing.
 
-    Before:
+    *fatkodima*, *Stefan Kanev*
 
-    If `post` is not persisted, then `post.subscriptions` will be empty.
+*   Defining an Enum as a Hash with blank key, or as an Array with a blank value, now raises an `ArgumentError`.
 
-    After:
+    *Christophe Maximin*
 
-    If `post` is not persisted, then `post.subscriptions` can be set and used
-    just like it would if `post` were persisted.
+*   Adds support for multiple databases to `rails db:schema:cache:dump` and `rails db:schema:cache:clear`.
 
-    Fixes #16313.
+    *Gannon McGibbon*
 
-    *Zoltan Kiss*
+*   `update_columns` now correctly raises `ActiveModel::MissingAttributeError`
+    if the attribute does not exist.
 
-*   Fixed inconsistency with `first(n)` when used with `limit()`.
-    The `first(n)` finder now respects the `limit()`, making it consistent
-    with `relation.to_a.first(n)`, and also with the behavior of `last(n)`.
+    *Sean Griffin*
 
-    Fixes #23979.
+*   Add support for hash and url configs in database hash of `ActiveRecord::Base.connected_to`.
 
-    *Brian Christian*
+    ````
+    User.connected_to(database: { writing: "postgres://foo" }) do
+      User.create!(name: "Gannon")
+    end
 
-*   Use `count(:all)` in `HasManyAssociation#count_records` to prevent invalid
-    SQL queries for association counting.
+    config = { "adapter" => "sqlite3", "database" => "db/readonly.sqlite3" }
+    User.connected_to(database: { reading: config }) do
+      User.count
+    end
+    ````
 
-    *Klas Eskilson*
+    *Gannon McGibbon*
 
-*   Fix to invoke callbacks when using `update_attribute`.
+*   Support default expression for MySQL.
 
-    *Mike Busch*
+    MySQL 8.0.13 and higher supports default value to be a function or expression.
 
-*   Fix `count(:all)` to correctly work `distinct` with custom SELECT list.
+    https://dev.mysql.com/doc/refman/8.0/en/create-table.html
 
     *Ryuta Kamizono*
 
-*   Using subselect for `delete_all` with `limit` or `offset`.
+*   Support expression indexes for MySQL.
 
-    *Ryuta Kamizono*
+    MySQL 8.0.13 and higher supports functional key parts that index
+    expression values rather than column or column prefix values.
 
-*   Undefine attribute methods on descendants when resetting column
-    information.
+    https://dev.mysql.com/doc/refman/8.0/en/create-index.html
 
-    *Chris Salzberg*
+    *Ryuta Kamizono*
 
-*   Log database query callers.
+*   Fix collection cache key with limit and custom select to avoid ambiguous timestamp column error.
 
-    Add `verbose_query_logs` configuration option to display the caller
-    of database queries in the log to facilitate N+1 query resolution
-    and other debugging.
+    Fixes #33056.
 
-    Enabled in development only for new and upgraded applications. Not
-    recommended for use in the production environment since it relies
-    on Ruby's `Kernel#caller_locations` which is fairly slow.
+    *Federico Martinez*
 
-    *Olivier Lacan*
+*   Add basic API for connection switching to support multiple databases.
 
-*   Fix conflicts `counter_cache` with `touch: true` by optimistic locking.
+    1) Adds a `connects_to` method for models to connect to multiple databases. Example:
 
     ```
-    # create_table :posts do |t|
-    #   t.integer :comments_count, default: 0
-    #   t.integer :lock_version
-    #   t.timestamps
-    # end
-    class Post < ApplicationRecord
+    class AnimalsModel < ApplicationRecord
+      self.abstract_class = true
+
+      connects_to database: { writing: :animals_primary, reading: :animals_replica }
     end
 
-    # create_table :comments do |t|
-    #   t.belongs_to :post
-    # end
-    class Comment < ApplicationRecord
-      belongs_to :post, touch: true, counter_cache: true
+    class Dog < AnimalsModel
+      # connected to both the animals_primary db for writing and the animals_replica for reading
     end
     ```
 
-    Before:
+    2) Adds a `connected_to` block method for switching connection roles or connecting to
+    a database that the model didn't connect to. Connecting to the database in this block is
+    useful when you have another defined connection, for example `slow_replica` that you don't
+    want to connect to by default but need in the console, or a specific code block.
+
     ```
-    post = Post.create!
-    # => begin transaction
-         INSERT INTO "posts" ("created_at", "updated_at", "lock_version")
-         VALUES ("2017-12-11 21:27:11.387397", "2017-12-11 21:27:11.387397", 0)
-         commit transaction
-
-    comment = Comment.create!(post: post)
-    # => begin transaction
-         INSERT INTO "comments" ("post_id") VALUES (1)
-
-         UPDATE "posts" SET "comments_count" = COALESCE("comments_count", 0) + 1,
-         "lock_version" = COALESCE("lock_version", 0) + 1 WHERE "posts"."id" = 1
-
-         UPDATE "posts" SET "updated_at" = '2017-12-11 21:27:11.398330',
-         "lock_version" = 1 WHERE "posts"."id" = 1 AND "posts"."lock_version" = 0
-         rollback transaction
-    # => ActiveRecord::StaleObjectError: Attempted to touch a stale object: Post.
-
-    Comment.take.destroy!
-    # => begin transaction
-         DELETE FROM "comments" WHERE "comments"."id" = 1
-
-         UPDATE "posts" SET "comments_count" = COALESCE("comments_count", 0) - 1,
-         "lock_version" = COALESCE("lock_version", 0) + 1 WHERE "posts"."id" = 1
-
-         UPDATE "posts" SET "updated_at" = '2017-12-11 21:42:47.785901',
-         "lock_version" = 1 WHERE "posts"."id" = 1 AND "posts"."lock_version" = 0
-         rollback transaction
-    # => ActiveRecord::StaleObjectError: Attempted to touch a stale object: Post.
+    ActiveRecord::Base.connected_to(role: :reading) do
+      Dog.first # finds dog from replica connected to AnimalsBase
+      Book.first # doesn't have a reading connection, will raise an error
+    end
     ```
 
-    After:
     ```
-    post = Post.create!
-    # => begin transaction
-         INSERT INTO "posts" ("created_at", "updated_at", "lock_version")
-         VALUES ("2017-12-11 21:27:11.387397", "2017-12-11 21:27:11.387397", 0)
-         commit transaction
-
-    comment = Comment.create!(post: post)
-    # => begin transaction
-         INSERT INTO "comments" ("post_id") VALUES (1)
-
-         UPDATE "posts" SET "comments_count" = COALESCE("comments_count", 0) + 1,
-         "lock_version" = COALESCE("lock_version", 0) + 1,
-         "updated_at" = '2017-12-11 21:37:09.802642' WHERE "posts"."id" = 1
-         commit transaction
-
-    comment.destroy!
-    # => begin transaction
-         DELETE FROM "comments" WHERE "comments"."id" = 1
-
-         UPDATE "posts" SET "comments_count" = COALESCE("comments_count", 0) - 1,
-         "lock_version" = COALESCE("lock_version", 0) + 1,
-         "updated_at" = '2017-12-11 21:39:02.685520' WHERE "posts"."id" = 1
-         commit transaction
+    ActiveRecord::Base.connected_to(database: :slow_replica) do
+      SlowReplicaModel.first # if the db config has a slow_replica configuration this will be used to do the lookup, otherwise this will throw an exception
+    end
     ```
 
-    Fixes #31199.
-
-    *bogdanvlviv*
-
-*   Add support for PostgreSQL operator classes to `add_index`.
-
-    Example:
-
-        add_index :users, :name, using: :gist, opclass: { name: :gist_trgm_ops }
-
-    *Greg Navis*
-
-*   Don't allow scopes to be defined which conflict with instance methods on `Relation`.
-
-    Fixes #31120.
-
-    *kinnrot*
-
-*   Add new error class `QueryCanceled` which will be raised
-    when canceling statement due to user request.
+    *Eileen M. Uchitelle*
 
-    *Ryuta Kamizono*
+*   Enum raises on invalid definition values
 
-*   Add `#up_only` to database migrations for code that is only relevant when
-    migrating up, e.g. populating a new column.
+    When defining a Hash enum it can be easy to use [] instead of {}. This
+    commit checks that only valid definition values are provided, those can
+    be a Hash, an array of Symbols or an array of Strings. Otherwise it
+    raises an ArgumentError.
 
-    *Rich Daley*
+    Fixes #33961
 
-*   Require raw SQL fragments to be explicitly marked when used in
-    relation query methods.
+    *Alberto Almagro*
 
-    Before:
-    ```
-    Article.order("LENGTH(title)")
-    ```
+*   Reloading associations now clears the Query Cache like `Persistence#reload` does.
 
-    After:
-    ```
-    Article.order(Arel.sql("LENGTH(title)"))
     ```
+    class Post < ActiveRecord::Base
+      has_one :category
+      belongs_to :author
+      has_many :comments
+    end
 
-    This prevents SQL injection if applications use the [strongly
-    discouraged] form `Article.order(params[:my_order])`, under the
-    mistaken belief that only column names will be accepted.
-
-    Raw SQL strings will now cause a deprecation warning, which will
-    become an UnknownAttributeReference error in Rails 6.0. Applications
-    can opt in to the future behavior by setting `allow_unsafe_raw_sql`
-    to `:disabled`.
-
-    Common and judged-safe string values (such as simple column
-    references) are unaffected:
+    # Each of the following will now clear the query cache.
+    post.reload_category
+    post.reload_author
+    post.comments.reload
     ```
-    Article.order("title DESC")
-    ```
-
-    *Ben Toews*
-
-*   `update_all` will now pass its values to `Type#cast` before passing them to
-    `Type#serialize`. This means that `update_all(foo: 'true')` will properly
-    persist a boolean.
-
-    *Sean Griffin*
-
-*   Add new error class `StatementTimeout` which will be raised
-    when statement timeout exceeded.
-
-    *Ryuta Kamizono*
-
-*   Fix `bin/rails db:migrate` with specified `VERSION`.
-    `bin/rails db:migrate` with empty VERSION behaves as without `VERSION`.
-    Check a format of `VERSION`: Allow a migration version number
-    or name of a migration file. Raise error if format of `VERSION` is invalid.
-    Raise error if target migration doesn't exist.
-
-    *bogdanvlviv*
-
-*   Fixed a bug where column orders for an index weren't written to
-    `db/schema.rb` when using the sqlite adapter.
-
-    Fixes #30902.
-
-    *Paul Kuruvilla*
-
-*   Remove deprecated method `#sanitize_conditions`.
-
-    *Rafael Mendonça França*
-
-*   Remove deprecated method `#scope_chain`.
-
-    *Rafael Mendonça França*
-
-*   Remove deprecated configuration `.error_on_ignored_order_or_limit`.
 
-    *Rafael Mendonça França*
-
-*   Remove deprecated arguments from `#verify!`.
-
-    *Rafael Mendonça França*
+    *Christophe Maximin*
 
-*   Remove deprecated argument `name` from `#indexes`.
+*   Added `index` option for `change_table` migration helpers.
+    With this change you can create indexes while adding new
+    columns into the existing tables.
 
-    *Rafael Mendonça França*
+    Example:
 
-*   Remove deprecated method `ActiveRecord::Migrator.schema_migrations_table_name`.
+        change_table(:languages) do |t|
+          t.string :country_code, index: true
+        end
 
-    *Rafael Mendonça França*
+    *Mehmet Emin İNAÇ*
 
-*   Remove deprecated method `supports_primary_key?`.
+*   Fix `transaction` reverting for migrations.
 
-    *Rafael Mendonça França*
+    Before: Commands inside a `transaction` in a reverted migration ran uninverted.
+    Now: This change fixes that by reverting commands inside `transaction` block.
 
-*   Remove deprecated method `supports_migrations?`.
+    *fatkodima*, *David Verhasselt*
 
-    *Rafael Mendonça França*
+*   Raise an error instead of scanning the filesystem root when `fixture_path` is blank.
 
-*   Remove deprecated methods `initialize_schema_migrations_table` and `initialize_internal_metadata_table`.
+    *Gannon McGibbon*, *Max Albrecht*
 
-    *Rafael Mendonça França*
+*   Allow `ActiveRecord::Base.configurations=` to be set with a symbolized hash.
 
-*   Raises when calling `lock!` in a dirty record.
-
-    *Rafael Mendonça França*
-
-*   Remove deprecated support to passing a class to `:class_name` on associations.
+    *Gannon McGibbon*
 
-    *Rafael Mendonça França*
+*   Don't update counter cache unless the record is actually saved.
 
-*   Remove deprecated argument `default` from `index_name_exists?`.
+    Fixes #31493, #33113, #33117.
 
-    *Rafael Mendonça França*
+    *Ryuta Kamizono*
 
-*   Remove deprecated support to `quoted_id` when typecasting an Active Record object.
+*   Deprecate `ActiveRecord::Result#to_hash` in favor of `ActiveRecord::Result#to_a`.
 
-    *Rafael Mendonça França*
+    *Gannon McGibbon*, *Kevin Cheng*
 
-*   Fix `bin/rails db:setup` and `bin/rails db:test:prepare` create wrong
-    ar_internal_metadata's data for a test database.
+*   SQLite3 adapter supports expression indexes.
 
-    Before:
-    ```
-    $ RAILS_ENV=test rails dbconsole
-    > SELECT * FROM ar_internal_metadata;
-    key|value|created_at|updated_at
-    environment|development|2017-09-11 23:14:10.815679|2017-09-11 23:14:10.815679
     ```
+    create_table :users do |t|
+      t.string :email
+    end
 
-    After:
-    ```
-    $ RAILS_ENV=test rails dbconsole
-    > SELECT * FROM ar_internal_metadata;
-    key|value|created_at|updated_at
-    environment|test|2017-09-11 23:14:10.815679|2017-09-11 23:14:10.815679
+    add_index :users, 'lower(email)', name: 'index_users_on_email', unique: true
     ```
 
-    Fixes #26731.
+    *Gray Kemmey*
 
-    *bogdanvlviv*
+*   Allow subclasses to redefine autosave callbacks for associated records.
 
-*   Fix longer sequence name detection for serial columns.
+    Fixes #33305.
 
-    Fixes #28332.
+    *Andrey Subbota*
 
-    *Ryuta Kamizono*
-
-*   MySQL: Don't lose `auto_increment: true` in the `db/schema.rb`.
-
-    Fixes #30894.
-
-    *Ryuta Kamizono*
-
-*   Fix `COUNT(DISTINCT ...)` for `GROUP BY` with `ORDER BY` and `LIMIT`.
-
-    Fixes #30886.
-
-    *Ryuta Kamizono*
-
-*   PostgreSQL `tsrange` now preserves subsecond precision.
-
-    PostgreSQL 9.1+ introduced range types, and Rails added support for using
-    this datatype in Active Record. However, the serialization of
-    `PostgreSQL::OID::Range` was incomplete, because it did not properly
-    cast the bounds that make up the range. This led to subseconds being
-    dropped in SQL commands:
-
-    Before:
+*   Bump minimum MySQL version to 5.5.8.
 
-        connection.type_cast(tsrange.serialize(range_value))
-        # => "[2010-01-01 13:30:00 UTC,2011-02-02 19:30:00 UTC)"
+    *Yasuo Honda*
 
-    Now:
+*   Use MySQL utf8mb4 character set by default.
 
-        connection.type_cast(tsrange.serialize(range_value))
-        # => "[2010-01-01 13:30:00.670277,2011-02-02 19:30:00.745125)"
+    `utf8mb4` character set with 4-Byte encoding supports supplementary characters including emoji.
+    The previous default 3-Byte encoding character set `utf8` is not enough to support them.
 
-    *Thomas Cannon*
+    *Yasuo Honda*
 
-*   Passing a `Set` to `Relation#where` now behaves the same as passing an
-    array.
-
-    *Sean Griffin*
-
-*   Use given algorithm while removing index from database.
-
-    Fixes #24190.
-
-    *Mehmet Emin İNAÇ*
-
-*   Update payload names for `sql.active_record` instrumentation to be
-    more descriptive.
+*   Fix duplicated record creation when using nested attributes with `create_with`.
 
-    Fixes #30586.
+    *Darwin Wu*
 
-    *Jeremy Green*
+*   Configuration item `config.filter_parameters` could also filter out
+    sensitive values of database columns when call `#inspect`.
+    We also added `ActiveRecord::Base::filter_attributes`/`=` in order to
+    specify sensitive attributes to specific model.
 
-*   Add new error class `LockWaitTimeout` which will be raised
-    when lock wait timeout exceeded.
+    ```
+    Rails.application.config.filter_parameters += [:credit_card_number, /phone/]
+    Account.last.inspect # => #<Account id: 123, name: "DHH", credit_card_number: [FILTERED], telephone_number: [FILTERED] ...>
+    SecureAccount.filter_attributes += [:name]
+    SecureAccount.last.inspect # => #<SecureAccount id: 42, name: [FILTERED], credit_card_number: [FILTERED] ...>
+    ```
 
-    *Gabriel Courtemanche*
+    *Zhang Kang*, *Yoshiyuki Kinjo*
 
-*   Remove deprecated `#migration_keys`.
+*   Deprecate `column_name_length`, `table_name_length`, `columns_per_table`,
+    `indexes_per_table`, `columns_per_multicolumn_index`, `sql_query_length`,
+    and `joins_per_query` methods in `DatabaseLimits`.
 
     *Ryuta Kamizono*
 
-*   Automatically guess the inverse associations for STI.
+*   `ActiveRecord::Base.configurations` now returns an object.
 
-    *Yuichiro Kaneko*
+    `ActiveRecord::Base.configurations` used to return a hash, but this
+    is an inflexible data model. In order to improve multiple-database
+    handling in Rails, we've changed this to return an object. Some methods
+    are provided to make the object behave hash-like in order to ease the
+    transition process. Since most applications don't manipulate the hash
+    we've decided to add backwards-compatible functionality that will throw
+    a deprecation warning if used, however calling `ActiveRecord::Base.configurations`
+    will use the new version internally and externally.
 
-*   Ensure `sum` honors `distinct` on `has_many :through` associations.
+    For example, the following `database.yml`:
 
-    Fixes #16791.
-
-    *Aaron Wortham*
-
-*   Add `binary` fixture helper method.
-
-    *Atsushi Yoshida*
-
-*   When using `Relation#or`, extract the common conditions and put them before the OR condition.
-
-    *Maxime Handfield Lapointe*
-
-*   `Relation#or` now accepts two relations who have different values for
-    `references` only, as `references` can be implicitly called by `where`.
-
-    Fixes #29411.
-
-    *Sean Griffin*
-
-*   `ApplicationRecord` is no longer generated when generating models. If you
-    need to generate it, it can be created with `rails g application_record`.
-
-    *Lisa Ugray*
-
-*   Fix `COUNT(DISTINCT ...)` with `ORDER BY` and `LIMIT` to keep the existing select list.
-
-    *Ryuta Kamizono*
-
-*   When a `has_one` association is destroyed by `dependent: destroy`,
-    `destroyed_by_association` will now be set to the reflection, matching the
-    behaviour of `has_many` associations.
+    ```
+    development:
+      adapter: sqlite3
+      database: db/development.sqlite3
+    ```
 
-    *Lisa Ugray*
+    Used to become a hash:
 
-*   Fix `unscoped(where: [columns])` removing the wrong bind values.
+    ```
+    { "development" => { "adapter" => "sqlite3", "database" => "db/development.sqlite3" } }
+    ```
 
-    When the `where` is called on a relation after a `or`, unscoping the column of that later `where` removed
-    bind values used by the `or` instead. (possibly other cases too)
+    Is now converted into the following object:
 
     ```
-    Post.where(id: 1).or(Post.where(id: 2)).where(foo: 3).unscope(where: :foo).to_sql
-    # Currently:
-    #     SELECT "posts".* FROM "posts" WHERE ("posts"."id" = 2 OR "posts"."id" = 3)
-    # With fix:
-    #     SELECT "posts".* FROM "posts" WHERE ("posts"."id" = 1 OR "posts"."id" = 2)
+    #<ActiveRecord::DatabaseConfigurations:0x00007fd1acbdf800 @configurations=[
+      #<ActiveRecord::DatabaseConfigurations::HashConfig:0x00007fd1acbded10 @env_name="development",
+        @spec_name="primary", @config={"adapter"=>"sqlite3", "database"=>"db/development.sqlite3"}>
+      ]
     ```
 
-    *Maxime Handfield Lapointe*
+    Iterating over the database configurations has also changed. Instead of
+    calling hash methods on the `configurations` hash directly, a new method `configs_for` has
+    been provided that allows you to select the correct configuration. `env_name`, and
+    `spec_name` arguments are optional. For example these return an array of
+    database config objects for the requested environment and a single database config object
+    will be returned for the requested environment and specification name respectively.
 
-*   Values constructed using multi-parameter assignment will now use the
-    post-type-cast value for rendering in single-field form inputs.
+    ```
+    ActiveRecord::Base.configurations.configs_for(env_name: "development")
+    ActiveRecord::Base.configurations.configs_for(env_name: "development", spec_name: "primary")
+    ```
 
-    *Sean Griffin*
+    *Eileen M. Uchitelle*, *Aaron Patterson*
 
-*   `Relation#joins` is no longer affected by the target model's
-    `current_scope`, with the exception of `unscoped`.
+*   Add database configuration to disable advisory locks.
 
-    Fixes #29338.
+    ```
+    production:
+      adapter: postgresql
+      advisory_locks: false
+    ```
 
-    *Sean Griffin*
+    *Guo Xiang*
 
-*   Change sqlite3 boolean serialization to use 1 and 0.
+*   SQLite3 adapter `alter_table` method restores foreign keys.
 
-    SQLite natively recognizes 1 and 0 as true and false, but does not natively
-    recognize 't' and 'f' as was previously serialized.
+    *Yasuo Honda*
 
-    This change in serialization requires a migration of stored boolean data
-    for SQLite databases, so it's implemented behind a configuration flag
-    whose default false value is deprecated.
+*   Allow `:to_table` option to `invert_remove_foreign_key`.
 
-    *Lisa Ugray*
+    Example:
 
-*   Skip query caching when working with batches of records (`find_each`, `find_in_batches`,
-    `in_batches`).
+       remove_foreign_key :accounts, to_table: :owners
 
-    Previously, records would be fetched in batches, but all records would be retained in memory
-    until the end of the request or job.
+    *Nikolay Epifanov*, *Rich Chen*
 
-    *Eugene Kenny*
+*   Add environment & load_config dependency to `bin/rake db:seed` to enable
+    seed load in environments without Rails and custom DB configuration
 
-*   Prevent errors raised by `sql.active_record` notification subscribers from being converted into
-    `ActiveRecord::StatementInvalid` exceptions.
+    *Tobias Bielohlawek*
 
-    *Dennis Taylor*
+*   Fix default value for mysql time types with specified precision.
 
-*   Fix eager loading/preloading association with scope including joins.
+    *Nikolay Kondratyev*
 
-    Fixes #28324.
+*   Fix `touch` option to behave consistently with `Persistence#touch` method.
 
     *Ryuta Kamizono*
 
-*   Fix transactions to apply state to child transactions.
+*   Migrations raise when duplicate column definition.
 
-    Previously, if you had a nested transaction and the outer transaction was rolledback, the record from the
-    inner transaction would still be marked as persisted.
+    Fixes #33024.
 
-    This change fixes that by applying the state of the parent transaction to the child transaction when the
-    parent transaction is rolledback. This will correctly mark records from the inner transaction as not persisted.
-
-    *Eileen M. Uchitelle*, *Aaron Patterson*
-
-*   Deprecate `set_state` method in `TransactionState`.
-
-    Deprecated the `set_state` method in favor of setting the state via specific methods. If you need to mark the
-    state of the transaction you can now use `rollback!`, `commit!` or `nullify!` instead of
-    `set_state(:rolledback)`, `set_state(:committed)`, or `set_state(nil)`.
-
-    *Eileen M. Uchitelle*, *Aaron Patterson*
-
-*   Deprecate delegating to `arel` in `Relation`.
-
-    *Ryuta Kamizono*
+    *Federico Martinez*
 
-*   Query cache was unavailable when entering the `ActiveRecord::Base.cache` block
-    without being connected.
+*   Bump minimum SQLite version to 3.8
 
-    *Tsukasa Oishi*
+    *Yasuo Honda*
 
-*   Previously, when building records using a `has_many :through` association,
-    if the child records were deleted before the parent was saved, they would
-    still be persisted. Now, if child records are deleted before the parent is saved
-    on a `has_many :through` association, the child records will not be persisted.
+*   Fix parent record should not get saved with duplicate children records.
 
-    *Tobias Kraze*
+    Fixes #32940.
 
-*   Merging two relations representing nested joins no longer transforms the joins of
-    the merged relation into LEFT OUTER JOIN.
+    *Santosh Wadghule*
 
-    Example:
+*   Fix logic on disabling commit callbacks so they are not called unexpectedly when errors occur.
 
-    ```
-    Author.joins(:posts).merge(Post.joins(:comments))
-    # Before the change:
-    #=> SELECT ... FROM authors INNER JOIN posts ON ... LEFT OUTER JOIN comments ON...
+    *Brian Durand*
 
-    # After the change:
-    #=> SELECT ... FROM authors INNER JOIN posts ON ... INNER JOIN comments ON...
-    ```
+*   Ensure `Associations::CollectionAssociation#size` and `Associations::CollectionAssociation#empty?`
+    use loaded association ids if present.
 
-    *Maxime Handfield Lapointe*
+    *Graham Turner*
 
-*   `ActiveRecord::Persistence#touch` does not work well when optimistic locking enabled and
-    `locking_column`, without default value, is null in the database.
+*   Add support to preload associations of polymorphic associations when not all the records have the requested associations.
 
-    *bogdanvlviv*
+    *Dana Sherson*
 
-*   Fix destroying existing object does not work well when optimistic locking enabled and
-    `locking_column` is null in the database.
+*   Add `touch_all` method to `ActiveRecord::Relation`.
 
-    *bogdanvlviv*
+    Example:
 
-*   Use bulk INSERT to insert fixtures for better performance.
+        Person.where(name: "David").touch_all(time: Time.new(2020, 5, 16, 0, 0, 0))
 
-    *Kir Shatrov*
+    *fatkodima*, *duggiefresh*
 
-*   Prevent creation of bind param if casted value is nil.
+*   Add `ActiveRecord::Base.base_class?` predicate.
 
-    *Ryuta Kamizono*
+    *Bogdan Gusiev*
 
-*   Deprecate passing arguments and block at the same time to `count` and `sum` in `ActiveRecord::Calculations`.
+*   Add custom prefix/suffix options to `ActiveRecord::Store.store_accessor`.
 
-    *Ryuta Kamizono*
+    *Tan Huynh*, *Yukio Mizuta*
 
-*   Loading model schema from database is now thread-safe.
+*   Rails 6 requires Ruby 2.5.0 or newer.
 
-    Fixes #28589.
+    *Jeremy Daer*, *Kasper Timm Hansen*
 
-    *Vikrant Chaudhary*, *David Abdemoulaie*
+*   Deprecate `update_attributes`/`!` in favor of `update`/`!`.
 
-*   Add `ActiveRecord::Base#cache_version` to support recyclable cache keys via the new versioned entries
-    in `ActiveSupport::Cache`. This also means that `ActiveRecord::Base#cache_key` will now return a stable key
-    that does not include a timestamp any more.
+    *Eddie Lebow*
 
-    NOTE: This feature is turned off by default, and `#cache_key` will still return cache keys with timestamps
-    until you set `ActiveRecord::Base.cache_versioning = true`. That's the setting for all new apps on Rails 5.2+
+*   Add `ActiveRecord::Base.create_or_find_by`/`!` to deal with the SELECT/INSERT race condition in
+    `ActiveRecord::Base.find_or_create_by`/`!` by leaning on unique constraints in the database.
 
     *DHH*
 
-*   Respect `SchemaDumper.ignore_tables` in rake tasks for databases structure dump.
-
-    *Rusty Geldmacher*, *Guillermo Iguaran*
-
-*   Add type caster to `RuntimeReflection#alias_name`.
-
-    Fixes #28959.
-
-    *Jon Moss*
-
-*   Deprecate `supports_statement_cache?`.
-
-    *Ryuta Kamizono*
-
-*   Raise error `UnknownMigrationVersionError` on the movement of migrations
-    when the current migration does not exist.
+*   Add `Relation#pick` as short-hand for single-value plucks.
 
-    *bogdanvlviv*
-
-*   Fix `bin/rails db:forward` first migration.
-
-    *bogdanvlviv*
-
-*   Support Descending Indexes for MySQL.
-
-    MySQL 8.0.1 and higher supports descending indexes: `DESC` in an index definition is no longer ignored.
-    See https://dev.mysql.com/doc/refman/8.0/en/descending-indexes.html.
-
-    *Ryuta Kamizono*
-
-*   Fix inconsistency with changed attributes when overriding Active Record attribute reader.
-
-    *bogdanvlviv*
-
-*   When calling the dynamic fixture accessor method with no arguments, it now returns all fixtures of this type.
-    Previously this method always returned an empty array.
-
-    *Kevin McPhillips*
+    *DHH*
 
 
-Please check [5-1-stable](https://github.com/rails/rails/blob/5-1-stable/activerecord/CHANGELOG.md) for previous changes.
+Please check [5-2-stable](https://github.com/rails/rails/blob/5-2-stable/activerecord/CHANGELOG.md) for previous changes.