activerecord 5.1.0 → 5.2.0.rc1

data/CHANGELOG.md

@@ -1,791 +1,671 @@
-## Rails 5.1.0 (April 27, 2017) ##
+## Rails 5.2.0.rc1 (January 30, 2018) ##
 
-*   Quote database name in db:create grant statement (when database_user does not have access to create the database).
-
-    *Rune Philosof*
-
-*   When multiple threads are sharing a database connection inside a test using
-    transactional fixtures, a nested transaction will temporarily lock the
-    connection to the current thread, forcing others to wait.
-
-    Fixes #28197.
-
-    *Matthew Draper*
-
-*   Load only needed records on `ActiveRecord::Relation#inspect`.
-
-    Instead of loading all records and returning only a subset of those, just
-    load the records as needed.
-
-    Fixes #25537.
-
-    *Hendy Tanata*
-
-*   Remove comments from structure.sql when using postgresql adapter to avoid
-    version-specific parts of the file.
-
-    Fixes #28153.
-
-    *Ari Pollak*
-
-*   Add `:default` option to `belongs_to`.
-
-    Use it to specify that an association should be initialized with a particular
-    record before validation. For example:
-
-        # Before
-        belongs_to :account
-        before_validation -> { self.account ||= Current.account }
-
-        # After
-        belongs_to :account, default: -> { Current.account }
-
-    *George Claghorn*
-
-*   Deprecate `Migrator.schema_migrations_table_name`.
+*   Deprecate `expand_hash_conditions_for_aggregates` without replacement.
+    Using a `Relation` for performing queries is the prefered API.
 
     *Ryuta Kamizono*
 
-*   Fix select with block doesn't return newly built records in has_many association.
+*   Fix not expanded problem when passing an Array object as argument to the where method using `composed_of` column.
 
-    Fixes #28348.
+    ```
+    david_balance = customers(:david).balance
+    Customer.where(balance: [david_balance]).to_sql
 
-    *Ryuta Kamizono*
-
-*   Check whether `Rails.application` defined before calling it
-
-    In #27674 we changed the migration generator to generate migrations at the
-    path defined in `Rails.application.config.paths` however the code checked
-    for the presence of the `Rails` constant but not the `Rails.application`
-    method which caused problems when using Active Record and generators outside
-    of the context of a Rails application.
+    # Before: WHERE `customers`.`balance` = NULL
+    # After : WHERE `customers`.`balance` = 50
+    ```
 
-    Fixes #28325.
+    Fixes #31723.
 
-    *Andrew White*
+    *Yutaro Kanagawa*
 
-*   Fix `deserialize` with JSON array.
+*   Fix `count(:all)` with eager loading and having an order other than the driving table.
 
-    Fixes #28285.
+    Fixes #31783.
 
     *Ryuta Kamizono*
 
-*   Fix `rake db:schema:load` with subdirectories.
+*   Clear the transaction state when an Active Record object is duped.
 
-    *Ryuta Kamizono*
+    Fixes #31670.
 
-*   Fix `rake db:migrate:status` with subdirectories.
+    *Yuriy Ustushenko*
 
-    *Ryuta Kamizono*
+*   Support for PostgreSQL foreign tables.
 
-*   Don't share options between reference id and type columns
+    *fatkodima*
 
-    When using a polymorphic reference column in a migration, sharing options
-    between the two columns doesn't make sense since they are different types.
-    The `reference_id` column is usually an integer and the `reference_type`
-    column a string so options like `unsigned: true` will result in an invalid
-    table definition.
+*   Fix relation merger issue with `left_outer_joins`.
 
-    *Ryuta Kamizono*
+    *Mehmet Emin İNAÇ*
 
-*   Use `max_identifier_length` for `index_name_length` in PostgreSQL adapter.
+*   Don't allow destroyed object mutation after `save` or `save!` is called.
 
     *Ryuta Kamizono*
 
-*   Deprecate `supports_migrations?` on connection adapters.
+*   Take into account association conditions when deleting through records.
 
-    *Ryuta Kamizono*
+    Fixes #18424.
 
-*   Fix regression of #1969 with SELECT aliases in HAVING clause.
+    *Piotr Jakubowski*
 
-    *Eugene Kenny*
+*   Fix nested `has_many :through` associations on unpersisted parent instances.
 
-*   Deprecate using `#quoted_id` in quoting.
+    For example, if you have
 
-    *Ryuta Kamizono*
+        class Post < ActiveRecord::Base
+          belongs_to :author
+          has_many :books, through: :author
+          has_many :subscriptions, through: :books
+        end
 
-*   Fix `wait_timeout` to configurable for mysql2 adapter.
+        class Author < ActiveRecord::Base
+          has_one :post
+          has_many :books
+          has_many :subscriptions, through: :books
+        end
 
-    Fixes #26556.
+        class Book < ActiveRecord::Base
+          belongs_to :author
+          has_many :subscriptions
+        end
 
-    *Ryuta Kamizono*
+        class Subscription < ActiveRecord::Base
+          belongs_to :book
+        end
 
-*   Correctly dump native timestamp types for MySQL.
+    Before:
 
-    The native timestamp type in MySQL is different from datetime type.
-    Internal representation of the timestamp type is UNIX time, This means
-    that timestamp columns are affected by time zone.
+    If `post` is not persisted, then `post.subscriptions` will be empty.
 
-        > SET time_zone = '+00:00';
-        Query OK, 0 rows affected (0.00 sec)
+    After:
 
-        > INSERT INTO time_with_zone(ts,dt) VALUES (NOW(),NOW());
-        Query OK, 1 row affected (0.02 sec)
+    If `post` is not persisted, then `post.subscriptions` can be set and used
+    just like it would if `post` were persisted.
 
-        > SELECT * FROM time_with_zone;
-        +---------------------+---------------------+
-        | ts                  | dt                  |
-        +---------------------+---------------------+
-        | 2016-02-07 22:11:44 | 2016-02-07 22:11:44 |
-        +---------------------+---------------------+
-        1 row in set (0.00 sec)
+    Fixes #16313.
 
-        > SET time_zone = '-08:00';
-        Query OK, 0 rows affected (0.00 sec)
+    *Zoltan Kiss*
 
-        > SELECT * FROM time_with_zone;
-        +---------------------+---------------------+
-        | ts                  | dt                  |
-        +---------------------+---------------------+
-        | 2016-02-07 14:11:44 | 2016-02-07 22:11:44 |
-        +---------------------+---------------------+
-        1 row in set (0.00 sec)
+*   Fixed inconsistency with `first(n)` when used with `limit()`.
+    The `first(n)` finder now respects the `limit()`, making it consistent
+    with `relation.to_a.first(n)`, and also with the behavior of `last(n)`.
 
-    *Ryuta Kamizono*
+    Fixes #23979.
 
-*   All integer-like PKs are autoincrement unless they have an explicit default.
+    *Brian Christian*
 
-    *Matthew Draper*
+*   Use `count(:all)` in `HasManyAssociation#count_records` to prevent invalid
+    SQL queries for association counting.
 
-*   Omit redundant `using: :btree` for schema dumping.
+    *Klas Eskilson*
 
-    *Ryuta Kamizono*
-
-*   Deprecate passing `default` to `index_name_exists?`.
+*   Fix to invoke callbacks when using `update_attribute`.
 
-    *Ryuta Kamizono*
+    *Mike Busch*
 
-*   PostgreSQL: schema dumping support for interval and OID columns.
+*   Fix `count(:all)` to correctly work `distinct` with custom SELECT list.
 
     *Ryuta Kamizono*
 
-*   Deprecate `supports_primary_key?` on connection adapters since it's
-    been long unused and unsupported.
+*   Using subselect for `delete_all` with `limit` or `offset`.
 
     *Ryuta Kamizono*
 
-*   Make `table_name=` reset current statement cache,
-    so queries are not run against the previous table name.
-
-    *namusyaka*
-
-*   Allow `ActiveRecord::Base#as_json` to be passed a frozen Hash.
-
-    *Isaac Betesh*
-
-*   Fix inspection behavior when the :id column is not primary key.
-
-    *namusyaka*
-
-*   Deprecate locking records with unpersisted changes.
-
-    *Marc Schütz*
+*   Undefine attribute methods on descendants when resetting column
+    information.
+
+    *Chris Salzberg*
+
+*   Log database query callers
+
+    Add `verbose_query_logs` configuration option to display the caller
+    of database queries in the log to facilitate N+1 query resolution
+    and other debugging.
+
+    Enabled in development only for new and upgraded applications. Not
+    recommended for use in the production environment since it relies
+    on Ruby's `Kernel#caller_locations` which is fairly slow.
+
+    *Olivier Lacan*
+
+*   Fix conflicts `counter_cache` with `touch: true` by optimistic locking.
+
+    ```
+    # create_table :posts do |t|
+    #   t.integer :comments_count, default: 0
+    #   t.integer :lock_version
+    #   t.timestamps
+    # end
+    class Post < ApplicationRecord
+    end
+
+    # create_table :comments do |t|
+    #   t.belongs_to :post
+    # end
+    class Comment < ApplicationRecord
+      belongs_to :post, touch: true, counter_cache: true
+    end
+    ```
+
+    Before:
+    ```
+    post = Post.create!
+    # => begin transaction
+         INSERT INTO "posts" ("created_at", "updated_at", "lock_version")
+         VALUES ("2017-12-11 21:27:11.387397", "2017-12-11 21:27:11.387397", 0)
+         commit transaction
+
+    comment = Comment.create!(post: post)
+    # => begin transaction
+         INSERT INTO "comments" ("post_id") VALUES (1)
+
+         UPDATE "posts" SET "comments_count" = COALESCE("comments_count", 0) + 1,
+         "lock_version" = COALESCE("lock_version", 0) + 1 WHERE "posts"."id" = 1
+
+         UPDATE "posts" SET "updated_at" = '2017-12-11 21:27:11.398330',
+         "lock_version" = 1 WHERE "posts"."id" = 1 AND "posts"."lock_version" = 0
+         rollback transaction
+    # => ActiveRecord::StaleObjectError: Attempted to touch a stale object: Post.
+
+    Comment.take.destroy!
+    # => begin transaction
+         DELETE FROM "comments" WHERE "comments"."id" = 1
+
+         UPDATE "posts" SET "comments_count" = COALESCE("comments_count", 0) - 1,
+         "lock_version" = COALESCE("lock_version", 0) + 1 WHERE "posts"."id" = 1
+
+         UPDATE "posts" SET "updated_at" = '2017-12-11 21:42:47.785901',
+         "lock_version" = 1 WHERE "posts"."id" = 1 AND "posts"."lock_version" = 0
+         rollback transaction
+    # => ActiveRecord::StaleObjectError: Attempted to touch a stale object: Post.
+    ```
+
+    After:
+    ```
+    post = Post.create!
+    # => begin transaction
+         INSERT INTO "posts" ("created_at", "updated_at", "lock_version")
+         VALUES ("2017-12-11 21:27:11.387397", "2017-12-11 21:27:11.387397", 0)
+         commit transaction
+
+    comment = Comment.create!(post: post)
+    # => begin transaction
+         INSERT INTO "comments" ("post_id") VALUES (1)
+
+         UPDATE "posts" SET "comments_count" = COALESCE("comments_count", 0) + 1,
+         "lock_version" = COALESCE("lock_version", 0) + 1,
+         "updated_at" = '2017-12-11 21:37:09.802642' WHERE "posts"."id" = 1
+         commit transaction
+
+    comment.destroy!
+    # => begin transaction
+         DELETE FROM "comments" WHERE "comments"."id" = 1
+
+         UPDATE "posts" SET "comments_count" = COALESCE("comments_count", 0) - 1,
+         "lock_version" = COALESCE("lock_version", 0) + 1,
+         "updated_at" = '2017-12-11 21:39:02.685520' WHERE "posts"."id" = 1
+         commit transaction
+    ```
+
+    Fixes #31199.
 
-*   Remove deprecated behavior that halts callbacks when the return is false.
-
-    *Rafael Mendonça França*
-
-*   Deprecate `ColumnDumper#migration_keys`.
-
-    *Ryuta Kamizono*
-
-*   Fix `association_primary_key_type` for reflections with symbol primary key.
-
-    Fixes #27864.
-
-    *Daniel Colson*
-
-*   Virtual/generated column support for MySQL 5.7.5+ and MariaDB 5.2.0+.
-
-    MySQL generated columns: https://dev.mysql.com/doc/refman/5.7/en/create-table-generated-columns.html
-    MariaDB virtual columns: https://mariadb.com/kb/en/mariadb/virtual-computed-columns/
+    *bogdanvlviv*
 
-    Declare virtual columns with `t.virtual name, type: …, as: "expression"`.
-    Pass `stored: true` to persist the generated value (false by default).
+*   Add support for PostgreSQL operator classes to `add_index`.
 
     Example:
 
-        create_table :generated_columns do |t|
-          t.string  :name
-          t.virtual :upper_name,  type: :string,  as: "UPPER(name)"
-          t.virtual :name_length, type: :integer, as: "LENGTH(name)", stored: true
-          t.index :name_length  # May be indexed, too!
-        end
-
-    *Ryuta Kamizono*
-
-*   Deprecate `initialize_schema_migrations_table` and `initialize_internal_metadata_table`.
-
-    *Ryuta Kamizono*
-
-*   Support foreign key creation for SQLite3.
-
-    *Ryuta Kamizono*
-
-*   Place generated migrations into the path set by `config.paths["db/migrate"]`.
+        add_index :users, :name, using: :gist, opclass: { name: :gist_trgm_ops }
 
-    *Kevin Glowacz*
+    *Greg Navis*
 
-*   Raise `ActiveRecord::InvalidForeignKey` when a foreign key constraint fails on SQLite3.
+*   Don't allow scopes to be defined which conflict with instance methods on `Relation`.
 
-    *Ryuta Kamizono*
-
-*   Add the touch option to `#increment!` and `#decrement!`.
+    Fixes #31120.
 
-    *Hiroaki Izu*
+    *kinnrot*
 
-*   Deprecate passing a class to the `class_name` because it eagerloads more classes than
-    necessary and potentially creates circular dependencies.
 
-    *Kir Shatrov*
+## Rails 5.2.0.beta2 (November 28, 2017) ##
 
-*   Raise error when has_many through is defined before through association.
+*   No changes.
 
-    Fixes #26834.
 
-    *Chris Holmes*
+## Rails 5.2.0.beta1 (November 27, 2017) ##
 
-*   Deprecate passing `name` to `indexes`.
+*   Add new error class `QueryCanceled` which will be raised
+    when canceling statement due to user request.
 
     *Ryuta Kamizono*
 
-*   Remove deprecated tasks: `db:test:clone`, `db:test:clone_schema`, `db:test:clone_structure`.
+*   Add `#up_only` to database migrations for code that is only relevant when
+    migrating up, e.g. populating a new column.
 
-    *Rafel Mendonça França*
+    *Rich Daley*
 
-*   Compare deserialized values for `PostgreSQL::OID::Hstore` types when
-    calling `ActiveRecord::Dirty#changed_in_place?`.
-
-    Fixes #27502.
-
-    *Jon Moss*
+*   Require raw SQL fragments to be explicitly marked when used in
+    relation query methods.
 
-*   Raise `ArgumentError` when passing an `ActiveRecord::Base` instance to `.find`,
-    `.exists?` and `.update`.
+    Before:
+    ```
+    Article.order("LENGTH(title)")
+    ```
 
-    *Rafael Mendonça França*
-
-*   Respect precision option for arrays of timestamps.
-
-    Fixes #27514.
-
-    *Sean Griffin*
+    After:
+    ```
+    Article.order(Arel.sql("LENGTH(title)"))
+    ```
 
-*   Optimize slow model instantiation when using STI and `store_full_sti_class = false` option.
+    This prevents SQL injection if applications use the [strongly
+    discouraged] form `Article.order(params[:my_order])`, under the
+    mistaken belief that only column names will be accepted.
 
-    *Konstantin Lazarev*
+    Raw SQL strings will now cause a deprecation warning, which will
+    become an UnknownAttributeReference error in Rails 6.0. Applications
+    can opt in to the future behavior by setting `allow_unsafe_raw_sql`
+    to `:disabled`.
 
-*   Add `touch` option to counter cache modifying methods.
+    Common and judged-safe string values (such as simple column
+    references) are unaffected:
+    ```
+    Article.order("title DESC")
+    ```
 
-    Works when updating, resetting, incrementing and decrementing counters:
+    *Ben Toews*
 
-        # Touches `updated_at`/`updated_on`.
-        Topic.increment_counter(:messages_count, 1, touch: true)
-        Topic.decrement_counter(:messages_count, 1, touch: true)
+*   `update_all` will now pass its values to `Type#cast` before passing them to
+    `Type#serialize`. This means that `update_all(foo: 'true')` will properly
+    persist a boolean.
 
-        # Touches `last_discussed_at`.
-        Topic.reset_counters(18, :messages, touch: :last_discussed_at)
-
-        # Touches `updated_at` and `last_discussed_at`.
-        Topic.update_counters(18, messages_count: 5, touch: %i( updated_at last_discussed_at ))
-
-    Fixes #26724.
-
-    *Jarred Trost*
-
-*   Remove deprecated `#uniq`, `#uniq!`, and `#uniq_value`.
-
-    *Ryuta Kamizono*
+    *Sean Griffin*
 
-*   Remove deprecated `#insert_sql`, `#update_sql`, and `#delete_sql`.
+*   Add new error class `StatementTimeout` which will be raised
+    when statement timeout exceeded.
 
     *Ryuta Kamizono*
 
-*   Remove deprecated `#use_transactional_fixtures` configuration.
-
-    *Rafael Mendonça França*
-
-*   Remove deprecated `#raise_in_transactional_callbacks` configuration.
+*   Fix `bin/rails db:migrate` with specified `VERSION`.
+    `bin/rails db:migrate` with empty VERSION behaves as without `VERSION`.
+    Check a format of `VERSION`: Allow a migration version number
+    or name of a migration file. Raise error if format of `VERSION` is invalid.
+    Raise error if target migration doesn't exist.
 
-    *Rafael Mendonça França*
-
-*   Remove deprecated `#load_schema_for`.
+    *bogdanvlviv*
 
-    *Rafael Mendonça França*
+*   Fixed a bug where column orders for an index weren't written to
+    `db/schema.rb` when using the sqlite adapter.
 
-*   Remove deprecated conditions parameter from `#destroy_all` and `#delete_all`.
+    Fixes #30902.
 
-    *Rafael Mendonça França*
+    *Paul Kuruvilla*
 
-*   Remove deprecated support to passing arguments to `#select` when a block is provided.
+*   Remove deprecated method `#sanitize_conditions`.
 
     *Rafael Mendonça França*
 
-*   Remove deprecated support to query using commas on LIMIT.
+*   Remove deprecated method `#scope_chain`.
 
     *Rafael Mendonça França*
 
-*   Remove deprecated support to passing a class as a value in a query.
+*   Remove deprecated configuration `.error_on_ignored_order_or_limit`.
 
     *Rafael Mendonça França*
 
-*   Raise `ActiveRecord::IrreversibleOrderError` when using `last` with an irreversible
-    order.
+*   Remove deprecated arguments from `#verify!`.
 
     *Rafael Mendonça França*
 
-*   Raise when a `has_many :through` association has an ambiguous reflection name.
+*   Remove deprecated argument `name` from `#indexes`.
 
     *Rafael Mendonça França*
 
-*   Raise when `ActiveRecord::Migration` is inherited from directly.
+*   Remove deprecated method `ActiveRecord::Migrator.schema_migrations_table_name`.
 
     *Rafael Mendonça França*
 
-*   Remove deprecated `original_exception` argument in `ActiveRecord::StatementInvalid#initialize`
-    and `ActiveRecord::StatementInvalid#original_exception`.
+*   Remove deprecated method `supports_primary_key?`.
 
     *Rafael Mendonça França*
 
-*   `#tables` and `#table_exists?` return only tables and not views.
-
-    All the deprecations on those methods were removed.
+*   Remove deprecated method `supports_migrations?`.
 
     *Rafael Mendonça França*
 
-*   Remove deprecated `name` argument from `#tables`.
+*   Remove deprecated methods `initialize_schema_migrations_table` and `initialize_internal_metadata_table`.
 
     *Rafael Mendonça França*
 
-*   Remove deprecated support to passing a column to `#quote`.
+*   Raises when calling `lock!` in a dirty record.
 
     *Rafael Mendonça França*
 
-*   Set `:time` as a timezone aware type and remove deprecation when
-    `config.active_record.time_zone_aware_types` is not explicitly set.
+*   Remove deprecated support to passing a class to `:class_name` on associations.
 
     *Rafael Mendonça França*
 
-*   Remove deprecated force reload argument in singular and collection association readers.
+*   Remove deprecated argument `default` from `index_name_exists?`.
 
     *Rafael Mendonça França*
 
-*   Remove deprecated `activerecord.errors.messages.restrict_dependent_destroy.one` and
-    `activerecord.errors.messages.restrict_dependent_destroy.many` i18n scopes.
+*   Remove deprecated support to `quoted_id` when typecasting an Active Record object.
 
     *Rafael Mendonça França*
 
-*   Allow passing extra flags to `db:structure:load` and `db:structure:dump`
-
-    Introduces `ActiveRecord::Tasks::DatabaseTasks.structure_(load|dump)_flags` to customize the
-    eventual commands run against the database, e.g. mysqldump/pg_dump.
-
-    *Kir Shatrov*
-
-*   Notifications see frozen SQL string.
-
-    Fixes #23774.
+*   Fix `bin/rails db:setup` and `bin/rails db:test:prepare` create  wrong
+    ar_internal_metadata's data for a test database.
 
-    *Richard Monette*
+    Before:
+    ```
+    $ RAILS_ENV=test rails dbconsole
+    > SELECT * FROM ar_internal_metadata;
+    key|value|created_at|updated_at
+    environment|development|2017-09-11 23:14:10.815679|2017-09-11 23:14:10.815679
+    ```
 
-*   RuntimeErrors are no longer translated to `ActiveRecord::StatementInvalid`.
+    After:
+    ```
+    $ RAILS_ENV=test rails dbconsole
+    > SELECT * FROM ar_internal_metadata;
+    key|value|created_at|updated_at
+    environment|test|2017-09-11 23:14:10.815679|2017-09-11 23:14:10.815679
+    ```
 
-    *Richard Monette*
+    Fixes #26731.
 
-*   Change the schema cache format to use YAML instead of Marshal.
-
-    *Kir Shatrov*
+    *bogdanvlviv*
 
-*   Support index length and order options using both string and symbol
-    column names.
+*   Fix longer sequence name detection for serial columns.
 
-    Fixes #27243.
+    Fixes #28332.
 
     *Ryuta Kamizono*
 
-*   Raise `ActiveRecord::RangeError` when values that executed are out of range.
+*   MySQL: Don't lose `auto_increment: true` in the `db/schema.rb`.
 
-    *Ryuta Kamizono*
-
-*   Raise `ActiveRecord::NotNullViolation` when a record cannot be inserted
-    or updated because it would violate a not null constraint.
+    Fixes #30894.
 
     *Ryuta Kamizono*
 
-*   Emulate db trigger behaviour for after_commit :destroy, :update.
-
-    Race conditions can occur when an ActiveRecord is destroyed
-    twice or destroyed and updated. The callbacks should only be
-    triggered once, similar to a SQL database trigger.
+*   Fix `COUNT(DISTINCT ...)` for `GROUP BY` with `ORDER BY` and `LIMIT`.
 
-    *Stefan Budeanu*
+    Fixes #30886.
 
-*   Moved `DecimalWithoutScale`, `Text`, and `UnsignedInteger` from Active Model to Active Record.
-
-    *Iain Beeston*
+    *Ryuta Kamizono*
 
-*   Fix `write_attribute` method to check whether an attribute is aliased or not, and
-    use the aliased attribute name if needed.
+*   PostgreSQL `tsrange` now preserves subsecond precision.
 
-    *Prathamesh Sonpatki*
+    PostgreSQL 9.1+ introduced range types, and Rails added support for using
+    this datatype in Active Record. However, the serialization of
+    `PostgreSQL::OID::Range` was incomplete, because it did not properly
+    cast the bounds that make up the range. This led to subseconds being
+    dropped in SQL commands:
 
-*   Fix `read_attribute` method to check whether an attribute is aliased or not, and
-    use the aliased attribute name if needed.
+    Before:
 
-    Fixes #26417.
+        connection.type_cast(tsrange.serialize(range_value))
+        # => "[2010-01-01 13:30:00 UTC,2011-02-02 19:30:00 UTC)"
 
-    *Prathamesh Sonpatki*
+    Now:
 
-*   PostgreSQL & MySQL: Use big integer as primary key type for new tables.
+        connection.type_cast(tsrange.serialize(range_value))
+        # => "[2010-01-01 13:30:00.670277,2011-02-02 19:30:00.745125)"
 
-    *Jon McCartie*, *Pavel Pravosud*
+    *Thomas Cannon*
 
-*   Change the type argument of `ActiveRecord::Base#attribute` to be optional.
-    The default is now `ActiveRecord::Type::Value.new`, which provides no type
-    casting behavior.
+*   Passing a `Set` to `Relation#where` now behaves the same as passing an
+    array.
 
     *Sean Griffin*
 
-*   Don't treat unsigned integers with zerofill as signed.
+*   Use given algorithm while removing index from database.
 
-    Fixes #27125.
+    Fixes #24190.
 
-    *Ryuta Kamizono*
+    *Mehmet Emin İNAÇ*
 
-*   Fix the uniqueness validation scope with a polymorphic association.
+*   Update payload names for `sql.active_record` instrumentation to be
+    more descriptive.
 
-    *Sergey Alekseev*
+    Fixes #30586.
 
-*   Raise `ActiveRecord::RecordNotFound` from collection `*_ids` setters
-    for unknown IDs with a better error message.
+    *Jeremy Green*
 
-    Changes the collection `*_ids` setters to cast provided IDs the data
-    type of the primary key set in the association, not the model
-    primary key.
+*   Add new error class `LockWaitTimeout` which will be raised
+    when lock wait timeout exceeded.
 
-    *Dominic Cleal*
+    *Gabriel Courtemanche*
 
-*   For PostgreSQL >= 9.4 use `pgcrypto`'s `gen_random_uuid()` instead of
-    `uuid-ossp`'s UUID generation function.
+*   Remove deprecated `#migration_keys`.
 
-    *Yuji Yaginuma*, *Yaw Boakye*
+    *Ryuta Kamizono*
 
-*   Introduce `Model#reload_<association>` to bring back the behavior
-    of `Article.category(true)` where `category` is a singular
-    association.
+*   Automatically guess the inverse associations for STI.
 
-    The force reloading of the association reader was deprecated
-    in #20888. Unfortunately the suggested alternative of
-    `article.reload.category` does not expose the same behavior.
+    *Yuichiro Kaneko*
 
-    This patch adds a reader method with the prefix `reload_` for
-    singular associations. This method has the same semantics as
-    passing true to the association reader used to have.
+*   Ensure `sum` honors `distinct` on `has_many :through` associations
 
-    *Yves Senn*
+    Fixes #16791.
 
-*   Make sure eager loading `ActiveRecord::Associations` also loads
-    constants defined in `ActiveRecord::Associations::Preloader`.
+    *Aaron Wortham*
 
-    *Yves Senn*
+*   Add `binary` fixture helper method.
 
-*   Allow `ActionController::Parameters`-like objects to be passed as
-    values for Postgres HStore columns.
+    *Atsushi Yoshida*
 
-    Fixes #26904.
+*   When using `Relation#or`, extract the common conditions and put them before the OR condition.
 
-    *Jon Moss*
+    *Maxime Handfield Lapointe*
 
-*   Added `stat` method to `ActiveRecord::ConnectionAdapters::ConnectionPool`.
+*   `Relation#or` now accepts two relations who have different values for
+    `references` only, as `references` can be implicitly called by `where`.
 
-    Example:
+    Fixes #29411.
 
-        ActiveRecord::Base.connection_pool.stat # =>
-        { size: 15, connections: 1, busy: 1, dead: 0, idle: 0, waiting: 0, checkout_timeout: 5 }
+    *Sean Griffin*
 
-    *Pavel Evstigneev*
+*   `ApplicationRecord` is no longer generated when generating models. If you
+    need to generate it, it can be created with `rails g application_record`.
 
-*   Avoid `unscope(:order)` when `limit_value` is presented for `count`
-    and `exists?`.
+    *Lisa Ugray*
 
-    If `limit_value` is presented, records fetching order is very important
-    for performance. We should not unscope the order in the case.
+*   Fix `COUNT(DISTINCT ...)` with `ORDER BY` and `LIMIT` to keep the existing select list.
 
     *Ryuta Kamizono*
 
-*   Fix an Active Record `DateTime` field `NoMethodError` caused by incomplete
-    datetime.
-
-    Fixes #24195.
-
-    *Sen Zhang*
+*   When a `has_one` association is destroyed by `dependent: destroy`,
+    `destroyed_by_association` will now be set to the reflection, matching the
+    behaviour of `has_many` associations.
 
-*   Allow `slice` to take an array of methods(without the need for splatting).
-
-    *Cohen Carlisle*
-
-*   Improved partial writes with HABTM and has many through associations
-    to fire database query only if relation has been changed.
-
-    Fixes #19663.
-
-    *Mehmet Emin İNAÇ*
+    *Lisa Ugray*
 
-*   Deprecate passing arguments and block at the same time to
-    `ActiveRecord::QueryMethods#select`.
+*   Fix `unscoped(where: [columns])` removing the wrong bind values
 
-    *Prathamesh Sonpatki*
+    When the `where` is called on a relation after a `or`, unscoping the column of that later `where` removed
+    bind values used by the `or` instead. (possibly other cases too)
 
-*   Fixed: Optimistic locking does not work well with `null` in the database.
+    ```
+    Post.where(id: 1).or(Post.where(id: 2)).where(foo: 3).unscope(where: :foo).to_sql
+    # Currently:
+    #     SELECT "posts".* FROM "posts" WHERE ("posts"."id" = 2 OR "posts"."id" = 3)
+    # With fix:
+    #     SELECT "posts".* FROM "posts" WHERE ("posts"."id" = 1 OR "posts"."id" = 2)
+    ```
 
-    Fixes #26024.
-
-    *bogdanvlviv*
-
-*   Fixed support for case insensitive comparisons of `text` columns in
-    PostgreSQL.
+    *Maxime Handfield Lapointe*
 
-    *Edho Arief*
+*   Values constructed using multi-parameter assignment will now use the
+    post-type-cast value for rendering in single-field form inputs.
 
-*   Serialize JSON attribute value `nil` as SQL `NULL`, not JSON `null`.
+    *Sean Griffin*
 
-    *Trung Duc Tran*
+*   `Relation#joins` is no longer affected by the target model's
+    `current_scope`, with the exception of `unscoped`.
 
-*   Return `true` from `update_attribute` when the value of the attribute
-    to be updated is unchanged.
+    Fixes #29338.
 
-    Fixes #26593.
+    *Sean Griffin*
 
-    *Prathamesh Sonpatki*
+*   Change sqlite3 boolean serialization to use 1 and 0
 
-*   Always store errors details information with symbols.
+    SQLite natively recognizes 1 and 0 as true and false, but does not natively
+    recognize 't' and 'f' as was previously serialized.
 
-    When the association is autosaved we were storing the details with
-    string keys. This was creating inconsistency with other details that are
-    added using the `Errors#add` method. It was also inconsistent with the
-    `Errors#messages` storage.
+    This change in serialization requires a migration of stored boolean data
+    for SQLite databases, so it's implemented behind a configuration flag
+    whose default false value is deprecated.
 
-    To fix this inconsistency we are always storing with symbols. This will
-    cause a small breaking change because in those cases the details could
-    be accessed as strings keys but now it can not.
+    *Lisa Ugray*
 
-    Fix #26499.
+*   Skip query caching when working with batches of records (`find_each`, `find_in_batches`,
+    `in_batches`).
 
-    *Rafael Mendonça França*, *Marcus Vieira*
+    Previously, records would be fetched in batches, but all records would be retained in memory
+    until the end of the request or job.
 
-*   Calling `touch` on a model using optimistic locking will now leave the model
-    in a non-dirty state with no attribute changes.
+    *Eugene Kenny*
 
-    Fixes #26496.
+*   Prevent errors raised by `sql.active_record` notification subscribers from being converted into
+    `ActiveRecord::StatementInvalid` exceptions.
 
-    *Jakob Skjerning*
+    *Dennis Taylor*
 
-*   Using a mysql2 connection after it fails to reconnect will now have an error message
-    saying the connection is closed rather than an undefined method error message.
+*   Fix eager loading/preloading association with scope including joins.
 
-    *Dylan Thacker-Smith*
+    Fixes #28324.
 
-*   PostgreSQL array columns will now respect the encoding of strings contained
-    in the array.
+    *Ryuta Kamizono*
 
-    Fixes #26326.
+*   Fix transactions to apply state to child transactions
 
-    *Sean Griffin*
+    Previously, if you had a nested transaction and the outer transaction was rolledback, the record from the
+    inner transaction would still be marked as persisted.
 
-*   Inverse association instances will now be set before `after_find` or
-    `after_initialize` callbacks are run.
+    This change fixes that by applying the state of the parent transaction to the child transaction when the
+    parent transaction is rolledback. This will correctly mark records from the inner transaction as not persisted.
 
-    Fixes #26320.
+    *Eileen M. Uchitelle*, *Aaron Patterson*
 
-    *Sean Griffin*
+*   Deprecate `set_state` method in `TransactionState`
 
-*   Remove unnecessarily association load when a `belongs_to` association has already been
-    loaded then the foreign key is changed directly and the record saved.
+    Deprecated the `set_state` method in favor of setting the state via specific methods. If you need to mark the
+    state of the transaction you can now use `rollback!`, `commit!` or `nullify!` instead of
+    `set_state(:rolledback)`, `set_state(:committed)`, or `set_state(nil)`.
 
-    *James Coleman*
+    *Eileen M. Uchitelle*, *Aaron Patterson*
 
-*   Remove standardized column types/arguments spaces in schema dump.
+*   Deprecate delegating to `arel` in `Relation`.
 
-    *Tim Petricola*
-
-*   Avoid loading records from database when they are already loaded using
-    the `pluck` method on a collection.
+    *Ryuta Kamizono*
 
-    Fixes #25921.
+*   Fix eager loading to respect `store_full_sti_class` setting.
 
     *Ryuta Kamizono*
 
-*   Remove text default treated as an empty string in non-strict mode for
-    consistency with other types.
-
-    Strict mode controls how MySQL handles invalid or missing values in
-    data-change statements such as INSERT or UPDATE. If strict mode is not
-    in effect, MySQL inserts adjusted values for invalid or missing values
-    and produces warnings.
-
-        def test_mysql_not_null_defaults_non_strict
-          using_strict(false) do
-            with_mysql_not_null_table do |klass|
-              record = klass.new
-              assert_nil record.non_null_integer
-              assert_nil record.non_null_string
-              assert_nil record.non_null_text
-              assert_nil record.non_null_blob
-
-              record.save!
-              record.reload
-
-              assert_equal 0,  record.non_null_integer
-              assert_equal "", record.non_null_string
-              assert_equal "", record.non_null_text
-              assert_equal "", record.non_null_blob
-            end
-          end
-        end
-
-    https://dev.mysql.com/doc/refman/5.7/en/sql-mode.html#sql-mode-strict
+*   Query cache was unavailable when entering the `ActiveRecord::Base.cache` block
+    without being connected.
 
-    *Ryuta Kamizono*
+    *Tsukasa Oishi*
 
-*   SQLite3 migrations to add a column to an existing table can now be
-    successfully rolled back when the column was given and invalid column
-    type.
+*   Previously, when building records using a `has_many :through` association,
+    if the child records were deleted before the parent was saved, they would
+    still be persisted. Now, if child records are deleted before the parent is saved
+    on a `has_many :through` association, the child records will not be persisted.
 
-    Fixes #26087.
+    *Tobias Kraze*
 
-    *Travis O'Neill*
+*   Merging two relations representing nested joins no longer transforms the joins of
+    the merged relation into LEFT OUTER JOIN. Example to clarify:
 
-*   Deprecate `sanitize_conditions`. Use `sanitize_sql` instead.
+    ```
+    Author.joins(:posts).merge(Post.joins(:comments))
+    # Before the change:
+    #=> SELECT ... FROM authors INNER JOIN posts ON ... LEFT OUTER JOIN comments ON...
 
-    *Ryuta Kamizono*
+    # After the change:
+    #=> SELECT ... FROM authors INNER JOIN posts ON ... INNER JOIN comments ON...
+    ```
 
-*   Doing count on relations that contain LEFT OUTER JOIN Arel node no longer
-    force a DISTINCT. This solves issues when using count after a left_joins.
+    TODO: Add to the Rails 5.2 upgrade guide
 
     *Maxime Handfield Lapointe*
 
-*   RecordNotFound raised by association.find exposes `id`, `primary_key` and
-    `model` methods to be consistent with RecordNotFound raised by Record.find.
+*   `ActiveRecord::Persistence#touch` does not work well when optimistic locking enabled and
+    `locking_column`, without default value, is null in the database.
 
-    *Michel Pigassou*
+    *bogdanvlviv*
 
-*   Hashes can once again be passed to setters of `composed_of`, if all of the
-    mapping methods are methods implemented on `Hash`.
+*   Fix destroying existing object does not work well when optimistic locking enabled and
+    `locking_column` is null in the database.
 
-    Fixes #25978.
+    *bogdanvlviv*
 
-    *Sean Griffin*
+*   Use bulk INSERT to insert fixtures for better performance.
 
-*   Fix the SELECT statement in `#table_comment` for MySQL.
+    *Kir Shatrov*
 
-    *Takeshi Akima*
+*   Prevent creation of bind param if casted value is nil.
 
-*   Virtual attributes will no longer raise when read on models loaded from the
-    database.
+    *Ryuta Kamizono*
 
-    *Sean Griffin*
+*   Deprecate passing arguments and block at the same time to `count` and `sum` in `ActiveRecord::Calculations`.
 
-*   Support calling the method `merge` in `scope`'s lambda.
+    *Ryuta Kamizono*
 
-    *Yasuhiro Sugino*
+*   Loading model schema from database is now thread-safe.
 
-*   Fixes multi-parameter attributes conversion with invalid params.
+    Fixes #28589.
 
-    *Hiroyuki Ishii*
+    *Vikrant Chaudhary*, *David Abdemoulaie*
 
-*   Add newline between each migration in `structure.sql`.
+*   Add `ActiveRecord::Base#cache_version` to support recyclable cache keys via the new versioned entries
+    in `ActiveSupport::Cache`. This also means that `ActiveRecord::Base#cache_key` will now return a stable key
+    that does not include a timestamp any more.
 
-    Keeps schema migration inserts as a single commit, but allows for easier
-    git diffing.
+    NOTE: This feature is turned off by default, and `#cache_key` will still return cache keys with timestamps
+    until you set `ActiveRecord::Base.cache_versioning = true`. That's the setting for all new apps on Rails 5.2+
 
-    Fixes #25504.
+    *DHH*
 
-    *Grey Baker*, *Norberto Lopes*
+*   Respect `SchemaDumper.ignore_tables` in rake tasks for databases structure dump
 
-*   The flag `error_on_ignored_order_or_limit` has been deprecated in favor of
-    the current `error_on_ignored_order`.
+    *Rusty Geldmacher*, *Guillermo Iguaran*
 
-    *Xavier Noria*
+*   Add type caster to `RuntimeReflection#alias_name`
 
-*   Batch processing methods support `limit`:
+    Fixes #28959.
 
-        Post.limit(10_000).find_each do |post|
-          # ...
-        end
+    *Jon Moss*
 
-    It also works in `find_in_batches` and `in_batches`.
+*   Deprecate `supports_statement_cache?`.
 
-    *Xavier Noria*
+    *Ryuta Kamizono*
 
-*   Using `group` with an attribute that has a custom type will properly cast
-    the hash keys after calling a calculation method like `count`.
+*   Raise error `UnknownMigrationVersionError` on the movement of migrations
+    when the current migration does not exist.
 
-    Fixes #25595.
+    *bogdanvlviv*
 
-    *Sean Griffin*
+*   Fix `bin/rails db:forward` first migration.
 
-*   Fix the generated `#to_param` method to use `omission: ''` so that
-    the resulting output is actually up to 20 characters, not
-    effectively 17 to leave room for the default "...".
-    Also call `#parameterize` before `#truncate` and make the
-    `separator: /-/` to maximize the information included in the
-    output.
+    *bogdanvlviv*
 
-    Fixes #23635.
+*   Support Descending Indexes for MySQL.
 
-    *Rob Biedenharn*
+    MySQL 8.0.1 and higher supports descending indexes: `DESC` in an index definition is no longer ignored.
+    See https://dev.mysql.com/doc/refman/8.0/en/descending-indexes.html.
 
-*   Ensure concurrent invocations of the connection reaper cannot allocate the
-    same connection to two threads.
+    *Ryuta Kamizono*
 
-    Fixes #25585.
+*   Fix inconsistency with changed attributes when overriding Active Record attribute reader.
 
-    *Matthew Draper*
+    *bogdanvlviv*
 
-*   Inspecting an object with an associated array of over 10 elements no longer
-    truncates the array, preventing `inspect` from looping infinitely in some
-    cases.
+*   When calling the dynamic fixture accessor method with no arguments, it now returns all fixtures of this type.
+    Previously this method always returned an empty array.
 
     *Kevin McPhillips*
 
-*   Removed the unused methods `ActiveRecord::Base.connection_id` and
-    `ActiveRecord::Base.connection_id=`.
-
-    *Sean Griffin*
-
-*   Ensure hashes can be assigned to attributes created using `composed_of`.
-
-    Fixes #25210.
-
-    *Sean Griffin*
-
-*   Fix logging edge case where if an attribute was of the binary type and
-    was provided as a Hash.
-
-    *Jon Moss*
-
-*   Handle JSON deserialization correctly if the column default from database
-    adapter returns `''` instead of `nil`.
-
-    *Johannes Opper*
-
-*   Introduce new Active Record transaction error classes for catching
-    transaction serialization failures or deadlocks.
-
-    *Erol Fornoles*
-
-*   PostgreSQL: Fix `db:structure:load` silent failure on SQL error.
-
-    The command line flag `-v ON_ERROR_STOP=1` should be used
-    when invoking `psql` to make sure errors are not suppressed.
-
-    Example:
-
-        psql -v ON_ERROR_STOP=1 -q -f awesome-file.sql my-app-db
-
-    Fixes #23818.
-
-    *Ralin Chimev*
-
 
-Please check [5-0-stable](https://github.com/rails/rails/blob/5-0-stable/activerecord/CHANGELOG.md) for previous changes.
+Please check [5-1-stable](https://github.com/rails/rails/blob/5-1-stable/activerecord/CHANGELOG.md) for previous changes.