activerecord 5.1.0.rc2 → 5.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 68113d7968e655698251c14372de192d2e8e38da
-  data.tar.gz: 80fdb87c4ba3d63700799dd66b24d078c9ab9748
+  metadata.gz: b681beb18e3fb91541c6c1111e35b2a339cc0938
+  data.tar.gz: 0314f6221b13f28cf656b1d3443588f4d67e7982
 SHA512:
-  metadata.gz: 84e1eb324d24437342da23fc2d7c255ce23a2fab0888e5d347f98eb5bdfa9d8ef1e066800d7383f8cea1c76b006c965e1aa61599937502580da69821eea21844
-  data.tar.gz: de2d5f8de26cf8593c3ad320f9793d1df65260501b097dbbe8fadc122b97588a42c85cdc8ed7cec21e33106d076390dff00fa2cd5073eaf390eb3bd561f95e19
+  metadata.gz: 57725b96fdd14163059603613367d25276c1392c9389c1a1e79ea1993d569884da3a057869480545ab3310d01cb47e9da06116f42b8ea61c71b5e0dff2fb7bfc
+  data.tar.gz: e51aae2c1dace0810c3b7f572ba405a8892d07dccce8d4632540c488f875a815ab56e82c8e7de04a9bfe341c7733e4a2cc61187c2297ffefcb2a0fa000fc0f3f

data/CHANGELOG.md

@@ -1,4 +1,4 @@
-## Rails 5.1.0.rc2 (April 20, 2017) ##
+## Rails 5.1.0 (April 27, 2017) ##
 
 *   Quote database name in db:create grant statement (when database_user does not have access to create the database).
 
@@ -21,9 +21,6 @@
 
     *Hendy Tanata*
 
-
-## Rails 5.1.0.rc1 (March 20, 2017) ##
-
 *   Remove comments from structure.sql when using postgresql adapter to avoid
     version-specific parts of the file.
 
@@ -113,9 +110,6 @@
 
     *Ryuta Kamizono*
 
-
-## Rails 5.1.0.beta1 (February 23, 2017) ##
-
 *   Correctly dump native timestamp types for MySQL.
 
     The native timestamp type in MySQL is different from datetime type.

data/lib/active_record/associations/belongs_to_association.rb

@@ -22,7 +22,7 @@ module ActiveRecord
       end
 
       def default(&block)
-        writer(instance_exec(&block)) if reader.nil?
+        writer(owner.instance_exec(&block)) if reader.nil?
       end
 
       def reset

data/lib/active_record/associations/collection_proxy.rb

@@ -1125,6 +1125,19 @@ module ActiveRecord
 
       delegate(*delegate_methods, to: :scope)
 
+      module DelegateExtending # :nodoc:
+        private
+          def method_missing(method, *args, &block)
+            extending_values = association_scope.extending_values
+            if extending_values.any? && (extending_values - self.class.included_modules).any?
+              self.class.include(*extending_values)
+              public_send(method, *args, &block)
+            else
+              super
+            end
+          end
+      end
+
       private
 
         def find_nth_with_limit(index, limit)
@@ -1145,21 +1158,16 @@ module ActiveRecord
           @association.find_from_target?
         end
 
+        def association_scope
+          @association.association_scope
+        end
+
         def exec_queries
           load_target
         end
 
         def respond_to_missing?(method, _)
-          scope.respond_to?(method) || super
-        end
-
-        def method_missing(method, *args, &block)
-          if scope.respond_to?(method) && scope.extending_values.any?
-            extend(*scope.extending_values)
-            public_send(method, *args, &block)
-          else
-            super
-          end
+          association_scope.respond_to?(method) || super
         end
     end
   end

data/lib/active_record/collection_cache_key.rb

@@ -7,17 +7,27 @@ module ActiveRecord
       if collection.loaded?
         size = collection.size
         if size > 0
-          timestamp = collection.max_by(&timestamp_column).public_send(timestamp_column)
+          timestamp = collection.max_by(&timestamp_column)._read_attribute(timestamp_column)
         end
       else
         column_type = type_for_attribute(timestamp_column.to_s)
         column = "#{connection.quote_table_name(collection.table_name)}.#{connection.quote_column_name(timestamp_column)}"
+        select_values = "COUNT(*) AS #{connection.quote_column_name("size")}, MAX(%s) AS timestamp"
 
-        query = collection
-          .unscope(:select)
-          .select("COUNT(*) AS #{connection.quote_column_name("size")}", "MAX(#{column}) AS timestamp")
-          .unscope(:order)
-        result = connection.select_one(query)
+        if collection.limit_value || collection.offset_value
+          query = collection.spawn
+          query.select_values = [column]
+          subquery_alias = "subquery_for_cache_key"
+          subquery_column = "#{subquery_alias}.#{timestamp_column}"
+          subquery = query.arel.as(subquery_alias)
+          arel = Arel::SelectManager.new(query.engine).project(select_values % subquery_column).from(subquery)
+        else
+          query = collection.unscope(:order)
+          query.select_values = [select_values % column]
+          arel = query.arel
+        end
+
+        result = connection.select_one(arel, nil, query.bound_attributes)
 
         if result.blank?
           size = 0

data/lib/active_record/connection_adapters/abstract/connection_pool.rb

@@ -506,14 +506,16 @@ module ActiveRecord
       # +conn+: an AbstractAdapter object, which was obtained by earlier by
       # calling #checkout on this pool.
       def checkin(conn)
-        synchronize do
-          remove_connection_from_thread_cache conn
+        conn.lock.synchronize do
+          synchronize do
+            remove_connection_from_thread_cache conn
 
-          conn._run_checkin_callbacks do
-            conn.expire
-          end
+            conn._run_checkin_callbacks do
+              conn.expire
+            end
 
-          @available.add conn
+            @available.add conn
+          end
         end
       end
 

data/lib/active_record/connection_adapters/mysql2_adapter.rb

@@ -10,8 +10,6 @@ module ActiveRecord
     # Establishes a connection to the database that's used by all Active Record objects.
     def mysql2_connection(config)
       config = config.symbolize_keys
-
-      config[:username] = "root" if config[:username].nil?
       config[:flags] ||= 0
 
       if config[:flags].kind_of? Array

data/lib/active_record/connection_adapters/postgresql/referential_integrity.rb

@@ -6,50 +6,8 @@ module ActiveRecord
           true
         end
 
-        def disable_referential_integrity(&block) # :nodoc:
+        def disable_referential_integrity # :nodoc:
           if supports_disable_referential_integrity?
-            if supports_alter_constraint?
-              disable_referential_integrity_with_alter_constraint(&block)
-            else
-              disable_referential_integrity_with_disable_trigger(&block)
-            end
-          else
-            yield
-          end
-        end
-
-        private
-
-          def disable_referential_integrity_with_alter_constraint
-            tables_constraints = execute(<<-SQL).values
-              SELECT table_name, constraint_name
-              FROM information_schema.table_constraints
-              WHERE constraint_type = 'FOREIGN KEY'
-              AND is_deferrable = 'NO'
-            SQL
-
-            execute(
-              tables_constraints.collect { |table, constraint|
-                "ALTER TABLE #{quote_table_name(table)} ALTER CONSTRAINT #{constraint} DEFERRABLE"
-              }.join(";")
-            )
-
-            begin
-              transaction do
-                execute("SET CONSTRAINTS ALL DEFERRED")
-
-                yield
-              end
-            ensure
-              execute(
-                tables_constraints.collect { |table, constraint|
-                  "ALTER TABLE #{quote_table_name(table)} ALTER CONSTRAINT #{constraint} NOT DEFERRABLE"
-                }.join(";")
-              )
-            end
-          end
-
-          def disable_referential_integrity_with_disable_trigger
             original_exception = nil
 
             begin
@@ -81,7 +39,10 @@ Rails needs superuser privileges to disable referential integrity.
               end
             rescue ActiveRecord::ActiveRecordError
             end
+          else
+            yield
           end
+        end
       end
     end
   end

data/lib/active_record/connection_adapters/postgresql_adapter.rb

@@ -322,12 +322,6 @@ module ActiveRecord
         postgresql_version >= 90400
       end
 
-      def supports_alter_constraint?
-        # PostgreSQL 9.4 introduces ALTER TABLE ... ALTER CONSTRAINT but it has a bug and fixed in 9.4.2
-        # https://www.postgresql.org/docs/9.4/static/release-9-4-2.html
-        postgresql_version >= 90402
-      end
-
       def get_advisory_lock(lock_id) # :nodoc:
         unless lock_id.is_a?(Integer) && lock_id.bit_length <= 63
           raise(ArgumentError, "Postgres requires advisory lock ids to be a signed 64 bit integer")
@@ -574,7 +568,7 @@ module ActiveRecord
         end
 
         def has_default_function?(default_value, default)
-          !default_value && (%r{\w+\(.*\)|\(.*\)::\w+} === default)
+          !default_value && %r{\w+\(.*\)|\(.*\)::\w+|CURRENT_DATE|CURRENT_TIMESTAMP}.match?(default)
         end
 
         def load_additional_types(type_map, oids = nil)

data/lib/active_record/gem_version.rb

@@ -8,7 +8,7 @@ module ActiveRecord
     MAJOR = 5
     MINOR = 1
     TINY  = 0
-    PRE   = "rc2"
+    PRE   = nil
 
     STRING = [MAJOR, MINOR, TINY, PRE].compact.join(".")
   end

data/lib/active_record/railties/databases.rake

@@ -93,7 +93,7 @@ db_namespace = namespace :db do
 
     # desc 'Runs the "up" for a given migration VERSION.'
     task up: [:environment, :load_config] do
-      raise "VERSION is required" if ENV["VERSION"] && ENV["VERSION"].empty?
+      raise "VERSION is required" if !ENV["VERSION"] || ENV["VERSION"].empty?
 
       version = ENV["VERSION"] ? ENV["VERSION"].to_i : nil
       ActiveRecord::Migrator.run(:up, ActiveRecord::Tasks::DatabaseTasks.migrations_paths, version)
@@ -102,7 +102,7 @@ db_namespace = namespace :db do
 
     # desc 'Runs the "down" for a given migration VERSION.'
     task down: [:environment, :load_config] do
-      raise "VERSION is required - To go down one migration, use db:rollback" if ENV["VERSION"] && ENV["VERSION"].empty?
+      raise "VERSION is required - To go down one migration, use db:rollback" if !ENV["VERSION"] || ENV["VERSION"].empty?
       version = ENV["VERSION"] ? ENV["VERSION"].to_i : nil
       ActiveRecord::Migrator.run(:down, ActiveRecord::Tasks::DatabaseTasks.migrations_paths, version)
       db_namespace["_dump"].invoke

data/lib/active_record/relation/delegation.rb

@@ -25,6 +25,8 @@ module ActiveRecord
 
       def inherited(child_class)
         child_class.initialize_relation_delegate_cache
+        delegate = child_class.relation_delegate_class(ActiveRecord::Associations::CollectionProxy)
+        delegate.include ActiveRecord::Associations::CollectionProxy::DelegateExtending
         super
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord
 version: !ruby/object:Gem::Version
-  version: 5.1.0.rc2
+  version: 5.1.0
 platform: ruby
 authors:
 - David Heinemeier Hansson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-04-21 00:00:00.000000000 Z
+date: 2017-04-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -16,28 +16,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 5.1.0.rc2
+        version: 5.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 5.1.0.rc2
+        version: 5.1.0
 - !ruby/object:Gem::Dependency
   name: activemodel
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 5.1.0.rc2
+        version: 5.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 5.1.0.rc2
+        version: 5.1.0
 - !ruby/object:Gem::Dependency
   name: arel
   requirement: !ruby/object:Gem::Requirement
@@ -333,12 +333,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 2.2.2
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.10
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: Object-relational mapper framework (part of Rails).