activerecord 5.0.0.beta3 → 5.0.0.beta4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8926929a6df7248ea130b2445de91ba4e4933fb2
-  data.tar.gz: e25e460b0ff4541594badc944391f6a90b2d4c9f
+  metadata.gz: b7f29a643f71feaf240f7200a6e5c8dba8415d6e
+  data.tar.gz: 3b934f19c6464814f9a3c63db0684e4fcd25922c
 SHA512:
-  metadata.gz: baf2428151cb30e7a384a1a7a63fbb9da784c9a4fe23b8900ee9dc0ba7735baed85ca24b5e1dd2a75d1625e6b6e0b6378764e1694623cf292d66cc189f0fe373
-  data.tar.gz: 1069aa6eb655e0ee291af703e6d49785603662274d42cc632d95d9b39e37f2facc5d79aa4a25dd24103bd7268ba40a8c5f2af8cc1ece4e7c9d437ff584313439
+  metadata.gz: d024e027426b52314572c887bfaca668b290c1a21b6217d9221a7c5bd3d5d1857ed9e435dc007b3ab39767889d29741ba1f48891177def1d865f41d63c95ae72
+  data.tar.gz: 9fbbe193fa6100f07a9a16e61b912291bc8e42d802fb53f7d63461ac34a697166cff13b01904dffe9dcbc448e8600fac934d7a1cc307db2144680f00b5085607

data/CHANGELOG.md

@@ -1,5 +1,213 @@
+## Rails 5.0.0.beta4 (April 27, 2016) ##
+
+*   PostgreSQL: Support Expression Indexes and Operator Classes.
+
+    Example:
+
+        create_table :users do |t|
+          t.string :name
+          t.index 'lower(name) varchar_pattern_ops'
+        end
+
+    Fixes #19090, #21765, #21819, #24359.
+
+    *Ryuta Kamizono*
+
+*   MySQL: Prepared statements support.
+
+    To enable, set `prepared_statements: true` in config/database.yml.
+    Requires mysql2 0.4.4+.
+
+    *Ryuta Kamizono*
+
+*   Schema dumper: Indexes are now included in the `create_table` block
+    instead of listed afterward as separate `add_index` lines.
+
+    This tidies up schema.rb and makes it easy to read as a list of tables.
+
+    Bonus: Allows databases that support it (MySQL) to perform as single
+    `CREATE TABLE` query, no additional query per index.
+
+    *Ryuta Kamizono*
+
+*   SQLite: Fix uniqueness validation when values exceed the column limit.
+
+    SQLite doesn't impose length restrictions on strings, BLOBs, or numeric
+    values. It treats them as helpful metadata. When we truncate strings
+    before checking uniqueness, we'd miss values that exceed the column limit.
+
+    Other databases enforce length limits. A large value will pass uniqueness
+    validation since the column limit guarantees no value that long exists.
+    When we insert the row, it'll raise `ActiveRecord::ValueTooLong` as we
+    expect.
+
+    This fixes edge-case incorrect validation failures for values that exceed
+    the column limit but are identical to an existing value *when truncated*.
+    Now these will pass validation and raise an exception.
+
+    *Ryuta Kamizono*
+
+*   Raise `ActiveRecord::ValueTooLong` when column limits are exceeded.
+    Supported by MySQL and PostgreSQL adapters.
+
+    *Ryuta Kamizono*
+
+*   Migrations: `#foreign_key` respects `table_name_prefix` and `_suffix`.
+
+    *Ryuta Kamizono*
+
+*   SQLite: Force NOT NULL primary keys.
+
+    From SQLite docs: https://www.sqlite.org/lang_createtable.html
+        According to the SQL standard, PRIMARY KEY should always imply NOT
+        NULL. Unfortunately, due to a bug in some early versions, this is not
+        the case in SQLite. Unless the column is an INTEGER PRIMARY KEY or the
+        table is a WITHOUT ROWID table or the column is declared NOT NULL,
+        SQLite allows NULL values in a PRIMARY KEY column. SQLite could be
+        fixed to conform to the standard, but doing so might break legacy
+        applications. Hence, it has been decided to merely document the fact
+        that SQLite allowing NULLs in most PRIMARY KEY columns.
+
+    Now we override column options to explicitly set NOT NULL rather than rely
+    on implicit NOT NULL like MySQL and PostgreSQL adapters.
+
+    *Ryuta Kamizono*
+
+*   Added notice when a database is successfully created or dropped.
+
+    Example:
+
+        $ bin/rails db:create
+        Created database 'blog_development'
+        Created database 'blog_test'
+
+        $ bin/rails db:drop
+        Dropped database 'blog_development'
+        Dropped database 'blog_test'
+
+    Changed older notices
+    `blog_development already exists` to `Database 'blog_development' already exists`.
+    and
+    `Couldn't drop blog_development` to `Couldn't drop database 'blog_development'`.
+
+    *bogdanvlviv*
+
+*   Database comments. Annotate database objects (tables, columns, indexes)
+    with comments stored in database metadata. PostgreSQL & MySQL support.
+
+        create_table :pages, force: :cascade, comment: 'CMS content pages' do |t|
+          t.string :path,   comment: 'Path fragment of page URL used for routing'
+          t.string :locale, comment: 'RFC 3066 locale code of website language section'
+          t.index [:path, :locale], comment: 'Look up pages by URI'
+        end
+
+    *Andrey Novikov*
+
+*   Add `quoted_time` for truncating the date part of a TIME column value.
+    This fixes queries on TIME column on MariaDB, as it doesn't ignore the
+    date part of the string when it coerces to time.
+
+    *Ryuta Kamizono*
+
+*   Properly accept all valid JSON primitives in the JSON data type.
+
+    Fixes #24234
+
+    *Sean Griffin*
+
+*   MariaDB 5.3+ supports microsecond datetime precision.
+
+    *Jeremy Daer*
+
+*   Delegate `empty?`, `none?` and `one?`. Now they can be invoked as model class methods.
+
+    Example:
+
+        # When no record is found on the table
+        Topic.empty? # => true
+        Topic.none?  # => true
+
+        # When only one record is found on the table
+        Topic.one?   # => true
+
+    *Kenta Shirai*
+
+*   The form builder now properly displays values when passing a proc form
+    default to the attributes API.
+
+    Fixes #24249.
+
+    *Sean Griffin*
+
+*   The schema cache is now cleared after the `db:migrate` task is run.
+
+    Closes #24273.
+
+    *Chris Arcand*
+
+*   MySQL: strict mode respects other SQL modes rather than overwriting them.
+    Setting `strict: true` adds `STRICT_ALL_TABLES` to `sql_mode`. Setting
+    `strict: false` removes `STRICT_TRANS_TABLES`, `STRICT_ALL_TABLES`, and
+    `TRADITIONAL` from `sql_mode`.
+
+    *Ryuta Kamizono*
+
+*   Execute default_scope defined by abstract class in the context of subclass.
+
+    Fixes #23413.
+    Fixes #10658.
+
+    *Mehmet Emin İNAÇ*
+
+*   Fix an issue when preloading associations with extensions.
+    Previously every association with extension methods was transformed into an
+    instance dependent scope. This is no longer the case.
+
+    Fixes #23934.
+
+    *Yves Senn*
+
+*   Deprecate `{insert|update|delete}_sql` in `DatabaseStatements`.
+    Use the `{insert|update|delete}` public methods instead.
+
+    *Ryuta Kamizono*
+
+*   Added a configuration option to have active record raise an ArgumentError
+    if the order or limit is ignored in a batch query, rather than logging a
+    warning message.
+
+    *Scott Ringwelski*
+
+*   Honour the order of the joining model in a `has_many :through` association when eager loading.
+
+    Example:
+
+    The below will now follow the order of `by_lines` when eager loading `authors`.
+
+        class Article < ActiveRecord::Base
+          has_many :by_lines, -> { order(:position) }
+          has_many :authors, through: :by_lines
+        end
+
+    Fixes #17864.
+
+    *Yasyf Mohamedali*, *Joel Turkel*
+
+*   Ensure that the Suppressor runs before validations.
+
+    This moves the suppressor up to be run before validations rather than after
+    validations. There's no reason to validate a record you aren't planning on saving.
+
+    *Eileen M. Uchitelle*
+
 ## Rails 5.0.0.beta3 (February 24, 2016) ##
 
+*   Save many-to-many objects based on association primary key.
+
+    Fixes #20995.
+
+    *himesh-r*
+
 *   Ensure that mutations of the array returned from `ActiveRecord::Relation#to_a`
     do not affect the original relation, by returning a duplicate array each time.
 
@@ -53,7 +261,6 @@
 
     *Bogdan Gusiev*
 
-
 *   Allow `joins` to be unscoped.
 
     Fixes #13775.
@@ -182,6 +389,21 @@
 
 ## Rails 5.0.0.beta1 (December 18, 2015) ##
 
+*   Limit record touching to once per transaction.
+
+    If you have a parent/grand-parent relation like:
+
+        Comment belongs_to :message, touch: true
+        Message belongs_to :project, touch: true
+        Project belongs_to :account, touch: true
+
+    When the lowest entry(`Comment`) is saved, now, it won't repeat the touch
+    call multiple times for the parent records.
+
+    Related #18606.
+
+    *arthurnn*
+
 *   Order the result of `find(ids)` to match the passed array, if the relation
     has no explicit order defined.
 
@@ -456,13 +678,13 @@
 *   Add option to index errors in nested attributes
 
     For models which have nested attributes, errors within those models will
-    now be indexed if :index_errors is specified when defining a
+    now be indexed if `:index_errors` is specified when defining a
     has_many relationship, or if its set in the global config.
 
     Example:
 
         class Guitar < ActiveRecord::Base
-          has_many :tuning_pegs
+          has_many :tuning_pegs, index_errors: true
           accepts_nested_attributes_for :tuning_pegs
         end
 
@@ -1340,11 +1562,6 @@
 
     *Hyonjee Joo*
 
-*   Deprecate passing of `start` value to `find_in_batches` and `find_each`
-    in favour of `begin_at` value.
-
-    *Vipul A M*
-
 *   Add `foreign_key_exists?` method.
 
     *Tõnis Simo*

data/examples/performance.rb

@@ -1,4 +1,3 @@
-require File.expand_path('../../../load_paths', __FILE__)
 require "active_record"
 require 'benchmark/ips'
 

data/examples/simple.rb

@@ -1,4 +1,3 @@
-require File.expand_path('../../../load_paths', __FILE__)
 require 'active_record'
 
 class Person < ActiveRecord::Base

data/lib/active_record.rb

@@ -137,7 +137,6 @@ module ActiveRecord
 
     eager_autoload do
       autoload :AbstractAdapter
-      autoload :ConnectionManagement, "active_record/connection_adapters/abstract/connection_pool"
     end
   end
 

data/lib/active_record/associations.rb

@@ -318,7 +318,7 @@ module ActiveRecord
     #   create_other(attributes={})       |     X      |              |    X
     #   create_other!(attributes={})      |     X      |              |    X
     #
-    # ===Collection associations (one-to-many / many-to-many)
+    # === Collection associations (one-to-many / many-to-many)
     #                                     |       |          | has_many
     #   generated methods                 | habtm | has_many | :through
     #   ----------------------------------+-------+----------+----------
@@ -504,7 +504,7 @@ module ActiveRecord
     #
     # == Customizing the query
     #
-    # \Associations are built from <tt>Relation</tt>s, and you can use the Relation syntax
+    # \Associations are built from <tt>Relation</tt> objects, and you can use the Relation syntax
     # to customize them. For example, to add a condition:
     #
     #   class Blog < ActiveRecord::Base
@@ -1326,7 +1326,8 @@ module ActiveRecord
       #   Specifies type of the source association used by #has_many <tt>:through</tt> queries where the source
       #   association is a polymorphic #belongs_to.
       # [:validate]
-      #   If +false+, don't validate the associated objects when saving the parent object. true by default.
+      #   When set to +true+, validates new objects added to association when saving the parent object. +true+ by default.
+      #   If you want to ensure associated objects are revalidated on every update, use +validates_associated+.
       # [:autosave]
       #   If true, always save the associated objects or destroy them if marked for destruction,
       #   when saving the parent object. If false, never save or destroy the associated objects.
@@ -1456,7 +1457,8 @@ module ActiveRecord
       #   Specifies type of the source association used by #has_one <tt>:through</tt> queries where the source
       #   association is a polymorphic #belongs_to.
       # [:validate]
-      #   If +false+, don't validate the associated object when saving the parent object. +false+ by default.
+      #   When set to +true+, validates new objects added to association when saving the parent object. +false+ by default.
+      #   If you want to ensure associated objects are revalidated on every update, use +validates_associated+.
       # [:autosave]
       #   If true, always save the associated object or destroy it if marked for destruction,
       #   when saving the parent object. If false, never save or destroy the associated object.
@@ -1580,7 +1582,8 @@ module ActiveRecord
       #   Note: If you've enabled the counter cache, then you may want to add the counter cache attribute
       #   to the +attr_readonly+ list in the associated classes (e.g. <tt>class Post; attr_readonly :comments_count; end</tt>).
       # [:validate]
-      #   If +false+, don't validate the associated objects when saving the parent object. +false+ by default.
+      #   When set to +true+, validates new objects added to association when saving the parent object. +false+ by default.
+      #   If you want to ensure associated objects are revalidated on every update, use +validates_associated+.
       # [:autosave]
       #   If true, always save the associated object or destroy it if marked for destruction, when
       #   saving the parent object.
@@ -1766,7 +1769,8 @@ module ActiveRecord
       #   So if a Person class makes a #has_and_belongs_to_many association to Project,
       #   the association will use "project_id" as the default <tt>:association_foreign_key</tt>.
       # [:validate]
-      #   If +false+, don't validate the associated objects when saving the parent object. +true+ by default.
+      #   When set to +true+, validates new objects added to association when saving the parent object. +true+ by default.
+      #   If you want to ensure associated objects are revalidated on every update, use +validates_associated+.
       # [:autosave]
       #   If true, always save the associated objects or destroy them if marked for destruction, when
       #   saving the parent object.

data/lib/active_record/associations/association.rb

@@ -257,7 +257,7 @@ module ActiveRecord
 
         # Returns true if statement cache should be skipped on the association reader.
         def skip_statement_cache?
-          reflection.scope_chain.any?(&:any?) ||
+          reflection.has_scope? ||
             scope.eager_loading? ||
             klass.scope_attributes? ||
             reflection.source_reflection.active_record.default_scopes.any?

data/lib/active_record/associations/builder/collection_association.rb

@@ -70,7 +70,11 @@ module ActiveRecord::Associations::Builder # :nodoc:
 
     def self.wrap_scope(scope, mod)
       if scope
-        proc { |owner| instance_exec(owner, &scope).extending(mod) }
+        if scope.arity > 0
+          proc { |owner| instance_exec(owner, &scope).extending(mod) }
+        else
+          proc { instance_exec(&scope).extending(mod) }
+        end
       else
         proc { extending(mod) }
       end

data/lib/active_record/associations/join_dependency.rb

@@ -228,7 +228,7 @@ module ActiveRecord
 
       def find_reflection(klass, name)
         klass._reflect_on_association(name) or
-          raise ConfigurationError, "Association named '#{ name }' was not found on #{ klass.name }; perhaps you misspelled it?"
+          raise ConfigurationError, "Can't join '#{ klass.name }' to association named '#{ name }'; perhaps you misspelled it?"
       end
 
       def build(associations, base_klass)

data/lib/active_record/associations/preloader.rb

@@ -184,6 +184,7 @@ module ActiveRecord
         def self.new(klass, owners, reflection, preload_scope); self; end
         def self.run(preloader); end
         def self.preloaded_records; []; end
+        def self.owners; []; end
       end
 
       # Returns a class containing the logic needed to load preload the data

data/lib/active_record/associations/preloader/through_association.rb

@@ -38,12 +38,7 @@ module ActiveRecord
             }
           end
 
-          record_offset = {}
-          @preloaded_records.each_with_index do |record,i|
-            record_offset[record] = i
-          end
-
-          through_records.each_with_object({}) { |(lhs,center),records_by_owner|
+          through_records.each_with_object({}) do |(lhs,center), records_by_owner|
             pl_to_middle = center.group_by { |record| middle_to_pl[record] }
 
             records_by_owner[lhs] = pl_to_middle.flat_map do |pl, middles|
@@ -53,13 +48,25 @@ module ActiveRecord
                 target_records_from_association(association)
               }.compact
 
-              rhs_records.sort_by { |rhs| record_offset[rhs] }
+              # Respect the order on `reflection_scope` if it exists, else use the natural order.
+              if reflection_scope.values[:order].present?
+                @id_map ||= id_to_index_map @preloaded_records
+                rhs_records.sort_by { |rhs| @id_map[rhs] }
+              else
+                rhs_records
+              end
             end
-          }
+          end
         end
 
         private
 
+        def id_to_index_map(ids)
+          id_map = {}
+          ids.each_with_index { |id, index| id_map[id] = index }
+          id_map
+        end
+
         def reset_association(owners, association_name)
           should_reset = (through_scope != through_reflection.klass.unscoped) ||
              (reflection.options[:source_type] && through_reflection.collection?)

data/lib/active_record/attribute/user_provided_default.rb

@@ -4,20 +4,25 @@ module ActiveRecord
   class Attribute # :nodoc:
     class UserProvidedDefault < FromUser # :nodoc:
       def initialize(name, value, type, database_default)
+        @user_provided_value = value
         super(name, value, type, database_default)
       end
 
-      def type_cast(value)
-        if value.is_a?(Proc)
-          super(value.call)
+      def value_before_type_cast
+        if user_provided_value.is_a?(Proc)
+          @memoized_value_before_type_cast ||= user_provided_value.call
         else
-          super
+          @user_provided_value
         end
       end
 
       def with_type(type)
-        self.class.new(name, value_before_type_cast, type, original_attribute)
+        self.class.new(name, user_provided_value, type, original_attribute)
       end
+
+      protected
+
+      attr_reader :user_provided_value
     end
   end
 end