activerecord 4.2.0.beta1 → 4.2.0.beta2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 57b65593b6cdbb77e81c448af2b0e2c0f0776680
-  data.tar.gz: cea842a9261ae06b3a9ee0c5d1e276743c496457
+  metadata.gz: 211710d5cc673b4cc8739c6192094e48c7d8cea7
+  data.tar.gz: d5ed042f529bb6cea7663f61dbef6220803f1bdb
 SHA512:
-  metadata.gz: a95a9d12073d982417b4f08f02ac3492545e5096a3bea0b9400c933738709010f763a0961914bf0fa135013a4d315eb50efb38091d7cacf90f71c6c8bf1699b4
-  data.tar.gz: 345909347c2549c3be866f3cb335e561acafde1a26682705dd90d0d8022875a3fe19871e1402a43717dc28b2405a2450d224f39620ae7dd2a928bf76b0017af3
+  metadata.gz: 56a7041e9c7234e5be445391024eebd82ad24addd37a9d33bb44c76ed34515be23a3387e44065d287bbf100d79f0e336d479bb72d06960891b0cec044a599985
+  data.tar.gz: f2c89b0e109a6e52a6e8be18b2fd060abc8733348bdb65182fa11b3e0d924bcb400e34855c7419e6900071eed9111e5da56799f6714e1866845a81f8cb9d1278

data/CHANGELOG.md

@@ -1,17 +1,123 @@
-*   Fixed the `Relation#exists?` to work with polymorphic associations.
+*   Honor overridden `rack.test` in Rack environment for the connection
+    management middlware.
+
+    *Simon Eskildsen*
+
+*   Add a truncate method to the connection.
+
+    *Aaron Patterson*
+
+*   Don't autosave unchanged has_one through records.
+
+    *Alan Kennedy*, *Steve Parrington*
+
+*   Do not dump foreign keys for ignored tables.
+
+    *Yves Senn*
+
+*   PostgreSQL adapter correctly dumps foreign keys targeting tables
+    outside the schema search path.
+
+    Fixes #16907.
+
+    *Matthew Draper*, *Yves Senn*
+
+*   When a thread is killed, rollback the active transaction, instead of
+    committing it during the stack unwind. Previously, we could commit half-
+    completed work. This fix only works for Ruby 2.0+; on 1.9, we can't
+    distinguish a thread kill from an ordinary non-local (block) return, so must
+    default to committing.
+
+    *Chris Hanks*
+
+*   A `NullRelation` should represent nothing. This fixes a bug where
+    `Comment.where(post_id: Post.none)` returned a non-empty result.
+
+    Fixes #15176.
+
+    *Matthew Draper*, *Yves Senn*
+
+*   Include default column limits in schema.rb. Allows defaults to be changed
+    in the future without affecting old migrations that assumed old defaults.
+
+    *Jeremy Kemper*
+
+*   MySQL: schema.rb now includes TEXT and BLOB column limits.
+
+    *Jeremy Kemper*
+
+*   MySQL: correct LONGTEXT and LONGBLOB limits from 2GB to their true 4GB.
+
+    *Jeremy Kemper*
+
+*   SQLite3Adapter now checks for views in `table_exists?`. Fixes #14041.
+
+    *Girish Sonawane*
+
+*   Introduce `connection.supports_views?` to check whether the current adapter
+    has support for SQL views. Connection adapters should define this method.
+
+    *Yves Senn*
+
+*   Allow included modules to override association methods.
+
+    Fixes #16684.
+
+    *Yves Senn*
+
+*   Schema loading rake tasks (like `db:schema:load` and `db:setup`) maintain
+    the database connection to the current environment.
+
+    Fixes #16757.
+
+    *Joshua Cody*, *Yves Senn*
+
+*   MySQL: set the connection collation along with the charset.
+
+    Sets the connection collation to the database collation configured in
+    database.yml. Otherwise, `SET NAMES utf8mb4` will use the default
+    collation for that charset (utf8mb4_general_ci) when you may have chosen
+    a different collation, like utf8mb4_unicode_ci.
+
+    This only applies to literal string comparisons, not column values, so it
+    is unlikely to affect you.
+
+    *Jeremy Kemper*
+
+*   `default_sequence_name` from the PostgreSQL adapter returns a `String`.
+
+    *Yves Senn*
+
+*   Fixed a regression where whitespaces were stripped from DISTINCT queries in
+    PostgreSQL.
+
+    *Agis Anastasopoulos*
+
+    Fixes #16623.
+
+*   Fix has_many :through relation merging failing when dynamic conditions are
+    passed as a lambda with an arity of one.
+
+    Fixes #16128.
+
+    *Agis Anastasopoulos*
+
+*   Fixed `Relation#exists?` to work with polymorphic associations.
 
     Fixes #15821.
 
     *Kassio Borges*
 
-*   Currently, Active Record will rescue any errors raised within
-    after_rollback/after_create callbacks and print them to the logs. Next versions of rails
-    will not rescue those errors anymore, and just bubble them up, as the other callbacks.
+*   Currently, Active Record rescues any errors raised within
+    `after_rollback`/`after_create` callbacks and prints them to the logs.
+    Future versions of Rails will not rescue these errors anymore and
+    just bubble them up like the other callbacks.
+
+    This commit adds an opt-in flag to enable not rescuing the errors.
 
-    This adds a opt-in flag to enable that behaviour, of not rescuing the errors.
     Example:
 
-        # For not swallow errors in after_commit/after_rollback callbacks.
+        # Do not swallow errors in after_commit/after_rollback callbacks.
         config.active_record.raise_in_transactional_callbacks = true
 
     Fixes #13460.
@@ -31,9 +137,9 @@
 
     *Sean Griffin*
 
-*   Fix regression on after_commit that didnt fire when having nested transactions.
+*   Fix regression on `after_commit` that did not fire with nested transactions.
 
-    Fixes #16425
+    Fixes #16425.
 
     *arthurnn*
 
@@ -67,9 +173,9 @@
 
 *   Define `id_was` to get the previous value of the primary key.
 
-    Currently when we call id_was and we have a custom primary key name
+    Currently when we call `id_was` and we have a custom primary key name,
     Active Record will return the current value of the primary key. This
-    make impossible to correctly do an update operation if you change the
+    makes it impossible to correctly do an update operation if you change the
     id.
 
     Fixes #16413.
@@ -101,7 +207,7 @@
 
     *Eileen M. Uchtitelle*, *Aaron Patterson*
 
-*   No verbose backtrace by db:drop when database does not exist.
+*   No verbose backtrace by `db:drop` when database does not exist.
 
     Fixes #16295.
 
@@ -146,7 +252,7 @@
 
     *Stefan Kanev*
 
-*   Dont swallow errors on compute_type when having a bad alias_method on
+*   Do not swallow errors on `compute_type` when having a bad `alias_method` on
     a class.
 
     *arthurnn*
@@ -229,7 +335,7 @@
 
     *Eileen M. Uchitelle, Aaron Patterson*
 
-*   Avoid type casting boolean and ActiveSupport::Duration values to numeric
+*   Avoid type casting boolean and `ActiveSupport::Duration` values to numeric
     values for string columns. Otherwise, in some database, the string column
     values will be coerced to a numeric allowing false or 0.seconds match any
     string starting with a non-digit.
@@ -260,8 +366,8 @@
 
     *Abdelkader Boudih*
 
-*   Move 'dependent: :destroy' handling for 'belongs_to'
-    from 'before_destroy' to 'after_destroy' callback chain
+*   Move 'dependent: :destroy' handling for `belongs_to`
+    from `before_destroy` to `after_destroy` callback chain
 
     Fixes #12380.
 
@@ -269,8 +375,9 @@
 
 *   Detect in-place modifications on String attributes.
 
-    Before this change user have to mark the attribute as changed to it be persisted
-    in the database. Now it is not required anymore.
+    Before this change, an attribute modified in-place had to be marked as
+    changed in order for it to be persisted in the database. Now it is no longer
+    required.
 
     Before:
 
@@ -350,14 +457,6 @@
 
     *Sean Griffin*
 
-*   `has_many :through` associations will no longer save the through record
-    twice when added in an `after_create` callback defined before the
-    associations.
-
-    Fixes #3798.
-
-    *Sean Griffin*
-
 *   Detect in-place modifications of PG array types
 
     *Sean Griffin*
@@ -390,7 +489,7 @@
 
     *Sean Griffin*
 
-*   Pluck now works when selecting columns from different tables with the same
+*   `Pluck` now works when selecting columns from different tables with the same
     name.
 
     Fixes #15649.
@@ -457,7 +556,7 @@
 
     *Sean Griffin*
 
-*   Implemented ActiveRecord::Base#pretty_print to work with PP.
+*   Implemented `ActiveRecord::Base#pretty_print` to work with PP.
 
     *Ethan*
 
@@ -498,16 +597,16 @@
 
     *Arun Agrawal*
 
-*   Fix redefine a has_and_belongs_to_many inside inherited class
-    Fixing regression case, where redefining the same has_an_belongs_to_many
+*   Fix redefine a `has_and_belongs_to_many` inside inherited class
+    Fixing regression case, where redefining the same `has_and_belongs_to_many`
     definition into a subclass would raise.
 
     Fixes #14983.
 
     *arthurnn*
 
-*   Fix has_and_belongs_to_many public reflection.
-    When defining a has_and_belongs_to_many, internally we convert that to two has_many.
+*   Fix `has_and_belongs_to_many` public reflection.
+    When defining a `has_and_belongs_to_many`, internally we convert that to two has_many.
     But as `reflections` is a public API, people expect to see the right macro.
 
     Fixes #14682.
@@ -544,7 +643,7 @@
 
     *Brock Trappitt*
 
-*   Fixed the inferred table name of a has_and_belongs_to_many auxiliar
+*   Fixed the inferred table name of a `has_and_belongs_to_many` auxiliar
     table inside a schema.
 
     Fixes #14824.
@@ -588,7 +687,7 @@
 
     *Aaron Nelson*
 
-*   Fix how to calculate associated class name when using namespaced has_and_belongs_to_many
+*   Fix how to calculate associated class name when using namespaced `has_and_belongs_to_many`
     association.
 
     Fixes #14709.
@@ -658,7 +757,7 @@
 
 *   Fixed has_and_belongs_to_many's CollectionAssociation size calculation.
 
-    has_and_belongs_to_many should fall back to using the normal CollectionAssociation's
+    `has_and_belongs_to_many` should fall back to using the normal CollectionAssociation's
     size calculation if the collection is not cached or loaded.
 
     Fixes #14913, #14914.
@@ -718,7 +817,7 @@
 
     *Timur Alperovich*
 
-*   Give ActiveRecord::PredicateBuilder private methods the privacy they deserve.
+*   Give `ActiveRecord::PredicateBuilder` private methods the privacy they deserve.
 
     *Hector Satre*
 
@@ -774,7 +873,7 @@
 
     *Kuldeep Aggarwal*
 
-*   Fixed has_many association to make it support irregular inflections.
+*   Fixed `has_many` association to make it support irregular inflections.
 
     Fixes #8928.
 
@@ -888,7 +987,7 @@
 
 *   `to_sql` on an association now matches the query that is actually executed, where it
     could previously have incorrectly accrued additional conditions (e.g. as a result of
-    a previous query). CollectionProxy now always defers to the association scope's
+    a previous query). `CollectionProxy` now always defers to the association scope's
     `arel` method so the (incorrect) inherited one should be entirely concealed.
 
     Fixes #14003.
@@ -1119,7 +1218,7 @@
 
     The current solution of incrementing the beginning is not correct and is now
     deprecated. For subtypes where we don't know how to increment (e.g. `#succ`
-    is not defined) it will raise an ArgumentException for ranges with excluding
+    is not defined) it will raise an `ArgumentException` for ranges with excluding
     beginnings.
 
     *Yves Senn*

data/lib/active_record/associations.rb

@@ -447,9 +447,11 @@ module ActiveRecord
     #
     # Possible callbacks are: +before_add+, +after_add+, +before_remove+ and +after_remove+.
     #
-    # Should any of the +before_add+ callbacks throw an exception, the object does not get
-    # added to the collection. Same with the +before_remove+ callbacks; if an exception is
-    # thrown the object doesn't get removed.
+    # If any of the +before_add+ callbacks throw an exception, the object will not be
+    # added to the collection.
+    #
+    # Similarly, if any of the +before_remove+ callbacks throw an exception, the object
+    # will not be removed from the collection.
     #
     # == Association extensions
     #
@@ -647,7 +649,7 @@ module ActiveRecord
     #     belongs_to :commenter
     #   end
     #
-    # When using nested association, you will not be able to modify the association because there
+    # When using a nested association, you will not be able to modify the association because there
     # is not enough information to know what modification to make. For example, if you tried to
     # add a <tt>Commenter</tt> in the example above, there would be no way to tell how to set up the
     # intermediate <tt>Post</tt> and <tt>Comment</tt> objects.
@@ -717,7 +719,7 @@ module ActiveRecord
     # == Eager loading of associations
     #
     # Eager loading is a way to find objects of a certain class and a number of named associations.
-    # This is one of the easiest ways of to prevent the dreaded N+1 problem in which fetching 100
+    # It is one of the easiest ways to prevent the dreaded N+1 problem in which fetching 100
     # posts that each need to display their author triggers 101 database queries. Through the
     # use of eager loading, the number of queries will be reduced from 101 to 2.
     #
@@ -749,16 +751,16 @@ module ActiveRecord
     #   Post.includes(:author, :comments).each do |post|
     #
     # This will load all comments with a single query. This reduces the total number of queries
-    # to 3. More generally the number of queries will be 1 plus the number of associations
+    # to 3. In general, the number of queries will be 1 plus the number of associations
     # named (except if some of the associations are polymorphic +belongs_to+ - see below).
     #
     # To include a deep hierarchy of associations, use a hash:
     #
-    #   Post.includes(:author, {comments: {author: :gravatar}}).each do |post|
+    #   Post.includes(:author, { comments: { author: :gravatar } }).each do |post|
     #
-    # That'll grab not only all the comments but all their authors and gravatar pictures.
-    # You can mix and match symbols, arrays and hashes in any combination to describe the
-    # associations you want to load.
+    # The above code will load all the comments and all of their associated
+    # authors and gravatars. You can mix and match any combination of symbols,
+    # arrays, and hashes to retrieve the associations you want to load.
     #
     # All of this power shouldn't fool you into thinking that you can pull out huge amounts
     # of data with no performance penalty just because you've reduced the number of queries.
@@ -767,8 +769,8 @@ module ActiveRecord
     # cut down on the number of queries in a situation as the one described above.
     #
     # Since only one table is loaded at a time, conditions or orders cannot reference tables
-    # other than the main one. If this is the case Active Record falls back to the previously
-    # used LEFT OUTER JOIN based strategy. For example
+    # other than the main one. If this is the case, Active Record falls back to the previously
+    # used LEFT OUTER JOIN based strategy. For example:
     #
     #   Post.includes([:author, :comments]).where(['comments.approved = ?', true])
     #
@@ -1133,6 +1135,31 @@ module ActiveRecord
       # * <tt>Firm#clients.create!</tt> (similar to <tt>c = Client.new("firm_id" => id); c.save!</tt>)
       # The declaration can also include an +options+ hash to specialize the behavior of the association.
       #
+      # === Scopes
+      #
+      # You can pass a second argument +scope+ as a callable (i.e. proc or
+      # lambda) to retrieve a specific set of records or customize the generated
+      # query when you access the associated collection.
+      #
+      # Scope examples:
+      #   has_many :comments, -> { where(author_id: 1) }
+      #   has_many :employees, -> { joins(:address) }
+      #   has_many :posts, ->(post) { where("max_post_length > ?", post.length) }
+      #
+      # === Extensions
+      #
+      # The +extension+ argument allows you to pass a block into a has_many
+      # association. This is useful for adding new finders, creators and other
+      # factory-type methods to be used as part of the association.
+      #
+      # Extension examples:
+      #   has_many :employees do
+      #     def find_or_create_by_name(name)
+      #       first_name, last_name = name.split(" ", 2)
+      #       find_or_create_by(first_name: first_name, last_name: last_name)
+      #     end
+      #   end
+      #
       # === Options
       # [:class_name]
       #   Specify the class name of the association. Use it only if that name can't be inferred
@@ -1144,7 +1171,7 @@ module ActiveRecord
       #   of this class in lower-case and "_id" suffixed. So a Person class that makes a +has_many+
       #   association will use "person_id" as the default <tt>:foreign_key</tt>.
       # [:primary_key]
-      #   Specify the method that returns the primary key used for the association. By default this is +id+.
+      #   Specify the name of the column to use as the primary key for the association. By default this is +id+.
       # [:dependent]
       #   Controls what happens to the associated objects when
       #   their owner is destroyed. Note that these are implemented as
@@ -1257,6 +1284,17 @@ module ActiveRecord
       # * <tt>Account#create_beneficiary</tt> (similar to <tt>b = Beneficiary.new("account_id" => id); b.save; b</tt>)
       # * <tt>Account#create_beneficiary!</tt> (similar to <tt>b = Beneficiary.new("account_id" => id); b.save!; b</tt>)
       #
+      # === Scopes
+      #
+      # You can pass a second argument +scope+ as a callable (i.e. proc or
+      # lambda) to retrieve a specific record or customize the generated query
+      # when you access the associated object.
+      #
+      # Scope examples:
+      #   has_one :author, -> { where(comment_id: 1) }
+      #   has_one :employer, -> { joins(:company) }
+      #   has_one :dob, ->(dob) { where("Date.new(2000, 01, 01) > ?", dob) }
+      #
       # === Options
       #
       # The declaration can also include an +options+ hash to specialize the behavior of the association.
@@ -1554,6 +1592,33 @@ module ActiveRecord
       # * <tt>Developer#projects.create</tt> (similar to <tt>c = Project.new("developer_id" => id); c.save; c</tt>)
       # The declaration may include an +options+ hash to specialize the behavior of the association.
       #
+      # === Scopes
+      #
+      # You can pass a second argument +scope+ as a callable (i.e. proc or
+      # lambda) to retrieve a specific set of records or customize the generated
+      # query when you access the associated collection.
+      #
+      # Scope examples:
+      #   has_and_belongs_to_many :projects, -> { includes :milestones, :manager }
+      #   has_and_belongs_to_many :categories, ->(category) {
+      #     where("default_category = ?", category.name)
+      #   }
+      #
+      # === Extensions
+      #
+      # The +extension+ argument allows you to pass a block into a
+      # has_and_belongs_to_many association. This is useful for adding new
+      # finders, creators and other factory-type methods to be used as part of
+      # the association.
+      #
+      # Extension examples:
+      #   has_and_belongs_to_many :contractors do
+      #     def find_or_create_by_name(name)
+      #       first_name, last_name = name.split(" ", 2)
+      #       find_or_create_by(first_name: first_name, last_name: last_name)
+      #     end
+      #   end
+      #
       # === Options
       #
       # [:class_name]