activerecord 1.12.2 → 1.13.0

data/test/readonly_test.rb

@@ -1,12 +1,19 @@
 require 'abstract_unit'
+require 'fixtures/post'
+require 'fixtures/comment'
 require 'fixtures/developer'
 require 'fixtures/project'
 
+# Dummy class methods to test implicit association scoping.
+def Comment.foo() find :first end
+def Project.foo() find :first end
+
+
 class ReadOnlyTest < Test::Unit::TestCase
-  fixtures :developers, :projects, :developers_projects
+  fixtures :posts, :comments, :developers, :projects, :developers_projects
 
   def test_cant_save_readonly_record
-    dev = Developer.find(:first)
+    dev = Developer.find(1)
     assert !dev.readonly?
 
     dev.readonly!
@@ -21,21 +28,74 @@ class ReadOnlyTest < Test::Unit::TestCase
     assert_raise(ActiveRecord::ReadOnlyRecord) { dev.save! }
   end
 
+
   def test_find_with_readonly_option
     Developer.find(:all).each { |d| assert !d.readonly? }
     Developer.find(:all, :readonly => false).each { |d| assert !d.readonly? }
     Developer.find(:all, :readonly => true).each { |d| assert d.readonly? }
   end
 
+
   def test_find_with_joins_option_implies_readonly
-    Developer.find(:all, :joins => '').each { |d| assert d.readonly? }
-    Developer.find(:all, :joins => '', :readonly => false).each { |d| assert !d.readonly? }
+    # Blank joins don't count.
+    Developer.find(:all, :joins => '  ').each { |d| assert !d.readonly? }
+    Developer.find(:all, :joins => '  ', :readonly => false).each { |d| assert !d.readonly? }
+
+    # Others do.
+    Developer.find(:all, :joins => ', projects').each { |d| assert d.readonly? }
+    Developer.find(:all, :joins => ', projects', :readonly => false).each { |d| assert !d.readonly? }
   end
 
+
   def test_habtm_find_readonly
-    dev = Developer.find(:first)
+    dev = Developer.find(1)
+    assert !dev.projects.empty?
     dev.projects.each { |p| assert !p.readonly? }
     dev.projects.find(:all) { |p| assert !p.readonly? }
     dev.projects.find(:all, :readonly => true) { |p| assert p.readonly? }
   end
+
+  def test_has_many_find_readonly
+    post = Post.find(1)
+    assert !post.comments.empty?
+    post.comments.each { |r| assert !r.readonly? }
+    post.comments.find(:all) { |r| assert !r.readonly? }
+    post.comments.find(:all, :readonly => true) { |r| assert r.readonly? }
+  end
+
+
+  def test_readonly_scoping
+    Post.with_scope(:find => { :conditions => '1=1' }) do 
+      assert !Post.find(1).readonly?
+      assert Post.find(1, :readonly => true).readonly?
+      assert !Post.find(1, :readonly => false).readonly?
+    end
+
+    Post.with_scope(:find => { :joins => '   ' }) do 
+      assert !Post.find(1).readonly?
+      assert Post.find(1, :readonly => true).readonly?
+      assert !Post.find(1, :readonly => false).readonly?
+    end
+
+    # Oracle barfs on this because the join includes unqualified and
+    # conflicting column names
+    unless current_adapter?(:OCIAdapter)
+      Post.with_scope(:find => { :joins => ', developers' }) do 
+        assert Post.find(1).readonly?
+        assert Post.find(1, :readonly => true).readonly?
+        assert !Post.find(1, :readonly => false).readonly?
+      end
+    end
+
+    Post.with_scope(:find => { :readonly => true }) do
+      assert Post.find(1).readonly?
+      assert Post.find(1, :readonly => true).readonly?
+      assert !Post.find(1, :readonly => false).readonly?
+    end
+  end
+
+  def test_association_collection_method_missing_scoping_not_readonly
+    assert !Developer.find(1).projects.foo.readonly?
+    assert !Post.find(1).comments.foo.readonly?
+  end
 end

data/test/validations_test.rb

@@ -76,8 +76,16 @@ class ValidationsTest < Test::Unit::TestCase
   end
 
   def test_invalid_record_exception
-    r = Reply.new
-    assert_raises(ActiveRecord::RecordInvalid) { r.save! }
+    assert_raises(ActiveRecord::RecordInvalid) { Reply.create! }
+    assert_raises(ActiveRecord::RecordInvalid) { Reply.new.save! }
+
+    begin
+      r = Reply.new
+      r.save!
+      flunk
+    rescue ActiveRecord::RecordInvalid => invalid
+      assert_equal r, invalid.record
+    end
   end
 
   def test_single_error_per_attr_iteration

metadata

@@ -3,8 +3,8 @@ rubygems_version: 0.8.11
 specification_version: 1
 name: activerecord
 version: !ruby/object:Gem::Version 
-  version: 1.12.2
-date: 2005-10-26 00:00:00 +02:00
+  version: 1.13.0
+date: 2005-11-07 00:00:00 +01:00
 summary: Implements the ActiveRecord pattern for ORM.
 require_paths: 
   - lib
@@ -98,6 +98,7 @@ files:
   - test/ar_schema_test.rb
   - test/association_callbacks_test.rb
   - test/association_inheritance_reload.rb
+  - test/associations_extensions_test.rb
   - test/associations_go_eager_test.rb
   - test/associations_test.rb
   - test/base_test.rb
@@ -105,9 +106,9 @@ files:
   - test/callbacks_test.rb
   - test/class_inheritable_attributes_test.rb
   - test/column_alias_test.rb
-  - test/conditions_scoping_test.rb
   - test/connections
   - test/copy_table_sqlite.rb
+  - test/debug.log
   - test/deprecated_associations_test.rb
   - test/deprecated_finder_test.rb
   - test/finder_test.rb
@@ -116,6 +117,7 @@ files:
   - test/inheritance_test.rb
   - test/lifecycle_test.rb
   - test/locking_test.rb
+  - test/method_scoping_test.rb
   - test/migration_test.rb
   - test/mixin_nested_set_test.rb
   - test/mixin_test.rb
@@ -178,11 +180,14 @@ files:
   - test/fixtures/developers_projects.yml
   - test/fixtures/entrant.rb
   - test/fixtures/entrants.yml
+  - test/fixtures/fixture_database.sqlite
+  - test/fixtures/fixture_database_2.sqlite
   - test/fixtures/fk_test_has_fk.yml
   - test/fixtures/fk_test_has_pk.yml
   - test/fixtures/flowers.jpg
   - test/fixtures/keyboard.rb
   - test/fixtures/migrations
+  - test/fixtures/migrations_with_duplicate
   - test/fixtures/mixin.rb
   - test/fixtures/mixins.yml
   - test/fixtures/movie.rb
@@ -240,6 +245,10 @@ files:
   - test/fixtures/migrations/1_people_have_last_names.rb
   - test/fixtures/migrations/2_we_need_reminders.rb
   - test/fixtures/migrations/3_innocent_jointable.rb
+  - test/fixtures/migrations_with_duplicate/1_people_have_last_names.rb
+  - test/fixtures/migrations_with_duplicate/2_we_need_reminders.rb
+  - test/fixtures/migrations_with_duplicate/3_foo.rb
+  - test/fixtures/migrations_with_duplicate/3_innocent_jointable.rb
   - test/fixtures/naked/csv
   - test/fixtures/naked/yml
   - test/fixtures/naked/csv/accounts.csv
@@ -270,5 +279,5 @@ dependencies:
         - 
           - "="
           - !ruby/object:Gem::Version 
-            version: 1.2.2
+            version: 1.2.3
       version: